Hi Mark and Boyd,
Thanks for your time on this issue.
In my opinion, It 's better not to apply this patch.
I will post patch with changing size in sc7180.dtsi file.
On 1/22/2021 1:09 AM, Mark Brown wrote:
On Fri, 15 Jan 2021 12:33:29 -0800, Stephen Boyd wrote:
Suspending/resuming with an
From: Ajit Pandey
Add dai link for supporting lpass I2S driver, which is used
for audio capture and playback.
Add lpass-cpu node with pin controls and i2s primary
and secondary dai-links
Signed-off-by: Ajit Pandey
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
Thanks for review comments Srinivas!!!
On 10/7/2020 2:00 AM, Srinivas Kandagatla wrote:
On 05/10/2020 05:48, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: V
Thanks for bringing up this point Srinivas!!!
On 9/30/2020 8:57 PM, Srinivas Kandagatla wrote:
On 30/09/2020 07:39, Srinivasa Rao Mandadapu wrote:
+}
+
+static bool lpass_hdmi_regmap_volatile(struct device *dev, unsigned
int reg)
+{
+ return true;
+}
I did ask this question
From: V Sujith Kumar Reddy
Update dts property read API call with platform get property
by name, as it make code more readable and avoid conflicts
when array of properties to be used.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Srinivas Kandagatla
Signed-off-by: Srinivasa Rao
---
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: V Sujith Kumar Reddy
Acked-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
From: V Sujith Kumar Reddy
Increase buffer size to support audio over DP.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-platform.c b/sound
From: V Sujith Kumar Reddy
Update the lpaif_dmactl struct members order to match
HDMI reg map members sequence. Separate Interface reg map
as it is used for I2S control but not for HDMI control,
to make use of bulk API, which makes code more readable.
Signed-off-by: V Sujith Kumar Reddy
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass
sc7180 platform driver. Update lpass_variant
structure for hdmi data configuaration.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/lpass-sc7180.c | 116
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++---
1 file
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS
Asoc. It includes machine driver, cpu driver, platform driver updates for
HDMI path support, device tree documention, lpass variant structure
optimization and configuration changes.
These patches depends on the DP patch
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS
Asoc. It includes machine driver, cpu driver, platform driver updates for
HDMI path support, device tree documention, lpass variant structure
optimization and configuration changes.
These patches depends on the DP patch
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++---
1 file
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: V Sujith Kumar Reddy
Acked-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
From: V Sujith Kumar Reddy
Update dts property read API call with platform get property
by name, as it make code more readable and avoid conflicts
when array of properties to be used.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Srinivas Kandagatla
Signed-off-by: Srinivasa Rao
---
From: V Sujith Kumar Reddy
Update the lpaif_dmactl struct members order to match
HDMI reg map members sequence. Separate Interface reg map
as it is used for I2S control but not for HDMI control,
to make use of bulk API, which makes code more readable.
Signed-off-by: V Sujith Kumar Reddy
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass
sc7180 platform driver. Update lpass_variant
structure for hdmi data configuaration.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/lpass-sc7180.c | 116
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
From: V Sujith Kumar Reddy
Increase buffer size to support audio over DP.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-platform.c b/sound
Thanks Srinivas For Review Comments!!!
On 9/29/2020 2:32 PM, Srinivas Kandagatla wrote:
On 28/09/2020 10:53, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Thanks for doing
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS
Asoc. It includes machine driver, cpu driver, platform driver updates for
HDMI path support, device tree documention, lpass variant structure
optimization and configuration changes.
These patches depends on the DP patch
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: V Sujith Kumar Reddy
Acked-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++---
1 file
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass
sc7180 platform driver. Update lpass_variant
structure for hdmi data configuaration.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/lpass-sc7180.c | 116
From: V Sujith Kumar Reddy
Update dts property read API call with platform get property
by name, as it make code more readable and avoid conflicts
when array of properties to be used.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Srinivas Kandagatla
Signed-off-by: Srinivasa Rao
---
From: V Sujith Kumar Reddy
Increase buffer size to support audio over DP.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-platform.c b/sound
From: V Sujith Kumar Reddy
Update the lpaif_dmactl struct members order to match
HDMI reg map members sequence. Separate Interface reg map
as it is used for I2S control but not for HDMI control,
to make use of bulk API, which makes code more readable.
Signed-off-by: V Sujith Kumar Reddy
From: V Sujith Kumar Reddy
Add dai link in sc7180-trogdor.dtsi for supporting audio over DP
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch
From: V Sujith Kumar Reddy
Updaate lpass dts node with HDMI reg, interrupt and iommu
for supporting audio over dp.
Signed-off-by: Srinivasa Rao Mandadapu
Signed-off-by: V Sujith Kumar Reddy
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 17 ++---
1 file changed, 10 insertions(+), 7
These patches are device tree changes to support audio over DP.
It includes changes of HDMI reg, interrupt and iommu and
hdmi dai link.
These patches depends on the lpass I2S patch series
and DP dts node patch series:
-- https://patchwork.kernel.org/patch/11785073/
--
From: V Sujith Kumar Reddy
Update the lpaif_dmactl struct members order to match
HDMI reg map members sequence. Separate Interface reg map
as it is used for I2S control but not for HDMI control,
to make use of bulk API, which makes code more readable.
Signed-off-by: V Sujith Kumar Reddy
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++---
1 file
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass
sc7180 platform driver. Update lpass_variant
structure for hdmi data configuaration.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/lpass-sc7180.c | 116
From: V Sujith Kumar Reddy
Update dts property read API call with platform get property
by name, as it make code more readable and avoid conflicts
when array of properties to be used.
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Srinivas Kandagatla
Signed-off-by: Srinivasa Rao
---
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: V Sujith Kumar Reddy
Acked-by: Rob Herring
Signed-off-by: Srinivasa Rao
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS
Asoc. It includes machine driver, cpu driver, platform driver updates for
HDMI path support, device tree documention, lpass variant structure
optimization and configuration changes.
These patches depends on the DP patch
From: V Sujith Kumar Reddy
Increase buffer size to support audio over DP.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-platform.c b/sound
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass sc7180 platform driver.
Update lpass_variant structure for hdmi data configuaration.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/lpass-sc7180.c | 116
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++---
1 file changed, 52 insertions(+), 22
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc.
It includes machine driver, cpu driver, platform driver updates for HDMI path
support,
device tree documention, lpass variant structure optimization and configuration
changes.
These patches depends on the DP patch
From: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/lpass-cpu.c | 2 +-
sound/soc/qcom/lpass-platform.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
Acked-by: Rob Herring
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
From: V Sujith Kumar Reddy
lpass variant structure in audio driver has I2S and HDMI register fields,
which are used exclusively. To optimize memory, replace with union to
select either I2S or HDMI register fields.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 51 --
1 file changed, 47 insertions(+), 4
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass sc7180 platform driver.
Add lpass_variant structure for hdmi data configuaration.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/lpass-sc7180.c | 121
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc.
It includes machine driver, cpu driver, platform driver updates for HDMI path
support,
device tree documention, lpass variant structure optimization and configuration
changes.
These patches depends on the DP patch
Thanks Mark for Your time!!!
On 12/1/2020 11:21 PM, Mark Brown wrote:
On Tue, Dec 01, 2020 at 11:01:21PM +0530, Srinivasa Rao Mandadapu wrote:
On 11/30/2020 6:16 PM, Mark Brown wrote:
Part of this commit message says that the problem was making the registers
non-volatile but both the change
:
-- Subject lines changed
Changes Since v3:
-- Patch is splitted into 2 patches
Changes Since v4:
-- Subject lines changed
Changes Since v5:
-- Removed redundant initialization of map variable in lpass-platform.c
Srinivasa Rao Mandadapu (2):
ASoC: qcom: Fix incorrect volatile registers
ASoC: qcom
To support playback continuation after hard suspend(bypass powerd)
and resume do regcache sync with component driver pm ops.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
Reviewed-by: Srinivas Kandagatla
Tested-by: Steev Klimaszewski
---
sound/soc/qcom/lpass
API,
so remove redundant initialization.
Fixes commit b1824968221cc ("ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF
invalid state")
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-cpu.c | 20 ++--
sound/soc/
Thanks Mark for your Time!!!
On 12/14/2020 11:20 PM, Mark Brown wrote:
On Mon, Dec 14, 2020 at 06:13:22PM +0530, Srinivasa Rao Mandadapu wrote:
On 12/1/2020 11:21 PM, Mark Brown wrote:
Later from review comments by Srinivas kandagatla, I got to know
about regcache sync APIs, which can
Thanks Mark for your Time!!!
On 12/14/2020 11:20 PM, Mark Brown wrote:
On Mon, Dec 14, 2020 at 06:13:22PM +0530, Srinivasa Rao Mandadapu wrote:
On 12/1/2020 11:21 PM, Mark Brown wrote:
Later from review comments by Srinivas kandagatla, I got to know
about regcache sync APIs, which can
From: V Sujith Kumar Reddy
Update iommu property in lpass cpu node for supporting
simultaneous playback on headset and speaker.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1
From: V Sujith Kumar Reddy
Register shutdown handler to stop sc7180 lpass platform driver
and to disable audio clocks.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-cpu.c| 10 ++
sound/soc/qcom/lpass-sc7180.c | 1 +
sound/soc
lpass_pcm_data is not freed in error paths. Free it in
error paths to avoid memory leak.
Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage")
Signed-off-by: Pavel Machek
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/
From: V Sujith Kumar Reddy
Add 32 bit format support for capture in lpass-sc7180
snd_soc_dai_driver capabilities. Need to add contstraints
in machine driver so that only specific format allowed.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Manidadapu
---
rom Rohit kumar :")
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-sc7180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
index c6292f9e..bc998d5 100644
--- a/
Thanks for your time srinivas!!!
On 10/26/2020 8:31 PM, Srinivas Kandagatla wrote:
On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Update SC7180 lpass_variant structure with proper I2S bitwidth
field bit positions, as bitwidth denotes 0 to 1 bits
dy
Signed-off-by: Srinivasa Rao Mandadapu
---
Changes Since v1:
-- Commit message is changed
sound/soc/qcom/lpass-sc7180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
index c6292f9e..bc998d5 100644
--- a/soun
From: V Sujith Kumar Reddy
Change LPASS MI2S gpio configuration to pull down from pull up.
Fixes: 9b72f4e6a3f8 (arm64: dts: qcom: sc7180: Add lpass cpu node for I2S
driver)
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
arch/arm64/boot/dts/qcom/sc7180.dtsi
Thanks Bjorn For your comments!!!
On 11/30/2020 10:22 PM, Bjorn Andersson wrote:
On Fri 18 Sep 09:51 CDT 2020, Srinivasa Rao Mandadapu wrote:
From: Ajit Pandey
Add dai link for supporting lpass I2S driver, which is used
for audio capture and playback.
Add lpass-cpu node with pin controls
enable, and by maintaining BLCK state information.
Fixes: 7e6799d8f87d ("ASoC: qcom: lpass-cpu: Enable MI2S BCLK and LRCLK
together")
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-cpu.c
Thanks Mark for your time!!!
On 11/30/2020 6:16 PM, Mark Brown wrote:
On Sat, Nov 28, 2020 at 10:29:18AM +0530, Srinivasa Rao Mandadapu wrote:
This reverts part of commit b1824968221c
("ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state")
To identify LPAIF invalid s
BCLK and LRCLK in LPAIF
invalid state")
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-cpu.c | 20 ++--
sound/soc/qcom/lpass-platform.c | 11 ---
2 files changed, 2 insertions(+), 29 deletions(-)
diff --git a
To support playback continuation after hard suspend(bypass powerd)
and resume do regcache sync with component driver pm ops.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
Reviewed-by: Srinivas Kandagatla
Tested-by: Steev Klimaszewski
---
sound/soc/qcom/lpass
:
-- Subject lines changed
Changes Since v3:
-- Patch is splitted into 2 patches
Changes Since v4:
-- Subject lines changed
Srinivasa Rao Mandadapu (2):
ASoC: qcom: Fix incorrect volatile registers
ASoC: qcom: Add support for playback recover after resume
sound/soc/qcom/lpass-cpu.c | 20
To support playback continuation after resume problem in chrome
audio server:
Prepare device in platform trigger callback.
Make I2s and DMA control registers as non volatile.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-cpu.c | 8
To support playback continuation after hard suspend(bypass powerd)
and resume:
Prepare device in platform trigger callback.
Make I2s and DMA control registers as non volatile.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
Changes Since v1:
-- Subject lines
To support playback continuation after hard suspend(bypass powerd)
and resume:
Prepare device in platform trigger callback.
Make I2s and DMA control registers as non volatile.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
Changes Since v1 and v2:
-- Subject
Thanks a lot Srinivas for your valuable review comments and for your
time!!!
On 11/27/2020 5:39 PM, Srinivas Kandagatla wrote:
On 27/11/2020 09:56, Srinivasa Rao Mandadapu wrote:
To support playback continuation after hard suspend(bypass powerd)
and resume:
Prepare device in platform
Thanks Mark for your time!!!
On 11/27/2020 6:08 PM, Mark Brown wrote:
On Fri, Nov 27, 2020 at 09:42:03AM +0530, Srinivasa Rao Mandadapu wrote:
To support playback continuation after resume problem in chrome
audio server:
Prepare device in platform trigger callback.
Make I2s and DMA control
To support playback continuation after hard suspend(bypass powerd)
and resume add component driver ops and do regcache sync.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-platform.c | 35 +++
1 file changed
This patch set is to add support for playback recover after hard suspend and
resume.
It includes:
1. Reverting part of previous commit, which is for handling registers invalid
state
after hard suspend.
2. Adding pm ops in component driver and do regcache sync.
Srinivasa Rao Mandadapu (2
be handled with regcache APIs.
The BCLK ref count is necessary to enable clock only it's in disable state.
Signed-off-by: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
sound/soc/qcom/lpass-cpu.c | 20 ++--
sound/soc/qcom/lpass-platform.c | 11 ---
2 files
Thanks Srinivas For Review!!!
On 9/4/2020 4:11 PM, Srinivas Kandagatla wrote:
On 31/08/2020 07:39, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith
Thanks Srinivas For Review!!!
On 9/4/2020 4:11 PM, Srinivas Kandagatla wrote:
On 31/08/2020 07:39, Srinivasa Rao Mandadapu wrote:
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: Srinivasa Rao
From: Ajit Pandey
Add the I2S controller node to sc7180 dtsi.
Add pinmux for primary and secondary I2S.
Signed-off-by: Ajit Pandey
Signed-off-by: Cheng-Yi Chiang
Signed-off-by: Srinivasa Rao Mandadapu
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 69
1
Thanks Stephen, for your time for review!!!
On 9/1/2020 1:02 PM, Stephen Boyd wrote:
Quoting Srinivasa Rao Mandadapu (2020-08-30 23:39:23)
diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
index 167bf2c..cea7ae7 100644
--- a/sound/soc/qcom/lpass-sc7180.c
+++ b/sound
Thanks Stephen for your time for review!!!
On 9/1/2020 1:06 PM, Stephen Boyd wrote:
Quoting Srinivasa Rao Mandadapu (2020-08-30 23:39:22)
diff --git a/sound/soc/qcom/lpass-hdmi.c b/sound/soc/qcom/lpass-hdmi.c
new file mode 100644
index 000..7e18113
--- /dev/null
+++ b/sound/soc/qcom/lpass
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc.
It includes machine driver, cpu driver, platform driver updates for HDMI path
support,
device tree documention, lpass variant structure optimization and configuration
changes.
These patches depends on the DP patch
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 51 --
1 file changed, 47 insertions(+), 4
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass sc7180 platform driver.
Add lpass_variant structure for hdmi data configuaration.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/lpass-sc7180.c | 121
From: V Sujith Kumar Reddy
lpass variant structure in audio driver has I2S and HDMI register fields,
which are used exclusively. To optimize memory, replace with union to
select either I2S or HDMI register fields.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
Thanks for your reply Srinivas!!!
On 9/4/2020 4:54 PM, Srinivas Kandagatla wrote:
On 04/09/2020 12:21, Srinivasa Rao Mandadapu wrote:
Before going into detail review, I see real issue in the overall
approach here to add new interface to exiting lpass!!
Intention of struct lpass_variant
From: V Sujith Kumar Reddy
Add header defining hdmi dai-id for SC7180 lpass soc
in dt bindings.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
include/dt-bindings/sound/sc7180-lpass.h | 1 +
1 file changed, 1 insertion(+)
diff --git
These patches are to support audio over DP port on Qualcomm's SC7180 LPASS Asoc.
It includes machine driver, cpu driver, platform driver updates for HDMI path
support,
device tree documention, lpass variant structure optimization and configuration
changes.
These patches depends on the DP patch
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 51 --
1 file changed, 47 insertions(+), 4
From: V Sujith Kumar Reddy
Add support for audio playback over DP in lpass sc7180 platform driver.
Add lpass_variant structure for hdmi data configuaration.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
Reviewed-by: Srinivas Kandagatla
---
sound/soc/qcom/lpass-sc7180.c |
From: V Sujith Kumar Reddy
Upadate lpass cpu and platform driver to support audio over dp.
Also add lpass-hdmi.c and lpass-hdmi.h.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/Kconfig | 5 +
sound/soc/qcom/Makefile | 2 +
From: V Sujith Kumar Reddy
lpass variant structure in audio driver has I2S and HDMI register fields,
which are used exclusively. To optimize memory, replace with union to
select either I2S or HDMI register fields.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
From: V Sujith Kumar Reddy
Adds bindings for lpass hdmi interface
which can support audio path over dp.
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
.../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 74 +++---
1 file changed, 52 insertions(+), 22
From: V Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao
Signed-off-by: V Sujith Kumar Reddy
---
sound/soc/qcom/lpass-cpu.c | 2 +-
sound/soc/qcom/lpass-platform.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/qcom/lpass-cpu.c
1 - 100 of 158 matches
Mail list logo
