printk replaced with corresponding pr_*
fixed two broken user-visible strings used by the printk
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/tty/serial/serial_core.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/tty
printk replaced with corresponding dev_*
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/tty/serial/serial_core.c | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git
On Wed, Jul 30, 2014 at 8:07 PM, Jiri Slaby jsl...@suse.cz wrote:
On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
printk replaced with corresponding dev_*
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
replaced printk with corresponding pr_err
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/pci/ctxfi/ctpcm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/pci/ctxfi/ctpcm.c b/sound/pci/ctxfi/ctpcm.c
index e8a4feb..6826c2c 100644
--- a/sound/pci
printk replaced ith corresponding pr_err
fixed three broken user-visible strings
fixed a checkpatch warning of space before new line
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/pci/ctxfi/ctatc.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions
new link for - How to piss off a Linux kernel subsystem maintainer
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Documentation/SubmittingPatches | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 0a523c9
On Mon, Aug 25, 2014 at 05:16:51PM -0700, Randy Dunlap wrote:
On 08/25/14 11:06, Sudip Mukherjee wrote:
new link for - How to piss off a Linux kernel subsystem maintainer
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
Hi,
I'll apply this patch, but it would really be nice
On Mon, Aug 25, 2014 at 12:24:01PM -0700, Jim Davis wrote:
Building with the attached random configuration file,
drivers/built-in.o: In function `__bnx2x_remove':
/home/jim/linux/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13409:
undefined reference to `ptp_clock_unregister'
On Tue, Aug 26, 2014 at 08:27:09AM +0200, Takashi Iwai wrote:
At Mon, 25 Aug 2014 23:26:52 +0530,
Sudip Mukherjee wrote:
printk replaced ith corresponding pr_err
fixed three broken user-visible strings
fixed a checkpatch warning of space before new line
Fixes are good
printk replaced with corresponding pr_err and pr_alert
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Initially started by copy-paste but as Takashi suggested it was done by a
script.
bash script is as follows :
OLD=printk(KERN_ERR \?
OLD1=printk(KERN_ALERT \?
NEW=pr_err(
NEW1
On Tue, Aug 26, 2014 at 12:33:28PM +0200, Takashi Iwai wrote:
At Tue, 26 Aug 2014 15:43:24 +0530,
Sudip Mukherjee wrote:
printk replaced with corresponding pr_err and pr_alert
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
Initially started by copy-paste but as Takashi
fixed broken user visible strings
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
I am not exactly sure about the patch as some lines after fixing has crossed
the limit of 80 characters.
But the coding style says :
never break user-visible strings such as printk messages, because
as pr_* macros are more preffered over printk, so printk replaced with
corresponding pr_err and pr_alert
this patch will generate a warning from checkpatch for an unnecessary space
before new line and has not been fixed as this patch is only for printk
replacement.
Signed-off-by: Sudip
as broken user-visible strings breaks the ability to grep for them , so this
patch fixes the broken user-visible strings
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/pci/ctxfi/ctatc.c | 18 +++---
sound/pci/ctxfi/cthw20k1.c | 3 +--
sound/pci/ctxfi
On Tue, Aug 26, 2014 at 02:32:04PM +0200, Takashi Iwai wrote:
At Tue, 26 Aug 2014 17:52:14 +0530,
Sudip Mukherjee wrote:
fixed broken user visible strings
This text just repeats what the summary line says. Instead, you
should write *why* the patch is needed. Ditto for the previous
On Tue, Aug 26, 2014 at 12:45:20AM +0200, Rafael J. Wysocki wrote:
On Friday, August 22, 2014 05:33:21 PM Sudip Mukherjee wrote:
printk replaced with corresponding dev_err and dev_info
fixed one broken user-visible string
multiine comment edited for correct commenting style
asm/uaccess.h
On Tue, Aug 26, 2014 at 11:22:12PM +0200, Rafael J. Wysocki wrote:
On Tuesday, August 26, 2014 01:59:02 PM Joe Perches wrote:
On Tue, 2014-08-26 at 23:02 +0200, Rafael J. Wysocki wrote:
On Tuesday, August 26, 2014 09:00:39 PM Sudip Mukherjee wrote:
On Tue, Aug 26, 2014 at 12:45:20AM
On Tue, Aug 26, 2014 at 09:50:43AM -0700, Jim Davis wrote:
Building with the attached random configuration file,
ERROR: vb2_ops_wait_finish
[Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
ERROR: vb2_ops_wait_prepare
[Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
On Wed, Jul 30, 2014 at 8:22 PM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
On Wed, Jul 30, 2014 at 8:07 PM, Jiri Slaby jsl...@suse.cz wrote:
On 07/30/2014, 04:07 PM, Sudip Mukherjee wrote:
printk replaced with corresponding dev_*
fixed two broken user-visible strings used
printk replaced with corresponding pr_err, dev_alert, dev_notice and pr_info.
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
In the first patch i sent Greg suggested to use dev_err instead of pr_err , but
as later
printk replaced with corresponding dev_err and dev_info
fixed one broken user-visible string
multiine comment edited for correct commenting style
asm/uaccess.h replaced with linux/uaccess.h
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/acpi/fan.c | 18 +-
1
Uses the struct pci_device_id instead of the depreciated macro
DEFINE_PCI_DEVICE_TABLE.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/pci/es1968.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c
index 5bb1cf6..a9956a7
On Tue, Aug 12, 2014 at 5:56 PM, Takashi Iwai ti...@suse.de wrote:
At Tue, 12 Aug 2014 17:45:40 +0530,
Sudip Mukherjee wrote:
Uses the struct pci_device_id instead of the depreciated macro
DEFINE_PCI_DEVICE_TABLE.
If we do this, better to apply to all sound/pci/* at once after
3.17-rc1
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/staging/bcm/Transmit.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
index 05fae92..622a482 100644
--- a/drivers/staging/bcm
---
drivers/staging/bcm/DDRInit.c | 59 ---
1 file changed, 39 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 4564f40..4226c93 100644
--- a/drivers/staging/bcm/DDRInit.c
+++
Signed-off-by: Sudip Mukherjee sudipm.mukher...@gmail.com
---
drivers/staging/bcm/DDRInit.c | 59 ---
1 file changed, 39 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 4564f40..4226c93
printk replaced with corresponding dev_err, dev_alert, dev_notice and pr_info.
pr_info has been used instead of dev_info as there is a check for port-dev
being NULL or not.
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee sudipm.mukher
Hi, that will not work either, as there is put_device(tty_dev) before
you use tty_dev.
--
js
suse labs
Hi,
i missed that. I put my test message to test tty_dev immediately after
tty_dev was initialized and so never got the error when the port was
suspended.
Will change it to pr_err and
On Thu, Oct 23, 2014 at 01:47:37AM +0200, Hartmut Knaack wrote:
Sudip Mukherjee schrieb am 22.10.2014 06:21:
On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote:
This fixes the 2 checkpatch.pl warnings:
WARNING: line over 80 characters
please check your patch with --strict
On Fri, Oct 17, 2014 at 07:05:19PM +, Paul Zimmerman wrote:
From: Felipe Balbi [mailto:ba...@ti.com]
Sent: Friday, October 17, 2014 11:52 AM
On Fri, Oct 17, 2014 at 06:50:19PM +, Paul Zimmerman wrote:
From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
Sent: Thursday
commit 374f8fdea4aabec8e918cf9951e51bfa4f570ea8 has fixed a problem by
jumping to the correct label,but the previous incorrect label was not
removed and it was still there in the code unused.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
block/scsi_ioctl.c | 1 -
1 file changed, 1
rather than
returning 0 always.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
hi,
if my understanding was wrong and if it is indeed a case of unusued variable,
then please discard this patch.
block/elevator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Thu, Oct 23, 2014 at 08:12:06AM -0600, Jens Axboe wrote:
On 10/23/2014 07:20 AM, Sudip Mukherjee wrote:
while compiling integer err was showing as a set but unused variable.
elevator_init_fn can be either cfq_init_queue or deadline_init_queue
or noop_init_queue.
all three
rather than
returning 0 always.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
change in v2: added elevator_put
block/elevator.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/elevator.c b/block/elevator.c
index 24c28b6..1267c2b 100644
--- a/block
On Thu, Oct 23, 2014 at 10:09:36AM -0600, Jens Axboe wrote:
On 10/23/2014 10:04 AM, Sudip Mukherjee wrote:
while compiling integer err was showing as a set but unused variable.
elevator_init_fn can be either cfq_init_queue or deadline_init_queue
or noop_init_queue.
all three
rather than
returning 0 always.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
change in v2: added elevator_put
change in v3: remove unneeded initialization of err
block/elevator.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/elevator.c b/block/elevator.c
On Sat, Oct 25, 2014 at 01:05:13AM +0100, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ap.c | 130
++--
1 file changed, 40 insertions(+), 90
On Sat, Oct 25, 2014 at 12:22:32AM +0100, Paul McQuade wrote:
ERROR: that open brace { should be on the previous line
patch is corrupt.
thanks
sudip
Signed-off-by: Paul McQuade paulmcq...@gmail.com
---
drivers/staging/rtl8723au/core/rtw_ap.c | 137
++--
1
unused variables are removed. These variables were only assigned some
values and after that they were never being used. So they are safe to
be removed , and it has been build tested.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8712/hal_init.c| 9
On Tue, Oct 14, 2014 at 08:55:55PM +, Paul Zimmerman wrote:
From: Sudip Mukherjee [mailto:sudipm.mukher...@gmail.com]
Sent: Friday, October 10, 2014 6:10 AM
sparse was giving the following warning:
warning: context imbalance in 's3c_hsotg_ep_enable'
- different lock
modified the function to have a single return statement at the end
instead of multiple return statement in the middle of the function
to improve the readability of the code.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/usb/dwc2/gadget.c | 11 ---
1 file changed, 8
.
This patch depends on the previous patch of the series.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/usb/dwc2/gadget.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index af5517f..05a9a23 100644
--- a/drivers
fixed a sparse warning in 8250_core.c :
incorrect type in assignment (different address spaces)
the warning was because an unsigned char pointer was being assigned to
a pointer of unsigned char __iomem type .
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/tty/serial
On Thu, Oct 16, 2014 at 02:38:53AM -0700, Joe Perches wrote:
On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote:
Fixed codin style errors and warnings. Changes printk with
print_debug/warn. Changed seq_printf to seq_puts.
If you are going to do style cleanups, please make
sure you check
On Thu, Oct 16, 2014 at 08:21:55AM -0500, Felipe Balbi wrote:
HI,
On Thu, Oct 16, 2014 at 01:11:10PM +0530, Sudip Mukherjee wrote:
sparse was giving the following warning:
warning: context imbalance in 's3c_hsotg_ep_enable'
- different lock contexts for basic block
On Thu, Oct 16, 2014 at 03:45:44PM +0200, Takashi Iwai wrote:
At Thu, 16 Oct 2014 11:04:34 +0800,
Raymond Yau wrote:
snip
since these 2 commits:
commit e28d713704117bca0820c732210df6075b09f13b
Author: Linus Torvalds torva...@linux-foundation.org
Date: Tue Jun 16 11:02:28
.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/usb/dwc2/gadget.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
index 7b5856f..7f25527 100644
--- a/drivers/usb/dwc2/gadget.c
+++ b/drivers/usb/dwc2
modified the function to have a single return statement at the end
instead of multiple return statement in the middle of the function
to improve the readability of the code.
This patch depends on the previous patch of the series.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers
On Fri, Oct 17, 2014 at 09:02:00AM +, David Laight wrote:
From: Of Sudip Mukherjee
modified the function to have a single return statement at the end
instead of multiple return statement in the middle of the function
to improve the readability of the code.
Many of us would disagree
the integer variable 'feature' was not being used anywhere in the function.
so it is safe to remove the variable.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/usb/core/hub.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core
As of now the pointer to struct dai is not being used anywhere in the
function. So it is safe to remove the variable.
If we are ever doing anything with the container_of(daio, struct dai, daio),
then at that time we can again add the variable.
Signed-off-by: Sudip Mukherjee su
On Tue, Oct 21, 2014 at 05:56:47PM -0500, Brian Vandre wrote:
This fixes the 2 checkpatch.pl warnings:
WARNING: line over 80 characters
please check your patch with --strict option of checkpatch.pl , and you will
get :
Alignment should match open parenthesis .
thanks
sudip
Signed-off-by:
we should be using DMA API rather than using bus specific DMA API.
converted the occurrence of pci_map_*() to dma_map_*(),
and at the same time used the dma_mapping_error().
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 12
fixed sparse warning : context imbalance in 'pause_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not modified.
Signed-off-by: Sudip Mukherjee su
On Fri, Sep 05, 2014 at 12:34:13PM +0300, Dan Carpenter wrote:
On Thu, Sep 04, 2014 at 10:15:42PM +0530, Sudip Mukherjee wrote:
fixed sparse warning : incorrect type in argument 1
(different address spaces)
The change log is not clear. It's the IS_ERR() which
On Sat, Sep 06, 2014 at 04:16:17PM +0800, Kroderia wrote:
vagrant@lucid32:~$ uname -r
3.17.0-rc3-00130-g86ba8b0
vagrant@lucid32:~$ ls /lib/modules/
2.6.32-38-generic 3.17.0-rc3+ 3.17.0-rc3-00130-g86ba8b0
vagrant@lucid32:~$ ls /boot/
abi-2.6.32-38-generic memtest86+.bin
On Fri, Aug 29, 2014 at 01:38:01PM +0530, Sudip Mukherjee wrote:
with -Werror=implicit-function-declaration build failed with error :
error: implicit declaration of function 'inb'
error: implicit declaration of function 'outb'
Reported-by: Jim Davis jim.ep...@gmail.com
Signed-off-by: Sudip
On Mon, Sep 08, 2014 at 10:07:45AM +0200, Hans Verkuil wrote:
On 09/06/2014 01:24 PM, Sudip Mukherjee wrote:
On Fri, Aug 29, 2014 at 01:38:01PM +0530, Sudip Mukherjee wrote:
with -Werror=implicit-function-declaration build failed with error :
error: implicit declaration of function 'inb
On Thu, Aug 28, 2014 at 08:32:58PM +0530, Sudip Mukherjee wrote:
as pr_* macros are more preffered over printk, so printk replaced with
corresponding pr_* macros
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
The replacement was done by a bash script to avoid copy paste error
On Mon, Sep 08, 2014 at 06:14:48PM +0900, Masahiro Yamada wrote:
Hi Josh,
On Mon, 8 Sep 2014 01:39:20 -0700
Josh Triplett j...@joshtriplett.org wrote:
On Mon, Sep 08, 2014 at 05:10:13PM +0900, Masahiro Yamada wrote:
@@ -406,9 +404,9 @@ static void get_hynix_nand_para(struct
On Mon, Sep 08, 2014 at 07:32:22AM -0500, Morgan Phillips wrote:
Signed-off-by: Morgan Phillips winter2...@gmail.com
no commit message ?
thanks
sudip
---
drivers/media/usb/gspca/sn9c20x.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git
-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org
On Mon, Sep 8, 2014 at 8:48 AM, Sudip Mukherjee sudipm.mukher...@gmail.com
wrote:
On Mon, Sep 08, 2014 at 07:32:22AM -0500, Morgan Phillips wrote:
Signed-off-by: Morgan Phillips winter2...@gmail.com
no commit message ?
thanks
On Mon, Sep 08, 2014 at 09:55:58AM -0500, Morgan Phillips wrote:
Change array initialization format to fix style error.
from:
u8 foo[] =
{1, 2, 3};
to:
checkpatch is giving a warning here , but looks like a false positive.
thanks
sudip
On Mon, Sep 08, 2014 at 10:57:08AM -0500, Romer, Benjamin M wrote:
On Fri, 2014-09-05 at 14:52 +0530, Sudip Mukherjee wrote:
fixed sparse warning : context imbalance in 'pause_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over
On Mon, Sep 08, 2014 at 11:30:48AM -0500, Romer, Benjamin M wrote:
On Mon, 2014-09-08 at 21:57 +0530, Sudip Mukherjee wrote:
Hi Ben,
thanks. the same file is having two more similar warnings. if you want i can
resend a patch fixing all the three warnings , or i can send two separate
On Mon, Sep 08, 2014 at 11:48:44AM -0500, Romer, Benjamin M wrote:
On Mon, 2014-09-08 at 22:08 +0530, Sudip Mukherjee wrote:
Hi Ben,
sorry to disturb you again. i got confused , which one is perfect one
combined patch or
separate patches?
thanks
sudip
Two patches, as you
as pr_* macros are more preffered over printk, so printk replaced
with corresponding pr_* macros.
this patch will generate warning from checkpatch as it only did printk
replacement and didnot fixed other style issues.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
The replacement
build is giving :
warning: passing argument 1 of 'strlen' makes pointer from integer
without a cast [enabled by default]
the snprintf after the strlen is trying to put the Unsupported string
at the end of exising string. so len should give the string length here
Signed-off-by: Sudip Mukherjee
On Tue, Sep 09, 2014 at 12:53:50PM +0530, Sudip Mukherjee wrote:
build is giving :
warning: passing argument 1 of 'strlen' makes pointer from integer
without a cast [enabled by default]
the snprintf after the strlen is trying to put the Unsupported string
at the end of exising string. so
fixed sparse warning : context imbalance in 'resume_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not modified.
Signed-off-by: Sudip Mukherjee su
On Wed, Aug 27, 2014 at 10:33:46AM -0700, Jim Davis wrote:
On Wed, Aug 27, 2014 at 3:58 AM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
Hi,
I tried to build next-20140826 with your given config file . But for me
everything was fine.
Well, you should be able to reproduce it. Do
printk replaced with corresponding dev_err and dev_info
fixed one broken user-visible string
multiine comment edited for correct commenting style
asm/uaccess.h replaced with linux/uaccess.h
PREFIX removed
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
modified with reference
On Thu, Aug 28, 2014 at 01:26:58AM +0200, Rafael J. Wysocki wrote:
On Wednesday, August 27, 2014 10:27:47 AM Sudip Mukherjee wrote:
On Tue, Aug 26, 2014 at 11:22:12PM +0200, Rafael J. Wysocki wrote:
On Tuesday, August 26, 2014 01:59:02 PM Joe Perches wrote:
On Tue, 2014-08-26 at 23:02
On Thu, Aug 28, 2014 at 08:53:45AM -0400, edubez...@gmail.com wrote:
Hello Sudip,
On Thu, Aug 28, 2014 at 7:33 AM, Sudip Mukherjee
sudipm.mukher...@gmail.com wrote:
printk replaced with corresponding dev_err and dev_info
fixed one broken user-visible string
multiine comment edited
printk replaced with corresponding dev_err and dev_info
fixed one broken user-visible string
multiine comment edited for correct commenting style
asm/uaccess.h replaced with linux/uaccess.h
PREFIX removed
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
modified with reference
printk replaced with corresponding pr_err, dev_alert, dev_notice and pr_info.
fixed two broken user-visible strings used by the corresponding printk
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
In the first patch i sent Greg suggested to use dev_err instead of pr_err , but
as later
as pr_* macros are more preffered over printk, so printk replaced with
corresponding pr_* macros
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
The replacement was done by a bash script to avoid copy paste error. The script
is as follows :
OLD=printk(KERN_ERR \?
OLD1=printk
On Thu, Aug 28, 2014 at 09:17:14AM -0700, Jim Davis wrote:
Building with the attached random configuration file,
CC [M] drivers/media/radio/radio-miropcm20.o
drivers/media/radio/radio-miropcm20.c: In function ‘rds_waitread’:
drivers/media/radio/radio-miropcm20.c:90:3: error: implicit
with -Werror=implicit-function-declaration build failed with error :
error: implicit declaration of function 'inb'
error: implicit declaration of function 'outb'
Reported-by: Jim Davis jim.ep...@gmail.com
Signed-off-by: Sudip Mukherjee su...@vectorindi.org
---
Jim reported for next-20140828
fixed sparse warning of following symbol not declared:
warning: symbol 'lnet_ptl_cleanup' was not declared. Should it be static?
warning: symbol 'lnet_ptl_setup' was not declared. Should it be static?
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
As of now these functions
fixed sparse warning of incorrect type in argument 1 and incorrect type in
argument 2
it was directly dereferencing a __iomem pointer , which will work in x86 but
will fail in other architectures.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
hi,
can you please reveiew the patch
On Mon, Sep 01, 2014 at 12:35:14PM +0300, Dan Carpenter wrote:
On Sun, Aug 31, 2014 at 09:46:22PM +0530, Sudip Mukherjee wrote:
@@ -133,9 +134,15 @@ static ssize_t goldfish_audio_read(struct file *fp,
char __user *buf,
AUDIO_READ_BUFFER_AVAILABLE
pr_* macros replaced with dev_* as they are more preffered over pr_*.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/pci/ctxfi/ctamixer.c | 6 --
sound/pci/ctxfi/ctatc.c | 23 ++-
sound/pci/ctxfi/ctdaio.c | 3 ++-
sound/pci/ctxfi/cthw20k1.c
fixed sparse warning : context imbalance in 'destroy_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not modified.
Signed-off-by: Sudip Mukherjee su
On Sun, Sep 14, 2014 at 08:54:43PM +0800, Amitabha Yin wrote:
Hello all,
Set EXTRAVERSION to -eudyptula in Makefile for
Task 03 of the Eudyptula Challenge.
i think you are supposed to send the patch to little and not here.
thanks
sudip
Signed-off-by: Ping Yin angelo@gmail.com
--
On Mon, Sep 15, 2014 at 07:41:23PM +0800, Herbert Xu wrote:
On Thu, Aug 28, 2014 at 08:32:58PM +0530, Sudip Mukherjee wrote:
as pr_* macros are more preffered over printk, so printk replaced with
corresponding pr_* macros
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
Your
pr_* macros replaced with dev_* as they are more preffered over pr_*.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
in v1 Takashi mentioned that now we have card-dev
so v2 is using card-dev as much as possible.
sound/pci/ctxfi/ctatc.c | 24 ++--
sound/pci
as pr_* macros are more preffered over printk, so printk replaced with
corresponding pr_* macros
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
The replacement was done by a bash script to avoid copy paste error. The script
is as follows :
OLD=printk(KERN_ERR \?
OLD1=printk
On Mon, Sep 15, 2014 at 04:29:48PM +0200, Takashi Iwai wrote:
At Mon, 15 Sep 2014 19:39:41 +0530,
Sudip Mukherjee wrote:
pr_* macros replaced with dev_* as they are more preffered over pr_*.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
in v1 Takashi mentioned
pr_* macros replaced with dev_* as they are more preffered over pr_*.
each file which had pr_* was reviewed manually and replaced with dev_*.
here we have actually used the reference of the vortex which was added
to some functions in the previous patch of this series.
Signed-off-by: Sudip
*.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
---
sound/pci/au88x0/au88x0.h | 4 ++--
sound/pci/au88x0/au88x0_a3d.c | 6 +++---
sound/pci/au88x0/au88x0_core.c | 5 +++--
sound/pci/au88x0/au88x0_pcm.c | 2 +-
4 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/sound/pci
On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
On Thu, Oct 09, 2014 at 05:03:07PM +0800, Jia He wrote:
Signed-off-by: Jia He hejia...@gmail.com
This fixes all coding style error problems at rtl8188eu which
makes checkpatch.pl unhappy
your commit message should be above your Signed-off line.
mention what type of error you are fixing.
you
On Thu, Oct 09, 2014 at 06:25:10PM +0800, WANG Chao wrote:
This fixes the following sparse error:
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c:393:9: error:
incompatible types in comparison expression (different address spaces)
Signed-off-by: WANG Chao
On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote:
On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote:
@@ -262,7 +257,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
if (tmp8_a != (tmp8|BIT(2)))
goto exit_fail
() and r8712_read8() is ultimately calling usb_read32()
and usb_read8() respectively. and they are again calling
r8712_usbctrl_vendorreq().
this r8712_usbctrl_vendorreq() is communicating through the usb bus
and is sending and receiving the control msg.
Signed-off-by: Sudip Mukherjee su...@vectorindia.org
On Mon, Oct 27, 2014 at 03:12:57PM +0300, Dan Carpenter wrote:
On Mon, Oct 27, 2014 at 05:22:21PM +0530, Sudip Mukherjee wrote:
On Mon, Oct 27, 2014 at 02:13:12PM +0300, Dan Carpenter wrote:
On Sun, Oct 26, 2014 at 06:03:33PM +0530, Sudip Mukherjee wrote:
@@ -262,7 +257,7 @@ static u8
On Thu, Oct 23, 2014 at 10:16:48PM +0530, Sudip Mukherjee wrote:
while compiling integer err was showing as a set but unused variable.
elevator_init_fn can be either cfq_init_queue or deadline_init_queue
or noop_init_queue.
all three of these functions are returning -ENOMEM if they fail
On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
Signed-off-by: Mikael Svantesson mik...@distopic.net
still the same problem.
ERROR: patch seems to be corrupt (line wrapped?)
---
drivers/staging/skein/skein_api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
to be that Thunderbird thrashes empty lines when
double clicking the e-mail in Drafts or selecting Edit as new.
When forwarding the e-mail it doesn't seem to affect the empty lines,
very weird behaviour.
Regards,
Mikael
On 2014-10-29 06:25, Sudip Mukherjee wrote:
On Tue, Oct 28, 2014 at 09:07:00PM
1 - 100 of 4590 matches
Mail list logo
