Re: [PATCH] ppdev: don't print a free'd string

+), 5 deletions(-) Sudip, any thoughts? Hi Greg, Sorry for the late reply. It looks good. Acked-by: Sudip Mukherjee Regards Sudip

Re: [RFC PATCH 0/3] staging: remove fbdev drivers

On Wednesday 23 November 2016 09:12 AM, Tomi Valkeinen wrote: On 23/11/16 10:52, Greg Kroah-Hartman wrote: On Wed, Nov 23, 2016 at 10:03:10AM +0200, Tomi Valkeinen wrote: Hi, Since the fbdev framework is in maintenance mode and all new display drivers should be made with the DRM framework, rem

[PATCH] staging: sm750fb: update license

The driver was actually released with BSD license. It also gained GPL when it was submitted to be included in the kernel. Cc: Teddy Wang Cc: gzhou1 Signed-off-by: Sudip Mukherjee --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] mtd: nand: nandsim: fix error check

On Thursday 17 November 2016 01:21 PM, Marek Vasut wrote: On 11/16/2016 09:56 PM, Sudip Mukherjee wrote: On Wednesday 16 November 2016 04:56 PM, Marek Vasut wrote: On 11/16/2016 08:52 AM, Sudip Mukherjee wrote: On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote: On 11/16/2016 12:09 AM

[PATCH] net: bcm63xx_enet: fix build failure

b ("net: bcm63xx_enet: Utilize phy_ethtool_nway_reset") Signed-off-by: Sudip Mukherjee --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/176269457 drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/etherne

Re: [PATCH] mtd: nand: nandsim: fix error check

On Wednesday 16 November 2016 04:56 PM, Marek Vasut wrote: On 11/16/2016 08:52 AM, Sudip Mukherjee wrote: On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote: On 11/16/2016 12:09 AM, Sudip Mukherjee wrote: debugfs_create_dir() and debugfs_create_file() returns NULL on error or a pointer

[PATCH v2] mtd: nand: nandsim: fix error check

debugfs_create_dir() and debugfs_create_file() returns NULL on error or a pointer on success. They do not return the error value with ERR_PTR. So we should not check the return with IS_ERR_OR_NULL, instead we should just check for NULL. Signed-off-by: Sudip Mukherjee --- v2: nuked err drivers

Re: [PATCH] mtd: nand: nandsim: fix error check

On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote: On 11/16/2016 12:09 AM, Sudip Mukherjee wrote: debugfs_create_dir() and debugfs_create_file() returns NULL on error or a pointer on success. They do not return the error value with ERR_PTR. So we should not check the return with

[PATCH] mtd: nand: nandsim: fix error check

debugfs_create_dir() and debugfs_create_file() returns NULL on error or a pointer on success. They do not return the error value with ERR_PTR. So we should not check the return with IS_ERR_OR_NULL, instead we should just check for NULL. Signed-off-by: Sudip Mukherjee --- drivers/mtd/nand

[PATCH] m32r: fix build warning

iables and functions only when CONFIG_USB is enabled. Signed-off-by: Sudip Mukherjee --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/175943814 arch/m32r/platforms/m32700ut/setup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/m32r/platforms/m32700ut/setup.c b

Re: [PATCH 1/3] pcmcia: m32r_pcc: check return from request_irq

On Sunday 18 September 2016 11:21 PM, Sudip Mukherjee wrote: While building m32r allmodconfig we were getting warning: drivers/pcmcia/m32r_pcc.c:331:2: warning: ignoring return value of 'request_irq', declared with attribute warn_unused_result request_irq() can fail and we should

[PATCH] usb: mtu3: declare functions static

The only user of the functions mtu3_irq() and gpd_ring_empty() are in the same file. They can be declared as static. Signed-off-by: Sudip Mukherjee --- drivers/usb/mtu3/mtu3_core.c | 2 +- drivers/usb/mtu3/mtu3_qmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] ppdev: check before attaching port

new array of pointer and use that to remember the ports we have attached. And use that information to skip attaching ports which we have already attached. Tested-by: Joe Lawrence Signed-off-by: Sudip Mukherjee --- drivers/char/ppdev.c | 23 +-- 1 file changed, 21 insertions

Re: [ppdev] sysfs warning on qemu boot

Hi Joe, On Wednesday 09 November 2016 06:41 PM, Joe Lawrence wrote: On 11/09/2016 12:04 PM, Sudip Mukherjee wrote: Hi Joe, On 09/11/16 16:00, Joe Lawrence wrote: Hi Sudip, I hit a sysfs_warn_dup inside QEMU running 4.9.0-rc4 (I suspect earlier versions as well, but this is the first

[PATCH 2/3] MAINTAINERS: update email

I am no longer with Vector India. Update my email. Signed-off-by: Sudip Mukherjee --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3d838cf..054b258 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9084,7 +9084,7 @@ F

[PATCH 3/3] ppdev: use pr_* macros

The coding style recommends not to use printk. Use pr_* macros. Signed-off-by: Sudip Mukherjee --- drivers/char/ppdev.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c index f08f3ed..85c63e4 100644 --- a/drivers/char

[PATCH 1/3] ppdev: fix memory leak

: Sudip Mukherjee --- drivers/char/ppdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c index 6af1ce0..f08f3ed 100644 --- a/drivers/char/ppdev.c +++ b/drivers/char/ppdev.c @@ -305,10 +305,10 @@ static int register_device(int minor

Re: [PATCH v2] ppdev: fix double-free of pp->pdev->name

On Thu, Nov 10, 2016 at 02:18:12PM +0100, Arnd Bergmann wrote: > On Sunday, October 30, 2016 11:19:24 PM CET Jann Horn wrote: > > diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c > > index d23368874710..6af1ce04b3da 100644 > > --- a/drivers/char/ppdev.c > > +++ b/drivers/char/ppdev.c > > @@

Re: [PATCH v2] ppdev: fix double-free of pp->pdev->name

> [ 60.316869] Freed: > [ 60.316880] PID = 1695 > [ 60.316935] ====== > > Signed-off-by: Jann Horn Acked-by: Sudip Mukherjee

Re: [PATCH v2] MIPS: fix duplicate define

e system] > > url: > https://github.com/0day-ci/linux/commits/Sudip-Mukherjee/MIPS-fix-duplicate-define/20161110-044738 > config: mips-ip27_defconfig (attached as .config) > compiler: mips64-linux-gnuabi64-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: > wget > https:

[PATCH] nios2: add screen_info

con.c:(.text+0x123f4): undefined reference to `screen_info' vgacon.c:(.text+0x123f8): undefined reference to `screen_info' drivers/built-in.o: In function `vgacon_save_screen': vgacon.c:(.text+0x12528): undefined reference to `screen_info' Lets define a screen_info which can work a

Re: Linux 4.9-rc4 double free from pp_release()

Hi Shuah On Wednesday 09 November 2016 10:04 PM, Shuah Khan wrote: Hi Sudip/Greg, I am seeing the following double free from pp_release() in Linux 4.9-rc4 Is this a known problem? Can you please check if the patch at [1] fixes the problem. [1] https://patchwork.kernel.org/patch/9404815/ Re

[PATCH v2] MIPS: fix duplicate define

ot;MIPS: Adjust MIPS64 CAC_BASE to reflect Config.K0") Signed-off-by: Sudip Mukherjee --- v2: corrected a silly mistake of overlooking #else Build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/174134289 arch/mips/include/asm/mach-generic/spaces.h | 2 ++ 1 file changed, 2

Re: [ppdev] sysfs warning on qemu boot

Hi Joe, On 09/11/16 16:00, Joe Lawrence wrote: > Hi Sudip, > > I hit a sysfs_warn_dup inside QEMU running 4.9.0-rc4 (I suspect earlier > versions as well, but this is the first upstream I've run in a while). > This warning looks like something the kernel test robot ran into a few > months ago: Y

[PATCH] MIPS: fix duplicate define

ot;MIPS: Adjust MIPS64 CAC_BASE to reflect Config.K0") Signed-off-by: Sudip Mukherjee --- Build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/174134289 arch/mips/include/asm/mach-generic/spaces.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/include/asm/m

Re: [PATCH] m32r: add simple dma

On Thursday 03 November 2016 07:13 PM, Andrew Morton wrote: On Sun, 30 Oct 2016 23:47:29 +0530 Sudip Mukherjee wrote: On Friday 21 October 2016 08:59 AM, Andrew Morton wrote: On Sat, 8 Oct 2016 23:23:18 +0530 Sudip Mukherjee wrote: Some builds of m32r were failing as it tried to build

Re: [PATCH] m32r: add simple dma

Hi Andrew, On Friday 21 October 2016 08:59 AM, Andrew Morton wrote: On Sat, 8 Oct 2016 23:23:18 +0530 Sudip Mukherjee wrote: Some builds of m32r were failing as it tried to build few drivers which needed dma but m32r is not having dma support. Objections were raised when it was tried to

Re: [PATCH] ppdev: fix double-free of pp->pdev->name

area. I think the above should not be a part of the commit message. It looks like a valid bug. As we have now started using the device model from this release, so device_unregister() will finally call free_pardevice() and that will free the name. Signed-off-by: Jann Horn --- Acked-by: Su

[tip:irq/urgent] kernel/irq: Export irq_set_parent()

Commit-ID: 3118dac501bc0317de099db81618d589503351e1 Gitweb: http://git.kernel.org/tip/3118dac501bc0317de099db81618d589503351e1 Author: Sudip Mukherjee AuthorDate: Thu, 6 Oct 2016 23:06:43 +0530 Committer: Thomas Gleixner CommitDate: Fri, 21 Oct 2016 10:21:38 +0200 kernel/irq: Export

Re: [PATCH] kernel: irq: fix build failure

On Thursday 06 October 2016 11:06 PM, Sudip Mukherjee wrote: The allmodconfig build of powerpc is failing with the error: ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined! export the symbol to fix the failure. Hi Thomas, powerpc and arm allmodconfig builds still fail

[PATCH] m32r: add simple dma

memory mapping. Signed-off-by: Sudip Mukherjee --- Hi Andrew, Just to let you know that this was not tested on any board. I think I have told you earlier that inspite of all my efforts I could not find any source of information to procure a board of m32r. Hi Fengguang, If Andrew accepts this patch

[PATCH] kernel: irq: fix build failure

The allmodconfig build of powerpc is failing with the error: ERROR: ".irq_set_parent" [drivers/mfd/tps65217.ko] undefined! export the symbol to fix the failure. Signed-off-by: Sudip Mukherjee --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/165418652

[PATCH] char: tb0219: fix build failure

ictim of indirect include chains" Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it") Cc: Al Viro Signed-off-by: Sudip Mukherjee --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/165143641 drivers/char/tb0219.c | 1 + 1 file changed, 1

[PATCH] watchdog: ath79_wdt: fix build failure

og/ath79_wdt.c:201:3: error: implicit declaration of function 'put_user' Quoting Al Viro - "another victim of indirect include chains" Fixes: 58a8f3b69e07 ("mips: separate extable.h, switch module.h to it") Signed-off-by: Sudip Mukherjee --- build log is at: h

Re: [m32r] undefined reference to `printk'

Hi Fengguang, On Sunday 11 September 2016 02:16 AM, Fengguang Wu wrote: Sorry m32r looks orphaned and there is no maintainer to CC such arch related error report.. Yes, its a pity that it has no maintainer. I have tried to contact the previous maintainer (Hirokazu Takata) but without any succe

[PATCH 2/3] pcmcia: m32r_pcc: use common error path

Use a common error path for the failure. Signed-off-by: Sudip Mukherjee --- drivers/pcmcia/m32r_pcc.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/pcmcia/m32r_pcc.c b/drivers/pcmcia/m32r_pcc.c index fad4455..56bf388 100644 --- a/drivers/pcmcia

[PATCH 3/3] pcmcia: m32r_pcc: check return from add_pcc_socket

If request_irq() fails it passes the error to the caller. The caller now checks it and jumps to the common error path on failure. Signed-off-by: Sudip Mukherjee --- drivers/pcmcia/m32r_pcc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pcmcia/m32r_pcc.c

[PATCH 1/3] pcmcia: m32r_pcc: check return from request_irq

turn it to the caller. Signed-off-by: Sudip Mukherjee --- m32r allmodconfig build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/160355863 drivers/pcmcia/m32r_pcc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/m32r_pcc.c b/driv

[PATCH] spi: bcm-qspi: fix build error

e (not in a function) .resume = bcm_qspi_resume, bcm_qspi_suspend() and bcm_qspi_resume() are only defined when CONFIG_PM_SLEEP is defined. Use the macro SET_SYSTEM_SLEEP_PM_OPS to use it only when CONFIG_PM_SLEEP is defined. Signed-off-by: Sudip Mukherjee --- m68k build log is at: https://

[PATCH v2] net: smsc: remove build warning of duplicate definition

definition #define SMC_outb(v, a, r) outb(v, ((u32)a) + (r)) Signed-off-by: Sudip Mukherjee --- v2: +#ifdef of v1 is removed. drivers/net/ethernet/smsc/smc91x.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/smsc/smc91x.h b/drivers/net/ethernet/smsc/smc91x.h in

[PATCH v2] MAINTAINERS: modify maintainers email of intelfb

Maik is no longer using the plusserver.de email, update with his current email. Signed-off-by: Sudip Mukherjee --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cccbb1c..17c9bd3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH] staging/android: mark sync_timeline_create() static

On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which

Re: [PATCH] staging: rtl8712: fixed comment style and space indent

On Fri, Sep 02, 2016 at 09:14:15PM +0800, Louie Lu wrote: > fixed comment style and space indent report from checkpatch > in rtl8712/rtl871x_ioctl_linux.c: > > * WARNING: Statements should start on a tabstop > * WARNING: Block comments use * on subsequent lines > * WARNING: suspect code indent for

Re: [PATCH] staging:ks7010:Fix warning about coding style spacing issue around asterisk in ks_wlan_net.c

On Wed, Aug 31, 2016 at 08:20:10PM -0400, Nicholas Krause wrote: > This fixes warning around a asterisk used in ks_wlan_net.c > for the define statement used for this driver's transmit > queue timeout value as defined by the marco, TX_TIMEOUT. > Signed-off-by: Nicholas Krause > --- Please keep a

Re: [PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test

On Sun, Sep 04, 2016 at 01:01:20PM +0200, Matthias Beyer wrote: > This patch removes the pointless `else if` test. > > Signed-off-by: Matthias Beyer > Reported-by: David Binderman > --- looks like Greg has already applied your first patch. db0c12744f8d ("drivers: staging: rtl8723au: hal: Remove

[PATCH 2/2 RESEND] staging: ks7010: fix memory leak

If the firmware request failed we were just returning but we missed freeing the memory and releasing the MMC Host. Signed-off-by: Sudip Mukherjee --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b

[PATCH 1/2 RESEND] staging: ks7010: return on failure

if it is still not claimed then mmc_host->claim_cnt will be 0 and mmc_release_host() will do "if (--host->claim_cnt)" and thus the condition will become true. Lets just return the value on allocation failure instead of trying to release the host before claiming it. Signe

Re: [PATCH] HID: usbkbd: return proper error code

On Thursday 01 September 2016 04:51 PM, Jiri Kosina wrote: On Wed, 31 Aug 2016, Sudip Mukherjee wrote: Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. But we don't. usb_kbd_probe() returns -ENOMEM in

Re: [ppdev] 8b7d3a9d90: WARNING: CPU: 0 PID: 153 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80

On Thursday 01 September 2016 02:35 AM, kernel test robot wrote: FYI, we noticed the following commit: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing commit 8b7d3a9d903ee1d1f5febc8e74223e4e72720e35 ("ppdev: use new parport device model") in testcase: b

Re: [PATCH] HID: usbkbd: return proper error code

On Wednesday 31 August 2016 10:03 PM, Fabio Estevam wrote: On Wed, Aug 31, 2016 at 1:28 PM, Sudip Mukherjee wrote: Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. Signed-off-by: Sudip Mukherjee --- drivers/hid/usbhid

[PATCH] net: smsc: remove build warning of duplicate definition

definition #define SMC_outb(v, a, r) outb(v, ((u32)a) + (r)) Signed-off-by: Sudip Mukherjee --- m32r allmodconfig build of next-20160825 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/154943795 drivers/net/ethernet/smsc/smc91x.h | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH] MAINTAINERS: modify status of intelfb as orphan

telfb: new maintainer") Signed-off-by: Sudip Mukherjee --- I think I have the hardware. Will test tomorrow. MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d8e81b1..72280d5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6148

[PATCH] HID: usbkbd: return proper error code

Use proper error code instead of using -1 on failure to allocate memory. We may use the error code later in the caller. Signed-off-by: Sudip Mukherjee --- drivers/hid/usbhid/usbkbd.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/usbhid/usbkbd.c b

[PATCH] video: fbdev: intelfb: remove impossible condition

xoffset and yoffset of struct fb_var_screeninfo are unsigned and so they can never be less than 0. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/intelfb/intelfbdrv.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev

[PATCH] Input: joystick - enable interrupts

The irq was disabled before reading from the gameport. After reading we should enable it. Instead we were restoring it back to the previous state before starting the do-while loop. Signed-off-by: Sudip Mukherjee --- drivers/input/joystick/analog.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] matroxfb: fix size of memcpy

hw->DACreg has a size of 80 bytes and MGADACbpp32 has 21. So when memcpy copies MGADACbpp32 to hw->DACreg it copies 80 bytes but only 21 bytes are valid. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

On Thu, Aug 25, 2016 at 09:59:46PM +0800, Ming-Chia Chung wrote: > On Tue, Aug 23, 2016 at 12:01:36PM +0530, Sudip Mukherjee wrote: > > On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote: > > > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: >

Re: next-20160804: Build error when building xtensa images

On Thursday 04 August 2016 06:55 PM, Max Filippov wrote: Hi Guenter, On Thu, Aug 4, 2016 at 9:30 AM, Guenter Roeck wrote: Hi Max, I see the following build errors when building xtensa images in next-20160804. Error log: arch/xtensa/kernel/built-in.o: In function `fast_alloca': (.text+0x99a):

Re: [PATCH] staging: android: ion: ion.c fix parenthesis alignment

On Wed, Aug 24, 2016 at 03:56:32AM +0700, Didik Setiawan wrote: > Fix checkpatch.pl warning about "Alignment should match open parenthesis". > --- you missed the Signed-off-by: line. regards sudip

[PATCH 2/2] staging: ks7010: fix memory leak

If the firmware request failed we were just returning but we missed freeing the memory and releasing the MMC Host. Signed-off-by: Sudip Mukherjee --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b

[PATCH 1/2] staging: ks7010: return on failure

if it is still not claimed then mmc_host->claim_cnt will be 0 and mmc_release_host() will do "if (--host->claim_cnt)" and thus the condition will become true. Lets just return the value on allocation failure instead of trying to release the host before claiming it. Signed-off-by: Sudi

Re: [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings

On Tue, Aug 23, 2016 at 03:02:21PM +, Wei Yongjun wrote: > From: Wei Yongjun > > drivers/staging/comedi/drivers/dt2811.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dt2811.c > b/drivers/staging/comedi/drivers/dt2811.c > index

[PATCH] crypto: rockchip - use devm_add_action_or_reset()

: Sudip Mukherjee --- drivers/crypto/rockchip/rk3288_crypto.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index af50825..d0f80c6 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c

[PATCH v2] staging: i4l: icn: use memdup_user

Its better to use memdup_user which does the same thing which this code has implemented. Also removed a related warning as we will be warned if allocation fails. Suggested-by: Fengguang Wu Signed-off-by: Sudip Mukherjee --- v2: removed type change done in v1, and removed a warning. drivers

Re: [PATCH] staging: i4l: icn: use memdup_user

On Tue, Aug 23, 2016 at 06:50:30AM -0400, Greg Kroah-Hartman wrote: > On Tue, Aug 23, 2016 at 03:57:34PM +0530, Sudip Mukherjee wrote: > > Its better to use memdup_user which does the same thing which this > > code has implemented. > > > > Suggested-by: Fengguang W

[PATCH] staging: i4l: icn: use memdup_user

Its better to use memdup_user which does the same thing which this code has implemented. Suggested-by: Fengguang Wu Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/icn/icn.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/staging/i4l/icn

Re: [PATCH resend] staging:xgifb:remove unused code

On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- The subject should have been [Patch v2] not resend. regards sudip

Re: [PATCH] staging:xgifb:remove unused code

On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- Your name in Signed-off-by: and From: doesnot match. > drivers/staging/xgifb/vb_setmode.c | 1 - > 1 file changed, 1 deletion(-) > > diff

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote: > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: > > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > > > This patch fixes a minor checkpatch warnings: > > > > >

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > This patch fixes a minor checkpatch warnings: > > "WARNING: Block comments use a trailing */ on a separate line" > > Signed-off-by: Ming-Chia Chung > --- > drivers/staging/rts5208/rtsx.c | 42 >

[PATCH 4/5] staging: i4l: icn: remove blank lines

Blank lines are not needed after starting brace or before a closing brace. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/icn/icn.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 1f72884..45623fa 100644 --- a

[PATCH 2/5] staging: i4l: act2000: remove unused macro

The macro EVAL_PLCI and MAKE_PLCI are not being used. Remove them. But keep the comment preceding them as it contains information regarding message format. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/act2000/capi.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers

[PATCH 5/5] staging: i4l: icn: fix incorrect type of arguments

-by: Sudip Mukherjee --- drivers/staging/i4l/icn/icn.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 45623fa..fa705db 100644 --- a/drivers/staging/i4l/icn/icn.c +++ b

[PATCH 3/5] staging: i4l: icn: space not needed after cast

No need provide a space after a typecast. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/icn/icn.c | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index

[PATCH 1/5] staging: i4l: act2000: remove unused argument

The macro EVAL_NCCI was only being used in capi.c and the argument controller was not used. Remove the argument and at the same time remove the variable which now becomes unused. Signed-off-by: Sudip Mukherjee --- drivers/staging/i4l/act2000/capi.c | 3 +-- drivers/staging/i4l/act2000/capi.h

[PATCH] phy: rockhip-usb: use devm_add_action_or_reset()

: Sudip Mukherjee --- drivers/phy/phy-rockchip-usb.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c index d60b149..dd58f23 100644 --- a/drivers/phy/phy-rockchip-usb.c +++ b/drivers/phy/phy-rockchip-usb.c

[PATCH] Input: zforce_ts - use devm_add_action_or_reset()

: Sudip Mukherjee --- drivers/input/touchscreen/zforce_ts.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/zforce_ts.c b/drivers/input/touchscreen/zforce_ts.c index 7b3845a..6053e31 100644 --- a/drivers/input/touchscreen/zforce_ts.c +++ b/drivers

Re: [PATCH] Input: axp20x-pek: use devm_add_action_or_reset

On Sunday 12 June 2016 03:12 PM, Sudip Mukherjee wrote: If devm_add_action() fails we are explicitly calling axp20x_remove_sysfs_group() to free the resources allocated. Lets use the helper devm_add_action_or_reset() and return directly in case of error, as we know that the cleanup function has

Re: [PATCH] Input: gpio-keys - use devm_add_action_or_reset

On Sunday 12 June 2016 03:28 PM, Sudip Mukherjee wrote: If devm_add_action() fails we are printing the error message and returning but we have already setup a delayed work or a timer. Lets now use the helper devm_add_action_or_reset() and return and in case of error the cleanup function will be

Re: [PATCH] Input: snvs_pwrkey - use devm_add_action_or_reset

On Sunday 12 June 2016 03:34 PM, Sudip Mukherjee wrote: If devm_add_action() fails we are printing the error message and returning but we have already setup a timer. Lets now use the helper devm_add_action_or_reset() and return and so in case of error the cleanup function will be called by the

[PATCH] rtc: abx80x: use devm_add_action_or_reset()

: Sudip Mukherjee --- drivers/rtc/rtc-abx80x.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index ba0d619..fea9a60 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -643,17 +643,15

[PATCH] rtc: m41t80: use devm_add_action_or_reset()

: Sudip Mukherjee --- drivers/rtc/rtc-m41t80.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index d1bf93a..49bc464 100644 --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c @@ -831,10 +831,9 @@ static int

Re: [PATCH v2] m32r: fix build warning about putc

On Sunday 26 June 2016 10:37 PM, Sudip Mukherjee wrote: We were getting build warning: arch/m32r/boot/compressed/m32r_sio.c:11:13: warning: conflicting types for built-in function 'putc' Here putc is used as a static function so lets just rename it to avoid the conflic

Re: [PATCH] m32r: fix build warning about putc

/Sudip-Mukherjee/m32r-fix-build-warning-about-putc/20160627-094312 config: m32r-m32104ut_defconfig (attached as .config) compiler: m32r-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross

[PATCH v2] m32r: fix build warning about putc

We were getting build warning: arch/m32r/boot/compressed/m32r_sio.c:11:13: warning: conflicting types for built-in function 'putc' Here putc is used as a static function so lets just rename it to avoid the conflict with the builtin putc. Signed-off-by: Sudip Mukherjee --

[PATCH] m32r: fix build warning about putc

We were getting build warning: arch/m32r/boot/compressed/m32r_sio.c:11:13: warning: conflicting types for built-in function 'putc' Here putc is used as a static function so lets just rename it to avoid the conflict with the builtin putc. Signed-off-by: Sudip Mukherjee --- bu

Re: linux-next: Tree for Jun 21

On Tue, Jun 21, 2016 at 04:14:35PM +0200, Peter Zijlstra wrote: > On Tue, Jun 21, 2016 at 04:04:08PM +0200, Peter Zijlstra wrote: > > > I'm not sure who builds the toolchains, but tilepro is in upstream > > > gcc/binutils/etc > > > so should be easy enough to include. There's also a cross-toolcha

Re: linux-next: Tree for Jun 21

On Tue, Jun 21, 2016 at 09:58:28AM +0200, Peter Zijlstra wrote: > On Tue, Jun 21, 2016 at 08:01:36AM +0100, Sudip Mukherjee wrote: > > > tilepro defconfig is failing while doing "make prepare" and bisect shows the > > first bad commit as: > > > >

Re: ERROR: "bad_dma_ops" [sound/core/snd-pcm.ko] undefined!

On Sunday 19 June 2016 05:15 AM, kbuild test robot wrote: Hi, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: c141afd1a28793c08c88325aa64b773be6f79ccf commit: 420520766a796d3607639ba1e4fb1aadeadd [media] media:

Re: linux-next: Tree for Jun 21

On Tuesday 21 June 2016 06:46 AM, Stephen Rothwell wrote: Hi all, Changes since 20160620: tilepro defconfig is failing while doing "make prepare" and bisect shows the first bad commit as: 1af5de9af138 ("locking/atomic, arch/tile: Implement atomic{,64}_fetch_{add,sub,and,or,xor}()") You c

Re: linux-next: Tree for Jun 20

On Monday 20 June 2016 07:05 AM, Stephen Rothwell wrote: Hi all, Changes since 20160617: I just started trying gcc 6.1.0 for mips and mips allmodconfig is failing with the error: {standard input}: Assembler messages: {standard input}:147: Error: number (0x90008000) larger than 32 bi

Re: [PATCH] ppdev: use new parport device model

On Wed, Jun 01, 2016 at 05:50:08PM +0530, Sudip Mukherjee wrote: > Modify ppdev driver to use the new parallel port device model. > > Initially submitted and committed as: > e7223f186033 ("ppdev: use new parport device model") > > But due to some regression it was

Re: USB broken on Banana Pi in Linux 4.6

On Sun, Jun 12, 2016 at 06:47:56PM +0200, Marc Haber wrote: > On Sat, Jun 11, 2016 at 02:55:04PM +0200, Marc Haber wrote: > > On Tue, Jun 07, 2016 at 10:30:17AM -0700, Greg KH wrote: > > > Nothing obvious, can you use 'git bisect' to go from 4.5.0 to 4.6.0 to > > > find the offending commit? > > >

[PATCH] net: lantiq_etop: remove unused variable

The variable i was declared but was never used and we were getting a build warning for that. Signed-off-by: Sudip Mukherjee --- drivers/net/ethernet/lantiq_etop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index

[PATCH] MIPS: Lantiq: fix build failure

r for the name. Fixes: be45beb2df69 ("genirq: Add runtime power management support for IRQ chips") Signed-off-by: Sudip Mukherjee --- build log can be seen at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/137992701 arch/mips/lantiq/irq.c | 4 ++-- 1 file changed, 2 insertions(+)

Re: [PATCH] dax: use devm_add_action_or_reset

On Tue, Jun 14, 2016 at 04:28:43PM -0700, Dan Williams wrote: > On Sun, Jun 12, 2016 at 7:48 AM, Sudip Mukherjee > wrote: > > If devm_add_action() fails we are explicitly calling the cleanup to free > > the resources allocated. Lets use the helper devm_add_action_or_rese

Re: [PATCH 3.2 00/46] 3.2.81-rc1 review

On Tuesday 14 June 2016 11:16 PM, Ben Hutchings wrote: On Tue, 2016-06-14 at 22:56 +0100, Sudip Mukherjee wrote: On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.81 release. There are 46 patches in this series, which will be posted

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

On Tuesday 14 June 2016 10:23 PM, Ben Hutchings wrote: On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote: On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: 3.2.81-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Gunthorpe commit

Re: [PATCH 3.2 00/46] 3.2.81-rc1 review

On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.81 release. There are 46 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: 3.2.81-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Gunthorpe commit e6bd18f57aad1a2d1ef40e646d03ed0f2515c9e3 upstream. The drivers/infiniband stack uses write() as a replacement for

<    1   2   3   4   5   6   7   8   9   10   >