Re: linux-next: Tree for Apr 7

2016-04-07 Thread Sudip Mukherjee
On Thursday 07 April 2016 10:59 AM, Stephen Rothwell wrote: Hi all, Changes since 20160406: All the mips builds are failing since last few days. My patch at : https://lkml.org/lkml/2016/4/4/236 fixes the build for defconfig and allmodconfig. I have not checked the patch with other builds.

[PATCH] tty: ipwireless: fix possible NULL dereference

2016-04-06 Thread Sudip Mukherjee
The function alloc_ctrl_packet() can fail and return NULL. Incase it fails print an error message and exit. Signed-off-by: Sudip Mukherjee --- drivers/tty/ipwireless/hardware.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless

[PATCH] tty: synclink: remove unneeded test

2016-04-06 Thread Sudip Mukherjee
We reach this point of code after a test of 'info->port.tty->hw_stopped', we do not need to test for 'info->port.tty' as it is obvious that info->port.tty is not NULL now, we have already dereferenced it. Signed-off-by: Sudip Mukherjee --- drivers/tty/syncl

[PATCH] proc: fix dereference of ERR_PTR

2016-04-06 Thread Sudip Mukherjee
On the unlikely event of a bad name, d_hash_and_lookup() can return the error value in ERR_PTR(). And we were only checking the return value of d_hash_and_lookup() to be NULL. In case it is not NULL and has some error then d_inode() will try to dereference it later. Signed-off-by: Sudip Mukherjee

[PATCH 1/2] lkdtm: fix memory leak of val

2016-04-05 Thread Sudip Mukherjee
This case is supposed to read from a page after after it is freed, but it missed freeing val if we are not able to get a free page. Signed-off-by: Sudip Mukherjee --- drivers/misc/lkdtm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/lkdtm.c b/drivers/misc

[PATCH 2/2] lkdtm: fix memory leak of base

2016-04-05 Thread Sudip Mukherjee
This case is supposed to read from a memory after it has been freed, but we missed freeing base if the memory 'val' could not be allocated. Signed-off-by: Sudip Mukherjee --- drivers/misc/lkdtm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc

[PATCH] staging: android: make function static

2016-04-05 Thread Sudip Mukherjee
The only user of ion_handle_put() is within the file ion.c, so we can safely make it static. Just to be double sure, checked the function ion_handle_get() which is static. So we can make ion_handle_put() static. Signed-off-by: Sudip Mukherjee --- drivers/staging/android/ion/ion.c | 2 +- 1 file

[PATCH] staging/lustre/obdclass: fix build warning

2016-04-05 Thread Sudip Mukherjee
While building with W=1 we were getting the warning: drivers/staging/lustre/lustre/obdclass/cl_object.c:1056:16: warning: old-style function definition struct lu_env *cl_env_percpu_get() ^ Signed-off-by: Sudip Mukherjee --- drivers/staging/lustre/lustre/obdclass

[PATCH] staging: comedi: das1800: remove unused variable

2016-04-05 Thread Sudip Mukherjee
The variable unipolar was never used. Signed-off-by: Sudip Mukherjee --- There may be a chance that reading from DAS1800_CONTROL_C is necessary before reading from DAS1800_STATUS. If that is true then please discard this patch. drivers/staging/comedi/drivers/das1800.c | 3 --- 1 file changed

Re: [PATCH v2] parport: register driver later

2016-04-05 Thread Sudip Mukherjee
On Tuesday 05 April 2016 06:28 PM, Greg KH wrote: On Tue, Apr 05, 2016 at 06:26:08AM +0100, Sudip Mukherjee wrote: On Mon, Mar 07, 2016 at 10:32:55AM -0700, Ross Zwisler wrote: On Sun, Mar 06, 2016 at 08:40:10PM +0530, Sudip Mukherjee wrote: If the parport bus is not yet registered and any

Re: [PATCH v2] parport: register driver later

2016-04-05 Thread Sudip Mukherjee
On Mon, Apr 04, 2016 at 11:13:12PM -0700, Linus Torvalds wrote: > On Mar 6, 2016 7:10 AM, "Sudip Mukherjee" > wrote: > > > > > Hi Ross, > > Can you please test this patch in your setup. This is a respin of the > > previous patch in another way. >

Re: [PATCH v2] parport: register driver later

2016-04-04 Thread Sudip Mukherjee
On Mon, Mar 07, 2016 at 10:32:55AM -0700, Ross Zwisler wrote: > On Sun, Mar 06, 2016 at 08:40:10PM +0530, Sudip Mukherjee wrote: > > If the parport bus is not yet registered and any device using parallel > > port tries to register with the bus we get a stackdump with a message &g

Re: [PATCH][RESEND] parport: parport_pc: PCI SIO access should also depend on SIO option

2016-04-04 Thread Sudip Mukherjee
On Tue, Mar 29, 2016 at 12:00:56AM +0200, Maciej S. Szmigiero wrote: > CONFIG_PARPORT_PC_SUPERIO toggles Super IO chip support in parport_pc > code, however only code accessing SIO chip via ISA (or LPC) bus was > conditional on it. > > This patch makes SIO chip accesses via PCI bus also dependent

Re: linux-next: Tree for Apr 4

2016-04-04 Thread Sudip Mukherjee
On Monday 04 April 2016 09:39 AM, Stephen Rothwell wrote: Hi all, Changes since 20160401: s390 allmodconfig build fails with the error: arch/s390/crypto/ghash_s390.c:14:24: fatal error: crypt_s390.h: No such file or directory #include "crypt_s390.h" ^ build log is at

[PATCH] MIPS: remove duplicate definition

2016-04-04 Thread Sudip Mukherjee
quot;MIPS: Make flush_thread and exit_thread inline.") Signed-off-by: Sudip Mukherjee --- build log of next-20160404 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/120536697 (defconfig) https://travis-ci.org/sudipm-mukherjee/parport/jobs/120536714 (allmodconfig) patch has been build t

Re: [PATCH v2] block: fix possible NULL dereference

2016-04-01 Thread Sudip Mukherjee
On Fri, Apr 01, 2016 at 08:38:23AM -0600, Jens Axboe wrote: > On 04/01/2016 08:34 AM, Sudip Mukherjee wrote: > >We were checking for iter to be NULL after dereferencing it. There is > >actually no need to check for iter to be NULL as all the callers of > >blk_rq_map_user_iov(

[PATCH v2] block: fix possible NULL dereference

2016-04-01 Thread Sudip Mukherjee
ter checking for it. Signed-off-by: Sudip Mukherjee --- v2: removed the check for iter v1: moved the assignment to copy after check for iter and iter->count block/blk-map.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/blk-map.c b/block/blk-map.c index a54f054..e

[PATCH] s390: fix build failure

2016-04-01 Thread Sudip Mukherjee
bers were moved into inline function defined in asm-generic header but the asm-generic header was not being used by s390. Fixes: 5adddb612ca1 ("seccomp: Get compat syscalls from asm-generic header") Cc: Matt Redfearn Signed-off-by: Sudip Mukherjee --- Tested with s390 defconfig and allmodco

[PATCH] MIPS: ath79: fix build failure

2016-03-30 Thread Sudip Mukherjee
c __init int ath79_setup(void) ^ arch/mips/ath79/setup.c:299:1: error: initializer element is not constant arch_initcall(ath79_setup); It turns out to be a simple error of a missed closing brace. Fixes: f63ba725caa7 ("MIPS: ath79: Disable platform code for OF boards.")

Re: linux-next: build failure after merge of the aio tree

2016-03-15 Thread Sudip Mukherjee
On Tue, Mar 15, 2016 at 05:46:34PM +1100, Stephen Rothwell wrote: > Hi Benjamin, > > After merging the aio tree, today's linux-next build (powerpc > ppc44x_defconfig) failed like this: > > fs/built-in.o: In function `aio_thread_op_foo_at': > aio.c:(.text+0x4dab4): undefined reference to `__get_us

Re: [PATCH] i2c: i2c-core: do not use bus internal data

2016-03-14 Thread Sudip Mukherjee
On Mon, Mar 14, 2016 at 10:28:10AM +0100, Wolfram Sang wrote: > > > This doesn't work. I see a number of these WARN_ON()s trigger and I > > think the reason is that i2c_init() always fails now. The cause seems to > > be that i2c_init() calls i2c_add_driver(&dummy_driver), which will now > > always

Re: [PATCH] i2c: immediately mark ourselves as registered

2016-03-14 Thread Sudip Mukherjee
On Mon, Mar 14, 2016 at 10:53:26AM +0100, Wolfram Sang wrote: > Mark the i2c bus as registered right after the the bus_register call, > not at the end of init. Otherwise, we can't register our own dummy > driver. > > Reported-by: Thierry Reding > Signed-off-by: Wolfram Sang > Fixes: 95026658c46e

Re: [lkp] [i2c] 95026658c4: WARNING: CPU: 0 PID: 1 at drivers/i2c/i2c-core.c:1930 i2c_register_driver+0x2c/0x79()

2016-03-14 Thread Sudip Mukherjee
On Mon, Mar 14, 2016 at 02:14:19AM +0100, Wolfram Sang wrote: > On Mon, Mar 14, 2016 at 08:47:59AM +0800, kernel test robot wrote: > > FYI, we noticed the below changes on > > > > https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux i2c/for-next > > commit 95026658c46ea2d94498d0dac1282e28cd47

[PATCH] ASoC: qcom: fix build error

2016-03-11 Thread Sudip Mukherjee
From: Sudip Mukherjee While building m32r allmodconfig the build failed with: ERROR: "bad_dma_ops" [sound/soc/qcom/snd-soc-lpass-platform.ko] undefined! ERROR: "dma_common_mmap" [sound/soc/qcom/snd-soc-lpass-platform.ko] undefined! To satisfy the dependency CONFIG_SND_SOC_L

[PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

2016-03-11 Thread Sudip Mukherjee
Acked-by: Michael Büsch Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/broadcom/b43/main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c index 72380af..b0603e7 100644 --- a

Re: [PATCH] b43: fix memory leak

2016-03-10 Thread Sudip Mukherjee
On Thursday 10 March 2016 11:13 PM, Michael Büsch wrote: On Fri, 19 Feb 2016 20:37:18 +0530 Sudip Mukherjee wrote: https://patchwork.kernel.org/patch/8049041/ I have an old laptop running on 800Mhz CPU. It has "Broadcom BCM4311 [14e4:4311] (rev 01)". I will try to test it on th

Re: [PATCH] ld-version: Fix awk regex compile failure

2016-03-10 Thread Sudip Mukherjee
dd ld-version and ld-ifversion ...") Reported-by: Geert Uytterhoeven Signed-off-by: James Hogan This error was only coming in my gitlab builds but was not showing in the build of travis-ci. Maybe it depends on the version of awk also. Build log at: https://gitlab.com/sudipm/linux-next/builds

Re: [PATCH] avr32: fix asm operand constraint in cmpxchg()

2016-03-10 Thread Sudip Mukherjee
which makes the compiler use a temporary register for out of range constants. Signed-off-by: Mans Rullgard build log at: https://gitlab.com/sudipm/linux-next/builds/839572 Tested-by: Sudip Mukherjee regards sudip

[PATCH] serial-uartlite: fix build warning

2016-03-10 Thread Sudip Mukherjee
rivers/tty/serial/uartlite.c:354:22: warning: assignment discards 'const' qualifier from pointer target type port->private_data = &uartlite_le; ^ Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le") Signed-off-by: Sudi

[PATCH] ntb: fix possible NULL dereference

2016-03-10 Thread Sudip Mukherjee
kmalloc can fail and we should check for NULL before using the pointer returned by kmalloc. Signed-off-by: Sudip Mukherjee --- drivers/ntb/test/ntb_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index c8a37ba..b21e647

[PATCH] block: fix possible NULL dereference

2016-03-10 Thread Sudip Mukherjee
We were checking for iter to be NULL after dereferencing it. Lets first check it and then use it. Signed-off-by: Sudip Mukherjee --- block/blk-map.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/blk-map.c b/block/blk-map.c index a54f054..089ed59 100644 --- a/block

Re: avr32 build failures in linux-next

2016-03-09 Thread Sudip Mukherjee
On Thursday 10 March 2016 01:20 AM, Måns Rullgård wrote: Andy Shevchenko writes: On Tue, Feb 9, 2016 at 6:02 AM, Guenter Roeck wrote: On 02/08/2016 08:06 AM, Andy Shevchenko wrote: On Sat, Feb 6, 2016 at 7:28 PM, Måns Rullgård wrote: Not very surprising either. The number of people usi

[PATCH] ASoC: rt5640: remove unused variable

2016-03-08 Thread Sudip Mukherjee
From: Sudip Mukherjee We are getting build warning about: sound/soc/codecs/rt5640.c:1892:11: warning: unused variable 'dai_sel' The use of the variable was removed but the variable itself was not removed. Fixes: c467fc0e010b ("ASoC: rt5640: Set PLL src according to source&

Re: [PATCH] i2c: i2c-core: do not use bus internal data

2016-03-07 Thread Sudip Mukherjee
On Monday 07 March 2016 10:27 PM, Greg KH wrote: On Mon, Mar 07, 2016 at 05:19:17PM +0530, Sudip Mukherjee wrote: The variable p is a data structure which is used by the driver core internally and it is not expected that busses will be directly accessing these driver core internal only data

[PATCH] i2c: i2c-core: do not use bus internal data

2016-03-07 Thread Sudip Mukherjee
The variable p is a data structure which is used by the driver core internally and it is not expected that busses will be directly accessing these driver core internal only data. Signed-off-by: Sudip Mukherjee --- Reference of Greg's comment about it at: https://lkml.org/lkml/2016/3/

[PATCH] spmi: do not use bus internal data

2016-03-07 Thread Sudip Mukherjee
The variable p is a data structure which is used by the driver core internally and it is not expected that busses will be directly accessing these driver core internal only data. Signed-off-by: Sudip Mukherjee --- Reference of Greg's comment about it at: https://lkml.org/lkml/2016/3/

Re: [PATCH] iio: adc: imx25-gcq: fix do_div

2016-03-07 Thread Sudip Mukherjee
On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote: > Hi, > > On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote: > > On 03/03/16 12:51, Sudip Mukherjee wrote: > > > We are getting build failure with tilepro allmodconfig with the error: > > >

[PATCH] [media] dw2102: fix unreleased firmware

2016-03-07 Thread Sudip Mukherjee
On the particular case when the product id is 0x2101 we have requested for a firmware but after processing it we missed releasing it. Signed-off-by: Sudip Mukherjee --- drivers/media/usb/dvb-usb/dw2102.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb/dw2102.c

[PATCH] [media] cx231xx: fix memory leak

2016-03-07 Thread Sudip Mukherjee
When we returned on error we missed freeing p_current_fw and p_buffer. Signed-off-by: Sudip Mukherjee --- drivers/media/usb/cx231xx/cx231xx-417.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c index

[PATCH] nfsd: recover: fix memory leak

2016-03-07 Thread Sudip Mukherjee
nfsd4_cltrack_grace_start() will allocate the memory for grace_start but when we returned due to error we missed freeing it. Signed-off-by: Sudip Mukherjee --- fs/nfsd/nfs4recover.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c index 195fe26

Re: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct

2016-03-06 Thread Sudip Mukherjee
On Mon, Feb 29, 2016 at 11:15:51AM +0900, Daeseok Youn wrote: > From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 > From: Daeseok Youn > Date: Thu, 25 Feb 2016 14:53:37 +0900 > Subject: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct These lines above are not requir

Re: [PATCH] parport: register driver later

2016-03-06 Thread Sudip Mukherjee
On Sat, Mar 05, 2016 at 12:19:32PM -0800, Greg KH wrote: > On Fri, Mar 04, 2016 at 04:20:59PM +0530, Sudip Mukherjee wrote: > > If the parport bus is not yet registered and any device using parallel > > port tries to register with the bus we get a stackdump with a message &g

[PATCH v2] parport: register driver later

2016-03-06 Thread Sudip Mukherjee
If the parport bus is not yet registered and any device using parallel port tries to register with the bus we get a stackdump with a message of Kernel bug. Reported-by: Fengguang Wu Cc: # 4.2+ Signed-off-by: Sudip Mukherjee --- Hi Ross, Can you please test this patch in your setup. This is a

[PATCH] v4l2-mc.h: fix build failure

2016-03-04 Thread Sudip Mukherjee
utines") Signed-off-by: Sudip Mukherjee --- build logs at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/113601228 and https://travis-ci.org/sudipm-mukherjee/parport/jobs/113601203 include/media/v4l2-mc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/inclu

[PATCH v2] ASoC: pcm3168a: remove unused variable

2016-03-04 Thread Sudip Mukherjee
From: Sudip Mukherjee While building we were getting build warning about: sound/soc/codecs/pcm3168a.c:403:21: warning: variable 'channels' set but not used The variable channels were being assigned some value but that was never reused. Signed-off-by: Sudip Mukherjee --- v2: Fro

[PATCH] parport: register driver later

2016-03-04 Thread Sudip Mukherjee
If the parport bus is not yet registered and any device using parallel port tries to register with the bus we get a stackdump with a message of Kernel bug. Reported-by: Fengguang Wu Tested-by: Ross Zwisler Cc: # 4.2+ Signed-off-by: Sudip Mukherjee --- We should actually have some deferred

[PATCH] ASoC: pcm3168a: remove unused variable

2016-03-03 Thread Sudip Mukherjee
While building we were getting build warning about: sound/soc/codecs/pcm3168a.c:403:21: warning: variable 'channels' set but not used The variable channels were being assigned some value but that was never reused. Signed-off-by: Sudip Mukherjee --- Its upto you now. If you dont want

[PATCH] mvumi: fix build warning

2016-03-03 Thread Sudip Mukherjee
FIG_PM is defined as mentioned in the mvumi_pci_driver. Signed-off-by: Sudip Mukherjee --- drivers/scsi/mvumi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 02360de..d9d0736 100644 --- a/drivers/scsi/mvumi.c +++ b/drivers/scsi/mvumi.

[PATCH] iio: adc: imx25-gcq: fix do_div

2016-03-03 Thread Sudip Mukherjee
long unsigned int *}' but argument is of type 'u32 * {aka unsigned int *}' Create a temporary variable of type u64 and use that in do_div. Signed-off-by: Sudip Mukherjee --- tilepro allmodconfig build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/113325889

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

2016-03-03 Thread Sudip Mukherjee
On Mon, Jan 25, 2016 at 03:12:57PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 25 Jan 2016 22:32:31 +0530 > Sudip Mukherjee escreveu: > > > On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > > > Em Fri, 18 Dec 2015 18:35:29 +0530 > &g

Re: linux-next: Tree for Mar 3

2016-03-03 Thread Sudip Mukherjee
On Thu, Mar 03, 2016 at 04:30:18PM +0530, Sudip Mukherjee wrote: > On Thu, Mar 03, 2016 at 05:09:26PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20160302: > > With next-20160301 and next-20160302 I am having problem in allmodconfig > bu

Re: linux-next: Tree for Mar 3

2016-03-03 Thread Sudip Mukherjee
On Thu, Mar 03, 2016 at 05:09:26PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20160302: With next-20160301 and next-20160302 I am having problem in allmodconfig build of x86_64. The error being: In file included from builtin-check.c:32:0: elf.h:22:18: fatal error: gelf.h: No such

Re: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153!

2016-03-02 Thread Sudip Mukherjee
On Wed, Mar 02, 2016 at 02:24:22PM -0700, Ross Zwisler wrote: > On Mon, Feb 15, 2016 at 4:50 AM, Sudip Mukherjee > wrote: > > On Mon, Feb 15, 2016 at 04:20:45PM +0800, kernel test robot wrote: > >> Greetings, > >> > >> 0day kernel testing robot got the

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Sudip Mukherjee
On Wednesday 02 March 2016 06:50 PM, Mark Brown wrote: On Wed, Mar 02, 2016 at 12:27:09PM +, One Thousand Gnomes wrote: Sudip Mukherjee wrote: My From: is Sudip Mukherjee and my Signed-off-by: is Sudip Mukherjee My From name and Signed-off name matches. But my emails donot match

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Sudip Mukherjee
On Wed, Mar 02, 2016 at 12:27:09PM +, One Thousand Gnomes wrote: > On Wed, 2 Mar 2016 11:56:28 +0530 > Sudip Mukherjee wrote: > > > On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > > > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: &g

[PATCH] ALSA: portman2x4: fix NULL pointer dereference

2016-03-02 Thread Sudip Mukherjee
is created. Fixes: e6a1b7e88046 ("ALSA: portman2x4 - use new parport device model") Signed-off-by: Sudip Mukherjee --- sound/drivers/portman2x4.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c ind

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-01 Thread Sudip Mukherjee
On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > > > Can i not keep using my gmail as my From: ? > > The advantage of using gmail as my From: is that the discussion and all > > threads related

[PATCH] rtc: rtc-vr41xx: remove unused function

2016-03-01 Thread Sudip Mukherjee
We were getting build warning about: drivers/rtc/rtc-vr41xx.c:228:12: warning: ‘vr41xx_rtc_alarm_irq_enable’ defined but not used The function vr41xx_rtc_alarm_irq_enable() was not used anywhere. Signed-off-by: Sudip Mukherjee --- build log is at: https://travis-ci.org/sudipm-mukherjee/parport

[PATCH] rtc: rtc-generic: use correct header file

2016-03-01 Thread Sudip Mukherjee
rtc_time' Apart from m32r, many other arch like xtensa, sparc are failing with: drivers/rtc/rtc-generic.c:12:21: fatal error: asm/rtc.h: No such file or directory Other rtc drivers are using asm-generic/rtc.h, so use it here. Fixes: 2a32c792f1c9 ("rtc: enable COMPILE_TEST") Signed-

Re: [PATCH] ASoC: intel: remove unused variable

2016-02-29 Thread Sudip Mukherjee
On Tue, Mar 01, 2016 at 11:59:12AM +0900, Mark Brown wrote: > On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote: > > The variable cmd_id is only assigned some value and is never used. > > > > Signed-off-by: Sudip Mukherjee > > Your signoff doesn't c

[PATCH] video: fbdev: sis: remove unused variable

2016-02-29 Thread Sudip Mukherjee
The variables modeflag and resinfo were only assigned some value but were never used. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/sis/init301.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis

[PATCH] ASoC: intel: remove unused variable

2016-02-29 Thread Sudip Mukherjee
The variable cmd_id is only assigned some value and is never used. Signed-off-by: Sudip Mukherjee --- sound/soc/intel/atom/sst/sst_ipc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c index 3dc7358..8afa6fe 100644

Re: [PATCH] ASoC: qcom: add dependency on HAS_DMA

2016-02-29 Thread Sudip Mukherjee
On Monday 29 February 2016 07:55 PM, Sudip Mukherjee wrote: m32r allmodconfig build is failing with the error: ERROR: "bad_dma_ops" [sound/soc/qcom/snd-soc-lpass-platform.ko] undefined! ERROR: "dma_common_mmap" [sound/soc/qcom/snd-soc-lpass-platform.ko] undefined! lpass-plat

Re: [PATCH] ALSA: mts64: fix NULL pointer dereference

2016-02-29 Thread Sudip Mukherjee
On Mon, Feb 29, 2016 at 01:24:24PM +0100, Takashi Iwai wrote: > On Mon, 29 Feb 2016 13:13:30 +0100, > Sudip Mukherjee wrote: > > > > While registering pardev, the irq_func was also registered. As a > > result when we tried to probe for the card, an interrupt was generat

[PATCH] ASoC: qcom: add dependency on HAS_DMA

2016-02-29 Thread Sudip Mukherjee
lso add the same for SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_APQ8016 as they will also select SND_SOC_LPASS_PLATFORM. Signed-off-by: Sudip Mukherjee --- m32r allmodconfig build for next-20160229 is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/112534168 sound/soc/qcom/Kconfig | 3 +++ 1 file c

[PATCH] ALSA: mts64: fix NULL pointer dereference

2016-02-29 Thread Sudip Mukherjee
mts64 is created. Reported-by: Fengguang Wu Fixes: 94a573500d48 ("ALSA: mts64: use new parport device model") Signed-off-by: Sudip Mukherjee --- sound/drivers/mts64.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sound/drivers/mts64.c b/sound/drivers/mts

[PATCH 3/4] staging: dgnc: unregister pci driver

2016-02-27 Thread Sudip Mukherjee
with the error: "Driver 'dgnc' is already registered." Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index 1d1

[PATCH 4/4] staging: dgnc: cleanup properly

2016-02-27 Thread Sudip Mukherjee
dgnc_remove_driver_sysfiles() depending on the argument passed to it. Reported-by: Navy Cheng Signed-off-by: Sudip Mukherjee --- Hi Greg, If you remember this problem was reported by Navy Cheng on the kernelnewbies list but his report did not contain the call trace. He just reported that his system hangs after reloading

[PATCH 2/4] staging: dgnc: remove pci_unregister_driver

2016-02-27 Thread Sudip Mukherjee
with the error code. Signed-off-by: Sudip Mukherjee --- drivers/staging/dgnc/dgnc_driver.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c index c32f208..1d1d5c8 100644 --- a/drivers

[PATCH 1/4] staging: dgnc: remove unneeded else

2016-02-27 Thread Sudip Mukherjee
If pci_enable_device() fails then we can return directly. Signed-off-by: Sudip Mukherjee --- I saw there is some pending dgnc patch in outreachy, so this series might not apply. This series is based on staging-testing. I will resend v2 if it fails. drivers/staging/dgnc/dgnc_driver.c | 14

[PATCH v2] osd: remove deadcode

2016-02-24 Thread Sudip Mukherjee
The variable is_ver1 is always true and so OSD_CAP_LEN can never be used. Reported by Coverity. Signed-off-by: Sudip Mukherjee --- v2: Joe Perches asked to mention the tool used in the commit log. drivers/scsi/osd/osd_initiator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v2] tty: audit: remove unused variable

2016-02-24 Thread Sudip Mukherjee
is no need of audit_get_loginuid() also. Signed-off-by: Sudip Mukherjee --- v2: audit_get_loginuid() also removed. drivers/tty/tty_audit.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c index 66d53fc..df2d735 100644

[PATCH] imm: check parport_claim

2016-02-24 Thread Sudip Mukherjee
parport_claim() can fail and we should be checking if we were able to claim the port. Signed-off-by: Sudip Mukherjee --- drivers/scsi/imm.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c index f8b88fa..9164ce12 100644 --- a

[PATCH] osd: remove deadcode

2016-02-24 Thread Sudip Mukherjee
The variable is_ver1 is always true and so OSD_CAP_LEN can never be used. Signed-off-by: Sudip Mukherjee --- drivers/scsi/osd/osd_initiator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index d8a2b51

Re: linux-next: Tree for Feb 17

2016-02-23 Thread Sudip Mukherjee
On Wednesday 17 February 2016 11:07 PM, David Daney wrote: On 02/17/2016 03:52 AM, Sudip Mukherjee wrote: On Wed, Feb 17, 2016 at 04:39:21PM +1100, Stephen Rothwell wrote: Hi all, Changes since 20160216: since last few days build of mips cavium_octeon_defconfig is failing with the error

[PATCH] fbdev: n411: check return value

2016-02-23 Thread Sudip Mukherjee
We were not checking the return value of platform_device_add_data() which can fail. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/n411.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/n411.c b/drivers/video/fbdev/n411.c index

[PATCH] clk: shmobile: check for failure

2016-02-23 Thread Sudip Mukherjee
We were not checking the return from devm_add_action() which can fail. Start using the helper devm_add_action_or_reset() and return directly as we know that the cleanup has been done by this helper. Signed-off-by: Sudip Mukherjee --- I think this will go throuh clk tree, so this doesnot have to

[PATCH] tty: audit: remove unused variable

2016-02-23 Thread Sudip Mukherjee
While building with W=1 we were getting build warning: drivers/tty/tty_audit.c:149:16: warning: variable 'sessionid' set but not used The local variable sessionid was only assigned the value of current->sessionid but was never reused. Signed-off-by: Sudip Mukherjee --- drivers/tt

[PATCH] netfilter: xt_osf: remove unused variable

2016-02-23 Thread Sudip Mukherjee
TS was not removed so that it will serve as a reminder to us that we can do something in that particular case. Signed-off-by: Sudip Mukherjee --- net/netfilter/xt_osf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/xt_osf.c b/net/netfilter/xt_osf.c index 4e3c3af..2455b69 10

[PATCH] netcp: use pointer to fix build fail

2016-02-22 Thread Sudip Mukherjee
9:2: warning: initialization from incompatible pointer type .ndo_setup_tc = netcp_setup_tc, ^ The callback of ndo_setup_tc should be: int (*ndo_setup_tc)(struct net_device *dev, u32 handle, __be16 protocol, struct tc_to_netdev *tc); But we missed marking the last argument

[PATCH] ALSA: mts64: use new parport device model

2016-02-22 Thread Sudip Mukherjee
port subsystem and the temporary device to probe mts64 card is removed and mts64_probe() is used in the probe callback. Signed-off-by: Sudip Mukherjee --- exactly same changes as done in portman2x4. BTW, there is one portman2x4 available on ebay. I was bidding for it but someone is more desperate

[PATCH] ASoC: topology: fix build warning

2016-02-22 Thread Sudip Mukherjee
any use of get_dobj_mixer_type(). Fixes: 64527e8a3529 ("ASoC: topology: Add FE DAIs dynamically") CC: Mengdong Lin Signed-off-by: Sudip Mukherjee --- sound/soc/soc-topology.c | 45 - 1 file changed, 45 deletions(-) diff --git a/sound/soc/so

[PATCH] ASoC: fix memory leak

2016-02-22 Thread Sudip Mukherjee
off-by: Sudip Mukherjee --- sound/soc/soc-core.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 790ee2b..d2e62b15 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -986,16 +986,16 @@ static

Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

2016-02-19 Thread Sudip Mukherjee
On Friday 19 February 2016 09:43 PM, David Miller wrote: From: Sudip Mukherjee Date: Fri, 19 Feb 2016 13:59:09 +0530 On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: From: Sudip Mukherjee Date: Sat, 13 Feb 2016 19:33:15 +0530 The builds of allmodconfig of s390, m68k, tilegx

Re: [PATCH] b43: fix memory leak

2016-02-19 Thread Sudip Mukherjee
On Friday 19 February 2016 01:14 PM, Kalle Valo wrote: Michael Büsch writes: On Thu, 18 Feb 2016 18:04:36 +0530 Sudip Mukherjee wrote: From: Sudip Mukherjee On error we jumped to the label bcma_out and returned the error code but we missed freeing dev. Signed-off-by: Sudip Mukherjee

[PATCH] gpio: pisosr: add missing unlock

2016-02-19 Thread Sudip Mukherjee
If spi_read() fails then we just returned but we missed unlocking the mutex. Signed-off-by: Sudip Mukherjee --- drivers/gpio/gpio-pisosr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index 58ea08d..f9f1074 100644

Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO

2016-02-19 Thread Sudip Mukherjee
On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: > From: Sudip Mukherjee > Date: Sat, 13 Feb 2016 19:33:15 +0530 > > > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > > with the error: > > drivers/net/phy/spi_ks8995.c:477:3: err

[PATCH] b43: fix memory leak

2016-02-18 Thread Sudip Mukherjee
From: Sudip Mukherjee On error we jumped to the label bcma_out and returned the error code but we missed freeing dev. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/broadcom/b43/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/b43/main.c b

Re: [PATCH v5] portman2x4 - use new parport device model

2016-02-18 Thread Sudip Mukherjee
On Thu, Feb 18, 2016 at 11:20:28AM +0100, Takashi Iwai wrote: > On Wed, 17 Feb 2016 13:56:27 +0100, > Sudip Mukherjee wrote: > > > > Modify portman driver to use the new parallel port device model. > > The advantage of using the device model is that the device gets binded

[PATCH RESEND] dpt_i2o: fix build warning

2016-02-18 Thread Sudip Mukherjee
We were getting build warning about: drivers/scsi/dpt_i2o.c:183:29: warning: 'dptids' defined but not used dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not defined then dptids[] becomes unused. Reviewed-by: Johannes Thumshirn Signed-off-by: Sudip Mukherjee ---

Re: [PATCH v2] [SCSI] dpt_i2o: use proper pci driver

2016-02-17 Thread Sudip Mukherjee
On Wednesday 17 February 2016 07:57 PM, One Thousand Gnomes wrote: On Wed, 17 Feb 2016 17:50:14 +0530 Sudip Mukherjee wrote: This is a pci device but was not done in the usual way a pci driver is done. Convert the driver into a proper pci driver. This looks completely wrong. Please read the

[PATCH v5] portman2x4 - use new parport device model

2016-02-17 Thread Sudip Mukherjee
port subsystem and the temporary device to probe portman card is removed and portman_probe() is used in the probe callback. Signed-off-by: Sudip Mukherjee --- v5: claimed flag and one call to parport_claim() removed. v4: temporary device to probe is removed. v3: changed commit message v2: 1

[PATCH v2] [SCSI] dpt_i2o: use proper pci driver

2016-02-17 Thread Sudip Mukherjee
This is a pci device but was not done in the usual way a pci driver is done. Convert the driver into a proper pci driver. Signed-off-by: Sudip Mukherjee --- v1: only build warning related to "dptids defined but not used" was fixed using #ifdef drivers/scsi/dpt_i

Re: linux-next: Tree for Feb 17

2016-02-17 Thread Sudip Mukherjee
On Wed, Feb 17, 2016 at 04:39:21PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20160216: since last few days build of mips cavium_octeon_defconfig is failing with the error: arch/mips/include/asm/octeon/cvmx.h:60:39: fatal error: asm/octeon/cvmx-ciu3-defs.h: No such file or

Re: [PATCH] [SCSI] dpt_i2o: fix build warning

2016-02-16 Thread Sudip Mukherjee
On Tuesday 16 February 2016 02:47 PM, Johannes Thumshirn wrote: On Tue, Feb 16, 2016 at 02:07:36PM +0530, Sudip Mukherjee wrote: We were getting build warning about: drivers/scsi/dpt_i2o.c:183:29: warning: ‘dptids’ defined but not used dptids[] is only used in the MODULE_DEVICE_TABLE so when

[PATCH v4] portman2x4 - use new parport device model

2016-02-16 Thread Sudip Mukherjee
port subsystem and the temporary device to probe portman card is removed and portman_probe() is used in the probe callback. Signed-off-by: Sudip Mukherjee --- v4: temporary device to probe is removed. v3: changed commit message v2: 1. pardev_cb is initialized while declaring, thus removing the

[PATCH] [SCSI] dpt_i2o: fix build warning

2016-02-16 Thread Sudip Mukherjee
We were getting build warning about: drivers/scsi/dpt_i2o.c:183:29: warning: ‘dptids’ defined but not used dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not defined then dptids[] becomes unused. Signed-off-by: Sudip Mukherjee --- drivers/scsi/dpt_i2o.c | 3 +++ 1 file

[PATCH] igmp: fix build warning

2016-02-16 Thread Sudip Mukherjee
CONFIG_IP_MULTICAST is defined. Mark them as '__maybe_unused'. Signed-off-by: Sudip Mukherjee --- net/ipv4/igmp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 7c95335..0ba241b 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c

[PATCH] btrfs: fix build warning

2016-02-16 Thread Sudip Mukherjee
used. But gcc is not able to understand that and we can initialize it while declaring to silence the warning. Signed-off-by: Sudip Mukherjee --- fs/btrfs/extent-tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index e2287c

Re: [ppdev] e7223f1860: kernel BUG at drivers/base/driver.c:153!

2016-02-15 Thread Sudip Mukherjee
esting > > commit e7223f18603374d235d8bb0398532323e5f318b9 > Author: Sudip Mukherjee > AuthorDate: Fri Feb 12 18:33:45 2016 +0530 > Commit: Greg Kroah-Hartman > CommitDate: Sun Feb 14 17:43:50 2016 -0800 > > ppdev: use new parport device model > > Modify ppdev

<    1   2   3   4   5   6   7   8   9   10   >