On Sat, Dec 12, 2015 at 01:12:21AM -0500, Sanidhya Solanki wrote:
> Thank you everyone for your concern regarding my email client.
>
> Unfortunately, there is a bug in "git send-email" that leads to the gmail
> SMTP server rejecting certain patches sent by the git command.
Is it? I am using git
On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> > > This patch does the following:
> > > * changed the complicated i
On Sat, Dec 12, 2015 at 11:57:45AM +0300, Dan Carpenter wrote:
> On Fri, Dec 11, 2015 at 09:24:16PM -0500, Sanidhya Solanki wrote:
> > On Fri, 11 Dec 2015 16:02:33 +0300
> > Dan Carpenter wrote:
> >
> > > On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> > > > >From 1dbe78ce9803
We were getting build warning about unused variable "tsc_msr" and
"va_tsc" while building for i386 allmodconfig.
Signed-off-by: Sudip Mukherjee
---
build warning with next-20151211 and build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206
---
We were getting build warning about unused variables "vpd_pg83" and "d"
Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()")
Cc: Hannes Reinecke
Signed-off-by: Sudip Mukherjee
---
build warning with next-20151211 and build log is at:
https://travis-ci.org
On Fri, Dec 11, 2015 at 01:52:11PM +0800, Jandy Gou wrote:
> drivers/staging/rtl8192u/r8192U_core.c:3212:6: warning: symbol
> 'rtl819x_watchdog_wqcallback' was not declared. Should it be static?
> drivers/staging/rtl8192u/r8192U_core.c:3276:6: warning: symbol
> 'watch_dog_timer_callback' was not de
On Thu, Dec 10, 2015 at 06:31:09PM -0500, Benjamin Young wrote:
> From 4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5 Mon Sep 17 00:00:00 2001
> From: Benjamin Young
> Date: Thu, 10 Dec 2015 17:31:00 -0500
> Subject: [PATCH] staging: goldfish: Coding Style Fix - spaces preferred around
> that '+'
Rega
On Wed, Dec 09, 2015 at 03:46:02PM -0800, Benjamin Young wrote:
> From f18a3e5f155f5258d2d19ac6b56bfaafa2ad470b Mon Sep 17 00:00:00 2001
> From: Benjamin Young
> Date: Wed, 9 Dec 2015 13:45:00 -0800
> Subject: [PATCH] Fixed coding style problems based on checkpatch.pl for
> goldfish_audio.c
This
On Fri, Nov 20, 2015 at 11:17:55AM +0100, Richard Weinberger wrote:
> Am 20.11.2015 um 11:14 schrieb Sudip Mukherjee:
> > We are checking dfs_rootdir for error value or NULL. But in the
> > conditional ternary operator we returned -ENODEV if dfs_rootdir contains
> > an err
On Mon, Nov 16, 2015 at 06:27:15PM +0530, Sudip Mukherjee wrote:
> In case of invalid number_destination_params we were returning error but
> we missed releasing cmd. Lets check for the number of parameter before
> allocating memory so that we don't have a memory leak.
>
>
On Thu, Oct 08, 2015 at 06:17:48PM +0530, Sudip Mukherjee wrote:
> We are allocating backing using psbfb_alloc() and so
> backing->stolen is always true. So we were freeing backing two times.
> Moreover if we follow the execution path then we should be freeing
> backing after we ha
On Tue, Sep 15, 2015 at 01:30:00PM +0530, Sudip Mukherjee wrote:
> On Fri, Sep 04, 2015 at 07:40:29PM +0530, Sudip Mukherjee wrote:
> > We were getting build warning about:
> > "Section mismatch in reference from the variable sim710_eisa_driver to
> > the function .i
On Thu, Oct 08, 2015 at 04:29:31PM +0200, Daniel Vetter wrote:
> On Thu, Oct 08, 2015 at 07:28:00PM +0530, Sudip Mukherjee wrote:
> > We were not checking the return value of drm_encoder_init() which can
> > fail. And if it fails then we will be working with an uninitiali
On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> This patch does the following:
> * changed the complicated if statements to simple case statements
> * in case of E_DEFAULT, no need to return error as ERESTART,
> because this is the user asked for. Hence function should return succ
")
Cc: Minchan Kim
Cc: Chen Gang
Signed-off-by: Sudip Mukherjee
---
v2: combined the patches for different arch in this single patch.
arch/alpha/include/uapi/asm/mman.h | 1 -
arch/mips/include/uapi/asm/mman.h | 1 -
arch/parisc/include/uapi/asm/mman.h | 1 -
arch/xtensa/include/uapi/asm/
On Tue, Dec 08, 2015 at 09:01:07PM +0800, Chen Gang wrote:
> On 12/7/15 20:09, Sudip Mukherjee wrote:
> > We are having build failure with mips defconfig with the error:
> > "MADV_FREE" redefined.
> >
> > commit d53d95838c7d introduced uniform values for all
On Tue, Dec 08, 2015 at 12:49:56PM +, Mark Brown wrote:
> On Tue, Dec 08, 2015 at 10:03:00AM +0530, Sudip Mukherjee wrote:
>
> > I think there is some confusion. I am not seeing v1 of these patches in
> > for-next branch of your spi tree. And in review of v1 you said to use
source/drivers/mediatek: Add the COMPILE_TEST
option")
Fixes: 4a373b45f94a ("clocksource/drivers/asm9260: Add the COMPILE_TEST option")
Cc: Daniel Lezcano
Signed-off-by: Sudip Mukherjee
---
v1: had a complicated set of #ifdefs
v2: i messed up and resulted in build failure of som
On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote:
> Sudip Mukherjee writes:
>
> > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote:
> >> Hi Sudip,
> >>
> >> Sudip Mukherjee writes:
> >>
> >
> > I have
On Mon, Dec 07, 2015 at 09:54:50AM -0500, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.2.7 release.
> There are 124 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote:
> Hi Sudip,
>
> Sudip Mukherjee writes:
>
> > We were dereferencing cmd first and checking for NULL later. Lets first
> > check for NULL.
> >
> > Signed-off-by: Sudip Mukherjee
>
> I noticed
On Mon, Dec 07, 2015 at 08:07:37PM +, Mark Brown wrote:
> On Mon, Dec 07, 2015 at 04:17:28PM +0530, Sudip Mukherjee wrote:
> > checkpatch complains about multiple blank lines.
>
> Please don't resubmit already applied patches, please submit against the
> latest d
On Mon, Dec 07, 2015 at 01:32:30PM +0100, Geert Uytterhoeven wrote:
> Hi Sudip,
>
> On Mon, Dec 7, 2015 at 1:20 PM, Sudip Mukherjee
> wrote:
> > We are having build failure with linux-next for sparc allmodconfig with
> > the error messages:
> >
> > undefined
!SPARC. In other words, CONFIG_OF_ADDRESS is not defined for
sparc so we get the build failure.
Signed-off-by: Sudip Mukherjee
---
v1: had a complicated set of #ifdefs
v2: i messed up and resulted in build failure of some other arch where
CONFIG_OF is not defined.
v3: tested with allmodconfig
value for all architectures")
Signed-off-by: Sudip Mukherjee
---
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/95309512
arch/mips/include/uapi/asm/mman.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/include/uapi/asm/mman.h
b/arch/mips/include/uapi/asm/mman.h
in
value for all architectures")
Signed-off-by: Sudip Mukherjee
---
build log at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/95309505
arch/alpha/include/uapi/asm/mman.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/alpha/include/uapi/asm/mman.h
b/arch/alpha/include/uapi/asm/mman.h
in
On Mon, Dec 07, 2015 at 05:07:36PM +0530, Sudip Mukherjee wrote:
> We are having build failure with linux-next for sparc allmodconfig with
> the error messages:
>
> undefined reference to 'of_io_request_and_map'
>
> CONFIG_OF is defined for sparc so it is expected th
!SPARC. In other words, CONFIG_OF_ADDRESS is not defined for
sparc so we get the build failure.
Signed-off-by: Sudip Mukherjee
---
include/linux/of_address.h | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/include/linux/of_address.h b/include/linux/of_addre
checkpatch complains about missing blank line after declaration.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index eb4b421..7037028 100644
--- a/drivers/spi/spi
checkpatch was complaining about space after cast. But the cast to void
is not required at that place.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index
checkpatch complains about the allignment with open parenthesis.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 133e76c..5f526ce 100644
--- a
checkpatch complains about space before closing brace.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 5f526ce..62d0f6d 100644
--- a/drivers/spi/spi
Using pr_* macros are more prefferable than using printk. Start using
pr_* family of macros and define pr_fmt to be used with it.
While at it remove DRVNAME from an existing pr_info() as the name is now
being printed by pr_fmt.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 8
As we have a struct device available it is better to use dev_warn()
instead of printk.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 9d45a63
Modify spi-lm70llp driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 62d0f6d..9d45a63 100644
checkpatch complains about multiple blank lines.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index ba72347..eb4b421 100644
--- a/drivers/spi/spi-lm70llp.c
+++ b/drivers
On Sat, Dec 05, 2015 at 12:09:41PM +0100, Geert Uytterhoeven wrote:
> Hi Sudip
>
> On Thu, Dec 3, 2015 at 9:38 AM, Sudip Mukherjee
> wrote:
> > We are having build failure with next-20151202 for sparc allmodconfig
> > with the error messages:
> > undefined refer
On Sat, Dec 05, 2015 at 06:44:10AM -0500, Sanidhya Solanki wrote:
> The patch is included below.
> I would like to apologize for the past few emails. It turns out the
> documentation included in the eMail clients file is woefully out of
> date. I have checked the patches for errors using the script
On Sat, Dec 05, 2015 at 10:25:16PM -0500, Sanidhya Solanki wrote:
> I disagree with the output of the automaton. Included below are my
> compile checks before and after the patch.
Build fails with:
skein_block.c: multiple definition of 'skein_256_process_block'
And you moved skein_256_process_bl
checkpatch complains about missing blank line after declaration.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index eb4b421..7037028 100644
--- a/drivers/spi/spi
checkpatch complains about space before closing brace.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 5f526ce..62d0f6d 100644
--- a/drivers/spi/spi
Using pr_* macros are more prefferable than using printk. Start using
pr_* family of macros and define pr_fmt to be used with it.
While at it remove DRVNAME from an existing pr_info() as the name is now
being printed by pr_fmt.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 13
Modify spi-lm70llp driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 39cf5dc..9537248 100644
checkpatch complains about the allignment with open parenthesis.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index 133e76c..5f526ce 100644
--- a
checkpatch was complaining about space after cast. But the cast to void
is not required at that place.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index
checkpatch complains about multiple blank lines.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-lm70llp.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/spi/spi-lm70llp.c b/drivers/spi/spi-lm70llp.c
index ba72347..eb4b421 100644
--- a/drivers/spi/spi-lm70llp.c
+++ b/drivers
On Wed, Dec 02, 2015 at 11:39:17PM -0800, Stephen Boyd wrote:
> On 12/01, Sudip Mukherjee wrote:
> > We were not checking the return from devm_add_action() which can fail.
> >
> > Signed-off-by: Sudip Mukherjee
> > ---
> > drivers/clk/qcom/common.c | 13
is !SPARC.
Signed-off-by: Sudip Mukherjee
---
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/builds/94541627
patch has been build tested with sparc allmodconfig and x86_64
allmodconfig.
include/linux/of_address.h | 15 +--
1 file changed, 13 insertions(+), 2 deletion
checkpatch complains about the allignment with open parenthesis.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-butterfly.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/spi/spi-butterfly.c b/drivers/spi/spi-butterfly.c
index 8fc284d..f16ef7f
Modify spi-butterfly driver to use the new parallel port device model.
Signed-off-by: Sudip Mukherjee
---
Only change is in the module loading part. It has been tested by
inserting and removing the module repeatedly, tested with unbind also.
drivers/spi/spi-butterfly.c | 10 ++
1 file
checkpatch was complaining about space after cast. But the cast to void
is not required at that place.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-butterfly.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-butterfly.c b/drivers/spi/spi-butterfly.c
checkpatch complains about multiple blank lines.
Signed-off-by: Sudip Mukherjee
---
drivers/spi/spi-butterfly.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/spi/spi-butterfly.c b/drivers/spi/spi-butterfly.c
index 9a95862..f520eaa 100644
--- a/drivers/spi/spi-butterfly.c
On Wed, Dec 02, 2015 at 08:39:10AM +0530, punit vara wrote:
> On Mon, Nov 9, 2015 at 3:53 PM, Sudip Mukherjee
> wrote:
> > On Mon, Nov 09, 2015 at 03:43:38PM +0530, punit vara wrote:
> >> On Mon, Nov 9, 2015 at 3:31 PM, glen lee wrote:
> >> >
> >> &
On Tue, Dec 01, 2015 at 06:57:24PM +0300, Dan Carpenter wrote:
> On Tue, Dec 01, 2015 at 09:54:50AM -0500, Ben Romer wrote:
> > On 12/01/2015 03:00 AM, Dan Carpenter wrote:
> > >Doing One Err style error handling is often a mistake but it's ok here.
> >
> > Why is it okay here? I don't understand
On Tue, Dec 01, 2015 at 11:16:16AM -0500, Ben Romer wrote:
> On 12/01/2015 10:57 AM, Dan Carpenter wrote:
> >What I meant was that I'm generally opposed to "common exit paths".
> >Mixing all the exit paths together often makes the code more complicated
> >and leads to errors. That makes sense from
On Tue, Dec 01, 2015 at 07:05:19PM +0300, Dan Carpenter wrote:
> A lot of review is judgement calls. I try very hard to be predictable
> and machine like as possible.
>
> I have sometimes called you out for being too strict.
I usually try to guess what Greg will do if he notices those multiple
c
The success path and the error path both are first doing
spin_unlock_irqrestore() before returning. Use that in the common path
and return the success/error value.
Signed-off-by: Sudip Mukherjee
---
v2: changed label name
It is dependent on the patch series sent by Benjamin (Nov 30th
We have been returning success even if snd_soc_card_jack_new() fails.
Lets check the return value and return error if it fails.
Fixes: 12cc6d1dca4d ("ASoC: tegra_alc5632: Register jacks at the card level")
Signed-off-by: Sudip Mukherjee
---
sound/soc/tegra/tegra_alc5632.c | 12 +
On Tue, Dec 01, 2015 at 11:06:58AM +0300, Dan Carpenter wrote:
> Also, the main point of course is that you should choose meaningful
> names for labels every time just like you would for functions.
Yes, and while sending I was really thinking that you are going to
complain about the label name. :)
We were not checking the return from devm_add_action() which can fail.
Signed-off-by: Sudip Mukherjee
---
drivers/clk/qcom/common.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
index c112eba..3541a9a
As hdac->num_nodes is unsigned we can not check if
snd_hdac_get_sub_nodes() has returned error or success. Lets have a
temporary int to check the error value.
Signed-off-by: Sudip Mukherjee
---
v2: made num_nodes as int, but Takashi said that num_nodes should really
be an unsigned.
v1: remo
The success path and the error path both are first doing
spin_unlock_irqrestore() before returning. Use that in the common path
and return the success/error value.
Signed-off-by: Sudip Mukherjee
---
It is dependent on the patch series sent by Benjamin (Nov 30th).
drivers/staging/unisys
On error we were returning retval, but retval is not having the error
value. We will get the error value using PTR_ERR.
Signed-off-by: Sudip Mukherjee
---
This series doesnot depend on my earlier pending series.
drivers/staging/most/aim-cdev/cdev.c | 4 ++--
1 file changed, 2 insertions(+), 2
use.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/aim-cdev/cdev.c | 10 +-
drivers/staging/most/aim-network/networking.c | 2 +-
drivers/staging/most/aim-sound/sound.c| 4 ++--
drivers/staging/most/hdm-dim2/dim2_hdm.c | 2 +-
drivers/staging/most
On Fri, Nov 27, 2015 at 05:44:53AM +, 김정배 wrote:
> From 8f6aeb362d9e44f29d46ae7694cdfee4408406ce Mon Sep 17 00:00:00 2001
> From: "KIM JUGNBAE"
> Date: Thu, 26 Nov 2015 16:28:47 +0900
> Subject: [PATCH] bug_fix : access freed memory
This part should not be present in the patch.
>
> sync_fen
All uses of num_nodes are considering it as a signed integer and that is
very much clear when we try to save the error value in it and later try
to compare it with less than 0.
Signed-off-by: Sudip Mukherjee
---
include/sound/hdaudio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On Wed, Nov 25, 2015 at 07:10:30PM +0600, Alexander Kuleshov wrote:
> The dgap driver contains three functions: dgap_cmdb(), dgap_cmdw()
> and dgap_cmdw_exit which are contain duplicated code which waits
> if necessary before updating the pointer to limit outstanding
> commands. This patch introduc
We were getting build failure with allmodconfig of tile, tilegx, m32r and m68k
with the error:
implicit declaration of function 'gpio_to_desc'
implicit declaration of function 'gpiod_direction_output'
Fixes: cc30c16344fc ("net: dsa: Add support for a switch reset gp
hdac->num_nodes is unsigned int and can never be less than 0.
Signed-off-by: Sudip Mukherjee
---
Or, maybe, another way can be to declare num_nodes as int. Then this
test makes sense and also snd_hdac_get_sub_nodes() is returning an int.
sound/soc/codecs/hdac_hdmi.c | 2 +-
1 file changed
If copy_to_user() fails we returned error but we missed releasing
devices.
Signed-off-by: Sudip Mukherjee
---
v1 on fixed one error. v2 fixes both.
drivers/lightnvm/core.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm
If create_dma_pools() fails then we just returned the error code but we
missed freeing the device.
Signed-off-by: Sudip Mukherjee
---
drivers/lightnvm/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index d288996..9dd1623 100644
--- a
at the beginning and continue
initialization only if it is supported.
Signed-off-by: Sudip Mukherjee
---
drivers/lightnvm/core.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index e338048..2ab561f 100644
--- a
We were returning a success value even if a manager was not found.
Signed-off-by: Sudip Mukherjee
---
Not sure if it was intentionally done like that way. This patch is
placed at the end so it will be easy to drop if i am wrong.
Did this change seeing similar code in nvm_create_target
If create_dma_pool() fails then we are returning the error code but we
have already added the device to the list. Lets add the device to the
list only if everything is successfully initialized.
Signed-off-by: Sudip Mukherjee
---
drivers/lightnvm/core.c | 8
1 file changed, 4 insertions
If kzalloc fails it will return NULL. Lets check for NULL first before
using the pointer.
Signed-off-by: Sudip Mukherjee
---
v2: commit message changed
drivers/net/wireless/marvell/libertas/cfg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless
On Mon, Nov 23, 2015 at 03:25:43PM -0800, Eduardo Valentin wrote:
> On Mon, Nov 23, 2015 at 06:24:41PM +0530, Sudip Mukherjee wrote:
> > We were only checking if data is not NULL but
> > ti_bandgap_get_sensor_data() can return NULL or ERR_PTR.
>
> Do you have a fail case? Ca
On Tue, Nov 24, 2015 at 01:43:38AM +0200, Andy Shevchenko wrote:
> On Mon, Nov 23, 2015 at 2:32 PM, Sudip Mukherjee
> wrote:
> > We were dereferencing cmd first and checking for NULL later. Lets first
> > check for NULL.
>
> However the patch is valid due to reduci
On Mon, Nov 23, 2015 at 04:13:39PM +0100, Matias Bjørling wrote:
> On 11/23/2015 11:35 AM, Sudip Mukherjee wrote:
> >If copy_to_user() fails we returned error but we missed releasing
> >devices.
> >
> >Signed-off-by: Sudip Mukherjee
> >---
> > driver
We were only checking if data is not NULL but
ti_bandgap_get_sensor_data() can return NULL or ERR_PTR.
Signed-off-by: Sudip Mukherjee
---
drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/ti-soc-thermal/ti
We were dereferencing cmd first and checking for NULL later. Lets first
check for NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/net/wireless/marvell/libertas/cfg.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/libertas/cfg.c
b/drivers/net
kzalloc() can return NULL if it fails, and then we will be dereferencing
a NULL pointer.
Signed-off-by: Sudip Mukherjee
---
sound/soc/codecs/hdac_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
index d155262..205f2c2
If request_firmware() succeeds then rc becomes 0. After that if the test
for strcmp() fails then we were jumping to label done: and returning rc.
But rc being 0 we returned success whereas we have failed here and we
were supposed to return an error.
Signed-off-by: Sudip Mukherjee
---
I am not
>From the error path we are printing an error message with dev_err(). No
need to print almost same message with dev_dbg().
Signed-off-by: Sudip Mukherjee
---
drivers/misc/mic/host/mic_x100.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/misc/mic/h
Instead of jumping to a label and then returning from there lets return
directly.
Signed-off-by: Sudip Mukherjee
---
drivers/misc/mic/host/mic_x100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mic/host/mic_x100.c b/drivers/misc/mic/host/mic_x100.c
index
Instead of calling release_firmware() on every error and then jumping
lets have a common release_firmware() in the error path.
This patch also fixes a memory leak where we missed release_firmware()
if mic_x100_load_command_line() fails.
Signed-off-by: Sudip Mukherjee
---
drivers/misc/mic/host
We have requested the firmware but missed releasing it.
Signed-off-by: Sudip Mukherjee
---
sound/soc/intel/skylake/skl-topology.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/skylake/skl-topology.c
b/sound/soc/intel/skylake/skl-topology.c
index 0937ea2..87b9c3e 100644
If copy_to_user() fails we returned error but we missed releasing
devices.
Signed-off-by: Sudip Mukherjee
---
drivers/lightnvm/core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index f659e60..6688b60 100644
--- a
If get_pll_div() fails we exited by returning NULL but we missed
releasing hwc.
Signed-off-by: Sudip Mukherjee
---
drivers/clk/clk-qoriq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 1ab0fb8..7bc1c45 100644
--- a
On Sat, Nov 21, 2015 at 09:26:32AM +0530, Anjali Menon wrote:
> Moved the comments to the next line to remove the warning
> detected by the checkpatch.pl.
>
> WARNING: line over 80 characters
>
> Signed-off-by: Anjali Menon
> ---
> drivers/staging/panel/panel.c | 4 +++-
> 1 file changed, 3 ins
device_create() returns ERR_PTR on error, it does not return NULL.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/mostcore/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/mostcore/core.c
b/drivers/staging/most/mostcore/core.c
index
If create_most_inst_obj() fails we returned an error pointer but we
missed releasing id.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/mostcore/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/mostcore/core.c
b/drivers/staging/most/mostcore/core.c
index
We were returning ENOMEM on all types of errors. Lets return the actual
error code. At the same time remove the label which became unused as a
result of this patch.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/most/mostcore/core.c | 22 +++---
1 file changed, 15 insertions
to the caller implying a success.
Lets return -ENODEV when dfs_rootdir is NULL else return
PTR_ERR(dfs_rootdir).
Signed-off-by: Sudip Mukherjee
---
drivers/mtd/ubi/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c
index
The pr_debug() will never be executed.
Signed-off-by: Sudip Mukherjee
---
drivers/misc/ti-st/st_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index 6e3af8b..dcdbd58 100644
--- a/drivers/misc/ti-st/st_core.c
+++ b/drivers
On Wed, Nov 18, 2015 at 02:24:46PM -0800, Stephen Boyd wrote:
> On 11/16, Sudip Mukherjee wrote:
> > If of_clk_parent_fill() fails then we printed an error message and
> > returned. But we missed freeing sp810.
> >
> > Signed-off-by: Sudip Mukherjee
> > ---
If kzalloc fails we will already have many messages in the log and we do
not need another message to know that kzalloc for sp810 has failed.
Signed-off-by: Sudip Mukherjee
---
drivers/clk/versatile/clk-sp810.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clk
On Tue, Nov 17, 2015 at 10:00:52AM -0800, Dmitry Torokhov wrote:
> On Tue, Nov 17, 2015 at 07:10:15PM +0530, Sudip Mukherjee wrote:
> > db9_parport_cb is a local uninitialized structure and the member
> > function pointers will be pointing to arbitrary locations unless they
On Tue, Nov 17, 2015 at 09:01:28PM +0100, Bogicevic Sasa wrote:
> This fixes all "Comparison to NULL could be written like..."
> messages from checkpatch.pl
>
> Signed-off-by: Bogicevic Sasa
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 10 +-
> 1 file changed, 5 insertions(+), 5
On Tue, Nov 17, 2015 at 05:44:55PM +0100, Christian Colic wrote:
> Fix checkpatch checks: spaces around + at "reg_base+addr2" and
> rewrite comparisons with NULL to "!data->reg_base"
That becomes multiple changes in a single patch. It should be in
separate patches.
regards
sudip
--
To unsubscribe
On Mon, Nov 16, 2015 at 10:48:28PM +0530, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
>
> Signed-off-by: Ranjith Thangavel
> ---
In this one I am not seeing any change to BIT.
801 - 900 of 2348 matches
Mail list logo
