Hello, Waiman.
My apologies for the delay.
On Mon, Aug 27, 2018 at 01:50:18PM -0400, Waiman Long wrote:
> My current code has explicitly assumed the following relationship for
> partition root.
>
> cpus_allowed = effective_cpus + reserved_cpus
>
> Also effective_cpus cannot be empty. Specif
On Fri, Sep 28, 2018 at 03:41:23PM -0700, Florian Fainelli wrote:
> On 09/25/2018 09:12 AM, Florian Fainelli wrote:
> > On 09/24/2018 11:19 PM, Kishon Vijay Abraham I wrote:
> >> On Friday 21 September 2018 12:49 AM, Florian Fainelli wrote:
> >>> On 09/20/2018 12:16 PM, Florian Fainelli wrote:
> >>
Hello,
On Thu, Sep 20, 2018 at 06:18:21PM +0800, Jianchao Wang wrote:
> -static inline void percpu_ref_get_many(struct percpu_ref *ref, unsigned long
> nr)
> +static inline void __percpu_ref_get_many(struct percpu_ref *ref, unsigned
> long nr)
> {
> unsigned long __percpu *percpu_count;
>
Hello,
On Tue, Sep 11, 2018 at 10:02:22AM -0700, Paul E. McKenney wrote:
> > Doesn't work for me because it is still within the preempt-disable
> > section :/.
> > Would it work to use WORK_CPU_UNBOUND? As far as I understand it, the
> > CPU number does not matter, you just want to spread it acros
> because it is at atomic mode.
>
> This patch introduces percpu_ref_resurge() in which the above limit is
> relaxed, so we may avoid extra change[1] for NVMe timeout's requirement.
For now,
Nacked-by: Tejun Heo
Please see the original discussion thread.
Thanks.
--
tejun
12:16:36
-0700)
--------
Tejun Heo (1):
MAINTAINERS: Make Dennis the percpu tree maintainer
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4130acc2e152..bb65f0c1861c 100644
--- a/MA
On Wed, Sep 12, 2018 at 09:58:29PM +0800, lius...@tom.com wrote:
> From: Liu Song
>
> Although the 'need_to_create_worker' has been determined to be
> true before entering the function. However, adjusting the order
> of judgment can combine two judgments in the loop. Also improve
> the matching b
Hello, Patrick.
On Tue, Sep 11, 2018 at 05:26:24PM +0100, Patrick Bellasi wrote:
> My question is: IF the scheduler maintainers are going to be happy
> with the overall design for the core bits, are you happy to start the
> review of the cgroups bits before the core ones are (eventually) merged?
Hello, Patrick.
Can we first concentrate on getting in the non-cgroup part first? The
feature has to make sense without cgroup too and I think it'd be a lot
easier to discuss cgroup details once the scheduler core side is
settled.
Thanks.
--
tejun
vate version of the
> function with notes not to use it describing the flaw. Hopefully soon,
> that code can be cleaned up.
>
> Signed-off-by: Dennis Zhou
Acked-by: Tejun Heo
--
tejun
a fault.
> >
> > Signed-off-by: Bernd Edlinger
Acked-by: Tejun Heo
Thanks.
--
tejun
ata: ahci: Support state with min power but Partial low power state
ata: ahci: Enable DEVSLP by default on x86 with SLP_S0
ata: libahci: Correct setting of DEVSLP register
ata: libahci: Allow reconfigure of DEVSLP register
Tejun Heo (1):
Revert "ata: ahci_platform: al
Hello,
Just one commit from Steven to take out spin lock from trace event
handlers.
Thanks.
The following changes since commit 1e09177acae32a61586af26d83ca5ef591cdcaf5:
Merge tag 'mips_fixes_4.18_3' of
git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux (2018-07-10 16:18:09
-0700)
are
Hello,
Workqueue changes for v4.19-rc1. Over the lockdep cross-release
churn, workqueue lost some of the existing annotations. Johannes Berg
restored it and also improved them.
Thanks.
The following changes since commit 66448bc274cadedb71fda7d914e7c29d8dead217:
workqueue: move function defi
On Wed, Aug 22, 2018 at 09:13:00PM +0900, Kunihiko Hayashi wrote:
> Add support to get and control a list of resets for the device, and
> add the flag indicating whether to use the reset. Existing SoC-dependent
> drivers set 0 to this flag.
Applied to libata/for-4.19.
Thanks.
--
tejun
Hello,
On Mon, Aug 13, 2018 at 09:58:10AM +0300, Konstantin Khlebnikov wrote:
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 19a4348974a4..7ef6ea9d5e4a 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -333,6 +333,7 @@ struct cgroup_subsys_state
> *mem_cgroup_css_from_page(str
emoved in 2009 with b01e8dc34379..6088464cf1ae.
>
> Signed-off-by: Alexander Pateenok
I'm not sure this is a meaningful cleanup, but then again, why not?
Can you please repost the patch to Andrew so that it can go through
-mm tree? Please feel free to add
Acked-by: Tejun Heo
Thanks.
--
tejun
On Mon, Aug 20, 2018 at 12:05:50PM +0800, wang.y...@zte.com.cn wrote:
> Gentle ping :)
>
> > The 'tbl' variable may leak when return in function
> > wq_numa_init(), and this patch fixes this.
> >
> > Signed-off-by: Yi Wang
> > Reviewed-by: Jiang Biao
It's a kernel bug path where we might as wel
Hello,
On Tue, Aug 14, 2018 at 10:06:18AM -0700, Paul E. McKenney wrote:
> > Is there a way we could make a union, or reuse one of the other fields,
> > as we know that synchronize_srcu() can't be used yet (and if it is,
> > either warn, or just make it a nop). And when we call srcu_init() and
> >
On Mon, Aug 13, 2018 at 09:52:09AM +0300, Konstantin Khlebnikov wrote:
> Now it returns the length of the full path or error code.
>
> Signed-off-by: Konstantin Khlebnikov
> Fixes: 3abb1d90f5d9 ("kernfs: make kernfs_path*() behave in the style of
> strlcpy()")
Ack
Hello, Konstantin.
On Mon, Aug 13, 2018 at 09:58:05AM +0300, Konstantin Khlebnikov wrote:
> After removing cgroup subsystem state could leak or live in background
> forever because it is pinned by some reference. For example memory cgroup
> could be pinned by pages in cache or tmpfs.
>
> This pat
hink excluding metadata is fair because
> the backing memory scales with the numbere of cpus and can quickly
> outweigh the metadata. It also makes this calculation light.
>
> Signed-off-by: Dennis Zhou
Acked-by: Tejun Heo
Andrew, if this looks good, can you please route this?
Thanks.
--
tejun
Hello,
On Tue, Aug 07, 2018 at 02:12:06PM +, Christopher Lameter wrote:
> > @@ -121,6 +122,7 @@ static int meminfo_proc_show(struct seq_file *m, void
> > *v)
> >(unsigned long)VMALLOC_TOTAL >> 10);
> > show_val_kb(m, "VmallocUsed:", 0ul);
> > show_val_kb(m, "Vmallo
Hello,
On Mon, Aug 06, 2018 at 09:30:15AM +1000, Stephen Rothwell wrote:
> > > So this issue is still happening as of next-20180702. Can you guys
> > > please revert the commit above while working on a better solution?
> >
> > That's fine with me. I'm not very familiar with the process here, do
On Wed, Aug 01, 2018 at 05:32:01PM -0700, Roman Gushchin wrote:
> For some workloads an intervention from the OOM killer
> can be painful. Killing a random task can bring
> the workload into an inconsistent state.
For patches 1-3,
Acked-by: Tejun Heo
Thanks.
--
tejun
On Wed, Aug 01, 2018 at 08:49:58AM -0700, Tejun Heo wrote:
> Hello,
>
> On Tue, Jul 31, 2018 at 05:25:59PM -0700, Dennis Zhou wrote:
> ...
> > + /*
> > +* CALC_LOAD takes in a number stored in fixed point representation.
> > +* Because we are using this
on the stack.
Acked-by: Tejun Heo
Thanks.
--
tejun
Hello, Michal.
On Mon, Jul 30, 2018 at 08:51:10PM +0200, Michal Hocko wrote:
> > Yeah, workqueue can choke on things like that and kthread indefinitely
> > busy looping doesn't do anybody any good.
>
> Yeah, I do agree. But this is much easier said than done ;) Sure
> we have that hack that does
On Mon, Jul 30, 2018 at 07:59:36PM +0200, Pavel Machek wrote:
> Its true I have no interest in psi. But I'm trying to use same kernel
> you are trying to "improve" and I was confused enough by seing
> "CONFIG_PSI". And yes, my association was "pounds per square inch" and
> "what is it doing here".
Hello,
On Mon, Jul 30, 2018 at 10:54:05AM -0700, Randy Dunlap wrote:
> I'd say he's trying to make something that is readable and easier to
> understand for users.
Sure, it's perfectly fine to make those suggestions and discuss but
the counter points have already been discussed (e.g. PSI is a kno
Hello,
On Mon, Jul 30, 2018 at 07:39:40PM +0200, Pavel Machek wrote:
> > I'd rather have the internal config symbol match the naming scheme in
> > the code, where psi is a shorter, unique token as copmared to e.g.
> > pressure, press, prsr, etc.
>
> I'd do "pressure", really. Yes, psi is shorter,
On Mon, Jul 30, 2018 at 05:26:45PM +0200, Hans de Goede wrote:
> Hi,
>
> On 30-07-18 17:22, Tejun Heo wrote:
> >On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote:
> >>Hi Tejan,
> >>
> >>On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pan
Hello,
On Tue, Jul 31, 2018 at 12:25:04AM +0900, Tetsuo Handa wrote:
> WQ_MEM_RECLAIM guarantees that "struct task_struct" is preallocated. But
> WQ_MEM_RECLAIM does not guarantee that the pending work is started as soon
> as an item was queued. Same rule applies to both WQ_MEM_RECLAIM workqueues
On Mon, Jul 30, 2018 at 08:15:47AM -0700, Srinivas Pandruvada wrote:
> Hi Tejan,
>
> On Mon, 2018-07-02 at 12:01 -0700, Srinivas Pandruvada wrote:
> > Some minor fixes to be able to correctly set devslp register
> > to optimize power.
> >
> > Srinivas Pandruvada (2):
> > ata: libahci: Correct s
Hello,
On Mon, Jul 30, 2018 at 04:46:47PM +0200, Michal Hocko wrote:
> On Mon 30-07-18 23:34:23, Tetsuo Handa wrote:
> > On 2018/07/30 18:32, Michal Hocko wrote:
> [...]
> > > This one is waiting for draining and we are in mm_percpu_wq WQ context
> > > which has its rescuer so no other activity ca
On Fri, Jul 27, 2018 at 01:47:01PM -0700, Srinivas Pandruvada wrote:
> One of the requirement for modern x86 system to enter lowest power mode
> (SLP_S0) is SATA IP block to be off. This is true even during when
> platform is suspended to idle and not only in opportunistic (runtime)
> suspend.
> Th
On Wed, Jul 25, 2018 at 02:50:01PM +0300, Georgi Nikolov wrote:
> I posted a kernel bug https://bugzilla.kernel.org/show_bug.cgi?id=200651 and
> i hope this is the correct place to discuss this.
That's just NORETRY vmalloc allocation failing under memory pressure.
Doesn't have much to do with cgro
Hello, Andrew.
On Tue, Jul 24, 2018 at 12:29:13PM -0700, Andrew Morton wrote:
> How did you make this happen, btw? Fault injection, or did a small
> GFP_KERNEL allocation fail?
We have a group of machines which are pushing memory really hard and
this actually triggered in prod on several of them
f
Fix it by updating delayacct_blkio_end() check @p->delays instead.
Signed-off-by: Tejun Heo
Reported-and-debugged-by: Dave Jones
Cc: Josh Snyder
Fixes: c96f5471ce7d ("delayacct: Account blkio completion on the correct task")
Cc: sta...@vger.kernel.org # v4.15+
---
include/linux/delayacct.h |
On Tue, Jul 17, 2018 at 10:49:35AM +, Corentin Labbe wrote:
> Since ahci_platform_put_resources() use target_pwrs after "devm_" freed
> it, we cannot use devm_kcalloc for allocating target_pwrs.
>
> This reverts commit bd0038b1b4f499d814d8f33a55b1df5ea6cf3b85.
>
> Reported-by: Mikko Perttunen
Hello, Patrick.
On Mon, Jul 23, 2018 at 06:22:15PM +0100, Patrick Bellasi wrote:
> However, the "best effort" bandwidth control we have for CFS and RT
> can be further improved if, instead of just looking at time spent on
> CPUs, we provide some more hints to the scheduler to know at which
> min/m
Hello,
On Mon, Jul 16, 2018 at 09:29:02AM +0100, Patrick Bellasi wrote:
> The cgroup's CPU controller allows to assign a specified (maximum)
> bandwidth to the tasks of a group. However this bandwidth is defined and
> enforced only on a temporal base, without considering the actual
> frequency a C
On Wed, Jul 18, 2018 at 07:33:58PM +0200, Claudio wrote:
> This commit adds tests for some of the core functionalities
> of cgroups v2.
>
> The commit adds tests for some core principles of croup V2 API:
Acked-by: Tejun Heo
Thanks, Claudio.
--
tejun
es for only the tasks inside the cgroup.
>
> Signed-off-by: Johannes Weiner
Acked-by: Tejun Heo
Please feel free to route with the rest of the patchset.
Thanks.
--
tejun
On Thu, Jul 12, 2018 at 06:31:03PM +0200, Paul Menzel wrote:
> Date: Sun, 8 Jul 2018 09:18:21 +0200
>
> Defining `ATA_DEBUG` there are a lof of messages like below in the log.
>
> [ 16.345472] ata_sg_setup: 1 sg elements mapped
>
> As that is too verbose, only output these messages in verb
On Thu, Jul 12, 2018 at 06:29:44PM +0200, Paul Menzel wrote:
> Date: Sun, 8 Jul 2018 09:11:34 +0200
>
> Defining `ATA_DEBUG` nothing can be really seen, as the log is spammed
> with CDB messages.
>
> Therefore, guard the print by `ATA_VERBOSE_DEBUG`.
>
> Signed-off-by: Paul Menzel
Applied to l
On Thu, Jul 12, 2018 at 11:41:28AM +, Corentin Labbe wrote:
> Hello
>
> This patchset fixes some minor problem found when working on supporting
> allwinner R40 AHCI.
>
> Regards
>
> Corentin Labbe (3):
> ata: ahci_platform: correct parameter documentation for
> ahci_platform_shutdown
>
Hello, Linus.
* Jens's patches to expand the usable command depth from 31 to 32
broke sata_fsl due to a subtle command iteration bug. Fixed by
introducing explicit iteration helpers and using the correct
variant.
* On some laptops, enabling LPM by default reportedly led to
occasional har
On Mon, Jul 09, 2018 at 05:48:54PM -0400, Steven Rostedt wrote:
> From: Steven Rostedt (VMware)
>
> It is unwise to take spin locks from the handlers of trace events.
> Mainly, because they can introduce lockups, because it introduces locks
> in places that are normally not tested. Worse yet, bec
Hello, Sebastian.
On Wed, Jul 11, 2018 at 01:05:13PM +0200, Sebastian Andrzej Siewior wrote:
> > > We at least used to do this in the kernel - manipulating irqsafe locks
> > > with spin_lock/unlock() if the irq state is known, whether enabled or
> > > disabled, and ISTR lockdep being smart enough
(cc'ing Peter and Ingo for lockdep)
Hello, Sebastian.
On Tue, Jul 03, 2018 at 06:45:44PM +0200, Sebastian Andrzej Siewior wrote:
> All callers of cgroup_rstat_flush_locked() acquire cgroup_rstat_lock
> either with spin_lock_irq() or spin_lock_irqsave().
So, irq is always disabled in cgroup_rstat
Hello, Paul.
On Tue, Jul 03, 2018 at 09:40:44AM -0700, Paul E. McKenney wrote:
> > I will apply this, but be advised that I have not seen that WARN_ON_ONCE()
> > trigger since. :-/
>
> But I get a build error:
>
> kernel/workqueue.o: In function `worker_attach_to_pool':
> workqueue.c:(.text+0x6
Hello,
On Tue, Jul 03, 2018 at 03:22:47PM +1000, Benjamin Herrenschmidt wrote:
> +bool kernfs_has_children(struct kernfs_node *kn)
> +{
> + bool has_children = false;
> + struct kernfs_node *pos;
> +
> + /* Lockless shortcut */
> + if (RB_EMPTY_NODE(&kn->rb))
> + return
Hello, Sergey.
On Tue, Jul 03, 2018 at 01:30:21PM +0900, Sergey Senozhatsky wrote:
> Cc-ing Linus, Tejun, Andrew
> [I'll keep the entire lockdep report]
>
> On (07/02/18 19:26), Tetsuo Handa wrote:
> [..]
> > 2018-07-02 12:13:13 192.168.159.129: [ 151.606834] swapper/0/0 is
> > trying to ac
der this much pressure we want to
> do as little IO as possible so we can still make progress on real work
> if we're a throttled cgroup, so just skip readahead if our group is
> under pressure.
>
> Signed-off-by: Josef Bacik
Acked-by: Tejun Heo
Thanks.
--
tejun
Hello, Paul.
Sorry about the late reply.
On Wed, Jun 20, 2018 at 12:29:01PM -0700, Paul E. McKenney wrote:
> I have hit this WARN_ON_ONCE() in process_one_work:
>
> WARN_ON_ONCE(!(pool->flags & POOL_DISASSOCIATED) &&
>raw_smp_processor_id() != pool->cpu);
>
> This look
On Mon, Jul 02, 2018 at 12:08:45PM -0700, Srinivas Pandruvada wrote:
> From: Srinivas
>
> One of the requirement for modern x86 system to enter lowest power mode
> (SLP_S0) is SATA IP block to be off. This is true even during when
> platform is suspended to idle and not only in opportunistic (run
On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote:
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or
On Fri, Jun 22, 2018 at 01:03:07PM +0200, Geert Uytterhoeven wrote:
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or
BDI_DIRTIED => WB_DIRTIED
> BDI_WRITTEN => WB_WRITTEN
>
> Signed-off-by: Greg Thelen
Acked-by: Tejun Heo
Thanks.
--
tejun
Hello, Peter.
On Tue, Jun 26, 2018 at 05:49:08PM +0200, Peter Zijlstra wrote:
> Well, no, because the Changelog is incomprehensible and the patch
> doesn't really have useful comments, so I'll have to reverse engineer
> the entire thing, and I've just not had time for that.
Just as an additional
On Sun, Jul 01, 2018 at 12:15:46PM +0200, Hans de Goede wrote:
> There have been several reports of LPM related hard freezes about once
> a day on multiple Lenovo 50 series models. Strange enough these reports
> where not disk model specific as LPM issues usually are and some users
> with the exact
ng and optimize the code a little.
>
> Signed-off-by: Guenter Roeck
Acked-by: Tejun Heo
Thanks.
--
tejun
On Mon, Jul 02, 2018 at 08:30:22AM +0100, Colin King wrote:
> From: Colin Ian King
>
> Pointers sdev0 and sdev1 are being assigned but are never used hence they
> are redundant and can be removed.
>
> Cleans up clang warnings:
> warning: variable 'sdev0' set but not used [-Wunused-but-set-variab
On Fri, Jun 08, 2018 at 06:26:33PM +0800, John Garry wrote:
> Currently smatch warns of possible Spectre-V1 issue in ahci_led_store():
> drivers/ata/libahci.c:1150 ahci_led_store() warn: potential spectre issue
> 'pp->em_priv' (local cap)
>
> Userspace controls @pmp from following callchain:
> em
Hello, Ivan.
On Fri, Jun 15, 2018 at 08:40:02PM +0300, Ivan Zahariev wrote:
> The lazy pids accounting + modern fast CPUs makes the "pids.current"
> metric practically unusable for resource limiting in our case. For a
> test, when we started and ended one single process very quickly, we
> saw "pid
Hello,
On Fri, Jun 15, 2018 at 07:07:27PM +0300, Ivan Zahariev wrote:
> I understand all concerns and design decisions. However, having
> RLIMIT_NPROC support combined with "cgroups" hierarchy would be very
> handy.
>
> Does it make sense that you introduce "nproc.current" and
> "nproc.max" metri
Hello,
On Fri, Jun 15, 2018 at 05:26:04PM +0300, Ivan Zahariev wrote:
> The standard RLIMIT_NPROC does not suffer from such accounting
> discrepancies at any time.
RLIMIT_NPROC uses a dedicated atomic counter which is updated when the
process is getting reaped; however, that doesn't actually coin
Hello,
On Mon, Jun 11, 2018 at 11:12:48AM +0200, Jan Kara wrote:
> However this is wrong and so is the patch. The problem is in
> cgwb_bdi_unregister() which does cgwb_kill() and thus drops bdi's
> reference to wb structures before going through the list of wbs again and
> calling wb_shutdown() on
On Wed, Jun 06, 2018 at 09:39:40PM +0200, Mathieu Malaterre wrote:
> Since function `percpu_counter_add' may result in a signed integer overflow
> the result stored in `fbc->count' could be negative. Make sure that
> function `percpu_counter_read_positive' does not return a negative number
> in thi
On Wed, Jun 06, 2018 at 08:14:27AM -0700, Linus Torvalds wrote:
> On Wed, Jun 6, 2018 at 8:04 AM Tejun Heo wrote:
> >
> > The notification implementation isn't super light weight, so the patch
> > ratelimits the notifications by capping minimum notification int
Hello, Linus.
On Tue, Jun 05, 2018 at 05:13:55PM -0700, Linus Torvalds wrote:
> On Tue, Jun 5, 2018 at 12:22 PM Tejun Heo wrote:
> >
> > * cgroup uses file modified events to notify certain events. A rate
> > limiting mechanism is added.
>
> This "explanatio
h changes up to 66448bc274cadedb71fda7d914e7c29d8dead217:
workqueue: move function definitions within CONFIG_SMP block (2018-05-23
11:16:58 -0700)
Mathieu Malaterre (1):
workqueue: move function definitions within CONFIG_SMP bloc
11:04:54
-0700)
Andy Shevchenko (1):
rdmacg: Convert to use match_string() helper
Tejun Heo (12):
cgroup: Explicitly remove core interface files
cgroup: Limit event generation frequency
cgroup: Rename kernel/cgroup/stat.c to kernel/cgroup/rstat
Hello, Linus.
This is the second part of libata pull request.
* libata has always been limiting the maximum queue depth to 31, 1 set
aside mostly for historical reasons. This didn't use to make much
difference but Jens found out that modern hard drives can actually
perform measurably bette
Hello, Linus.
These two are fixes which missed v4.17. I tried to merge these into
libata/for-4.18 but couldn't make "git request-pull" not generate huge
spurious diffstat without merging v4.17 in the middle, so I'm sending
them out as two spearate pull request. Pulling into master should be
clea
On Mon, Jun 04, 2018 at 02:01:34PM -0700, Casey Schaufler wrote:
> On 6/1/2018 10:45 AM, Casey Schaufler wrote:
> > Fix memory leak in smack_inode_getsecctx
> >
> > The implementation of smack_inode_getsecctx() made
> > incorrect assumptions about how Smack presents a security
> > context. Smack do
Hello, Michal.
On Mon, Jun 04, 2018 at 03:01:19PM +0200, Michal Hocko wrote:
> > On Fri, Jun 01, 2018 at 01:11:59PM -0500, Eric W. Biederman wrote:
> > > Widening the definition of a process sounds good. The memory control
> > > group code would still need a way to forbid these in cgroup v1 mode,
Hello,
On Fri, Jun 01, 2018 at 01:11:59PM -0500, Eric W. Biederman wrote:
> Widening the definition of a process sounds good. The memory control
> group code would still need a way to forbid these in cgroup v1 mode,
> when someone uses the task file.
Yeap, you're right. We'll need memcg's can_a
Hello, Eric.
On Fri, Jun 01, 2018 at 09:53:09AM -0500, Eric W. Biederman wrote:
>
> From a userspace perspective the cgroup of a mm is determined by which
> the cgroup the task belongs too. As practically an mm can only belong to
> a single memory cgroup having multiple tasks with the same mm in
On Thu, May 31, 2018 at 09:04:25AM -0700, Casey Schaufler wrote:
> On 5/31/2018 8:39 AM, Tejun Heo wrote:
> > (cc'ing more security folks and copying whole body)
> >
> > So, I'm sure the patch fixes the memory leak but API wise it looks
> > super confusing.
On Thu, May 31, 2018 at 01:10:38PM +0100, Richard W.M. Jones wrote:
> On Thu, May 31, 2018 at 01:21:07PM +0200, Hans de Goede wrote:
> > Commit 184add2ca23c ("libata: Apply NOLPM quirk for SanDisk
> > SD7UB3Q*G1001 SSDs") disabled LPM for SanDisk SD7UB3Q*G1001 SSDs.
> >
> > This has lead to severa
On Thu, May 31, 2018 at 01:21:07PM +0200, Hans de Goede wrote:
> Commit 184add2ca23c ("libata: Apply NOLPM quirk for SanDisk
> SD7UB3Q*G1001 SSDs") disabled LPM for SanDisk SD7UB3Q*G1001 SSDs.
>
> This has lead to several reports of users of that SSD where LPM
> was working fine and who know have
(cc'ing more security folks and copying whole body)
So, I'm sure the patch fixes the memory leak but API wise it looks
super confusing. Can security folks chime in here? Is this the right
fix?
Thanks.
On Thu, May 31, 2018 at 02:58:31PM +0530, CHANDAN VN wrote:
> From: "sireesha.t"
>
> Leak i
On Tue, May 29, 2018 at 05:17:19PM -0400, Josef Bacik wrote:
> From: Josef Bacik
>
> We need to use blk_rq_stat in the blkcg qos stuff, so export some of
> these helpers so they can be used by other things.
>
> Signed-off-by: Josef Bacik
Acked-by: Tejun Heo
Thanks.
--
tejun
Hello,
On Tue, May 29, 2018 at 05:17:17PM -0400, Josef Bacik wrote:
> +static void blkcg_scale_delay(struct blkcg_gq *blkg, u64 now)
> +{
> + u64 old = atomic64_read(&blkg->delay_start);
> +
> + if (old + NSEC_PER_SEC <= now &&
Maybe time_before64()?
> + atomic64_cmpxchg(&blkg->d
allocate the corresponding blkg.
>
> So for now do this, and in the future if possible we could just replace
> the bi_css with bi_blkg and update the helpers to do the correct
> translation.
>
> Signed-off-by: Josef Bacik
Acked-by: Tejun Heo
Thanks.
--
tejun
On Sun, May 27, 2018 at 11:21:25AM +0900, Tetsuo Handa wrote:
> From 8a8222698163d1fe180258566e9a3ff43f54fcd9 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa
> Date: Sun, 27 May 2018 11:08:20 +0900
> Subject: [PATCH] bdi: Fix another oops in wb_workfn()
>
> syzbot is still hitting NULL pointer dere
)
François Cami (1):
libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.
Mika Westerberg (1):
ahci: Add PCI ID for Cannon Lake PCH-LP AHCI
Sudip Mukherjee (1):
libata: blacklist Micron 500IT SSD with MU01 firmware
Tejun Heo (1):
libata: Blacklist some Sandisk
Hello, Jan.
On Thu, May 24, 2018 at 12:19:00PM +0200, Jan Kara wrote:
> > We're periodically seeing close to 256 kworkers getting stuck with the
> > following stack trace and overtime the entire system gets stuck.
>
> OK, but that means that you have to have 256 block devices, don't you? As
It'd
work item.
Let's allow them to bunch up a bit.
Signed-off-by: Tejun Heo
Suggested-by: Rik van Riel
---
mm/backing-dev.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 8fe3ebd..f9a2268 100644
--- a/mm/backing-dev.c
+++
Hello, Rik.
On Wed, May 23, 2018 at 06:03:15PM -0400, Rik van Riel wrote:
> Dumb question. Does setting max_active to 1 mean
> that every cgwb_release_workfn() ends up forcing
> another RCU grace period on the whole system, while
> today you might have a bunch of them waiting on the
> same RCU gr
On Wed, May 23, 2018 at 11:39:07AM -0700, Paul E. McKenney wrote:
> > While this resolves the problem at hand, it might be a good idea to
> > isolate rcu_exp_work to its own workqueue too as it can be used from
> > various paths and is prone to this sort of indirect A-A deadlocks.
>
> Commit ad7c9
e and less scarce, letting the existing usage
dissipate over time through the above gradual reclaim and as they're
falted back in is likely the better behavior.
Signed-off-by: Tejun Heo
Acked-by: Roman Gushchin
Acked-by: Rik van Riel
Cc: Johannes Weiner
Cc: Michal Hocko
Cc: Shaohu
On Tue, May 22, 2018 at 09:47:32PM +0200, Mathieu Malaterre wrote:
> In commit 7ee681b25284 ("workqueue: Convert to state machine callbacks"),
> three new function definitions were added: ‘workqueue_prepare_cpu’,
> ‘workqueue_online_cpu’ and ‘workqueue_offline_cpu’.
>
> Move these function definit
Applied the following patch to cgroup/for-4.18.
Thanks.
-- 8< --
>From d8742e22902186e30c346b1ba881cb52942ae3e4 Mon Sep 17 00:00:00 2001
From: Tejun Heo
Date: Wed, 23 May 2018 11:04:54 -0700
cgroup_enable_task_cg_lists() incorrectly nests non-irq-safe
tasklist_lock inside ir
>From 0aa2e9b921d6db71150633ff290199554f0842a8 Mon Sep 17 00:00:00 2001
From: Tejun Heo
Date: Wed, 23 May 2018 10:29:00 -0700
cgwb_release() punts the actual release to cgwb_release_workfn() on
system_wq. Depending on the number of cgroups or block devices, there
can be a lot
On Sat, May 19, 2018 at 10:29:36PM +0100, Sudip Mukherjee wrote:
> From: Sudip Mukherjee
>
> While whitelisting Micron M500DC drives, the tweaked blacklist entry
> enabled queued TRIM from M500IT variants also. But these do not support
> queued TRIM. And while using those SSDs with the latest ker
On Fri, May 18, 2018 at 03:03:49PM +0200, Roman Pen wrote:
> Function is going to be used in transport over RDMA module
> in subsequent patches.
>
> Signed-off-by: Roman Pen
> Cc: Tejun Heo
> Cc: linux-kernel@vger.kernel.org
Acked-by: Tejun Heo
Please feel free to apply
ly defines how
worker->pool updates are synchronized.
This will help later workqueue visibility improvements by allowing
safe access to workqueue information from worker->task.
Signed-off-by: Tejun Heo
---
kernel/workqueue.c | 16
kernel/workqueue_internal.h | 2 +-
501 - 600 of 8459 matches
Mail list logo
