RE: [PATCH 4/9] regulator: bd71837: Devicetree bindings for BD71837 regulators

Hello Mark, First of all, thank you for taking your time to check the patches. I do appreciate it. I find reading patches hard myself. > From: Mark Brown [broo...@kernel.org] > Sent: Thursday, May 24, 2018 5:01 PM > > > On Thu, May 24, 2018 at 08:57:52AM +0300, Matti Vaittinen wrote: > > >

RE: [PATCH 9/9] regulator: bd71837: Build BD71837 regulator driver

> On Thu, May 24, 2018 at 09:01:14AM +0300, Matti Vaittinen wrote: > > Configurations and Makefile for BD71837 regulator driver > > > > Signed-off-by: Matti Vaittinen > > --- > > drivers/regulator/Kconfig | 11 +++ > > drivers/regulator/Makefile | 1

RE: [PATCH 8/9] regulator: bd71837: BD71837 PMIC regulator driver

From: Mark Brown [broo...@kernel.org] > Sent: Thursday, May 24, 2018 5:14 PM > > On Thu, May 24, 2018 at 09:00:36AM +0300, Matti Vaittinen wrote: > > > @@ -0,0 +1,683 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* Copyright (C) 2018 ROHM Semiconductors */ > > +/* > > + * bd71837-regulator.c

RE: [PATCH] regulator: bd71837: add to fix build errors

Hello, From: Randy Dunlap > Fix build error due to missing header file: > > drivers/regulator/bd71837-regulator.c:242:3: error: implicit declaration of > function 'of_match_ptr' [-Werror=implicit-function-declaration] > > Fixes: ba08799e90b5 ("regulator: bd71837: BD71837 PMIC regulator

Re: [PATCH v2 10/17] gpio: support ROHM BD71815 GPOs

Hi Bartosz, On Tue, 2021-01-19 at 12:07 +0100, Bartosz Golaszewski wrote: > On Tue, Jan 19, 2021 at 8:23 AM Matti Vaittinen > wrote: > > Support GPO(s) found from ROHM BD71815 power management IC. The IC > > has two > > GPO pins but only one is properly documented in data-sheet. The > > driver >

Re: [PATCH RESEND v6 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

Hello Lee, Nice to see you are back :) On Thu, 2021-01-14 at 10:00 +, Lee Jones wrote: > On Tue, 29 Dec 2020, Vaittinen, Matti wrote: > > > Hello Again peeps, > > > > On Thu, 2020-12-17 at 12:04 +0200, Matti Vaittinen wrote: > > > On Wed, 2020-12-02 at 1

Re: [PATCH] gpio: bd7xxxx: use helper variable for pdev->dev

Thanks for making this better :) On Wed, 2021-01-06 at 11:11 +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Using a helper local variable to store the address of >dev adds > to readability and allows us to avoid unnecessary line breaks. > > Signed-off-by: Bartosz Golaszewski

Re: [PATCH 1/2] watchdog: bd70528: don't crash if WDG is confiured with BD71828

Thanks a lot for taking a careful look at this Guenter! On Thu, 2021-01-07 at 07:12 -0800, Guenter Roeck wrote: > On Thu, Jan 07, 2021 at 08:37:03AM +0200, Matti Vaittinen wrote: > > If config for BD70528 watchdog is enabled when BD71828 or BD71815 > > are used the RTC module will issue call to

Re: [PATCH 11/15] regulator: rohm-regulator: SNVS dvs and linear voltage support

Hello Lee, Thanks for carefull review! I do appreciate this! On Fri, 2021-01-15 at 08:26 +, Lee Jones wrote: > On Fri, 08 Jan 2021, Matti Vaittinen wrote: > > > The helper for obtaining HW-state based DVS voltage levels > > currently only > > works for regulators using linear-ranges. Extend

Re: [PATCH] regulator: bd718x7, bd71828, Fix dvs voltage levels

On Fri, 2021-01-15 at 13:47 +, Lee Jones wrote: > On Fri, 15 Jan 2021, Matti Vaittinen wrote: > > > The ROHM BD718x7 and BD71828 drivers support setting HW state > > specific voltages from device-tree. This is used also by various > > in-tree DTS files. > > > > These drivers do incorrectly

Re: [PATCH] regulator: bd718x7, bd71828, Fix dvs voltage levels

On Fri, 2021-01-15 at 14:41 +, Lee Jones wrote: > On Fri, 15 Jan 2021, Matti Vaittinen wrote: > > > The ROHM BD718x7 and BD71828 drivers support setting HW state > > specific voltages from device-tree. This is used also by various > > in-tree DTS files. > > > > These drivers do incorrectly

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt > flags. > These are simple defines so they could be used in DTS but they will > not > have the same meaning: > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE > 2.

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

Hello Krzysztof, On Wed, 2020-09-09 at 10:17 +0200, k...@kernel.org wrote: > On Wed, Sep 09, 2020 at 06:30:44AM +0000, Vaittinen, Matti wrote: > > On Tue, 2020-09-08 at 16:59 +0200, Krzysztof Kozlowski wrote: > > > GPIO_ACTIVE_x flags are not correct in the context of int

Re: [PATCH] dt-bindings: mfd: Correct interrupt flags in examples

On Wed, 2020-09-09 at 11:20 +0200, k...@kernel.org wrote: > On Wed, Sep 09, 2020 at 08:57:36AM +0000, Vaittinen, Matti wrote: > > Hello Krzysztof, > > > > On Wed, 2020-09-09 at 10:17 +0200, k...@kernel.org wrote: > > > On Wed, Sep 09, 2020 at 06:30:44AM

Re: [PATCH -next] regulator: bd718x7: Make some variable static

On Thu, 2020-09-10 at 11:42 +0800, YueHaibing wrote: > Fix sparse warnings: > > drivers/regulator/bd718x7-regulator.c:576:28: warning: symbol > 'bd71847_swcontrol_ops' was not declared. Should it be static? > drivers/regulator/bd718x7-regulator.c:585:28: warning: symbol > 'bd71847_hwcontrol_ops'

Re: [PATCH 06/13] dt-bindings: mfd: rohm,bd71837-pmic: Add common properties

st: 0 > > > > + clock-output-names: > > +maxItems: 1 > > Ideally this one too, but we've been more flexible on it. Data-sheet for BD71837 uses pin name "C32k_OUT". So maybe this would be good? BD71838 uses "bd71828-32k-out" . so we could also go with

Re: [PATCH v1 1/6] dt_bindings: mfd: Add ROHM BD9576MUF and BD9573MUF PMICs

Thanks Rob for taking a look at this! On Fri, 2020-09-18 at 11:28 -0600, Rob Herring wrote: > On Thu, Sep 17, 2020 at 11:01:52AM +0300, Matti Vaittinen wrote: > > Add bindings for ROHM BD9576MUF and BD9573MUF PMICs. These > > PMICs are primarily intended to be used to power the R-Car series > >

Re: [PATCH v2 02/10] mfd: rohm-generic: Add BD9571 and BD9574

CHIP_TYPE_BD71828, > + ROHM_CHIP_TYPE_BD9571, > + ROHM_CHIP_TYPE_BD9574, > ROHM_CHIP_TYPE_AMOUNT > }; > Just a note to Lee & Others: This will probably conflict with the BD9573/BD9576 patch series (which introduces those chip IDs here). Conflict should be trivial though. With that note: Reviewed-By: Matti Vaittinen --Matti

Re: [PATCH v2 03/10] regulator: bd9571mwv: rid of using struct bd9571mwv

On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > To simplify this driver, use dev_get_regmap() and > rid of using struct bd9571mwv. > > Signed-off-by: Yoshihiro Shimoda > --- > drivers/regulator/bd9571mwv-regulator.c | 49 + > > 1 file changed, 26

Re: [PATCH v2 04/10] regulator: bd9571mwv: Add BD9574MWF support

Hello again Shimada-san, On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > Add support for BD9574MWF which is silimar chip with BD9571MWV. > Note that BD9574MWF doesn't support AVS and VID. I'd like to understand what is VID? > > Signed-off-by: Yoshihiro Shimoda > --- >

Re: [PATCH v2 06/10] gpio: bd9571mwv: rid of using struct bd9571mwv

On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > To simplify this driver, use dev_get_regmap() and > rid of using struct bd9571mwv. > > Signed-off-by: Yoshihiro Shimoda FWIW: Reviewed-By: Matti Vaittinen > --- > drivers/gpio/gpio-bd9571mwv.c | 19 +-- > 1 file

Re: [PATCH v2 07/10] gpio: bd9571mwv: Add BD9574MWF support

On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > Add support for BD9574MWF which is silimar chip with BD9571MWV. > Note that BD9574MWF has an additional feature, but doesn't > support it for now. nit: Perhaps mention which feature? And I think you mean the driver does not support it

Re: [PATCH v2 09/10] mfd: bd9571mwv: Make the driver more generic

Hi Yoshihiro-san, On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > Since the driver supports BD9571MWV PMIC only, > this patch makes the functions and data structure become more generic > so that it can support other PMIC variants as well. > >

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

Hi deee Ho Yoshihiro-san, Geert, All, On Wed, 2020-12-09 at 14:30 +0100, Geert Uytterhoeven wrote: > Hi Shimoda-san, > > CC Matti (BD9573/6 driver for R-Car platforms) Thank Geert! I wouldn't have noticed this :) > > (I don't have the BD9574 datasheet, so I have to base my review on >

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote: > Hi Geert-san, > > Thank you for your review! > > > From: Geert Uytterhoeven, Sent: Wednesday, December 9, 2020 10:30 > > PM > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++ b/drivers/mfd/bd9571mwv.c > > > > > > @@ -182,6 +272,8 @@

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > The new PMIC BD9574MWF inherits features from BD9571MWV. > Add the support of new PMIC to existing bd9571mwv driver. > > Signed-off-by: Khiem Nguyen > [shimoda: rebase and refactor] > Signed-off-by: Yoshihiro

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

On Thu, 2020-12-10 at 09:19 +0100, Geert Uytterhoeven wrote: > Hi Matti, Shimoda-san, > > On Thu, Dec 10, 2020 at 8:33 AM Vaittinen, Matti > wrote: > > On Thu, 2020-12-10 at 04:44 +, Yoshihiro Shimoda wrote: > > > > From: Geert Uytterhoeven, Sent: Wednesday,

Re: [PATCH 3/3] mfd: bd9571mwv: Add support for BD9574MWF

Hi Yoshihiro san, On Thu, 2020-12-10 at 10:58 +, Yoshihiro Shimoda wrote: > Hi Matti, > > > From: Vaittinen, Matti, Sent: Thursday, December 10, 2020 5:28 PM > > > > On Tue, 2020-12-08 at 17:04 +0900, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen &g

Re: [PATCH v4 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices()

On Tue, 2020-12-22 at 09:41 +0100, Geert Uytterhoeven wrote: > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda > wrote: > > To remove mfd devices when unload this driver, should use > > devm_mfd_add_devices() instead. > > > > Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") >

Re: [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote: > On Mon, Dec 21, 2020 at 3:57 AM Yoshihiro Shimoda > wrote: > > Use dev_regmap_add_irq_chip() to simplify the code. > > > > Signed-off-by: Yoshihiro Shimoda > > Acked-for-MFD-by: Lee Jones > > Reviewed-by: Geert Uytterhoeven

Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF

On Tue, 2020-12-22 at 09:23 +, Yoshihiro Shimoda wrote: > Hi Geert-san, > > Thank you for your review! > > > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM > > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda > > wrote: > > > > --- a/drivers/mfd/bd9571mwv.c > > > +++

Re: [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

On Tue, 2020-12-22 at 09:25 +, Yoshihiro Shimoda wrote: > Hi Matti-san, > > > From: Vaittinen, Matti, Sent: Tuesday, December 22, 2020 6:15 PM > > > > On Tue, 2020-12-22 at 09:49 +0100, Geert Uytterhoeven wrote: > > > On Mon, Dec 21, 2020 at 3:57

Re: [PATCH v2] regulators: bd718x7: Add enable times

On Fri, 2020-12-18 at 19:38 +0100, Guido Günther wrote: > Use the typical startup times from the data sheet so boards get a > reasonable default. Not setting any enable time can lead to board > hangs > when e.g. clocks are enabled too soon afterwards. > > This fixes gpu power domain resume on

Re: [PATCH] lib/linear_ranges: fix repeated words & one typo

Thanks for corrections! On Sun, 2020-12-20 at 20:06 -0800, Randy Dunlap wrote: > Change "which which" to "for which" in 3 places. > Change "ranges" to possessive "range's" in 1 place. > > Signed-off-by: Randy Dunlap > Cc: Andrew Morton > Cc: Mark Brown > Cc: Matti Vaittinen Reviewed-by:

Re: [PATCH v2 04/10] regulator: bd9571mwv: Add BD9574MWF support

Hello Shimoda-san, On Mon, 2020-12-14 at 04:57 +, Yoshihiro Shimoda wrote: > Hello Matti-san, > > > From: Vaittinen, Matti, Sent: Friday, December 11, 2020 9:34 PM > > > > Hello again Shimada-san, > > > > On Fri, 2020-12-11 at 20:27 +0900, Yoshih

Re: [PATCH v2 03/10] regulator: bd9571mwv: rid of using struct bd9571mwv

gt; > > On Fri, Dec 11, 2020 at 3:03 PM Vaittinen, Matti > > > wrote: > > > > On Fri, 2020-12-11 at 20:27 +0900, Yoshihiro Shimoda wrote: > > > > > > --- a/drivers/regulator/bd9571mwv-regulator.c > > > > > +++ b/drivers/regulator/

Re: [PATCH v2 03/10] regulator: bd9571mwv: rid of using struct bd9571mwv

On Wed, 2020-12-16 at 06:29 +, Yoshihiro Shimoda wrote: > Hi Matti-san, > > > From: Vaittinen, Matti, Sent: Wednesday, December 16, 2020 3:00 PM > > On Wed, 2020-12-16 at 02:13 +, Yoshihiro Shimoda wrote: > > > Hi Geert-san, Matti-san, > > > &g

Re: [PATCH v3 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > Use dev_regmap_add_irq_chip() to simplify the code. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Matti Vaittinen > --- > drivers/mfd/bd9571mwv.c | 27 ++- > 1 file changed, 6 insertions(+), 21

Re: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic

On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > Since the driver supports BD9571MWV PMIC only, > this patch makes the functions and data structure become more generic > so that it can support other PMIC variants as well. > > Signed-off-by: Khiem Nguyen >

Re: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF

On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > From: Khiem Nguyen > > The new PMIC BD9574MWF inherits features from BD9571MWV. > Add the support of new PMIC to existing bd9571mwv driver. > > Signed-off-by: Khiem Nguyen > [shimoda: rebase and refactor] > Signed-off-by: Yoshihiro

Re: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic

On Wed, 2020-12-16 at 10:25 +0200, Matti Vaittinen wrote: > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > > From: Khiem Nguyen > > > > Since the driver supports BD9571MWV PMIC only, > > this patch makes the functions and data structure become more > > generic > > so that it can

Re: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic

On Wed, 2020-12-16 at 09:00 +, Lee Jones wrote: > On Wed, 16 Dec 2020, Vaittinen, Matti wrote: > > > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen > > > > > > Since the driver supports BD9571MWV PMIC only, > &

Re: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF

On Wed, 2020-12-16 at 09:02 +, Lee Jones wrote: > On Wed, 16 Dec 2020, Vaittinen, Matti wrote: > > > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen > > > > > > The new PMIC BD9574MWF inherits features from BD957

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

Hello Guido, Thanks for looking at this! On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote: > Use the typical startup times from the data sheet so boards get a > reasonable default. Not setting any enable time can lead to board > hangs > when e.g. clocks are enabled too soon afterwards. >

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

On Wed, 2020-12-16 at 12:48 +, Mark Brown wrote: > On Wed, Dec 16, 2020 at 01:41:33PM +0100, Guido Günther wrote: > > On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote: > > > > + .enable_time = 144, > > > Where are thes

Re: [RFC PATCH v2 4/6] mfd: add BD71827 header

On Wed, 2020-12-16 at 08:53 +, Lee Jones wrote: > On Fri, 04 Dec 2020, Matti Vaittinen wrote: > > > Add BD71827 driver header. For a record - Header is originally > > based on work authored by Cong Pham although not much of original > > work is left now. > > > > Signed-off-by: Matti

Re: [PATCH RESEND v6 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

Hi deee Ho Lee, On Wed, 2020-12-02 at 15:32 +0200, Matti Vaittinen wrote: > Hello Lee, > > On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote: > > On Fri, 27 Nov 2020, Vaittinen, Matti wrote: > > > > > Hello Lee, > > > > > > On Fri, 2020-11-27

Re: [PATCH 1/1] regulators: bd718x7: Add enable times

On Wed, 2020-12-16 at 13:41 +0100, Guido Günther wrote: > Hi Matti, > On Wed, Dec 16, 2020 at 12:29:20PM +, Vaittinen, Matti wrote: > > Hello Guido, > > > > Thanks for looking at this! > > > > On Wed, 2020-12-16 at 12:05 +0100, Guido Günther wrote: >

Re: [PATCH RESEND v6 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

Hello Again peeps, On Thu, 2020-12-17 at 12:04 +0200, Matti Vaittinen wrote: > On Wed, 2020-12-02 at 15:32 +0200, Matti Vaittinen wrote: > > Hello Lee, > > > > On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote: > > > On Fri, 27 Nov 2020, Vaittinen, Matti w

Re: [PATCH v5 3/4] wdt: Support wdt on ROHM BD9576MUF and BD9573MUF

On Thu, 2020-11-05 at 13:38 +0200, Matti Vaittinen wrote: > Add Watchdog support for ROHM BD9576MUF and BD9573MUF PMICs which are > mainly used to power the R-Car series processors. The watchdog is > pinged using a GPIO and enabled using another GPIO. Additionally > watchdog time-out can be

Re: [PATCH v5 3/4] wdt: Support wdt on ROHM BD9576MUF and BD9573MUF

On Wed, 2020-11-11 at 06:41 -0800, Guenter Roeck wrote: > On 11/11/20 6:01 AM, Vaittinen, Matti wrote: > > On Thu, 2020-11-05 at 13:38 +0200, Matti Vaittinen wrote: > > > Add Watchdog support for ROHM BD9576MUF and BD9573MUF PMICs which > > > are > > > m

Re: [PATCH] gpio: bd70528: remove unneeded break

Thanks Tom, On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix > --- > drivers/gpio/gpio-bd70528.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpio/gpio-bd70528.c

Re: [PATCH] gpio: bd70528: remove unneeded break

On Tue, 2020-10-20 at 13:07 +0300, Matti Vaittinen wrote: > Thanks Tom, > > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > > From: Tom Rix > > > > A break is not needed if it is preceded by a return > > > > Signed-off-by: Tom Rix > > --- > > drivers/gpio/gpio-bd70528.c | 3 --- >

Re: [PATCH] gpio: bd70528: remove unneeded break

On Tue, 2020-10-20 at 14:46 +0300, Andy Shevchenko wrote: > On Tue, Oct 20, 2020 at 2:26 PM Vaittinen, Matti > wrote: > > On Mon, 2020-10-19 at 12:33 -0700, t...@redhat.com wrote: > > > - break; > > My personal taste is also to omit these breaks but I a

Re: [PATCH] gpio: bd70528: remove unneeded break

Hello, On Wed, 2020-10-21 at 07:39 -0700, Joe Perches wrote: > On Wed, 2020-10-21 at 07:25 +0000, Vaittinen, Matti wrote: > > Hello Joe & All, > > On Tue, 2020-10-20 at 11:36 -0700, Joe Perches wrote: > > > On Tue, 2020-10-20 at 11:48 +, Vaittinen, Matti wrote: &g

Re: [PATCH RESEND v6 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

Hello Lee, On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote: > On Fri, 27 Nov 2020, Vaittinen, Matti wrote: > > > Hello Lee, > > > > On Fri, 2020-11-27 at 08:32 +, Lee Jones wrote: > > > On Mon, 23 Nov 2020, Matti Vaittinen wrote: > > > &

Re: [PATCH RESEND v6 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

On Wed, 2020-12-02 at 12:57 +, Lee Jones wrote: > On Fri, 27 Nov 2020, Vaittinen, Matti wrote: > > > Hello Lee, > > > > On Fri, 2020-11-27 at 08:32 +, Lee Jones wrote: > > > On Mon, 23 Nov 2020, Matti Vaittinen wrote: > > > > > > > A

Re: [RFC PATCH 2/2] power: supply: add sw-gauge for SOC estimation and CC correction

On Thu, 2020-11-26 at 12:13 +0200, Matti Vaittinen wrote: > Add generic 'sw gauge' helper for performing iterative SOC estimation > and coulomb counter correction for devices with a (drifting) coulomb > counter. This should allow few charger/fuel-gauge drivers to use > generic > loop instead of

Re: [PATCH RESEND v6 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

Hello Lee, On Fri, 2020-11-27 at 08:32 +, Lee Jones wrote: > On Mon, 23 Nov 2020, Matti Vaittinen wrote: > > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are > > mainly used to power the R-Car series processors. > > > > Signed-off-by: Matti Vaittinen > > --- > >

Re: [PATCH] rtc: bd70528: fix link error

Hello All, On Thu, 2019-08-08 at 10:29 +0800, Yuehaibing wrote: > On 2019/7/9 13:25, Vaittinen, Matti wrote: > > Hello Arnd, > > > > (Added Randy who also sent a patch to fix this) > > > > On Mon, 2019-07-08 at 18:10 +0200, Arnd Bergmann wrote: > > >

Re: [PATCH] rtc: bd70528: fix link error

Hello Arnd, Thanks for taking a look on this! On Mon, 2019-07-08 at 14:41 +0200, Arnd Bergmann wrote: > With CONFIG_BD70528_WATCHDOG=m, a built-in rtc driver cannot call > into the low-level functions that are part of the watchdog module: > > drivers/rtc/rtc-bd70528.o: In function

Re: [PATCH] rtc: bd70528: add dependency to fix build errors

Hello Randy, Thanks a lot for trying to clean up the mess :) On Sun, 2019-07-07 at 09:12 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors when MFD_ROHM_BD70528=m, BD70528_WATCHDOG=m, > and RTC_DRV_BD70528=y. Fixes these build errors: > > ld: drivers/rtc/rtc-bd70528.o: in

Re: [PATCH] rtc: bd70528: fix link error

Hello Arnd, (Added Randy who also sent a patch to fix this) On Mon, 2019-07-08 at 18:10 +0200, Arnd Bergmann wrote: > On Mon, Jul 8, 2019 at 3:24 PM Vaittinen, Matti > wrote: > > > On Mon, 2019-07-08 at 14:41 +0200, Arnd Bergmann wrote: > > > With CONFIG_BD70528_WA

Re: [PATCH] regulator: bd70528: Drop unused include

Thanks Linus! On Sat, 2019-06-01 at 01:06 +0200, Linus Walleij wrote: > This driver does not use any symbols from > so just drop the include. > > Cc: Matti Vaittinen > Signed-off-by: Linus Walleij Acked-By: Matti Vaittinen Br, Matti Vaittinen

Re: [PATCH] regulator: bd718x7: Drop unused include

And thanks for this too =) On Sat, 2019-06-01 at 01:08 +0200, Linus Walleij wrote: > This driver does not use any symbols from > so just drop the include. > > Cc: Matti Vaittinen > Signed-off-by: Linus Walleij Acked-By: Matti Vaittinen Br, Matti Vaittinen

RE: [PATCH v2] arm64: dts: fsl: pico-pi: Add a device tree for the PICO-PI-IMX8M

; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Vaittinen, Matti; linux-...@nxp.com; Daniel Baluta Subject: Re: [PATCH v2] arm64: dts: fsl: pico-pi: Add a device tree for the PICO-PI-IMX8M On Thu, Jul 18, 2019 at 02:12:10PM +0300, Andra Danciu wrote: ... > > >

Re: [PATCH 01/16] dt-bindings: mfd: rohm,bd71847-pmic: Correct clock properties requirements

- - clocks > - - "#clock-cells" >- regulators > > additionalProperties: false > > +dependencies: > + '#clock-cells': [clocks] > + clocks: ['#clock-cells'] This is new to me. Please educate me - does this simply mean that if '#clock-cells' is given, th

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

Hello Krzysztof, Just some questions - please ignore if I misunderstood the impact of the change. On Mon, 2020-08-24 at 21:06 +0200, Krzysztof Kozlowski wrote: > Device tree schema expects regulator names to be lowercase. This > fixes > dtbs_check warnings like: > >

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

Hello Krzysztof, On Tue, 2020-08-25 at 09:50 +0200, k...@kernel.org wrote: > On Tue, Aug 25, 2020 at 09:45:00AM +0200, k...@kernel.org wrote: > > On Tue, Aug 25, 2020 at 09:25:37AM +0200, k...@kernel.org wrote: > > > On Tue, Aug 25, 2020 at 06:51:33AM +, Vaittinen, Matti wr

Re: [PATCH 03/16] arm64: dts: imx8mm-beacon-som.dtsi: Align regulator names with schema

On Tue, 2020-08-25 at 10:27 +0200, k...@kernel.org wrote: > On Tue, Aug 25, 2020 at 08:22:18AM +0000, Vaittinen, Matti wrote: > > Hello Krzysztof, > > > > On Tue, 2020-08-25 at 09:50 +0200, k...@kernel.org wrote: > > > On Tue, Aug 25, 2020 at 09:45:00A

Re: [PATCH v2 11/19] arm64: dts: imx8mn-ddr4-evk: Align regulator names with schema

On Fri, 2020-08-28 at 18:47 +0200, Krzysztof Kozlowski wrote: > Device tree schema expects regulator names to be lowercase. Changing > to > lowercase has multiple effects: > 1. LDO6 supply is now properly configured, because regulator driver >looks for supplies by lowercase name, > 2.

Re: [PATCH v2 08/19] arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC

On Fri, 2020-08-28 at 18:47 +0200, Krzysztof Kozlowski wrote: > The ROHM BD71847 PMIC has a 32.768 kHz clock. Adding necessary > parent > allows to probe the bd718x7 clock driver fixing boot errors: > > bd718xx-clk bd71847-clk.1.auto: No parent clk found > bd718xx-clk: probe of

Re: [PATCH v2] dt-bindings: mfd: rohm,bd71837-pmic: Add common properties

Hi d Ho peeps! On Thu, 2020-09-17 at 21:37 +0200, Krzysztof Kozlowski wrote: > Add common properties appearing in DTSes (clock-names, > clock-output-names) with the common values (actually used in DTSes) > to > fix dtbs_check warnings like: > >

Re: [PATCH v1 4/6] wdt: Support wdt on ROHM BD9576MUF and BD9573MUF

Thanks (again) for review Guenter! On Thu, 2020-09-17 at 22:45 -0700, Guenter Roeck wrote: > On 9/17/20 1:03 AM, Matti Vaittinen wrote: > > Add Watchdog support for ROHM BD9576MUF and BD9573MUF PMICs which > > are > > mainly used to power the R-Car series processors. The watchdog is > > pinged

Re: [PATCH v1 1/6] dt_bindings: mfd: Add ROHM BD9576MUF and BD9573MUF PMICs

On Wed, 2020-09-23 at 08:27 -0600, Rob Herring wrote: > On Sat, Sep 19, 2020 at 5:46 AM Vaittinen, Matti > wrote: > > Thanks Rob for taking a look at this! > > > > On Fri, 2020-09-18 at 11:28 -0600, Rob Herring wrote: > > > On Thu, Sep 17, 2020 at 11:01:

Re: [PATCH v1 1/6] dt_bindings: mfd: Add ROHM BD9576MUF and BD9573MUF PMICs

Hi dee Ho peeps! On Thu, 2020-09-24 at 09:12 +0300, Matti Vaittinen wrote: > On Wed, 2020-09-23 at 08:27 -0600, Rob Herring wrote: > > On Sat, Sep 19, 2020 at 5:46 AM Vaittinen, Matti > > wrote: > > > Thanks Rob for taking a look at this! > > > > > &

Re: [PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

Morning Lee, Thanks for taking a look at this :) I see most of the comments being valid. There's two I would like to clarify though... On Wed, 2020-11-04 at 15:51 +, Lee Jones wrote: > On Wed, 28 Oct 2020, Matti Vaittinen wrote: > > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs

Re: [PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

On Thu, 2020-11-05 at 08:46 +0200, Matti Vaittinen wrote: > Morning Lee, > > Thanks for taking a look at this :) I see most of the comments being > valid. There's two I would like to clarify though... > > On Wed, 2020-11-04 at 15:51 +, Lee Jones wrote: > > On Wed, 28 Oct 2020, Matti

Re: [PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

On Thu, 2020-11-05 at 08:21 +, Lee Jones wrote: > On Thu, 05 Nov 2020, Vaittinen, Matti wrote: > > > On Thu, 2020-11-05 at 08:46 +0200, Matti Vaittinen wrote: > > > Morning Lee, > > > > > > Thanks for taking a look at this :) I see most of the comments

Re: [PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

On Thu, 2020-11-05 at 08:23 +, Lee Jones wrote: > On Wed, 04 Nov 2020, Lee Jones wrote: > > > On Wed, 28 Oct 2020, Matti Vaittinen wrote: > > > > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are > > > mainly used to power the R-Car series processors. > > > > > >

Re: [PATCH v4 2/4] mfd: Support ROHM BD9576MUF and BD9573MUF

On Thu, 2020-11-05 at 08:58 +, Lee Jones wrote: > On Thu, 05 Nov 2020, Vaittinen, Matti wrote: > > > On Thu, 2020-11-05 at 08:21 +, Lee Jones wrote: > > > On Thu, 05 Nov 2020, Vaittinen, Matti wrote: > > > > > > > On Thu, 2020-1

Re: [PATCH 06/15] dt_bindings: regulator: Add ROHM BD71815 PMIC regulators

On Wed, 2021-01-13 at 07:53 -0600, Rob Herring wrote: > On Tue, Jan 12, 2021 at 08:10:14AM +0200, Matti Vaittinen wrote: > > On Mon, 2021-01-11 at 13:09 -0600, Rob Herring wrote: > > > On Fri, Jan 08, 2021 at 03:36:38PM +0200, Matti Vaittinen wrote: > > > > Add binding documentation for

short-circuit and over-current IRQs

Hi dee Ho peeps, I just noticed the 390af53e04114f790d60b63802a4de9d815ade03 ("regulator: qcom-labibb: Implement short-circuit and over-current IRQs") in regulator tree. No worries - I haven't hit any problem with it :] I've been working with ROHM BD9576MUF - which implements warning IRQs for

Re: short-circuit and over-current IRQs

wrote: > > > On Wed, Jan 27, 2021 at 12:01:55PM +, Vaittinen, Matti wrote: > > > I will see if I can cook-up something decent - but as I said, I > > would > > appreciate any/all testing if I get patch crafted :) > > I develop this stuff in my spare time

Re: short-circuit and over-current IRQs

On Wed, 2021-01-27 at 16:32 +, Mark Brown wrote: > On Wed, Jan 27, 2021 at 03:34:46PM +0100, AngeloGioacchino Del Regno > wrote: > > Il 27/01/21 13:56, Matti Vaittinen ha scritto: > > > I can only speak for BD9576MUF - which has two limits for > > > monitored > > > entity

Re: [PATCH 1/2] MAINTAINERS: Add entry for ROHM power management ICs

Morning Lee, On Wed, 2020-05-20 at 07:35 +0100, Lee Jones wrote: > On Wed, 20 May 2020, Matti Vaittinen wrote: > > > Add entry for maintaining power management IC drivers for ROHM > > BD71837, BD71847, BD71850, BD71828, BD71878, BD70528 and BD99954. > > > > Signed-off-by: Matti Vaittinen > >

Re: [PATCH v14 0/8] support ROHM BD70528 PMIC

Hello All, On Thu, 2019-05-02 at 12:11 +0300, Matti Vaittinen wrote: > Patch series introducing support for ROHM BD70528 PMIC > Just thought I'd ask if there's any chances to get this series in 5.2? It seems to me the WDT part (patch 8) was already merged in but rest of the patches seem to be in

Re: [PATCH v14 0/8] support ROHM BD70528 PMIC

Hello Alexandre, On Tue, 2019-05-21 at 13:41 +0200, Alexandre Belloni wrote: > On 21/05/2019 11:01:53+0000, Vaittinen, Matti wrote: > > Hello All, > > > > On Thu, 2019-05-02 at 12:11 +0300, Matti Vaittinen wrote: > > > Patch series introducing support for ROHM BD7

Re: [PATCH 1/3] regulator: core: fix boot-on regulators use_count usage

On Fri, 2019-10-04 at 12:32 +0100, Mark Brown wrote: > On Fri, Oct 04, 2019 at 09:34:43AM +0300, Matti Vaittinen wrote: > > On Tue, Oct 01, 2019 at 12:57:31PM -0700, Doug Anderson wrote: > > > I don't think your fix is correct. It sounds as if the intention > > > of > > > "regulator-boot-on" is

Re: [RFC PATCH 09/13] mfd: rtc: support RTC on ROHM BD71828 with BD70528 driver

Hello Alexandre, Thanks for quick check! I'll be off for the rest of the week but I will re-work this patch at next week :) I agree with you regarding most of the comments. > > + > > + > > +/* > > + * RTC definitions shared between > > + * > > + * BD70528 > > + * and BD71828 > > + */ > > + > >

Re: [PATCH/RFC] clk: gate: Add some kunit test suites

Hello David, & All This review and mail is more for pointing out the downsides of UTs. I am not demanding any changes, these comments can be seen as 'nit's. On Wed, 2020-04-29 at 12:15 +0800, David Gow wrote: > On Tue, Apr 14, 2020 at 7:46 PM Vaittinen, Matti > wrote: > > Hel

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

Hello Jacek, Thanks for the clarifications. I think I now understand the LED subsystem a bit better :) On Mon, 2019-10-21 at 21:09 +0200, Jacek Anaszewski wrote: > Hi Matti, > > On 10/21/19 10:00 AM, Vaittinen, Matti wrote: > > Hello Dan, > > > > Thanks for taking

Re: [RFC PATCH 10/13] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs

Hello Bartosz, Just a short note at this point. On Mon, 2019-10-21 at 16:36 +0200, Bartosz Golaszewski wrote: > pon., 21 paź 2019 o 09:00 Vaittinen, Matti > napisał(a): > > On Thu, 2019-10-17 at 14:45 +0200, Bartosz Golaszewski wrote: > > > czw., 17 paź 2019 o

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

Morning Jacek, Thanks for the reply again. I did some cleaning to this mail as it was getting lengthy. On Tue, 2019-10-22 at 19:40 +0200, Jacek Anaszewski wrote: > Matti, > > On 10/22/19 2:40 PM, Vaittinen, Matti wrote: > > Hello Jacek, > > > > Thanks for the cl

Re: [RFC PATCH 09/13] mfd: rtc: support RTC on ROHM BD71828 with BD70528 driver

Hello again Alexandre, On Thu, 2019-10-17 at 12:48 +0200, Alexandre Belloni wrote: > On 17/10/2019 10:36:44+0000, Vaittinen, Matti wrote: > > Hello Alexandre, > > > > Thanks for quick check! I'll be off for the rest of the week but I > > will > > re-work t

Re: [PATCH/RFC] clk: gate: Add some kunit test suites

On Mon, 2020-05-04 at 13:19 -0700, Brendan Higgins wrote: > On Sun, May 3, 2020 at 10:54 PM Vaittinen, Matti > wrote: > > On Wed, 2020-04-29 at 12:15 +0800, David Gow wrote: > > > On Tue, Apr 14, 2020 at 7:46 PM Vaittinen, Matti > > > wrot

Re: [PATCH v12 02/11] lib/test_linear_ranges: add a test for the 'linear_ranges'

Thanks Mark! On Fri, 2020-05-08 at 18:17 +0100, Mark Brown wrote: > On Fri, May 08, 2020 at 06:40:43PM +0300, Matti Vaittinen wrote: > > Add a KUnit test for the linear_ranges helper. > > > > Signed-off-by: Matti Vaittinen > > Reviewed-by: Brendan Higgins > > This now generates: > >

Re: [PATCH v12 02/11] lib/test_linear_ranges: add a test for the 'linear_ranges'

On Fri, 2020-05-08 at 18:17 +0100, Mark Brown wrote: > On Fri, May 08, 2020 at 06:40:43PM +0300, Matti Vaittinen wrote: > > Add a KUnit test for the linear_ranges helper. > > > > Signed-off-by: Matti Vaittinen > > Reviewed-by: Brendan Higgins > > This now generates: > > WARNING: modpost:

Re: [PATCH v12 00/11] Support ROHM BD99954 charger IC

Thanks a lot Sebastian and Mark! On Sun, 2020-05-10 at 18:04 +0200, Sebastian Reichel wrote: > Hi, > > On Fri, May 08, 2020 at 06:38:17PM +0300, Matti Vaittinen wrote: > > Please note that this series should be applied to two trees. > > Patches > > 1-4 (or 1-5 as suggested by Sebastian) should

Re: [PATCH] lib: linear_ranges: Add missing MODULE_LICENSE()

Morning folks, On Sun, 2020-05-10 at 21:50 +0200, Sebastian Reichel wrote: > Hi, > > On Sat, May 09, 2020 at 06:15:19PM +0300, Matti Vaittinen wrote: > > When linear_ranges is compiled as module we get warning > > about missing MODULE_LICENSE(). Fix it by adding > > MODULE_LICENSE("GPL") as is

  1   2   >