Re: [PATCH v2 1/5] virtio: add functions for piecewise addition of buffers

status group 0 (all jobs): READ: io=34863MB, aggrb=242320KB/s, minb=242320KB/s, maxb=242320KB/s, mint=147325msec, maxt=147325msec WRITE: io=34437MB, aggrb=239357KB/s, minb=239357KB/s, maxb=239357KB/s, mint=147325msec, maxt=147325msec Thanks, Wanlong Gao From

Re: kernel panic when reboot

On 12/14/2012 07:02 PM, Borislav Petkov wrote: On Fri, Dec 14, 2012 at 05:29:09PM +0800, Wanlong Gao wrote: Hi, I hit the kernel panic when reboot the system today, just system reboot can cause kernel panic. $ git describe v3.7-7784-g7313264 The config file is attached. And the crash

Re: [char-misc for 3.8] mei: avoid oops in watchdog unregister code path

...@alien8.de Cc: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Jerry Snitselaar jerry.snitsel...@oracle.com Signed-off-by: Tomas Winkler tomas.wink...@intel.com Fixed the panic here, thank you. Tested-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/misc/mei/wd.c |2 +- 1

[PATCH V4 2/2] virtio-net: reset virtqueue affinity when doing cpu hotplug

: Jason Wang jasow...@redhat.com Cc: Eric Dumazet erdnet...@gmail.com Cc: virtualizat...@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/net/virtio_net.c | 30 ++ 1 file changed, 30 insertions(+) diff

[PATCH V4 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: Jason Wang jasow...@redhat.com Cc: Eric Dumazet erdnet...@gmail.com Cc: virtualizat...@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- V3-V4: move vq_index

[PATCH 1/2] virtio-scsi: split out request queue set affinity function

These two patches are based on the multi-queue virtio-scsi patch set. We set cpu affinity when the num_queues equals to the number of VCPUs. Split out the set affinity function, this also fix the bug when CPU IDs are not consecutive. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com

[PATCH 2/2] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/scsi/virtio_scsi.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi

[PATCH V2 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

erdnet...@gmail.com Cc: virtualizat...@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/net/virtio_net.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio_net.c b

[PATCH V2 2/2] virtio-net: reset virtqueue affinity when doing cpu hotplug

Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: Jason Wang jasow...@redhat.com Cc: Eric Dumazet erdnet...@gmail.com Cc: virtualizat...@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/net/virtio_net.c

Re: [PATCH V2 2/2] virtio-net: reset virtqueue affinity when doing cpu hotplug

On 01/07/2013 03:28 PM, Jason Wang wrote: On 01/07/2013 03:15 PM, Wanlong Gao wrote: Add a cpu notifier to virtio-net, so that we can reset the virtqueue affinity if the cpu hotplug happens. It improve the performance through enabling or disabling the virtqueue affinity after doing cpu

Re: [PATCH V2 2/2] virtio-net: reset virtqueue affinity when doing cpu hotplug

On 01/07/2013 03:55 PM, Jason Wang wrote: On 01/07/2013 03:48 PM, Wanlong Gao wrote: On 01/07/2013 03:28 PM, Jason Wang wrote: On 01/07/2013 03:15 PM, Wanlong Gao wrote: Add a cpu notifier to virtio-net, so that we can reset the virtqueue affinity if the cpu hotplug happens. It improve

[PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Cc: Jason Wang jasow...@redhat.com Cc: Eric Dumazet erdnet...@gmail.com Cc: virtualizat...@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/net/virtio_net.c | 39

[PATCH V3 2/2] virtio-net: reset virtqueue affinity when doing cpu hotplug

: Jason Wang jasow...@redhat.com Cc: Eric Dumazet erdnet...@gmail.com Cc: virtualizat...@lists.linux-foundation.org Cc: net...@vger.kernel.org Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- drivers/net/virtio_net.c | 30 ++ 1 file changed, 30 insertions(+) diff

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

On 01/09/2013 07:31 AM, Rusty Russell wrote: Wanlong Gao gaowanl...@cn.fujitsu.com writes: */ static u16 virtnet_select_queue(struct net_device *dev, struct sk_buff *skb) { -int txq = skb_rx_queue_recorded(skb) ? skb_get_rx_queue(skb) : - smp_processor_id(); +int

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

On 01/08/2013 06:26 PM, Jason Wang wrote: On 01/08/2013 06:07 PM, Wanlong Gao wrote: As Michael mentioned, set affinity and select queue will not work very well when CPU IDs are not consecutive, this can happen with hot unplug. Fix this bug by traversal the online CPUs, and create a per cpu

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

On 01/10/2013 08:49 AM, Rusty Russell wrote: Wanlong Gao gaowanl...@cn.fujitsu.com writes: On 01/09/2013 07:31 AM, Rusty Russell wrote: Wanlong Gao gaowanl...@cn.fujitsu.com writes: */ static u16 virtnet_select_queue(struct net_device *dev, struct sk_buff *skb) { - int txq

Re: [PATCH net 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready

. Tsirkin m...@redhat.com Cc: Wanlong Gao gaowanl...@cn.fujitsu.com Signed-off-by: Jason Wang jasow...@redhat.com Thank you. Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- The patch is need for 3.8 and above. --- drivers/net/virtio_net.c | 8 1 file changed, 8 insertions

[PATCH] sh: fix kernel build error

once for each function it appears in cc1: all warnings being treated as errors This is introduced by commit 16559ae. CC: kbuild-...@01.org Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- arch/sh/kernel/kgdb.c | 1 + 1 file changed, 1

Re: [PATCH] sh: fix kernel build error

On 11/14/2013 02:14 AM, Sergei Shtylyov wrote: Hello. On 11/13/2013 05:38 PM, Wanlong Gao wrote: arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs': arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function

Re: [PATCH net] virtio-net: correctly handle cpu hotplug notifier during resuming

the hotcpu notifier during restore and register a new one in resume. Reported-by: Fengguang Wu fengguang...@intel.com Tested-by: Fengguang Wu fengguang...@intel.com Cc: Wanlong Gao gaowanl...@cn.fujitsu.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Signed

Re: [net-next/master PATCH] lib: fix compile warning in hashlib_init

On 12/19/2013 09:32 AM, Daniel Borkmann wrote: On 12/19/2013 02:15 AM, Fengguang Wu wrote: CC the list. On Thu, Dec 19, 2013 at 09:08:34AM +0800, Wanlong Gao wrote: /git/linux/lib/hash.c: In function 'hashlib_init': /git/linux/lib/hash.c:35:2: warning: passing argument 1

mqueue perf data

Hi Fengguang, Do we need to stat out the perf data of mqueue test in kernel_selftests? It's like following. Thanks, Wanlong Gao # make run_tests -C mqueue make: Entering directory `/git/linux/tools/testing/selftests/mqueue' Initial system state: Using queue path

[BUG] LTP test case readahead01 fails after commit 63d0f0a3c7

-a_ops-readpages)) return -EINVAL; = I think you must know which is right? Thanks, Wanlong Gao [1]: commit 63d0f0a3c7e1281fd79268a8d988167eff607fb6 Author: Andrew Morton a...@linux-foundation.org Date: Tue Nov 12 15:07:09 2013 -0800 mm

Re: [PATCH 2/2] virtio-net: fix buggy features advertised by host

does not advertise +VIRTIO_NET_F_CTRL_VQ); + virtio_disable_feature(dev, VIRTIO_NET_F_CTRL_MAC_ADDR); + } Can we use a feature array and check with one loop? The current check looks so dup? Thanks, Wanlong Gao

Race condition in vfio will cause deadwait

From: Wen Congyang Hi, Alex Williamson When using vfio, we encounter a problem: too many lspci processes are blocked in D state. I analyzed all processes, and found one process is blocked in pci_dev_lock(), another process is blocked in vfio_del_group_put(). I checked

[PATCH v2] modpost: abort if module name is too long

. Signed-off-by: Wanlong Gao <wanlong@gmail.com> --- scripts/mod/modpost.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 30d752a..cb16985 100644 --- a/scripts/mod/modpost.c +++ b/scrip

Re: [PATCH] modpost: abort if a module name is too long

On 2017/6/22 0:09, Jessica Yu wrote: > +++ Jessica Yu [06/06/17 20:41 -0700]: >> +++ Wanlong Gao [06/06/17 09:07 +0800]: >>> >>> >>> On 2017/6/5 10:09, Jessica Yu wrote: >>>> +++ Wanlong Gao [02/06/17 11:04 +0800]: >>>>> >>>

Re: [PATCH] modpost: abort if a module name is too long

On 2017/6/22 22:25, Jessica Yu wrote: > +++ Wanlong Gao [22/06/17 09:11 +0800]: >> >> >> On 2017/6/22 0:09, Jessica Yu wrote: >>> +++ Jessica Yu [06/06/17 20:41 -0700]: >>>> +++ Wanlong Gao [06/06/17 09:07 +0800]: >>>>> >>>>&g

Re: [PATCH] modpost: abort if a module name is too long

Folks, Any comments? On 2017/5/20 15:46, Xie XiuQi wrote: > From: Wanlong Gao <gaowanl...@huawei.com> > > Module name has a limited length, but currently the build system > allows the build finishing even if the module name is too long. > > CC

Re: [PATCH] modpost: abort if a module name is too long

Hi Jessica, On 2017/5/31 11:30, Jessica Yu wrote: > +++ Wanlong Gao [31/05/17 10:23 +0800]: >> Hi Jessica, >> >> On 2017/5/29 17:10, Jessica Yu wrote: >>> +++ Xie XiuQi [20/05/17 15:46 +0800]: >>>> From: Wanlong Gao <gaowanl...@huawei.com> >>&

Re: [PATCH] modpost: abort if a module name is too long

On 2017/5/31 11:30, Jessica Yu wrote: > +++ Wanlong Gao [31/05/17 10:23 +0800]: >> Hi Jessica, >> >> On 2017/5/29 17:10, Jessica Yu wrote: >>> +++ Xie XiuQi [20/05/17 15:46 +0800]: >>>> From: Wanlong Gao <gaowanl...@huawei.com> >>>> &g

Re: [PATCH] modpost: abort if a module name is too long

Hi Jessica, On 2017/5/29 17:10, Jessica Yu wrote: > +++ Xie XiuQi [20/05/17 15:46 +0800]: >> From: Wanlong Gao <gaowanl...@huawei.com> >> >> Module name has a limited length, but currently the build system >> allows the build finishing even if the module name is t

Re: [PATCH] modpost: abort if a module name is too long

On 2017/6/2 7:23, Jessica Yu wrote: > +++ Wanlong Gao [31/05/17 11:48 +0800]: >> >> >> On 2017/5/31 11:30, Jessica Yu wrote: >>> +++ Wanlong Gao [31/05/17 10:23 +0800]: >>>> Hi Jessica, >>>> >>>> On 2017/5/29 17:10, Jessica

Re: [PATCH] modpost: abort if a module name is too long

On 2017/6/2 11:04, Wanlong Gao wrote: > > > On 2017/6/2 7:23, Jessica Yu wrote: >> +++ Wanlong Gao [31/05/17 11:48 +0800]: >>> >>> >>> On 2017/5/31 11:30, Jessica Yu wrote: >>>> +++ Wanlong Gao [31/05/17 10:23 +0800]: >>>

Re: [PATCH] modpost: abort if a module name is too long

Jessica, On 2017/5/31 11:48, Wanlong Gao wrote: > > > On 2017/5/31 11:30, Jessica Yu wrote: >> +++ Wanlong Gao [31/05/17 10:23 +0800]: >>> Hi Jessica, >>> >>> On 2017/5/29 17:10, Jessica Yu wrote: >>>> +++ Xie XiuQi [20/05/17 15:46

Re: [PATCH] modpost: abort if a module name is too long

On 2017/6/5 10:09, Jessica Yu wrote: > +++ Wanlong Gao [02/06/17 11:04 +0800]: >> >> >> On 2017/6/2 7:23, Jessica Yu wrote: >>> +++ Wanlong Gao [31/05/17 11:48 +0800]: >>>> >>>> >>>> On 2017/5/31 11:30, Jessica Yu wrot

Re: [PATCH V7 0/5] virtio-scsi multiqueue

On 03/28/2013 10:22 AM, Wanlong Gao wrote: > On 03/23/2013 07:28 PM, Wanlong Gao wrote: >> This series implements virtio-scsi queue steering, which gives >> performance improvements of up to 50% (measured both with QEMU and >> tcm_vhost backends). >> >> This versi

Re: [PATCH V7 0/5] virtio-scsi multiqueue

On 04/06/2013 04:40 PM, James Bottomley wrote: > On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote: >> On 03/28/2013 10:22 AM, Wanlong Gao wrote: >>> On 03/23/2013 07:28 PM, Wanlong Gao wrote: >>>> This series implements virtio-scsi queue steering, which gives

[PATCH] sh: fix kernel build error

27: note: each undeclared identifier is reported only once for each function it appears in cc1: all warnings being treated as errors This is introduced by commit 16559ae. CC: kbuild-...@01.org Reported-by: Fengguang Wu Signed-off-by: Wanlong Gao --- arch/sh/kernel/kgdb.c | 1 + 1 file changed,

Re: [PATCH] sh: fix kernel build error

On 11/14/2013 02:14 AM, Sergei Shtylyov wrote: > Hello. > > On 11/13/2013 05:38 PM, Wanlong Gao wrote: > >> arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs': >>>> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function >>&g

Re: [PATCH net] virtio-net: correctly handle cpu hotplug notifier during resuming

rnatives > [ 623.194559] smpboot: Booting Node 0 Processor 1 APIC 0x1 > ... > > A correct fix is to unregister the hotcpu notifier during restore and > register a > new one in resume. > > Reported-by: Fengguang Wu > Tested-by: Fengguang Wu > Cc: Wanlong Gao

[PATCH V5 1/5] virtio-scsi: redo allocation of target data

-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 40 +++- 1 file changed, 11 insertions(+), 29 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index b53ba9e..3256c51 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi

[PATCH V5 4/5] virtio-scsi: introduce multiqueue support

Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 269 - 1 file changed, 241 insertions(+), 28 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 94a64ad..1d95295 10064

[PATCH V5 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done

From: Paolo Bonzini Avoid duplicated code in all of the callers. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff

[PATCH V5 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 29 + 1 file changed, 29 insertions

[PATCH V5 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function

From: Paolo Bonzini This will be needed soon in order to retrieve the per-target struct. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 17 + 1 file changed, 9 insertions(+), 8

[PATCH V5 0/5] virtio-scsi multiqueue

into virtscsi_vq_done virtio-scsi: introduce multiqueue support Wanlong Gao (1): virtio-scsi: reset virtqueue affinity when doing cpu hotplug drivers/scsi/virtio_scsi.c | 359 - 1 file changed, 290 insertions(+), 69 deletions(-) -- 1.8.2.rc2

[PATCH V6 0/5] virtio-scsi multiqueue

Bonzini (3): virtio-scsi: pass struct virtio_scsi to virtqueue completion function virtio-scsi: push vq lock/unlock into virtscsi_vq_done virtio-scsi: introduce multiqueue support Wanlong Gao (2): virtio-scsi: redo allocation of target data virtio-scsi: reset virtqueue affinity when doing c

[PATCH V6 1/5] virtio-scsi: redo allocation of target data

y. Cc: James Bottomley Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 71 -- 1 file changed, 25 insertions(+), 46 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/driver

[PATCH V6 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done

From: Paolo Bonzini Avoid duplicated code in all of the callers. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff

[PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 29 + 1 file changed, 29 insertions

[PATCH V6 4/5] virtio-scsi: introduce multiqueue support

Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 282 - 1 file changed, 254 insertions(+), 28 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index dc2daec..13d7672 10064

[PATCH V6 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function

From: Paolo Bonzini This will be needed soon in order to retrieve the per-target struct. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 17 + 1 file changed, 9 insertions(+), 8

Re: [PATCH V5 4/5] virtio-scsi: introduce multiqueue support

> + /* Does the affinity hint is set for virtqueues? */ > Could you rephrase that, please? Thank you, fixed in V6, please review. > > Tested on qemu and w/ Google Compute Engine's virtio-scsi device. Cool. > > Reviewed-and-tested-by: Venkatesh Srinivas Do you mind review an

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

On 03/20/2013 03:24 PM, Asias He wrote: > On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote: >> Add hot cpu notifier to reset the request virtqueue affinity >> when doing cpu hotplug. >> >> Cc: linux-s...@vger.kernel.org >> Signed-off-by: Paolo Bonzi

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

On 03/20/2013 03:24 PM, Asias He wrote: > On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote: >> Add hot cpu notifier to reset the request virtqueue affinity >> when doing cpu hotplug. >> >> Cc: linux-s...@vger.kernel.org >> Signed-off-by: Paolo Bonzi

Re: [BUG REPORT] Kernel panic on 3.9.0-rc7-4-gbb33db7

On 04/18/2013 09:35 PM, Jens Axboe wrote: > On Thu, Apr 18 2013, Wanlong Gao wrote: >>> A bio is always fully initialized, regardless of which internal >>> allocator it came from. If people are doing private kmallocs, then they >>> better be using bio_init() a

Re: [BUG REPORT] Kernel panic on 3.9.0-rc7-4-gbb33db7

On 04/18/2013 10:30 PM, Jens Axboe wrote: > On Thu, Apr 18 2013, Wanlong Gao wrote: >> On 04/18/2013 09:35 PM, Jens Axboe wrote: >>> On Thu, Apr 18 2013, Wanlong Gao wrote: >>>>> A bio is always fully initialized, regardless of which internal >>>>

Re: [BUG REPORT] Kernel panic on 3.9.0-rc7-4-gbb33db7

On 04/18/2013 10:30 PM, Jens Axboe wrote: > On Thu, Apr 18 2013, Wanlong Gao wrote: >> On 04/18/2013 09:35 PM, Jens Axboe wrote: >>> On Thu, Apr 18 2013, Wanlong Gao wrote: >>>>> A bio is always fully initialized, regardless of which internal >>>>

Re: [BUG REPORT] Kernel panic on 3.9.0-rc7-4-gbb33db7

new TP. Thank you for investigating this. And sorry for my incompleted panic picture before that let you detour. :-( Regards, Wanlong Gao > > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

[PATCH V7 0/5] virtio-scsi multiqueue

can we get your Acked-by? Paolo Bonzini (3): virtio-scsi: pass struct virtio_scsi to virtqueue completion function virtio-scsi: push vq lock/unlock into virtscsi_vq_done virtio-scsi: introduce multiqueue support Wanlong Gao (2): virtio-scsi: redo allocation of target data virtio-scsi: reset

[PATCH V7 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done

From: Paolo Bonzini Avoid duplicated code in all of the callers. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff

[PATCH V7 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function

From: Paolo Bonzini This will be needed soon in order to retrieve the per-target struct. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 17 + 1 file changed, 9 insertions(+), 8

[PATCH V7 4/5] virtio-scsi: introduce multiqueue support

Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He Tested-by: Venkatesh Srinivas --- drivers/scsi/virtio_scsi.c | 282 - 1 file changed, 254 insertions(+), 28 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c in

[PATCH V7 1/5] virtio-scsi: redo allocation of target data

y. Cc: James Bottomley Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 71 -- 1 file changed, 25 insertions(+), 46 deletions(-) diff --git a/driver

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

On 03/23/2013 02:36 PM, Paolo Bonzini wrote: > Il 20/03/2013 08:56, Wanlong Gao ha scritto: >>> This one does not apply on top of virtio-next + patch 1-4 in this series. >> >> I'm very sorry. >> >> This fault is because I modified the 4/5 from >> &quo

[PATCH V7 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao Reviewed-by: Asias He --- drivers/scsi/virtio_scsi.c | 29 + 1 file changed, 29 insertions

Re: [PATCH net 1/2] virtio-net: don't respond to cpu hotplug notifier if we're not ready

Rusty Russell > Cc: Michael S. Tsirkin > Cc: Wanlong Gao > Signed-off-by: Jason Wang Thank you. Reviewed-by: Wanlong Gao > --- > The patch is need for 3.8 and above. > --- > drivers/net/virtio_net.c | 8 > 1 file changed, 8 insertions(+) > > diff --git

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

net eth0: Failed to disable allmulti mode. [7.552504] net eth0: Failed to set MAC fitler table. [7.553423] net eth0: Failed to disable promisc mode. [7.554308] net eth0: Failed to disable allmulti mode. [7.555201] net eth0: Failed to set MAC fitler table. [9.571103] net eth0: Faile

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

On 02/21/2013 05:41 PM, Jason Wang wrote: > On 02/21/2013 04:30 PM, Wanlong Gao wrote: >> On 02/19/2013 03:56 PM, Rusty Russell wrote: >>> It's a bit cleaner to hand multiple sgs, rather than one big one. >>> >>> Signed-off-by: Rusty Russell >>

[PATCH V4 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

Add hot cpu notifier to reset the request virtqueue affinity when doing cpu hotplug. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers

[PATCH V4 3/5] virtio-scsi: push vq lock/unlock into virtscsi_vq_done

From: Paolo Bonzini Avoid duplicated code in all of the callers. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/scsi

[PATCH V4 4/5] virtio-scsi: introduce multiqueue support

Bonzini Signed-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 269 - 1 file changed, 241 insertions(+), 28 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 3573704..7a54293 100644 --- a/drivers/scsi/virtio_

[PATCH V4 1/5] virtio-scsi: redo allocation of target data

structs in the flexible array member at the end of struct virtio_scsi, because we will place the virtqueues there in the next patches. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 45

[PATCH V4 2/5] virtio-scsi: pass struct virtio_scsi to virtqueue completion function

From: Paolo Bonzini This will be needed soon in order to retrieve the per-target struct. Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH V4 0/5] virtio-scsi multiqueue

-scsi: redo allocation of target data virtio-scsi: pass struct virtio_scsi to virtqueue completion function virtio-scsi: push vq lock/unlock into virtscsi_vq_done virtio-scsi: introduce multiqueue support Wanlong Gao (1): virtio-scsi: reset virtqueue affinity when doing cpu hotplug

Re: [PATCH v3 0/5] virtio-scsi multiqueue

y? I can't apply this series on top of Rusty's virtio-next, I missed something or needed rebase them ? Thanks, Wanlong Gao > > Paolo > > Paolo Bonzini (4): > virtio-scsi: redo allocation of target data > virtio-scsi: pass struct virtio_scsi to virtqueue completion

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > virtio_scsi can really use this, to avoid the current hack of copying > the whole sg array. Some other things get slightly neater, too. > > Signed-off-by: Rusty Russell I like this simple implementation. Reviewed-by:

[PATCH 17/16] virtio-scsi: use virtqueue_add_sgs for command buffers

Using the new virtqueue_add_sgs function lets us simplify the queueing path. In particular, all data protected by the tgt_lock is just gone (multiqueue will find a new use for the lock). Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao --- drivers/scsi/virtio_scsi.c | 93

Re: [PATCH 17/16] virtio-scsi: use virtqueue_add_sgs for command buffers

On 02/20/2013 05:38 PM, Asias He wrote: > On 02/20/2013 04:37 PM, Wanlong Gao wrote: >> Using the new virtqueue_add_sgs function lets us simplify the queueing >> path. In particular, all data protected by the tgt_lock is just gone >> (multiqueue will find a new use for the lo

[PATCH 17/16 V2] virtio-scsi: use virtqueue_add_sgs for command buffers

Using the new virtqueue_add_sgs function lets us simplify the queueing path. In particular, all data protected by the tgt_lock is just gone (multiqueue will find a new use for the lock). Signed-off-by: Paolo Bonzini Signed-off-by: Wanlong Gao --- V1->V2: add the lost comments (As

Re: [PATCH 07/16] virtio_ring: don't count elements twice for add_buf path.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > Extract the post-counting code into virtqueue_add(), make both callers > use it. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/virtio/virtio_ring.c | 147 > +++

Re: [PATCH 08/16] virtio_ring: virtqueue_add_outbuf / virtqueue_add_inbuf.

; FIXME: I'm not sure about the unclean sglist bit. I had a more > ambitious one which conditionally ignored end markers in the iterator, > but it was ugly and I suspect this is just as fast. Maybe we should > just fix all the drivers? > > Signed-off-by: Rusty Russell Reviewe

Re: [PATCH 09/16] virtio_net: use simplified virtqueue accessors.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/net/virtio_net.c | 11 +-- > 1 file changed, 5 insertio

Re: [PATCH 11/16] virtio_rng: use simplified virtqueue accessors.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/char/hw_random/virtio-rng.c |2 +- > 1 file changed, 1 insert

Re: [PATCH 14/16] virtio_rpmsg_bus: use simplified virtqueue accessors.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/rpmsg/virtio_rpmsg_bus.c |8 > 1 file changed, 4 insertio

Re: [PATCH 15/16] virtio_balloon: use simplified virtqueue accessors.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/virtio/virtio_balloon.c |6 +++--- > 1 file changed, 3 insertio

Re: [PATCH 13/16] caif_virtio: use simplified virtqueue accessors.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/net/caif/caif_virtio.c |3 +-- > 1 file changed, 1 insertion(+), 2 dele

Re: [PATCH 12/16] virtio_console: use simplified virtqueue accessors.

On 02/19/2013 03:56 PM, Rusty Russell wrote: > We never add buffers with input and output parts, so use the new accessors. > > Signed-off-by: Rusty Russell Reviewed-by: Wanlong Gao > --- > drivers/char/virtio_console.c |6 +++--- > 1 file changed, 3 insertio

Re: [PATCH 10/16] virtio_net: use virtqueue_add_sgs[] for command buffers.

d return status */ > + BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ)); > > - ctrl.class = class; > - ctrl.cmd = cmd; The class and cmd assignment of ctrl header is forgotten? Thanks, Wanlong Gao > + /* Add header */ > + sg_init_one(, , sizeof(ct

Re: [net-next/master PATCH] lib: fix compile warning in hashlib_init

On 12/19/2013 09:32 AM, Daniel Borkmann wrote: > On 12/19/2013 02:15 AM, Fengguang Wu wrote: >> CC the list. >> >> On Thu, Dec 19, 2013 at 09:08:34AM +0800, Wanlong Gao wrote: >>> /git/linux/lib/hash.c: In function 'hashlib_init': >>> /git/linux/lib/h

[BUG] LTP test case readahead01 fails after commit 63d0f0a3c7

force_page_cache_readahead(): if (unlikely(!mapping->a_ops->readpage && !mapping->a_ops->readpages)) return -EINVAL; ========= I think you must know which is right? Thanks, Wanlong Gao [1]: commit 63d0f0a3c7e1281fd79268a8d988167e

Re: [PATCH V7 0/5] virtio-scsi multiqueue

On 03/23/2013 07:28 PM, Wanlong Gao wrote: > This series implements virtio-scsi queue steering, which gives > performance improvements of up to 50% (measured both with QEMU and > tcm_vhost backends). > > This version rebased on Rusty's virtio ring rework patches, which >

mqueue perf data

Hi Fengguang, Do we need to stat out the perf data of mqueue test in kernel_selftests? It's like following. Thanks, Wanlong Gao # make run_tests -C mqueue make: Entering directory `/git/linux/tools/testing/selftests/mqueue' Initial system state: Using queue path

Race condition in vfio will cause deadwait

From: Wen Congyang Hi, Alex Williamson When using vfio, we encounter a problem: too many lspci processes are blocked in D state. I analyzed all processes, and found one process is blocked in pci_dev_lock(), another process is blocked in vfio_del_group_put(). I checked the backtrace, and found

[PATCH v2] modpost: abort if module name is too long

. Signed-off-by: Wanlong Gao --- scripts/mod/modpost.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 30d752a..cb16985 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -47,6 +47,12

Re: [PATCH] modpost: abort if a module name is too long

Jessica, On 2017/5/31 11:48, Wanlong Gao wrote: > > > On 2017/5/31 11:30, Jessica Yu wrote: >> +++ Wanlong Gao [31/05/17 10:23 +0800]: >>> Hi Jessica, >>> >>> On 2017/5/29 17:10, Jessica Yu wrote: >>>> +++ Xie XiuQi [20/05/17 15:46 +0800]

Re: [PATCH] modpost: abort if a module name is too long

On 2017/6/2 7:23, Jessica Yu wrote: > +++ Wanlong Gao [31/05/17 11:48 +0800]: >> >> >> On 2017/5/31 11:30, Jessica Yu wrote: >>> +++ Wanlong Gao [31/05/17 10:23 +0800]: >>>> Hi Jessica, >>>> >>>> On 2017/5/29 17:10, Jessica

Re: [PATCH] modpost: abort if a module name is too long

On 2017/6/2 11:04, Wanlong Gao wrote: > > > On 2017/6/2 7:23, Jessica Yu wrote: >> +++ Wanlong Gao [31/05/17 11:48 +0800]: >>> >>> >>> On 2017/5/31 11:30, Jessica Yu wrote: >>>> +++ Wanlong Gao [31/05/17 10:23 +0800]: >>>

Re: [PATCH 4/5] video:omap3isp:fix up ENOIOCTLCMD error handling

On 09/13/2012 12:03 PM, Laurent Pinchart wrote: > Hi Wanlong, > > Thanks for the patch. > > On Monday 27 August 2012 15:23:15 Wanlong Gao wrote: >> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be >> translated as ENOTTY to user mode. >> >

<    1   2   3   >