Re: [PATCH v9 11/22] IB/hns: Add IB device registration

On 2016/6/9 14:26, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: This patch registered IB device when loaded, and unregistered IB device when removed. Signed-off-by: Wei Hu Signed-off-by: Nenglong Zhao

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On 2016/6/20 21:33, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote: This patch added the operation for cmd, and added some functions for initializing eq table and selecting cmd mode. Signed-off-by: Wei Hu Signed-off-by: Nenglong Zhao

Re: [PATCH v10 08/22] IB/hns: Add icm support

On 2016/6/21 19:55, Leon Romanovsky wrote: On Tue, Jun 21, 2016 at 12:37:39PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 21:04, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 17:27, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 03:49

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On 2016/6/22 12:54, Leon Romanovsky wrote: On Tue, Jun 21, 2016 at 09:01:57PM +0800, Wei Hu (Xavier) wrote: On 2016/6/21 19:28, Leon Romanovsky wrote: On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 21:33, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35

Re: [PATCH v9 03/22] IB/hns: Add initial main frame driver and get cfg info

On 2016/6/9 14:39, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:45PM +0800, Lijun Ou wrote: This patch mainly added the initial bare main driver. It could get the relative configure information of net node. Signed-off-by: Wei Hu Signed-off-by: Nenglong Zhao

Re: [PATCH v9 09/22] IB/hns: Add hca support

On 2016/6/9 15:10, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:51PM +0800, Lijun Ou wrote: This patch mainly setup hca for RoCE. It will do a series of initial works, as follows: 1. init uar table, allocate uar resource 2. init pd table 3. init cq table 4. init mr

Re: [PATCH v9 11/22] IB/hns: Add IB device registration

On 2016/6/13 20:46, Leon Romanovsky wrote: On Sun, Jun 12, 2016 at 05:41:06PM +0800, Wei Hu (Xavier) wrote: On 2016/6/9 14:26, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: This patch registered IB device when loaded, and unregistered IB device when

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On 2016/6/21 19:28, Leon Romanovsky wrote: On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 21:33, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote: This patch added the operation for cmd, and added some functions for initializing

Re: [PATCH v10 08/22] IB/hns: Add icm support

On 2016/6/20 14:06, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: On 2016/6/17 17:58, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: This patch mainly added icm support for RoCE. It initializes icm which managers

Re: [PATCH v10 08/22] IB/hns: Add icm support

On 2016/6/20 17:27, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 14:06, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: On 2016/6/17 17:58, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35

Re: [PATCH v10 08/22] IB/hns: Add icm support

On 2016/6/20 21:04, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 17:27, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 14:06, Leon Romanovsky wrote: On Mon, Jun 20, 2016 at 12:37

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On 2016/6/27 16:31, oulijun wrote: Hi, Leon 在 2016/6/27 16:01, Leon Romanovsky 写道: On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: On 2016/6/24 22:59, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: This patch mainly added reset flow

[PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig)

This submit add Kconfig. Signed-off-by: Wei Hu(Xavier) <xavier.hu...@huawei.com> Signed-off-by: oulijun <ouli...@huawei.com> --- drivers/infiniband/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig i

[PATCH 0/4] infiniband: hns: Hisilicon RoCE support

supported. Wei Hu(Xavier) (4): net: hns: add Hisilicon RoCE support(the dependent routine) infiniband: hns: add Hisilicon RoCE support(binding) infiniband: hns: add Hisilicon RoCE support(driver code) infiniband: hns: add Hisilicon RoCE support(Kconfig) .../bindings/infiniband/hisilicon-hn

[PATCH 2/4] infiniband: hns: add Hisilicon RoCE support(binding)

This submit add binding file and dts file. Signed-off-by: Wei Hu(Xavier) <xavier.hu...@huawei.com> Signed-off-by: oulijun <ouli...@huawei.com> --- .../bindings/infiniband/hisilicon-hns-roce.txt | 68 ++ 1 file changed, 68 insertions(+) create mode 100644 D

[PATCH 1/4] net: hns: add Hisilicon RoCE support(the dependent routine)

It added hns_dsaf_roce_reset routine for roce driver. RoCE is a feature of hns. In hip06 SOC, in roce reset process, it's needed to configure dsaf channel reset,port and sl map info. Signed-off-by: Wei Hu(Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lisheng <lisheng...@huawei.com>

Re: [RESEND PATCH v7 00/21] Add HiSilicon RoCE driver

Hi, Doug Ledford We will modify the license description of the beginning of the code file in patch v8. Thanks Regards Wei Hu On 2016/5/14 5:09, Doug Ledford wrote: On 05/09/2016 11:04 PM, Lijun Ou wrote: The HiSilicon Network Substem is a long term evolution IP which is supposed to be

Re: [RESEND PATCH v7 17/21] IB/hns: Add QP operations support

Hi, Doug Ledford In hns_roce_cmd_wait and hns_roce_cmd_poll, there are down seminal operations, So, there are not deadlock and conflict, right? static int hns_roce_cmd_poll(struct hns_roce_dev *hr_dev, u64 in_param, u64 *out_param, unsigned long in_modifier,

Re: [PATCH v5 09/21] IB/hns: Add hca support

On 2016/5/3 16:14, Or Gerlitz wrote: On Tue, May 3, 2016 at 10:57 AM, Wei Hu (Xavier) <xavier.hu...@huawei.com> wrote: On 2016/4/30 12:33, Or Gerlitz wrote: Can you elaborate what design aspects in the driver or anywhere else should impose that limitation? 1. Oulijun resolved the p

Re: [PATCH v5 09/21] IB/hns: Add hca support

On 2016/4/30 12:33, Or Gerlitz wrote: On Wed, Apr 27, 2016 at 6:34 AM, oulijun wrote: On 2016/4/26 22:25, Jiri Pirko wrote: Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: I appreciate your keen eye. this code is meant for ARM64bit therefore should

Re: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info

On 2016/6/27 15:00, Leon Romanovsky wrote: On Sat, Jun 25, 2016 at 06:29:31PM +0800, Wei Hu (Xavier) wrote: On 2016/6/24 19:48, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at 10:35:11PM +0800, Lijun Ou wrote: This patch mainly added the initial bare main driver. It could get the relative

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On 2016/7/8 10:58, oulijun wrote: 在 2016/7/2 17:39, Lijun Ou 写道: The HiSilicon Network Substem is a long term evolution IP which is supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network Sybsystem) also has a hardware support of performing RDMA with RoCEE. The driver for HiSilicon

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On 2016/7/2 20:58, Leon Romanovsky wrote: On Sat, Jul 02, 2016 at 05:39:02PM +0800, Lijun Ou wrote: This v11 28 files changed, 10626 insertions(+), 1 deletion(-) First version 27 files changed, 11670 insertions(+), 11 deletions(-) 1K LOC less, we are moving in right direction. Thanks

[PATCH for-next] RDMA/hns: Delete the unnecessary initializing enum to zero

It deletes the unnecessary initializing enum to zero. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> --- This patch is based on the patchset as below: [PATCH for-next 00/20] R

[PATCH RESEND for-next] RDMA/hns: Delete the unnecessary initializing enum to zero

It deletes the unnecessary initializing enum to zero. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- This patch

Re: [PATCH for-next 3/4] RDMA/hns: Update the IRRL table chunk size in hip08

On 2017/10/1 13:40, Leon Romanovsky wrote: On Sat, Sep 30, 2017 at 05:29:00PM +0800, Wei Hu (Xavier) wrote: As the increase of the IRRL specification in hip08, the IRRL table chunk size needs to be updated. This patch updates the IRRL table chunk size to 256k for hip08. Signed-off-by: Wei Hu

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/10/1 0:10, Leon Romanovsky wrote: On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: If the IOMMU is enabled, the length of sg obtained from __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg dma address, the IOVA will not be page continuous. and the VA

Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver

On 2017/9/27 0:18, Doug Ledford wrote: On 9/26/2017 9:13 AM, Wei Hu (Xavier) wrote: On 2017/9/26 1:36, Doug Ledford wrote: On Mon, 2017-09-25 at 20:18 +0300, Leon Romanovsky wrote: On Mon, Sep 25, 2017 at 01:06:53PM -0400, Doug Ledford wrote: On Wed, 2017-08-30 at 17:23 +0800, Wei Hu

Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

On 2017/9/28 21:04, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 07:56:40PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 17:02, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou <ouli...@huawei.com> This patch mainly deletes some

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On 2017/9/28 20:59, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 17:13, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou <ouli...@huawei.com> When lp_qp_work is NULL, it

Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value

Thanks, Colin Ian King Acked-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> On 2017/9/30 4:13, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized value in ret is being returned by function hns_r

[PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

is a discontinuous VA. Under these circumstances, the IOVA should be calculated based on the sg length, and record the VA returned from dma_alloc_coherent in the struct of hem. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Li

[PATCH for-next 0/4] Add Features & Code improvements for hip08

This patch-set introduce PBL page size configuration support,IOMMU support, updating PD specification and IRRL table chunk size for hip08. Shaobo Xu (1): RDMA/hns: Support WQE/CQE/PBL page size configurable feature in hip08 Wei Hu (Xavier) (3): RDMA/hns: Add IOMMU enable support in hip08

[PATCH for-next 1/4] RDMA/hns: Support WQE/CQE/PBL page size configurable feature in hip08

From: Shaobo Xu <xushao...@huawei.com> This patch updates to support WQE, CQE and PBL page size configurable feature, which includes base address page size and buffer page size. Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.

[PATCH for-next 3/4] RDMA/hns: Update the IRRL table chunk size in hip08

As the increase of the IRRL specification in hip08, the IRRL table chunk size needs to be updated. This patch updates the IRRL table chunk size to 256k for hip08. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Li

[PATCH for-next 4/4] RDMA/hns: Update the PD specification in hip08

hao...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.h b/dri

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On 2017/9/29 18:23, Leon Romanovsky wrote: On Fri, Sep 29, 2017 at 02:07:22PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 20:59, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 17:13, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57

[PATCH V2 for-next 3/8] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

/hns_roce_hw_v1.c:918 hns_roce_v1_recreate_lp_qp() error: potential null dereference 'lp_qp_work'. (kzalloc returns null) Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> --- Patch V2: Addres

[PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver

s: Set mask for destination qp field of qp context assignment RDMA/hns: Set rdma_ah_attr type for querying qp RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function RDMA/hns: Replace usleep_range with udelay when checking command status Wei Hu (Xavier) (2): RD

[PATCH V2 for-next 2/8] RDMA/hns: Factor out the code for checking sdb status into a new function

niband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status() warn: inconsistent indenting. Fixes: 5f110ac4bed8 ("IB/hns: Fix for checkpatch.pl comment style) Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-of

[PATCH V2 for-next 6/8] RDMA/hns: Add return statement when checking error in hns_roce_v1_mr_free_work_fn

infiniband/hw/hns/hns_roce_hw_v1.c:1009 hns_roce_v1_mr_free_work_fn() error: we previously assumed 'hr_qp' could be null Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com>

[PATCH V2 for-next 4/8] RDMA/hns: Set mask for destination qp field of qp context assignment

From: Lijun Ou <ouli...@huawei.com> When only set IB_QP_DEST_QPN flag for attr_mask, the operation of assigning the dest_qp_num for dest_qp field of qp context is valid. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed

[PATCH V2 for-next 7/8] RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function

From: Lijun Ou <ouli...@huawei.com> When the driver doesn't call register_inetaddr_notifier function, it need not call unregister_inetaddr_notifier to unregister inet addr. This patch fixes it. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.h

[PATCH V2 for-next 5/8] RDMA/hns: Set rdma_ah_attr type for querying qp

From: Lijun Ou <ouli...@huawei.com> When querying qp, It needs to return RoCE device ah_attr type that may be specific to RoCE devices. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <

[PATCH V2 for-next 1/8] RDMA/hns: Modify the value with rd_rd of qp_attr

From: Lijun Ou <ouli...@huawei.com> The value of max_rd_atomic and max_dest_rd_atomic in query_qp are incorrect. It should be assigned by left shifting of the bit in hip06 SoC. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.co

[PATCH V2 for-next 8/8] RDMA/hns: Replace usleep_range with udelay when checking command status

s-roce-hw-v2] Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function

On 2017/9/28 21:50, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou <ouli...@huawei.com> It mainly places the lines for checking send doorbell status into a special functions. As a result, we can directl

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On 2017/9/28 17:13, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou <ouli...@huawei.com> When lp_qp_work is NULL, it should be returned ENOMEM. This patch mainly fixes it. Ihis patch fixes the smatch error as below: drivers/infi

Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

On 2017/9/28 17:02, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou <ouli...@huawei.com> This patch mainly deletes some unused struct members for hns_roce_ib_create_qp in order to match libhns, because the num of struct m

[PATCH for-next 4/9] RDMA/hns: Set mask for destination qp field of qp context assignment

From: Lijun Ou <ouli...@huawei.com> When only set IB_QP_DEST_QPN flag for attr_mask, the operation of assigning the dest_qp_num for dest_qp field of qp context is valid. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed

[PATCH for-next 6/9] RDMA/hns: Add return statement when checking error in hns_roce_v1_mr_free_work_fn

infiniband/hw/hns/hns_roce_hw_v1.c:1009 hns_roce_v1_mr_free_work_fn() error: we previously assumed 'hr_qp' could be null Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com>

[PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

uawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> --- include/uapi/rdma/hns-abi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/uapi/rdma/hns-abi.h b/include/uapi/rdma/hns-abi.h index 5d74019..79251b6 1

[PATCH for-next 5/9] RDMA/hns: Set rdma_ah_attr type for querying qp

From: Lijun Ou <ouli...@huawei.com> When querying qp, It needs to return RoCE device ah_attr type that may be specific to RoCE devices. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <

[PATCH for-next 9/9] RDMA/hns: Replace usleep_range with udelay when checking command status

s-roce-hw-v2] Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH for-next 0/9] Bug fixes & Code improvements in hip06 and hip08 RoCE driver

alling unregister_inetaddr_notifier function RDMA/hns: Remove unused struct members in hns-abi.h RDMA/hns: Replace usleep_range with udelay when checking command status Wei Hu (Xavier) (1): RDMA/hns: Add return statement when checking error in hns_roce_v1_mr_free_work_fn d

[PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function

eckpatch.pl comment style) The warning from static checker: drivers/infiniband/hw/hns/hns_roce_hw_v1.c:3562 check_qp_db_process_status() warn: inconsistent indenting Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo X

[PATCH for-next 1/9] RDMA/hns: Modify the value with rd_rd of qp_attr

From: Lijun Ou <ouli...@huawei.com> The value of max_rd_atomic and max_dest_rd_atomic in query_qp are incorrect. It should be assigned by left shifting of the bit in hip06 SoC. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.co

[PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

zalloc returns null) Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/d

[PATCH for-next 7/9] RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier function

From: Lijun Ou <ouli...@huawei.com> When the driver doesn't call register_inetaddr_notifier function, it need not call unregister_inetaddr_notifier to unregister inet addr. This patch fixes it. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.h

Re: [PATCH for-next 05/20] RDMA/hns: Add command queue support for hip08 RoCE driver

On 2017/9/27 20:41, Doug Ledford wrote: On Wed, 2017-09-27 at 08:21 -0400, Doug Ledford wrote: And if you argee, after this patchset has been accepted we will send a following up patch : In hns_roce_cmq_send function, replace usleep_range(1000, 2000); with the following

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/10/1 0:10, Leon Romanovsky wrote: On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: If the IOMMU is enabled, the length of sg obtained from __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg dma address, the IOVA will not be page continuous. and the VA

[PATCH V2 1/3] RDMA/hns: Support WQE/CQE/PBL page size configurable feature in hip08

This patch updates to support WQE, CQE and PBL page size configurable feature, which includes base address page size and buffer page size. Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lijun Ou <oul

[PATCH V2 0/3] RDMA/hns: Add Features & Code improvements for hip08

This patch-set introduce PBL page size configuration support, updating PD specification and IRRL table chunk size for hip08. Wei Hu (Xavier) (3): RDMA/hns: Support WQE/CQE/PBL page size configurable feature in hip08 RDMA/hns: Update the IRRL table chunk size in hip08 RDMA/hns: Update the PD

[PATCH V2 3/3] RDMA/hns: Update the PD specification in hip08

hao...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.h b/dri

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/10/18 16:42, Wei Hu (Xavier) wrote: On 2017/10/1 0:10, Leon Romanovsky wrote: On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: If the IOMMU is enabled, the length of sg obtained from __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg dma address

[PATCH V2 2/3] RDMA/hns: Update the IRRL table chunk size in hip08

As the increase of the IRRL specification in hip08, the IRRL table chunk size needs to be updated. This patch updates the IRRL table chunk size to 256k for hip08. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Li

[PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

This patch-set introduces three patches to fix about the memory related issues. Wei Hu (Xavier) (3): RDMA/hns: Fix the issue of IOVA not page continuous in hip08 RDMA/hns: Get rid of virt_to_page and vmap calls after dma_alloc_coherent RDMA/hns: Get rid of page operation after

[PATCH 2/3] RDMA/hns: Get rid of virt_to_page and vmap calls after dma_alloc_coherent

. In current code, there are incorrect usage as below: dma_alloc_coherent + virt_to_page + vmap. This patch fixes it to get rid of virt_to_page and vmap calls. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Li

[PATCH 3/3] RDMA/hns: Get rid of page operation after dma_alloc_coherent

in the struct of hem. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Yixian Liu <liuyix...@huawei.com> Signed-off-by: Xiping Zhang (Francis) <zhangxipi.

[PATCH 1/3] RDMA/hns: Fix the issue of IOVA not page continuous in hip08

If the smmu is enabled, the length of sg obtained from __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg dma address, the IOVA will not be page continuous. In order to fix this issue, the IOVA should be calculated based on the sg length. Signed-off-by: Wei Hu (Xavier) <xavier

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On 2017/11/28 2:36, Jason Gunthorpe wrote: > On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote: >> This patch-set introduces three patches to fix about the memory >> related issues. > If these patches are for-rc can you revise the commit message to more >

[PATCH V2 rdma-rc 3/3] RDMA/hns: Get rid of page operation after dma_alloc_coherent

in the struct of hem in hns RoCE driver. Fixes: 9a44353("IB/hns: Add driver files for hns RoCE driver") Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Yixi

[PATCH V2 rdma-rc 2/3] RDMA/hns: Get rid of virt_to_page and vmap calls after dma_alloc_coherent

ot;IB/hns: Add driver files for hns RoCE driver") Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Yixian Liu <liuyix...@huawei.com> Signed-off-by:

[PATCH V2 rdma-rc 0/3] RDMA/hns: Bug fixes in hns RoCE driver

This patch-set introduces three patches to fix the memory related issues. one fixes DMA operation failure when smmu is enabled. the other two patches fixes incorrect usage of dma API that may cause coherency problems. Wei Hu (Xavier) (3): RDMA/hns: Fix the issue of IOVA not page continuous

[PATCH V2 rdma-rc 1/3] RDMA/hns: Fix the issue of IOVA not page continuous in hip08

, the IOVA should be calculated based on the sg length. Fixes: 3958cc5("RDMA/hns: Configure the MTPT in hip08") Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signe

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/10/12 20:59, Robin Murphy wrote: > On 12/10/17 13:31, Wei Hu (Xavier) wrote: >> >> On 2017/10/1 0:10, Leon Romanovsky wrote: >>> On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: >>>> If the IOMMU is enabled, the length of sg obt

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/11/1 20:26, Robin Murphy wrote: > On 01/11/17 07:46, Wei Hu (Xavier) wrote: >> >> On 2017/10/12 20:59, Robin Murphy wrote: >>> On 12/10/17 13:31, Wei Hu (Xavier) wrote: >>>> On 2017/10/1 0:10, Leon Romanovsky wrote: >>>>> On Sat, Sep

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/11/7 14:32, Leon Romanovsky wrote: > On Tue, Nov 07, 2017 at 10:45:29AM +0800, Wei Hu (Xavier) wrote: >> >> On 2017/11/1 20:26, Robin Murphy wrote: >>> On 01/11/17 07:46, Wei Hu (Xavier) wrote: >>>> On 2017/10/12 20:59, Robin Murphy wrote: >>&g

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/11/7 23:58, Christoph Hellwig wrote: > On Tue, Nov 07, 2017 at 08:48:38AM -0700, Jason Gunthorpe wrote: >> Can't you just use vmalloc and dma_map that? Other drivers follow that >> approach.. > You can't easily due to the flushing requirements. We used to do that > in XFS and it led to

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/11/7 23:48, Jason Gunthorpe wrote: > On Tue, Nov 07, 2017 at 10:45:29AM +0800, Wei Hu (Xavier) wrote: > >> We reconstruct the code as below: >> It replaces dma_alloc_coherent with __get_free_pages and >> dma_map_single functions. So, we can vma

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On 2017/11/1 20:26, Robin Murphy wrote: > On 01/11/17 07:46, Wei Hu (Xavier) wrote: >> >> On 2017/10/12 20:59, Robin Murphy wrote: >>> On 12/10/17 13:31, Wei Hu (Xavier) wrote: >>>> On 2017/10/1 0:10, Leon Romanovsky wrote: >>>>> On Sat, Sep

[PATCH 0/3] RDMA/hns: Add rereg mr & RoCEv2 support for hip08

This patch-set introduce rereg mr support, RoCEv2 support for hip08. Wei Hu (Xavier) (3): RDMA/hns: Add rereg mr support for hip08 RDMA/hns: Generate gid type of RoCEv2 RDMA/hns: Configure sgid type for hip08 RoCE drivers/infiniband/hw/hns/hns_roce_cmd.h| 3 + drivers/infiniband/hw

[PATCH 1/3] RDMA/hns: Add rereg mr support for hip08

This patch adds rereg mr support for hip08. Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Yixian Liu <liuyix...@huawei.com> --- drivers/infiniband/hw/hns

[PATCH 2/3] RDMA/hns: Generate gid type of RoCEv2

uli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaobo Xu <xushao...@huawei.com> Signed-off-by: Yixian Liu <liuyix...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_device.h | 1 + drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 ++- d

[PATCH 3/3] RDMA/hns: Configure sgid type for hip08 RoCE

The hardware vendors need to generate RoCEv1 or RoCEv2 packet according to the sgid type configured. Besides, update the gid table size for hip08 RoCE device. Signed-off-by: Lijun Ou <ouli...@huawei.com> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Signed-off-by: Shaob

Re: [PATCH rdma-next 4/5] RDMA/hns: Add reset process for RoCE in hip08

On 2018/5/17 23:14, Jason Gunthorpe wrote: > On Thu, May 17, 2018 at 04:02:52PM +0800, Wei Hu (Xavier) wrote: >> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c >> b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c >> index 86ef15f..e1c44a6 100644 >> +++

Re: [PATCH rdma-next 4/5] RDMA/hns: Add reset process for RoCE in hip08

On 2018/5/18 12:15, Jason Gunthorpe wrote: > On Fri, May 18, 2018 at 11:28:11AM +0800, Wei Hu (Xavier) wrote: >> >> On 2018/5/17 23:14, Jason Gunthorpe wrote: >>> On Thu, May 17, 2018 at 04:02:52PM +0800, Wei Hu (Xavier) wrote: >>>> diff --git a/drivers/infini

[PATCH rdma-next 4/5] RDMA/hns: Add reset process for RoCE in hip08

This patch added reset process for RoCE in hip08. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_cmd.c| 3 ++ drivers/infiniband/hw/hns/hns_roce_device.h | 2 + drivers/infiniband/hw/hns/hns_roce_hw_v2.c

[PATCH rdma-next 5/5] RDMA/hns: Fix the illegal memory operation when cross page

RDMA/hns: Get rid of virt_to_page and vmap calls after dma_alloc_coherent") Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 70 +- drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 1 + 2 files changed, 51

[PATCH rdma-next 0/5] Misc update for hns driver

This patchset included fixing bug, some optimization, reset process and implementation of the disassociate_ucontext API for hns driver. Wei Hu (Xavier) (5): RDMA/hns: Implement the disassociate_ucontext API RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust RDMA/hns: Increase

[PATCH rdma-next 1/5] RDMA/hns: Implement the disassociate_ucontext API

This patch Implements the IB core disassociate_ucontext API. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_main.c | 36 +++ 1 file changed, 36 insertions(+) diff --git a/drivers/infiniband/hw/hns/hns_roce_mai

[PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust

This patch modified uar allocation algorithm in hns_roce_uar_alloc function to avoid bitmap exhaust. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_device.h | 1 + drivers/infiniband/hw/hns/hns_roce_pd.c | 10 ++ 2 files chan

[PATCH rdma-next 3/5] RDMA/hns: Increase checking CMQ status timeout value

This patch increases checking CMQ status timeout value and uses the same value with NIC driver to avoid deficiency of time. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH rdma-next 1/5] RDMA/hns: Implement the disassociate_ucontext API

On 2018/5/17 23:00, Jason Gunthorpe wrote: > On Thu, May 17, 2018 at 04:02:49PM +0800, Wei Hu (Xavier) wrote: >> This patch Implements the IB core disassociate_ucontext API. >> >> Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> >> drivers/infin

[PATCH V2 rdma-next 0/4] Misc update for hns driver

3.Address the Jason's comment in reset relevant patch. Wei Hu (Xavier) (4): RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust RDMA/hns: Increase checking CMQ status timeout value RDMA/hns: Add reset process for RoCE in hip08 RDMA/hns: Fix the illegal memory operation when cross p

[PATCH V2 rdma-next 2/4] RDMA/hns: Increase checking CMQ status timeout value

This patch increases checking CMQ status timeout value and uses the same value with NIC driver to avoid deficiency of time. Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.h |

[PATCH V2 rdma-next 4/4] RDMA/hns: Fix the illegal memory operation when cross page

RDMA/hns: Get rid of virt_to_page and vmap calls after dma_alloc_coherent") Signed-off-by: Wei Hu (Xavier) <xavier.hu...@huawei.com> --- v1->v2: Modify the Fixes statement according to Leon's comment. --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 70 +-

Re: [PATCH rdma-next 2/5] RDMA/hns: Modify uar allocation algorithm to avoid bitmap exhaust

On 2018/5/23 15:00, Leon Romanovsky wrote: > On Wed, May 23, 2018 at 02:49:35PM +0800, Wei Hu (Xavier) wrote: >> >> On 2018/5/23 14:05, Leon Romanovsky wrote: >>> On Thu, May 17, 2018 at 04:02:50PM +0800, Wei Hu (Xavier) wrote: >>>> This pat

Re: [PATCH rdma-next 1/5] RDMA/hns: Implement the disassociate_ucontext API

On 2018/5/23 4:21, Jason Gunthorpe wrote: > On Sat, May 19, 2018 at 04:24:40PM +0800, Wei Hu (Xavier) wrote: >> >> On 2018/5/17 23:00, Jason Gunthorpe wrote: >>> On Thu, May 17, 2018 at 04:02:49PM +0800, Wei Hu (Xavier) wrote: >>>> This patch Implements t

Re: [PATCH rdma-next 4/5] RDMA/hns: Add reset process for RoCE in hip08

On 2018/5/23 11:47, Jason Gunthorpe wrote: > On Wed, May 23, 2018 at 10:54:54AM +0800, Wei Hu (Xavier) wrote: >> >> On 2018/5/23 4:26, Jason Gunthorpe wrote: >>> On Fri, May 18, 2018 at 03:23:00PM +0800, Wei Hu (Xavier) wrote: >>>> On 2018/5/18 12:15, Jason G

  1   2   3   >