[PATCH] mm/vmscan: fix error return in kswapd_run()

2013-04-02 Thread Xishi Qiu
Fix the error return value in kswapd_run(). The bug was introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34 mm/vmscan: fix error number for failed kthread. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/vmscan.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

report: IA64 boot failed when set mem=xxG in sparse memory

2013-03-25 Thread Xishi Qiu
. Boot failed and there is no print on the screen! If both set Memory model (sparse Memory) and Sparse Memory virtual memmap, then add mem=xxG to the command line, reboot is OK. I don't know whether it is a problem only in my system. Thanks, Xishi Qiu -- To unsubscribe from this list: send the line

[PATCH] ia64/mm: add size restriction to the kdump

2013-03-25 Thread Xishi Qiu
to a GRANULE boundary, but doesn't talk about restrictions on the size. This patch add size restriction to the documentation of kdump. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/kdump/kdump.txt |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Documentation

Re: [PATCH] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-04 Thread Xishi Qiu
On 2013/2/5 0:32, Matt Fleming wrote: On Tue, 2013-01-29 at 11:52 +0800, Xishi Qiu wrote: On ia64 platform, I set crashkernel=1024M-:600M, and dmesg shows 128M-728M memory is reserved for crash kernel. Then echo c /proc/sysrq-trigger to test kdump. When crash kernel booting, efi_init

[PATCH V2] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-06 Thread Xishi Qiu
On 2013/2/5 0:32, Matt Fleming wrote: On Tue, 2013-01-29 at 11:52 +0800, Xishi Qiu wrote: On ia64 platform, I set crashkernel=1024M-:600M, and dmesg shows 128M-728M memory is reserved for crash kernel. Then echo c /proc/sysrq-trigger to test kdump. When crash kernel booting, efi_init

[PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-06 Thread Xishi Qiu
one? : Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- arch/ia64/mm/init.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/ia64/mm/init.c b/arch/ia64/mm/init.c index 082e383..23f2ee3 100644 --- a/arch/ia64/mm/init.c +++ b/arch/ia64/mm/init.c @@ -213,6

Re: [PATCH v2] mm: clean up soft_offline_page()

2013-01-27 Thread Xishi Qiu
), num_poisoned_pages); - set_page_hwpoison_huge_page(hpage); - dequeue_hwpoisoned_huge_page(hpage); Hi Naoya, Does num_poisoned_pages be added when soft_offline_huge_page? I mean the in-use huge pages. Thanks, Xishi Qiu -out: return ret; } +static int __soft_offline_page

[PATCH] ia64/mm: fix a bad_page bug when crash kernel booting

2013-01-28 Thread Xishi Qiu
sp=e00021e8fe30 bsp=e00021e810e0 [a001a4c0] start_kernel_thread+0x20/0x40 sp=e00021e8fe30 bsp=e00021e810e0 ... Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- arch/ia64/include/asm/meminit.h |2 ++ arch/ia64

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-15 Thread Xishi Qiu
not* check the invalid pages when freeing initrd memory. There are some pages missed at the end of the seciton. ChangeLog V3: fixed vaddr mistake ChangeLog V2: add invalid pages check when freeing initrd memory Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- arch/ia64/mm/init.c

Re: [PATCH V3] ia64/mm: fix a bad_page bug when crash kernel booting

2013-02-19 Thread Xishi Qiu
that users Hi Tony, I think this is the real problem begins and it only appears when use Sparse-Memory. provide crashkernel parameters rounded to GRANULE boundaries? Seems like a good idea, should we modify \linux\Documentation\kernel-parameters.txt? Thanks, Xishi Qiu -Tony

[PATCH] MCE: fix an error of mce_bad_pages statistics

2012-12-06 Thread Xishi Qiu
page\n, __func__, pfn);. When page is allocated, the PageBuddy is removed in bad_page(), then get_any_page() returns -EIO with pr_info(%s: %#lx: unknown zero refcount page type %lx\n, so mce_bad_pages will not be added. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang

Re: [PATCH] MCE: fix an error of mce_bad_pages statistics

2012-12-06 Thread Xishi Qiu
On 2012/12/7 15:25, Borislav Petkov wrote: On Fri, Dec 07, 2012 at 10:53:41AM +0800, Xishi Qiu wrote: On x86 platform, if we use /sys/devices/system/memory/soft_offline_page to offline a free page twice, the value of mce_bad_pages will be added twice. So this is an error, since the page

[PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-07 Thread Xishi Qiu
/meminfo | grep HardwareCorrupted soft_offline_page() get_any_page() atomic_long_add(1, mce_bad_pages) Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com --- mm/memory-failure.c |7 +-- 1 files changed, 5 insertions(+), 2

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-09 Thread Xishi Qiu
On 2012/12/8 6:11, Andrew Morton wrote: On Fri, 7 Dec 2012 16:48:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On x86 platform, if we use /sys/devices/system/memory/soft_offline_page to offline a free page twice, the value of mce_bad_pages will be added twice. So this is an error

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-10 Thread Xishi Qiu
On 2012/12/10 16:33, Wanpeng Li wrote: On Fri, Dec 07, 2012 at 02:11:02PM -0800, Andrew Morton wrote: On Fri, 7 Dec 2012 16:48:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On x86 platform, if we use /sys/devices/system/memory/soft_offline_page to offline a free page twice, the value

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-10 Thread Xishi Qiu
On 2012/12/10 18:47, Simon Jeons wrote: On Mon, 2012-12-10 at 17:06 +0800, Xishi Qiu wrote: On 2012/12/10 16:33, Wanpeng Li wrote: On Fri, Dec 07, 2012 at 02:11:02PM -0800, Andrew Morton wrote: On Fri, 7 Dec 2012 16:48:45 +0800 Xishi Qiu qiuxi...@huawei.com wrote: On x86 platform, if we

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-10 Thread Xishi Qiu
On 2012/12/10 19:39, Wanpeng Li wrote: On Mon, Dec 10, 2012 at 07:16:50PM +0800, Xishi Qiu wrote: On 2012/12/10 18:47, Simon Jeons wrote: On Mon, 2012-12-10 at 17:06 +0800, Xishi Qiu wrote: On 2012/12/10 16:33, Wanpeng Li wrote: On Fri, Dec 07, 2012 at 02:11:02PM -0800, Andrew Morton wrote

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-10 Thread Xishi Qiu
will be dropped, it seems to be a waste of memory. Can we separate the poisoned page from the buddy block, then *only* drop the poisoned page? Thanks Xishi Qiu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-10 Thread Xishi Qiu
() prep_new_page() check_new_page() bad_page() If we alloc 2^10 pages and one of them is a poisoned page, then the whole 4M memory will be dropped. Thanks, Xishi Qiu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-10 Thread Xishi Qiu
() free_pages_check() bad_page() Is this right, Andi? Thanks Xishi Qiu -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH V2] MCE: fix an error of mce_bad_pages statistics

2012-12-10 Thread Xishi Qiu
() is used in online_pages() and offline_pages()? Thanks, Xishi Qiu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH V3 0/2] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
; atomic_long_add(1, mce_bad_pages); Changelog: V3: -add page lock when set HWPoison flag -adjust the function structure V2 and V1: -fix the error Xishi Qiu (2): move poisoned page check at the beginning of the function fix the function structure mm

[PATCH V3 1/2] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
1) move poisoned page check at the beginning of the function. 2) add page_lock to avoid unpoison clear the flag. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com --- mm/memory-failure.c | 43 ++- 1 files changed

[PATCH V3 2/2] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
1) adjust the function structure, there are too many return points randomly intermingled with some goto done return points. 2) use atomic_long_inc instead of atomic_long_add. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com --- mm/memory-failure.c

Re: [PATCH V3 1/2] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
On 2012/12/11 20:42, Wanpeng Li wrote: On Tue, Dec 11, 2012 at 08:18:27PM +0800, Xishi Qiu wrote: 1) move poisoned page check at the beginning of the function. 2) add page_lock to avoid unpoison clear the flag. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang

[PATCH V4 0/3] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
; atomic_long_add(1, mce_bad_pages); Changelog: V4: -use num_poisoned_pages instead of mce_bad_pages -remove page lock V3: -add page lock when set HWPoison flag -adjust the function structure V2 and V1: -fix the error Xishi Qiu (3): move

[PATCH V4 2/3] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
There are too many return points randomly intermingled with some goto done return points. So adjust the function structure, one for the success path, the other for the failure path. Use atomic_long_inc instead of atomic_long_add. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang

[PATCH V4 1/3] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
Move poisoned page check at the beginning of the function in order to fix the error. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com --- mm/memory-failure.c | 38 +- 1 files changed, 17 insertions(+), 21 deletions

[PATCH V4 3/3] MCE: fix an error of mce_bad_pages statistics

2012-12-11 Thread Xishi Qiu
Since MCE is an x86 concept, and this code is in mm/, it would be better to use the name num_poisoned_pages instead of mce_bad_pages. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com Signed-off-by: Borislav Petkov b...@alien8.de --- fs/proc/meminfo.c

Re: [PATCH] mm/hugetlb: create hugetlb cgroup file in hugetlb_init

2012-12-12 Thread Xishi Qiu
in start_kernel() parse_early_param() // - before mm_init() - kmem_cache_init() Is this right? Thanks Xishi Qiu Shouldn't this be rather placed in hugetlb_cgroup_create? Signed-off-by: Jianguo Wu wujian...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com --- include

Re: [PATCH V4 3/3] MCE: fix an error of mce_bad_pages statistics

2012-12-12 Thread Xishi Qiu
On 2012/12/12 18:25, Borislav Petkov wrote: On Wed, Dec 12, 2012 at 11:35:33AM +0800, Xishi Qiu wrote: Since MCE is an x86 concept, and this code is in mm/, it would be better to use the name num_poisoned_pages instead of mce_bad_pages. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed

[PATCH V4 2/3 RESEND] MCE: do code refactor of soft_offline_page

2012-12-13 Thread Xishi Qiu
There are too many return points randomly intermingled with some goto done return points. So adjust the function structure, one for the success path, the other for the failure path. Use atomic_long_inc instead of atomic_long_add. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang

[PATCH V4 0/3 RESEND] MCE: fix an error of mce_bad_pages statistics

2012-12-13 Thread Xishi Qiu
; atomic_long_add(1, mce_bad_pages); Changelog: V4: -use num_poisoned_pages instead of mce_bad_pages -remove page lock V3: -add page lock when set HWPoison flag -adjust the function structure V2 and V1: -fix the error Xishi Qiu (3

[PATCH V4 1/3 RESEND] MCE: fix an error of mce_bad_pages statistics

2012-12-13 Thread Xishi Qiu
Move poisoned page check at the beginning of the function in order to fix the error. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com Tested-by: Naoya Horiguchi n-horigu...@ah.jp.nec.com --- mm/memory-failure.c | 38

[PATCH V4 3/3 RESEND] MCE: use num_poisoned_pages instead of mce_bad_pages

2012-12-13 Thread Xishi Qiu
Since MCE is an x86 concept, and this code is in mm/, it would be better to use the name num_poisoned_pages instead of mce_bad_pages. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Signed-off-by: Jiang Liu jiang@huawei.com Suggested-by: Borislav Petkov b...@alien8.de Reviewed-by: Wanpeng Li liw

Re: [PATCH] mm: clean up soft_offline_page()

2012-12-13 Thread Xishi Qiu
= __soft_offline_page(page, flags); right? Thanks Xishi Qiu + } else { /* for free pages */ + if (PageHuge(page)) { + set_page_hwpoison_huge_page(hpage); + dequeue_hwpoisoned_huge_page(hpage); + atomic_long_add(1

[PATCH 0/2] cma: do some clean up

2013-08-05 Thread Xishi Qiu
1. use PFN_DOWN(r-size) instead of r-size PAGE_SHIFT. 2. adjust the function structure, one for the success path, the other for the failure path. Xishi Qiu (2): cma: use macro PFN_DOWN when converting size to pages cma: adjust goto branch in function cma_create_area() drivers/base/dma

[PATCH 2/2] cma: adjust goto branch in function cma_create_area()

2013-08-05 Thread Xishi Qiu
Adjust the function structure, one for the success path, the other for the failure path. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- drivers/base/dma-contiguous.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/base/dma-contiguous.c b/drivers

[PATCH 1/2] cma: use macro PFN_DOWN when converting size to pages

2013-08-05 Thread Xishi Qiu
Use PFN_DOWN(r-size) instead of r-size PAGE_SHIFT. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- drivers/base/dma-contiguous.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index 0ca5442..1bcfaed

Re: [PATCH 1/2] cma: use macro PFN_DOWN when converting size to pages

2013-08-05 Thread Xishi Qiu
On 2013/8/5 16:54, Greg Kroah-Hartman wrote: On Mon, Aug 05, 2013 at 04:31:00PM +0800, Xishi Qiu wrote: Use PFN_DOWN(r-size) instead of r-size PAGE_SHIFT. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- drivers/base/dma-contiguous.c |5 ++--- 1 files changed, 2 insertions(+), 3

[PATCH V2] cma: use macro PFN_DOWN when converting size to pages

2013-08-05 Thread Xishi Qiu
Use PFN_DOWN(r-size) instead of r-size PAGE_SHIFT. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- drivers/base/dma-contiguous.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index 0ca5442..b3d711d

[PATCH] kexec: remove unnecessary return

2013-08-06 Thread Xishi Qiu
Code can not run here forever, so remove the unnecessary return. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- kernel/kexec.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/kernel/kexec.c b/kernel/kexec.c index 59f7b55..c14e3ea 100644 --- a/kernel/kexec.c +++ b

[PATCH V2] kexec: remove unnecessary return

2013-08-06 Thread Xishi Qiu
Code can not run here forever, so remove the unnecessary return. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Suggested-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- kernel/kexec.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/kernel/kexec.c b/kernel/kexec.c

[PATCH 1/3] mm: use zone_end_pfn() instead of zone_start_pfn+spanned_pages

2013-08-07 Thread Xishi Qiu
Use zone_end_pfn() instead of zone-zone_start_pfn + zone-spanned_pages. Simplify the code, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- kernel/power/snapshot.c | 12 ++-- mm/memory_hotplug.c |4 ++-- 2 files changed, 8 insertions(+), 8 deletions

[PATCH 2/3] mm: use zone_is_empty() instead of if(zone-spanned_pages)

2013-08-07 Thread Xishi Qiu
Use zone_is_empty() instead of if (zone-spanned_pages). Simplify the code, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/memory_hotplug.c |6 +++--- mm/page_alloc.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/memory_hotplug.c b

[PATCH 3/3] mm: use zone_is_initialized() instead of if(zone-wait_table)

2013-08-07 Thread Xishi Qiu
Use zone_is_initialized() instead of if (zone-wait_table). Simplify the code, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/memory_hotplug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index

[PATCH] doc: documentation/hwspinlock.txt fix typo

2013-08-23 Thread Xishi Qiu
Fix a trivial typo in Documentation/hwspinlock.txt Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/hwspinlock.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/hwspinlock.txt b/Documentation/hwspinlock.txt index a903ee5..62f7d4e 100644

[PATCH] mm/hotplug: fix a trivial typo in Documentation/memory-hotplug.txt

2013-08-22 Thread Xishi Qiu
Fix a trivial typo in Documentation/memory-hotplug.txt Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/memory-hotplug.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/memory-hotplug.txt b/Documentation/memory-hotplug.txt index 8e5eacb

[PATCH] mm: skip the page buddy block instead of one page

2013-08-13 Thread Xishi Qiu
A large free page buddy block will continue many times, so if the page is free, skip the whole page buddy block instead of one page. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/compaction.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm

Re: [PATCH] mm: skip the page buddy block instead of one page

2013-08-14 Thread Xishi Qiu
On 2013/8/14 16:57, Mel Gorman wrote: On Wed, Aug 14, 2013 at 12:45:41PM +0800, Xishi Qiu wrote: A large free page buddy block will continue many times, so if the page is free, skip the whole page buddy block instead of one page. Signed-off-by: Xishi Qiu qiuxi...@huawei.com page_order

Re: [PATCH] mm: skip the page buddy block instead of one page

2013-08-14 Thread Xishi Qiu
On 2013/8/15 2:00, Mel Gorman wrote: Even if the page is still page buddy, there is no guarantee that it's the same page order as the first read. It could have be currently merging with adjacent buddies for example. There is also a really small race that a page was freed, allocated with some

Re: [PATCH] mm: skip the page buddy block instead of one page

2013-08-14 Thread Xishi Qiu
On 2013/8/15 10:44, Minchan Kim wrote: Hi Xishi, On Thu, Aug 15, 2013 at 10:32:50AM +0800, Xishi Qiu wrote: On 2013/8/15 2:00, Mel Gorman wrote: Even if the page is still page buddy, there is no guarantee that it's the same page order as the first read. It could have be currently merging

Re: [PATCH] mm: skip the page buddy block instead of one page

2013-08-15 Thread Xishi Qiu
this: if (PageBuddy(page)) { unsigned long order = page_order(page); order = min(order, pageblock_order); if (PageBuddy(page)) low_pfn += (1 order) - 1; continue; } Thanks, Xishi Qiu } #endif continue; } so worst case

Re: [PATCH] mm: skip the page buddy block instead of one page

2013-08-15 Thread Xishi Qiu
; } continue; } Thanks, Xishi Qiu so worst case is (pageblock_nr_pages - 1). but we don't need to add CONFIG_MEMORY_ISOLATION so my suggestion is following as. if (PageBuddy(page)) { unsigned long order = page_order(page); if (PageBuddy(page)) { low_pfn += (1 order

Re: [PATCH] mm: skip the page buddy block instead of one page

2013-08-15 Thread Xishi Qiu
On 2013/8/15 17:51, Wanpeng Li wrote: On Thu, Aug 15, 2013 at 03:45:11PM +0800, Xishi Qiu wrote: On 2013/8/15 12:24, Minchan Kim wrote: Please read full thread in detail. Mel suggested following as if (PageBuddy(page)) { int nr_pages = (1 page_order(page)) - 1

Re: [PATCH] mm: skip the page buddy block instead of one page

2013-08-15 Thread Xishi Qiu
On 2013/8/15 17:51, Wanpeng Li wrote: On Thu, Aug 15, 2013 at 03:45:11PM +0800, Xishi Qiu wrote: On 2013/8/15 12:24, Minchan Kim wrote: Please read full thread in detail. Mel suggested following as if (PageBuddy(page)) { int nr_pages = (1 page_order(page)) - 1

[PATCH] mm/hotplug: remove unnecessary BUG_ON in __offline_pages()

2013-07-30 Thread Xishi Qiu
(start_pfn = end_pfn) Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/memory_hotplug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index ca1dd3a..8e333f9 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1472,7 +1472,6 @@ static int

[PATCH] net: fix build warning in trans_rdma.c

2013-07-30 Thread Xishi Qiu
When building v3.11-rc3, I get the following warning: ... net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used ... As the function is not be used, so remove it. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- net/9p/trans_rdma.c | 11 --- 1 files changed, 0

[PATCH] fbdev: fix build warning in vga16fb.c

2013-07-30 Thread Xishi Qiu
When building v3.11-rc3, I get the following warning: ... drivers/video/vga16fb.c: In function ‘vga16fb_destroy’: drivers/video/vga16fb.c:1268: warning: unused variable ‘dev’ ... Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- drivers/video/vga16fb.c |1 - 1 files changed, 0 insertions

Re: [PATCH] mm/hotplug: remove unnecessary BUG_ON in __offline_pages()

2013-07-31 Thread Xishi Qiu
On 2013/8/1 0:55, Dave Hansen wrote: On 07/29/2013 11:49 PM, Xishi Qiu wrote: I think we can remove BUG_ON(start_pfn = end_pfn) in __offline_pages(), because in memory_block_action() nr_pages = PAGES_PER_SECTION * sections_per_block is always greater than 0. ... --- a/mm/memory_hotplug.c

[PATCH] mm/hotplug: fix a drain pcp bug when offline pages

2013-08-01 Thread Xishi Qiu
they are not in PageBuddy's MIGRATE_ISOLATE list. This will cause offline_pages failed. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/page_alloc.c | 10 ++ mm/page_isolation.c | 15 ++- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/mm/page_alloc.c

Re: [PATCH] mm/hotplug: fix a drain pcp bug when offline pages

2013-08-01 Thread Xishi Qiu
On 2013/8/2 2:59, Cody P Schafer wrote: On 08/01/2013 02:18 AM, Xishi Qiu wrote: __offline_pages() start_isolate_page_range() set_migratetype_isolate() set_pageblock_migratetype() - this pageblock will be marked as MIGRATE_ISOLATE move_freepages_block

[PATCH] doc: fix some typos

2013-09-13 Thread Xishi Qiu
Fix some typos in documentation. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/IRQ-domain.txt|2 +- Documentation/email-clients.txt |2 +- Documentation/io-mapping.txt|2 +- Documentation/kprobes.txt |2 +- 4 files changed, 4 insertions(+), 4

Re: [PATCH] doc: fix some typos

2013-09-15 Thread Xishi Qiu
On 2013/9/15 0:49, Randy Dunlap wrote: On 09/13/13 20:49, Xishi Qiu wrote: diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt index 0cfb00f..ca278d5 100644 --- a/Documentation/kprobes.txt +++ b/Documentation/kprobes.txt @@ -92,7 +92,7 @@ stack contents as the probed

[PATCH v2] doc: fix some typos

2013-09-15 Thread Xishi Qiu
Fix some typos in three documentations. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/IRQ-domain.txt|2 +- Documentation/email-clients.txt |2 +- Documentation/io-mapping.txt|2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation

[PATCH] doc: fix some typos in documentations

2013-09-17 Thread Xishi Qiu
Fix some typos in five documentations, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/md.txt |2 +- Documentation/rfkill.txt |2 +- Documentation/rt-mutex-design.txt |2 +- Documentation/static-keys.txt |4

kexec: fast boot error in my hardware

2013-09-18 Thread Xishi Qiu
The kernel is 3.4.24, and we changed it somewhere for the hardware. When using kexec to fast boot a new kernel, Call Trace happens. kernel_kexec() kernel_restart_prepare() blocking_notifier_call_chain() Storage:~ # kexec -e [ 272.954064]

Re: [PATCH] arch: metag: kernel: dma.c: check 'pud' whether is NULL in dma_alloc_init()

2013-11-14 Thread Xishi Qiu
); pud = pud_alloc(init_mm, pgd, CONSISTENT_START); + if (!pud) { + pr_err(%s: no pud tables\n, __func__); + ret = -ENOMEM; + break; + } It looks fine to me. Thanks, Xishi Qiu pmd

kmemcheck: OS boot failed because NMI handlers access the memory tracked by kmemcheck

2014-03-17 Thread Xishi Qiu
with SLAB_NOTRACK) instead of kmalloc() when the size is variable. Thanks, Xishi Qiu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH] kmemcheck: move hook into __alloc_pages_nodemask() for the page allocator

2014-03-17 Thread Xishi Qiu
() get_page_from_freelist() So move kmemcheck_pagealloc_alloc() into __alloc_pages_nodemask(), like this: __alloc_pages_nodemask() ... get_page_from_freelist() if (!page) __alloc_pages_slowpath() kmemcheck_pagealloc_alloc() ... Signed-off-by: Xishi Qiu qiuxi

Re: mm: OS boot failed when set command-line kmemcheck=1

2014-02-26 Thread Xishi Qiu
On 2014/2/20 6:24, David Rientjes wrote: On Wed, 19 Feb 2014, Xishi Qiu wrote: Here is a warning, I don't whether it is relative to my hardware. If set kmemcheck=1 nowatchdog, it can boot. code: ... pte = kmemcheck_pte_lookup(address); if (!pte) return false

[PATCH] numa: fix NULL pointer access and memory leak in unregister_one_node()

2014-03-06 Thread Xishi Qiu
] is still NULL. If doing socket hot remove again, NULL pointer access will be happen. unregister_one_node() unregister_node() Another, we should free the memory used by node_devices[nid] in unregister_one_node(). Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- drivers/base/node.c |4

Re: mm: OS boot failed when set command-line kmemcheck=1

2014-03-12 Thread Xishi Qiu
On 2014/2/26 18:14, Vegard Nossum wrote: On 26 February 2014 09:43, Peter Zijlstra pet...@infradead.org wrote: On Wed, Feb 19, 2014 at 02:24:41PM -0800, David Rientjes wrote: On Wed, 19 Feb 2014, Xishi Qiu wrote: Here is a warning, I don't whether it is relative to my hardware. If set

[PATCH V2] mm: add a new command-line kmemcheck value

2014-02-16 Thread Xishi Qiu
in boot. boottime: kmemcheck=0/1/2/3 (command-line) runtime: kmemcheck=0/1/2 (/proc/sys/kernel/kmemcheck) Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- arch/x86/mm/init.c| 11 ++ arch/x86/mm/kmemcheck/kmemcheck.c | 62 ++--- arch/x86/mm

Re: [PATCH V2] mm: add a new command-line kmemcheck value

2014-02-18 Thread Xishi Qiu
On 2014/2/18 18:28, Vegard Nossum wrote: On 17 February 2014 03:34, Xishi Qiu qiuxi...@huawei.com wrote: If we want to debug the kernel memory, we should turn on CONFIG_KMEMCHECK and rebuild the kernel. This always takes a long time and sometimes impossible, e.g. users don't have the kernel

mm: OS boot failed when set command-line kmemcheck=1

2014-02-18 Thread Xishi Qiu
Hi all, CONFIG_KMEMCHECK=y and set command-line kmemcheck=1, I find OS boot failed. The kernel is v3.14.0-rc3 If set kmemcheck=1 nowatchdog, OS will boot successfully. Here is the boot failed log: [ 23.586826] Freeing unused kernel memory: 1160K (8800014de000 - 88000 160) [

Re: mm: OS boot failed when set command-line kmemcheck=1

2014-02-19 Thread Xishi Qiu
On 2014/2/19 15:49, David Rientjes wrote: On Wed, 19 Feb 2014, Xishi Qiu wrote: Hi all, CONFIG_KMEMCHECK=y and set command-line kmemcheck=1, I find OS boot failed. The kernel is v3.14.0-rc3 If set kmemcheck=1 nowatchdog, OS will boot successfully. I have automated kernel boots

Re: [PATCH 3.10 00/26] 3.10.31-stable review

2014-02-19 Thread Xishi Qiu
However, my strong suspect is the following: Xishi Qiu qiuxi...@huawei.com mm: fix process accidentally killed by mce because of huge page migration I don't see how this could cause problems, none the less, I will test without these changes and let you know. Naoya Horiguchi n-horigu

Re: [PATCH] mm: add a new command-line kmemcheck value

2014-02-10 Thread Xishi Qiu
On 2014/1/22 9:22, Xishi Qiu wrote: Hi Vegard, In some scenes, user want to check memory dynamicly, this dynamically means we can turn on/off the feature at boottime, not runtime. Without this patch, if user want to use this feature, he should change config and build the kernel

Re: [PATCH 4/5] ACPI / scan: Add second pass of companion offlining to hot-remove code

2013-05-21 Thread Xishi Qiu
; + if (second_pass) { + /* Skip devices offlined by the first pass. */ + if (pn-put_online) should it be if (!pn-put_online) ? Thanks Xishi Qiu + continue; + } else { + pn-put_online = false

Re: [PATCH] doc: fix some typos in documentations

2013-10-07 Thread Xishi Qiu
On 2013/10/1 18:24, Johannes Berg wrote: On Wed, 2013-09-18 at 11:45 +0800, Xishi Qiu wrote: to ensure the driver cannot be built-in when rfkill is modular. The !RFKILL -case allows the driver to be built when rfkill is not configured, which which +case allows the driver to be built

[PATCH V2] doc: fix some typos in documentations

2013-10-07 Thread Xishi Qiu
Fix some typos in five documentations, no functional changes. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/md.txt |2 +- Documentation/rfkill.txt |2 +- Documentation/rt-mutex-design.txt |2 +- Documentation/static-keys.txt |4

kdump: kdump can't boot in this case

2013-10-09 Thread Xishi Qiu
I write a module, and find kdump can't boot in this case. kernel version is 3.12, Intel(R) Xeon(R) CPUE5620 struct timer_list g_timer; void tmrhnd_invtssfault(unsigned long data) { long __res; printk(KERN_EMERG invalid TSS fault in interrupt context.\n); __asm__

[BUG] kdump won't work if invalid TSS fault happens in irq context

2013-10-09 Thread Xishi Qiu
I write a module, and find kdump can't boot in the following case. Kernel version is 3.4.24, Intel(R) Xeon(R) CPU E5620, and kernel v3.12 has the same problem too. Here is the code: struct timer_list g_timer; void tmrhnd_invtssfault(unsigned long data) { long __res;

[PATCH 2/2] mm/driver: use __free_reserved_page() to simplify the code

2013-09-04 Thread Xishi Qiu
Use __free_reserved_page() to simplify the code in the others. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- drivers/video/acornfb.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/video/acornfb.c b/drivers/video/acornfb.c index 6488a73..4ef302a 100644

[PATCH 1/2] mm/arch: use __free_reserved_page() to simplify the code

2013-09-04 Thread Xishi Qiu
the value __free_page() Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- arch/metag/kernel/dma.c |4 +--- arch/microblaze/mm/consistent.c |7 ++- arch/powerpc/mm/dma-noncoherent.c |4 +--- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/arch/metag

[PATCH] doc: Documentation/cputopology.txt fix typo

2013-09-04 Thread Xishi Qiu
Fix a trivial typo in Documentation/cputopology.txt Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/cputopology.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/cputopology.txt b/Documentation/cputopology.txt index 902d315..0aad6de 100644

[PATCH 1/2] mm: use pgdat_end_pfn() to simplify the code in arch

2013-09-05 Thread Xishi Qiu
Use pgdat_end_pfn() instead of pgdat-node_start_pfn + pgdat-node_spanned_pages. Simplify the code, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- arch/ia64/mm/init.c|4 +--- arch/metag/mm/init.c |2 +- arch/powerpc/mm/numa.c |3 +-- arch/sh/mm/init.c

[PATCH 2/2] mm: use pgdat_end_pfn() to simplify the code in others

2013-09-05 Thread Xishi Qiu
Use pgdat_end_pfn() instead of pgdat-node_start_pfn + pgdat-node_spanned_pages. Simplify the code, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- fs/proc/kcore.c |3 +-- mm/bootmem.c|2 +- mm/memory_hotplug.c |9 - 3 files changed, 6

[PATCH] mm: use populated_zone() instead of if(zone-present_pages)

2013-09-05 Thread Xishi Qiu
Use if (zone-present_pages) instead of if (zone-present_pages). Simplify the code, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/page_alloc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b100255

[PATCH V2] mm: use populated_zone() instead of if(zone-present_pages)

2013-09-05 Thread Xishi Qiu
Use if (populated_zone(zone)) instead of if (zone-present_pages). Simplify the code, no functional change. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/page_alloc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index b100255

[PATCH] doc: fix some typos in documentation

2013-09-05 Thread Xishi Qiu
Fix some typos in Documentation/IRQ-domain.txt/email-clients.txt/io-mapping.txt Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/IRQ-domain.txt|4 ++-- Documentation/email-clients.txt |2 +- Documentation/io-mapping.txt|2 +- 3 files changed, 4 insertions(+), 4

[PATCH] mm/hotplug: rename the function is_memblock_offlined_cb()

2013-09-06 Thread Xishi Qiu
Function is_memblock_offlined() return 1 means memory block is offlined, but is_memblock_offlined_cb() return 1 means memory block is not offlined, this will confuse somebody, so rename the function. Another, use pfn_to_nid(pfn) instead of page_to_nid(pfn_to_page(pfn)). Signed-off-by: Xishi Qiu

[PATCH 2/2] mm/cleanup: use pfn_to_nid() instead of page_to_nid(pfn_to_page())

2013-09-08 Thread Xishi Qiu
Use pfn_to_nid(pfn) instead of page_to_nid(pfn_to_page(pfn)). Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- mm/memory_hotplug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 85f80b7..a95dd28 100644 --- a/mm

[PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()

2013-09-08 Thread Xishi Qiu
Function is_memblock_offlined() return 1 means memory block is offlined, but is_memblock_offlined_cb() return 1 means memory block is not offlined, this will confuse somebody, so rename the function. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Acked-by: Yasuaki Ishimatsu isimatu.yasu

[PATCH RESEND] doc: Documentation/DMA-attributes.txt fix typo

2013-09-08 Thread Xishi Qiu
Fix some typos in Documentation/DMA-attributes.txt. Signed-off-by: Xishi Qiu qiuxi...@huawei.com Acked-by: Rob Landley r...@landley.net --- Documentation/DMA-attributes.txt |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/DMA-attributes.txt b

Re: [PATCH 1/2] mm/hotplug: rename the function is_memblock_offlined_cb()

2013-09-09 Thread Xishi Qiu
On 2013/9/9 14:08, Yasuaki Ishimatsu wrote: [CCing Kosaki since he maintains mm/memory_hotplug.c] (2013/09/09 12:27), Xishi Qiu wrote: Function is_memblock_offlined() return 1 means memory block is offlined, but is_memblock_offlined_cb() return 1 means memory block is not offlined

[PATCH] doc: Documentation/DMA-attributes.txt fix typo

2013-08-30 Thread Xishi Qiu
Fix some typos in Documentation/DMA-attributes.txt. Signed-off-by: Xishi Qiu qiuxi...@huawei.com --- Documentation/DMA-attributes.txt |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/DMA-attributes.txt b/Documentation/DMA-attributes.txt index e59480d

kmemcheck: got WARNING when dynamicly adjust /proc/sys/kernel/kmemcheck to 0/1

2014-05-09 Thread Xishi Qiu
OS boot with kmemcheck=0, then set 1, do something, set 0, do something, set 1... then I got the WARNING log. Does kmemcheck support dynamicly adjust? Thanks, Xishi Qiu [ 20.200305] igb: eth0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX [ 20.208652] ADDRCONF(NETDEV_UP): eth0: link

Re: kmemcheck: got WARNING when dynamicly adjust /proc/sys/kernel/kmemcheck to 0/1

2014-05-09 Thread Xishi Qiu
On 2014/5/9 15:57, Xishi Qiu wrote: OS boot with kmemcheck=0, then set 1, do something, set 0, do something, set 1... then I got the WARNING log. Does kmemcheck support dynamicly adjust? Thanks, Xishi Qiu [ 20.200305] igb: eth0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX

  1   2   3   4   5   6   7   8   9   10   >