Re: [PATCH] thermal:samsung: fix compilation warning

2014-01-01 Thread Zhang Rui
On Fri, 2013-12-20 at 17:42 +0530, Naveen Krishna Chatradhi wrote: > This patch fixes a compilation warning. > > warning: passing argument 5 of 'thermal_zone_device_register' discards 'const' > qualifier from pointer target type [enabled by default] > include/linux/thermal.h:270:29: note: expected

Re: [PATCH V2] thermal: imx: correct suspend/resume flow

2014-01-01 Thread Zhang Rui
On Tue, 2013-12-24 at 09:43 -0500, Anson Huang wrote: > Fixes regression introduced by: > > commit 37713a1e8e4c1a1067ad4c99296f78d3c82ed9c4 > Author: Philipp Zabel > Date: Thu Aug 1 18:33:12 2013 +0200 > > thermal: imx: implement thermal alarm interrupt handling > > The commit 37713a1e8e4

Re: [PATCH 23/25] thermal: exynos: fix error return code

2014-01-01 Thread Zhang Rui
On Sun, 2013-12-29 at 23:47 +0100, Julia Lawall wrote: > From: Julia Lawall > > Set the return variable to an error code as done elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > if@p1 (\

RE: [PATCH 0/4] Convert ACPI fan driver to platform driver

2013-12-05 Thread Zhang, Rui
> -Original Message- > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Thursday, December 05, 2013 7:10 AM > To: Lu, Aaron > Cc: Zhang, Rui; linux-a...@vger.kernel.org; linux- > ker...@vger.kernel.org; Lan, Tianyu; Brown, Len; Matthew Garrett > Su

Re: [PATCH] sysfs, acpi, tables: Set file size for each ACPI table

2013-11-20 Thread Zhang Rui
00 00 ...@ > 00A0: 00 00 00 00 00 00 00 00 > > Signed-off-by: HATAYAMA Daisuke Nice catch! Acked-by: Zhang Rui thanks, rui > --- > drivers/acpi/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [lm-sensors] [PATCHv9 02/20] thermal: introduce device tree parser

2013-11-17 Thread Zhang Rui
DT thermal zone, > > it was required to allow changing the thermal zone > > .get_temp callback. For this reason, this patch > > also removes the 'const' modifier from the .ops > > field of thermal zone devices. > > > > Cc: Zhang Rui > > C

[GIT PULL] thermal management updates for v3.13-rc1

2013-11-12 Thread Zhang Rui
Wei Yongjun (1): thermal: cpu_cooling: fix return value check in cpufreq_cooling_register() Zhang Rui (1): Merge branches 'intel_powerclamp', 'tmon' and 'misc' of .git into next durgados...@intel.com (2): Thermal: Tidy up error handling in powercla

Re: [PATCH] thermal: Fix binding problem when there is thermal zone params

2013-11-05 Thread Zhang Rui
On Fri, 2013-10-18 at 18:03 +0800, Wei Ni wrote: > The thermal zone params can be used to set governor > to specific thermal governor for thermal zone device. > But if the thermal zone params has only governor name > without thermal bind params, then the thermal zone device > will not be binding to

RE: [PATCH v9 3/7] thermal:boost: Automatic enable/disable of BOOST feature

2013-10-17 Thread Zhang, Rui
> -Original Message- > From: Lukasz Majewski [mailto:l.majew...@samsung.com] > Sent: Tuesday, October 15, 2013 11:43 PM > To: Zhang, Rui > Cc: Viresh Kumar; Rafael J. Wysocki; Eduardo Valentin; > cpuf...@vger.kernel.org; Linux PM list; Jonghwa Lee; Lukasz Majews

Re: [GIT PULL] thermal-soc: urgent fixes for 3.12

2013-10-15 Thread Zhang Rui
Hi, Eduardo, On Mon, 2013-10-14 at 18:00 -0400, Eduardo Valentin wrote: > Hello Rui, > > Please pull the following changes. It contains fixes for 3.12 on Exynos > thermal driver, which is currently broken, Exynos4412 is the main affected. > Thanks Lukasz for his persistence on getting this done f

Re: [PATCHv4 0/9] Thermal Framework Enhancements

2013-10-15 Thread Zhang Rui
Hi, Durga, On Wed, 2013-10-02 at 00:07 +0530, Durgadoss R wrote: > This patch set is a v4 of the previous versions submitted here: > [v3]: https://lkml.org/lkml/2013/2/5/228 > [v2]: http://lwn.net/Articles/531720/ > [v1]: https://lkml.org/lkml/2012/12/18/108 > [RFC]:https://patchwork.kernel.org/

Re: [PATCHv4 5/9] Thermal: Add trip point sysfs nodes for sensor

2013-10-15 Thread Zhang Rui
On Wed, 2013-10-02 at 00:08 +0530, Durgadoss R wrote: > This patch adds a trip point related sysfs nodes > for each sensor under a zone in /sys/class/thermal/zoneX/. > The nodes will be named, sensorX_trip_activeY, > sensorX_trip_passiveY, sensorX_trip_hot, sensorX_trip_critical > for active, passi

Re: [PATCHv4 4/9] Thermal: Add APIs to bind cdev to new zone structure

2013-10-15 Thread Zhang Rui
On Wed, 2013-10-02 at 00:08 +0530, Durgadoss R wrote: > This patch creates new APIs to add/remove a > cdev to/from a zone. This patch does not change > the old cooling device implementation. > > Signed-off-by: Durgadoss R I'm okay with this patch except the API naming. thanks, rui > --- > drive

Re: [PATCHv4 3/9] Thermal: Create zone level APIs

2013-10-15 Thread Zhang Rui
On Wed, 2013-10-02 at 00:08 +0530, Durgadoss R wrote: > This patch adds a new thermal_zone structure to > thermal.h. Also, adds zone level APIs to the thermal > framework. > > A thermal zone is a hot spot on the platform, which > can have one or more sensors and cooling devices attached > to it. T

RE: [PATCHv4 2/9] Thermal: Create sensor level APIs

2013-10-15 Thread Zhang Rui
On Mon, 2013-10-14 at 10:21 -0600, R, Durgadoss wrote: > Hi Rui, > > > -Original Message- > > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > > ow...@vger.kernel.org] On Behalf Of Zhang Rui > > Sent: Monday, October 14, 2013 2:56 PM > > To

Re: [PATCH v9 3/7] thermal:boost: Automatic enable/disable of BOOST feature

2013-10-15 Thread Zhang Rui
Hi, Lukasz, thanks for the patch, sorry that I didn't look into this one earlier. On Mon, 2013-10-14 at 14:17 +0200, Lukasz Majewski wrote: > This patch provides auto disable/enable operation for boost. When any > defined trip point is passed, the boost is disabled. Do you mean boost is disabled

Re: [PATCH 1/3] ACPI: add module autoloading support for ACPI enumerated devices

2013-10-14 Thread Zhang Rui
On Mon, 2013-10-14 at 13:14 +0300, Mika Westerberg wrote: > On Mon, Oct 14, 2013 at 05:10:32PM +0800, Zhang Rui wrote: > > An ACPI enumerated device may have its compatible id strings. > > > > To support the compatible ACPI ids (acpi_device->pnp.ids), > > we intro

Re: [PATCHv4 2/9] Thermal: Create sensor level APIs

2013-10-14 Thread Zhang Rui
On Wed, 2013-10-02 at 00:08 +0530, Durgadoss R wrote: > This patch creates sensor level APIs, in the > generic thermal framework. > > A Thermal sensor is a piece of hardware that can report > temperature of the spot in which it is placed. A thermal > sensor driver reads the temperature from this s

[PATCH 3/3] I2C: fix module autoloading for ACPI enumerated devices

2013-10-14 Thread Zhang Rui
Signed-off-by: Zhang Rui --- drivers/i2c/i2c-core.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 3be58f8..d75b679 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -104,6 +104,11 @@ static int i2c_device_match

[PATCH 1/3] ACPI: add module autoloading support for ACPI enumerated devices

2013-10-14 Thread Zhang Rui
a problem that will affect us the day when the ACPI bus is removed from device model. This patch introduces a new function to exporting ACPI ids as the module_alias, for the ACPI enumerate devices. For any drivers using MODULE_DEVICE_TALBE(acpi, blabla), the uevent file of its associated device

[PATCH 2/3] Platform: fix module autoloading for ACPI enumerated devices

2013-10-14 Thread Zhang Rui
Signed-off-by: Zhang Rui --- drivers/base/platform.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 4f8bef3..80d2250 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -690,6 +690,10 @@ static int

RE: [PATCH v2 0/5] thermal: exynos: Fixes for v3.12

2013-10-13 Thread Zhang, Rui
3 1:47 PM > To: Zhang, Rui; Eduardo Valentin; kgene@samsung.com > Cc: Lukasz Majewski; Linux PM list; Lukasz Majewski; linux-kernel; > Bartlomiej Zolnierkiewicz; devicet...@vger.kernel.org; Amit Daniel > Kachhap; linux-samsung-...@vger.kernel.org > Subject: Re: [PATCH v2 0/5] the

Re: [PATCHv4 1/9] Thermal: Check for validity before doing kfree

2013-10-13 Thread Zhang Rui
On Wed, 2013-10-02 at 00:08 +0530, Durgadoss R wrote: > The thermal_release function is called whenever > any device belonging to 'thermal' class unregisters. > This function performs kfree(cdev) without any check. > In cases where there are more device registrations > other than just 'thermal_zone

RE: [PATCH] Thermal: Fix Step-wise governor Kconfig help text

2013-10-10 Thread Zhang, Rui
Hi, Abelardo, > -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Abelardo Ricart > Sent: Wednesday, October 09, 2013 4:50 PM > To: linux...@vger.kernel.org > Cc: triv...@kernel.org; linux-kernel@vger.kernel.org; Abelardo Rica

Re: [PATCH] thermal/intel_powerclamp: Add newer CPU models

2013-10-08 Thread Zhang Rui
On Thu, 2013-09-26 at 04:33 -0700, Jacob Pan wrote: > This will enable intel_powerclamp driver on newer Intel CPUs > including some Ivy Bridge and Haswell processors. > > Signed-off-by: Jacob Pan applied to thermal -next. thanks, rui > --- > drivers/thermal/intel_powerclamp.c |5 + > 1

Re: [PATCH] typo in drivers/thermal/Kconfig: lpatform instead of platform

2013-09-25 Thread Zhang Rui
On Mon, 2013-09-09 at 00:58 +0300, Regid Ichira wrote: > Applied to the HEAD of linux.git, >VERSION = 3 PATCHLEVEL = 11 SUBLEVEL = 0 > Signed-off-by: Regid Ichira applied to thermal -next. thanks, rui > --- > drivers/thermal/Kconfig | 2 +- > 1 file changed, 1 insertion(

Re: [PATCH 3/5] drivers: thermal: make usage of CONFIG_THERMAL_HWMON optional

2013-08-27 Thread Zhang Rui
On 二, 2013-08-27 at 23:17 +0200, Rafael J. Wysocki wrote: > On Tuesday, August 27, 2013 02:26:41 PM Eduardo Valentin wrote: > > On 23-08-2013 19:08, Rafael J. Wysocki wrote: > > > On Friday, August 23, 2013 06:03:14 PM Eduardo Valentin wrote: > > >> When registering a new thermal_device, the therma

Re: [PATCH] thermal: new asus driver

2013-08-15 Thread Zhang Rui
On 四, 2013-08-15 at 15:22 +0800, Zhang Rui wrote: > On 二, 2013-08-06 at 17:48 -0500, Felipe Contreras wrote: > > Simple driver to enable control of the fan in ASUS laptops. So far this > > has only been tested in ASUS Zenbook Prime UX31A, but according to some > > online ref

Re: [PATCH] thermal: new asus driver

2013-08-15 Thread Zhang Rui
On 二, 2013-08-06 at 17:48 -0500, Felipe Contreras wrote: > Simple driver to enable control of the fan in ASUS laptops. So far this > has only been tested in ASUS Zenbook Prime UX31A, but according to some > online reference [1], it should work in other models as well. > I'd rather prefer to do thi

Re: [PATCH] thermal: exynos_tmu: fix wrong error check for mapped memory

2013-08-15 Thread Zhang Rui
On 三, 2013-08-07 at 14:01 +0530, Naveen Krishna Chatradhi wrote: > The error check is checking for a "base" mapped memory base > instead of "base_common". Fixing the same. > > Signed-off-by: Naveen Krishna Chatradhi applied. Thanks! BTW, can you rebase the other three exynos patches you submitte

Re: [RFC PATCH 1/4] thermal: hwmon: move hwmon support to single file

2013-08-14 Thread Zhang Rui
drivers/thermal/thermal_hwmon.h > @@ -0,0 +1,49 @@ > +/* > + * thermal_hwmon.h - Generic Thermal Management hwmon support. > + * > + * Code based on Intel thermal_core.c. Copyrights of the original code: > + * Copyright (C) 2008 Intel Corp > + * Copyright (C) 2008 Zhang Rui >

Re: [Panic - Bisected] f1a18a10566081abfce1649c2f3884b28fff7372 cases panic on boot

2013-07-23 Thread Zhang Rui
On Tue, 2013-07-23 at 21:56 -0300, Kevin Winchester wrote: > On 22 July 2013 23:11, Linus Torvalds wrote: > > On 22 July 2013 21:45, Kevin Winchester wrote: > >> I have found that the new CPU Package temperature thermal driver introduced > >> in this merge window causes my HP laptop to panic on b

[GIT PULL] Thermal management fixes for v3.11-rc3

2013-07-21 Thread Zhang Rui
Hi, Linus, Please pull from the git repository at git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git next to receive Thermal management fixes for v3.11-rc3 with top-most commit ace120dcf23b3bbba00d797a898481997381052f: Thermal: Fix lockup of cpu_down() on top of commit 47188d39

Re: thermal / x86: Fix init error code path in package temperature driver

2013-07-21 Thread Zhang Rui
On Sun, 2013-07-21 at 15:03 +0200, Rafael J. Wysocki wrote: > On Saturday, July 20, 2013 11:30:44 PM Srinivas Pandruvada wrote: > > Hi Rafael, > > > > This is already fixed and currently merged to MM tree. So this should > > make to rc2. > > I don't know whether Rui will push or MM maintainer wil

RE: [PATCH V7 00/30] thermal: exynos: Re-structure driver and add support for exynos5440

2013-06-27 Thread Zhang, Rui
> -Original Message- > From: amit.kach...@gmail.com [mailto:amit.kach...@gmail.com] On Behalf > Of amit daniel kachhap > Sent: Friday, June 28, 2013 1:20 PM > To: Zhang, Rui > Cc: Eduardo Valentin; Kukjin Kim; linux...@vger.kernel.org; linux- > samsung-...@vger.ker

Re: [PATCH 1/1] thermal: MAINTAINERS: Add git tree path for SoC specific updates

2013-06-23 Thread Zhang Rui
merge > window and rc's (for fixes). > > Branch names would be: next and fixes. > > Cc: Zhang Rui > Cc: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin Acked-by: Zhang Rui thanks, rui > --- > MAINTAINERS | 1 + &g

Re: [PATCH -next v3] thermal: fix x86_pkg_temp_thermal.c build and Kconfig

2013-06-17 Thread Zhang Rui
On Mon, 2013-06-17 at 21:45 +0200, Borislav Petkov wrote: > On Mon, Jun 17, 2013 at 12:27:17PM -0700, Randy Dunlap wrote: > > From: Randy Dunlap > > > > Fix build error in x86_pkg_temp_thermal.c. It requires that > > X86_MCE & X86_THERMAL_VECTOR be enabled, so depend on the latter symbol, > > si

[RFC PATCH 2/6] thermal: step_wise: return instance->target by default

2013-06-17 Thread Zhang Rui
the difference between instance cur target, next target and cdev cur_state. Cc: Zhang Rui Cc: Durgadoss R Cc: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Reported-by: Ruslan Ruslichenko Signed-of-by: Eduardo Valentin Signed-off-by: Zhang Rui --- drivers/thermal/step_wise.c |

Re: [PATCH 1/1] thermal: consider emul_temperature while computing trend

2013-06-12 Thread Zhang Rui
gt; > To avoid this situation, this patch changes the get_tz_trend() > to consider the emulated temperature whenever that is in use. > > Cc: Zhang Rui > Cc: Amit Daniel Kachhap > Cc: Durgadoss R > Cc: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signe

Re: [PATCH 0/7] thermal: ti-soc-thermal: fixes and DRA752 support

2013-06-12 Thread Zhang Rui
On Wed, 2013-05-29 at 11:07 -0400, Eduardo Valentin wrote: > Hello Rui, > > Here is a patch set for your consideration on ti-soc-thermal driver. > the whole patch set has been applied. thanks, rui > This patch set is mix of: > > (a) patches that were added to the staging tree post 3.10-rc1 but

Re: [RFT][PATCH 1/1] thermal: step_wise: return instance->target by default

2013-05-29 Thread Zhang Rui
now it is put in use > the THERMAL_NO_TARGET macro. > (d) - variable names are also improved so that reader can > clearly understand the difference between instance cur target, > next target and cdev cur_state. > > Cc: Zhang Rui > Cc: Durgadoss R > Cc: linux...@vger.kern

Re: [PATCH 0/2] staging -> thermal: move ti-soc-thermal to drivers/thermal

2013-05-27 Thread Zhang Rui
On Wed, 2013-05-15 at 11:45 -0400, Eduardo Valentin wrote: > Hello Greg and Rui, > > I am proposing to move the ti-soc-thermal driver from drivers/stating/ > to drivers/thermal. It has been some time that we have been fixing and > improving the code under staging tree. > > I believe it is time to

Re: Fans at full speed after resume

2013-05-26 Thread Zhang Rui
On Thu, 2013-05-23 at 22:22 +0200, Michael Großhäuser wrote: > Zhang Rui wrote: > > > On Wed, 2013-05-22 at 20:46 +0200, Michael Großhäuser wrote: > >> Zhang Rui wrote: > >> > >> > On Wed, 2013-05-15 at 12:26 +0800, Zhang Rui wrote: > >> >

Re: Fans at full speed after resume

2013-05-22 Thread Zhang Rui
On Wed, 2013-05-22 at 20:46 +0200, Michael Großhäuser wrote: > Zhang Rui wrote: > > > On Wed, 2013-05-15 at 12:26 +0800, Zhang Rui wrote: > >> please > >> > >> On Tue, 2013-05-14 at 21:18 -0700, Sonny Rao wrote: > >> > Hi, I've see

Re: [PATCH 2/3] Thermal: core: Modify temp_crit_show() to use proper callback function.

2013-05-22 Thread Zhang Rui
On Tue, 2013-05-21 at 10:31 +0900, jonghwa3@samsung.com wrote: > On 2013년 05월 21일 00:57, Zhang, Rui wrote: > > > > > > >> -Original Message- > >> From: Jonghwa Lee [mailto:jonghwa3@samsung.com] > >> Sent: Saturday, May 18, 2013 5:51

Re: [PATCH 3/3] Thermal:core: Handle trips focused on current trip point only.

2013-05-22 Thread Zhang Rui
On Tue, 2013-05-21 at 12:40 +0900, jonghwa3@samsung.com wrote: > On 2013년 05월 21일 01:00, Zhang, Rui wrote: > > > > > > >> -Original Message- > >> From: Jonghwa Lee [mailto:jonghwa3@samsung.com] > >> Sent: Saturday, May 18, 2013 5:51

RE: [PATCH 3/3] Thermal:core: Handle trips focused on current trip point only.

2013-05-20 Thread Zhang, Rui
> -Original Message- > From: Jonghwa Lee [mailto:jonghwa3@samsung.com] > Sent: Saturday, May 18, 2013 5:51 PM > To: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit > Dinel Kachhap; Jonghwa Lee; MyungJoo Ham >

RE: [PATCH 2/3] Thermal: core: Modify temp_crit_show() to use proper callback function.

2013-05-20 Thread Zhang, Rui
> -Original Message- > From: Jonghwa Lee [mailto:jonghwa3@samsung.com] > Sent: Saturday, May 18, 2013 5:51 PM > To: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit > Dinel Kachhap; Jonghwa Lee; MyungJoo Ham >

RE: [PATCH 1/3] Thermal: core: Ask .get_trip_temp() to register thermal zone device.

2013-05-20 Thread Zhang, Rui
> -Original Message- > From: Jonghwa Lee [mailto:jonghwa3@samsung.com] > Sent: Saturday, May 18, 2013 5:50 PM > To: linux...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit > Dinel Kachhap; Jonghwa Lee; MyungJoo Ham >

RE: [PATCH 20/33] drivers/thermal: don't check resource with devm_ioremap_resource

2013-05-20 Thread Zhang, Rui
> -Original Message- > From: Wolfram Sang [mailto:w...@the-dreams.de] > Sent: Thursday, May 16, 2013 7:16 PM > To: linux-kernel@vger.kernel.org > Cc: Wolfram Sang; Zhang, Rui; Eduardo Valentin; linux- > p...@vger.kernel.org > Subject: [PATCH 20/33] drivers/thermal:

Re: [RFC 26/42] drivers/thermal: don't check resource with devm_ioremap_resource

2013-05-16 Thread Zhang Rui
On Fri, 2013-05-10 at 10:17 +0200, Wolfram Sang wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang applied to thermal -next. thanks, rui > --- > drivers/thermal/dove_thermal.c | 11 +-

Re: ACPI fan driver: uninitialized variable when CONFIG_PM is not set

2013-05-15 Thread Zhang Rui
Hi, Michel, On Mon, 2013-04-29 at 05:32 -0700, Michel Lespinasse wrote: > In the following code: > > static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned > long > *state) > { > struct acpi_device *device = cdev->devdata; > int re

Re: Fans at full speed after resume

2013-05-14 Thread Zhang Rui
On Wed, 2013-05-15 at 12:26 +0800, Zhang Rui wrote: > please > > On Tue, 2013-05-14 at 21:18 -0700, Sonny Rao wrote: > > Hi, I've seen a regression in kernels since 3.7 on x86 devices where > > the kernel turns the system fans on to max speed after resuming from &

Re: Fans at full speed after resume

2013-05-14 Thread Zhang Rui
please On Tue, 2013-05-14 at 21:18 -0700, Sonny Rao wrote: > Hi, I've seen a regression in kernels since 3.7 on x86 devices where > the kernel turns the system fans on to max speed after resuming from > ram. Other people have noticed it as well, for example see > https://bugzilla.redhat.com/show_

Re: [PATCH V3 02/21] thermal: exynos: Bifurcate exynos thermal common and tmu controller code

2013-05-07 Thread Zhang Rui
On Tue, 2013-05-07 at 18:30 +0530, Amit Daniel Kachhap wrote: > This code bifurcates exynos thermal implementation into common and sensor > specific parts. The common thermal code interacts with core thermal layer and > core cpufreq cooling parts and is independent of SOC specific driver. This > ch

Re: [PATCH V2 05/20] thermal: exynos: Bifurcate exynos tmu driver and configuration data

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This code splits the exynos tmu driver code into SOC specific data parts. > This will simplify adding new SOC specific data to the same TMU controller. > > Acked-by: Kukjin Kim > Signed-off-by: Amit Daniel Kachhap I'm okay with all

Re: [PATCH V2 04/20] thermal: exynos: Move exynos_thermal.h from include/* to driver/* folder

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This patch renames and moves include/linux/platform_data/exynos_thermal.h to > drivers/thermal/samsung/exynos_tmu.h. This file movement is needed as exynos > SOC's are not supporting non-DT based platforms. Also the rename is needed a

Re: [PATCH V2 03/20] thermal: exynos: Rename exynos_thermal.c to exynos_tmu.c

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This patch renames exynos_thermal.c to exynos_tmu.c. This change is needed as > this file now just contains exynos tmu driver related codes and thermal zone > or cpufreq cooling registration related changes are not there anymore. > >

Re: [PATCH V2 02/20] thermal: exynos: Bifurcate exynos thermal common and tmu controller code

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This code bifurcates exynos thermal implementation into common and sensor > specific parts. The common thermal code interacts with core thermal layer and > core cpufreq cooling parts and is independent of SOC specific driver. This > ch

Re: [PATCH V2 01/20] thermal: exynos: Moving exynos thermal files into samsung directory

2013-05-06 Thread Zhang Rui
On Fri, 2013-04-26 at 16:07 +0530, Amit Daniel Kachhap wrote: > This movement of files is done for easy maintenance and adding more > new sensor's support for exynos platform easily . This will also help in > bifurcating exynos common, sensor driver and sensor data related parts. > > Acked-by: Kuk

Re: [PATCH] ACPI thermal: do not always return THERMAL_TREND_RAISING for active trip points

2013-04-27 Thread Zhang Rui
On Sat, 2013-04-27 at 12:23 +0200, Pavel Machek wrote: > Hi! > > > Commit 4ae46befb49d4173122e0afa995c4e93d01948a2 > > introduces a regression that the fan is always on > > even if the system is in idle state. > > > > My original idea in that commit is that: > > when the current temperature is ab

[PATCH] ACPI thermal: do not always return THERMAL_TREND_RAISING for active trip points

2013-04-26 Thread Zhang Rui
=56601 https://bugzilla.kernel.org/show_bug.cgi?id=50041#c45 Patch should be applied to 3.7 stable kernel and later. Signed-off-by: Zhang Rui Tested-by: Matthias Tested-by: Ville Syrjälä Cc: # v3.7+ --- drivers/acpi/thermal.c | 16 +--- 1 file changed, 13 insertions(+), 3

Re: [PATCH 15/21] thermal: cooling: avoid uninitialied used gcc warning

2013-04-26 Thread Zhang Rui
Slightly rearranging the code makes this more obvious and > avoids the warning. > > Signed-off-by: Arnd Bergmann > Cc: Zhang Rui > Cc: Amit Daniel kachhap we already have a fix for this. please refer to https://patchwork.kernel.org/patch/2454891/ thanks for your patch, Arnd! -

Re: [PATCH 28/30] MAINTAINERS: update thermal entry by adding file cpu_cooling.h

2013-04-24 Thread Zhang Rui
On Wed, 2013-04-24 at 13:34 -0400, Eduardo Valentin wrote: > Rui, > > On 17-04-2013 13:12, Eduardo Valentin wrote: > > Add cpu_cooling.h to thermal entry in MAINTAINERS. > > > > Cc: Zhang Rui > > Cc: linux...@vger.kernel.org > > Cc: linux-kernel@vge

RE: [PATCHv2 0/9] thermal: clean ups on thermal code base

2013-04-24 Thread Zhang, Rui
Hi, Eduardo, > -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Eduardo Valentin > Sent: Wednesday, April 24, 2013 5:48 AM > To: Zhang, Rui > Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org;

RE: [PATCH RESEND 11/11] thermal: update kernel-doc for thermal_zone_device_register

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: Eduardo Valentin [mailto:eduardo.valen...@ti.com] > Sent: Thursday, April 18, 2013 3:30 AM > To: Zhang, Rui > Cc: Eduardo Valentin; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH RESEND 11/11] thermal:

RE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Zhang, Rui > Sent: Thursday, April 25, 2013 12:32 AM > To: Eduardo Valentin; amit.kach...@linaro.org > Cc: linux...@vger.kernel.org; linux-kernel@vger.ke

RE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Eduardo Valentin > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kach...@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux...@vger.kernel

RE: [PATCH 02/30] thermal: cpu_cooling: remove trailing white spaces

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Zhang, Rui > Sent: Wednesday, April 24, 2013 10:49 PM > To: Eduardo Valentin; amit.kach...@linaro.org > Cc: linux...@vger.kernel.org; linux-kernel@vger.ke

RE: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: Eduardo Valentin [mailto:eduardo.valen...@ti.com] > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kach...@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject:

RE: [PATCH 03/30] thermal: cpu_cooling: fix kernel_doc for cpufreq_cooling_device

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: Eduardo Valentin [mailto:eduardo.valen...@ti.com] > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kach...@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject:

RE: [PATCH 04/30] thermal: cpu_cooling: use EXPORT_SYMBOL_GPL

2013-04-24 Thread Zhang, Rui
Applied. Thanks, rui > -Original Message- > From: Eduardo Valentin [mailto:eduardo.valen...@ti.com] > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kach...@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org >

RE: [PATCH 02/30] thermal: cpu_cooling: remove trailing white spaces

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: Eduardo Valentin [mailto:eduardo.valen...@ti.com] > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kach...@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject:

RE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers

2013-04-24 Thread Zhang, Rui
> -Original Message- > From: linux-pm-ow...@vger.kernel.org [mailto:linux-pm- > ow...@vger.kernel.org] On Behalf Of Eduardo Valentin > Sent: Thursday, April 18, 2013 1:12 AM > To: amit.kach...@linaro.org > Cc: Eduardo Valentin; Zhang, Rui; linux...@vger.kernel

Re: [PATCH RESEND 03/11] thermal: rename notify_thermal_framework to thermal_notify_framework

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > To follow the prefix names used by the thermal exported functions, > this patch renames notify_thermal_framework to thermal_notify_framework. > > Signed-off-by: Eduardo Valentin Hmm, I'm okay with this one. thanks, rui > --- > Docume

Re: [PATCH RESEND 01/11] thermal: use strlcpy instead of strcpy

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > For memory boundaries safety, use strlcpy instead of strcpy. > > Signed-off-by: Eduardo Valentin ACK. thanks, rui > --- > drivers/thermal/thermal_sys.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH RESEND 10/11] thermal: update kernel-doc for create_trip_attrs

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > This patch updates the documentation for create_trip_attrs > and removes the warnings generated by scripts/kernel-doc -v. > > Signed-off-by: Eduardo Valentin this one looks okay to me. thanks, rui > --- > drivers/thermal/thermal_sys.

Re: [PATCH RESEND 09/11] thermal: update kernel-doc for thermal_cooling_device_register

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > This patch updates the documentation for thermal_cooling_device_register > and removes the warnings generated by scripts/kernel-doc -v. > > Signed-off-by: Eduardo Valentin > --- > drivers/thermal/thermal_sys.c |9 - > 1 fil

Re: [PATCH RESEND 08/11] thermal: update kernel-doc for thermal_zone_unbind_cooling_device

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > This patch updates the documentation for thermal_zone_unbind_cooling_device > and removes the warnings generated by scripts/kernel-doc -v. > > Signed-off-by: Eduardo Valentin I'm fine with this one. thanks, rui > --- > drivers/therma

Re: [PATCH RESEND 07/11] thermal: update kernel-doc for thermal_zone_bind_cooling_device

2013-04-17 Thread Zhang Rui
On Wed, 2013-04-17 at 23:26 +0800, Zhang Rui wrote: > On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > > This patch updates the documentation for thermal_zone_bind_cooling_device > > and removes the warnings generated by scripts/kernel-doc -v. > > > > Sign

Re: [PATCH RESEND 07/11] thermal: update kernel-doc for thermal_zone_bind_cooling_device

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > This patch updates the documentation for thermal_zone_bind_cooling_device > and removes the warnings generated by scripts/kernel-doc -v. > > Signed-off-by: Eduardo Valentin > --- > drivers/thermal/thermal_sys.c | 16 +---

Re: [PATCH RESEND 11/11] thermal: update kernel-doc for thermal_zone_device_register

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > This patch updates the documentation for thermal_zone_device_register it is not enough. parameters including const struct thermal_zone_params *tzp, int passive_delay, and int polling_delay are missing in the documentation. thanks, rui >

Re: [PATCH RESEND 06/11] thermal: use EXPORT_SYMBOL_GPL

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > Restrict usage of GPL modules. > > Signed-off-by: Eduardo Valentin NACK for thermal_zone_trend_get/thermal_instance_get/thermal_cdev_update, for the reasons stated earlier. ACK for the others. thanks, rui > --- > drivers/thermal/ther

Re: [PATCH RESEND 05/11] thermal: rename get_tz_trend to thermal_zone_trend_get

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > To follow the prefix names used by the thermal exported functions, > this patch renames get_tz_trend to thermal_zone_trend_get. > > Signed-off-by: Eduardo Valentin NACK. get_tz_trend will not be exported as API any more. thanks, rui

Re: [PATCH RESEND 04/11] thermal: rename get_thermal_instance to thermal_instance_get

2013-04-17 Thread Zhang Rui
On Mon, 2013-04-08 at 12:07 -0400, Eduardo Valentin wrote: > To follow the prefix names used by the thermal exported functions, > this patch renames get_thermal_instance to thermal_instance_get. > > Signed-off-by: Eduardo Valentin NACK. with the change of building all thermal governors into the

Re: still in 3.9-rc6 - fan speed at 100% after suspend/resume regression

2013-04-15 Thread Zhang Rui
On Mon, 2013-04-15 at 09:30 -0400, Eduardo Valentin wrote: > On 13-04-2013 19:46, Ville Syrjälä wrote: > > On Sun, Apr 14, 2013 at 12:44:00AM +0300, Ville Syrjälä wrote: > >> On Sat, Apr 13, 2013 at 10:02:21AM -0600, Jake Edge wrote: > >>> Hi Zhang Rui, > >&g

Re: [PATCHv3 3/3] staging: ti-soc-thermal: remove external heat while extrapolating hotspot

2013-04-14 Thread Zhang Rui
On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: > For boards that provide a PCB sensor close to SoC junction > temperature, it is possible to remove the cumulative heat > reported by the SoC temperature sensor. > > This patch changes the extrapolation computation to consider > an extern

Re: [PATCHv3 2/3] thermal: expose thermal_zone_get_temp API

2013-04-14 Thread Zhang Rui
On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: > This patch exports the thermal_zone_get_temp API so that driver > writers can fetch temperature of thermal zones managed by other > drivers. > > Acked-by: Durgadoss R > Signed-off-by: Eduardo Valentin refreshed the patch to modify dri

Re: [PATCHv3 1/3] thermal: introduce thermal_zone_get_zone_by_name helper function

2013-04-14 Thread Zhang Rui
On Fri, 2013-04-05 at 08:32 -0400, Eduardo Valentin wrote: > This patch adds a helper function to get a reference of > a thermal zone, based on the zone type name. > > It will perform a zone name lookup and return a reference > to a thermal zone device that matches the name requested. > In case th

Re: [PATCH] Thermal: Don't resolve THERMAL_NO_LIMIT to max_state.

2013-04-11 Thread Zhang Rui
On Tue, 2013-03-26 at 21:29 +0800, Yuxuan Shui wrote: > max_state may change at runtime, for example, when loading/unloading > cpufreq policy. > this seems to be a problem that we have not covered yet. when loading/unloading the cpufreq policy, the cpufreq_frequency_table will be changed as well,

Re: [PATCH V2 1/3] Thermal: rename thermal_sys.c to thermal_core.c

2013-04-11 Thread Zhang Rui
On Thu, 2013-04-04 at 16:24 -0400, Eduardo Valentin wrote: > On 29-03-2013 10:26, Zhang Rui wrote: > > this is the preparation work to build all the thermal core framework > > source file, like governors, cpu cooling, etc, into one module. > > > > No functional change in

Re: [PATCH 14/30] thermal/exynos: remove unnecessary header inclusions

2013-04-11 Thread Zhang Rui
by only the exynos platform. Fortunately a number > > of drivers that include those headers do not actually need > > them, so we can just remove the inclusions. > > > > Signed-off-by: Arnd Bergmann > > Cc: linux...@vger.kernel.org > > Cc: Zhang Rui > > This patc

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-11 Thread Zhang Rui
On Wed, 2013-04-10 at 16:22 -0400, Eduardo Valentin wrote: > On 10-04-2013 03:06, Zhang Rui wrote: > > On Tue, 2013-04-09 at 14:59 -0700, Andrew Bresticker wrote: > >> When selecting a target cooling state in get_target_state(), make sure > >> that the state is at least

Re: [PATCH] thermal: step_wise: set throttle target within thermal instance limits

2013-04-10 Thread Zhang Rui
On Tue, 2013-04-09 at 14:59 -0700, Andrew Bresticker wrote: > When selecting a target cooling state in get_target_state(), make sure > that the state is at least as high as the minimum when the temperature > is rising and at least as low as the maximum when the temperature is > falling. This is ne

Re: [PATCH] thermal: exynos: fix handling of invalid frequency table entries

2013-04-09 Thread Zhang Rui
Hi, Andrew, can you please verify commit fc35b35cbe24ef021ea9acfba21e54da958df747 commit 57df8106932b57427df1eaaa13871857f75b1194 at http://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/log/?h=thermal fixes the problem for you? thanks, rui On Tue, 2013-04-09 at 14:59 -0700, Andrew

[PATCH V2 2/3] Thermal: build thermal governors into thermal_sys module

2013-03-29 Thread Zhang Rui
problem that the generic thermal layer does not work when CONFIG_THERMAL=m and CONFIG_THERMAL_GOV_XXX=y. Signed-off-by: Zhang Rui --- Documentation/thermal/sysfs-api.txt |8 - drivers/thermal/Makefile|6 ++-- drivers/thermal/fair_share.c| 15 ++--- drivers

[PATCH V2 1/3] Thermal: rename thermal_sys.c to thermal_core.c

2013-03-29 Thread Zhang Rui
this is the preparation work to build all the thermal core framework source file, like governors, cpu cooling, etc, into one module. No functional change in this patch. Signed-off-by: Zhang Rui --- drivers/thermal/Makefile |1 + drivers/thermal/{thermal_sys.c

[PATCH V2 3/3] Thermal: build cpu_cooling code into thermal_sys module

2013-03-29 Thread Zhang Rui
Signed-off-by: Zhang Rui --- drivers/thermal/Kconfig |2 +- drivers/thermal/Makefile|2 +- include/linux/cpu_cooling.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index a764f16..10014de 100644 --- a

[PATCH V2 0/3] Thermal: build all thermal framework code into thermal_sys module

2013-03-29 Thread Zhang Rui
A regression introduced by thermal governor feature is reported in http://marc.info/?l=linux-kernel&m=136085598604095&w=2 And the root cause is that all the thermal governors can not be registered successfully when the thermal framework is built as a module. Thus I made this patch set to build al

RE: [RFC PATCH 3/5] Thermal: build thermal governors into thermal_sys module

2013-03-26 Thread Zhang Rui
On Tue, 2013-03-26 at 10:53 -0600, R, Durgadoss wrote: > Hi Rui, > > > -Original Message- > > From: Zhang, Rui > > Sent: Tuesday, March 26, 2013 9:56 PM > > To: linux...@vger.kernel.org; linux-kernel@vger.kernel.org > > Cc: amit.dan...@samsung.com; R,

<    2   3   4   5   6   7   8   9   >