GFS2: Pull request (merge window)

2015-09-10 Thread Bob Peterson
Hi, Please consider pulling the following changes for the GFS2 file system. I apologize for the late request, but as I explained in my previous email, I wanted to make sure everything was done "the right way." Bo

GFS2: Pull request (merge window)

2015-09-10 Thread Bob Peterson
Hi, Please consider pulling the following changes for the GFS2 file system. I apologize for the late request, but as I explained in my previous email, I wanted to make sure everything was done "the right way." Bo

GFS2 pull request for this merge window delayed a couple days

2015-09-08 Thread Bob Peterson
l of them are pretty much confined to GFS2 (except for new calls to rhashtable functions) so hopefully this is just a formality. Sorry for the delay. Regards, Bob Peterson GFS2 Maintainer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

GFS2 pull request for this merge window delayed a couple days

2015-09-08 Thread Bob Peterson
l of them are pretty much confined to GFS2 (except for new calls to rhashtable functions) so hopefully this is just a formality. Sorry for the delay. Regards, Bob Peterson GFS2 Maintainer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

2015-09-07 Thread Bob Liu
On 09/07/2015 07:10 PM, Julien Grall wrote: > On 07/09/15 07:07, Bob Liu wrote: >> Hi Julien, > > Hi Bob, > >> On 09/04/2015 09:51 PM, Julien Grall wrote: >>> Hi Roger, >>> >>> On 04/09/15 11:08, Roger Pau Monne wrote: >>>> Req

Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

2015-09-07 Thread Bob Liu
oris Ostrovsky >> Cc: David Vrabel >> Cc: xen-de...@lists.xenproject.org > > The patch is fixing my problem when using UEFI in the guest. Thank you! > Could you please explain the problem you met a bit more? So that I can know back port this patch if met similar issue. Th

Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

2015-09-07 Thread Bob Liu
my problem when using UEFI in the guest. Thank you! > Could you please explain the problem you met a bit more? So that I can know back port this patch if met similar issue. Thanks, -Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

2015-09-07 Thread Bob Liu
On 09/07/2015 07:10 PM, Julien Grall wrote: > On 07/09/15 07:07, Bob Liu wrote: >> Hi Julien, > > Hi Bob, > >> On 09/04/2015 09:51 PM, Julien Grall wrote: >>> Hi Roger, >>> >>> On 04/09/15 11:08, Roger Pau Monne wrote: >>>> Req

[PATCH v3 8/9] xen/blkback: pseudo support for multi hardware queues/rings

2015-09-05 Thread Bob Liu
Prepare patch for multi hardware queues/rings, the ring number was set to 1 by force. Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen-blkback/common.h |3 +- drivers/block/xen-blkback/xenbus.c | 328 +++- 2 files changed, 209

[PATCH v3 7/9] xen/blkback: separate ring information out of struct xen_blkif

2015-09-05 Thread Bob Liu
Split per ring information to an new structure:xen_blkif_ring, so that one vbd device can associate with one or more rings/hardware queues. This patch is a preparation for supporting multi hardware queues/rings. Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen

[PATCH v3 6/9] xen/blkfront: negotiate the number of hw queues/rings with backend

2015-09-05 Thread Bob Liu
ueues". Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 142 -- 1 file changed, 108 insertions(+), 34 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 1cae76b..1aa66c9 100644 --- a/drivers/block/

[PATCH v3 9/9] xen/blkback: get number of hardware queues/rings from blkfront

2015-09-05 Thread Bob Liu
Backend advertises "multi-queue-max-queues" to front, and then read back the final negotiated queues/rings from "multi-queue-num-queues" which is wrote by blkfront. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c |8 drivers/block/xen-blkb

[PATCH v3 5/9] xen/blkfront: convert per device io_lock to per ring ring_lock

2015-09-05 Thread Bob Liu
The per device io_lock became a coarser grained lock after multi-queues/rings was introduced, this patch converts it to a fine-grained per ring lock. NOTE: The per dev_info structure was no more protected by any lock. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 44

[PATCH v3 4/9] xen/blkfront: pseudo support for multi hardware queues/rings

2015-09-05 Thread Bob Liu
ter. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 513 +- 1 file changed, 308 insertions(+), 205 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index bf416d5..bf45c99 100644 --- a/drivers/block/

[PATCH v3 3/9] xen/blkfront: separate per ring information out of device info

2015-09-05 Thread Bob Liu
. This patch is a preparation for supporting real multi hardware queues/rings. Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 854 ++ 1 file changed, 445 insertions(+), 409 deletions(-) diff --git a/drivers/block/xen

[PATCH v3 1/9] xen-blkfront: convert to blk-mq APIs

2015-09-05 Thread Bob Liu
, and nvme. Also dropped one unnecessary holding of info->io_lock when calling blk_mq_stop_hw_queues(). Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu Reviewed-by: Christoph Hellwig Acked-by: Jens Axboe Signed-off-by: David Vrabel --- drivers/block/xen-blkfront.c |

[PATCH v3 2/9] xen-block: add document for mutli hardware queues/rings

2015-09-05 Thread Bob Liu
Document multi queues/rings of xen-block. Signed-off-by: Bob Liu --- include/xen/interface/io/blkif.h | 32 1 file changed, 32 insertions(+) diff --git a/include/xen/interface/io/blkif.h b/include/xen/interface/io/blkif.h index c33e1c4..b453b70 100644

[PATCH v3 0/9] xen-block: support multi hardware-queues/rings

2015-09-05 Thread Bob Liu
ps: 1310k279k810k(+200%) 871k 1000k Only with 4queues, iops for domU get improved a lot and nearly catch up with dom0. There were also similar huge improvement for write and real SSD storage. --- v3: Rebased to v4.2-rc8 Bob Liu (9): xen-blkfront: convert to blk-mq

[PATCH v3 6/9] xen/blkfront: negotiate the number of hw queues/rings with backend

2015-09-05 Thread Bob Liu
ueues". Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 142 -- 1 file changed, 108 insertions(+), 34 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 1cae76b..1aa66c9 1006

[PATCH v3 9/9] xen/blkback: get number of hardware queues/rings from blkfront

2015-09-05 Thread Bob Liu
Backend advertises "multi-queue-max-queues" to front, and then read back the final negotiated queues/rings from "multi-queue-num-queues" which is wrote by blkfront. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/blkback.c |8

[PATCH v3 5/9] xen/blkfront: convert per device io_lock to per ring ring_lock

2015-09-05 Thread Bob Liu
The per device io_lock became a coarser grained lock after multi-queues/rings was introduced, this patch converts it to a fine-grained per ring lock. NOTE: The per dev_info structure was no more protected by any lock. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkf

[PATCH v3 4/9] xen/blkfront: pseudo support for multi hardware queues/rings

2015-09-05 Thread Bob Liu
ter. Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 513 +- 1 file changed, 308 insertions(+), 205 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index bf416d5..bf45c

[PATCH v3 3/9] xen/blkfront: separate per ring information out of device info

2015-09-05 Thread Bob Liu
. This patch is a preparation for supporting real multi hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkfront.c | 854 ++ 1 file changed, 44

[PATCH v3 7/9] xen/blkback: separate ring information out of struct xen_blkif

2015-09-05 Thread Bob Liu
Split per ring information to an new structure:xen_blkif_ring, so that one vbd device can associate with one or more rings/hardware queues. This patch is a preparation for supporting multi hardware queues/rings. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: B

[PATCH v3 8/9] xen/blkback: pseudo support for multi hardware queues/rings

2015-09-05 Thread Bob Liu
Prepare patch for multi hardware queues/rings, the ring number was set to 1 by force. Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> --- drivers/block/xen-blkback/common.h |3 +- drivers/block/xen-blkback/xen

[PATCH v3 1/9] xen-blkfront: convert to blk-mq APIs

2015-09-05 Thread Bob Liu
, and nvme. Also dropped one unnecessary holding of info->io_lock when calling blk_mq_stop_hw_queues(). Signed-off-by: Arianna Avanzini <avanzini.aria...@gmail.com> Signed-off-by: Bob Liu <bob@oracle.com> Reviewed-by: Christoph Hellwig <h...@lst.de> Acked-by: Jens Axboe <

[PATCH v3 2/9] xen-block: add document for mutli hardware queues/rings

2015-09-05 Thread Bob Liu
Document multi queues/rings of xen-block. Signed-off-by: Bob Liu <bob@oracle.com> --- include/xen/interface/io/blkif.h | 32 1 file changed, 32 insertions(+) diff --git a/include/xen/interface/io/blkif.h b/include/xen/interface/io/blkif.h index c

[PATCH v3 0/9] xen-block: support multi hardware-queues/rings

2015-09-05 Thread Bob Liu
ps: 1310k279k810k(+200%) 871k 1000k Only with 4queues, iops for domU get improved a lot and nearly catch up with dom0. There were also similar huge improvement for write and real SSD storage. --- v3: Rebased to v4.2-rc8 Bob Liu (9): xen-blkfront: convert to blk-mq

Re: [PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-08-24 Thread Bob Liu
Hi Rafal, Please have a try adding "--iodepth_batch=32 --iodepth_batch_complete=32" to the fio command line. I didn't see this issue any more, neither for domU. Thanks, -Bob On 08/21/2015 04:46 PM, Rafal Mielniczuk wrote: > On 19/08/15 12:12, Bob Liu wrote: >> Hi Jens &

Re: [PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-08-24 Thread Bob Liu
Hi Rafal, Please have a try adding --iodepth_batch=32 --iodepth_batch_complete=32 to the fio command line. I didn't see this issue any more, neither for domU. Thanks, -Bob On 08/21/2015 04:46 PM, Rafal Mielniczuk wrote: On 19/08/15 12:12, Bob Liu wrote: Hi Jens Christoph, Rafal reported

Re: [PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-08-19 Thread Bob Liu
s, mint=30002msec, maxt=30002msec Disk stats (read/write): xvdb: ios=734048/0, merge=0/0, ticks=843584/0, in_queue=843080, util=99.72% Regards, -Bob On 07/13/2015 05:55 PM, Bob Liu wrote: > Note: This patch is based on original work of Arianna's internship for > GNOME's Outreach Program for

Re: [PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-08-19 Thread Bob Liu
=30002msec Disk stats (read/write): xvdb: ios=734048/0, merge=0/0, ticks=843584/0, in_queue=843080, util=99.72% Regards, -Bob On 07/13/2015 05:55 PM, Bob Liu wrote: Note: This patch is based on original work of Arianna's internship for GNOME's Outreach Program for Women. Only one hardware queue

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-14 Thread Bob Liu
On 08/13/2015 12:46 AM, Rafal Mielniczuk wrote: > On 12/08/15 11:17, Bob Liu wrote: >> On 08/12/2015 01:32 AM, Jens Axboe wrote: >>> On 08/11/2015 03:45 AM, Rafal Mielniczuk wrote: >>>> On 11/08/15 07:08, Bob Liu wrote: >>>>> On 08/10/2015 11:52 PM, Je

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-14 Thread Bob Liu
On 08/13/2015 12:46 AM, Rafal Mielniczuk wrote: On 12/08/15 11:17, Bob Liu wrote: On 08/12/2015 01:32 AM, Jens Axboe wrote: On 08/11/2015 03:45 AM, Rafal Mielniczuk wrote: On 11/08/15 07:08, Bob Liu wrote: On 08/10/2015 11:52 PM, Jens Axboe wrote: On 08/10/2015 05:03 AM, Rafal Mielniczuk

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-12 Thread Bob Liu
On 08/12/2015 01:32 AM, Jens Axboe wrote: > On 08/11/2015 03:45 AM, Rafal Mielniczuk wrote: >> On 11/08/15 07:08, Bob Liu wrote: >>> On 08/10/2015 11:52 PM, Jens Axboe wrote: >>>> On 08/10/2015 05:03 AM, Rafal Mielniczuk wrote: ... >>>>> Hello, >&g

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-12 Thread Bob Liu
On 08/12/2015 01:32 AM, Jens Axboe wrote: On 08/11/2015 03:45 AM, Rafal Mielniczuk wrote: On 11/08/15 07:08, Bob Liu wrote: On 08/10/2015 11:52 PM, Jens Axboe wrote: On 08/10/2015 05:03 AM, Rafal Mielniczuk wrote: ... Hello, We rerun the tests for sequential reads with the identical

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-11 Thread Bob Liu
ops was better than single queue iops for all the block sizes. >>>> There were very good improvements as well for sequential writes with >>>> block size 4K (from 80K iops with single queue to 230K iops with 8 >>>> queues), and no regressions were visible in any measu

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-11 Thread Bob Liu
to this again. Personally I'd be really interested in the results for the same set of tests, but without the blk-mq patches. Do you have them, or could you potentially run them? Hello, We rerun the tests for sequential reads with the identical settings but with Bob Liu's multiqueue patches reverted

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-10 Thread Bob Liu
;> queues), and no regressions were visible in any measurement performed. >> Great results! And I don't know why this code has lingered for so long, >> so thanks for helping get some attention to this again. >> >> Personally I'd be really interested in the results fo

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-08-10 Thread Bob Liu
in the results for the same set of tests, but without the blk-mq patches. Do you have them, or could you potentially run them? Hello, We rerun the tests for sequential reads with the identical settings but with Bob Liu's multiqueue patches reverted from dom0 and guest kernels. The results we

Re: [PATCH 24/31] fs/omfs: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Bob Copeland
On Fri, Aug 07, 2015 at 09:59:30AM +0200, Andrzej Hajda wrote: > The patch was generated using fixed coccinelle semantic patch > scripts/coccinelle/api/memdup.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320 > > Signed-off-by: Andrzej Hajda Thank

Re: [PATCH 24/31] fs/omfs: use kmemdup rather than duplicating its implementation

2015-08-07 Thread Bob Copeland
-by: Bob Copeland m...@bobcopeland.com -- Bob Copeland %% http://bobcopeland.com/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH v2 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-22 Thread Bob Liu
descriptors and flush/barrier features to a separate function and call it from both blkfront_connect and blkif_recover Signed-off-by: Bob Liu --- Changes in v2: * Also put blkfront_setup_indirect() inside --- drivers/block/xen-blkfront.c | 122 +++--- 1 file

[PATCH v2] xen-blkback: replace work_pending with work_busy in purge_persistent_gnt()

2015-07-22 Thread Bob Liu
The BUG_ON() in purge_persistent_gnt() will be triggered when previous purge work haven't finished. There is a work_pending() before this BUG_ON, but it doesn't account if the work is still currently running. Signed-off-by: Bob Liu --- Change in v2: * Replace with work_busy() --- drivers/block

[PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent

2015-07-22 Thread Bob Liu
We should consider info->feature_persistent when adding indriect page to list info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v2 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-22 Thread Bob Liu
descriptors and flush/barrier features to a separate function and call it from both blkfront_connect and blkif_recover Signed-off-by: Bob Liu bob@oracle.com --- Changes in v2: * Also put blkfront_setup_indirect() inside --- drivers/block/xen-blkfront.c | 122

[PATCH v2 2/3] xen-blkfront: don't add indirect pages to list when !feature_persistent

2015-07-22 Thread Bob Liu
We should consider info-feature_persistent when adding indriect page to list info-indirect_pages, else the BUG_ON() in blkif_free() would be triggered. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v2] xen-blkback: replace work_pending with work_busy in purge_persistent_gnt()

2015-07-22 Thread Bob Liu
The BUG_ON() in purge_persistent_gnt() will be triggered when previous purge work haven't finished. There is a work_pending() before this BUG_ON, but it doesn't account if the work is still currently running. Signed-off-by: Bob Liu bob@oracle.com --- Change in v2: * Replace with work_busy

Re: [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/22/2015 12:43 PM, Bob Liu wrote: > > On 07/21/2015 05:25 PM, Roger Pau Monné wrote: >> El 21/07/15 a les 5.30, Bob Liu ha escrit: >>> This BUG_ON() in blkif_free() is incorrect, because indirect page can be >>> added >>> to list info->indi

Re: [PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/21/2015 05:25 PM, Roger Pau Monné wrote: > El 21/07/15 a les 5.30, Bob Liu ha escrit: >> This BUG_ON() in blkif_free() is incorrect, because indirect page can be >> added >> to list info->indirect_pages in blkif_completion() no matter >> feature_

Re: [PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-21 Thread Bob Liu
On 07/21/2015 05:13 PM, Roger Pau Monné wrote: > El 21/07/15 a les 5.30, Bob Liu ha escrit: >> This BUG_ON() will be triggered when previous purge work haven't finished. >> It's reasonable under pretty extreme load and should not panic the system. >> >> Signed-off-by:

Re: [PATCH 2/3] xen-blkfront: rm BUG_ON(info-feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/22/2015 12:43 PM, Bob Liu wrote: On 07/21/2015 05:25 PM, Roger Pau Monné wrote: El 21/07/15 a les 5.30, Bob Liu ha escrit: This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info-indirect_pages in blkif_completion() no matter feature_persistent

Re: [PATCH 2/3] xen-blkfront: rm BUG_ON(info-feature_persistent) in blkif_free

2015-07-21 Thread Bob Liu
On 07/21/2015 05:25 PM, Roger Pau Monné wrote: El 21/07/15 a les 5.30, Bob Liu ha escrit: This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info-indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob

Re: [PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-21 Thread Bob Liu
On 07/21/2015 05:13 PM, Roger Pau Monné wrote: El 21/07/15 a les 5.30, Bob Liu ha escrit: This BUG_ON() will be triggered when previous purge work haven't finished. It's reasonable under pretty extreme load and should not panic the system. Signed-off-by: Bob Liu bob@oracle.com

[PATCH 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-20 Thread Bob Liu
descriptors and flush/barrier features to a separate function and call it from both blkfront_connect and blkif_recover Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 118 +++--- 1 file changed, 66 insertions(+), 52 deletions(-) diff --git a/drivers/block

[PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-20 Thread Bob Liu
This BUG_ON() will be triggered when previous purge work haven't finished. It's reasonable under pretty extreme load and should not panic the system. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/3] xen-blkfront: rm BUG_ON(info->feature_persistent) in blkif_free

2015-07-20 Thread Bob Liu
This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info->indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c |1 - 1 file changed, 1 deletion(-) diff --git a/driv

[PATCH 3/3] xen-blkback: rm BUG_ON() in purge_persistent_gnt()

2015-07-20 Thread Bob Liu
This BUG_ON() will be triggered when previous purge work haven't finished. It's reasonable under pretty extreme load and should not panic the system. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 2/3] xen-blkfront: rm BUG_ON(info-feature_persistent) in blkif_free

2015-07-20 Thread Bob Liu
This BUG_ON() in blkif_free() is incorrect, because indirect page can be added to list info-indirect_pages in blkif_completion() no matter feature_persistent is true or false. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c |1 - 1 file changed, 1 deletion(-) diff

[PATCH 1/3] xen-blkfront: introduce blkfront_gather_backend_features()

2015-07-20 Thread Bob Liu
descriptors and flush/barrier features to a separate function and call it from both blkfront_connect and blkif_recover Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c | 118 +++--- 1 file changed, 66 insertions(+), 52 deletions(-) diff --git

Re: [PATCH linux-gfs2] GFS2: ht_parms can be static

2015-07-14 Thread Bob Peterson
S2_GL_HASH_SIZE * 3 / 4, > .key_len = sizeof(struct lm_lockname), > .key_offset = offsetof(struct gfs2_glock, gl_name), > Hi, Thanks. Now pushed to the for-next branch of the linux-gfs2 tree. Regards, Bob Peterson Red Hat File Systems -- To unsubscribe from this list:

Re: [PATCH linux-gfs2] GFS2: ht_parms can be static

2015-07-14 Thread Bob Peterson
(struct lm_lockname), .key_offset = offsetof(struct gfs2_glock, gl_name), Hi, Thanks. Now pushed to the for-next branch of the linux-gfs2 tree. Regards, Bob Peterson Red Hat File Systems -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-07-13 Thread Bob Liu
dropped one unnecessary holding of info->io_lock when calling blk_mq_stop_hw_queues(). Changes in v2: - Reorganized blk_mq_queue_rq() - Restored most io_locks in place Change in v3: - Rename blk_mq_queue_rq to blkif_queue_rq Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu Revie

[PATCH v3] xen/blkfront: convert to blk-mq APIs

2015-07-13 Thread Bob Liu
-by: Bob Liu bob@oracle.com Reviewed-by: Christoph Hellwig h...@lst.de Acked-by: Jens Axboe ax...@fb.com --- drivers/block/xen-blkfront.c | 146 +- 1 file changed, 60 insertions(+), 86 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block

Re: [PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/12/2015 02:14 AM, Jens Axboe wrote: > On 07/11/2015 07:30 AM, Bob Liu wrote: >> Note: This patch is based on original work of Arianna's internship for >> GNOME's Outreach Program for Women. > > Great to see this finally get prepped to go in! > >> Only one

[PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
dropped one unnecessary holding of info->io_lock when calling blk_mq_stop_hw_queues(). Changes in v2: - Reorganized blk_mq_queue_rq() - Restored most io_locks in place Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c |

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/11/2015 03:57 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: >> From: Arianna Avanzini >> >> This patch converts xen-blkfront driver to use the block multiqueue APIs. >> Only one hardware queue is used now, so the

Re: [RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/11/2015 03:57 AM, Konrad Rzeszutek Wilk wrote: On Mon, Jul 06, 2015 at 05:56:48PM +0800, Bob Liu wrote: From: Arianna Avanzini avanzini.aria...@gmail.com This patch converts xen-blkfront driver to use the block multiqueue APIs. Only one hardware queue is used now, so

[PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
dropped one unnecessary holding of info-io_lock when calling blk_mq_stop_hw_queues(). Changes in v2: - Reorganized blk_mq_queue_rq() - Restored most io_locks in place Signed-off-by: Arianna Avanzini avanzini.aria...@gmail.com Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen

Re: [PATCH v2] xen/blkfront: convert to blk-mq APIs

2015-07-11 Thread Bob Liu
On 07/12/2015 02:14 AM, Jens Axboe wrote: On 07/11/2015 07:30 AM, Bob Liu wrote: Note: This patch is based on original work of Arianna's internship for GNOME's Outreach Program for Women. Great to see this finally get prepped to go in! Only one hardware queue is used now, so

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Bob Liu
t; Signed-off-by: Julien Grall Also hit the same issue, thank you for the fix. Tested-by: Bob Liu > Cc: Bernhard Thaler > Cc: Pablo Neira Ayuso > Cc: f...@strlen.de > Cc: ian.campb...@citrix.com > Cc: wei.l...@citrix.com > > --- > Note that it's impossible to crea

[RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-06 Thread Bob Liu
unnecessary holding of info->io_lock when calling into blk-mq APIs. Signed-off-by: Arianna Avanzini Signed-off-by: Bob Liu --- drivers/block/xen-blkfront.c | 173 ++ 1 file changed, 73 insertions(+), 100 deletions(-) diff --git a/drivers/block/

[RESEND PATCH] xen/blkfront: convert to blk-mq APIs

2015-07-06 Thread Bob Liu
, and nvme. Also dropped unnecessary holding of info-io_lock when calling into blk-mq APIs. Signed-off-by: Arianna Avanzini avanzini.aria...@gmail.com Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkfront.c | 173 ++ 1 file changed, 73

Re: [Xen-devel] [PATCH] net/bridge: Add missing in6_dev_put in br_validate_ipv6

2015-07-06 Thread Bob Liu
issue, thank you for the fix. Tested-by: Bob Liu bob@oracle.com Cc: Bernhard Thaler bernhard.tha...@wvnet.at Cc: Pablo Neira Ayuso pa...@netfilter.org Cc: f...@strlen.de Cc: ian.campb...@citrix.com Cc: wei.l...@citrix.com --- Note that it's impossible to create new guest after

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-06-30 Thread Bob Liu
On 06/30/2015 10:21 PM, Marcus Granado wrote: > On 13/05/15 11:29, Bob Liu wrote: >> >> On 04/28/2015 03:46 PM, Arianna Avanzini wrote: >>> Hello Christoph, >>> >>> Il 28/04/2015 09:36, Christoph Hellwig ha scritto: >>>> What happened to t

Re: [Xen-devel] [PATCH RFC v2 0/5] Multi-queue support for xen-blkfront and xen-blkback

2015-06-30 Thread Bob Liu
On 06/30/2015 10:21 PM, Marcus Granado wrote: On 13/05/15 11:29, Bob Liu wrote: On 04/28/2015 03:46 PM, Arianna Avanzini wrote: Hello Christoph, Il 28/04/2015 09:36, Christoph Hellwig ha scritto: What happened to this patchset? It was passed on to Bob Liu, who published a follow-up

GFS2: Pull request (merge window)

2015-06-26 Thread Bob Peterson
Hi, Please consider pulling the following changes for the GFS2 file system. Regards, Bob Peterson The following changes since commit f4a3ae9308e34bcd704325a08879b2c1cfb74686: GFS2: Use average srttb value in congestion

GFS2: Pull request (merge window)

2015-06-26 Thread Bob Peterson
Hi, Please consider pulling the following changes for the GFS2 file system. Regards, Bob Peterson The following changes since commit f4a3ae9308e34bcd704325a08879b2c1cfb74686: GFS2: Use average srttb value in congestion

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-21 Thread Bob Liu
ches or not. > Hey, Are there any updates? What's the performance regression problem? Thanks, -Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-21 Thread Bob Liu
regression on some of their tests. I'm adding them to the conversation so they can provide more details about the issues they found, and whether we should hold pushing this patches or not. Hey, Are there any updates? What's the performance regression problem? Thanks, -Bob -- To unsubscribe

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread Bob Peterson
- Original Message - > Bob Peterson wrote: > > - Original Message - > > > >> Hi Bob, > >> > >> Bob Peterson wrote: > >> > >>> - Original Message - > >>> > >>&

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-10 Thread Bob Peterson
- Original Message - Bob Peterson wrote: - Original Message - Hi Bob, Bob Peterson wrote: - Original Message - We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang gqji...@suse.com

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Bob Peterson
- Original Message - > Hi Bob, > > Bob Peterson wrote: > > - Original Message - > > > >> We don't need the redundant logic since send_message always returns 0. > >> > >> Signed-off-by: Guoqing Jiang > >> --- &g

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/09/2015 09:39 PM, Konrad Rzeszutek Wilk wrote: > On Tue, Jun 09, 2015 at 08:52:53AM +, Paul Durrant wrote: >>> -Original Message- >>> From: Bob Liu [mailto:bob@oracle.com] >>> Sent: 09 June 2015 09:50 >>> To: Bob Liu >>>

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Bob Peterson
ks okay, but if remove_from_waiters() always returns 0, wouldn't it be better to change the function from int to void and return 0 here? The advantage is that code spelunkers wouldn't need to back-track one more level (not to mention the instruction or two it might save). Regards, Bob Peterson Red

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/03/2015 01:40 PM, Bob Liu wrote: > Extend xen/block to support multi-page ring, so that more requests can be > issued by using more than one pages as the request ring between blkfront > and backend. > As a result, the performance can get improved significantly. > > We g

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/03/2015 01:40 PM, Bob Liu wrote: Extend xen/block to support multi-page ring, so that more requests can be issued by using more than one pages as the request ring between blkfront and backend. As a result, the performance can get improved significantly. We got some impressive

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Bob Peterson
? The advantage is that code spelunkers wouldn't need to back-track one more level (not to mention the instruction or two it might save). Regards, Bob Peterson Red Hat File Systems -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check

2015-06-09 Thread Bob Peterson
- Original Message - Hi Bob, Bob Peterson wrote: - Original Message - We don't need the redundant logic since send_message always returns 0. Signed-off-by: Guoqing Jiang gqji...@suse.com --- fs/dlm/lock.c | 10 ++ 1 file changed, 2 insertions(+), 8

Re: [PATCH 3/3] xen/block: add multi-page ring support

2015-06-09 Thread Bob Liu
On 06/09/2015 09:39 PM, Konrad Rzeszutek Wilk wrote: On Tue, Jun 09, 2015 at 08:52:53AM +, Paul Durrant wrote: -Original Message- From: Bob Liu [mailto:bob@oracle.com] Sent: 09 June 2015 09:50 To: Bob Liu Cc: xen-de...@lists.xen.org; David Vrabel; just...@spectralogic.com

[PATCH 3/3] xen/block: add multi-page ring support

2015-06-02 Thread Bob Liu
in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Changes in v5: - Clarify with 4k granularity to comment - Address more comments from Roger Signed-off-by: Bob Liu --- drivers/block/xen-blkback/blkback.c | 13 drivers/block/xen-blkback

[PATCH 1/3] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-02 Thread Bob Liu
This is a pre-patch for multi-page ring feature. In connect_ring, we can know exactly how many pages are used for the shared ring, delay pending_req allocation here so that we won't waste too much memory. Signed-off-by: Bob Liu --- drivers/block/xen-blkback/common.h |2 +- drivers/block/xen

[PATCH 2/3] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-06-02 Thread Bob Liu
and furthermore it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu Acked-by: Roger Pau Monné --- drivers/block/xen-blkfront.c | 14 ++ 1 file changed, 6 insertions(+), 8

[PATCH 2/3] driver: xen-blkfront: move talk_to_blkback to a more suitable place

2015-06-02 Thread Bob Liu
and furthermore it would not allow frontend/backend to negotiate 'multi-page' and 'multi-queue' features. Changes in v2: - Re-write the commit message to be more clear. Signed-off-by: Bob Liu bob@oracle.com Acked-by: Roger Pau Monné roger@citrix.com --- drivers/block/xen-blkfront.c | 14

[PATCH 3/3] xen/block: add multi-page ring support

2015-06-02 Thread Bob Liu
in v4: - Turn to use 'ring-page-order' and 'max-ring-page-order'. - A few comments from Roger. Changes in v5: - Clarify with 4k granularity to comment - Address more comments from Roger Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/blkback.c | 13 drivers

[PATCH 1/3] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-02 Thread Bob Liu
This is a pre-patch for multi-page ring feature. In connect_ring, we can know exactly how many pages are used for the shared ring, delay pending_req allocation here so that we won't waste too much memory. Signed-off-by: Bob Liu bob@oracle.com --- drivers/block/xen-blkback/common.h |2

Re: [PATCH] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-01 Thread Bob Liu
On 06/01/2015 04:36 PM, Roger Pau Monné wrote: > El 26/05/15 a les 2.06, Bob Liu ha escrit: >> In connect_ring, we can know exactly how many pages are used for the shared >> ring and also whether feature-persistent is enabled, delay pending_req >> allocation here so that we

Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent

2015-06-01 Thread Bob Liu
On 06/01/2015 03:50 PM, Roger Pau Monné wrote: > El 26/05/15 a les 2.11, Bob Liu ha escrit: >> When migrate from !feature-persistent host to feature-persistent host, domU >> still think new host/backend don't support persistent. >> Dmesg like: >> backed has not unmapp

Re: [PATCH] drivers: xen-blkback: delay pending_req allocation to connect_ring

2015-06-01 Thread Bob Liu
On 06/01/2015 04:36 PM, Roger Pau Monné wrote: El 26/05/15 a les 2.06, Bob Liu ha escrit: In connect_ring, we can know exactly how many pages are used for the shared ring and also whether feature-persistent is enabled, delay pending_req allocation here so that we won't waste too much memory

Re: [PATCH] drivers: xen-blkfront: blkif_recover: recheck feature-persistent

2015-06-01 Thread Bob Liu
On 06/01/2015 03:50 PM, Roger Pau Monné wrote: El 26/05/15 a les 2.11, Bob Liu ha escrit: When migrate from !feature-persistent host to feature-persistent host, domU still think new host/backend don't support persistent. Dmesg like: backed has not unmapped grant: 839 backed has not unmapped

<    1   2   3   4   5   6   7   8   9   10   >