Re: [PATCH v12 01/19] input: cyapa: modify code to following kernel code style

Dudley, Jeremiah, On Thu, Dec 04, 2014 at 05:54:43AM +, Dudley Du wrote: Jeremiah, I didn't submitted this fix patch, but Dmitry has been helping apply the fix patch quickly, maybe todoay or tommorrow. The patches that I apply for the next merge window should appear first in my 'next'

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

Hi Philip, On Thu, Jun 11, 2015 at 08:10:07PM +, Philip Moltmann wrote: Hi, sorry for taking so long to address your concerns. What happens if you run this new driver on an older hypervisor that does not support batched operations? When the driver starts or when it gets reset

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

On Fri, Jun 12, 2015 at 03:40:42PM +, Philip Moltmann wrote: Hi, Three improvements contribute to the overall faster speed: - batched operations reduce the hypervisor overhead per page - 2m instead of 4k buffer reduce the hypervisor overhead per page - removing the

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

On Fri, Jun 12, 2015 at 03:06:56PM +, Philip Moltmann wrote: Hi, thanks for taking so much interest in this driver. It is quite good that our design choices get scrutinized by non-current VMware employees. I understand that you negotiate the capabilities between hypervisor and

Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

On Wed, Aug 05, 2015 at 08:22:35PM +, Philip Moltmann wrote: Hi, MODULE_AUTHOR(VMware, Inc.); MODULE_DESCRIPTION(VMware Memory Control (Balloon) Driver); -MODULE_VERSION(1.3.2.0-k); +MODULE_VERSION(1.3.3.0-k); This constant change of module version is annoying, is it

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Nick, On Mon, Mar 06, 2017 at 03:59:00PM +, Nick Fletcher wrote: > HI, > > I installed the two drivers as requested. Results of dmesg | grep > 'two-finger' below.. Could you please also tell us whether the devoice only has touchpad, or if it has touchpad/starckstick combo? Thanks. --

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Masaki, On Tue, Mar 07, 2017 at 08:40:20AM +, Masaki Ota wrote: > Hi, Paul, > > I have modified the source code. > > There are three issues. > #1. E7=73 03 28 Button pad device is not assigned "ALPS_BUTTONPAD" Flag > correctly. > #2. E7=73 03 28 devices are not assigned "

Re: [PATCH] Input: i8042: add a check in i8042_interrupt

+ if (likely(port->exists && !filtered && serio)) I do not think we need to check port->exists here, just checking serio should be enough. Also, please check Documentation/SubmittingPatches when submitting patches in the future. I believe we want the version of the pa

Re: [PATCH] add SERIO_WIPO

Hi Michael, On Fri, Sep 08, 2017 at 11:43:42AM +, Graichen Michael wrote: > From d4122cfe5f177198ae80d0c973eb29559c762fd3 Mon Sep 17 00:00:00 2001 > From: dev > Date: Fri, 8 Sep 2017 13:21:32 +0200 > Subject: [PATCH] add SERIO_WIPO > > --- >

Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices

> > Best Regards, > Masaki Ota > -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Wednesday, November 15, 2017 5:35 PM > To: 太田 真喜 Masaki Ota <masaki@jp.alps.com> > Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; >

Re: [PATCH V2 6/8] input: stpmic1: add stpmic1 onkey driver

Hi Pascal, On Fri, Sep 07, 2018 at 12:59:45PM +, Pascal PAILLET-LME wrote: > From: pascal paillet > > The stpmic1 pmic is able to manage an onkey button. This driver exposes > the stpmic1 onkey as an input device. It can also be configured to > shut-down the power supplies on a long

Re: [PATCH v3 6/8] input: stpmic1: add stpmic1 onkey driver

Hi Pascal, On Mon, Oct 08, 2018 at 04:29:41PM +, Pascal PAILLET-LME wrote: > From: pascal paillet > > The stpmic1 pmic is able to manage an onkey button. This driver exposes > the stpmic1 onkey as an input device. It can also be configured to > shut-down the power supplies on a long

Re: [PATCH v4 6/8] input: stpmic1: add stpmic1 onkey driver

On Thu, Oct 18, 2018 at 09:02:13AM +, Pascal PAILLET-LME wrote: > From: pascal paillet > > The stpmic1 pmic is able to manage an onkey button. This driver exposes > the stpmic1 onkey as an input device. It can also be configured to > shut-down the power supplies on a long key-press with an

Re: [PATCH] add SERIO_WIPO

Hi Michael, On Fri, Sep 08, 2017 at 11:43:42AM +, Graichen Michael wrote: > From d4122cfe5f177198ae80d0c973eb29559c762fd3 Mon Sep 17 00:00:00 2001 > From: dev > Date: Fri, 8 Sep 2017 13:21:32 +0200 > Subject: [PATCH] add SERIO_WIPO > > --- > include/uapi/linux/serio.h | 3 ++- > 1 file

Re: [PATCH] Input: i8042: add a check in i8042_interrupt

Hi, On Sat, Jun 24, 2017 at 09:38:48AM +, chenhong (N) wrote: > Description of problem: > > Encounterd BUG case: > serio: i8042 KBD port at 0x60,0x64 irq 1 > BUG: unable to handle kernel NULL pointer dereference at 0050 > IP: [] _spin_lock_irqsave+0x1f/0x40 > PGD 0 > Oops: 0002

Re: [PATCH] FROMLIST: input: add 2 kind of switch

On Wed, Oct 21, 2020 at 07:10:35AM +0200, gre...@linuxfoundation.org wrote: > On Wed, Oct 21, 2020 at 12:12:16PM +0900, HyungJae Im wrote: > > >From ec9859ee01b7bc0e04255971e0fe97348847dab7 Mon Sep 17 00:00:00 2001 > > You sent this 3 times, why? > > And why is this in the body of the email,

Re: [PATCH] Input: hyperv-keyboard: Use in-place iterator API in the channel callback

On Tue, Aug 20, 2019 at 03:01:23AM +, Dexuan Cui wrote: > Simplify the ring buffer handling with the in-place API. > > Also avoid the dynamic allocation and the memory leak in the channel > callback function. > > Signed-off-by: Dexuan Cui > --- > > Hi Dmitry, can this patch go through

Re: [PATCH v3 00/12] add IRQF_NO_AUTOEN for request_irq

On Wed, Jan 27, 2021 at 02:49:21PM +0100, gre...@linuxfoundation.org wrote: > On Thu, Jan 21, 2021 at 09:38:28PM +, Song Bao Hua (Barry Song) wrote: > > Hi Thomas, Greg, Dmitry, Marc, > > Any further comment on this new API? > > It's not my subsystem, I'll let the irq maintainers handle it

Re: [PATCH] Input: ALPS - fix DualPoint flag for 74 03 28 devices

> > Best Regards, > Masaki Ota > -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Wednesday, November 15, 2017 5:35 PM > To: 太田 真喜 Masaki Ota > Cc: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org; > dmitry.torok...@gmail.com; Aar

Re: [PATCH] input: keyboard: imx: use devm_platform_ioremap_resource() to simplify code

On Mon, Apr 01, 2019 at 05:28:12AM +, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Applied, thank you. > --- >

Re: [PATCH] input: imx6ul_tsc: use devm_platform_ioremap_resource() to simplify code

On Mon, Apr 01, 2019 at 05:19:55AM +, Anson Huang wrote: > Use the new helper devm_platform_ioremap_resource() which wraps the > platform_get_resource() and devm_ioremap_resource() together, to > simplify the code. > > Signed-off-by: Anson Huang Applied, thank you. > --- >

Re: [RESEND] input: keyboard: imx: make sure keyboard can always wake up system

Hi Anson, On Thu, Apr 04, 2019 at 01:40:16AM +, Anson Huang wrote: > There are several scenarios that keyboard can NOT wake up system > from suspend, e.g., if a keyboard is depressed between system > device suspend phase and device noirq suspend phase, the keyboard > ISR will be called and

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

On Sat, Sep 21, 2019 at 06:56:04AM +, Dexuan Cui wrote: > > From: dmitry.torok...@gmail.com > > Sent: Thursday, September 19, 2019 9:18 AM > > > > Hi Dexuan, > > > > On Wed, Sep 11, 2019 at 11:36:20PM +, Dexuan Cui wrote: > >

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

On Mon, Sep 30, 2019 at 10:09:27PM +, Dexuan Cui wrote: > > From: dmitry.torok...@gmail.com > > Sent: Friday, September 27, 2019 5:32 PM > > > ... > > > pm_wakeup_pending() is tested in a lot of places in the suspend > > > process and eventually an uni

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

Hi Dexuan, On Wed, Sep 11, 2019 at 11:36:20PM +, Dexuan Cui wrote: > We need hv_kbd_pm_notify() to make sure the pm_wakeup_hard_event() call > does not prevent the system from entering hibernation: the hibernation > is a relatively long process, which can be aborted by the call >

Re: [PATCH] Input: hyperv-keyboard: Add the support of hibernation

On Thu, Oct 03, 2019 at 06:44:04AM +, Dexuan Cui wrote: > > From: Dexuan Cui > > Sent: Wednesday, October 2, 2019 10:35 PM > > > ... > > > > > > ¯\_(ツ)_/¯ If you do not want to implement hibernation properly in vmbus > > > code that is totally up to you (have you read in pm.h how freeze() is

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.

On Tue, Jun 11, 2019 at 09:23:33AM +0200, Pali Rohár wrote: > On Tuesday 11 June 2019 12:32:33 Hui Wang wrote: > > On 2019/6/11 上午11:23, Hui Wang wrote: > > > On 2019/6/11 上午11:05, Xiaoxiao Liu wrote: > > > > Hi Pali, > > > > > > > > I discussed with our FW team about this problem. > > > > We

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.

On Tue, Jun 11, 2019 at 07:17:07PM +0200, Pali Rohár wrote: > On Tuesday 11 June 2019 10:07:07 dmitry.torok...@gmail.com wrote: > > On Tue, Jun 11, 2019 at 09:23:33AM +0200, Pali Rohár wrote: > > > On Tuesday 11 June 2019 12:32:33 Hui Wang wrote: > > > > On 201

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue alps cs19 trackstick do not work.

On Tue, Jun 11, 2019 at 07:38:56PM +0200, Pali Rohár wrote: > On Tuesday 11 June 2019 10:32:28 dmitry.torok...@gmail.com wrote: > > On Tue, Jun 11, 2019 at 07:17:07PM +0200, Pali Rohár wrote: > > > On Tuesday 11 June 2019 10:07:07 dmitry.torok...@gmail.com wrote: > > > &

Re: [RESEND] input: keyboard: imx: make sure keyboard can always wake up system

On Thu, Apr 04, 2019 at 01:40:16AM +, Anson Huang wrote: > There are several scenarios that keyboard can NOT wake up system > from suspend, e.g., if a keyboard is depressed between system > device suspend phase and device noirq suspend phase, the keyboard > ISR will be called and both keyboard

Re: [PATCH v7 0/7] Introduce STPMIC1 PMIC Driver

On Fri, Dec 14, 2018 at 12:47:01PM +, Lee Jones wrote: > On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote: > > > The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from > > STMicroelectronics. > > The STPMIC1 regulators supply power to an application processor as well as >

Re: [PATCH v4 6/8] input: stpmic1: add stpmic1 onkey driver

On Thu, Oct 18, 2018 at 09:02:13AM +, Pascal PAILLET-LME wrote: > From: pascal paillet > > The stpmic1 pmic is able to manage an onkey button. This driver exposes > the stpmic1 onkey as an input device. It can also be configured to > shut-down the power supplies on a long key-press with an

Re: [PATCH v3 6/8] input: stpmic1: add stpmic1 onkey driver

Hi Pascal, On Mon, Oct 08, 2018 at 04:29:41PM +, Pascal PAILLET-LME wrote: > From: pascal paillet > > The stpmic1 pmic is able to manage an onkey button. This driver exposes > the stpmic1 onkey as an input device. It can also be configured to > shut-down the power supplies on a long

Re: [PATCH v2] Input: uinput: Avoid Object-Already-Free with a global lock

Hi Mukesh, On Mon, Apr 15, 2019 at 03:35:51PM +0530, Mukesh Ojha wrote: > > Hi Dmitry, > > Can you please have a look at this patch ? as this seems to reproducing > quite frequently > > Thanks, > Mukesh > > On 4/10/2019 1:29 PM, Mukesh Ojha wrote: > > uinput_destroy_device() gets called from

Re: [PATCH v2] Input: uinput: Avoid Object-Already-Free with a global lock

Hi Mukesh, On Fri, Apr 19, 2019 at 12:17:44PM +0530, Mukesh Ojha wrote: > For some reason my last mail did not get delivered,  sending it again. > > > On 4/18/2019 11:55 AM, Mukesh Ojha wrote: > > > > > > On 4/18/2019 7:13 AM, dmitry.torok...@gm

Re: [PATCH v2] Input: uinput: Avoid Object-Already-Free with a global lock

On Fri, Apr 19, 2019 at 02:13:48PM +0530, Mukesh Ojha wrote: > > On 4/19/2019 12:41 PM, dmitry.torok...@gmail.com wrote: > > Hi Mukesh, > > > > On Fri, Apr 19, 2019 at 12:17:44PM +0530, Mukesh Ojha wrote: > > > For some reason my last mail did not

Re: [PATCH v2] Input: uinput: Avoid Object-Already-Free with a global lock

On Tue, Apr 23, 2019 at 12:51:13PM +0530, Mukesh Ojha wrote: > On 4/23/2019 8:58 AM, dmitry.torok...@gmail.com wrote: > > On Fri, Apr 19, 2019 at 02:13:48PM +0530, Mukesh Ojha wrote: > > > On 4/19/2019 12:41 PM, dmitry.torok...@gmail.com wrote: > > > > On Fri, Ap

Re: [PATCH] input: keyboard: snvs: make sure irq is handled correctly

Hi Anson, On Wed, Mar 27, 2019 at 02:47:06AM +, Anson Huang wrote: > SNVS IRQ is requested before necessary driver data initialized, > if there is a pending IRQ during driver probe phase, kernel > NULL pointer panic will occur in IRQ handler. To avoid such > scenario, need to move the IRQ

Re: [BUG REPORT] linux-input: keyboard: gpio_keys: False Button Press Event on Wake

Hi Ken, On Wed, Apr 03, 2019 at 05:50:09PM +, Ken Sloat wrote: > Hello Dmitry, > > I may have found a potential bug in the "gpio_keys" driver. FYI, I am > running the 4.14 LTS kernel on my system, but from my understanding of > the issue, it seems that this would still occur in the latest

Re: [PATCH 1/2] input: keyboard: imx: no need to control interrupt status in event check

Hi Anson, On Fri, Mar 29, 2019 at 07:00:43AM +, Anson Huang wrote: > There is no need to enable release interrupt and disable depress > interrupt in event check, as a timer is setup for checking these > events rather than interrupts. But won't using release interrupt allow signalling key

Re: [PATCH V2] input: keyboard: snvs: initialize necessary driver data before enabling IRQ

On Wed, Mar 27, 2019 at 06:07:06AM +, Anson Huang wrote: > SNVS IRQ is requested before necessary driver data initialized, > if there is a pending IRQ during driver probe phase, kernel > NULL pointer panic will occur in IRQ handler. To avoid such > scenario, just initialize necessary driver

Re: [PATCH] input: keyboard: snvs: use dev_pm_set_wake_irq() to simplify code

On Wed, Mar 27, 2019 at 06:08:05AM +, Anson Huang wrote: > With calling dev_pm_set_wake_irq() to set SNVS ON/OFF button > as wakeup source for suspend, generic wake irq mechanism > will automatically enable it as wakeup source when suspend, > then the enable_irq_wake()/disable_irq_wake() can

Re: [PATCH V2 6/8] input: stpmic1: add stpmic1 onkey driver

Hi Pascal, On Fri, Sep 07, 2018 at 12:59:45PM +, Pascal PAILLET-LME wrote: > From: pascal paillet > > The stpmic1 pmic is able to manage an onkey button. This driver exposes > the stpmic1 onkey as an input device. It can also be configured to > shut-down the power supplies on a long

Re: [PATCH v12 01/19] input: cyapa: modify code to following kernel code style

Dudley, Jeremiah, On Thu, Dec 04, 2014 at 05:54:43AM +, Dudley Du wrote: > Jeremiah, > > I didn't submitted this fix patch, but Dmitry has been helping apply the fix > patch quickly, maybe todoay or tommorrow. The patches that I apply for the next merge window should appear first in my

Re: [PATCH v3 5/9] VMware balloon: Show capabilities of balloon and resulting capabilities in the debug-fs node.

On Wed, Aug 05, 2015 at 08:22:35PM +, Philip Moltmann wrote: > Hi, > > > > MODULE_AUTHOR("VMware, Inc."); > > > MODULE_DESCRIPTION("VMware Memory Control (Balloon) Driver"); > > > -MODULE_VERSION("1.3.2.0-k"); > > > +MODULE_VERSION("1.3.3.0-k"); > > > > This constant change of module

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

Hi Philip, On Thu, Jun 11, 2015 at 08:10:07PM +, Philip Moltmann wrote: > Hi, > > sorry for taking so long to address your concerns. > > > What happens if you run this new driver on an older hypervisor that > > does not support batched operations? > > When the driver starts or when it

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

On Fri, Jun 12, 2015 at 03:06:56PM +, Philip Moltmann wrote: > Hi, > > thanks for taking so much interest in this driver. It is quite good > that our design choices get scrutinized by non-current VMware > employees. > > > > I understand that you negotiate the capabilities between hypervisor

Re: [PATCH 6/9] VMware balloon: Do not limit the amount of frees and allocations in non-sleep mode.

On Fri, Jun 12, 2015 at 03:40:42PM +, Philip Moltmann wrote: > Hi, > > > > > > Three improvements contribute to the overall faster speed: > > > - batched operations reduce the hypervisor overhead per page > > > - 2m instead of 4k buffer reduce the hypervisor overhead per page > > > - removing

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Masaki, On Tue, Mar 07, 2017 at 08:40:20AM +, Masaki Ota wrote: > Hi, Paul, > > I have modified the source code. > > There are three issues. > #1. E7=73 03 28 Button pad device is not assigned "ALPS_BUTTONPAD" Flag > correctly. > #2. E7=73 03 28 devices are not assigned "

Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

Hi Nick, On Mon, Mar 06, 2017 at 03:59:00PM +, Nick Fletcher wrote: > HI, > > I installed the two drivers as requested. Results of dmesg | grep > 'two-finger' below.. Could you please also tell us whether the devoice only has touchpad, or if it has touchpad/starckstick combo? Thanks. --