[PATCH v5 0/8] media: i2c: Add RDACM21 camera module

2020-11-16 Thread Jacopo Mondi
: renesas-drivers-2020-11-10-v5.10-rc3 Thanks j Jacopo Mondi (7): media: i2c: Add driver for RDACM21 camera module dt-bindings: media: max9286: Document 'maxim,initial-reverse-channel-mV' media: i2c: max9286: Break-out reverse channel setup media: i2c: max9286: Make channel amplitude

[PATCH v5 4/8] media: i2c: max9286: Make channel amplitude programmable

2020-11-16 Thread Jacopo Mondi
Instrument the function that configures the reverse channel with a programmable amplitude value. This change serves to prepare to adjust the reverse channel amplitude depending on the remote end high-threshold configuration. Reviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi --- drivers

[PATCH v5 5/8] media: i2c: max9286: Configure reverse channel amplitude

2020-11-16 Thread Jacopo Mondi
Bingham Signed-off-by: Jacopo Mondi --- drivers/media/i2c/max9286.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 31e27d0f34f1..11ba047f3793 100644 --- a/drivers/media/i2c/max9286.c +++ b

[PATCH v5 3/8] media: i2c: max9286: Break-out reverse channel setup

2020-11-16 Thread Jacopo Mondi
Break out the reverse channel setup configuration procedure to its own function. This change prepares for configuring the reverse channel conditionally to the remote side high threshold configuration. No functional changes intended. Reviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi

[PATCH v5 1/8] media: i2c: Add driver for RDACM21 camera module

2020-11-16 Thread Jacopo Mondi
the same serializer, such as rdacm20. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 12 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile | 2 + drivers/media/i2c/rdacm21.c | 595 4 files changed, 622 insertions(+) create mode

[PATCH v5 8/8] [DNI] arm64: dts: renesas: eagle: Specify channel amplitude

2020-11-16 Thread Jacopo Mondi
Use the newly introduced 'maxim,initial-reverse-channel-mV' property to specify the initial reverse channel amplitude when the remote serializers are not pre-programmed with noise immunity threshold enabled. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 1 + 1

Re: [PATCH v4 1/8] media: i2c: Add driver for RDACM21 camera module

2020-11-16 Thread Jacopo Mondi
Hi Kieran, On Mon, Nov 16, 2020 at 10:20:47AM +, Kieran Bingham wrote: > On 16/11/2020 10:03, Jacopo Mondi wrote: > > Hi Laurent, > > > > On Mon, Nov 16, 2020 at 11:08:33AM +0200, Laurent Pinchart wrote: > >> Hi Jacopo, > >> > >> On Sat, Nov

Re: [PATCH v4 1/8] media: i2c: Add driver for RDACM21 camera module

2020-11-16 Thread Jacopo Mondi
Hi Laurent, On Mon, Nov 16, 2020 at 11:08:33AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Sat, Nov 14, 2020 at 03:04:57PM +0100, Jacopo Mondi wrote: > > On Thu, Nov 12, 2020 at 10:31:05PM +, Kieran Bingham wrote: > > > Hi Jacopo, > > > > [snip] >

Re: [PATCH v4 1/8] media: i2c: Add driver for RDACM21 camera module

2020-11-14 Thread Jacopo Mondi
1, >pad); > > + if (ret < 0) > > + goto error_free_ctrls; > > + > > + ep = fwnode_graph_get_next_endpoint(dev_fwnode(>dev), NULL); > > + if (!ep) { > > + dev_err(>dev, > > + "Unable to get endpoint in node %pOF\n&qu

[PATCH v4 7/8] [DNI] arm64: dts: renesas: salvator-x-max9286: Specify channel amplitude

2020-11-12 Thread Jacopo Mondi
Use the newly introduced 'maxim,maxim,initial-reverse-channel-mV' property to specify the initial reverse channel amplitude when the remote serializers are pre-programmed with noise immunity threshold enabled. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi

[PATCH v4 5/8] media: i2c: max9286: Configure reverse channel amplitude

2020-11-12 Thread Jacopo Mondi
Adjust the initial reverse channel amplitude parsing from firmware interface the 'maxim,initial-reverse-channel-mV' property. This change is required for both rdacm20 and rdacm21 camera modules to be correctly probed when used in combination with the max9286 deserializer. Signed-off-by: Jacopo

[PATCH v4 4/8] media: i2c: max9286: Make channel amplitude programmable

2020-11-12 Thread Jacopo Mondi
Instrument the function that configures the reverse channel with a programmable amplitude value. This change serves to prepare to adjust the reverse channel amplitude depending on the remote end high-threshold configuration. Reviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi --- drivers

[PATCH v4 1/8] media: i2c: Add driver for RDACM21 camera module

2020-11-12 Thread Jacopo Mondi
the same serializer, such as rdacm20. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 12 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile | 2 + drivers/media/i2c/rdacm21.c | 539 4 files changed, 566 insertions(+) create mode

[PATCH v4 3/8] media: i2c: max9286: Break-out reverse channel setup

2020-11-12 Thread Jacopo Mondi
Break out the reverse channel setup configuration procedure to its own function. This change prepares for configuring the reverse channel conditionally to the remote side high threshold configuration. No functional changes intended. Reviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi

[PATCH v4 2/8] dt-bindings: media: max9286: Document 'maxim,,initial-reverse-channel-mV"

2020-11-12 Thread Jacopo Mondi
supply noise immunity enabled. Signed-off-by: Jacopo Mondi --- .../bindings/media/i2c/maxim,max9286.yaml | 23 +++ 1 file changed, 23 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c/maxim

[PATCH v4 6/8] arm64: dts: renesas: salvator-x: Add MAX9286 expansion board

2020-11-12 Thread Jacopo Mondi
From: Laurent Pinchart Add a .dtsi fragment to describe the MAX9286-based expansion board for the Renesas Salvator-X board. The MAX9286 expansion board has eight RDACM20 cameras connected to it. They can be individually controlled by enabling or disabling the macro defines. Signed-off-by:

[PATCH v4 8/8] [DNI] arm64: dts: renesas: eagle: Specify channel amplitude

2020-11-12 Thread Jacopo Mondi
Use the newly introduced 'maxim,maxim,initial-reverse-channel-mV' property to specify the initial reverse channel amplitude when the remote serializers are not pre-programmed with noise immunity threshold enabled. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77970-eagle.dts

[PATCH v4 0/8] media: i2c: Add RDACM21 camera module

2020-11-12 Thread Jacopo Mondi
for inclusion to devicetree people, which I have left out at the moment. Thanks j Jacopo Mondi (7): media: i2c: Add driver for RDACM21 camera module dt-bindings: media: max9286: Document 'maxim,,initial-reverse-channel-mV" media: i2c: max9286: Break-out reverse channel setup

Re: [PATCH v4 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656

2020-10-30 Thread Jacopo Mondi
Hi Sakari, On Fri, Oct 30, 2020 at 07:42:36PM +0200, Sakari Ailus wrote: > Hi Rob, > > On Mon, Oct 26, 2020 at 09:17:14AM -0500, Rob Herring wrote: > > On Thu, Oct 22, 2020 at 02:56:17PM +, Hugues FRUCHET wrote: > > > Hi Sakari, > > > > > > + Jacopo for his work on ov772x binding related to

Re: [PATCH v3 1/3] dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc

2020-10-16 Thread Jacopo Mondi
Hello Eugen, On Fri, Oct 16, 2020 at 12:30:59PM +, eugen.hris...@microchip.com wrote: > On 12.10.2020 16:04, Jacopo Mondi wrote: > > Hello, > > just my 2 cents, as I've noticed this patch skimming through the > > list > > > > On Mon, Oct 12, 202

Re: [PATCH v3 2/7] dt-bindings: media: max9286: Document 'maxim,high-threshold'

2020-10-16 Thread Jacopo Mondi
Hi Geert (and Kieran, as his question on the other patch is actually on the same point) On Fri, Oct 16, 2020 at 01:50:34PM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Fri, Oct 16, 2020 at 12:09 PM Jacopo Mondi > wrote: > > Document the 'maxim,high-threshol

[PATCH v3 3/7] media: i2c: max9286: Break-out reverse channel setup

2020-10-16 Thread Jacopo Mondi
Break out the reverse channel setup configuration procedure to its own function. This change prepares for configuring the reverse channel conditionally to the remote side high threshold configuration. No functional changes intended. Reviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi

[PATCH v3 5/7] media: i2c: max9286: Configure reverse channel amplitude

2020-10-16 Thread Jacopo Mondi
d-off-by: Jacopo Mondi --- drivers/media/i2c/max9286.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 31e27d0f34f1..4c72e1e6b27b 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/medi

[PATCH v3 6/7] arm64: dts: renesas: salvator-x: Add MAX9286 expansion board

2020-10-16 Thread Jacopo Mondi
From: Laurent Pinchart Add a .dtsi fragment to describe the MAX9286-based expansion board for the Renesas Salvator-X board. The MAX9286 expansion board has eight RDACM20 cameras connected to it. They can be individually controlled by enabling or disabling the macro defines. Signed-off-by:

[PATCH v3 1/7] media: i2c: Add driver for RDACM21 camera module

2020-10-16 Thread Jacopo Mondi
the same serializer, such as rdacm20. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 12 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile | 2 + drivers/media/i2c/rdacm21.c | 538 4 files changed, 565 insertions(+) create mode

[PATCH v3 0/7] media: i2c: Add support for RDACM21 camera module

2020-10-16 Thread Jacopo Mondi
tup works on Salvator-X, I'll submit the new property for inclusion to devicetree people, which I have left out at the moment. Thanks j Jacopo Mondi (6): media: i2c: Add driver for RDACM21 camera module dt-bindings: media: max9286: Document 'maxim,high-threshold' media: i2c: max9286: Break-

[PATCH v3 4/7] media: i2c: max9286: Make channel amplitude programmable

2020-10-16 Thread Jacopo Mondi
Instrument the function that configures the reverse channel with a programmable amplitude value. This change serves to prepare to adjust the reverse channel amplitude depending on the remote end high-threshold configuration. Reviewed-by: Kieran Bingham Signed-off-by: Jacopo Mondi --- drivers

[PATCH v3 2/7] dt-bindings: media: max9286: Document 'maxim,high-threshold'

2020-10-16 Thread Jacopo Mondi
supply noise immunity enabled. Signed-off-by: Jacopo Mondi --- .../bindings/media/i2c/maxim,max9286.yaml | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c

[PATCH v3 7/7] [DNI] arm64: dts: renesas: salvator-x-max9286: Use high-threshold

2020-10-16 Thread Jacopo Mondi
Use the newly introduced 'maxim,high-threshold' property to maintain compatibility with RDACM20 camera module. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/salvator-x-max9286

[PATCH v2 0/6] r8a779a0: Add CSI and VIN

2020-10-16 Thread Jacopo Mondi
only. Jacopo Mondi (6): clk: renesas: r8a779a0: Add CSI4[0-3] clocks dt-bindings: media: renesas,csi2: Add V3U support arm64: dts: renesas: r8a779a0: Add CSI-2 nodes clk: renesas: r8a779a0: Add VIN clocks dt-bindings: media: renesas,vin: Add V3U support arm64: dts: r8a779a0: Add VIN

[PATCH v2 2/6] dt-bindings: media: renesas,csi2: Add V3U support

2020-10-16 Thread Jacopo Mondi
Add compatible string definition for R-Car V3U. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/media/renesas,csi2.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media

[PATCH v2 3/6] arm64: dts: renesas: r8a779a0: Add CSI-2 nodes

2020-10-16 Thread Jacopo Mondi
Add CSI-2 nodes to R8A779A0 R-Car V3U SoC. Reviewed-by: Geert Uytterhoeven Signed-off-by: Jacopo Mondi --- v2: - Add empty 'ports' node to pass dtbs validation --- arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 52 +++ 1 file changed, 52 insertions(+) diff --git a/arch

[PATCH v2 1/6] clk: renesas: r8a779a0: Add CSI4[0-3] clocks

2020-10-16 Thread Jacopo Mondi
Add definitions of the CSI-2 receivers clocks for R-Car V3U. Reviewed-by: Geert Uytterhoeven Signed-off-by: Jacopo Mondi --- drivers/clk/renesas/r8a779a0-cpg-mssr.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0

[PATCH v2 4/6] clk: renesas: r8a779a0: Add VIN clocks

2020-10-16 Thread Jacopo Mondi
Add definitions of the VIN instances clocks for R-Car V3U. Reviewed-by: Geert Uytterhoeven Signed-off-by: Jacopo Mondi --- drivers/clk/renesas/r8a779a0-cpg-mssr.c | 32 + 1 file changed, 32 insertions(+) diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers

[PATCH v2 5/6] dt-bindings: media: renesas,vin: Add V3U support

2020-10-16 Thread Jacopo Mondi
Add compatible string definition for R-Car V3U. Signed-off-by: Jacopo Mondi --- This and the following patch are still under discussion as the proper support for the V3U VIN might require the implementation of a different driver. I'm fine deferring it to when we'll have a more clear plan

[PATCH v2 6/6] arm64: dts: r8a779a0: Add VIN nodes

2020-10-16 Thread Jacopo Mondi
Add VIN nodes to R8A779A0 R-Car V3U SoC. Signed-off-by: Jacopo Mondi --- v2: - Add 'renesas,id' property and empty 'ports' node to pass dtbs validation --- arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 448 ++ 1 file changed, 448 insertions(+) diff --git a/arch/arm64/boot

Re: [PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks

2020-10-16 Thread Jacopo Mondi
Hi Geert, On Thu, Oct 15, 2020 at 06:30:03PM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Oct 15, 2020 at 9:32 AM Jacopo Mondi wrote: > > On Wed, Oct 14, 2020 at 09:55:32PM +0300, Sergei Shtylyov wrote: > > > On 10/14/20 12:44 PM, Jacopo Mondi wrote: >

Re: [PATCH v2 5/7] media: i2c: max9286: Configure reverse channel amplitude

2020-10-16 Thread Jacopo Mondi
Hi Kieran, On Thu, Oct 15, 2020 at 08:52:01PM +0100, Kieran Bingham wrote: > Hi Jacopo, > > On 15/10/2020 19:27, Jacopo Mondi wrote: > > Adjust reverse channel amplitude according to the presence of > > the 'high-threshold" DTS property. > > > > If no h

[PATCH v2 0/7] media: i2c: Add support for RDACM21 camera module

2020-10-15 Thread Jacopo Mondi
ion to devicetree people, which I have left out at the moment. Thanks j Jacopo Mondi (6): media: i2c: Add driver for RDACM21 camera module dt-bindings: media: max9286: Document 'maxim,high-threshold' media: i2c: max9286: Break-out reverse channel setup media: i2c: max9286: Make channel amplit

[PATCH v2 1/7] media: i2c: Add driver for RDACM21 camera module

2020-10-15 Thread Jacopo Mondi
the same serializer, such as rdacm20. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 12 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile | 2 + drivers/media/i2c/rdacm21.c | 538 4 files changed, 565 insertions(+) create mode

[PATCH v2 4/7] media: i2c: max9286: Make channel amplitude programmable

2020-10-15 Thread Jacopo Mondi
Instrument the function that configures the reverse channel with a programmable amplitude value. This change serves to prepare to adjust the reverse channel amplitude depending on the remote end high-threshold configuration. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/max9286.c | 22

[PATCH v2 7/7] [DNI] arm64: dts: renesas: salvator-x-max9286: Use high-threshold

2020-10-15 Thread Jacopo Mondi
Use the newly introduced 'maxim,high-threshold' property to maintain compatibility with RDACM20 camera module. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/salvator-x-max9286

[PATCH v2 3/7] media: i2c: max9286: Break-out reverse channel setup

2020-10-15 Thread Jacopo Mondi
Break out the reverse channel setup configuration procedure to its own function. This change prepares for configuring the reverse channel conditionally to the remote side high threshold configuration. No functional changes intended. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/max9286.c

[PATCH v2 2/7] dt-bindings: media: max9286: Document 'maxim,high-threshold'

2020-10-15 Thread Jacopo Mondi
supply noise immunity enabled. Signed-off-by: Jacopo Mondi --- .../bindings/media/i2c/maxim,max9286.yaml | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9286.yaml b/Documentation/devicetree/bindings/media/i2c

[PATCH v2 6/7] [DNI] arm64: dts: renesas: salvator-x: Add MAX9286 expansion board

2020-10-15 Thread Jacopo Mondi
From: Laurent Pinchart Add a .dtsi fragment to describe the MAX9286-based expansion board for the Renesas Salvator-X board. The MAX9286 expansion board has eight RDACM20 cameras connected to it. They can be individually controlled by enabling or disabling the macro defines. Signed-off-by:

[PATCH v2 5/7] media: i2c: max9286: Configure reverse channel amplitude

2020-10-15 Thread Jacopo Mondi
d-off-by: Jacopo Mondi --- drivers/media/i2c/max9286.c | 74 +++-- 1 file changed, 47 insertions(+), 27 deletions(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 163e102199e3..4b59a9e0228a 100644 --- a/drivers/media/i2c/max9286.c

Re: [PATCH 3/6] arm64: dts: renesas: r8a779a0: Add CSI-2 nodes

2020-10-15 Thread Jacopo Mondi
Hi Geert, On Thu, Oct 15, 2020 at 02:43:51PM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Wed, Oct 14, 2020 at 11:40 AM Jacopo Mondi > wrote: > > Add CSI-2 nodes to R8A779A0 R-Car V3U SoC. > > > > Signed-off-by: Jacopo Mondi > > Thanks for your

Re: [PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks

2020-10-15 Thread Jacopo Mondi
Hi Sergei, On Wed, Oct 14, 2020 at 09:55:32PM +0300, Sergei Shtylyov wrote: > On 10/14/20 12:44 PM, Jacopo Mondi wrote: > > > Add clock definitions of the VIN instances for R-Car V3U. > > > > Signed-off-by: Jacopo Mondi > > > > --- > > Clocks at inde

Re: [PATCH 6/6] arm64: dts: r8a779a0: Add VIN nodes

2020-10-14 Thread Jacopo Mondi
Hi Niklas, On Wed, Oct 14, 2020 at 12:19:50PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2020-10-14 11:44:43 +0200, Jacopo Mondi wrote: > > Add VIN nodes to R8A779A0 R-Car V3U SoC. > > > > Signed-off-by: Jacopo Mondi > &g

Re: [PATCH 5/6] dt-bindings: media: renesas,vin: Add V3U support

2020-10-14 Thread Jacopo Mondi
Hi Niklas, On Wed, Oct 14, 2020 at 12:11:52PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2020-10-14 11:44:42 +0200, Jacopo Mondi wrote: > > Add compatible string definition for R-Car V3U. > > > > Signed-off-by: Jacopo Mondi >

[PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks

2020-10-14 Thread Jacopo Mondi
Add clock definitions of the VIN instances for R-Car V3U. Signed-off-by: Jacopo Mondi --- Clocks at indexes 730 and 731 are named 'vin0' and 'vin1'. I assumed it's a typographic error and renamed them 'vin00' and 'vin01' --- drivers/clk/renesas/r8a779a0-cpg-mssr.c | 32

[PATCH 6/6] arm64: dts: r8a779a0: Add VIN nodes

2020-10-14 Thread Jacopo Mondi
Add VIN nodes to R8A779A0 R-Car V3U SoC. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 320 ++ 1 file changed, 320 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi index

[PATCH 5/6] dt-bindings: media: renesas,vin: Add V3U support

2020-10-14 Thread Jacopo Mondi
Add compatible string definition for R-Car V3U. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/media/renesas,vin.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media

[PATCH 0/6] r8a779a0: Add CSI and VIN

2020-10-14 Thread Jacopo Mondi
This series adds the CPG clock definitions, device node entries, and compatible strings for the CSI-2 receivers and VIN instances on R8A779A0 R-Car V3U SoC. A few quircks in the per-patches commit messages. Compile tested only. Jacopo Mondi (6): clk: renesas: r8a779a0: Add CSI4[0-3] clocks

[PATCH 3/6] arm64: dts: renesas: r8a779a0: Add CSI-2 nodes

2020-10-14 Thread Jacopo Mondi
Add CSI-2 nodes to R8A779A0 R-Car V3U SoC. Signed-off-by: Jacopo Mondi --- The chip manual reports that the CSI-2 units are fed with S1D1 and S1D2 clocks. The same applies to other SoCs, but none lists the two additional clocks in the DTS node. So I left them out here as well. --- arch/arm64

[PATCH 2/6] dt-bindings: media: renesas,csi2: Add V3U support

2020-10-14 Thread Jacopo Mondi
Add compatible string definition for R-Car V3U. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/media/renesas,csi2.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media

[PATCH 1/6] clk: renesas: r8a779a0: Add CSI4[0-3] clocks

2020-10-14 Thread Jacopo Mondi
Add clock definitions of the CSI-2 receivers for R-Car V3U. Signed-off-by: Jacopo Mondi --- drivers/clk/renesas/r8a779a0-cpg-mssr.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c index 7e25b3b8945b

Re: [PATCH v3 1/3] dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc

2020-10-12 Thread Jacopo Mondi
Hello, just my 2 cents, as I've noticed this patch skimming through the list On Mon, Oct 12, 2020 at 07:19:43AM +, eugen.hris...@microchip.com wrote: > On 11.10.2020 00:17, Laurent Pinchart wrote: > > Hi Eugen, > > > > Thank you for the patch. > > Hi, > > Thank you for your review, > >

Re: [PATCH v6 2/3] media: i2c: ov772x: Add support for BT.656 mode

2020-09-30 Thread Jacopo Mondi
2_MBUS_PARALLEL as it was the only supported bus > at the time. v4l2_fwnode_endpoint_alloc_parse() will not fail if > 'bus-type' is not specified. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/media/i2c/ov772x

Re: [PATCH v6 1/3] media: i2c: ov772x: Parse endpoint properties

2020-09-30 Thread Jacopo Mondi
Signed-off-by: Lad Prabhakar Looks good! Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/media/i2c/ov772x.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c > ind

Re: [PATCH v6 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-09-22 Thread Jacopo Mondi
Hi Thierry On Tue, Sep 22, 2020 at 09:55:01AM +0200, Thierry Reding wrote: > On Mon, Sep 21, 2020 at 02:39:39PM -0700, Sowjanya Komatineni wrote: > > IMX274 has analog 2.8V supply, digital core 1.8V supply, and vddl digital > > io 1.2V supply which are optional based on camera module design. > >

[PATCH 1/2] RFC: media: i2c: max9286: Compensate reverse channel

2020-09-16 Thread Jacopo Mondi
feature. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/max9286.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 6852448284ea..992eb15a59be 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c

[PATCH 2/2] media: i2c: Add driver for RDACM21 camera module

2020-09-16 Thread Jacopo Mondi
the same serializer, such as rdacm20. Signed-off-by: Jacopo Mondi --- MAINTAINERS | 12 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile | 2 + drivers/media/i2c/rdacm21.c | 541 4 files changed, 568 insertions(+) create mode

[PATCH 0/2] media: i2c: Add support for RDACM21 camera module

2020-09-16 Thread Jacopo Mondi
github.com/xlnx-hyunkwon/linux-xlnx/commits/hyunk/vision-wip-5.4-next Jacopo Mondi (2): RFC: media: i2c: max9286: Compensate reverse channel media: i2c: Add driver for RDACM21 camera module MAINTAINERS | 12 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makef

Re: [PATCH v5 1/3] media: i2c: ov772x: Parse endpoint properties

2020-09-16 Thread Jacopo Mondi
Hi Prabhakar, sorry, two more tiny nits On Wed, Sep 16, 2020 at 09:47:37AM +0200, Jacopo Mondi wrote: > Hi Prabhakar, > > On Tue, Sep 15, 2020 at 06:42:33PM +0100, Lad Prabhakar wrote: > > Parse endpoint properties using v4l2_fwnode_endpoint_alloc_parse() > > to determi

Re: [PATCH v5 2/3] media: i2c: ov772x: Add support for BT.656 mode

2020-09-16 Thread Jacopo Mondi
Hi Prabhakar, On Tue, Sep 15, 2020 at 06:42:34PM +0100, Lad Prabhakar wrote: > Add support to read the bus-type for V4L2_MBUS_BT656 and > enable BT.656 mode in the sensor if needed. Here we should be concerned about retro-compatibility, as a new bus type is added. I would move the comment you

Re: [PATCH v5 1/3] media: i2c: ov772x: Parse endpoint properties

2020-09-16 Thread Jacopo Mondi
Hi Prabhakar, On Tue, Sep 15, 2020 at 06:42:33PM +0100, Lad Prabhakar wrote: > Parse endpoint properties using v4l2_fwnode_endpoint_alloc_parse() > to determine bus-type and store it locally in priv data. > > v4l2_fwnode_endpoint_alloc_parse() with bus_type set to > V4L2_MBUS_PARALLEL falls back

Re: [PATCH 2/3] media: docs: v4l2-subdev: move "Subdev registration" to a subsection

2020-09-15 Thread Jacopo Mondi
d not mind a subsection to be honest... I think the patch is good and I'll provide a tag, maybe others can provide opinions too! Reviewed-by: Jacopo Mondi Thanks j > > Signed-off-by: Luca Ceresoli > --- > Documentation/driver-api/media/v4l2-subdev.rst | 11 +++ > 1 file

Re: [PATCH 1/3] media: docs: v4l2-subdev: fix typo

2020-09-15 Thread Jacopo Mondi
Hi Luca, On Fri, Sep 04, 2020 at 11:51:39PM +0200, Luca Ceresoli wrote: > Fix "will to" -> "will do". > > Signed-off-by: Luca Ceresoli Reviewed-by: Jacopo Mondi Thanks j > --- > Documentation/driver-api/media/v4l2-subdev.rst | 2 +- > 1

Re: [PATCH 3/3] media: docs: v4l2-subdev: move generic paragraph to the introduction

2020-09-15 Thread Jacopo Mondi
Hi Luca, On Fri, Sep 04, 2020 at 11:51:41PM +0200, Luca Ceresoli wrote: > This paragraph provides generic information to explain what v4l2_subdev is > useful for. Placing it in the middle of paragraphs describing the details > of subdev registration does not make much sense. Move it near the

Re: [PATCH v4 1/3] media: i2c: ov772x: Parse endpoint properties

2020-09-14 Thread Jacopo Mondi
Hi Prabhakar, On Sun, Sep 13, 2020 at 07:42:45PM +0100, Lad Prabhakar wrote: > Parse endpoint properties using v4l2_fwnode_endpoint_alloc_parse() > to determine bus-type and store it locally in priv data. > > Also for backward compatibility with the existing DT where bus-type > isnt specified

Re: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies

2020-09-08 Thread Jacopo Mondi
Hi Sakari, Sowjanya, On Tue, Sep 08, 2020 at 12:33:41PM +0300, Sakari Ailus wrote: > On Thu, Sep 03, 2020 at 09:40:57AM -0700, Sowjanya Komatineni wrote: > > > > On 9/3/20 9:35 AM, Jacopo Mondi wrote: > > > Hi Sowjanya, > > > > > > On Thu, Sep 03, 202

Re: [PATCH v5 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-09-07 Thread Jacopo Mondi
Hello, On Fri, Sep 04, 2020 at 10:04:10AM -0700, Sowjanya Komatineni wrote: > > On 9/4/20 1:55 AM, Jacopo Mondi wrote: > > > > usleep_range() allows you to provide an interval in which your timeout > > > > can be coalesced with others. Giving a [1usec, 2usec

Re: [PATCH v3 2/3] media: i2c: ov5640: Add support for BT656 mode

2020-09-04 Thread Jacopo Mondi
Hi Prabhakar On Thu, Aug 13, 2020 at 06:13:36PM +0100, Lad Prabhakar wrote: > Enable support for BT656 mode. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Looks good to me Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/media

Re: [PATCH v3 3/3] media: i2c: ov5640: Fail probe on unsupported bus_type

2020-09-04 Thread Jacopo Mondi
Hi Prabhakar On Thu, Aug 13, 2020 at 06:13:37PM +0100, Lad Prabhakar wrote: > Fail probe if unsupported bus_type is detected. > > Signed-off-by: Lad Prabhakar Thanks Reviewed-by: Jacopo Mondi > --- > drivers/media/i2c/ov5640.c | 7 +++ > 1 file changed, 7 insertions

Re: [PATCH v3 1/3] media: i2c: ov5640: Enable data pins on poweron for DVP mode

2020-09-04 Thread Jacopo Mondi
s? > That way this would be quite a bit easier to review. > > While some of the above seem entirely reasonable, the changes are vast and > testing should be done on different boards to make sure things won't break. > That said, this depends on others who have the hardware. I left it

Re: [PATCH v3 1/2] media: i2c: ov772x: Add support for BT656 mode

2020-09-04 Thread Jacopo Mondi
Hi Sakari, On Fri, Sep 04, 2020 at 12:36:26PM +0300, Sakari Ailus wrote: > On Fri, Sep 04, 2020 at 11:20:49AM +0200, Jacopo Mondi wrote: > > Hi Sakari, > > > > On Fri, Sep 04, 2020 at 11:21:04AM +0300, Sakari Ailus wrote: > > > Hi Laurent, Jacopo, > > > &

Re: [PATCH v3 1/2] media: i2c: ov772x: Add support for BT656 mode

2020-09-04 Thread Jacopo Mondi
Hi Sakari, On Fri, Sep 04, 2020 at 11:21:04AM +0300, Sakari Ailus wrote: > Hi Laurent, Jacopo, > > On Fri, Sep 04, 2020 at 09:55:53AM +0200, Jacopo Mondi wrote: > > Hi Laurent, > > > > On Fri, Sep 04, 2020 at 04:20:00AM +0300, Laurent Pinchart wrote: > > >

Re: [PATCH v5 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-09-04 Thread Jacopo Mondi
Hello Sowjanya, On Thu, Sep 03, 2020 at 09:25:44AM -0700, Sowjanya Komatineni wrote: > > On 9/3/20 8:03 AM, Jacopo Mondi wrote: > > Hello, > > > > On Tue, Sep 01, 2020 at 07:04:38PM -0700, Sowjanya Komatineni wrote: > > > IMX274 has VANA analog 2.8V supp

Re: [PATCH v3 1/2] media: i2c: ov772x: Add support for BT656 mode

2020-09-04 Thread Jacopo Mondi
Hi Laurent, On Fri, Sep 04, 2020 at 04:20:00AM +0300, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. > > On Mon, Aug 24, 2020 at 08:04:05PM +0100, Lad Prabhakar wrote: > > Add support to read the bus-type and enable BT656 mode if needed. > > > > Also fail probe if

Re: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies

2020-09-03 Thread Jacopo Mondi
Hi Sowjanya, On Thu, Sep 03, 2020 at 09:05:27AM -0700, Sowjanya Komatineni wrote: > > On 9/3/20 5:55 AM, Jacopo Mondi wrote: > > Hello Sowjanya, > > > > On Tue, Sep 01, 2020 at 07:04:37PM -0700, Sowjanya Komatineni wrote: > > > This patch adds IMX274 optional

Re: [PATCH v3 2/2] media: i2c: ov772x: Add test pattern control

2020-09-03 Thread Jacopo Mondi
flip the =^ serves to invert the v4l2-control meaning, as the image is said to be already H/V flipped by the platform data (if I got this part right). For test pattern, do we want the same behaviour ? If enabled by platform data then selecting "Vertical Color Bar Type 1" then disables

Re: [PATCH v3 1/2] media: i2c: ov772x: Add support for BT656 mode

2020-09-03 Thread Jacopo Mondi
ood to me Reviewed-by: Jacopo Mondi Thanks j > --- > drivers/media/i2c/ov772x.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c > index 2cc6a678069a..67764d647526 100644 > --- a/dri

Re: [PATCH v5 3/3] media: i2c: imx274: Add IMX274 power on and off sequence

2020-09-03 Thread Jacopo Mondi
Hello, On Tue, Sep 01, 2020 at 07:04:38PM -0700, Sowjanya Komatineni wrote: > IMX274 has VANA analog 2.8V supply, VDIG digital core 1.8V supply, > and VDDL digital io 1.2V supply which are optional based on camera > module design. > > IMX274 also need external 24Mhz clock and is optional based on

Re: [PATCH v5 2/3] dt-bindings: media: imx274: Add optional input clock and supplies

2020-09-03 Thread Jacopo Mondi
Hello Sowjanya, On Tue, Sep 01, 2020 at 07:04:37PM -0700, Sowjanya Komatineni wrote: > This patch adds IMX274 optional external clock input and voltage > supplies to device tree bindings. > > Reviewed-by: Luca Ceresoli > Signed-off-by: Sowjanya Komatineni > --- >

Re: [PATCH v2 28/47] staging: vchi: Get rid of vchiq_shim's message callback

2020-08-28 Thread Jacopo Mondi
Hi Nicolas, I'm working on a v2 of the bcm2835-isp support which was sent along with UNICAM v4l2 driver and some misc changes you have collected in this series. Reference to v1: https://lore.kernel.org/linux-media/20200504092611.9798-1-laurent.pinch...@ideasonboard.com/ On Mon, Jun 29, 2020

Re: [PATCH v2 1/3] dt-bindings: media: ov772x: Document endpoint properties

2020-08-17 Thread Jacopo Mondi
Hello Prabhakar, On Sat, Aug 15, 2020 at 11:34:33AM +0100, Lad, Prabhakar wrote: > Hi Jacopo, > > On Mon, Aug 3, 2020 at 12:39 PM Lad Prabhakar > wrote: > > > > Document endpoint properties required for parallel interface > > > > Signed-off-by: Lad Prabhakar > > --- > >

Re: [PATCH v2 2/4] media: i2c: ov5640: Enable data pins on poweron for DVP mode

2020-08-10 Thread Jacopo Mondi
Hi Prabhakar, On Mon, Aug 10, 2020 at 08:40:29AM +0100, Lad, Prabhakar wrote: > Hi Jacopo, > > Thank you for the review. > > On Fri, Aug 7, 2020 at 9:42 AM Jacopo Mondi wrote: > > > > Hi Prabhakar, > >+ Paul who is working with this chip on a parallel setup &

Re: [PATCH v2 2/4] media: i2c: ov5640: Enable data pins on poweron for DVP mode

2020-08-07 Thread Jacopo Mondi
Hi Prabhakar, + Paul who is working with this chip on a parallel setup On Thu, Aug 06, 2020 at 05:38:57PM +0100, Lad, Prabhakar wrote: > Hi Jacopo, > > Thank you for the review. > > On Thu, Aug 6, 2020 at 5:27 PM Jacopo Mondi wrote: > > > > Hi Prabhakar, > >

Re: [PATCH v2 2/4] media: i2c: ov5640: Enable data pins on poweron for DVP mode

2020-08-06 Thread Jacopo Mondi
Hi Prabhakar, On Mon, Aug 03, 2020 at 03:31:45PM +0100, Lad Prabhakar wrote: > During testing this sensor on iW-RainboW-G21D-Qseven platform in 8-bit DVP > mode with rcar-vin bridge noticed the capture worked fine for the first run > (with yavta), but for subsequent runs the bridge driver waited

Re: [PATCH v2 2/3] media: i2c: ov772x: Add support for BT656 mode

2020-08-06 Thread Jacopo Mondi
On Mon, Aug 03, 2020 at 12:39:12PM +0100, Lad Prabhakar wrote: > Add support to read the bus-type and enable BT656 mode if needed. > > The driver defaults to parallel mode if bus-type is not specified in DT. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das > --- >

Re: [PATCH v2 0/4] media: i2c: ov5640 feature enhancement and fixes

2020-08-06 Thread Jacopo Mondi
Hello, On Mon, Aug 03, 2020 at 03:31:43PM +0100, Lad Prabhakar wrote: > Hi All, > > This patch series fixes DVP support and enables BT656 mode in > the driver. > > @Jacopo Mondi - patch 1/4 will collide with your patch series [1], > feel free to merge it as part of your v2.

Re: [PATCH v2 1/3] dt-bindings: media: ov772x: Document endpoint properties

2020-08-06 Thread Jacopo Mondi
Hi Prabhakar, On Mon, Aug 03, 2020 at 12:39:11PM +0100, Lad Prabhakar wrote: > Document endpoint properties required for parallel interface > > Signed-off-by: Lad Prabhakar > --- > .../devicetree/bindings/media/i2c/ov772x.txt | 16 > 1 file changed, 16 insertions(+) > >

Re: [PATCH] media: ov5640: Correct Bit Div register in clock tree diagram

2020-08-05 Thread Jacopo Mondi
he future. Thanks for spotting this! Correct indeed! I'm not sure it's worth a fixes tag, but just in case: Fixes: aa2882481cada ("media: ov5640: Adjust the clock based on the expected rate") Acked-by: Jacopo Mondi > > Signed-off-by: Paul Kocialkowski > --- > drivers/medi

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-07-17 Thread Jacopo Mondi
Hello Eugeniu, On Mon, Jun 15, 2020 at 04:17:23PM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > On Fri, Jun 12, 2020 at 05:12:09PM +0200, Jacopo Mondi wrote: > > On Mon, Jun 08, 2020 at 11:44:32AM +0200, Eugeniu Rosca wrote: > > > FWIW, I seem to hit pre-existing i

Re: [PATCH] MAINTAINERS: Fix sort order for RDACM20

2020-07-16 Thread Jacopo Mondi
d-off-by: Kieran Bingham FWIW Acked-by: Jacopo Mondi Thanks j > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 373e4198d2b1..8bd8d4ab8b5f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS &g

Re: [PATCH 20/25] pinctrl: pinctrl-rza1: Demote some kerneldoc headers and fix others

2020-07-14 Thread Jacopo Mondi
ameter or member > 'rza1_pctl' not described in 'rza1_pin_mux_single' > drivers/pinctrl/pinctrl-rza1.c:672: warning: Excess function parameter > 'pinctrl' description in 'rza1_pin_mux_single' > > Cc: Geert Uytterhoeven > Cc: Jacopo Mondi > Cc: linux-renesas-...@vger.ker

[PATCH v10.1] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286

2020-07-03 Thread Jacopo Mondi
From: Laurent Pinchart The MAX9286 deserializes video data received on up to 4 Gigabit Multimedia Serial Links (GMSL) and outputs them on a CSI-2 port using up to 4 data lanes. Signed-off-by: Laurent Pinchart Signed-off-by: Jacopo Mondi Signed-off-by: Kieran Bingham Reviewed-by: Niklas

Re: [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT

2020-06-24 Thread Jacopo Mondi
Hello On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote: > From: Steve Longerbeam > +Niklas, +Laurent Niklas, Laurent, how does this play with CAP_IO_MC ? Thanks j > This commit enables VIDIOC_ENUMINPUT, VIDIOC_G_INPUT, and VIDIOC_S_INPUT > ioctls for use via v4l2 subdevice

Re: [PATCH v2 3/6] media: ov5647: Add support for non-continuous clock mode

2020-06-22 Thread Jacopo Mondi
Hi Roman, On Mon, Jun 22, 2020 at 10:00:46AM +0300, Roman Kovalivskyi wrote: > Hi Jacopo, > > On 18.06.20 13:13, Jacopo Mondi wrote: > > Hi Roman, Sakari > > > > On Tue, May 19, 2020 at 02:57:07PM +0300, Sakari Ailus wrote: > >> Hi Roman, > >> > &g

<    1   2   3   4   5   6   7   8   9   10   >