On 09/10/2014 07:20 PM, Peter Zijlstra wrote:
On Sat, Aug 30, 2014 at 10:37:40PM +0530, Preeti U Murthy wrote:
- if ((sd-flags SD_SHARE_CPUCAPACITY) weight 1) {
- if (sched_feat(ARCH_CAPACITY))
Aren't you missing this check above? I understand that it is not
crucial
On 09/01/2014 01:35 PM, Vincent Guittot wrote:
On 30 August 2014 19:07, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
On 08/26/2014 04:36 PM, Vincent Guittot wrote:
capacity_orig is only changed for system with a SMT sched_domain level in
order
I think I had asked
On 09/01/2014 02:15 PM, Vincent Guittot wrote:
On 30 August 2014 19:50, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
index 18db43e..60ae1ce 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6049,6 +6049,14 @@ static bool update_sd_pick_busiest(struct lb_env
On 09/03/2014 05:14 PM, Vincent Guittot wrote:
On 3 September 2014 11:11, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 09/01/2014 02:15 PM, Vincent Guittot wrote:
On 30 August 2014 19:50, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
Hi Vincent,
index 18db43e..60ae1ce 100644
in
the above places is incorrect?
Thanks
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
changes made with
-setpolicy drivers that also affect -target drivers in unpredictable ways
and
the other way around.
Okay, I have picked up a very old thread but it looks more sensible to start
replying here..
Preeti (Cc'd) wants to do something similar, i.e. reduce freq of a
core before
On 09/04/2014 02:46 PM, Viresh Kumar wrote:
On 4 September 2014 14:40, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
cpufreq: Allow stop CPU callback to be used by all cpufreq drivers
Commit 367dc4aa introduced the stop CPU callback for intel_pstate
drivers. During the CPU_DOWN_PREPARE
On 09/15/2014 03:32 PM, Kirill Tkhai wrote:
Hi, Preeti,
В Пн, 15/09/2014 в 15:18 +0530, Preeti Murthy пишет:
Hi Kirill,
Which tree is this patch based on? __migrate_task() does a
double_rq_lock/unlock() today in mainline, doesn't it? I don't
however see that in your patch.
it's based
checks on any debug parameters such as powersave_nap .We will then only
need to check for powersave_nap == 0 and return only if that is the
case. This check is still required since the user can disable all deep
idle states by setting powersave_nap to 0.
Regards
Preeti U Murthy
On 10/27/2014 06:56 PM
the above circumstances. If that is no
better we could fall back to cpuidle_idle_loop().
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On 11/10/2014 08:47 PM, Peter Zijlstra wrote:
On Mon, Nov 10, 2014 at 07:50:22PM +0530, Preeti U Murthy wrote:
Hi Peter,
On 11/10/2014 05:59 PM, Peter Zijlstra wrote:
On Fri, Nov 07, 2014 at 03:31:22PM +0100, Daniel Lezcano wrote:
The poll function is called when a timer expired or if we
. As far as I see besides explaining the
bits of core_idle_state structure and the purpose of lock bit the rest
of the comments is redundant. A git-blame will let people know why all
this is needed. The comment section should not be used up for this
purpose IMO.
Regards
Preeti U Murthy
|= SD_PREFER_SIBLING;
sd-imbalance_pct = 110;
sd-smt_gain = 1178; /* ~15% */
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
Hi Jacob,
On 12/23/2014 08:27 AM, Jacob Pan wrote:
On Sat, 20 Dec 2014 07:01:12 +0530
Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
On 12/20/2014 01:26 AM, Thomas Gleixner wrote:
On Fri, 19 Dec 2014, Jacob Pan wrote:
On Thu, 18 Dec 2014 22:12:57 +0100 (CET)
Thomas Gleixner t
. The power numbers have very little
variation between the runs with and without the patchset.
Thanks
Regards
Preeti U Murthy
On 11/25/2014 04:47 PM, Shreyas B. Prabhu wrote:
Deep idle states like sleep and winkle are per core idle states. A core
enters these states only when all the threads enter
On 12/10/2014 06:22 PM, Viresh Kumar wrote:
On 10 December 2014 at 18:03, Preeti U Murthy pre...@linux.vnet.ibm.com
wrote:
Right. We get an interrupt when nobody had asked for it to be delivered
or had asked for it to be delivered and later canceled the request. It
is most often
On 12/11/2014 10:26 AM, Santosh Shukla wrote:
On 11 December 2014 at 10:14, Preeti U Murthy pre...@linux.vnet.ibm.com
wrote:
On 12/10/2014 06:22 PM, Viresh Kumar wrote:
On 10 December 2014 at 18:03, Preeti U Murthy pre...@linux.vnet.ibm.com
wrote:
Right. We get an interrupt when nobody
to force a scheduler tick to update the
jiffies. Since this happens on cpus in a package, all of them get soft
lockedup.
Hope the above explanation makes sense.
Regards
Preeti U Murthy
On 12/12/2014 05:27 PM, Viresh Kumar wrote:
Cc'ing Thomas as well..
On 12 December 2014 at 01:12, Fengguang Wu
On 11/06/2014 05:57 PM, Daniel Lezcano wrote:
On 11/06/2014 05:08 AM, Preeti U Murthy wrote:
On 11/05/2014 07:58 PM, Daniel Lezcano wrote:
On 10/29/2014 03:01 AM, Preeti U Murthy wrote:
On 10/29/2014 12:29 AM, Daniel Lezcano wrote:
On 10/28/2014 04:51 AM, Preeti Murthy wrote:
Hi Daniel
On 11/06/2014 07:12 PM, Daniel Lezcano wrote:
Preeti,
I am wondering if we aren't going to a false debate.
If the latency_req is 0, we should just poll and not enter in any idle
state even if one has zero exit latency. With a zero latency req, we
want full reactivity on the system
();
+ return 1;
+}
+
/**
* cpuidle_idle_call - the main idle function
*
Thanks Daniel!
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Acked-by: Nicolas Pitre n...@linaro.org
Acked-by: Peter Zijlstra (Intel) pet...@infradead.org
Reviewed-by: Len Brown len.br...@intel.com
---
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Regards
Preeti U Murthy
--
To unsubscribe
:
__current_set_polling();
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
the current behavior.
Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org
Acked-by: Nicolas Pitre n...@linaro.org
Reviewed-by: Len Brown len.br...@intel.com
---
This patch looks good to me as well.
Reviewed-by: Preeti U. Murthy
--
To unsubscribe from this list: send the line unsubscribe
Commit dcb18694 Fix ipi on palmeto disabled fastsleep at boot time.
Revert this commit since we no longer need this fix. However we can
continue to use powersave_nap parameter to control entry into deep
idle states beyond snooze.
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
there may be several points that I have missed. But how does
the approach appear? If it looks sane enough, the cases which do not
obviously fall in place can be worked upon.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
design is not too hard.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
operations when the cpu coming online can go out of sync
with
the idle periods. But that situation exists today as well.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Missed Ccing LKML on the previous mail.
drivers/thermal/intel_powerclamp.c | 227
On 12/15/2014 03:02 PM, Viresh Kumar wrote:
On 15 December 2014 at 12:55, Preeti U Murthy pre...@linux.vnet.ibm.com
wrote:
Hi Viresh,
Let me explain why I think this is happening.
1. tick_nohz_irq_enter/exit() both get called *only if the cpu is idle*
and receives an interrupt.
Bang
will not do. It may solve
this regression,but the check is incomplete.
IMO it should simply be :
if (tick_nohz_tick_stopped() || tick_nohz_full_cpu())
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On 11/05/2014 07:58 PM, Daniel Lezcano wrote:
On 10/29/2014 03:01 AM, Preeti U Murthy wrote:
On 10/29/2014 12:29 AM, Daniel Lezcano wrote:
On 10/28/2014 04:51 AM, Preeti Murthy wrote:
Hi Daniel,
On Thu, Oct 23, 2014 at 2:31 PM, Daniel Lezcano
daniel.lezc...@linaro.org wrote:
When the pmqos
the
policy cpus to do this.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
preference if
present, so we don't need to add board-specific code to only register
this in certain conditions.
Hmm.. this makes sense to me. Let me send out a patch to do this.
Regards
Preeti U Murthy
Mark.
---
arch/arm/mach-imx/mach-ls1021a.c | 12
1 file changed, 12
the help of the
broadcast clock device without checking for its existence. Registering a default
broadcast mode will handle such buggy cases properly.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch/arm64/kernel/time.c |2 --
arch/powerpc/kernel/time.c |1 -
kernel
On 12/05/2014 07:09 PM, Mark Rutland wrote:
Hi Preeti,
Moving this out of the architecture code looks good to me!
I have a couple of minor comments below.
snip
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index ec1791f..6044a51 100644
--- a/kernel/time
.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Changes from V1: https://lkml.org/lkml/2014/12/5/261
1.Moved registering the hrtimer based broadcast from timekeeping code
to an early_initcall.
arch/arm64/kernel/time.c |2 --
arch/powerpc/kernel/time.c |1
On 12/08/2014 04:18 PM, Mark Rutland wrote:
Hi Preeti,
On Mon, Dec 08, 2014 at 06:55:43AM +, Preeti U Murthy wrote:
Commit 5d1638acb9f6 ('tick: Introduce hrtimer based broadcast') added a
hrtimer based broadcast mode for those platforms in which local timers stop
when CPUs enter deep
. While at it, give a name to this mode of broadcast which was
missing all along.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Tested-by: Mark Rutland mark.rutl...@arm.com
---
Changes from V1: https://lkml.org/lkml/2014/12/5/261
1.Moved registering the hrtimer based broadcast from
);
+ else
+ print_name_offset(m, dev-set_mode);
SEQ_printf(m, \n);
SEQ_printf(m, event_handler: );
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
by a microsecond by the time we call their
handlers.
Regards
Preeti U Murthy
Tested on: Ivybrdge V2, 12 core X86 server, though it occurs on ARM as well
(but not that frequent).
Regards,
Santosh
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
does not expose residency
values, use default values as a fallback mechanism. While at it, use better
APIs to parse the powermgmt device tree node.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Stewart Smith stew...@linux.vnet.ibm.com
Acked-by: Michael Ellerman m
We currently read the information about idle states from the DT
so as to find out the cpu idle states supported by the platform.
Use those APIs to read from the DT that can avoid endianness
conversions of the property values.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
arch
We currently read the information about idle states from the DT
so as to populate the cpuidle table. Use those APIs to read from
the DT that can avoid endianness conversions of the property values
in the cpuidle driver.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
This patch
power. Hence exit
the idle
poll loop if the tick_broadcast_force_mask gets cleared and enter idle states.
Of course if the cpu has entered cpu_idle_poll() on being asked to poll
explicitly,
it continues to poll till it is asked to reschedule.
Signed-off-by: Preeti U Murthy pre
it explicitly.
It fixes the bug reported here:
http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Changes from V1: https://lkml.org/lkml/2015/1/19/168
1. Modified the Changelog
kernel/time/clockevents.c|2
On 01/20/2015 11:39 AM, Michael Ellerman wrote:
On Mon, 2015-19-01 at 10:26:48 UTC, Preeti U Murthy wrote:
Today if a cpu handling broadcasting of wakeups goes offline, it hands over
It's *the* cpu handling broadcasting of wakeups right? ie. there's only ever
one at a time.
Right, thanks
it explicitly.
It fixes the bug reported here:
http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Changes from previous versions:
1. Modification to the changelog
2. Clarified the comments
kernel/time/clockevents.c
On 01/20/2015 11:15 AM, Michael Ellerman wrote:
On Mon, 2015-19-01 at 11:32:51 UTC, Preeti U Murthy wrote:
The device tree now exposes the residency values for different idle states.
Read
these values instead of calculating residency from the latency values. The
values
exposed in the DT
On 01/20/2015 04:51 PM, Thomas Gleixner wrote:
On Mon, 19 Jan 2015, Preeti U Murthy wrote:
An idle cpu enters cpu_idle_poll() if it is set in the
tick_broadcast_force_mask.
This is so that it does not incur the overhead of entering idle states when
it is expected
to be woken up anytime
On 01/21/2015 05:16 PM, Thomas Gleixner wrote:
On Tue, 20 Jan 2015, Preeti U Murthy wrote:
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 5544990..f3907c9 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -568,6 +568,7 @@ int
phase so that it is visible to
all cpus right after exiting stop_machine, which is when they can re-enter idle.
This ensures that handover of the broadcast duty falls in place on offline,
without
having to do it explicitly.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
kernel/time
does not expose residency
values, use default values as a fallback mechanism. While at it, clump
the common parts of device tree parsing into one chunk.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
drivers/cpuidle/cpuidle-powernv.c | 39 -
1
On 01/21/2015 03:26 PM, Thomas Gleixner wrote:
On Tue, 20 Jan 2015, Preeti U Murthy wrote:
On 01/20/2015 04:51 PM, Thomas Gleixner wrote:
On Mon, 19 Jan 2015, Preeti U Murthy wrote:
An idle cpu enters cpu_idle_poll() if it is set in the
tick_broadcast_force_mask.
This is so that it does
or tick_check_broadcast_expired() returns false, without setting
the resched flag. So a cpu will be caught in cpu_idle_poll() needlessly,
thereby wasting power. Add an explicit check on cpu_idle_force_poll and
tick_check_broadcast_expired() to the exit condition of cpu_idle_poll()
to avoid this.
Signed-off-by: Preeti U
On 02/17/2015 04:09 PM, Peter Zijlstra wrote:
[PATCH 11/35] clockevents: Cleanup dead cpu explicitely
n Tue, Feb 17, 2015 at 09:33:45AM +0530, Preeti U Murthy wrote:
On 02/16/2015 05:45 PM, Peter Zijlstra wrote:
From: Thomas Gleixner t...@linutronix.de
@@ -428,7 +428,7 @@ static int __ref
On 02/18/2015 11:21 AM, Rafael J. Wysocki wrote:
On Wednesday, February 18, 2015 10:13:23 AM Preeti U Murthy wrote:
On 02/17/2015 11:23 PM, Rafael J. Wysocki wrote:
On Tuesday, February 17, 2015 01:29:10 PM Preeti U Murthy wrote:
Hi Rafael,
Hi,
Can you please pull this patch ?
Sorry
On 02/17/2015 11:23 PM, Rafael J. Wysocki wrote:
On Tuesday, February 17, 2015 01:29:10 PM Preeti U Murthy wrote:
Hi Rafael,
Hi,
Can you please pull this patch ?
Sorry, I wasn't sure whether or not the patch was for me to take and then
I've been traveling lately. Applied now.
Hi
, \n);
+ }
+ }
SEQ_printf(m, event_handler: );
print_name_offset(m, dev-event_handler);
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
We currently read the information about idle states from the DT
so as to populate the cpuidle table. Use those APIs to read from
the DT that can avoid endianness conversions of the property values
in the cpuidle driver.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Acked-by: Michael
On 02/18/2015 06:36 PM, Peter Zijlstra wrote:
On Wed, Feb 18, 2015 at 08:40:52AM +0530, Preeti U Murthy wrote:
Look at the changelog,
Heh, yah, clearly I tl;dr'd that. Indeed.
it explains why tick_takeover must be called
*before* __cpu_die().
Since you reported this, can you test
Hi Rafael,
Can you please pull this patch ?
Another patch based on top of this is waiting to be pulled:
[PATCH] driver/cpuidle-powernv: Avoid endianness conversions while parsing DT
Regards
Preeti U Murthy
On 02/03/2015 11:50 AM, Preeti U Murthy wrote:
The device tree now exposes the residency
On 02/16/2015 05:45 PM, Peter Zijlstra wrote:
Reviewed-by: Preeti U Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/17/2015 07:28 AM, Michael Ellerman wrote:
On Sat, 2015-01-31 at 09:44 +0530, Preeti U Murthy wrote:
These duties include do_timer to update jiffies and broadcast wakeups on
those
platforms which do not have an external device to handle wakeup of cpus from
deep
idle states
);
+ tick_takeover(cpu);
Why is tick_handover() called after __cpu_die()? And the function
tick_takeover()
is not introduced until the next patch. tick_broadcast_takeover_bc() is the
function used instead in this patch.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux
On 01/23/2015 10:29 AM, Michael Ellerman wrote:
On Tue, 2015-20-01 at 11:26:49 UTC, Preeti U Murthy wrote:
@@ -177,34 +178,39 @@ static int powernv_add_idle_states(void)
return nr_idle_states;
}
-idle_state_latency = of_get_property(power_mgt
On 01/22/2015 04:45 PM, Thomas Gleixner wrote:
On Thu, 22 Jan 2015, Preeti U Murthy wrote:
On 01/21/2015 05:16 PM, Thomas Gleixner wrote:
How about when the cpu that is going offline receives a timer interrupt
just before setting its state to CPU_DEAD ? That is still possible right
given
does not expose residency
values, use default values as a fallback mechanism. While at it, handle some
cleanups.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Changes from V1: https://lkml.org/lkml/2015/1/19/221
1. Used a better API for reading the DT property values.
2. Code cleanups
On 01/28/2015 02:45 PM, Stewart Smith wrote:
Preeti U Murthy pre...@linux.vnet.ibm.com writes:
The device tree now exposes the residency values for different idle states.
Read
these values instead of calculating residency from the latency values. The
values
exposed in the DT are validated
On 01/27/2015 09:01 AM, Preeti U Murthy wrote:
On 01/22/2015 04:45 PM, Thomas Gleixner wrote:
On Thu, 22 Jan 2015, Preeti U Murthy wrote:
On 01/21/2015 05:16 PM, Thomas Gleixner wrote:
How about when the cpu that is going offline receives a timer interrupt
just before setting its state
On 01/29/2015 03:01 AM, Richard Cochran wrote:
On Wed, Jan 28, 2015 at 03:32:58PM +0530, Preeti U Murthy wrote:
Thomas ping. Would you be posting this patch?
FYI, Thomas is temporarily out of action, in bed with the flu.
Oh I am sorry to hear that! Let me post out a patch based on Thomas's
the broadcast timer upon itself so as to seamlessly
continue both these operations.
It fixes the bug reported here:
http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Changes from V3: https://lkml.org/lkml/2015/1/20/236
1
does not expose residency
values, use default values as a fallback mechanism. While at it, use better
APIs to parse the powermgmt device tree node so as to avoid endianness
transformation.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Changes from V2: https://lkml.org/lkml/2015/1/27
On 02/02/2015 12:09 PM, Michael Ellerman wrote:
On Mon, 2015-02-02 at 10:40 +0530, Preeti U Murthy wrote:
The device tree now exposes the residency values for different idle states.
Read
these values instead of calculating residency from the latency values. The
values
exposed in the DT
On 02/09/2015 11:44 PM, Steven Noonan wrote:
On Mon, Feb 9, 2015 at 9:56 AM, Steven Noonan ste...@uplinklabs.net wrote:
On Mon, Feb 9, 2015 at 3:51 AM, Preeti U Murthy
pre...@linux.vnet.ibm.com wrote:
Hi Steven,
On 02/09/2015 01:02 PM, Steven Noonan wrote:
On Sun, Feb 8, 2015 at 8:49 PM
this :
se-avg.utilization_avg_contrib = group_cfs_rq(se)-utilization_load_avg
? and then the delta with old_contrib be passed ?
Or is this being updated someplace that I have missed ?
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Steven,
On 02/09/2015 01:02 PM, Steven Noonan wrote:
On Sun, Feb 8, 2015 at 8:49 PM, Preeti U Murthy
pre...@linux.vnet.ibm.com wrote:
The powerclamp driver injects idle periods to stay within the thermal
constraints.
The driver does a fake idle by spawning per-cpu threads that call
in this patch is valid.
a. This patch exports the functions to set the quota and period of task groups.
b. This patch removes the constraint of not being able to set the root task
grp's bandwidth.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
V1: https://lkml.org/lkml/2014/12/21/23
V1
non-idle.
As an aside it is helpful to point out that the clock event device that is
programmed here is not a per-cpu clock device; it is a
pseudo clock device, used by the broadcast framework alone.
The per-cpu clock device programming never goes through bc_set_next().
Signed-off-by: Preeti U
On 03/16/2015 08:26 PM, Peter Zijlstra wrote:
On Thu, Mar 05, 2015 at 10:06:30AM +0530, Preeti U Murthy wrote:
On 03/02/2015 08:23 PM, Peter Zijlstra wrote:
On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote:
The hrtimer mode of broadcast queues hrtimers in the idle entry
path
Hi Peter, Ingo, Thomas,
Can you please take a look at the conversation on this thread ?
This fix is urgent.
Regards
Preeti U Murthy
On 03/02/2015 08:26 PM, Peter Zijlstra wrote:
On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote:
The problem reported in the changelog
On 03/16/2015 08:26 PM, Peter Zijlstra wrote:
On Thu, Mar 05, 2015 at 10:06:30AM +0530, Preeti U Murthy wrote:
On 03/02/2015 08:23 PM, Peter Zijlstra wrote:
On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote:
The hrtimer mode of broadcast queues hrtimers in the idle entry
path
Ping.
On 03/16/2015 10:22 AM, Preeti U Murthy wrote:
Hi Peter, Ingo, Thomas,
Can you please take a look at the conversation on this thread ?
This fix is urgent.
Regards
Preeti U Murthy
On 03/02/2015 08:26 PM, Peter Zijlstra wrote:
On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
Preeti, what benchmarks did you use on power8 smt to verify performance?
I'm seeing a slight but statistically significant regression on my
ivb-ep kernel build when I match the build concurrency to my core count.
/me goes run (and install
in
quicker spread of load, instead of performing load balancing within the
local sched domain hierarchy of the ILB CPU alone under circumstances
such as above.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
---
Changes from V1:
1. Added relevant comments
2. Wrapped lines to a fixed width
in, this series looks good to me.
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
more sensible to do this in parallel. The scenario on POWER is
that tasks don't spread out across nodes until 10s of fork. This is
unforgivable and we cannot afford the code to be the way it is today.
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
device */
+ clockevents_set_state(dev,
CLOCK_EVT_STATE_ONESHOT_STOPPED);
goto out;
}
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
an IPI and
is definitely more complex than this immediate fix.
Fixes:
http://linuxppc.10917.n7.nabble.com/offlining-cpus-breakage-td88619.html
Suggested-by: Thomas Gleixner t...@linutronix.de
Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
[Changelog drawn from: https://lkml.org/lkml/2015/2
On 03/30/2015 07:15 PM, Vincent Guittot wrote:
On 26 March 2015 at 14:02, Preeti U Murthy pre...@linux.vnet.ibm.com wrote:
When a CPU is kicked to do nohz idle balancing, it wakes up to do load
balancing on itself, followed by load balancing on behalf of idle CPUs.
But it may end up with load
idle load balancing, but this wakeup is needed and worthwhile for
spreading the load. So I find no problem here too.
I am unable to see the issue. What is it that I am missing ?
Regards
Preeti U Murthy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Hi Jason,
On 03/31/2015 12:25 AM, Jason Low wrote:
Hi Preeti,
I noticed that another commit 4a725627f21d converted the check in
nohz_kick_needed() from idle_cpu() to rq-idle_balance, causing a
potentially outdated value to be used if this cpu is able to pull tasks
using rebalance_domains
))
+ clockevents_set_state(dev,
CLOCK_EVT_STATE_ONESHOT);
+
if (!tick_program_event(
hrtimer_get_expires(ts-sched_timer), 0))
break;
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
--
To unsubscribe from
On 03/31/2015 11:00 PM, Jason Low wrote:
On Tue, 2015-03-31 at 14:28 +0530, Preeti U Murthy wrote:
Morten,
I am a bit confused about the problem you are pointing to.
I am unable to see the issue. What is it that I am missing ?
Hi Preeti,
Here is one of the potential issues
On 04/01/2015 12:24 AM, Jason Low wrote:
On Tue, 2015-03-31 at 14:07 +0530, Preeti U Murthy wrote:
Hi Jason,
On 03/31/2015 12:25 AM, Jason Low wrote:
Hi Preeti,
I noticed that another commit 4a725627f21d converted the check in
nohz_kick_needed() from idle_cpu() to rq-idle_balance, causing
int cpu_nr_cores(void)
{
- return NR_CPUS threads_shift;
+ return nr_cpu_ids threads_shift;
}
Thanks for the patch!
Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com
static inline cpumask_t cpu_online_cores_map(void)
--
To unsubscribe from this list: send the line
Hi Wanpeng
On 03/27/2015 07:42 AM, Wanpeng Li wrote:
Hi Preeti,
On Thu, Mar 26, 2015 at 06:32:44PM +0530, Preeti U Murthy wrote:
1. An ILB CPU was chosen from the first numa domain to trigger nohz idle
load balancing [Given the experiment, upto 6 CPUs per core could be
potentially idle
On 02/26/2015 11:01 AM, Preeti U Murthy wrote:
On 02/23/2015 11:03 PM, Nicolas Pitre wrote:
On Mon, 23 Feb 2015, Nicolas Pitre wrote:
On Mon, 23 Feb 2015, Peter Zijlstra wrote:
The reported function that fails: bL_switcher_restore_cpus() is called
in the error paths of the former
On 03/02/2015 08:23 PM, Peter Zijlstra wrote:
On Thu, Feb 26, 2015 at 08:52:02AM +0530, Preeti U Murthy wrote:
The hrtimer mode of broadcast queues hrtimers in the idle entry
path so as to wakeup cpus in deep idle states.
Callgraph please...
cpuidle_idle_call()
| clockevents_notify
On 03/02/2015 08:26 PM, Peter Zijlstra wrote:
On Fri, Feb 27, 2015 at 02:19:05PM +0530, Preeti U Murthy wrote:
The problem reported in the changelog of this patch is causing severe
regressions very frequently on our machines for certain usecases. It would
help to put in a fix in place first
with RCU_NONIDLE which informs RCU that the cpu
is momentarily non-idle.
Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com
Reviewed-by: Paul E. McKenney paul...@linux.vnet.ibm.com
---
kernel/time/tick-broadcast-hrtimer.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions
501 - 600 of 1331 matches
Mail list logo
