[PATCH v3] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-22 Thread Alexander Kochetkov
From: Alexander Kochetkov DMA-based transfer will be enabled if data length is larger than FIFO size (64 bytes for A64). This greatly reduce number of interrupts for transferring data. For smaller data size PIO mode will be used. In PIO mode whole buffer will be loaded into FIFO. If driver

Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-19 Thread Alexander Kochetkov
> 19 окт. 2020 г., в 11:21, Maxime Ripard написал(а): > > Hi! > > On Thu, Oct 15, 2020 at 06:47:40PM +0300, Alexander Kochetkov wrote: >> DMA-based transfer will be enabled if data length is larger than FIFO size >> (64 bytes for A64). This greatly

[PATCH v2] spi: spi-sun6i: enable autosuspend feature

2020-10-19 Thread Alexander Kochetkov
From: Alexander Kochetkov If SPI is used for periodic polling any sensor, significant delays sometimes appear. Switching on module clocks during resume lead to delays. Enabling autosuspend mode causes the controller to not suspend between SPI transfers and the delays disappear. The commit also

[PATCH v2] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-19 Thread Alexander Kochetkov
From: Alexander Kochetkov DMA-based transfer will be enabled if data length is larger than FIFO size (64 bytes for A64). This greatly reduce number of interrupts for transferring data. For smaller data size PIO mode will be used. In PIO mode whole buffer will be loaded into FIFO. If driver

Re: [PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-19 Thread Alexander Kochetkov
Hi, Maxime! Thanks for reviewing patches! >> >> +static int sun6i_spi_prepare_dma(struct sun6i_spi *sspi, >> + struct spi_transfer *tfr) >> +{ >> +struct dma_async_tx_descriptor *rxdesc, *txdesc; >> +struct spi_master *master = sspi->master; >> + >> +

[PATCH] spi: rockchip: enable autosuspend feature

2020-10-16 Thread Alexander Kochetkov
If SPI is used for periodic polling any sensor, significant delays sometimes appear. Switching on module clocks during resume lead to delays. Enabling autosuspend mode causes the controller to not suspend between SPI transfers and the delays disappear. Signed-off-by: Alexander Kochetkov

[PATCH] spi: spi-sun6i: enable autosuspend feature

2020-10-16 Thread Alexander Kochetkov
If SPI is used for periodic polling any sensor, significant delays sometimes appear. Switching on module clocks during resume lead to delays. Enabling autosuspend mode causes the controller to not suspend between SPI transfers and the delays disappear. Signed-off-by: Alexander Kochetkov

[PATCH] spi: spi-sun6i: implement DMA-based transfer mode

2020-10-15 Thread Alexander Kochetkov
then it fallback for PIO mode. Tested on SOPINE (https://www.pine64.org/sopine/) Signed-off-by: Alexander Kochetkov --- drivers/spi/spi-sun6i.c | 171 +--- 1 file changed, 159 insertions(+), 12 deletions(-) diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi

[PATCH] arm64: dts: allwinner: replace numerical constant with CCU_CLKX

2020-08-03 Thread Alexander Kochetkov
From: Alexander Kochetkov Signed-off-by: Alexander Kochetkov --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index

Re: [PATCH 2/2] mmc: dw_mmc-rockchip: fix transfer hangs on rk3188【请注意,邮件由linux-mmc-ow...@vger.kernel.org代发】

2019-03-21 Thread Alexander Kochetkov
= mmc->max_req_size; > 21 марта 2019 г., в 5:31, Shawn Lin написал(а): > > + Caesar Wang > > On 2019/3/21 1:48, Alexander Kochetkov wrote: >> I've found that sometimes dw_mmc in my rk3188 based board stop transfer >> any data with error: >> kernel: dwmmc_roc

[PATCH 1/2] mmc: dw_mmc: add init_slot() hook to platform function table

2019-03-20 Thread Alexander Kochetkov
The init_slot() hook allow platform driver override slot defaults provided by generic dw_mmc driver. It's required to fix EDMA based transfer hangs observed on rockchip rk3188. Signed-off-by: Alexander Kochetkov --- drivers/mmc/host/dw_mmc.c |4 drivers/mmc/host/dw_mmc.h |2 ++ 2

[PATCH 2/2] mmc: dw_mmc-rockchip: fix transfer hangs on rk3188

2019-03-20 Thread Alexander Kochetkov
st for one transfer. I guess that all other rk3xxx chips that lacks FLUSHP also affected by the problem. So I made fix for all rk3xxx chips from rk2928 to rk3188. Signed-off-by: Alexander Kochetkov --- drivers/mmc/host/dw_mmc-rockchip.c | 19 +++ 1 file changed, 19 insertion

[PATCH 0/2] Fix eMMC hang on rk3188 and earlier

2019-03-20 Thread Alexander Kochetkov
Hello! I found, that sometimes dw_mmc driver stop transfer data to eMMC card on my rk3188 based board. One of tranfers hangs then doing EDMA transfer and controller gives HTO. And here is a fix. Alexander Kochetkov (2): mmc: dw_mmc: add init_slot() hook to platform function table mmc: dw_mmc

Re: [PATCH AUTOSEL for 3.18 34/63] ARM: dts: rockchip: disable arm-global-timer for rk3188

2018-03-04 Thread Alexander Kochetkov
рта 2018 г., в 1:33, Sasha Levin <alexander.le...@microsoft.com> > написал(а): > > From: Alexander Kochetkov <al.koc...@gmail.com> > > [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ] > > The clocksource and the sched_clock provided by the arm_globa

Re: [PATCH AUTOSEL for 3.18 34/63] ARM: dts: rockchip: disable arm-global-timer for rk3188

2018-03-04 Thread Alexander Kochetkov
рта 2018 г., в 1:33, Sasha Levin > написал(а): > > From: Alexander Kochetkov > > [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ] > > The clocksource and the sched_clock provided by the arm_global_timer > are quite unstable because their rates

Re: [PATCH AUTOSEL for 4.4 062/115] ARM: dts: rockchip: disable arm-global-timer for rk3188

2018-03-04 Thread Alexander Kochetkov
рта 2018 г., в 1:31, Sasha Levin <alexander.le...@microsoft.com> > написал(а): > > From: Alexander Kochetkov <al.koc...@gmail.com> > > [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ] > > The clocksource and the sched_clock provided by the arm_globa

Re: [PATCH AUTOSEL for 4.4 062/115] ARM: dts: rockchip: disable arm-global-timer for rk3188

2018-03-04 Thread Alexander Kochetkov
рта 2018 г., в 1:31, Sasha Levin > написал(а): > > From: Alexander Kochetkov > > [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ] > > The clocksource and the sched_clock provided by the arm_global_timer > are quite unstable because their rates

Re: [PATCH AUTOSEL for 4.9 124/219] ARM: dts: rockchip: disable arm-global-timer for rk3188

2018-03-04 Thread Alexander Kochetkov
; 4 марта 2018 г., в 1:29, Sasha Levin <alexander.le...@microsoft.com> > написал(а): > > From: Alexander Kochetkov <al.koc...@gmail.com> > > [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ] > > The clocksource and the sched_clock provided by the arm_globa

Re: [PATCH AUTOSEL for 4.9 124/219] ARM: dts: rockchip: disable arm-global-timer for rk3188

2018-03-04 Thread Alexander Kochetkov
; 4 марта 2018 г., в 1:29, Sasha Levin > написал(а): > > From: Alexander Kochetkov > > [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ] > > The clocksource and the sched_clock provided by the arm_global_timer > are quite unstable because their rates

Re: [PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-29 Thread Alexander Kochetkov
> 29 дек. 2017 г., в 3:14, Stephen Boyd написал(а): > > I'm asking if the rate is capped on the consumer side with > clk_set_max_rate() or if it's capped on the clk provider side to > express a hardware constraint. I do that using clk_set_max_rate() at provider size inside

Re: [PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-29 Thread Alexander Kochetkov
> 29 дек. 2017 г., в 3:14, Stephen Boyd написал(а): > > I'm asking if the rate is capped on the consumer side with > clk_set_max_rate() or if it's capped on the clk provider side to > express a hardware constraint. I do that using clk_set_max_rate() at provider size inside clk-rk3188.c. > >

Re: [PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-28 Thread Alexander Kochetkov
Initial thread here: https://www.spinics.net/lists/linux-clk/msg21682.html > 27 дек. 2017 г., в 4:06, Stephen Boyd написал(а): > > Are these limits the min/max limits that the parent clk can > output at? Or the min/max limits that software has constrained on > the clk? >

Re: [PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-28 Thread Alexander Kochetkov
Initial thread here: https://www.spinics.net/lists/linux-clk/msg21682.html > 27 дек. 2017 г., в 4:06, Stephen Boyd написал(а): > > Are these limits the min/max limits that the parent clk can > output at? Or the min/max limits that software has constrained on > the clk? > Don’t know how to

Re: [PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-25 Thread Alexander Kochetkov
> 21 дек. 2017 г., в 23:07, Stephen Boyd написал(а): > > Can you convert to the determine_rate op instead of round_rate? > That function should tell you the min/max limits so that you > don't need to query that information from the core. I converted

Re: [PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-25 Thread Alexander Kochetkov
> 21 дек. 2017 г., в 23:07, Stephen Boyd написал(а): > > Can you convert to the determine_rate op instead of round_rate? > That function should tell you the min/max limits so that you > don't need to query that information from the core. I converted rockchip_fractional_approximation() to

[PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-21 Thread Alexander Kochetkov
r than one configured using clk_set_max_rate(). Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/clk/clk.c| 14 -- include/linux/clk-provider.h |2 ++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/clk/clk.c b/drivers

[PATCH 0/2] Fix clock rate in the rockchip_fractional_approximation()

2017-12-21 Thread Alexander Kochetkov
al clk's jitter"). Alexander Kochetkov (2): clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose clk: rockchip: limit clock rate in the rockchip_fractional_approximation() drivers/clk/clk.c| 14 -- drivers/clk/rockchip/clk.c |7 ++

[PATCH 1/2] clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose

2017-12-21 Thread Alexander Kochetkov
r than one configured using clk_set_max_rate(). Signed-off-by: Alexander Kochetkov --- drivers/clk/clk.c| 14 -- include/linux/clk-provider.h |2 ++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index c8d83ac..8943

[PATCH 0/2] Fix clock rate in the rockchip_fractional_approximation()

2017-12-21 Thread Alexander Kochetkov
al clk's jitter"). Alexander Kochetkov (2): clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and expose clk: rockchip: limit clock rate in the rockchip_fractional_approximation() drivers/clk/clk.c| 14 -- drivers/clk/rockchip/clk.c |7 ++

[PATCH 2/2] clk: rockchip: limit clock rate in the rockchip_fractional_approximation()

2017-12-21 Thread Alexander Kochetkov
ecial approximation to fix up fractional clk's jitter"). Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/clk/rockchip/clk.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c index 35dbd63

[PATCH 2/2] clk: rockchip: limit clock rate in the rockchip_fractional_approximation()

2017-12-21 Thread Alexander Kochetkov
ecial approximation to fix up fractional clk's jitter"). Signed-off-by: Alexander Kochetkov --- drivers/clk/rockchip/clk.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c index 35dbd63..3c1fb0d 100644 --- a/drivers/clk/rock

Re: [PATCH] net: arc_emac: fix arc_emac_rx() error paths

2017-12-19 Thread Alexander Kochetkov
> 19 дек. 2017 г., в 18:22, David Miller <da...@davemloft.net> написал(а): > > From: Alexander Kochetkov <al.koc...@gmail.com> > Date: Fri, 15 Dec 2017 20:20:06 +0300 > >> arc_emac_rx() has some issues found by code review. >> >> In case netdev_all

Re: [PATCH] net: arc_emac: fix arc_emac_rx() error paths

2017-12-19 Thread Alexander Kochetkov
> 19 дек. 2017 г., в 18:22, David Miller написал(а): > > From: Alexander Kochetkov > Date: Fri, 15 Dec 2017 20:20:06 +0300 > >> arc_emac_rx() has some issues found by code review. >> >> In case netdev_alloc_skb_ip_align() or dma_map_single() failure >

[PATCH v2] net: arc_emac: fix arc_emac_rx() error paths

2017-12-19 Thread Alexander Kochetkov
will not be provided to EMAC. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- Changes in v2: - Rebased against stable linux-4.14.y branch drivers/net/ethernet/arc/emac_main.c | 53 -- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/d

[PATCH v2] net: arc_emac: fix arc_emac_rx() error paths

2017-12-19 Thread Alexander Kochetkov
will not be provided to EMAC. Signed-off-by: Alexander Kochetkov --- Changes in v2: - Rebased against stable linux-4.14.y branch drivers/net/ethernet/arc/emac_main.c | 53 -- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/arc

[PATCH v2] net: arc_emac: restart stalled EMAC

2017-12-19 Thread Alexander Kochetkov
a broadcast storm. For example, running on PC 'ping' to some IP address triggers ARP-request storm. After some time (~10sec), EMAC on rk3188 will stall. Observed and tested on rk3188 radxarock. [1] https://en.wikipedia.org/wiki/Broadcast_radiation Signed-off-by: Alexander Kochetkov <al.koc...@gmail.

[PATCH v2] net: arc_emac: restart stalled EMAC

2017-12-19 Thread Alexander Kochetkov
a broadcast storm. For example, running on PC 'ping' to some IP address triggers ARP-request storm. After some time (~10sec), EMAC on rk3188 will stall. Observed and tested on rk3188 radxarock. [1] https://en.wikipedia.org/wiki/Broadcast_radiation Signed-off-by: Alexander Kochetkov --- Changes in v2

[PATCH] net: arc_emac: fix arc_emac_rx() error paths

2017-12-15 Thread Alexander Kochetkov
will not be provided to EMAC. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/net/ethernet/arc/emac_main.c | 53 -- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethern

[PATCH] net: arc_emac: fix arc_emac_rx() error paths

2017-12-15 Thread Alexander Kochetkov
will not be provided to EMAC. Signed-off-by: Alexander Kochetkov --- drivers/net/ethernet/arc/emac_main.c | 53 -- 1 file changed, 31 insertions(+), 22 deletions(-) diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c index b2e0051

[PATCH] net: arc_emac: restart stalled EMAC

2017-12-15 Thread Alexander Kochetkov
a broadcast storm. For example, running on PC 'ping' to some IP address triggers ARP-request storm. After some time (~10sec), EMAC on rk3188 will stall. Observed and tested on rk3188 radxarock. [1] https://en.wikipedia.org/wiki/Broadcast_radiation Signed-off-by: Alexander Kochetkov <al.koc...@gmail.

[PATCH] net: arc_emac: restart stalled EMAC

2017-12-15 Thread Alexander Kochetkov
a broadcast storm. For example, running on PC 'ping' to some IP address triggers ARP-request storm. After some time (~10sec), EMAC on rk3188 will stall. Observed and tested on rk3188 radxarock. [1] https://en.wikipedia.org/wiki/Broadcast_radiation Signed-off-by: Alexander Kochetkov --- drivers/net

Re: [PATCH v2 1/2] dmaengine: pl330: fix descriptor allocation fail

2017-10-16 Thread Alexander Kochetkov
, Alexander. > 4 окт. 2017 г., в 14:37, Alexander Kochetkov <al.koc...@gmail.com> написал(а): > > If two concurrent threads call pl330_get_desc() when DMAC descriptor > pool is empty it is possible that allocation for one of threads will fail > with message: > > ker

Re: [PATCH v2 1/2] dmaengine: pl330: fix descriptor allocation fail

2017-10-16 Thread Alexander Kochetkov
, Alexander. > 4 окт. 2017 г., в 14:37, Alexander Kochetkov написал(а): > > If two concurrent threads call pl330_get_desc() when DMAC descriptor > pool is empty it is possible that allocation for one of threads will fail > with message: > > kernel: dma-pl330 20078000.dma-contr

[PATCH v2 1/2] dmaengine: pl330: fix descriptor allocation fail

2017-10-04 Thread Alexander Kochetkov
for thread A will fail. Using on-stack pool for new descriptor allow avoid the issue described. The patch modify pl330_get_desc() to use on-stack pool for allocation new descriptors. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/dma/pl330.c

[PATCH v2 1/2] dmaengine: pl330: fix descriptor allocation fail

2017-10-04 Thread Alexander Kochetkov
for thread A will fail. Using on-stack pool for new descriptor allow avoid the issue described. The patch modify pl330_get_desc() to use on-stack pool for allocation new descriptors. Signed-off-by: Alexander Kochetkov --- drivers/dma/pl330.c | 39 --- 1 file changed

[PATCH v2 2/2] !!! FOR TESTING ONLY !!! dmaengine: pl330: add verbose message and set NR_DEFAULT_DESC to 1

2017-10-04 Thread Alexander Kochetkov
descriptor [1.344912] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor --- rest of similar lines omitted --- Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/dma/pl330.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH v2 2/2] !!! FOR TESTING ONLY !!! dmaengine: pl330: add verbose message and set NR_DEFAULT_DESC to 1

2017-10-04 Thread Alexander Kochetkov
descriptor [1.344912] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated one more descriptor --- rest of similar lines omitted --- Signed-off-by: Alexander Kochetkov --- drivers/dma/pl330.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/pl330.c b

[PATCH v2 0/2] dmaengine: pl330: fix descriptor allocation fail

2017-10-04 Thread Alexander Kochetkov
Here is the patch fixing descriptor allocation issue. Could someone with pl330 hardware test it and confirm that it doesn't brake current pl330 driver? I will be very grateful to you! Changes in v2: - removed wrappers add_desc(), pluck_desc() - fix code intendation Alexander Kochetkov (2

[PATCH v2 0/2] dmaengine: pl330: fix descriptor allocation fail

2017-10-04 Thread Alexander Kochetkov
Here is the patch fixing descriptor allocation issue. Could someone with pl330 hardware test it and confirm that it doesn't brake current pl330 driver? I will be very grateful to you! Changes in v2: - removed wrappers add_desc(), pluck_desc() - fix code intendation Alexander Kochetkov (2

Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-26 Thread Alexander Kochetkov
Hello Vinod! Thanks for review! > 26 сент. 2017 г., в 20:37, Vinod Koul написал(а): > > Tested-by please... In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC defined to 1 and with some trace code included. Is it OK if I provide second patch I

Re: [PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-26 Thread Alexander Kochetkov
Hello Vinod! Thanks for review! > 26 сент. 2017 г., в 20:37, Vinod Koul написал(а): > > Tested-by please... In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC defined to 1 and with some trace code included. Is it OK if I provide second patch I used for testing with

[PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-08 Thread Alexander Kochetkov
described will nether happen. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/dma/pl330.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index f37f497..0e7f6c9

[PATCH] dmaengine: pl330: fix descriptor allocation fail

2017-09-08 Thread Alexander Kochetkov
described will nether happen. Signed-off-by: Alexander Kochetkov --- drivers/dma/pl330.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index f37f497..0e7f6c9 100644 --- a/drivers/dma/pl330.c

Re: [PATCH 0/2] Free running cyclic transfer implementation for pl330

2017-04-26 Thread Alexander Kochetkov
Hello! Just to let you know, that I got following test report from Stephen (thanks a lot!). The patch won’t work due to full cyclic transfer doesn’t fit into mcbufsz (256 bytes long). His application requested driver to do cyclic transfer with large number of cycles. pl330 microcode has

Re: [PATCH 0/2] Free running cyclic transfer implementation for pl330

2017-04-26 Thread Alexander Kochetkov
Hello! Just to let you know, that I got following test report from Stephen (thanks a lot!). The patch won’t work due to full cyclic transfer doesn’t fit into mcbufsz (256 bytes long). His application requested driver to do cyclic transfer with large number of cycles. pl330 microcode has

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-25 Thread Alexander Kochetkov
Hello David! > 25 апр. 2017 г., в 17:36, David Miller написал(а): > > So... what are we doing here? > > My understanding is that this should fix the same problem that commit > 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto > negotiation on startup")

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-25 Thread Alexander Kochetkov
Hello David! > 25 апр. 2017 г., в 17:36, David Miller написал(а): > > So... what are we doing here? > > My understanding is that this should fix the same problem that commit > 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto > negotiation on startup") fixed and that this

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-21 Thread Alexander Kochetkov
> 21 апр. 2017 г., в 17:18, Roger Quadros написал(а): > > I think the following commit broke functionality with interrupt driven PHYs > 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not > polling.") Probably this one[1] broke, according to Alexandre’s

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-21 Thread Alexander Kochetkov
> 21 апр. 2017 г., в 17:18, Roger Quadros написал(а): > > I think the following commit broke functionality with interrupt driven PHYs > 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not > polling.") Probably this one[1] broke, according to Alexandre’s commit[2]. And it

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Alexander Kochetkov
startup time for boards with Micrel PHY on 3~5 sec (auto-negotiation time[2]). Could you check that also? Regards, Alexander. [1] https://lkml.org/lkml/2017/4/20/357 [2] http://www.ieee802.org/3/af/public/jan02/brown_1_0102.pdf > 20 апр. 2017 г., в 14:00, Alexander Kochetkov <al.koc...@gma

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Alexander Kochetkov
startup time for boards with Micrel PHY on 3~5 sec (auto-negotiation time[2]). Could you check that also? Regards, Alexander. [1] https://lkml.org/lkml/2017/4/20/357 [2] http://www.ieee802.org/3/af/public/jan02/brown_1_0102.pdf > 20 апр. 2017 г., в 14:00, Alexander Kochetkov > нап

Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

2017-04-20 Thread Alexander Kochetkov
> 20 апр. 2017 г., в 13:06, Jaehoon Chung написал(а): > > I think you are not using the latest kernel. which version do you use? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9 > > Could you

Re: [PATCH] mmc: dw_mmc: hide clock message when card is resuming

2017-04-20 Thread Alexander Kochetkov
> 20 апр. 2017 г., в 13:06, Jaehoon Chung написал(а): > > I think you are not using the latest kernel. which version do you use? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9 > > Could you check this? Commit

[PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-20 Thread Alexander Kochetkov
phy_start_aneg() to phy_start(). Also the patch add call to phy_stop() to arc_emac_stop() to allow the PHY device to be fully suspended when the interface is unused. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- Changes in v2: - Updated commit message to clarify changes d

[PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-20 Thread Alexander Kochetkov
phy_start_aneg() to phy_start(). Also the patch add call to phy_stop() to arc_emac_stop() to allow the PHY device to be fully suspended when the interface is unused. Signed-off-by: Alexander Kochetkov --- Changes in v2: - Updated commit message to clarify changes drivers/net/ethernet/arc

[PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Alexander Kochetkov
get it. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> Cc: stable <sta...@vger.kernel.org> # v4.9+ --- drivers/net/phy/phy.c | 40 include/linux/phy.h |1 + 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Alexander Kochetkov
get it. Signed-off-by: Alexander Kochetkov Cc: stable # v4.9+ --- drivers/net/phy/phy.c | 40 include/linux/phy.h |1 + 2 files changed, 37 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 7cc1b7d

[PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Alexander Kochetkov
atch[2] and this one patch will get upstream instead of patch[2]. Could you please test it? Regards, Alexander. [1] http://patchwork.ozlabs.org/patch/743773/ [2] https://lkml.org/lkml/2017/3/30/517 Alexander Kochetkov (1): net: phy: fix auto-negotiation stall due to unavailable interrupt drive

[PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-20 Thread Alexander Kochetkov
will get upstream instead of patch[2]. Could you please test it? Regards, Alexander. [1] http://patchwork.ozlabs.org/patch/743773/ [2] https://lkml.org/lkml/2017/3/30/517 Alexander Kochetkov (1): net: phy: fix auto-negotiation stall due to unavailable interrupt drivers/net/phy/phy.c | 40

Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-19 Thread Alexander Kochetkov
rgei Shtylyov > <sergei.shtyl...@cogentembedded.com> написал(а): > > On 04/19/2017 05:29 PM, Alexander Kochetkov wrote: > >> The patch replace phy_start_aneg() with phy_start(). phy_start() call > > Replaces. > >> phy_start_aneg() as a part of startup seq

Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-19 Thread Alexander Kochetkov
): > > On 04/19/2017 05:29 PM, Alexander Kochetkov wrote: > >> The patch replace phy_start_aneg() with phy_start(). phy_start() call > > Replaces. > >> phy_start_aneg() as a part of startup sequence and allow recover from >> error (PHY_HALTED) state. >

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
> 19 апр. 2017 г., в 19:32, Florian Fainelli написал(а): > > http://patchwork.ozlabs.org/patch/743773/ > > Roger can you also test Alexander's patch? If MAC use phy_start_aneg() instead of phy_start() my patch will not work as expected. Roger, if patch don’t work for you

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
> 19 апр. 2017 г., в 19:32, Florian Fainelli написал(а): > > http://patchwork.ozlabs.org/patch/743773/ > > Roger can you also test Alexander's patch? If MAC use phy_start_aneg() instead of phy_start() my patch will not work as expected. Roger, if patch don’t work for you please check what MAC

[PATCH] mmc: dw_mmc: hide clock message when card is resuming

2017-04-19 Thread Alexander Kochetkov
force setup bus if active slots exist") Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/mmc/host/dw_mmc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 73db085..faaf2c1 100644 --- a

[PATCH] mmc: dw_mmc: hide clock message when card is resuming

2017-04-19 Thread Alexander Kochetkov
force setup bus if active slots exist") Signed-off-by: Alexander Kochetkov --- drivers/mmc/host/dw_mmc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 73db085..faaf2c1 100644 --- a/drivers/mmc/host/dw_mmc.c ++

[PATCH] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-19 Thread Alexander Kochetkov
The patch replace phy_start_aneg() with phy_start(). phy_start() call phy_start_aneg() as a part of startup sequence and allow recover from error (PHY_HALTED) state. Also added call phy_stop() to arc_emac_remove() to stop PHY state machine when MAC is down. Signed-off-by: Alexander Kochetkov

[PATCH] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-19 Thread Alexander Kochetkov
The patch replace phy_start_aneg() with phy_start(). phy_start() call phy_start_aneg() as a part of startup sequence and allow recover from error (PHY_HALTED) state. Also added call phy_stop() to arc_emac_remove() to stop PHY state machine when MAC is down. Signed-off-by: Alexander Kochetkov

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
Just found similar problem fixed in another PHY. See commit 99f81afc139c ("phy: micrel: Disable auto negotiation on startup») > 19 апр. 2017 г., в 16:46, Alexander Kochetkov <al.koc...@gmail.com> > написал(а): > > The problem I fix related to SMSC LAN8710/LAN8720 PHY han

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
Just found similar problem fixed in another PHY. See commit 99f81afc139c ("phy: micrel: Disable auto negotiation on startup») > 19 апр. 2017 г., в 16:46, Alexander Kochetkov > написал(а): > > The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using > interru

[PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/net/phy/phy.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 7cc1b7d..da8f03d 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -1169,6

[PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Alexander Kochetkov
Signed-off-by: Alexander Kochetkov --- drivers/net/phy/phy.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 7cc1b7d..da8f03d 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -1169,6 +1169,18 @@ void phy_sta

[PATCH 2/2] dmaengine: pl330: don't emit code for one iteration loop

2017-04-14 Thread Alexander Kochetkov
The patch remove one iteration outer loop in the _loop(). Removing loop saves 4 bytes of MicroCode buffer. This savings make sense for free-running cyclic transfer implementation. DMALP_0 0 ... DMALPENDA_0 bjmpto_9 Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- d

[PATCH 2/2] dmaengine: pl330: don't emit code for one iteration loop

2017-04-14 Thread Alexander Kochetkov
The patch remove one iteration outer loop in the _loop(). Removing loop saves 4 bytes of MicroCode buffer. This savings make sense for free-running cyclic transfer implementation. DMALP_0 0 ... DMALPENDA_0 bjmpto_9 Signed-off-by: Alexander Kochetkov --- drivers/dma/pl330.c |8

[PATCH 1/2] dmaengine: pl330: make cyclic transfer free runnable

2017-04-14 Thread Alexander Kochetkov
. As a result, lost samples and clicks gone. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/dma/pl330.c | 192 +-- 1 file changed, 94 insertions(+), 98 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c

[PATCH 1/2] dmaengine: pl330: make cyclic transfer free runnable

2017-04-14 Thread Alexander Kochetkov
. As a result, lost samples and clicks gone. Signed-off-by: Alexander Kochetkov --- drivers/dma/pl330.c | 192 +-- 1 file changed, 94 insertions(+), 98 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 7539f73..56a2377 100644

[PATCH 0/2] Free running cyclic transfer implementation for pl330

2017-04-14 Thread Alexander Kochetkov
can someone test this. I would not like pl330 to be broken again Now I was asked about the series[1] again by guys from Rockchip, so I send rebased against 4.10.10 version. Hope, someone might test it and confirm that patches work fine. Regards, Alexander. Alexander Kochetkov (2): dmaengine:

[PATCH 0/2] Free running cyclic transfer implementation for pl330

2017-04-14 Thread Alexander Kochetkov
would not like pl330 to be broken again Now I was asked about the series[1] again by guys from Rockchip, so I send rebased against 4.10.10 version. Hope, someone might test it and confirm that patches work fine. Regards, Alexander. Alexander Kochetkov (2): dmaengine: pl330: make cyclic transfe

Re: [PATCH v7 0/7] Implement clocksource for rockchip SoC using rockchip timer

2017-03-29 Thread Alexander Kochetkov
like clksrc-of»). What do you think? [1] https://lkml.org/lkml/2017/3/29/286 [2] https://lkml.org/lkml/2017/1/31/401 [3] https://lkml.org/lkml/2017/3/22/508 [4] https://lkml.org/lkml/2017/3/22/420 [5] https://lkml.org/lkml/2017/3/22/426 > 22 марта 2017 г., в 18:48, Alexander Kochetkov <al.koc..

Re: [PATCH v7 0/7] Implement clocksource for rockchip SoC using rockchip timer

2017-03-29 Thread Alexander Kochetkov
like clksrc-of»). What do you think? [1] https://lkml.org/lkml/2017/3/29/286 [2] https://lkml.org/lkml/2017/1/31/401 [3] https://lkml.org/lkml/2017/3/22/508 [4] https://lkml.org/lkml/2017/3/22/420 [5] https://lkml.org/lkml/2017/3/22/426 > 22 марта 2017 г., в 18:48, Alexander Kochetkov >

[PATCH] clk: rockchip: limit i2s0_pre max rate on rk3188

2017-03-24 Thread Alexander Kochetkov
i2s0_pre rate. Probably rk3188 has some sort of frequency restrictions imposed. Haven't found anything in the RK3188 TRM, so this is my assumption. Anyway, with the patch, all the issues gone. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- drivers/clk/rockchip/clk-rk3188.c

[PATCH] clk: rockchip: limit i2s0_pre max rate on rk3188

2017-03-24 Thread Alexander Kochetkov
i2s0_pre rate. Probably rk3188 has some sort of frequency restrictions imposed. Haven't found anything in the RK3188 TRM, so this is my assumption. Anyway, with the patch, all the issues gone. Signed-off-by: Alexander Kochetkov --- drivers/clk/rockchip/clk-rk3188.c |9 + 1 file changed

Re: [PATCH v7 5/7] clocksource/drivers/rockchip_timer: implement clocksource timer

2017-03-24 Thread Alexander Kochetkov
; url: > https://github.com/0day-ci/linux/commits/Alexander-Kochetkov/Implement-clocksource-for-rockchip-SoC-using-rockchip-timer/20170324-113008 > config: arm64-defconfig (attached as .config) > compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: >

Re: [PATCH v7 5/7] clocksource/drivers/rockchip_timer: implement clocksource timer

2017-03-24 Thread Alexander Kochetkov
s://github.com/0day-ci/linux/commits/Alexander-Kochetkov/Implement-clocksource-for-rockchip-SoC-using-rockchip-timer/20170324-113008 > config: arm64-defconfig (attached as .config) > compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > reproduce: >wget > https://ra

Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock

2017-03-22 Thread Alexander Kochetkov
> 22 марта 2017 г., в 20:04, Alexander Kochetkov <al.koc...@gmail.com> > написал(а): > > Ok. Let leave as is for now. > > My radxa worked stable for a year with this settings. Ok, I not sure what my radxa worked stable with this settings. Hieko, thanks for catching that. Sorry for your time.

Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock

2017-03-22 Thread Alexander Kochetkov
> 22 марта 2017 г., в 20:04, Alexander Kochetkov > написал(а): > > Ok. Let leave as is for now. > > My radxa worked stable for a year with this settings. Ok, I not sure what my radxa worked stable with this settings. Hieko, thanks for catching that. Sorry for your time.

Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock

2017-03-22 Thread Alexander Kochetkov
> 22 марта 2017 г., в 19:47, Heiko Stuebner написал(а): > > sorry, but I will not apply this patch at this time. > When testing on my radxarock with the card I always use upon entering the > rootfs everything explodes with -110 errors, while without that patch the > card >

Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock

2017-03-22 Thread Alexander Kochetkov
> 22 марта 2017 г., в 19:47, Heiko Stuebner написал(а): > > sorry, but I will not apply this patch at this time. > When testing on my radxarock with the card I always use upon entering the > rootfs everything explodes with -110 errors, while without that patch the > card > runs stable as

Re: [PATCH] ARM: dts: rockchip: setup DMA-channels for mmc0 and emmc for rk3188

2017-03-22 Thread Alexander Kochetkov
Hello, Heiko! > 22 марта 2017 г., в 18:54, Heiko Stuebner написал(а): > > I've applied a slightly different variant in [0] with your commit message and > moved the dma properties to the mmc/emmc nodes in rk3xxx.dtsi - as the dma > channels are the same on both rk3188 and

Re: [PATCH] ARM: dts: rockchip: setup DMA-channels for mmc0 and emmc for rk3188

2017-03-22 Thread Alexander Kochetkov
Hello, Heiko! > 22 марта 2017 г., в 18:54, Heiko Stuebner написал(а): > > I've applied a slightly different variant in [0] with your commit message and > moved the dma properties to the mmc/emmc nodes in rk3xxx.dtsi - as the dma > channels are the same on both rk3188 and rk3066. Thank you! I

[PATCH v7 7/7] ARM: dts: rockchip: disable arm-global-timer for rk3188

2017-03-22 Thread Alexander Kochetkov
the stable rockchip clocksource. Let's disable the arm_global_timer in order to have the rockchip clocksource selected by default. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> Reviewed-by: Heiko Stuebner <he...@sntech.de> --- arch/arm/boot/dts/rk3188.dtsi |1 + 1 fil

  1   2   3   4   5   >