Re: [PATCH] i2c: virtio: Constify struct i2c_algorithm and struct virtio_device_id

Hi Christophe, On Sun, Sep 08, 2024 at 08:52:07AM GMT, Christophe JAILLET wrote: > 'struct i2c_algorithm' and 'struct virtio_device_id' are not modified in > this driver. > > Constifying this structure moves some data to a read-only section, so > increase overall security, especially when the str

Re: [PATCH 0/2] Cleanup the MAINTAINER's file

Hi Wolfram, On Fri, Jul 12, 2024 at 08:34:11AM GMT, Wolfram Sang wrote: > On Fri, Jul 12, 2024 at 01:19:24AM +0200, Andi Shyti wrote: > > Hi, > > > > while reviewing Wolfram's series, I received some delivery > > failure notifications for e-mails that don

[PATCH 0/2] Cleanup the MAINTAINER's file

alizat...@lists.linux.dev Andi Shyti (2): MAINTAINERS: i2c-virtio: Drop Conghui Chen from Maintainers MAINTAINERS: Drop Thor Thayer from maintainers MAINTAINERS | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) -- 2.45.2

[PATCH 1/2] MAINTAINERS: i2c-virtio: Drop Conghui Chen from Maintainers

E-mails to Conghui Chen have bounced back: : host mgamail.eglb.intel.com[198.175.65.14] said: 550 #5.1.0 Address rejected. (in reply to RCPT TO command) Remove him as maintainer of the i2c Virtio driver in the MAINTAINERS file. Signed-off-by: Andi Shyti Cc: Viresh Kumar Cc: Wolfram

Re: [PATCH v2 00/60] i2c: reword first drivers according to newest specification

Hi Wolfram, pushed in i2c/i2c-host. Thanks for this big work, at the end it turned out quite nice and I'm happy of the outcome! Thanks Andi On Sat, Jul 06, 2024 at 01:20:00PM GMT, Wolfram Sang wrote: > Start changing the wording of the I2C main header wrt. the newest I2C > v7 and SMBus 3.2 spec

Re: [PATCH v2 58/60] i2c: virtio: reword according to newest specification

Hi Wolfram, On Sat, Jul 06, 2024 at 01:20:58PM GMT, Wolfram Sang wrote: > Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2 > specifications and replace "master/slave" with more appropriate terms. > > Signed-off-by: Wolfram Sang Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

Hi Wolfram, > > @Andi: are you okay with this approach? It means you'd need to merge > > -rc2 into your for-next branch. Or rebase if all fails. > > I think it's a good plan, I'll try to support you with it. Do you feel more comfortable if I take the patches as soon as they are reviewd? So far

Re: [PATCH 00/64] i2c: reword i2c_algorithm according to newest specification

Hi Wolfram, On Fri, Mar 22, 2024 at 02:24:53PM +0100, Wolfram Sang wrote: > Okay, we need to begin somewhere... > > Start changing the wording of the I2C main header wrt. the newest I2C > v7, SMBus 3.2, I3C specifications and replace "master/slave" with more > appropriate terms. This first step r

Re: [PATCH v3 1/5] arch,locking/atomic: arc: arch_cmpxchg should check data size

Hi Wuqiang, On Tue, Nov 21, 2023 at 10:23:43PM +0800, wuqiang.matt wrote: > arch_cmpxchg() should check data size rather than pointer size in case > CONFIG_ARC_HAS_LLSC is defined. So rename __cmpxchg to __cmpxchg_32 to > emphasize it's explicit support of 32bit data size with BUILD_BUG_ON() > add

Re: [PATCH v2] input: s6sy761: fix coordinate read bit shift

support for the Samsung S6SY761 > touchscreen") > Signed-off-by: Caleb Connolly Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH] input: s6sy761: fix coordinate read bit shift

[2] << 3) | (event[3] & S6SY761_MASK_Y); > + u16 x = (event[1] << 4) | ((event[3] & S6SY761_MASK_X) >> 4); > + u16 y = (event[2] << 4) | (event[3] & S6SY761_MASK_Y); the devil knows how that '3' has ended up there :) Thanks for catching it! Reviewed-by: Andi Shyti Andi

Re: [PATCH -next] Input: stmfts - Fix a & vs && typo

creen") > Signed-off-by: YueHaibing Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH] spi: s3c24xx: correct kerneldoc comment

27; > > Signed-off-by: Krzysztof Kozlowski thanks, Acked-by: Andi Shyti Andi

Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

t; > > > - int err; > > > + int err = 0; > > > > you don't need the initialization here. > > But it's close enough that I can munge the patch inline. > Reviewed-by: Chris Wilson sure... you can also remove it before merging it and it migh

Re: [PATCH] drm/i915: Fix wrong return value

Hi Tianjia, > diff --git a/drivers/gpu/drm/i915/i915_active.c > b/drivers/gpu/drm/i915/i915_active.c > index d960d0be5bd2..cc017e3cc9c5 100644 > --- a/drivers/gpu/drm/i915/i915_active.c > +++ b/drivers/gpu/drm/i915/i915_active.c > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(st

Re: [PATCH v2] HID: i2c-hid: Use block reads when possible to save power

Hi Sultan, > > > > so the only strategy available up until now has been to always retrieve > > > > the maximum possible report length over i2c, which can be quite > > > > inefficient. For devices that send reports in block read format, the i2c > > > > controller driver can read the payload length

Re: [PATCH v2] HID: i2c-hid: Use block reads when possible to save power

Hi Andy, > > so the only strategy available up until now has been to always retrieve > > the maximum possible report length over i2c, which can be quite > > inefficient. For devices that send reports in block read format, the i2c > > controller driver can read the payload length on the fly and ter

Re: [PATCH 3/3] Input: mms114 - add support for mms345l

Hi Dmitry, > > > > There was a related patch [2] that removes I2C_M_NOSTART for all models, > > > > but it seems abandoned and I do not have any other model for testing. > > > > Therefore, this patch implements the least instrusive solution > > > > and only removes I2C_M_NOSTART for MMS345L. > > >

Re: [PATCH 3/3] Input: mms114 - add support for mms345l

Hi Stephan, > > > There was a related patch [2] that removes I2C_M_NOSTART for all models, > > > but it seems abandoned and I do not have any other model for testing. > > > Therefore, this patch implements the least instrusive solution > > > and only removes I2C_M_NOSTART for MMS345L. > > > > Hmm

Re: [PATCH 3/3] Input: mms114 - add support for mms345l

Hi Dmitry, > > There was a related patch [2] that removes I2C_M_NOSTART for all models, > > but it seems abandoned and I do not have any other model for testing. > > Therefore, this patch implements the least instrusive solution > > and only removes I2C_M_NOSTART for MMS345L. > > Hmm, at this po

Re: [PATCH 3/3] Input: mms114 - add support for mms345l

> > - if (!i2c_check_functionality(client->adapter, > > - I2C_FUNC_PROTOCOL_MANGLING)) { > > + type = (enum mms_type)device_get_match_data(&client->dev); > > you don't need any cast here. sorry, please ignore :) Andi

Re: [PATCH 1/3] Input: mms114 - use device_get_match_data

Hi Stephan, > device_get_match_data is available now, so we can replace the call > to of_device_get_match_data and remove the FIXME comment. > > Signed-off-by: Stephan Gerhold Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 2/3] dt-bindings: mms114: document melfas,mms345l binding

Hi Stephan, On Mon, Oct 07, 2019 at 10:33:42PM +0200, Stephan Gerhold wrote: > The mms114 driver now supports MMS345L; document the > melfas,mms345l binding that is used for it. > > Signed-off-by: Stephan Gerhold Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH 3/3] Input: mms114 - add support for mms345l

bytes: NAK bailout. > mms114 0-0048: __mms114_read_reg: i2c transfer failed (-5) > > The driver works fine as soon as I2C_M_NOSTART is removed. > > Add a separate melfas,mms345l binding, and make use of I2C_M_NOSTART > only for MMS114 and MMS152. > > Signed-off-by:

Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

Hi Yuehaibing, > >> Use devm_platform_ioremap_resource() to simplify the code a bit. > >> This is detected by coccinelle. > >> > >> Reported-by: Hulk Robot > > > > This tag does not look real... First of all where is the report? > > It is our internal CI robot, which is unavailable to external

Re: [PATCH] Input: tm2-touchkey - acknowledge that setting brightness is a blocking call

Torokhov same here: Acked-by: Andi Shyti Thanks, Andi

Re: [PATCH] Input: stmfts - acknowledge that setting brightness is a blocking call

c7b2ae1 ("Input: add support for the STMicroelectronics FingerTip > touchscreen") > Signed-off-by: Dmitry Torokhov Acked-by: Andi Shyti Thanks,

Re: [PATCH 1/2] input: egalax_ts: add system wakeup support

Hi Anson, On Wed, Sep 05, 2018 at 05:26:46PM +0800, Anson Huang wrote: > This patch adds wakeup function support for egalax touch > screen, if "wakeup-source" is added to device tree's egalax > touch screen node, the wakeup function will be enabled, and > egalax touch screen will be able to wakeup

Re: [PATCH v3] dt-bindings: arm: Explicitly mark Samsung Exynos SoC as unstable

a typo here, other than that I agree with the patch: Acked-by: Andi Shyti Thanks, Andi

Re: [PATCH] input: olpc_apsp: remove unused pointer 'np'

Hi Colin, On Tue, Aug 28, 2018 at 03:56:48PM +0100, Colin King wrote: > From: Colin Ian King > > Pointer 'nb' is being assigned but is never used hence it is 'np' here. Other than that, Reviewed-by: Andi Shyti Andi > redundant and can be removed. > &

Re: [PATCH] Input: elants_i2c - Fix sw reset delays

Hi Derek, next time, could you please avoid using html mails when replying to the mailing list? They are not clear. On Fri, Aug 24, 2018 at 04:07:41PM -0700, dbasehore . wrote: > > > On Fri, Aug 24, 2018 at 1:49 AM Andi Shyti wrote: > > Hi Derek, > > > > &

Re: [PATCH] Input: elants_i2c - Fix sw reset delays

Hi Derek, > > > On Thu, Aug 23, 2018 at 04:10:13PM -0700, Derek Basehore wrote: > > > > We only need to wait 10ms instead of 30ms before starting fastboot or > > > > sending IAP on the touchscreen. Also, instead of delaying everytime > > > > sw_reset is called, this delays 10ms in the function tha

[PATCH v2] ARM: dts: exynos: Update x and y properties for mms114 touchscreen

Documentation/devicetree/bindings/input/touchscreen/mms114.txt [2] Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt Signed-off-by: Andi Shyti --- arch/arm/boot/dts/exynos4210-trats.dts | 4 ++-- arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 4 ++-- 2 files changed, 4 ins

Re: [PATCH] Input: ili251x - add support for Ilitek ILI251x touchscreens

Hi Philipp, I had a fast look to your driver and I have few comments. > .../bindings/input/touchscreen/ili251x.txt| 35 ++ > drivers/input/touchscreen/Kconfig | 12 + > drivers/input/touchscreen/Makefile| 1 + > drivers/input/touchscreen/ili251x.c | 350

[PATCH v2] media: ir-spi: update Andi's e-mail

From: Andi Shyti Because I will be leaving Samsung soon, update my e-mail to the etezian.org mail. CC: Mauro Carvalho Chehab CC: Sean Young Signed-off-by: Andi Shyti --- Hi Sean, thanks for the review and sorry for the late reply. Here is the patch with my mail changed also in the

[PATCH 0/2] Licensing fixes and updates for the mms114 driver

Hi Dmitry, I will send this two as a new patchset. The first one is the messed SPDX patch that you reverted, the second one is about the license incohorency that Marcus has pointed out. Andi Andi Shyti (2): Input: mms114 - add SPDX identifier Input: mms114 - fix license module information

[PATCH 2/2] Input: mms114 - fix license module information

81d4aff ("Input: add MELFAS mms114 touchscreen driver") Reported-by: Marcus Folkesson Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscre

[PATCH 1/2] Input: mms114 - add SPDX identifier

Replace the original license statement with the SPDX identifier. Add also one line of description as recommended by the COPYING file. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/input

Re: [PATCH 7/8] Input: mms114 - add SPDX identifier

Hi Dmitry, > > > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > > > > - * Author: Joonyoung Shim > > > > > - * > > > > > - * This program is free software; you can redistribute it and/or > > > > > modify > > > > > - * it under the terms of the GNU General Public License version 2 as >

Re: [PATCH 7/8] Input: mms114 - add SPDX identifier

Hi Marcus, > > > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > > > - * Author: Joonyoung Shim > > > > - * > > > > - * This program is free software; you can redistribute it and/or modify > > > > - * it under the terms of the GNU General Public License version 2 as > > > > - * published

Re: [PATCH 7/8] Input: mms114 - add SPDX identifier

Hi Dmitry, > > -/* > > - * Copyright (C) 2012 Samsung Electronics Co.Ltd > > - * Author: Joonyoung Shim > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License version 2 as > > - * published by the Free Soft

Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values

Hi Dmitry, On Mon, Jan 29, 2018 at 03:33:35PM -0800, Dmitry Torokhov wrote: > On Tue, Jan 30, 2018 at 08:29:23AM +0900, Andi Shyti wrote: > > Hi Dmitry, > > > > On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote: > > > On Mon, Jan 29, 2018 at 08:3

Re: [PATCH 5/8] Input: mms114 - use lower case for hexadecimal values

Hi Dmitry, On Mon, Jan 29, 2018 at 10:56:31AM -0800, Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 08:33:20PM +0900, Andi Shyti wrote: > > Signed-off-by: Andi Shyti > > But why? I think this patch is trivial and the subject itself is quite self-explanatory and the commit mes

Re: [PATCH 4/8] Input: mms114 - remove unused variable

Hi Dmitry, On Mon, Jan 29, 2018 at 10:43:09AM -0800, Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 08:33:19PM +0900, Andi Shyti wrote: > > '__packed' is not used anywhere, remove it. > > Umm, this is not a variable, this is type annotation meaning that the > st

Re: [PATCH 2/8] Input: mms114 - get read of custm i2c read/write functions

Hi Dmitry, On Mon, Jan 29, 2018 at 11:01:41AM -0800, Dmitry Torokhov wrote: > On Mon, Jan 29, 2018 at 08:33:17PM +0900, Andi Shyti wrote: > > The 'mms114_read_reg' and 'mms114_write_reg' are used when > > reading or writing to the 'MMS114_MOD

[PATCH 8/8] Input: mms114 - fix typo in definition

It's 'MMS114_INFORMATION', not 'MMS114_INFOMATION' Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index 3

[PATCH 5/8] Input: mms114 - use lower case for hexadecimal values

Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index 11dba8bb48e3..fdf23bc416af 100644 --- a/drivers/input/touchscreen/mms114

[PATCH 7/8] Input: mms114 - add SPDX identifier

Replace the original license statement with the SPDX identifier. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index

[PATCH 4/8] Input: mms114 - remove unused variable

'__packed' is not used anywhere, remove it. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index fb4435ae506b..11dba8bb48e3 10

[PATCH 1/8] Input: mms114 - use smbus functions whenever possible

e use of custom functions with the more standard smbus ones. It's not possible only in one case, in the mms114_set_active() function where the 'cache_mode_control' variable is updated according to the value in the register 'MMS114_MODE_CONTROL' register. Signed-off-by:

[PATCH 6/8] Input: mms114 - Use BIT() macro instead of explicit shifting

Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index fdf23bc416af..d70c03adf148 100644 --- a/drivers/input/touchscreen/mms114.c +++ b

[PATCH 3/8] Input: mms114 - replace mdelay with msleep

200ms seconds is a very long time to keep the CPU busy looping. Use msleep instead. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/mms114.c b/drivers/input/touchscreen/mms114.c index

[PATCH 2/8] Input: mms114 - get read of custm i2c read/write functions

ction and get rid of all the custom i2c read/write functions. With this remove also the redundant sleep of MMS114_I2C_DELAY (50us) between i2c operations. The waiting should to be handled by the i2c driver. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/mms114.c | 87 +--

[PATCH 0/8] Melfas MMS114 touchscreen cleanups

the mms114 touchscreen in trats2, I would appreaciate if Simon can test it on mms152. Thanks, Andi Andi Shyti (8): Input: mms114 - use smbus functions whenever possible Input: mms114 - get read of custm i2c read/write functions Input: mms114 - replace mdelay with msleep Input: mms114 - rem

[PATCH] ARM: dts: exynos: Update x and y properties for mms114 touchscreen

Documentation/devicetree/bindings/input/touchscreen/mms114.txt [2] Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt Signed-off-by: Andi Shyti --- Hi Krzysztof, this patch depends on Simon's patchset [1] and must be applied after that. If you want I can ping you when the pa

Re: [PATCH 4/4 v2] Input: mms114 - add support for mms152

25841 > Signed-off-by: Dmitry Torokhov also here Reviewed-by: Andi Shyti Tested-by: Andi Shyti one small nitpick: > @@ -239,14 +249,33 @@ static int mms114_get_version(struct mms114_data *data) > { > struct device *dev = &data->client->dev; > u8 buf[6]

Re: [PATCH 3/4] Input: mms114 - drop platform data and use generic APIs

mitry Torokhov yes, looks better. I'm happy you dropped the (mms114_parse_dt(data) < 0). Reviewed-by: Andi Shyti Tested-by: Andi Shyti Thanks, Andi > --- > .../bindings/input/touchscreen/mms114.txt | 29 ++-- > drivers/input/touchscreen/mms114.c

Re: [PATCH 2/4] Input: mms114 - mark as direct input device

d error handling for input_mt_init_slots(). > > Signed-off-by: Dmitry Torokhov Reviewed-by: Andi Shyti Tested-by: Andi Shyti Thanks, Andi

Re: [PATCH 1/4] Input: mms114 - do not clobber interrupt trigger

Hi Dmitry, On Wed, Jan 24, 2018 at 11:38:01AM -0800, Dmitry Torokhov wrote: > Rely on the platform (device tree, ACPI, etc) to properly configure > interrupt trigger/polarity instead of hardcoding the falling edge. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Andi Shyti Tes

Re: [PATCH] Input: edt-ft5x06 - fix error handling for factory mode on non-M06

ore we disable > interrupts/allocate memory for debug buffers. > > Fixes: fd335ab04b3f ("Input: edt-ft5x06 - add support for M09 firmware > version") > Signed-off-by: Dmitry Torokhov makes sense! Reviewed-by: Andi Shyti Andi > --- > drivers/input/touchscreen/edt-ft5x

Re: [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe()

e. > > Signed-off-by: Markus Elfring Acked-by: Andi Shyti Thanks, Andi > --- > drivers/input/touchscreen/edt-ft5x06.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c > b/drivers/input/tou

Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier

Hi Dmitry, On Fri, Jan 05, 2018 at 08:49:58AM -0800, Dmitry Torokhov wrote: > Hi Andi, > > On Fri, Jan 05, 2018 at 06:57:15PM +0900, Andi Shyti wrote: > > Hi Dmitry, > > > > this is a kind ping, would you also mind giving me a feedback to > > Yes, sorry. Cou

Re: [PATCH] Input: stmfts,s6sy671 - add SPDX identifier

Hi Dmitry, this is a kind ping, would you also mind giving me a feedback to all the previous patches I sent? Thanks, Andi On Tue, Dec 12, 2017 at 04:41:49PM +0900, Andi Shyti wrote: > Replace the original license statement with the SPDX identifier. > > Update also the copyright own

Re: [PATCH v3 1/6] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

encies. So this value could be > set if the attached ir receiver needs a different base clock frequency, > than the default 8 MHz. > > Signed-off-by: Philipp Rossak feel free to add Reviewed-by: Andi Shyti Andi

Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

Hi Philipp, just a couple of small nitpicks. > + u32 b_clk_freq; [...] > + /* Base clock frequency (optional) */ > + if (of_property_read_u32(dn, "clock-frequency", &b_clk_freq)) { > + b_clk_freq = SUNXI_IR_BASE_CLK; > + } > + how about you intialize 'b_clk_freq' to

[PATCH v3] spi: s3c64xx: add SPDX identifier

Replace the original license statement with the SPDX identifier. Signed-off-by: Andi Shyti Reviewed-by: Krzysztof Kozlowski --- Hi, v2 to v3: - move the SPDX identifier on top as a separate comment as per documentation - add Krzysztof's review v1 to v2: - keep the original license

Re: [PATCH v2] spi: s3c64xx: add SPDX identifier

Hi Philippe, > > diff --git a/include/linux/platform_data/spi-s3c64xx.h > > b/include/linux/platform_data/spi-s3c64xx.h > > index da79774078a7..8917f38c97c5 100644 > > --- a/include/linux/platform_data/spi-s3c64xx.h > > +++ b/include/linux/platform_data/spi-s3c64xx.h > > @@ -2,9 +2,7 @@ > > * C

[PATCH v2] spi: s3c64xx: add SPDX identifier

Replace the original license statement with the SPDX identifier. Signed-off-by: Andi Shyti --- Hi, this second version unlike v1, where I tried to move the license from GPLv2+ to GPLv2, preserves the original licese while adding the SPDX identifier. Andi drivers/spi/spi-s3c64xx.c

Re: [PATCH] spi: s3c64xx: add SPDX identifier

Hi Krzysztof, > > Here, this should be as a top line: > > > > // SPDX-License-Identifier: GPL-2.0+ > > > > > > So I agree with the SPDX id but also pointing to the use of the C++ // > > comment style as requested by Linus [1] > > Thanks for the reference. I see that Linus prefers converting entir

Re: [PATCH] spi: s3c64xx: add SPDX identifier

Hi Krzysztof, > > - * Copyright (C) 2009 Samsung Electronics Ltd. > > - * Jaswinder Singh > > - * > > - * This program is free software; you can redistribute it and/or modify > > - * it under the terms of the GNU General Public License as published by > > - * the Free Software Foundation; eit

[PATCH] spi: s3c64xx: add SPDX identifier

Replace the original license statement with the SPDX identifier. Signed-off-by: Andi Shyti --- drivers/spi/spi-s3c64xx.c | 18 -- include/linux/platform_data/spi-s3c64xx.h | 4 +--- 2 files changed, 5 insertions(+), 17 deletions(-) diff --git a/drivers/spi/spi

[PATCH] [media] ir-spi: add SPDX identifier

Replace the original license statement with the SPDX identifier. Update also the copyright owner adding myself as co-owner of the copyright. Signed-off-by: Andi Shyti --- drivers/media/rc/ir-spi.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers

[PATCH] Input: stmfts,s6sy671 - add SPDX identifier

Replace the original license statement with the SPDX identifier. Update also the copyright owner adding myself as co-owner of the copyright. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/s6sy761.c | 15 +-- drivers/input/touchscreen/stmfts.c | 15 +-- 2 files

[PATCH 1/2] Input: ili210x - use managed allocated resources

Use managed allocated resources to simplify error handling during probing. Adjust goto labels and remove function accordingly. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ili210x.c | 36 +++- 1 file changed, 11 insertions(+), 25 deletions(-) diff

[PATCH 2/2] Input: ili210x - use separate error handling for different allocators

Split the error between devm_kzalloc and devm_input_allocate_device, there is no need to call the second allocator if the first has failed. Besides this doesn't provide practical advantages. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ili210x.c | 5 - 1 file chang

[PATCH 0/2] managed resources for ili210x

Hi Dmitry, this is another patch of my series for switching the touchscreen drivers to to the managed resource allocators. The second patch is very trivial and perhaps bothering only me, feel free to ignore. Thanks, Andi Andi Shyti (2): Input: ili210x - use managed allocated resources

Re: [PATCH v6 0/2] add support for the Samsung S6SY761 touchscreen

> On Wed, Nov 08, 2017 at 05:21:03PM +0900, Andi Shyti wrote: > > Hi, > > > > This patchset adds support for the Samsung s6sy761 touchscreen. > > > > Thanks, > > Andi > > Applied, thank you. Thanks for your review :) Andi

[PATCH] Input: ads7846 - use managed allocated resources

Use managed allocated resources to simplify error handling during probing. Fix goto labels and remove function accordingly. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ads7846.c | 103 ++-- 1 file changed, 28 insertions(+), 75 deletions(-) diff

[PATCH v3 0/3] use managed functions for ad7897 driver

g to the managed resource allocation - removed the remove() function and used devm_add_action_or_reset for cleaning when exiting [1] https://marc.info/?l=linux-input&m=150671805312148&w=2 [2] https://marc.info/?l=linux-kernel&m=151015513508504&w=2 Andi Shyti (3): Input

[PATCH v3 3/3] Input: ad7897 - use separate error handling for different allocators

Split the error between devm_kzalloc and devm_input_allocate_device, there is no need to call the second allocator if the first has failed. Besides this doesn't provide practical advantages. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 5 +++

[PATCH v3 2/3] Input: ad7897 - use devm_add_action_or_reset to disable the device

Use the ad7877_disable() as a custom action when the driver gets removed instead of calling it from the remove function. Because ad7877_remove() was just calling the disable function, get rid of it. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 20

[PATCH v3 1/3] Input: ad7897 - use managed allocated resources

Use managed allocated resources to simplify error handling during probing failure and module exiting. With this all the goto labels in the probe function together with the cleanups in the remove function are unnecessary, therefore removed. CC: Michael Hennerich Signed-off-by: Andi Shyti

Re: [PATCH v2 1/3] Input: ad7897 - use managed allocated resources

> > - ts = kzalloc(sizeof(struct ad7877), GFP_KERNEL); > > - input_dev = input_allocate_device(); > > - if (!ts || !input_dev) { > > - err = -ENOMEM; > > - goto err_free_mem; > > - } > > + ts = devm_kzalloc(&spi->dev, sizeof(struct ad7877), GFP_KERNEL); > > + input_d

[PATCH v2 3/3] Input: ad7897 - use separate error handling for different allocators

Split the error between devm_kzalloc and devm_input_allocate_device, there is no need to call the second allocator if the first has failed. Besides this doesn't provide practical advantages. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 3 +++ 1

[PATCH v2 2/3] Input: ad7897 - use devm_add_action_or_reset to disable the device

Use the ad7877_disable() as a custom action when the driver gets removed instead of calling it from the remove function. Because ad7877_remove() was just calling the disable function, get rid of it. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 20

[PATCH v2 1/3] Input: ad7897 - use managed allocated resources

Use managed allocated resources to simplify error handling during probing failure and module exiting. With this all the goto labels in the probe function together with the cleanups in the remove function are unnecessary, therefore removed. CC: Michael Hennerich Signed-off-by: Andi Shyti

[PATCH v2 0/3] use managed functions for ad7897 driver

unction and used devm_add_action_or_reset for cleaning when exiting Andi Shyti (3): Input: ad7897 - use managed allocated resources Input: ad7897 - use devm_add_action_or_reset to disable the device Input: ad7897 - use separate error handling for different allocators drivers/input/touchscre

[PATCH v6 2/2] Input: add support for the Samsung S6SY761 touchscreen

h, in the version I currently have, doesn't provide all the possible functionalities mentioned in the datasheet. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/Kconfig | 11 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/s6sy7

[PATCH v6 0/2] add support for the Samsung S6SY761 touchscreen

ce works only in two modes and therefore 'prev_pm_state' is not required any longer. v1 - v2 - remove the low power functionality as it doesn't bring any benefit - use get_unaligned_be16 instead of the form 'a << 8 | b' - use max_t instead of '? :' -

[PATCH v6 1/2] dt-bindings: Input: add Samsung S6SY761 touchscreen binding file

Add the binding file for the Samsung capacitive multi-touch touchscreen S6SY761. Signed-off-by: Andi Shyti Acked-by: Rob Herring --- .../bindings/input/touchscreen/samsung,s6sy761.txt | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree

[PATCH 0/5] use managed functions for ad7897 driver

to reject it. Thanks, Andi [*] https://marc.info/?l=linux-input&m=150671805312148&w=2 Andi Shyti (5): Input: ad7897 - use managed devm_kzalloc Input: ad7897 - use managed devm_input_allocate_device Input: ad7897 - use managed devm_request_threaded_irq Input: ad7897 - use

[PATCH 5/5] Input: ad7897 - use separate error handling for different allocators

Split the error between devm_kzalloc and devm_input_allocate_device, there is no need to call the second allocator if the first has failed. Besides this doesn't provide practical advantages. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 3 +++ 1

[PATCH 3/5] Input: ad7897 - use managed devm_request_threaded_irq

Request the interrupt by using its related managed devm_request_threaded_irq function, remove the cleanup function calls and adjust the goto error handlings accordingly. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 7 ++- 1 file changed, 2

[PATCH 2/5] Input: ad7897 - use managed devm_input_allocate_device

Allocate the input device by using the devm_input_allocate_device function and remove all the related cleanup function and adjust the goto error handlings accordingly. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 18 ++ 1 file changed

[PATCH 1/5] Input: ad7897 - use managed devm_kzalloc

Allocate the driver's structure by using devm_kzalloc instead of simple kzalloc and remove all the related kfree calls. CC: Michael Hennerich Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH 4/5] Input: ad7897 - use managed devm_device_add_group

ned-off-by: Andi Shyti --- drivers/input/touchscreen/ad7877.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 3a4230219b23..c8a143db8681 100644 --- a/drivers/input/touchscreen/ad78

[PATCH v5 2/2] Input: add support for the Samsung S6SY761 touchscreen

h, in the version I currently have, doesn't provide all the possible functionalities mentioned in the datasheet. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/Kconfig | 11 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/s6sy7

[PATCH v5 1/2] dt-bindings: Input: add Samsung S6SY761 touchscreen binding file

Add the binding file for the Samsung capacitive multi-touch touchscreen S6SY761. Signed-off-by: Andi Shyti Acked-by: Rob Herring --- .../bindings/input/touchscreen/samsung,s6sy761.txt | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v5 0/2] add support for the Samsung S6SY761 touchscreen

' - use max_t instead of '? :' - use managed 'devm_device_add_group()' Andi Shyti (2): dt-bindings: Input: add Samsung S6SY761 touchscreen binding file Input: add support for the Samsung S6SY761 touchscreen .../bindings/input/touchscreen/samsung,s6sy761.txt | 34 ++ dr

Re: [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group

the relative sysfs_remove_group and goto label. > > > > CC: Michael Hennerich > > Signed-off-by: Andi Shyti > > --- > > drivers/input/touchscreen/ad7877.c | 8 ++-- > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/drive

  1   2   3   4   5   >