hat FIFO-99 is the wrong default level.
However, in my opinion, threads responsible for real time data
acquisition should have higher priority than the other kernel driver
threads normally running at FIFO-50.
How about FIFO-51 as the default?
Regards,
Andy
> Cc: Andy Walls
> Cc: Mauro C
On Fri, 2015-06-26 at 10:45 +0200, Ingo Molnar wrote:
> * Luis R. Rodriguez wrote:
>
> > On Thu, Jun 25, 2015 at 08:51:47AM +0200, Ingo Molnar wrote:
> > >
> > > * Luis R. Rodriguez wrote:
> > >
> > > > From: "Luis R. Rodriguez"
> > > >
> > > > On built-in kernels this warning will always
On Fri, 2015-06-26 at 10:45 +0200, Ingo Molnar wrote:
* Luis R. Rodriguez mcg...@suse.com wrote:
On Thu, Jun 25, 2015 at 08:51:47AM +0200, Ingo Molnar wrote:
* Luis R. Rodriguez mcg...@do-not-panic.com wrote:
From: Luis R. Rodriguez mcg...@suse.com
On built-in kernels
ice driver requires systems to
> boot with PAT disabled, with the nopat kernel parameter.
>
> This is a worthy comprmise given that the hardware is
> really rare these days, and perhaps only some lost souls
> in some third world country are expected to be using this
> feature
disabled, with the nopat kernel parameter.
This is a worthy comprmise given that the hardware is
really rare these days, and perhaps only some lost souls
in some third world country are expected to be using this
feature of the device driver.
Cc: Andy Walls awa...@md.metrocast.net
Acked
solution. It makes sense.
> and perhaps only some lost souls
> in some third world country are expected to be using this
> feature of the device driver.
>
> Cc: Mauro Carvalho Chehab
> Cc: Andy Lutomirski
> Cc: Andy Walls
> Cc: Suresh Siddha
> Cc: Ingo Molnar
>
souls
in some third world country are expected to be using this
feature of the device driver.
Cc: Mauro Carvalho Chehab mche...@osg.samsung.com
Cc: Andy Lutomirski l...@amacapital.net
Cc: Andy Walls awa...@md.metrocast.net
Cc: Suresh Siddha sbsid...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc
On Thu, 2015-04-16 at 01:58 +0200, Luis R. Rodriguez wrote:
> Hey Andy, thanks for your review, adding Hyong-Youb Kim for review of the
> full range ioremap_wc() idea below.
>
> On Wed, Apr 15, 2015 at 06:38:51PM -0400, Andy Walls wrote:
> > Hi All,
> >
> > On
On Wed, 2015-04-15 at 17:58 -0700, Andy Lutomirski wrote:
> On Wed, Apr 15, 2015 at 4:59 PM, Andy Walls wrote:
> > On Wed, 2015-04-15 at 16:42 -0700, Andy Lutomirski wrote:
> >> On Wed, Apr 15, 2015 at 3:38 PM, Andy Walls
> >> wrote:
> >
> >> >
>
On Wed, 2015-04-15 at 16:52 -0700, Andy Lutomirski wrote:
> On Wed, Apr 15, 2015 at 3:50 PM, Andy Walls wrote:
> > On Wed, 2015-04-15 at 13:42 -0700, Andy Lutomirski wrote:
> >> On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez
> >> wrote:
> >>
> >>
On Wed, 2015-04-15 at 16:42 -0700, Andy Lutomirski wrote:
> On Wed, Apr 15, 2015 at 3:38 PM, Andy Walls wrote:
> >
>
> IMO the right solution would be to avoid ioremapping the whole bar at
> startup. Instead ioremap pieces once the driver learns what they are.
> T
Hi All,
On Mon, 2015-04-13 at 19:49 +0200, Luis R. Rodriguez wrote:
[snip]
> I only saw a few drivers using overlapping ioremap*()
> calls though on my MTRR review and they are all old devices so likely mostly
> used on non-PAT systems, but there might be other corner cases elsewhere.
>
> Lets
On Wed, 2015-04-15 at 13:42 -0700, Andy Lutomirski wrote:
> On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez wrote:
>
> > c) ivtv: the driver does not have the PCI space mapped out separately, and
> > in fact it actually does not do the math for the framebuffer, instead it
> > lets
> > the
Hi All,
On Mon, 2015-04-13 at 19:49 +0200, Luis R. Rodriguez wrote:
[snip]
I only saw a few drivers using overlapping ioremap*()
calls though on my MTRR review and they are all old devices so likely mostly
used on non-PAT systems, but there might be other corner cases elsewhere.
Lets
On Wed, 2015-04-15 at 13:42 -0700, Andy Lutomirski wrote:
On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez mcg...@suse.com wrote:
c) ivtv: the driver does not have the PCI space mapped out separately, and
in fact it actually does not do the math for the framebuffer, instead it
lets
On Thu, 2015-04-16 at 01:58 +0200, Luis R. Rodriguez wrote:
Hey Andy, thanks for your review, adding Hyong-Youb Kim for review of the
full range ioremap_wc() idea below.
On Wed, Apr 15, 2015 at 06:38:51PM -0400, Andy Walls wrote:
Hi All,
On Mon, 2015-04-13 at 19:49 +0200, Luis R
On Wed, 2015-04-15 at 16:52 -0700, Andy Lutomirski wrote:
On Wed, Apr 15, 2015 at 3:50 PM, Andy Walls awa...@md.metrocast.net wrote:
On Wed, 2015-04-15 at 13:42 -0700, Andy Lutomirski wrote:
On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez mcg...@suse.com
wrote:
c) ivtv: the driver
On Wed, 2015-04-15 at 17:58 -0700, Andy Lutomirski wrote:
On Wed, Apr 15, 2015 at 4:59 PM, Andy Walls awa...@md.metrocast.net wrote:
On Wed, 2015-04-15 at 16:42 -0700, Andy Lutomirski wrote:
On Wed, Apr 15, 2015 at 3:38 PM, Andy Walls awa...@md.metrocast.net
wrote:
IMO the right
On Wed, 2015-04-15 at 16:42 -0700, Andy Lutomirski wrote:
On Wed, Apr 15, 2015 at 3:38 PM, Andy Walls awa...@md.metrocast.net wrote:
IMO the right solution would be to avoid ioremapping the whole bar at
startup. Instead ioremap pieces once the driver learns what they are.
This wouldn't
On Fri, 2015-01-30 at 08:09 -0500, valdis.kletni...@vt.edu wrote:
> On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
>
> > > > - if (ir == NULL) {
> > > > - dev_err(ir->l.dev, "close: no private_data attached to
> > > > the file
> !\n");
> > >
commit
On Fri, 2015-01-30 at 08:09 -0500, valdis.kletni...@vt.edu wrote:
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
- if (ir == NULL) {
- dev_err(ir-l.dev, close: no private_data attached to
the file
!\n);
commit
On December 20, 2014 8:17:05 PM EST, Rickard Strandqvist
wrote:
>2014-12-21 1:06 GMT+01:00 Andy Walls :
>> On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist
> wrote:
>>>Removes some functions that are not used anywhere:
>>>snd_cx18_mixer_tv_vol_ge
On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist
wrote:
>Removes some functions that are not used anywhere:
>snd_cx18_mixer_tv_vol_get() snd_cx18_mixer_tv_vol_info()
>snd_cx18_mixer_tv_vol_put()
>
>This was partially found by using a static code analysis program called
>cppcheck.
>
On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist
rickard_strandqv...@spectrumdigital.se wrote:
Removes some functions that are not used anywhere:
snd_cx18_mixer_tv_vol_get() snd_cx18_mixer_tv_vol_info()
snd_cx18_mixer_tv_vol_put()
This was partially found by using a static code analysis
On December 20, 2014 8:17:05 PM EST, Rickard Strandqvist
rickard_strandqv...@spectrumdigital.se wrote:
2014-12-21 1:06 GMT+01:00 Andy Walls awa...@md.metrocast.net:
On December 20, 2014 5:35:17 PM EST, Rickard Strandqvist
rickard_strandqv...@spectrumdigital.se wrote:
Removes some functions
ift before the mask to match nearly all the other
> uses in kernel.
>
> Signed-off-by: Joe Perches
The patch is technically correct.
Reviewed-by: Andy Walls
> ---
> drivers/media/i2c/cx25840/cx25840-core.c | 12 ++--
> drivers/media/pci/cx18/cx18-av-core.c
all the other
uses in kernel.
Signed-off-by: Joe Perches j...@perches.com
The patch is technically correct.
Reviewed-by: Andy Walls awa...@md.metrocast.net
---
drivers/media/i2c/cx25840/cx25840-core.c | 12 ++--
drivers/media/pci/cx18/cx18-av-core.c| 16
2
/cgit/linux/kernel/git/jack/linux-fs.git/commit/?h=get_user_pages=624fc1bfb70fb65d32d31fbd16427ad9c234653e
If I found the correct patch for adding get_user_pages_unlocked(), then
the patch below looks fine.
Reviewed-by: Andy Walls
Acked-by: Andy Walls
Regards,
Andy
On Wed, 2013-10-02 at 16
://git.kernel.org/cgit/linux/kernel/git/jack/linux-fs.git/commit/?h=get_user_pagesid=624fc1bfb70fb65d32d31fbd16427ad9c234653e
/rant
If I found the correct patch for adding get_user_pages_unlocked(), then
the patch below looks fine.
Reviewed-by: Andy Walls awa...@md.metrocast.net
Acked-by: Andy Walls awa
Knut Petersen wrote:
>As long as I use the "Hauppauge WinTV Nova-HD-S2", nobody seems to be
>really interested in silencing deadlock warnings triggered by
>dvb_device_open().
>
>dvb lockdep problems are old, see Andy Walls mail written in 2010
>
Knut Petersen knut_peter...@t-online.de wrote:
As long as I use the Hauppauge WinTV Nova-HD-S2, nobody seems to be
really interested in silencing deadlock warnings triggered by
dvb_device_open().
dvb lockdep problems are old, see Andy Walls mail written in 2010
http://permalink.gmane.org
On Thu, 2013-07-11 at 17:05 +0800, Ming Lei wrote:
> Hi,
>
> As we are going to run URB->complete() in tasklet context[1][2],
Hi,
Please pardon my naivete, but why was it decided to use tasklets to
defer work, as opposed to some other deferred work mechanism?
It seems to me that getting rid of
On Thu, 2013-07-11 at 17:05 +0800, Ming Lei wrote:
Hi,
As we are going to run URB-complete() in tasklet context[1][2],
Hi,
Please pardon my naivete, but why was it decided to use tasklets to
defer work, as opposed to some other deferred work mechanism?
It seems to me that getting rid of
Mauro Carvalho Chehab wrote:
>Em Wed, 29 May 2013 22:41:16 +0200
>Jon Arne Jørgensen escreveu:
>
>> Change all default values in the initial setup table to match the
>table
>> in the datasheet.
>
>This is not a good idea, as it can produce undesired side effects
>on the existing drivers that
Mauro Carvalho Chehab mche...@redhat.com wrote:
Em Wed, 29 May 2013 22:41:16 +0200
Jon Arne Jørgensen jona...@jonarne.no escreveu:
Change all default values in the initial setup table to match the
table
in the datasheet.
This is not a good idea, as it can produce undesired side effects
on the
On Sun, 2013-02-10 at 11:54 +0100, Hans Verkuil wrote:
> On Sun February 10 2013 11:34:11 Knut Petersen wrote:
> > Maybe somebody could have at that old locking warning:
>
> It's a false warning. If someone can point me to some documentation on how to
> tell lockdep that it isn't a deadlock, then
On Sun, 2013-02-10 at 11:54 +0100, Hans Verkuil wrote:
On Sun February 10 2013 11:34:11 Knut Petersen wrote:
Maybe somebody could have at that old locking warning:
It's a false warning. If someone can point me to some documentation on how to
tell lockdep that it isn't a deadlock, then that
Dmitry Torokhov wrote:
>Hi Yuanhan,
>
>On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote:
>> The current kfifo API take the kfifo size as input, while it rounds
>> _down_ the size to power of 2 at __kfifo_alloc. This may introduce
>> potential issue.
>>
>> Take the code at
Dmitry Torokhov dmitry.torok...@gmail.com wrote:
Hi Yuanhan,
On Tue, Jan 08, 2013 at 10:57:53PM +0800, Yuanhan Liu wrote:
The current kfifo API take the kfifo size as input, while it rounds
_down_ the size to power of 2 at __kfifo_alloc. This may introduce
potential issue.
Take the code
tive because arrays were
>being dereferenced using the index before the check.
>
>Signed-off-by: Nickolai Zeldovich
>---
>Thanks to Andy Walls for suggesting that instead of moving the checks
>before array dereference, a better fix is to remove the checks
>altogether,
>since the
On Sat, 2013-01-05 at 14:11 -0500, Nickolai Zeldovich wrote:
> Move dereferencing of hw_devicenames[], hw_bus[] arrays until after
> checking that idx is within range.
>
> Signed-off-by: Nickolai Zeldovich
Hi Nickolai,
My comments are in line below.
> ---
> drivers/media/pci/cx18/cx18-i2c.c
On Sat, 2013-01-05 at 14:11 -0500, Nickolai Zeldovich wrote:
Move dereferencing of hw_devicenames[], hw_bus[] arrays until after
checking that idx is within range.
Signed-off-by: Nickolai Zeldovich nicko...@csail.mit.edu
Hi Nickolai,
My comments are in line below.
---
ineffective because arrays were
being dereferenced using the index before the check.
Signed-off-by: Nickolai Zeldovich nicko...@csail.mit.edu
---
Thanks to Andy Walls for suggesting that instead of moving the checks
before array dereference, a better fix is to remove the checks
altogether,
since
Laurent Pinchart wrote:
>Hi Ezequiel,
>
>Thanks for the patch.
>
>On Tuesday 23 October 2012 16:57:04 Ezequiel Garcia wrote:
>> This kind of memcpy() is error-prone. Its replacement with a struct
>> assignment is prefered because it's type-safe and much easier to
>read.
>>
>> Found by
Laurent Pinchart laurent.pinch...@ideasonboard.com wrote:
Hi Ezequiel,
Thanks for the patch.
On Tuesday 23 October 2012 16:57:04 Ezequiel Garcia wrote:
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to
read.
On Tue, 2012-10-23 at 16:57 -0300, Ezequiel Garcia wrote:
> This kind of memcpy() is error-prone. Its replacement with a struct
> assignment is prefered because it's type-safe and much easier to read.
>
> Found by coccinelle. Hand patched and reviewed.
> Tested by compilation only.
>
> A
m), E);
> +to = from;
> //
>
This patch is fine.
Signed-off-by: Andy Walls
> Signed-off-by: Peter Senna Tschudin
> Signed-off-by: Ezequiel Garcia
> ---
> drivers/media/i2c/cx25840/cx25840-ir.c |6 ++
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
ompilation only.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //
> @@
> identifier struct_name;
> struct struct_name to;
> struct struct_name from;
> expression E;
> @@
> -memcpy(&(to), &(from
m), E);
> +to = from;
> //
>
> Signed-off-by: Peter Senna Tschudin
> Signed-off-by: Ezequiel Garcia
This patch looks OK to me. You forgot to CC: Steven Toth and/or Devin
Heitmueller (I can't remember who did the VBI work.)
For cx23885-video.c:
Reviewed-by: Andy Walls
For cx2
://coccinelle.lip6.fr/)
>
> //
> @@
> identifier struct_name;
> struct struct_name to;
> struct struct_name from;
> expression E;
> @@
> -memcpy(&(to), &(from), E);
> +to = from;
> //
>
> Cc: Andy Walls
Signed-off-by: Andy Walls
> Signed-off-by: P
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy((to), (from), E);
+to = from;
// /smpl
Cc: Andy Walls awa...@md.metrocast.net
Signed-off-by: Andy Walls awa...@md.metrocast.net
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
peter.se...@gmail.com
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com
This patch looks OK to me. You forgot to CC: Steven Toth and/or Devin
Heitmueller (I can't remember who did the VBI work.)
For cx23885-video.c:
Reviewed-by: Andy Walls awa...@md.metrocast.net
For cx23885-ir.c:
Signed-off
version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy((to), (from), E);
+to = from;
// /smpl
Cc: Andy Walls awa...@md.metrocast.net
version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// smpl
@@
identifier struct_name;
struct struct_name to;
struct struct_name from;
expression E;
@@
-memcpy((to), (from), E);
+to = from;
// /smpl
This patch is fine.
Signed-off-by: Andy
On Tue, 2012-10-23 at 16:57 -0300, Ezequiel Garcia wrote:
This kind of memcpy() is error-prone. Its replacement with a struct
assignment is prefered because it's type-safe and much easier to read.
Found by coccinelle. Hand patched and reviewed.
Tested by compilation only.
A simplified
Linus Torvalds wrote:
>On Wed, Oct 3, 2012 at 12:50 PM, Greg KH
>wrote:
>>>
>>> Ok, like this?
>>
>> This looks good to me. Having udev do firmware loading and tieing it
>to
>> the driver model may have not been such a good idea so many years
>ago.
>> Doing it this way makes more sense.
>
>Ok,
Greg KH wrote:
>On Wed, Oct 03, 2012 at 10:32:08AM -0700, Linus Torvalds wrote:
>> On Wed, Oct 3, 2012 at 10:09 AM, Al Viro
>wrote:
>> >
>> > + if (!S_ISREG(inode->i_mode))
>> > + return false;
>> > + size = i_size_read(inode);
>> >
>> > Probably better to do
Greg KH gre...@linuxfoundation.org wrote:
On Wed, Oct 03, 2012 at 10:32:08AM -0700, Linus Torvalds wrote:
On Wed, Oct 3, 2012 at 10:09 AM, Al Viro v...@zeniv.linux.org.uk
wrote:
+ if (!S_ISREG(inode-i_mode))
+ return false;
+ size = i_size_read(inode);
Linus Torvalds torva...@linux-foundation.org wrote:
On Wed, Oct 3, 2012 at 12:50 PM, Greg KH gre...@linuxfoundation.org
wrote:
Ok, like this?
This looks good to me. Having udev do firmware loading and tieing it
to
the driver model may have not been such a good idea so many years
ago.
Doing
On Fri, 2012-07-27 at 10:45 -0600, Tim Gardner wrote:
> Cc: Andy Walls
Acked-by: Andy Walls
Regards,
Andy
> Cc: Mauro Carvalho Chehab
> Cc: ivtv-de...@ivtvdriver.org
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Tim Gardner
> ---
> drivers/media/video/cx18/cx18
On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote:
> On 07/26/2012 04:21 PM, Andy Walls wrote:
> > On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
> >> Cc: Andy Walls
> >> Cc: Mauro Carvalho Chehab
> >> Cc: ivtv-de...@ivtvdriver.org
> >> Cc
On Fri, 2012-07-27 at 06:06 -0600, Tim Gardner wrote:
> On 07/26/2012 03:59 PM, Andy Walls wrote:
> > On Thu, 2012-07-26 at 10:44 -0600, Tim Gardner wrote:
> >> Cc: Mauro Carvalho Chehab
> >> Cc: linux-me...@vger.kernel.org
> >> Signed-off-by: Tim Gardner
On Fri, 2012-07-27 at 06:06 -0600, Tim Gardner wrote:
On 07/26/2012 03:59 PM, Andy Walls wrote:
On Thu, 2012-07-26 at 10:44 -0600, Tim Gardner wrote:
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Tim Gardner tim.gard...@canonical.com
On Fri, 2012-07-27 at 09:45 -0600, Tim Gardner wrote:
On 07/26/2012 04:21 PM, Andy Walls wrote:
On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
Cc: Andy Walls awa...@md.metrocast.net
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: ivtv-de...@ivtvdriver.org
Cc: linux-me
On Fri, 2012-07-27 at 10:45 -0600, Tim Gardner wrote:
Cc: Andy Walls awa...@md.metrocast.net
Acked-by: Andy Walls awa...@md.metrocast.net
Regards,
Andy
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: ivtv-de...@ivtvdriver.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Tim Gardner
On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
> Cc: Andy Walls
> Cc: Mauro Carvalho Chehab
> Cc: ivtv-de...@ivtvdriver.org
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Tim Gardner
> ---
> drivers/media/video/ivtv/ivtv-firmware.c |4
> 1 fi
17 00:00:00 2001
> From: Tim Gardner
> Date: Thu, 26 Jul 2012 11:03:51 -0600
> Subject: [PATCH v2] cx18: Declare MODULE_FIRMWARE usage
>
> Cc: Andy Walls
> Cc: Mauro Carvalho Chehab
> Cc: ivtv-de...@ivtvdriver.org
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Ti
On Thu, 2012-07-26 at 11:05 -0600, Tim Gardner wrote:
> Cc: Andy Walls
> Cc: Mauro Carvalho Chehab
> Cc: ivtv-de...@ivtvdriver.org
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Tim Gardner
You missed v4l-cx23418-dig.fw, in cx18-av-firmware.c, which is required
by all CX2341
On Thu, 2012-07-26 at 10:44 -0600, Tim Gardner wrote:
> Cc: Mauro Carvalho Chehab
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Tim Gardner
> ---
> drivers/media/video/cx25840/cx25840-firmware.c | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git
On Thu, 2012-07-26 at 10:44 -0600, Tim Gardner wrote:
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Tim Gardner tim.gard...@canonical.com
---
drivers/media/video/cx25840/cx25840-firmware.c | 15 ---
1 file changed, 12
On Thu, 2012-07-26 at 11:05 -0600, Tim Gardner wrote:
Cc: Andy Walls awa...@md.metrocast.net
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: ivtv-de...@ivtvdriver.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Tim Gardner tim.gard...@canonical.com
You missed v4l-cx23418-dig.fw
From: Tim Gardner tim.gard...@canonical.com
Date: Thu, 26 Jul 2012 11:03:51 -0600
Subject: [PATCH v2] cx18: Declare MODULE_FIRMWARE usage
Cc: Andy Walls awa...@md.metrocast.net
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: ivtv-de...@ivtvdriver.org
Cc: linux-me...@vger.kernel.org
On Thu, 2012-07-26 at 12:26 -0600, Tim Gardner wrote:
Cc: Andy Walls awa...@md.metrocast.net
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: ivtv-de...@ivtvdriver.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Tim Gardner tim.gard...@canonical.com
---
drivers/media/video/ivtv/ivtv
On Mon, 2012-07-23 at 10:12 -0700, Tejun Heo wrote:
> Hello,
>
> On Sun, Jul 22, 2012 at 04:46:54PM -0400, Andy Walls wrote:
> > Hmmm, I didn't know about the constraint about 'known to be alive' in
> > the other email I just sent.
> >
> > That might make
On Mon, 2012-07-23 at 10:12 -0700, Tejun Heo wrote:
Hello,
On Sun, Jul 22, 2012 at 04:46:54PM -0400, Andy Walls wrote:
Hmmm, I didn't know about the constraint about 'known to be alive' in
the other email I just sent.
That might make calling flush_kthread_work() hard for a user to use
On Sun, 2012-07-22 at 09:49 -0700, Tejun Heo wrote:
> Hello,
>
> On Sat, Jul 21, 2012 at 02:20:06PM -0400, Andy Walls wrote:
> > > + worker->current_work = work;
> > > spin_unlock_irq(>lock);
> > >
> > > if (work) {
> > >
On Sun, 2012-07-22 at 09:46 -0700, Tejun Heo wrote:
> Hello,
>
> On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote:
> > > +/* insert @work before @pos in @worker */
> >
> > Hi Tejun,
> >
> > Would a comment that the caller should be holdin
Hi Tejun,
Thanks for responding to my previous questions. I have one more.
On Sat, 2012-07-21 at 14:20 -0400, Andy Walls wrote:
> On Thu, 2012-07-19 at 14:16 -0700, Tejun Heo wrote:
> > From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001
> > From: Tejun Heo
&g
Hi Tejun,
Thanks for responding to my previous questions. I have one more.
On Sat, 2012-07-21 at 14:20 -0400, Andy Walls wrote:
On Thu, 2012-07-19 at 14:16 -0700, Tejun Heo wrote:
From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date
On Sun, 2012-07-22 at 09:46 -0700, Tejun Heo wrote:
Hello,
On Sat, Jul 21, 2012 at 01:13:27PM -0400, Andy Walls wrote:
+/* insert @work before @pos in @worker */
Hi Tejun,
Would a comment that the caller should be holding worker-lock be useful
here? Anyway, comment
On Sun, 2012-07-22 at 09:49 -0700, Tejun Heo wrote:
Hello,
On Sat, Jul 21, 2012 at 02:20:06PM -0400, Andy Walls wrote:
+ worker-current_work = work;
spin_unlock_irq(worker-lock);
if (work) {
__set_current_state(TASK_RUNNING);
work-func(work
On Thu, 2012-07-19 at 14:16 -0700, Tejun Heo wrote:
> From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001
> From: Tejun Heo
> Date: Thu, 19 Jul 2012 13:52:53 -0700
>
> kthread_worker provides minimalistic workqueue-like interface for
> users which need a dedicated worker
efore @pos in @worker */
Hi Tejun,
Would a comment that the caller should be holding worker->lock be useful
here? Anyway, comment or not:
Acked-by: Andy Walls
Regards,
Andy
> +static void insert_kthread_work(struct kthread_worker *worker,
> +
be holding worker-lock be useful
here? Anyway, comment or not:
Acked-by: Andy Walls aw...@md.metrocast.net
Regards,
Andy
+static void insert_kthread_work(struct kthread_worker *worker,
+struct kthread_work *work,
+struct list_head *pos
On Thu, 2012-07-19 at 14:16 -0700, Tejun Heo wrote:
From 06f9a06f4aeecdb9d07014713ab41b548ae219b5 Mon Sep 17 00:00:00 2001
From: Tejun Heo t...@kernel.org
Date: Thu, 19 Jul 2012 13:52:53 -0700
kthread_worker provides minimalistic workqueue-like interface for
users which need a dedicated
85 matches
Mail list logo
