Cleaning up two existing checkpatch errors (and 2 warnings) in
device_sysfs.c since the file is being changed.
The change in acpi_device_setup_files() is changing spaces to a tab.
Signed-off-by: Betty Dall <betty.d...@hpe.com>
---
drivers/acpi/device_sysfs.c | 16 +---
Cleaning up two existing checkpatch errors (and 2 warnings) in
device_sysfs.c since the file is being changed.
The change in acpi_device_setup_files() is changing spaces to a tab.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 16 +---
1 file changed, 9 insertions
xists or there wouldn't be a sysfs file.
Signed-off-by: Betty Dall <betty.d...@hpe.com>
---
drivers/acpi/device_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 49cc0cb..e556a3e 100644
--- a/d
Left some of the checkpatch warnings in place.
Betty Dall (3):
ACPI/device_sysfs: Add sysfs support for _HRV hardware revision
ACPI/device_sysfs: Change _SUN and _STA show functions error return to EIO
ACPI/device_sysfs: Clean up checkpatch errors
drivers/acpi/device_sysfs.
'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Signed-off-by: Betty Dall <betty.d...@hpe.com>
---
drivers/acpi/device_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/acpi/device_sys
xists or there wouldn't be a sysfs file.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 49cc0cb..e556a3e 100644
--- a/drivers/acpi/device_sysfs.c
Left some of the checkpatch warnings in place.
Betty Dall (3):
ACPI/device_sysfs: Add sysfs support for _HRV hardware revision
ACPI/device_sysfs: Change _SUN and _STA show functions error return to EIO
ACPI/device_sysfs: Clean up checkpatch errors
drivers/acpi/device_sysfs.
'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi
xists or there wouldn't be a sysfs file.
Signed-off-by: Betty Dall <betty.d...@hpe.com>
---
drivers/acpi/device_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 49cc0cb..e556a3e 100644
--- a/d
Cleaning up five existing checkpatch errors in device_sysfs.c since the
file is being changed.
Signed-off-by: Betty Dall <betty.d...@hpe.com>
---
drivers/acpi/device_sysfs.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/acpi/device_sys
xists or there wouldn't be a sysfs file.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 49cc0cb..e556a3e 100644
--- a/drivers/acpi/device_sysfs.c
Cleaning up five existing checkpatch errors in device_sysfs.c since the
file is being changed.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi
'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Signed-off-by: Betty Dall <betty.d...@hpe.com>
---
drivers/acpi/device_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/acpi/device_sys
'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi
'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Betty Dall (3):
ACPI/device_sysfs: Add sysfs support for _HRV hardware revision
Change _SUN and _STA show functions error return to EIO
Clean up checkpatch errors
drivers/acpi
'hrv' file. It is most useful for
non-PCI devices because lspci can list the hardware version for PCI
devices.
Betty Dall (3):
ACPI/device_sysfs: Add sysfs support for _HRV hardware revision
Change _SUN and _STA show functions error return to EIO
Clean up checkpatch errors
drivers/acpi
The ACPI _HRV object on the device is used to supply Linux with
the device's hardware revision. This is an optional object. Add
sysfs support for the _HRV object if it exists on the device.
Signed-off-by: Betty Dall <betty.d...@hpe.com>
---
drivers/acpi/device_sysfs.
The ACPI _HRV object on the device is used to supply Linux with
the device's hardware revision. This is an optional object. Add
sysfs support for the _HRV object if it exists on the device.
Signed-off-by: Betty Dall
---
drivers/acpi/device_sysfs.c | 24
1 file changed
The function atl1c_reset_pcie() does not check the return from
pci_find_ext_cabability() where it is getting the postion of the
PCI_EXT_CAP_ID_ERR. It is possible for the return to be 0.
Signed-off-by: Betty Dall
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c |8 +---
1 files
The function atl1c_reset_pcie() does not check the return from
pci_find_ext_cabability() where it is getting the postion of the
PCI_EXT_CAP_ID_ERR. It is possible for the return to be 0.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/net/ethernet/atheros/atl1c/atl1c_main.c |8
On Mon, 2013-12-16 at 12:51 -0700, Bjorn Helgaas wrote:
> On Fri, Dec 13, 2013 at 4:16 PM, Betty Dall wrote:
> > On Fri, 2013-12-13 at 15:35 -0700, Bjorn Helgaas wrote:
> >> On Fri, Dec 13, 2013 at 8:41 AM, Betty Dall wrote:
> >> > There are three functions exported
On Mon, 2013-12-16 at 12:51 -0700, Bjorn Helgaas wrote:
On Fri, Dec 13, 2013 at 4:16 PM, Betty Dall betty.d...@hp.com wrote:
On Fri, 2013-12-13 at 15:35 -0700, Bjorn Helgaas wrote:
On Fri, Dec 13, 2013 at 8:41 AM, Betty Dall betty.d...@hp.com wrote:
There are three functions exported from
On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote:
> I should have thought longer before hitting send. I think it's worthwhile
> to use the same helper in aer_hest_parse_aff(), and once I did that, it
> became more obvious that aer_hest_parse() and aer_hest_parse_aff() are
> essentially
On Fri, 2013-12-13 at 16:06 -0700, Bjorn Helgaas wrote:
I should have thought longer before hitting send. I think it's worthwhile
to use the same helper in aer_hest_parse_aff(), and once I did that, it
became more obvious that aer_hest_parse() and aer_hest_parse_aff() are
essentially
On Fri, 2013-12-13 at 15:35 -0700, Bjorn Helgaas wrote:
> On Fri, Dec 13, 2013 at 8:41 AM, Betty Dall wrote:
> > There are three functions exported from aerdrv_core.c that could be
> > called when the system is in firmware first mode:
> > pci_enable
On Fri, 2013-12-13 at 15:16 -0700, Bjorn Helgaas wrote:
> On Fri, Dec 13, 2013 at 08:23:16AM -0700, Betty Dall wrote:
> > aer_hest_parse() could pass a non-AER HEST error source to the function
> > hest_match_pci(). hest_match_pci() assumes that the HEST error sou
dev,
"pci_cleanup_aer_uncorrect_error_status failed 0x%0x\n",
err); /* non-fatal, continue */
}
That error message is how I found this problem, and it is not applicable
for the firmware first recovery path.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/
error sources where hest_match_pci() was trying to
access the structure as if it had the acpi_hest_aer_common fields.
aer_hest_parse() is only ever interested in the AER type HEST error
sources. Add a check on the type of the error souce at the beginning of
aer_hest_parse().
Signed-off-by: Betty Dall
error sources where hest_match_pci() was trying to
access the structure as if it had the acpi_hest_aer_common fields.
aer_hest_parse() is only ever interested in the AER type HEST error
sources. Add a check on the type of the error souce at the beginning of
aer_hest_parse().
Signed-off-by: Betty Dall
-dev,
pci_cleanup_aer_uncorrect_error_status failed 0x%0x\n,
err); /* non-fatal, continue */
}
That error message is how I found this problem, and it is not applicable
for the firmware first recovery path.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer
On Fri, 2013-12-13 at 15:16 -0700, Bjorn Helgaas wrote:
On Fri, Dec 13, 2013 at 08:23:16AM -0700, Betty Dall wrote:
aer_hest_parse() could pass a non-AER HEST error source to the function
hest_match_pci(). hest_match_pci() assumes that the HEST error source is
type
On Fri, 2013-12-13 at 15:35 -0700, Bjorn Helgaas wrote:
On Fri, Dec 13, 2013 at 8:41 AM, Betty Dall betty.d...@hp.com wrote:
There are three functions exported from aerdrv_core.c that could be
called when the system is in firmware first mode:
pci_enable_pcie_error_reporting
could be safely ignored by error handling software."
The ghes code uses the CPER record's severity and always calls the
function ghes_severity() to convert to the GHES_SEV value. Since the
ACPI spec defines the GHES severity, it makes sense to maintain an enum
for it and use the ghes_severity() to conver
se
multiple PCI segment groups, bits 8-31 must be zero. If the
GLOBAL flag is specified, this field is ignored."
This patch makes use of the new definition in the only place in the kernel
that uses the acpi_hest_aer_common's bus field.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/
segment groups, bits 8-31 must be zero. If the
GLOBAL flag is specified, this field is ignored.
This patch makes use of the new definition in the only place in the kernel
that uses the acpi_hest_aer_common's bus field.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer
record's severity and always calls the
function ghes_severity() to convert to the GHES_SEV value. Since the
ACPI spec defines the GHES severity, it makes sense to maintain an enum
for it and use the ghes_severity() to convert where necessary. This is
what I am thinking:
Author: Betty Dall betty.d
nk function for
both Downstream Ports and Root Ports.
Signed-off-by: Betty Dall
---
Betty Dall (6):
PCI/AER: Don't parse HEST table for non-PCIe devices
PCI/AER: Factor out HEST device type matching
PCI/AER: Set dev->__aer_firmware_first only for matching devices
PCI/ACPI: Move AER severity
.
Signed-off-by: Bjorn Helgaas
Tested-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_acpi.c
b/drivers/pci/pcie/aer/aerdrv_acpi.c
index 5194a7d..4f798ab 100644
--- a/drivers/pci/pcie
Previously, we always updated info->firmware_first, even for HEST entries
that didn't match the device. Therefore, if the last HEST descriptor was
a PCIe structure that didn't match the device, we always cleared
dev->__aer_firmware_first.
Signed-off-by: Bjorn Helgaas
Tested-by: Bett
to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Changes since v1:
Fixed a typo in comment.
Changes since v2:
Set the aer_severity to AER_FATAL rather than using cper_severity_to_aer().
Simplified the comment.
Signed-off-by: Betty Dall
---
drivers/acpi/apei
The function aer_recover_queue() is a public interface and the
severity argument uses #defines that are in the private header
pci/pcie/aer/aerdrv.h.
This patch moves the #defines from pci/pcie/aer/aerdrv.h to
include/linux/aer.h.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv.h
for a Downstream Link.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_core.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c
b/drivers/pci/pcie/aer/aerdrv_core.c
index 8ec8b4f..cb29c04 100644
--- a/drivers/pci/pcie/aer
This factors out the matching of HEST structure type and PCIe device type
to improve readability. No functional change.
Signed-off-by: Bjorn Helgaas
Tested-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c | 35 +--
1 files changed, 17 insertions
for a Downstream Link.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_core.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c
b/drivers/pci/pcie/aer/aerdrv_core.c
index 8ec8b4f..cb29c04 100644
--- a/drivers
This factors out the matching of HEST structure type and PCIe device type
to improve readability. No functional change.
Signed-off-by: Bjorn Helgaas bhelg...@google.com
Tested-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_acpi.c | 35
The function aer_recover_queue() is a public interface and the
severity argument uses #defines that are in the private header
pci/pcie/aer/aerdrv.h.
This patch moves the #defines from pci/pcie/aer/aerdrv.h to
include/linux/aer.h.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci
-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_acpi.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_acpi.c
b/drivers/pci/pcie/aer/aerdrv_acpi.c
index e7ea573..cf611ab 100644
--- a/drivers/pci/pcie/aer/aerdrv_acpi.c
to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Changes since v1:
Fixed a typo in comment.
Changes since v2:
Set the aer_severity to AER_FATAL rather than using cper_severity_to_aer().
Simplified the comment.
Signed-off-by: Betty Dall betty.d...@hp.com
.
Signed-off-by: Bjorn Helgaas bhelg...@google.com
Tested-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_acpi.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/pcie/aer/aerdrv_acpi.c
b/drivers/pci/pcie/aer/aerdrv_acpi.c
index 5194a7d
Ports and Root Ports.
Signed-off-by: Betty Dall betty.d...@hp.com
---
Betty Dall (6):
PCI/AER: Don't parse HEST table for non-PCIe devices
PCI/AER: Factor out HEST device type matching
PCI/AER: Set dev-__aer_firmware_first only for matching devices
PCI/ACPI: Move AER severity defines
On Tue, 2013-06-04 at 16:15 -0600, Bjorn Helgaas wrote:
> On Tue, Jun 4, 2013 at 3:38 PM, Betty Dall wrote:
> > On Tue, 2013-06-04 at 04:36 -0400, Chen Gong wrote:
> >> On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote:
> >> > Date: Thu, 30 May 2
On Tue, 2013-06-04 at 16:15 -0600, Bjorn Helgaas wrote:
On Tue, Jun 4, 2013 at 3:38 PM, Betty Dall betty.d...@hp.com wrote:
On Tue, 2013-06-04 at 04:36 -0400, Chen Gong wrote:
On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote:
Date: Thu, 30 May 2013 08:39:29 -0600
From
On Tue, 2013-06-04 at 04:36 -0400, Chen Gong wrote:
> On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote:
> > Date: Thu, 30 May 2013 08:39:29 -0600
> > From: Betty Dall
> > To: r...@sisk.pl, bhelg...@google.com
> > Cc: ying.hu...@intel.com, linux-a...@
On Tue, 2013-06-04 at 03:53 -0400, Chen Gong wrote:
> On Thu, May 30, 2013 at 08:39:28AM -0600, Betty Dall wrote:
> > Date: Thu, 30 May 2013 08:39:28 -0600
> > From: Betty Dall
> > To: r...@sisk.pl, bhelg...@google.com
> > Cc: ying.hu...@intel.com, linux-a...@
On Tue, 2013-06-04 at 03:53 -0400, Chen Gong wrote:
On Thu, May 30, 2013 at 08:39:28AM -0600, Betty Dall wrote:
Date: Thu, 30 May 2013 08:39:28 -0600
From: Betty Dall betty.d...@hp.com
To: r...@sisk.pl, bhelg...@google.com
Cc: ying.hu...@intel.com, linux-a...@vger.kernel.org
On Tue, 2013-06-04 at 04:36 -0400, Chen Gong wrote:
On Thu, May 30, 2013 at 08:39:29AM -0600, Betty Dall wrote:
Date: Thu, 30 May 2013 08:39:29 -0600
From: Betty Dall betty.d...@hp.com
To: r...@sisk.pl, bhelg...@google.com
Cc: ying.hu...@intel.com, linux-a...@vger.kernel.org
On Sat, 2013-06-01 at 18:38 -0600, Bjorn Helgaas wrote:
> [+cc Bob for ACPI HEST spec questions]
>
> On Thu, May 30, 2013 at 8:39 AM, Betty Dall wrote:
> > The function aer_hest_parse() is called to determine if the given
> > PCI device is firmware first or not. The co
On Sat, 2013-06-01 at 18:38 -0600, Bjorn Helgaas wrote:
[+cc Bob for ACPI HEST spec questions]
On Thu, May 30, 2013 at 8:39 AM, Betty Dall betty.d...@hp.com wrote:
The function aer_hest_parse() is called to determine if the given
PCI device is firmware first or not. The code loops through
to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Changes since v1:
Fixed a typo in comment.
Signed-off-by: Betty Dall
---
drivers/acpi/apei/ghes.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/apei
for the default_downstream_reset_link(). The firmware
first default reset_link brings the root port out of SBR if firmware
left it in SBR.
Changes since v1:
Removed incorrect setting of p2p_ctrl after the read.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_core.c | 36
once the info.firmware_first
variable is set. This is similar to how the function aer_hest_parse_aff()
stops the iteration.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pcie/aer
an recover.
The changes have been tested on systems with firmware first that set the
"reset" bit by injecting various hardware errors. The errors successfully
recover.
Changes since v1:
Fixed a typo in the comment of patch 2.
Removed incorrect setting of reset bit in patch 3.
Signed-off-by: Betty
have been tested on systems with firmware first that set the
reset bit by injecting various hardware errors. The errors successfully
recover.
Changes since v1:
Fixed a typo in the comment of patch 2.
Removed incorrect setting of reset bit in patch 3.
Signed-off-by: Betty Dall betty.d...@hp.com
once the info.firmware_first
variable is set. This is similar to how the function aer_hest_parse_aff()
stops the iteration.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_acpi.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci
for the default_downstream_reset_link(). The firmware
first default reset_link brings the root port out of SBR if firmware
left it in SBR.
Changes since v1:
Removed incorrect setting of p2p_ctrl after the read.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_core.c | 36
to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Changes since v1:
Fixed a typo in comment.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/acpi/apei/ghes.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git
On Wed, 2013-05-29 at 09:42 -0600, Pearson, Greg wrote:
> On 05/28/2013 12:48 PM, Betty Dall wrote:
> > The CPER error record has a reset bit that indicates that the platform
> > has reset the bus. The reset bit can be set for any severity error
> > including recoverable. Fro
On Wed, 2013-05-29 at 09:42 -0600, Pearson, Greg wrote:
> On 05/28/2013 12:48 PM, Betty Dall wrote:
> > The firmware first path does not install the aerdrv root port
> > service driver, so the firmware first root port does not have
> > a reset_link callback. When a firmware
On Wed, 2013-05-29 at 09:42 -0600, Pearson, Greg wrote:
On 05/28/2013 12:48 PM, Betty Dall wrote:
The CPER error record has a reset bit that indicates that the platform
has reset the bus. The reset bit can be set for any severity error
including recoverable. From the AER code path's
On Wed, 2013-05-29 at 09:42 -0600, Pearson, Greg wrote:
On 05/28/2013 12:48 PM, Betty Dall wrote:
The firmware first path does not install the aerdrv root port
service driver, so the firmware first root port does not have
a reset_link callback. When a firmware first root port does not have
once the info.firmware_first
variable is set. This is similar to how the function aer_hest_parse_aff()
stops the iteration.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_acpi.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pcie/aer
an recover.
The changes have been tested on systems with firmware first that set the
"reset" bit by injecting various hardware errors. The errors successfully
recover.
---
Betty Dall (3):
PCI/AER: Fix incorrect return from aer_hest_parse()
ACPI/APEI: Force fatal AER severity when bus has
for the default_downstream_reset_link(). The firmware
first default reset_link brings the root port out of SBR if firmware
left it in SBR.
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer/aerdrv_core.c | 37
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git
to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Signed-off-by: Betty Dall
---
drivers/acpi/apei/ghes.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index
to AER_FATAL whenever the CPER error record
indicates that the bus has been reset.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/acpi/apei/ghes.c | 21 -
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei
for the default_downstream_reset_link(). The firmware
first default reset_link brings the root port out of SBR if firmware
left it in SBR.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_core.c | 37
1 files changed, 37 insertions(+), 0 deletions
have been tested on systems with firmware first that set the
reset bit by injecting various hardware errors. The errors successfully
recover.
---
Betty Dall (3):
PCI/AER: Fix incorrect return from aer_hest_parse()
ACPI/APEI: Force fatal AER severity when bus has been reset
PCI/AER: Provide
once the info.firmware_first
variable is set. This is similar to how the function aer_hest_parse_aff()
stops the iteration.
Signed-off-by: Betty Dall betty.d...@hp.com
---
drivers/pci/pcie/aer/aerdrv_acpi.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/pci
The function aer_recover_queue() makes a call to pci_get_domain_bus_and_slot().
That function is documented to require that the caller decrement the
reference count by calling pci_dev_put(). This patch adds the missing
call to pci_dev_put().
Signed-off-by: Betty Dall
---
drivers/pci/pcie/aer
The function aer_recover_queue() makes a call to pci_get_domain_bus_and_slot().
That function is documented to require that the caller decrement the
reference count by calling pci_dev_put(). This patch adds the missing
call to pci_dev_put().
Signed-off-by: Betty Dall betty.d...@hp.com
tream Port must
report the same value in this field for all Functions."
Signed-off-by: Betty Dall
---
include/uapi/linux/pci_regs.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 20ae747..0cf8
Port must
report the same value in this field for all Functions.
Signed-off-by: Betty Dall betty.d...@hp.com
---
include/uapi/linux/pci_regs.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
index 20ae747
On Wed, 2012-11-14 at 15:43 -0500, Len Brown wrote:
> Here are some turbostat patches I have staged.
> The 1st two I've requested be pulled into 3.7,
> the rest are for 3.8
>
> The final patch allows turbostat to print Watts
> as measured by hardware RAPL counters -- something
> that people have
On Wed, 2012-11-14 at 15:43 -0500, Len Brown wrote:
> From: Len Brown
...
> @@ -1644,7 +1967,7 @@ int main(int argc, char **argv)
> cmdline(argc, argv);
>
> if (verbose > 1)
> - fprintf(stderr, "turbostat v2.1 October 6, 2012"
> + fprintf(stderr, "turbostat
On Wed, 2012-11-14 at 15:43 -0500, Len Brown wrote:
From: Len Brown len.br...@intel.com
...
@@ -1644,7 +1967,7 @@ int main(int argc, char **argv)
cmdline(argc, argv);
if (verbose 1)
- fprintf(stderr, turbostat v2.1 October 6, 2012
+ fprintf(stderr,
On Wed, 2012-11-14 at 15:43 -0500, Len Brown wrote:
Here are some turbostat patches I have staged.
The 1st two I've requested be pulled into 3.7,
the rest are for 3.8
The final patch allows turbostat to print Watts
as measured by hardware RAPL counters -- something
that people have been
On Sat, 2012-08-11 at 03:43 -0700, Andi Kleen wrote:
> On Fri, Aug 10, 2012 at 04:57:02PM -0700, H. Peter Anvin wrote:
> > On 08/09/2012 03:34 PM, Betty Dall wrote:
> > >
> > > I thought this should be a break instead of a continue since the code
> > > doe
On Sat, 2012-08-11 at 03:43 -0700, Andi Kleen wrote:
On Fri, Aug 10, 2012 at 04:57:02PM -0700, H. Peter Anvin wrote:
On 08/09/2012 03:34 PM, Betty Dall wrote:
I thought this should be a break instead of a continue since the code
does a break if the class is 0x. If the function
Hi Andi,
On Wed, 2012-08-08 at 15:17 -0700, Andi Kleen wrote:
> From: Andi Kleen
>
> According to the Intel PCI experts it's not safe to check any
> other field than vendor ID for 0x when doing PCI scans
> to see if the device exists.
>
> Several of the early PCI scans violated this. I
Hi Andi,
On Wed, 2012-08-08 at 15:17 -0700, Andi Kleen wrote:
From: Andi Kleen a...@linux.intel.com
According to the Intel PCI experts it's not safe to check any
other field than vendor ID for 0x when doing PCI scans
to see if the device exists.
Several of the early PCI scans
Hi Tim,
I reviewed this patch and it looks good. Once small suggestion you can
take or leave...
On Tue, 2012-07-24 at 14:31 -0600, Tim Gardner wrote:
> Advertise firmware files using MODULE_FIRMWARE macros.
>
> Cc: Greg Kroah-Hartman
> Cc: linux-...@vger.kernel.org
> Cc:
Hi Aaron,
On Tue, 2012-07-24 at 07:52 +0800, Aaron Lu wrote:
> On Mon, Jul 23, 2012 at 12:43:34PM -0600, Betty Dall wrote:
> > Hi Aaron,
>
> Hi,
>
> >
> > On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote:
> > > Set the ODD's in kernel poll interval to
Hi Aaron,
On Tue, 2012-07-24 at 07:52 +0800, Aaron Lu wrote:
On Mon, Jul 23, 2012 at 12:43:34PM -0600, Betty Dall wrote:
Hi Aaron,
Hi,
On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote:
Set the ODD's in kernel poll interval to 2s for the user in case the
user is using an old
Hi Tim,
I reviewed this patch and it looks good. Once small suggestion you can
take or leave...
On Tue, 2012-07-24 at 14:31 -0600, Tim Gardner wrote:
Advertise firmware files using MODULE_FIRMWARE macros.
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: linux-...@vger.kernel.org
Cc:
Hi Aaron,
On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote:
> Set the ODD's in kernel poll interval to 2s for the user in case the
> user is using an old distro on which udev will not set the system wide
> block parameter events_dfl_poll_msecs.
Why did you pick 2 seconds?
>
> Signed-off-by:
Hi Aaron,
On Mon, 2012-07-23 at 14:49 +0800, Aaron Lu wrote:
Set the ODD's in kernel poll interval to 2s for the user in case the
user is using an old distro on which udev will not set the system wide
block parameter events_dfl_poll_msecs.
Why did you pick 2 seconds?
Signed-off-by: Aaron
Hi Joe,
Joe Perches perches.com> writes:
>
> These types of macros should not be used for either a
> single statement nor should the macro end with a semi-colon.
>
> Add tests for these conditions.
>
> Signed-off-by: Joe Perches perches.com>
> ---
> scripts/checkpatch.pl | 39
Hi Joe,
Joe Perches joe at perches.com writes:
These types of macros should not be used for either a
single statement nor should the macro end with a semi-colon.
Add tests for these conditions.
Signed-off-by: Joe Perches joe at perches.com
---
scripts/checkpatch.pl | 39
Hi Joe,
Thanks for the comment Joe. It looks like Roland already accepted the
trivial change.
On Thu, 2012-07-19 at 11:03 -0700, Joe Perches wrote:
> On Thu, 2012-07-19 at 13:34 -0600, Betty Dall wrote:
> > There is a cut and paste typo in the function qib_pci_slot_reset() where
>
There is a cut and paste typo in the function qib_pci_slot_reset() where
it prints that the "link_reset" function is called rather than the
"slot_reset" function. This makes the message misleading.
Signed-off-by: Betty Dall
---
drivers/infiniband/hw/qib/qib_pcie.c |2 +-
1 - 100 of 102 matches
Mail list logo
