On Tue, 2019-06-04 at 10:45 +0800, Aaron Ma wrote:
> Hi Christopher:
>
> Have got time to review these 2 patches?
> Users reported it works fine since I sent out this patch.
Hi Aaron,
I've been poking around with this off and on. Unfortunately, more off
than on :-( but here's my current take:
On Thu, 2019-03-28 at 14:02 +0800, Aaron Ma wrote:
> Hi Dmitry and Chiristopher:
>
> Do you have any suggestion about these 2 patches?
>
> Many users confirmed that they fixed issues of Trackpoint/Touchpad
> after S3.
>
> Will you consider them be accepted?
Hi Aaron,
Sorry - I thought I'd
On Wed, 2019-02-20 at 17:41 +0100, Aaron Ma wrote:
> CAUTION: Email originated externally, do not click links or open
> attachments unless you recognize the sender and know the content is
> safe.
>
>
> rmi4 got spam data after S3 resume on some ThinkPads.
> Then TrackPoint lost when be detected
On Wed, 2017-01-11 at 18:48 +0100, Benjamin Tissoires wrote:
> On Jan 11 2017 or thereabouts, Arnd Bergmann wrote:
> >
> > On Wednesday, January 11, 2017 5:28:28 PM CET Benjamin Tissoires
> > wrote:
> > >
> > > Yep, it was initially written that way, and IIRC there was some
> > > issues
> > >
On Wed, 2017-01-11 at 18:48 +0100, Benjamin Tissoires wrote:
> On Jan 11 2017 or thereabouts, Arnd Bergmann wrote:
> >
> > On Wednesday, January 11, 2017 5:28:28 PM CET Benjamin Tissoires
> > wrote:
> > >
> > > Yep, it was initially written that way, and IIRC there was some
> > > issues
> > >
is
>
> On Thu, Oct 20, 2016 at 4:28 PM, Christopher Heiny <cheiny@synaptics.
> com> wrote:
> > On Thu, 2016-10-20 at 23:51 +0100, Nick Dyer wrote:
> > > On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote:
> > > >
> > &g
is
>
> On Thu, Oct 20, 2016 at 4:28 PM, Christopher Heiny com> wrote:
> > On Thu, 2016-10-20 at 23:51 +0100, Nick Dyer wrote:
> > > On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote:
> > > >
> > > > On Fri, Sep 30, 2016 at 08:22:47P
On Thu, 2016-10-20 at 23:51 +0100, Nick Dyer wrote:
> On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote:
> >
> > On Fri, Sep 30, 2016 at 08:22:47PM -0700, Guenter Roeck wrote:
> > >
> > > Sensor tuning support is needed to determine the number of
> > > enabled
> > > tx and rx
On Thu, 2016-10-20 at 23:51 +0100, Nick Dyer wrote:
> On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote:
> >
> > On Fri, Sep 30, 2016 at 08:22:47PM -0700, Guenter Roeck wrote:
> > >
> > > Sensor tuning support is needed to determine the number of
> > > enabled
> > > tx and rx
On 07/22/2014 11:11 PM, Dmitry Torokhov wrote:
Signed-off-by: Dmitry Torokhov
I've reviewed this, and can say:
Acked-by: Christopher Heiny
but I haven't had a chance to apply it to my build tree.
Andrew - I'll be OOO for a couple of days. Can you do that, and add a
Tested-by: or rev
On 07/22/2014 11:11 PM, Dmitry Torokhov wrote:
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
I've reviewed this, and can say:
Acked-by: Christopher Heiny che...@synaptics.com
but I haven't had a chance to apply it to my build tree.
Andrew - I'll be OOO for a couple of days. Can
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Do not write configuration data in probe(), we have config() for that.
I've just submitted a patch to correctly call config() after probe().
So this becomes...
Signed-off-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Do not write configuration data in probe(), we have config() for that.
I've just submitted a patch to correctly call config() after probe().
So this becomes...
Signed-off-by: Christopher Heiny che...@synaptics.com
Signed-off-by: Dmitry
On 02/17/2014 11:23 AM, Dmitry Torokhov wrote:
On Fri, Feb 14, 2014 at 03:00:43PM -0800, Christopher Heiny wrote:
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote:
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote:
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Do not write
On 02/17/2014 11:23 AM, Dmitry Torokhov wrote:
On Fri, Feb 14, 2014 at 03:00:43PM -0800, Christopher Heiny wrote:
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote:
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote:
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Do not write
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote:
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote:
>On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
> >Do not write configuration data in probe(), we have config() for that.
>
>Then we should call config() in rmi
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote:
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote:
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Do not write configuration data in probe(), we have config() for that.
Then we should call config() in rmi_function_probe
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
It is not used by anyone.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
We have too many "data"s: f01_data, driver_data, pdata, etc. Let's
untangle it a bit.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 135 ++
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Use rmi_read()/rmi_write() for reading/writing single-byte data. Also print
error code when IO fails.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 170
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Device core provides way of accessing driver-private data, we should
use it.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_bus.h | 1 -
drivers/input/rmi4/rmi_f01.c | 14 +--
drivers/input
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
We do not need to persist it - we read it when signalled.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
to look at some of our other #define
accessors as well, I think.
Signed-off-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input/rmi4/rmi_bus.h| 7 ++-
drivers/input/rmi4/rmi_driver.c | 8
drivers/input/rmi4/rmi_f01.c| 2 +-
drivers/input/rmi4
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Let's allocate interrupt mask together with the main structure and combine
rmi_f01_alloc_memory, rmi_f01_initialize and rmi_f01_probe into single
function.
Signed-off-by: Dmitry Torokhov
Signed-off-by: Christopher Heiny
---
drivers/input
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
From: Christopher Heiny
Both F01_RMI_Ctrl2 and F01_RMI_Ctrl3 (doze_interval and wakeup_threshold)
are controlled by the has_adjustable_doze bit.
Signed-off-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
Not sure if this need an Ack
rror;
- }
} else {
error = rmi_read(rmi_dev, data->doze_holdoff_addr,
>device_control.doze_holdoff);
--
Christopher Heiny
Senior Staff Firmware Engineer
Synaptics Incorporated
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
It is an empty stub and is not needed.
Signed-off-by: Dmitry Torokhov
Signed-off-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input
-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index 381ad60..92b90d1 100644
--- a/drivers/input/rmi4/rmi_f01.c
+++ b/drivers/input
-by: Dmitry Torokhov dmitry.torok...@gmail.com
Signed-off-by: Christopher Heiny che...@synaptics.com
---
drivers/input/rmi4/rmi_f01.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index 381ad60
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
It is an empty stub and is not needed.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Signed-off-by: Christopher Heiny che...@synaptics.com
---
drivers/input/rmi4/rmi_f01.c | 6 --
1 file changed, 6 deletions(-)
diff --git
-device_control.doze_holdoff);
--
Christopher Heiny
Senior Staff Firmware Engineer
Synaptics Incorporated
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
From: Christopher Heiny che...@synaptics.com
Both F01_RMI_Ctrl2 and F01_RMI_Ctrl3 (doze_interval and wakeup_threshold)
are controlled by the has_adjustable_doze bit.
Signed-off-by: Christopher Heinyche...@synaptics.com
Signed-off-by: Dmitry
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Let's allocate interrupt mask together with the main structure and combine
rmi_f01_alloc_memory, rmi_f01_initialize and rmi_f01_probe into single
function.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Signed-off-by: Christopher Heiny
to look at some of our other #define
accessors as well, I think.
Signed-off-by: Christopher Heiny che...@synaptics.com
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/input/rmi4/rmi_bus.h| 7 ++-
drivers/input/rmi4/rmi_driver.c | 8
drivers/input/rmi4
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
We do not need to persist it - we read it when signalled.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Christopher Heiny che...@synaptics.com
---
drivers/input/rmi4/rmi_f01.c | 15 +++
1 file changed, 7
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Device core provides way of accessing driver-private data, we should
use it.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Christopher Heiny che...@synaptics.com
---
drivers/input/rmi4/rmi_bus.h | 1 -
drivers/input
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Use rmi_read()/rmi_write() for reading/writing single-byte data. Also print
error code when IO fails.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Christopher Heiny che...@synaptics.com
---
drivers/input/rmi4/rmi_f01.c
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
We have too many datas: f01_data, driver_data, pdata, etc. Let's
untangle it a bit.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Christopher Heiny che...@synaptics.com
---
drivers/input/rmi4/rmi_f01.c | 135
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
It is not used by anyone.
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Acked-by: Christopher Heiny che...@synaptics.com
---
drivers/input/rmi4/rmi_f01.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/input/rmi4
On 02/03/2014 11:56 PM, Linus Walleij wrote:
On Sat, Jan 19, 2013 at 2:12 AM, Christopher Heiny wrote:
This patchset implements changes based on the synaptics-rmi4 branch of
Dmitry's input tree.
What is happening to the RMI4 driver stuff?
Has this development stalled? The branch
On 02/03/2014 11:56 PM, Linus Walleij wrote:
On Sat, Jan 19, 2013 at 2:12 AM, Christopher Heiny che...@synaptics.com wrote:
This patchset implements changes based on the synaptics-rmi4 branch of
Dmitry's input tree.
What is happening to the RMI4 driver stuff?
Has this development stalled
n;
-
- retval = i2c_master_recv(client, buf, len);
- if (retval < 0)
+ if (retval)
xport->stats.rx_errs++;
else
- dev_dbg(>dev,
- "read %zd bytes at %#06x: %*ph\n",
- len, addr, (i
- dev_dbg(client-dev,
- read %zd bytes at %#06x: %*ph\n,
- len, addr, (int)len, buf);
+ xport-stats.rx_bytes += len;
-exit:
mutex_unlock(rmi_i2c-page_mutex);
return retval;
}
--
Christopher Heiny
Senior Staff Firmware
the proper
tyep - size_t.
Also rename rmi_transport_info to rmi_transport_stats and move protocol
name (which is the only immutable piece of data there) into the transport
device itself.
Acked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input/rmi4/rmi_bus.h| 64
On 01/09/2014 11:44 PM, Dmitry Torokhov wrote:
When adapter does not support required functionality (I2C_FUNC_I2C) we were
returning 0 to the upper layers, making them believe that device bound
successfully.
Acked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input
Acked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input/rmi4/rmi_bus.h | 3 --
drivers/input/rmi4/rmi_i2c.c | 112 +--
2 files changed, 56 insertions(+), 59 deletions(-)
diff --git a/drivers/input/rmi4/rmi_bus.h b/drivers/input/rmi4/rmi
on some older platforms. I've tested it on
some more current platforms, though, and it works there. The old
platforms are running 2.6.xx series kernels, and don't look likely ever
to be updated, So
Acked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input/rmi4
on some older platforms. I've tested it on
some more current platforms, though, and it works there. The old
platforms are running 2.6.xx series kernels, and don't look likely ever
to be updated, So
Acked-by: Christopher Heiny che...@synaptics.com
Signed-off-by: Dmitry Torokhov
On 01/09/2014 11:44 PM, Dmitry Torokhov wrote:
When adapter does not support required functionality (I2C_FUNC_I2C) we were
returning 0 to the upper layers, making them believe that device bound
successfully.
Acked-by: Christopher Heiny che...@synaptics.com
Signed-off-by: Dmitry Torokhov
-by: Christopher Heiny che...@synaptics.com
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
---
drivers/input/rmi4/rmi_bus.h | 3 --
drivers/input/rmi4/rmi_i2c.c | 112 +--
2 files changed, 56 insertions(+), 59 deletions(-)
diff --git a/drivers/input
the proper
tyep - size_t.
Also rename rmi_transport_info to rmi_transport_stats and move protocol
name (which is the only immutable piece of data there) into the transport
device itself.
Acked-by: Christopher Heiny che...@synaptics.com
Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com
Sorry if this is a duplicate - there's some email issues here at work.
On 07/08/2013 03:39 PM, Dmitry Torokhov wrote:
> On Monday, July 08, 2013 10:21:16 PM Christopher Heiny wrote:
>> On 07/08/2013 01:25 AM, Balint Czobor wrote:
>>> Add initial support for Synaptics
On 07/08/2013 01:25 AM, Balint Czobor wrote:
> Add initial support for Synaptics RMI over I2C based touchscreens.
This is pretty old code - it looks like a modification of patches we
submitted last year. Is there some reason you're not basing it off the
latest checkins in synaptics-rmi4 branch
On 07/08/2013 01:25 AM, Balint Czobor wrote:
Add initial support for Synaptics RMI over I2C based touchscreens.
This is pretty old code - it looks like a modification of patches we
submitted last year. Is there some reason you're not basing it off the
latest checkins in synaptics-rmi4 branch of
Sorry if this is a duplicate - there's some email issues here at work.
On 07/08/2013 03:39 PM, Dmitry Torokhov wrote:
On Monday, July 08, 2013 10:21:16 PM Christopher Heiny wrote:
On 07/08/2013 01:25 AM, Balint Czobor wrote:
Add initial support for Synaptics RMI over I2C based touchscreens
On 01/31/2013 01:14 PM, Christopher Heiny wrote:
On 01/31/2013 12:08 AM, Dmitry Torokhov wrote:
Hi Chris,
On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote:
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated
On 01/31/2013 01:14 PM, Christopher Heiny wrote:
On 01/31/2013 12:08 AM, Dmitry Torokhov wrote:
Hi Chris,
On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote:
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated
On 01/31/2013 12:08 AM, Dmitry Torokhov wrote:
Hi Chris,
On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote:
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to conform to the latest RMI4
specification.
I
On 01/31/2013 12:08 AM, Dmitry Torokhov wrote:
Hi Chris,
On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote:
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to conform to the latest RMI4
specification.
I
Changes here are limited to those described in the 0/5 of this patchset, plus
some tweaks to debugging output.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_i2c.c | 141
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to conform to the latest RMI4
specification.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input
changes in
the driver code, and future patchsets can be much smaller and confined to
one or two areas of interest.
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synaptics RMI4 driver team
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Jean Delvare
in order to account for the fact that the PDT may change after
the initial reset.
* Problems with release_rmidev_device() identified by Greg KH are fixed and
tested.
* EXPORT_SYMBOL() changed to EXPORT_SYMBOL_GPL(), per Greg KH input.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus
In addition to the changes described in part 0/5, this fixes some cut
issues in the comments for module_rmi_function_driver.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
include/linux/rmi.h | 95
In addition to the changes described in part 0/5, this fixes some cutpaste
issues in the comments for module_rmi_function_driver.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Linus Walleij linus.wall...@stericsson.com
Cc: Joeri de Gram
in order to account for the fact that the PDT may change after
the initial reset.
* Problems with release_rmidev_device() identified by Greg KH are fixed and
tested.
* EXPORT_SYMBOL() changed to EXPORT_SYMBOL_GPL(), per Greg KH input.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry
changes in
the driver code, and future patchsets can be much smaller and confined to
one or two areas of interest.
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synaptics RMI4 driver team
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to conform to the latest RMI4
specification.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Linus Walleij linus.wall
Changes here are limited to those described in the 0/5 of this patchset, plus
some tweaks to debugging output.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Linus Walleij linus.wall...@stericsson.com
Cc: Joeri de Gram j.de.g...@gmail.com
in order to account for the fact that the PDT may change after
the initial reset.
* Problems with release_rmidev_device() identified by Greg KH are fixed and
tested.
* EXPORT_SYMBOL() changed to EXPORT_SYMBOL_GPL(), per Greg KH input.
Signed-off-by: Christopher Heiny
Cc: Greg Kroah-Hartman
Cc: Dmitry
In addition to the changes described in 0/0 of this patchset, this patch
includes:
* changes to the handling of sysfs as requested in feedback to our
previous patch.
* device serialization updated to conform to the latest specification.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc
In addition to the changes described in part 0/5, this fixes some cut
issues in the comments for module_rmi_function_driver.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
include/linux/rmi.h | 95
Changes here are limited to those described in the 0/0 of this patchset, plus
some tweaks to debugging output.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_i2c.c | 141
In addition to the changes described in 0/0 of this patchset, this patch
includes:
* elimination of unused sysfs and debugfs parameters.
* some fixes to the input device parameters.
* removal of some stray Android stuff.
Signed-off-by: Christopher Heiny
To: Henrik Rydberg
Cc: Dmitry Torokhov
areas of interest.
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synaptics RMI4 driver team
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Jean Delvare
Cc: Linus Walleij
Cc: Joeri de Gram
---
--
To unsubscribe from this list: send the line
areas of interest.
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synaptics RMI4 driver team
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Jean Delvare kh...@linux-fr.org
Cc: Linus Walleij linus.wall
In addition to the changes described in 0/0 of this patchset, this patch
includes:
* elimination of unused sysfs and debugfs parameters.
* some fixes to the input device parameters.
* removal of some stray Android stuff.
Signed-off-by: Christopher Heiny che...@synaptics.com
To: Henrik Rydberg
Changes here are limited to those described in the 0/0 of this patchset, plus
some tweaks to debugging output.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Linus Walleij linus.wall...@stericsson.com
Cc: Joeri de Gram j.de.g...@gmail.com
In addition to the changes described in part 0/5, this fixes some cutpaste
issues in the comments for module_rmi_function_driver.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Dmitry Torokhov dmitry.torok...@gmail.com
Cc: Linus Walleij linus.wall...@stericsson.com
Cc: Joeri de Gram
In addition to the changes described in 0/0 of this patchset, this patch
includes:
* changes to the handling of sysfs as requested in feedback to our
previous patch.
* device serialization updated to conform to the latest specification.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc
in order to account for the fact that the PDT may change after
the initial reset.
* Problems with release_rmidev_device() identified by Greg KH are fixed and
tested.
* EXPORT_SYMBOL() changed to EXPORT_SYMBOL_GPL(), per Greg KH input.
Signed-off-by: Christopher Heiny che...@synaptics.com
Cc: Greg Kroah
,
possibly with some slight modifications.
Thanks!
Chris
From: linux-input-ow...@vger.kernel.org [linux-input-ow...@vger.kernel.org] on
behalf of Dmitry Torokhov [dmitry.torok...@gmail.com]
Sent: Thursday, November 29, 2012 9:21 AM
To: Christopher Heiny
Cc
,
possibly with some slight modifications.
Thanks!
Chris
From: linux-input-ow...@vger.kernel.org [linux-input-ow...@vger.kernel.org] on
behalf of Dmitry Torokhov [dmitry.torok...@gmail.com]
Sent: Thursday, November 29, 2012 9:21 AM
To: Christopher Heiny
Cc
unregister_sensor_driver(void)
{
bus_unregister_notifier(_bus_type, _bus_notifier);
- driver_unregister(_driver.driver);
+ driver_unregister(_sensor_driver.driver);
}
-
-module_init(rmi_driver_init);
-module_exit(rmi_driver_exit);
-
-MODULE_AUTHOR("Christopher Heiny ");
-MO
);
}
-
-module_init(rmi_driver_init);
-module_exit(rmi_driver_exit);
-
-MODULE_AUTHOR(Christopher Heiny che...@synaptics.com);
-MODULE_DESCRIPTION(RMI generic driver);
-MODULE_LICENSE(GPL);
-MODULE_VERSION(RMI_DRIVER_VERSION);
diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers/input/rmi4
On 11/27/2012 01:29 AM, Dmitry Torokhov wrote:
On Mon, Nov 26, 2012 at 02:31:27PM -0800, Christopher Heiny wrote:
>On 11/26/2012 01:40 AM, Dmitry Torokhov wrote:
> >Hi Christopher,
> >
> >On Fri, Nov 16, 2012 at 07:58:53PM -0800, Christopher Heiny wrote:
> >>RM
__exit rmi_f11_module_exit(void)
-{
- rmi_unregister_function_handler(_f11_handler);
-}
-
-module_init(rmi_f11_module_init);
-module_exit(rmi_f11_module_exit);
+module_rmi_driver(rmi_f11_handler);
MODULE_AUTHOR("Christopher Heiny
--
Christopher Heiny
Senior Staff Firmware Engineer
Syna
On 11/27/2012 01:21 AM, Dmitry Torokhov wrote:
To save my old fingers...
Signed-off-by: Dmitry Torokhov
---
It looks like this driver(s) need some love and I might have some time so I
will refresh my "synaptics" branch with the patches you have sent and start
working off it. If you have
On 11/27/2012 01:21 AM, Dmitry Torokhov wrote:
To save my old fingers...
Signed-off-by: Dmitry Torokhovdmitry.torok...@gmail.com
---
It looks like this driver(s) need some love and I might have some time so I
will refresh my synaptics branch with the patches you have sent and start
working off
(rmi_f11_handler);
-}
-
-static void __exit rmi_f11_module_exit(void)
-{
- rmi_unregister_function_handler(rmi_f11_handler);
-}
-
-module_init(rmi_f11_module_init);
-module_exit(rmi_f11_module_exit);
+module_rmi_driver(rmi_f11_handler);
MODULE_AUTHOR(Christopher Heiny che...@synaptics.com
On 11/27/2012 01:29 AM, Dmitry Torokhov wrote:
On Mon, Nov 26, 2012 at 02:31:27PM -0800, Christopher Heiny wrote:
On 11/26/2012 01:40 AM, Dmitry Torokhov wrote:
Hi Christopher,
On Fri, Nov 16, 2012 at 07:58:53PM -0800, Christopher Heiny wrote:
RMI Function 01 implements basic device
On 11/26/2012 10:41 AM, Benjamin Tissoires wrote:
Hi Christopher,
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny wrote:
rmi_bus.c implements the basic functionality of the RMI bus. This file is
greatly simplified compared to the previous patch - we've switched from
"do it you
On 11/26/2012 01:40 AM, Dmitry Torokhov wrote:
Hi Christopher,
On Fri, Nov 16, 2012 at 07:58:53PM -0800, Christopher Heiny wrote:
RMI Function 01 implements basic device control and power management
behaviors for the RMI4 sensor.
rmi_f01.h exports definitions that we expect to be used
On 11/26/2012 01:40 AM, Dmitry Torokhov wrote:
Hi Christopher,
On Fri, Nov 16, 2012 at 07:58:53PM -0800, Christopher Heiny wrote:
RMI Function 01 implements basic device control and power management
behaviors for the RMI4 sensor.
rmi_f01.h exports definitions that we expect to be used
On 11/26/2012 10:41 AM, Benjamin Tissoires wrote:
Hi Christopher,
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny che...@synaptics.com wrote:
rmi_bus.c implements the basic functionality of the RMI bus. This file is
greatly simplified compared to the previous patch - we've switched from
do
On 11/17/2012 01:54 PM, Greg Kroah-Hartman wrote:
On Fri, Nov 16, 2012 at 07:58:50PM -0800, Christopher Heiny wrote:
+static void release_rmidev_device(struct device *dev)
+{
+ device_unregister(dev);
+}
You just leaked memory here, right?
Also, you already unregistered the device
On 11/17/2012 01:54 PM, Greg Kroah-Hartman wrote:
On Fri, Nov 16, 2012 at 07:58:50PM -0800, Christopher Heiny wrote:
+static void release_rmidev_device(struct device *dev)
+{
+ device_unregister(dev);
+}
You just leaked memory here, right?
Also, you already unregistered the device
seek your input on these core
files, particularly the bus implementation.
Signed-off-by: Christopher Heiny
Cc: Greg Kroah-Hartman
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
---
drivers/input/rmi4/rmi_bus.c| 248 ++
drivers/input/rmi4/rm
RMI Function 01 implements basic device control and power management
behaviors for the RMI4 sensor.
rmi_f01.h exports definitions that we expect to be used by other functionality
in the future (such as firmware reflash).
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
device).
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_i2c.c | 490 ++
1 files changed, 490 insertions(+), 0 deletions(-)
diff
1 - 100 of 201 matches
Mail list logo
