ces.
Any ideas on the sysfs group 'power' not found bug on removal while on
use?
Thanks, it will be great to get this fixed.
On Sat, May 26, 2018 at 07:21:11PM +0300, Laurent Pinchart wrote:
> Hi David,
>
> Thank you for the patch.
>
> On Saturday, 26 May 2018 18:
d' not found for kobject 'input32'
sysfs group 'capabilities' not found for kobject 'input32'
sysfs group 'power' not found for kobject 'media0'
--
David Fries
s 0, uvc_delete isn't
called, and evdev doesn't release /dev/input/event*. Plug and unplug
enough times and it runs out of device minors preventing any new input
device and the use of newly plugged in USB video cameras until the
system is rebooted.
Signed-off-by: David Fries
Cc: Guennadi
gt; inconsistent returns 'mutex:&sl->master->mutex'.
> > Locked on: line 416
> > Unlocked on: line 413
> >
> > The problem is that we lock ->mutex but we unlock ->bus_mutex on error.
> > David Fries says that ->bus
l.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
git fetch gregkh_char-misc
git rebase remotes/gregkh_char-misc/char-misc-next
and add a new commit from there.
> Matt Campbell
> mattrcampb...@gmail.com
>
>
> On Tue, Jun 2, 2015 at 9:07 PM, David Fries wrote:
> > The source
> David, not arguing just curious how you decide which lock to use? Is there
> a standard documented?
>
> --m
>
> Matt Campbell
> mattrcampb...@gmail.com
>
> On Tue, Jun 2, 2015 at 8:12 AM, David Fries wrote:
>
> > Thanks for including me, I'm going
laves/w1_therm.c
> @@ -412,7 +412,7 @@ static ssize_t w1_seq_show(struct device *device,
> c -= snprintf(buf + PAGE_SIZE - c, c, "%d\n", seq);
> return PAGE_SIZE - c;
> error:
> - mutex_unlock(&sl->master->bus_mutex);
> + mutex_unlock(&s
ill be freed and set to NULL
causing w1_slave_show to crash when it wakes up.
Signed-off-by: David Fries
Reported-By: Thorsten Bschorr
Tested-by: Thorsten Bschorr
Acked-by: Evgeniy Polyakov
---
This should be applied to the stable series as well. In the name of
full disclosure, this just narr
n ALIBERT*
> *06 32 26 59 12*
> *265, route de Saint Haon*
> *42 370 RENAISON*
>
>
> 2015-03-19 1:09 GMT+01:00 David Fries :
>
> > On Wed, Mar 18, 2015 at 06:18:53PM +0300, Evgeniy Polyakov wrote:
> > > Hi
> > >
> > > 18.03.2
On Wed, Mar 18, 2015 at 06:18:53PM +0300, Evgeniy Polyakov wrote:
> Hi
>
> 18.03.2015, 07:20, "David Fries" :
> > static void w1_therm_remove_slave(struct w1_slave *sl)
> > {
> > + int refcnt = atomic_sub_return(1, THERM_REFCNT(sl->family_data));
On Sat, Mar 14, 2015 at 11:55:16PM +0300, Evgeniy Polyakov wrote:
> Hi David
>
> 12.03.2015, 03:54, "David Fries" :
> > Would that be removing all four refcnt, w1_slave, w1_master,
> > w1_family, w1_cb_block, or just some of them? It sounds good to me,
> >
On Tue, Mar 10, 2015 at 04:52:00PM +0300, Evgeniy Polyakov wrote:
> Hi
>
> 10.03.2015, 02:09, "David Fries" :
>
> > diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c
> > index 1f11a20..39a9e6a 100644
> > --- a/drivers/w1/slave
e if mobing the sl lock at the beginning of
> w1_slave_show can cause dead locks in other scenarios.
I'm not sure, I would probably switch back to the referencing counting
version I wrote earlier, or make the bus mutex lock a timed lock or
try lock first.
--
David Fries PGP pub CB1EE8F0
ht
upstream anyway).
>From 777f5fd75f5f99a3352863e83d226c7b65ebdaa4 Mon Sep 17 00:00:00 2001
From: David Fries
Date: Sat, 7 Mar 2015 22:25:37 -0600
Subject: [PATCH] w1_therm, don't let the slave go away while in w1_slave_show
A temperature conversion can take 750 ms to complete, if the senso
On Wed, Mar 04, 2015 at 06:36:41PM +0300, ??? ??? wrote:
> Hi David
>
> 02.03.2015, 03:17, "David Fries" :
>
> > You are correct, it would be a race condition if it doesn't increment
> > the refcnt before unlocking the mutex, and it should get
if (i != 0) {
/* failed to lock */
return i;
}
if (!refcnt)
/* got lock, but slave went away */
mutex_unl
On Sun, Mar 01, 2015 at 04:48:22AM +0300, ??? ??? wrote:
> Hi everyone
>
> 28.02.2015, 23:18, "David Fries" :
> > Thanks for preparing the patch, it looks like it will go another
> > round, but that happens to everyone.
>
> Patch itself does
ocumentation/SubmittingPatches if you haven't
already.
Signed-off-by: David Fries
scripts/checkpatch.pl /tmp/w1_null_patch.patch
Thanks, keep up improving things.
On Fri, Feb 27, 2015 at 09:43:14AM +0100, Thorsten.Bschorr wrote:
> w1_slave_show unlocks the bus while waiting for the se
CPU and
> external disc load (timing and/or electrical issues); it seems that the
> sensor does not respond in time to the (periodic) search.
>
>
> Please email me if you need further information.
>
>
>
> Best regards,
> Thorsten Bschorr
> --
> To unsubscribe fr
the format of w1_slave printing two sensor readings
and such, it's confusing. Back in the day (2008) I at least
standardized the t= converted value to millidegrees C. That was
because DS18B20 gave degrees C where DS18S20 gave millidegrees C, so
it's been worse.
> Thanks,
> //ric
ct = read_rom(device, rom);
> +
> + if (verdict < 0)
> + return verdict;
I wanted to point out that this returns without unlocking bus_mutex.
--
David Fries PGP pub CB1EE8F0
http://fries.net/~david/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu
ocked on one read each (provided they
don't block the other readers).
Thanks for Cc'ing me on this.
> Mariusz Gorski (2):
> w1: slaves: w1_therm: Extract read_rom function
> w1: slaves: w1_therm: Add temp attribute
>
> drivers/w1/slaves/w1_therm.c | 83
> ++
Reported-by: Dan Carpenter
Acked-by: Evgeniy Polyakov
Signed-off-by: David Fries
---
drivers/w1/w1_netlink.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c
index dd96562..881597a 100644
--- a/drivers/w1/w1_netlink.c
Signed-off-by: David Fries
---
drivers/connector/connector.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
index f612d68..30f5228 100644
--- a/drivers/connector/connector.c
+++ b/drivers/connector/connector.c
@@ -141,12
Greg Kroah-Hartman,
These issues were found by Dan Carpenter with a static checker and will check
message buffer lengths from userspace or avoid length overflows. Evgeniy
Polyakov has given his ack, and they can be applied to the stable branch as
well.
[PATCH 1/2] cn: verify msg->len before makin
The struct cn_msg len field comes from userspace and needs to be
validated. More logical to do so here where the cn_msg pointer is
pulled out of the sk_buff than the callback which is passed cn_msg *
and might assume no validation is needed.
Reported-by: Dan Carpenter
Signed-off-by: David Fries
Reported-by: Dan Carpenter
Signed-off-by: David Fries
---
drivers/w1/w1_netlink.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c
index dd96562..881597a 100644
--- a/drivers/w1/w1_netlink.c
+++ b/drivers/w1/w1_netlink.c
These issues were found by Dan Carpenter with a static checker.
Evgeniy are you okay with these?
[PATCH 1/2] cn: verify msg->len before making callback
[PATCH 2/2] w1: avoid potential u16 overflow
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message t
Acked-by: David Fries
On Wed, May 07, 2014 at 01:26:04AM +0400, Alexey Khoroshilov wrote:
> w1_process_callbacks() expects to be called with dev->list_mutex held,
> but it is the fact only in w1_process(). __w1_remove_master_device()
> calls w1_process_callbacks() after it release
On Wed, May 07, 2014 at 01:42:12AM +0400, Alexey Khoroshilov wrote:
> On 01.05.2014 07:48, David Fries wrote:
> > On Thu, May 01, 2014 at 12:37:58AM +0400, Alexey Khoroshilov wrote:
> >> w1_process_callbacks() expects to be called with dev->list_mutex held,
> >&
gt; +
> + mutex_lock(&dev->list_mutex);
> + ret = __w1_process_callbacks(dev);
> + mutex_unlock(&dev->list_mutex);
> + return ret;
> +}
> +
> +
> #endif /* __KERNEL__ */
>
> #endif /* __W1_H */
> --
> 1.8.3.2
>
> --
&
e device sysfs entries are setup before the add
goes out.
Belisko Marek reported this change fixed the deadlock he was seeing on
ARM device tree, while testing on my x86-64 system never saw the
deadlock.
Reported-by: Belisko Marek
Signed-off-by: David Fries
---
Evgeniy any comments? The patch lo
I'm based on commit ce7613db2d8d4d5af2587a.
On Tue, Apr 08, 2014 at 09:47:50PM +0200, Belisko Marek wrote:
> Hi,
>
> On Mon, Mar 24, 2014 at 1:01 PM, Evgeniy Polyakov wrote:
> > Hi everyone
> >
> > 24.03.2014, 01:50, "David Fries" :
> >> On Mon,
into the merge window. Let me know if I should rewrite it for
stable and which kernel version.
The other two patches are more feature based changes.
On Tue, Apr 08, 2014 at 10:37:07PM -0500, David Fries wrote:
> If the message type is W1_MASTER_CMD or W1_SLAVE_CMD, then a reference
> is taken w
ned-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
Documentation/connector/connector.txt |2 +-
Documentation/w1/w1.generic |2 +-
Documentation/w1/w1.netlink | 13 +-
drivers/w1/w1.h |8 -
drivers/w1/w1_netlink.c
the problem.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/w1_netlink.c | 44 ++--
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c
index 5234964..a02704a 100644
--- a
identifies there being multiple of
the next.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
Documentation/connector/connector.txt | 13 ++---
drivers/connector/connector.c | 17 +++--
include/linux/connector.h |1 +
3 files changed, 26
A program can bundle a sequence of commands in one netlink packet but
the kernel was having to reply in many different packets, this adds a
flag W1_CN_BUNDLE in the cn_msg.flags to allow the kernel to bundle
the replies in to one message. This is opt in to avoid breaking
programs that aren't expec
Evgeniy,
Could you review this set of patches in this thread? Thanks.
On Sat, Mar 22, 2014 at 08:27:44PM -0500, David Fries wrote:
> On Fri, Feb 21, 2014 at 01:07:28AM +0400, Evgeniy Polyakov wrote:
> > Your approach and patch seem correct, but I worry about how old
> > command
ling lock debugging
on 3.14.0-rc5+ which includes some changes I'm working on.
https://github.com/dfries/linux.git w1_rework
--
David Fries PGP pub CB1EE8F0
http://fries.net/~david/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
sl->refcnt);
> - mutex_unlock(&dev->mutex);
> out_cont:
> if (!cmd || err)
> w1_netlink_send_error(msg, m, cmd, err);
> --
> 1.8.4.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ke
uch as the data returned from a read.
Signed-off-by: David Fries
Some of the common variable names have been standardized as follows.
struct cn_msg *cn
struct w1_netlink_msg *msg
struct w1_netlink_cmd *cmd
struct w1_master *dev
When an argument and a function scope variable would collide, add r
identifies there being multiple of
the next.
Signed-off-by: David Fries
---
Documentation/connector/connector.txt | 13 ++---
drivers/connector/connector.c | 17 +++--
include/linux/connector.h |1 +
3 files changed, 26 insertions(+), 5 deletions
the problem.
Signed-off-by: David Fries
---
drivers/w1/w1_netlink.c | 44 ++--
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c
index 5234964..a02704a 100644
--- a/drivers/w1/w1_netlink.c
+++ b
On Fri, Feb 21, 2014 at 01:07:28AM +0400, Evgeniy Polyakov wrote:
> Your approach and patch seem correct, but I worry about how old
> commands are processed. Do I get it right, that replies to old
> non-bundle commands are queued back instead of sending immediately,
> but since it is not bundle bu
A program can bundle multiple messages and commands together when
making one wire requests, which is going to be much more efficient
than sending lots of little packets one write at a time. With this
change the kernel will then bundle responses to requests that were
bundled, where it's probably ev
ill end up with a value
less than one despite the "tmp < 1" check.
Acked-by: David Fries
On Tue, Feb 11, 2014 at 07:08:26PM +0300, Dan Carpenter wrote:
> On 64 bit systems, a large value for "tmp" could be truncated so we
> still end up with a ->max_slave_count which
This reverts ds1wm.c from commit d3a8a9dbb903c73a7ec2deae4c9b7d74b6834f4c.
Of the three files changed ds1wm.c ds2490.c and w1_netlink.c, it turns out
ds1wm.c was locking bus_mutex, but inside the loop and I missed it.
Reverting ds1wm.c to the previous version.
Signed-off-by: David Fries
Reported
On Sat, Feb 08, 2014 at 01:23:43AM +0400, z...@ioremap.net wrote:
> Hi
>
> 07.02.2014, 10:00, "David Fries" :
>
> > Here's a patch to implement that. Is this what you have in mind?
> >
> > From 4ed65d81b0121a8c191a9833d041484e9097198b Mon Sep 17
On Wed, Feb 05, 2014 at 03:48:45AM +0400, z...@ioremap.net wrote:
> Hi
>
> 04.02.2014, 09:51, "David Fries" :
> > Help me understand what the protocol is supposed to be. Assuming
> > there aren't any errors, is there supposed to be a
> > w1_netlink_sen
On Tue, Feb 04, 2014 at 03:59:38AM +0400, z...@ioremap.net wrote:
> Hi
>
> 03.02.2014, 05:15, "David Fries" :
>
> > I could submit these patches as in, which would require the previous
> > set, or I could merge the documentation into the previous set and
I wasn't sure on the length, so I looked it up and documented it.
Signed-off-by: David Fries
---
drivers/w1/w1_netlink.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h
index 1e9504e..c646a98 100644
--- a/dr
Otherwise there's an extra reply being sent out for each async
message. Some commands such as W1_CMD_LIST_SLAVES will be identical
except one message has data and the other doesn't making it difficult
for a program to know if all the slaves just vanished or what happened.
Signed-off
the problem.
Signed-off-by: David Fries
---
drivers/w1/w1_netlink.c | 44 ++--
1 file changed, 26 insertions(+), 18 deletions(-)
diff --git a/drivers/w1/w1_netlink.c b/drivers/w1/w1_netlink.c
index 5234964..a02704a 100644
--- a/drivers/w1/w1_netlink.c
+++ b
I could submit these patches as in, which would require the previous
set, or I could merge the documentation into the previous set and
resubmit them all since they haven't made it into the kernel tree yet.
Opinions?
Here's a small refcnt fix, skipping sending non-error messages, and
documentation
Signed-off-by: David Fries
---
Documentation/connector/connector.txt | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/connector/connector.txt
b/Documentation/connector/connector.txt
index e5c5f5e..9bdfc1a 100644
--- a/Documentation/connector
once merged upstream won't be updated unless I have
another set of changes.
cd5f76716a37ebef3e8b771d672ba552a25dafd5
git://github.com/dfries/linux.git w1_rework
--
David Fries PGP pub CB1EE8F0
http://fries.net/~david/
--
To unsubscribe from this list: send the line "unsubscribe linux
both netlink and /sys slaves were executing bus
commands at the same time.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/masters/ds1wm.c |4 +++-
drivers/w1/masters/ds2490.c |8 ++--
drivers/w1/w1_netlink.c | 13 +++--
3 files changed, 20 insertions(
Switch the code documentation format style to DocBook format, enable
DocBook documentation generation, and fix some comments.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
Documentation/DocBook/Makefile |2 +-
Documentation/DocBook/w1.tmpl | 101
ot; change went from 23.16 seconds to about 3 seconds,
this takes the time for the search down to .307346 seconds.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
Documentation/w1/masters/ds2490 |2 -
drivers/w1/masters/ds2490.c | 108 +++---
to do with that printed temperature value.
Modify the code to store the last good conversion in family_data,
which is designed for custom data structures.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/slaves/w1_therm.c | 21 +++--
drivers/w1/w1.h
Use a #define for the usb vendor request type, clear the status
byte and use that instead of a magic offset in checking if idle.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/masters/ds2490.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions
as it is an interrupt pipe
(bulk worked, it was just technically the wrong call).
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/masters/ds2490.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/w1/masters/ds2490.c b
Netlink is a socket interface and is expected to be asynchronous.
Clients can now make w1 requests without blocking by making use of the
w1_master thread to process netlink commands which was previously only
used for doing an automatic bus search.
Signed-off-by: David Fries
Acked-by: Evgeniy
ts such as add/remove master/slave devices.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/w1.h |5 +
drivers/w1/w1_netlink.c | 42 +-
2 files changed, 30 insertions(+), 17 deletions(-)
diff --git a/drivers/w1/w1.h b/
This allows replying only to the requestor portid while still
supporting broadcasting. Pass 0 to portid for the previous behavior.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
Documentation/connector/cn_test.c |2 +-
drivers/connector/cn_proc.c| 18
memory when needed, so move kzalloc into w1_get_slaves
where it was used.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/w1.c |6 +--
drivers/w1/w1.h |3 ++
drivers/w1/w1_netlink.c | 125 ++-
drivers/w1
e the first time the count is reached and
there were more devices to discover to let the user know why not
all the devices were found.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/w1.c | 30 --
drivers/w1/w1.h |2 ++
2 files changed, 30 inser
Search will detect at most max_slave_count devices per run, if there
are more pick up the next search where the previous left off.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/w1.c | 18 +++---
drivers/w1/w1.h |3 +++
2 files changed, 18 insertions
It's valid to set the search count to 0 to stop searching, so don't
wake up the search thread to not search.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
---
drivers/w1/w1.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/w1/w1.c b/drive
n, so it is important to abort early if the
hardware is removed in the middle of a search.
Signed-off-by: David Fries
Acked-by: Evgeniy Polyakov
Cc: Marcin Jurkowski
Cc: Josh Boyer
Cc: Sven Geggus
---
drivers/w1/w1.c |3 +--
drivers/w1/w1.h | 10 ++
drivers/w1/w1_int.c
This patch series aims to extend and improve the netlink interface to
the one wire system. Netlink is exposed as a socket interface which
is normally assumed to be asynchronous which only blocks waiting on
incoming packets or a fulls end buffer, but were executed on the
calling thread. A bus devi
quot; because when it is 8,
there is space.
Instead, if there isn't space send and clear the buffer, then there is
always space for the slave id.
Signed-off-by: David Fries
Cc: sta...@vger.kernel.org
Acked-by: Evgeniy Polyakov
---
drivers/w1/w1_netlink.c | 25 +
Polyakov wrote:
> Hi
>
> 15.01.2014, 08:52, "David Fries" :
> > The bus_mutex needs to be taken to serialize access to a specific bus.
> > netlink wasn't updated when bus_mutex was added and was calling
> > without that lock held, and not all of the masters wer
both netlink and /sys slaves were executing bus
commands at the same time.
Signed-off-by: David Fries
---
This fixes existing bugs, tacking it to the end of the previous patch
series.
drivers/w1/masters/ds1wm.c |4 +++-
drivers/w1/masters/ds2490.c |8 ++--
drivers/w1/w1_netlink.c |
Search will detect at most max_slave_count devices per run, if there
are more pick up the next search where the previous left off.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/w1.c | 18 +++---
drivers/w1/w1.h |3 +++
2 files changed, 18 insertions(+), 3
This patch series aims to extend and improve the netlink interface to
the one wire system. Netlink is exposed as a socket interface which
is normally assumed to be asynchronous which only blocks waiting on
incoming packets or a fulls end buffer, but were executed on the
calling thread. A bus devi
to do with that printed temperature value.
Modify the code to store the last good conversion in family_data,
which is designed for custom data structures.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/slaves/w1_therm.c | 21 +++--
drivers/w1/w1.h
as it is an interrupt pipe
(bulk worked, it was just technically the wrong call).
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/masters/ds2490.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/w1/masters/ds2490.c b/drivers/w1
ot; change went from 23.16 seconds to about 3 seconds,
this takes the time for the search down to .307346 seconds.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
Documentation/w1/masters/ds2490 |2 -
drivers/w1/masters/ds2490.c | 108 +++
2 fil
e the first time the count is reached and
there were more devices to discover to let the user know why not
all the devices were found.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/w1.c | 30 --
drivers/w1/w1.h |2 ++
2 files changed, 30 insertions(
This allows replying only to the requestor portid while still
supporting broadcasting. Pass 0 to portid for the previous behavior.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
Documentation/connector/cn_test.c |2 +-
drivers/connector/cn_proc.c| 18
ts such as add/remove master/slave devices.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/w1.h |5 +
drivers/w1/w1_netlink.c | 42 +-
2 files changed, 30 insertions(+), 17 deletions(-)
diff --git a/drivers/w1/w1.h b/drive
memory when needed, so move kzalloc into w1_get_slaves
where it was used.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/w1.c |6 +--
drivers/w1/w1.h |3 ++
drivers/w1/w1_netlink.c | 125 ++-
drivers/w1
Use a #define for the usb vendor request type, clear the status
byte and use that instead of a magic offset in checking if idle.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/masters/ds2490.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions
Netlink is a socket interface and is expected to be asynchronous.
Clients can now make w1 requests without blocking by making use of the
w1_master thread to process netlink commands which was previously only
used for doing an automatic bus search.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
n, so it is important to abort early if the
hardware is removed in the middle of a search.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
Cc: Marcin Jurkowski
Cc: Josh Boyer
Cc: Sven Geggus
---
drivers/w1/w1.c |3 +--
drivers/w1/w1.h | 10 ++
drivers/w1/w1_int.c
Switch the code documentation format style to DocBook format, enable
DocBook documentation generation, and fix some comments.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
Documentation/DocBook/Makefile |2 +-
Documentation/DocBook/w1.tmpl | 101
It's valid to set the search count to 0 to stop searching, so don't
wake up the search thread to not search.
Signed-off-by: David Fries
Cc: Evgeniy Polyakov
---
drivers/w1/w1.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/
quot; because when it is 8,
there is space.
Instead, if there isn't space send and clear the buffer, then there is
always space for the slave id.
Signed-off-by: David Fries
Cc: sta...@vger.kernel.org
Cc: Evgeniy Polyakov
---
drivers/w1/w1_netlink.c | 25 +
1 fil
On Wed, Nov 13, 2013 at 05:15:52AM +0400, Evgeny Boger wrote:
> 11/12/2013 12:01 PM, David Fries:
> >On Tue, Nov 12, 2013 at 05:07:14AM +0400, Evgeny Boger wrote:
> >>+David Fries
> >>
> >>Hi David,
> >>
> >>Would you please comment on this?
&
On Tue, Nov 12, 2013 at 05:07:14AM +0400, Evgeny Boger wrote:
> +David Fries
>
> Hi David,
>
> Would you please comment on this?
On Mon, Nov 11, 2013 at 06:36:54PM +0400, Evgeny Boger wrote:
> Strong pullup is emulated by driving pin logic high after write
> command wh
On Thu, Sep 13, 2012 at 11:34:29PM +1000, Stephen Rothwell wrote:
> Hi David,
>
> On Thu, 13 Sep 2012 08:24:08 -0500 David Fries wrote:
> >
> > On Thu, Sep 13, 2012 at 06:11:27PM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After
ONFIG_PM set.
>
> I have reverted that commit for today.
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
David Fries PGP pub CB1EE8F0
http://fries.net/~david/
signature.asc
Description: Digital signature
ned-off-by: David Fries
Cc: Matthew Garrett
Cc: Alessandro Zummo
Cc: Uwe Kleine-König
Cc: Andrew Morton
---
On Fri, Sep 07, 2012 at 04:56:26PM -0700, Andrew Morton wrote:
> On Sat, 25 Aug 2012 21:19:31 -0500
> David Fries wrote:
>
> > Subject: [PATCH] rtc_sysfs_show_hctosys 0 i
uses only CONFIG_RTC_HCTOSYS_DEVICE for conditional compilation
instead of it and CONFIG_RTC_HCTOSYS. rtc_hctosys_ret was moved to
class.c so rtc_hctosys can be removed with just a Kconfig change if
boot time setting isn't desired.
Signed-off-by: David Fries
Cc: Matthew Garrett
Cc: Alessandro
back to the
program. That way a program that has a list of what devices should be
there can find out if they are detected without the driver constantly
scanning the bus for the same old devices. By the way the default bus
scan takes 7.7 seconds to complete and then sleeps 10 seconds before
the
now be 1000 times bigger. Fortunately there can't be that
many users out there, or some of these bugs will have been fixed by
now, such as the negative C error (see previous patch) that makes me
think the ds18b20 is the better choice to change because of the
current bugs.
Signed-off-by: David
hat just returns
the millidegrees C in ASCII without any other text. It would be
easier to parse. If the conversion fails return 0 bytes. Just an
idea, but if someone wants it they can write the patch.
--
David Fries <[EMAIL PROTECTED]>
http://fries.net/~david/ (PGP encryption key available
t; 655.35 K = 382.20 ?C = 719.96 ?F
The range for the sensor is -55 to 125 C, if an application didn't
care about precision they could store it in a signed 8 bit value just
fine.
--
David Fries <[EMAIL PROTECTED]>
http://fries.net/~david/ (PGP encryption key available)
--
To unsubsc
1 - 100 of 114 matches
Mail list logo
