[RFC/PATCH 1/2] kconfig: add KBUILD_USERCONFIG option

2015-08-27 Thread Felipe Contreras
CONFIG_PM_RUNTIME=y CONFIG_SCHED_AUTOGROUP=y CONFIG_UEVENT_HELPER_PATH="" CONFIG_FHANDLE=y CONFIG_EFI_STUB=y CONFIG_EFIVAR_FS=m CONFIG_HYPERVISOR_GUEST=y CONFIG_DRM_CIRRUS_QEMU=y CONFIG_CFG80211=m CONFIG_MAC80211=m CONFIG_IWLWIFI=m CONFIG_CFG80211_DEFAULT_PS=n Signed-off-by: Felipe

[RFC/PATCH 0/2] A simpler way to maintain custom defconfigs

2015-08-27 Thread Felipe Contreras
es anything that is in the default defconfig (e.g. x86_64_defconfig) I've been doing this by hand, but today I gave it a shot to automate this. The result is a bit crude, but it works. Thoughts? Felipe Contreras (2): kconfig: add KBUILD_USERCONFIG option kconfig: add KCONFIG_BASECONFIG option to sa

[RFC/PATCH 2/2] kconfig: add KCONFIG_BASECONFIG option to savedefconfig

2015-08-27 Thread Felipe Contreras
This option parses a defconfig file, and sets all the values as default ones. The result is a much simplified defconfig. This defconfig can be used as a KBUILD_USERCONFIG, which added to the default defconfig generates exactly the same config file. Signed-off-by: Felipe Contreras --- scripts

[RFC/PATCH 2/2] kconfig: add KCONFIG_BASECONFIG option to savedefconfig

2015-08-27 Thread Felipe Contreras
This option parses a defconfig file, and sets all the values as default ones. The result is a much simplified defconfig. This defconfig can be used as a KBUILD_USERCONFIG, which added to the default defconfig generates exactly the same config file. Signed-off-by: Felipe Contreras felipe.contre

[RFC/PATCH 1/2] kconfig: add KBUILD_USERCONFIG option

2015-08-27 Thread Felipe Contreras
CONFIG_PM_RUNTIME=y CONFIG_SCHED_AUTOGROUP=y CONFIG_UEVENT_HELPER_PATH= CONFIG_FHANDLE=y CONFIG_EFI_STUB=y CONFIG_EFIVAR_FS=m CONFIG_HYPERVISOR_GUEST=y CONFIG_DRM_CIRRUS_QEMU=y CONFIG_CFG80211=m CONFIG_MAC80211=m CONFIG_IWLWIFI=m CONFIG_CFG80211_DEFAULT_PS=n Signed-off-by: Felipe Contreras

[RFC/PATCH 0/2] A simpler way to maintain custom defconfigs

2015-08-27 Thread Felipe Contreras
that is in the default defconfig (e.g. x86_64_defconfig) I've been doing this by hand, but today I gave it a shot to automate this. The result is a bit crude, but it works. Thoughts? Felipe Contreras (2): kconfig: add KBUILD_USERCONFIG option kconfig: add KCONFIG_BASECONFIG option to savedefconfig

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-09 Thread Felipe Contreras
Michal Hocko wrote: > On Fri 06-06-14 18:11:14, Felipe Contreras wrote: > > On Fri, Jun 6, 2014 at 5:33 AM, Felipe Contreras > > wrote: > > > On Fri, Jun 6, 2014 at 4:16 AM, Michal Hocko wrote: > > > > > >> Mel has a nice systemtap script (attached) t

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-09 Thread Felipe Contreras
Michal Hocko wrote: On Fri 06-06-14 18:11:14, Felipe Contreras wrote: On Fri, Jun 6, 2014 at 5:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Jun 6, 2014 at 4:16 AM, Michal Hocko mho...@suse.cz wrote: Mel has a nice systemtap script (attached) to watch for stalls

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-07 Thread Felipe Contreras
gt; + if (nr_immediate) > congestion_wait(BLK_RW_ASYNC, HZ/10); > } That actually seems to work correctly on v3.15-rc8. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-07 Thread Felipe Contreras
) congestion_wait(BLK_RW_ASYNC, HZ/10); } That actually seems to work correctly on v3.15-rc8. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
On Fri, Jun 6, 2014 at 5:33 AM, Felipe Contreras wrote: > On Fri, Jun 6, 2014 at 4:16 AM, Michal Hocko wrote: > >> Mel has a nice systemtap script (attached) to watch for stalls. Maybe >> you can give it a try? > > Is there any special configurations I should enable? &g

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
On Fri, Jun 6, 2014 at 6:03 AM, Michal Hocko wrote: > On Fri 06-06-14 05:33:28, Felipe Contreras wrote: >> On Fri, Jun 6, 2014 at 4:16 AM, Michal Hocko wrote: >> >> > Mel has a nice systemtap script (attached) to watch for stalls. Maybe >> > you can give it

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
eading and writing to the SSD (although the stall is less severe). Here's the test: http://pastie.org/9264124 Just pass a big file as the first argument. I don't have much memory in this machine, so I guess running out of memory is the trigger. -- Felipe Contreras -- To unsubscribe from this list

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
new.pl line 320. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
On Fri, Jun 6, 2014 at 4:58 AM, wrote: > Alternatively can we try wait_iff_congested(zone, BLK_RW_ASYNC, HZ/10) ? I see the same problem with that code. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
On Fri, Jun 6, 2014 at 4:58 AM, zhd...@sina.com wrote: Alternatively can we try wait_iff_congested(zone, BLK_RW_ASYNC, HZ/10) ? I see the same problem with that code. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
-dstate-new.pl line 320. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
reading and writing to the SSD (although the stall is less severe). Here's the test: http://pastie.org/9264124 Just pass a big file as the first argument. I don't have much memory in this machine, so I guess running out of memory is the trigger. -- Felipe Contreras -- To unsubscribe from this list

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
On Fri, Jun 6, 2014 at 6:03 AM, Michal Hocko mho...@suse.cz wrote: On Fri 06-06-14 05:33:28, Felipe Contreras wrote: On Fri, Jun 6, 2014 at 4:16 AM, Michal Hocko mho...@suse.cz wrote: Mel has a nice systemtap script (attached) to watch for stalls. Maybe you can give it a try? Is there any

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-06 Thread Felipe Contreras
On Fri, Jun 6, 2014 at 5:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Jun 6, 2014 at 4:16 AM, Michal Hocko mho...@suse.cz wrote: Mel has a nice systemtap script (attached) to watch for stalls. Maybe you can give it a try? Is there any special configurations I should

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-05 Thread Felipe Contreras
On Thu, Jun 5, 2014 at 8:37 AM, Michal Hocko wrote: > On Thu 05-06-14 06:33:40, Felipe Contreras wrote: >> For a while I've noticed that my machine bogs down in certain >> situations, usually while doing heavy I/O operations, it is not just the >> I/O operations, but

Interactivity regression since v3.11 in mm/vmscan.c

2014-06-05 Thread Felipe Contreras
) congestion_wait(BLK_RW_ASYNC, HZ/10); After that I don't notice the slow down any more. Anybody has any ideas how to fix the issue properly? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

Interactivity regression since v3.11 in mm/vmscan.c

2014-06-05 Thread Felipe Contreras
) congestion_wait(BLK_RW_ASYNC, HZ/10); After that I don't notice the slow down any more. Anybody has any ideas how to fix the issue properly? -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: Interactivity regression since v3.11 in mm/vmscan.c

2014-06-05 Thread Felipe Contreras
On Thu, Jun 5, 2014 at 8:37 AM, Michal Hocko mho...@suse.cz wrote: On Thu 05-06-14 06:33:40, Felipe Contreras wrote: For a while I've noticed that my machine bogs down in certain situations, usually while doing heavy I/O operations, it is not just the I/O operations, but everything, including

Re: [ANNOUNCE] Git v2.0.0-rc4

2014-05-21 Thread Felipe Contreras
Junio C Hamano wrote: > Felipe Contreras writes: > > > Junio C Hamano wrote: > > > >> * The remote-helper interface to fast-import/fast-export via the > >>transport-helper has been tightened to avoid leaving the import > >>marks file from a f

Re: [ANNOUNCE] Git v2.0.0-rc4

2014-05-21 Thread Felipe Contreras
Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: Junio C Hamano wrote: * The remote-helper interface to fast-import/fast-export via the transport-helper has been tightened to avoid leaving the import marks file from a failed/crashed run, as such a file

RE: [ANNOUNCE] Git v2.0.0-rc4

2014-05-20 Thread Felipe Contreras
on of itself. Really? Where are the patches for that? I think it's fair to say the way the remote-helpers and transport-helper has been handled for v2.0 has been a total disaster. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

RE: [ANNOUNCE] Git v2.0.0-rc4

2014-05-20 Thread Felipe Contreras
. Really? Where are the patches for that? I think it's fair to say the way the remote-helpers and transport-helper has been handled for v2.0 has been a total disaster. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline

2014-05-06 Thread Felipe Contreras
but since it's 230 lines of *readable* code, that shouldn't be a problem. I also wrote a blog post explaining the process that lad me to that code[2]. Cheers. [1] https://github.com/felipec/finit [2] http://felipec.wordpress.com/2013/11/04/init/ -- Felipe Contreras -- To unsubscribe from this list: se

Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline

2014-05-06 Thread Felipe Contreras
to put a condom on > systemd's debug mode given how badly the assertion bug cascaded into > affecting non-systemd work. Unfortunately it seems your +1 (and everybody else's in that thread) didn't matter as the patch was not applied. -- Felipe Contreras -- To unsubscribe from this list: s

Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline

2014-05-06 Thread Felipe Contreras
bugs.freedesktop.org/show_bug.cgi?id=76935 -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH] cmdline: Hide debug from /proc/cmdline

2014-05-06 Thread Felipe Contreras
/show_bug.cgi?id=76935 -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH] cmdline: Hide debug from /proc/cmdline

2014-05-06 Thread Felipe Contreras
on systemd's debug mode given how badly the assertion bug cascaded into affecting non-systemd work. Unfortunately it seems your +1 (and everybody else's in that thread) didn't matter as the patch was not applied. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux

Re: [RFC PATCH] cmdline: Hide debug from /proc/cmdline

2014-05-06 Thread Felipe Contreras
of *readable* code, that shouldn't be a problem. I also wrote a blog post explaining the process that lad me to that code[2]. Cheers. [1] https://github.com/felipec/finit [2] http://felipec.wordpress.com/2013/11/04/init/ -- Felipe Contreras -- To unsubscribe from this list: send the line

RE: [ANNOUNCE] Git v2.0.0-rc0

2014-04-20 Thread Felipe Contreras
[1] http://article.gmane.org/gmane.comp.version-control.git/246558 -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please re

RE: [ANNOUNCE] Git v2.0.0-rc0

2014-04-20 Thread Felipe Contreras
://article.gmane.org/gmane.comp.version-control.git/246558 -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH v4 1/2] panic: setup panic_timeout early

2013-11-27 Thread Felipe Contreras
On Wed, Nov 27, 2013 at 9:47 AM, Jason Baron wrote: > On 11/27/2013 01:17 AM, Felipe Contreras wrote: >> Otherwise we might not reboot when the user needs it the most (early >> on). >> >> Signed-off-by: Felipe Contreras >> --- >> kernel/panic.c | 7 ++-

Re: [PATCH v4 1/2] panic: setup panic_timeout early

2013-11-27 Thread Felipe Contreras
On Wed, Nov 27, 2013 at 9:47 AM, Jason Baron jba...@akamai.com wrote: On 11/27/2013 01:17 AM, Felipe Contreras wrote: Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 7 ++- 1 file

[PATCH v4 0/2] Setup panic params early

2013-11-26 Thread Felipe Contreras
Exactly the same as v3, but with an unlrelated patch on top as well. Felipe Contreras (2): panic: setup panic_timeout early panic: setup panic_on_oops early kernel/panic.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 1.8.4.2+fc1 -- To unsubscribe from this list

[PATCH v4 2/2] panic: setup panic_on_oops early

2013-11-26 Thread Felipe Contreras
For consistency. Signed-off-by: Felipe Contreras --- kernel/panic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index 3456652..2256838 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -468,7 +468,11 @@ EXPORT_SYMBOL

[PATCH v4 1/2] panic: setup panic_timeout early

2013-11-26 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras --- kernel/panic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index b6c482c..3456652 100644 --- a/kernel/panic.c +++ b/kernel

Re: [PATCH v2] panic: Make panic_timeout configurable

2013-11-26 Thread Felipe Contreras
ly_param(). Is that sufficient for the >> (undescribed!) failure which you are presumably observing? > > Also note that that patch is still incomplete: if panic_timeout is > switched to early_param() then closely related functionality such as > pause_on_oops should be moved early

Re: [PATCH 0/3 v3] build in panic_timeout value

2013-11-26 Thread Felipe Contreras
d? > That fix patch had only one remaining bug/problem, last I checked: if > panic_timeout is turned into an early_param() then pause_on_oops > should obviously also be turned into an early param. That is not a "problem" with the patch itself, and it's the first time this

Re: [PATCH 0/3 v3] build in panic_timeout value

2013-11-26 Thread Felipe Contreras
/problem, last I checked: if panic_timeout is turned into an early_param() then pause_on_oops should obviously also be turned into an early param. That is not a problem with the patch itself, and it's the first time this problem has been mentioned at all. -- Felipe Contreras -- To unsubscribe from

Re: [PATCH v2] panic: Make panic_timeout configurable

2013-11-26 Thread Felipe Contreras
be moved early as well... If that was the case, then whomever made the oops param generic sent an incomplete patch because it's also early_param, and it's interesting why you didn't have that problem with that patch, but you do with this one. -- Felipe Contreras -- To unsubscribe from this list

[PATCH v4 2/2] panic: setup panic_on_oops early

2013-11-26 Thread Felipe Contreras
For consistency. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index 3456652..2256838 100644 --- a/kernel/panic.c +++ b/kernel/panic.c @@ -468,7 +468,11

[PATCH v4 1/2] panic: setup panic_timeout early

2013-11-26 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/panic.c b/kernel/panic.c index b6c482c..3456652 100644

[PATCH v4 0/2] Setup panic params early

2013-11-26 Thread Felipe Contreras
Exactly the same as v3, but with an unlrelated patch on top as well. Felipe Contreras (2): panic: setup panic_timeout early panic: setup panic_on_oops early kernel/panic.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 1.8.4.2+fc1 -- To unsubscribe from this list

Re: [PATCH 3/5] cmdline: declare exported symbols immediately

2013-11-16 Thread Felipe Contreras
On Sat, Nov 16, 2013 at 2:21 PM, Levente Kurusa wrote: > 2013-11-16 18:32 keltezéssel, Felipe Contreras írta: >> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable >> +EXPORT_SYMBOL(memparse); >> >> WARNING: EXPORT_SYMBOL(foo); should imme

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-16 Thread Felipe Contreras
On Sat, Nov 16, 2013 at 11:45 AM, Ingo Molnar wrote: > * Felipe Contreras wrote: > Anyway, the fact that you are argumentative even with Linus gives me > little hope that you will improve your communication patterns with > _me_, so I'm personally done arguing with you. Ho

[PATCH 4/5] kstrtox: remove redundant casts

2013-11-16 Thread Felipe Contreras
The temporary variable is of the same type as the cast, so it's redundant. Signed-off-by: Felipe Contreras --- lib/kstrtox.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/kstrtox.c b/lib/kstrtox.c index ec8da78..649b74b 100644 --- a/lib/kstrtox.c +++ b

[PATCH 2/5] cmdline: fix style issues

2013-11-16 Thread Felipe Contreras
at the start of a line + $ WARNING: space prohibited between function name and open parenthesis '(' + res = get_option ((char **), ints + i); Signed-off-by: Felipe Contreras --- lib/cmdline.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/cmdline.c b/lib

[PATCH 3/5] cmdline: declare exported symbols immediately

2013-11-16 Thread Felipe Contreras
+EXPORT_SYMBOL(get_options); Signed-off-by: Felipe Contreras --- lib/cmdline.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/cmdline.c b/lib/cmdline.c index 5466333..d4932f7 100644 --- a/lib/cmdline.c +++ b/lib/cmdline.c @@ -67,6 +67,7 @@ int get_option(char **str, int *pint

[PATCH 5/5] params: improve standard definitions

2013-11-16 Thread Felipe Contreras
We are repeating the functionality of kstrtol in param_set_long, and the same for kstrtoint. We can get rid of the extra code by using the right functions. Signed-off-by: Felipe Contreras --- kernel/params.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff

[PATCH 1/5] kstrtox: remove redundant cleanup

2013-11-16 Thread Felipe Contreras
We can't reach the cleanup code unless the flag KSTRTOX_OVERFLOW is not set, so there's not no point in clearing a bit that we know is not set. Signed-off-by: Felipe Contreras --- lib/kstrtox.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/kstrtox.c b/lib/kstrtox.c index f78ae0c

[PATCH 0/5] Command line related cleanups

2013-11-16 Thread Felipe Contreras
Hi, These became apparent in the review process of a new command line parameter. Felipe Contreras (5): kstrtox: remove redundant cleanup cmdline: fix style issues cmdline: declare exported symbols immediately kstrtox: remove redundant casts params: improve standard definitions kernel

[PATCH 1/5] kstrtox: remove redundant cleanup

2013-11-16 Thread Felipe Contreras
We can't reach the cleanup code unless the flag KSTRTOX_OVERFLOW is not set, so there's not no point in clearing a bit that we know is not set. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- lib/kstrtox.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/kstrtox.c b/lib

[PATCH 0/5] Command line related cleanups

2013-11-16 Thread Felipe Contreras
Hi, These became apparent in the review process of a new command line parameter. Felipe Contreras (5): kstrtox: remove redundant cleanup cmdline: fix style issues cmdline: declare exported symbols immediately kstrtox: remove redundant casts params: improve standard definitions kernel

[PATCH 3/5] cmdline: declare exported symbols immediately

2013-11-16 Thread Felipe Contreras
+EXPORT_SYMBOL(get_options); Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- lib/cmdline.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/cmdline.c b/lib/cmdline.c index 5466333..d4932f7 100644 --- a/lib/cmdline.c +++ b/lib/cmdline.c @@ -67,6 +67,7 @@ int

[PATCH 5/5] params: improve standard definitions

2013-11-16 Thread Felipe Contreras
We are repeating the functionality of kstrtol in param_set_long, and the same for kstrtoint. We can get rid of the extra code by using the right functions. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/params.c | 25 + 1 file changed, 9 insertions

[PATCH 4/5] kstrtox: remove redundant casts

2013-11-16 Thread Felipe Contreras
The temporary variable is of the same type as the cast, so it's redundant. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- lib/kstrtox.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/kstrtox.c b/lib/kstrtox.c index ec8da78..649b74b 100644

[PATCH 2/5] cmdline: fix style issues

2013-11-16 Thread Felipe Contreras
at the start of a line + $ WARNING: space prohibited between function name and open parenthesis '(' + res = get_option ((char **)str, ints + i); Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- lib/cmdline.c | 9 - 1 file changed, 4 insertions(+), 5 deletions

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-16 Thread Felipe Contreras
On Sat, Nov 16, 2013 at 11:45 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: Anyway, the fact that you are argumentative even with Linus gives me little hope that you will improve your communication patterns with _me_, so I'm personally done

Re: [PATCH 3/5] cmdline: declare exported symbols immediately

2013-11-16 Thread Felipe Contreras
On Sat, Nov 16, 2013 at 2:21 PM, Levente Kurusa le...@linux.com wrote: 2013-11-16 18:32 keltezéssel, Felipe Contreras írta: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable +EXPORT_SYMBOL(memparse); WARNING: EXPORT_SYMBOL(foo); should immediately follow its

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
On Fri, Nov 15, 2013 at 2:15 PM, Linus Torvalds wrote: > On Fri, Nov 15, 2013 at 12:10 PM, Felipe Contreras > wrote: >> >> I haven't seen a single complaint about this commit message, so I >> don't see what is your point. > > My point is that I have sixteen point

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
ply apply the patch I sent, even though *I* sent it, because it's technically correct, and the need is explained. Why wouldn't you? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majo

[PATCH v3] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras --- Since v2: There's no need for a temporary variable because kstrtoint() is already taking care of that (if there's an error panic_timeout is not updated). diff --git a/kernel/panic.c b

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
"childish". Anyway, I will update the patch to sue kstrtoint(), and I would gladly fix the existing code for issues 1) 2) and 3) *if* you or anybody agrees they should be using kstrtoint() as well, I'm not in the mood of going through Ingo's review process again for something so trivial. Chee

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
would gladly fix the existing code for issues 1) 2) and 3) *if* you or anybody agrees they should be using kstrtoint() as well, I'm not in the mood of going through Ingo's review process again for something so trivial. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line

[PATCH v3] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Since v2: There's no need for a temporary variable because kstrtoint() is already taking care of that (if there's an error panic_timeout is not updated

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
might as well simply apply the patch I sent, even though *I* sent it, because it's technically correct, and the need is explained. Why wouldn't you? -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-15 Thread Felipe Contreras
On Fri, Nov 15, 2013 at 2:15 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Nov 15, 2013 at 12:10 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I haven't seen a single complaint about this commit message, so I don't see what is your point. My point is that I have

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-14 Thread Felipe Contreras
Hi, Sending again since the previous one was rejected by the server. On Thu, Nov 14, 2013 at 3:25 PM, Felipe Contreras wrote: > Levente Kurusa wrote: >> 2013-11-14 12:16 keltezéssel, Felipe Contreras írta: >> > On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar wrote: >> >

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-14 Thread Felipe Contreras
On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> Otherwise we might not reboot when the user needs it the most (early >> on). >> >> Signed-off-by: Felipe Contreras >> --- >> > [...] >> >> d

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-14 Thread Felipe Contreras
On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- [...] diff --git a/kernel

Re: [PATCH v2] panic: setup panic_timeout early

2013-11-14 Thread Felipe Contreras
Hi, Sending again since the previous one was rejected by the server. On Thu, Nov 14, 2013 at 3:25 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Levente Kurusa wrote: 2013-11-14 12:16 keltezéssel, Felipe Contreras írta: On Tue, Nov 12, 2013 at 6:03 PM, Ingo Molnar mi...@kernel.org

Re: make oldnoconfig fix?

2013-11-11 Thread Felipe Contreras
config But it's very hacky and I see tons of errors reported, but it does what I expect. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
orms to standard practices, and solves a problem; it gets applied. Isn't that how it works in Linux? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

[PATCH v2] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras --- This time using kstrtol() instead of get_option(). Interdiff: diff --git a/kernel/panic.c b/kernel/panic.c index 46e37ff..d865263 100644 --- a/kernel/panic.c +++ b/kernel/panic.c

Re: [PATCH 1/3] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 8:22 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> On Mon, Nov 11, 2013 at 7:44 AM, Ingo Molnar wrote: >> > >> > * Felipe Contreras wrote: >> > >> >> Otherwise we might not reboot when the user need

Re: [PATCH 3/3] panic: enable local IRQs for restart timeout too

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:54 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar wrote: >> > >> > * Felipe Contreras wrote: >> > >> >> Signed-off-by: Felipe Contreras >> > >

Re: [PATCH 1/3] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:44 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> Otherwise we might not reboot when the user needs it the most (early >> on). >> >> Signed-off-by: Felipe Contreras >> --- >> kernel/panic.c | 14 +

[PATCH try2] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras --- This is exactly the same as in the previous try, but now alone since it was mudded by largely irrelevant patches in the series. kernel/panic.c | 14 +- 1 file changed, 13

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:28 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar wrote: >> > >> > * Felipe Contreras wrote: >> > >> >> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Mo

Re: [PATCH 3/3] panic: enable local IRQs for restart timeout too

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> Signed-off-by: Felipe Contreras > > The changelog is missing and the title is not self-explanatory. Either the local IRQs should be enabled for both the restart and halt blinks, or it

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: >> > >> > * Felipe Contreras wrote: >> > >> >> We want to calculate the blinks per second, and in

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar wrote: > > * Felipe Contreras wrote: > >> We want to calculate the blinks per second, and instead of making it 5 >> (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks >> per second. > > Please use

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: We want to calculate the blinks per second, and instead of making it 5 (1000 / (3600 / 18)), let's make it 4, so the user can see two blinks per second. Please use

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 5:32 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: We want to calculate the blinks per second

Re: [PATCH 3/3] panic: enable local IRQs for restart timeout too

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com The changelog is missing and the title is not self-explanatory. Either the local IRQs should be enabled

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:28 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 6:49 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 5:32 AM, Ingo

[PATCH try2] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- This is exactly the same as in the previous try, but now alone since it was mudded by largely irrelevant patches in the series. kernel/panic.c | 14

Re: [PATCH 1/3] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:44 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- kernel/panic.c | 14

Re: [PATCH 3/3] panic: enable local IRQs for restart timeout too

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 7:54 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 7:19 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: Signed-off-by: Felipe Contreras

Re: [PATCH 1/3] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
On Mon, Nov 11, 2013 at 8:22 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Nov 11, 2013 at 7:44 AM, Ingo Molnar mi...@kernel.org wrote: * Felipe Contreras felipe.contre...@gmail.com wrote: Otherwise we might not reboot when

[PATCH v2] panic: setup panic_timeout early

2013-11-11 Thread Felipe Contreras
Otherwise we might not reboot when the user needs it the most (early on). Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- This time using kstrtol() instead of get_option(). Interdiff: diff --git a/kernel/panic.c b/kernel/panic.c index 46e37ff..d865263 100644 --- a/kernel/panic.c

Re: [PATCH 2/3] panic: improve panic_timeout calculation

2013-11-11 Thread Felipe Contreras
applied. Isn't that how it works in Linux? -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: make oldnoconfig fix?

2013-11-11 Thread Felipe Contreras
: % echo '' | make oldconfig But it's very hacky and I see tons of errors reported, but it does what I expect. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 00/16] wl1251 patches from linux-n900 tree

2013-11-08 Thread Felipe Contreras
rg/linux-n900/linux-n900 How did you test these patches? I get a panic loop immediately after I bring the interface loop in monitor mode (v3.12). -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [PATCH 00/16] wl1251 patches from linux-n900 tree

2013-11-08 Thread Felipe Contreras
/linux-n900/linux-n900 How did you test these patches? I get a panic loop immediately after I bring the interface loop in monitor mode (v3.12). -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

  1   2   3   4   >