Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'

2019-08-18 Thread Gabriel FERNANDEZ
Acked-by: Gabriel Fernandez From: Stephen Boyd Sent: Friday, August 16, 2019 7:36 PM To: YueHaibing; alli...@lohutok.net; gre...@linuxfoundation.org; mturque...@baylibre.com; Gabriel FERNANDEZ Cc: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org

Re: [PATCH -next] clk: st: clkgen-fsyn: remove unused variable 'st_quadfs_fs660c32_ops'

2019-08-18 Thread Gabriel FERNANDEZ
Acked-by: Gabriel Fernandez From: Stephen Boyd Sent: Friday, August 16, 2019 7:36 PM To: YueHaibing; i...@metux.net; mturque...@baylibre.com; r...@kernel.org; Gabriel FERNANDEZ Cc: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; YueHaibing

[PATCH 1/2] clk: stm32: Introduce clocks of STM32F769 board

2019-04-05 Thread Gabriel Fernandez
STM32F769 clocks are derived from STM32746 clocks. main differences are: - new source clock for SAI1 and SAI2 (HSI or HSE) - Add DFSDM & DSI clocks Signed-off-by: Gabriel Fernandez --- .../bindings/clock/st,stm32-rcc.txt | 6 + drivers/clk/clk-stm32f4.c |

[PATCH 0/2] clk: stm32: STM32F769 clocks

2019-04-05 Thread Gabriel Fernandez
STM32F769 board is a derived of STM32F746 board. Concerning clocks, main differences are: - new source clock for SAI1 and SAI2 (HSI or HSE) - Add DFSDM & DSI clock Gabriel Fernandez (2): clk: stm32: Introduce clocks of STM32F769 board ARM: dts: stm32: Enable STM32F769 clock dr

[PATCH 2/2] ARM: dts: stm32: Enable STM32F769 clock driver

2019-04-05 Thread Gabriel Fernandez
This patch enables clocks for STM32F769 boards. Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stm32f769-disco.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/stm32f769-disco.dts b/arch/arm/boot/dts/stm32f769-disco.dts index 3c7216844a9b..6f1d0ac8c31c

Re: [PATCH] Input: st-keyscan - fix potential zalloc NULL dereference

2019-02-12 Thread Gabriel FERNANDEZ
Sorry ignore this patch (bad mailing list) Best Regard Gabriel On 2/12/19 4:24 PM, gabriel.fernan...@st.com wrote: > From: Gabriel Fernandez > > This patch fixes the following static checker warning: > > drivers/input/keyboard/st-keyscan.c:156 keyscan_probe() > error: pot

Re: [bug report] Input: add st-keyscan driver

2019-01-30 Thread Gabriel FERNANDEZ
e: >>> On Tue, Jan 22, 2019 at 1:53 PM Dan Carpenter >>> wrote: >>>> Hello Gabriel FERNANDEZ, >>> Hello Dan, >>> >>> I have added CCs for the maintainers as well as Gabriel Fernandez as >>> currently you just have the linux-input mail

Re: [PATCH] clk: stm32mp1: Add CLK_IGNORE_UNUSED to ck_sys_dbg clock

2018-05-15 Thread Gabriel FERNANDEZ
Thanks Stephen On 05/15/2018 08:23 PM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-04-24 00:58:43) >> From: Gabriel Fernandez >> >> Don't disable the dbg clock if was set by bootloader. >> >> Signed-off-by: Gabriel Fernandez >> --- > Applied to clk-next >

Re: clk: stm32mp1: Fix a memory leak in 'clk_stm32_register_gate_ops()'

2018-05-14 Thread Gabriel FERNANDEZ
Hi Christophe, Many thanks ! Acked-by: Gabriel Fernandez On 05/13/2018 01:17 PM, Christophe Jaillet wrote: > We allocate some memory which is neither used, nor referenced by anything. > So axe it. > > Signed-off-by: Christophe JAILLET > --- > This patch as not been compi

Re: [PATCH] clk: stm32mp1: Add CLK_IGNORE_UNUSED to ck_sys_dbg clock

2018-05-02 Thread Gabriel FERNANDEZ
Hi Stephen, This patch is not a critical fix for this merge window. Thanks Gabriel On 05/02/2018 12:10 AM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-04-24 00:58:43) >> From: Gabriel Fernandez >> >> Don't disable the dbg clock if was set by bootl

Re: [PATCH RESEND 2/2] clk: stm32: Add DSI clock for STM32F469 Board

2018-03-20 Thread Gabriel FERNANDEZ
Thanks Stephen ! Best Regards Gabriel On 03/19/2018 09:45 PM, Stephen Boyd wrote: > Quoting gabriel.fernan...@st.com (2018-03-08 22:57:31) >> From: Gabriel Fernandez >> >> This patch adds DSI clock for STM32F469 board >> >> Signed-off-by: Gabriel Fernandez >> --- > Applied to clk-next >

Re: [PATCH v3 1/2] dt-bindings: reset: add STM32MP1 resets

2018-03-19 Thread Gabriel FERNANDEZ
Many Thanks Philipp, Best Regards Gabriel On 03/19/2018 10:02 AM, Philipp Zabel wrote: > Hi Gabriel, > > On Mon, 2018-03-19 at 08:25 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch adds the reset binding entry for STM32MP1 &

Re: [PATCH v2 2/2] reset: stm32mp1: Enable stm32mp1 reset driver

2018-03-16 Thread Gabriel FERNANDEZ
Hi Philipp, Thanks for reviewing. On 03/16/2018 02:29 PM, Philipp Zabel wrote: > Hi Gabriel, > > this looks mostly good to me, a few questions and comments below: > > On Wed, 2018-03-14 at 17:30 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >>

Re: [PATCH 0/2] Introduce STM32MP1 Reset driver

2018-03-14 Thread Gabriel FERNANDEZ
Hi Philipp, Okay, i too support the idea to add custom  reset driver. Many Thanks Philipp. Best regards Gabriel On 03/14/2018 10:12 AM, Philipp Zabel wrote: > Hi Gabriel, > > On Tue, 2018-03-13 at 17:34 +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >&

Re: [PATCH v2 01/12] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

2018-03-12 Thread Gabriel FERNANDEZ
Thanks Rob ! Best Regards Gabriel On 03/10/2018 12:53 AM, Rob Herring wrote: > On Thu, Mar 08, 2018 at 05:53:54PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> The RCC block is responsible of the management of the clock and reset >>

Re: [PATCH v2 00/12] Introduce STM32MP1 clock driver

2018-03-12 Thread Gabriel FERNANDEZ
Many Thanks Mike ! Best Regards Gabriel. On 03/11/2018 11:42 PM, Michael Turquette wrote: > Excerpts from gabriel.fernan...@st.com's message of March 8, 2018 8:53 > am: >> From: Gabriel Fernandez >> >> v2: >>   - Don't use MFD, use existing binding of

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

2018-02-13 Thread Gabriel FERNANDEZ
On 02/07/2018 07:03 PM, Rob Herring wrote: > On Mon, Feb 5, 2018 at 1:01 AM, Gabriel FERNANDEZ > wrote: >> Hi Rob, >> >> Thanks for reviewing. >> >> >> On 02/05/2018 07:09 AM, Rob Herring wrote: >>> On Fri, Feb 02, 2018 at 03:03:29PM +0100,

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

2018-02-04 Thread Gabriel FERNANDEZ
On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:29PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> The RCC block is responsible of the management of the clock and reset >> generation for the complete circuit. &

Re: [PATCH 02/14] dt-bindings: clock: add STM32MP1 clocks

2018-02-04 Thread Gabriel FERNANDEZ
On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:30PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch adds the clock binding entry for STM32MP1 >> >> Signed-off-by: Gabriel Fernandez >> ---

Re: [PATCH 01/14] dt-bindings: Document STM32MP1 Reset Clock Controller (RCC) bindings

2018-02-04 Thread Gabriel FERNANDEZ
Hi Rob, Thanks for reviewing. On 02/05/2018 07:09 AM, Rob Herring wrote: > On Fri, Feb 02, 2018 at 03:03:29PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> The RCC block is responsible of the management of the clock and reset >> generati

Re: [PATCH 2/2] clk: stm32: Add DSI clock for STM32F469 Board

2018-01-30 Thread Gabriel FERNANDEZ
Hi Rob, Thanks for reviewing. On 01/29/2018 07:56 PM, Rob Herring wrote: > On Thu, Jan 18, 2018 at 03:49:40PM +0100, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch adds DSI clock for STM32F469 board >> >> Signed-off-by: Gabriel F

Re: [PATCH] clk: stm32: add configuration flags for each of the stm32 drivers

2018-01-16 Thread Gabriel FERNANDEZ
Hi Benjamin, Just remove the extra blanck line. Otherwise you can addmy Acked-by: Gabriel Fernandez Best regards Gabriel On 01/15/2018 03:21 PM, Benjamin Gaignard wrote: > Add two configuration flags to be able to not compile all the time > stm32f and stm32h7 drivers when ARCH_STM32

Re: [PATCH v2] clk: stm32-h7: fix copyright

2017-11-30 Thread Gabriel FERNANDEZ
Acked-by: Gabriel Fernandez On 11/30/2017 09:41 AM, Benjamin Gaignard wrote: > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > Acked-by: Alexandre TORGUE > CC: Gabriel Fernandez > --- > driver

Re: linux-4.14-rc1/drivers/clk/clk-stm32h7.c: 2 * possible typo ?

2017-09-19 Thread Gabriel FERNANDEZ
I missed David ... On 09/19/2017 11:22 AM, Gabriel FERNANDEZ wrote: > Hi David, > > I confirm it's typo issue. I 'm ready to send a fix for that. > > Many Thank's > > Gabriel > >> Hello there, >> >> 1. >> >> linux-4.14-rc1/dri

Re: linux-4.14-rc1/drivers/clk/clk-stm32h7.c: 2 * possible typo ?

2017-09-19 Thread Gabriel FERNANDEZ
Hi David, I confirm it's typo issue. I 'm ready to send a fix for that. Many Thank's Gabriel > Hello there, > > 1. > > linux-4.14-rc1/drivers/clk/clk-stm32h7.c:387]: (style) Same expression > on both sides of '&&'. > > Source code is > >     if (gcfg->mux && gcfg->mux) { > > 2. > > [linux-4.1

Re: [v3,3/5] reset: stm32: use the reset-simple driver

2017-08-29 Thread Gabriel FERNANDEZ
- return PTR_ERR(data->membase); > - > - spin_lock_init(&data->lock); > - > - data->rcdev.owner = THIS_MODULE; > - data->rcdev.nr_resets = resource_size(res) * 8; > - data->rcdev.ops = &stm32_reset_ops; > - data->rcdev.of_node = pdev->dev.of_node; > - > - return devm_reset_controller_register(&pdev->dev, &data->rcdev); > -} > - > -static struct platform_driver stm32_reset_driver = { > - .probe = stm32_reset_probe, > - .driver = { > - .name = "stm32-rcc-reset", > - .of_match_table = stm32_reset_dt_ids, > - }, > -}; > -builtin_platform_driver(stm32_reset_driver); Acked-by: Gabriel Fernandez

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

2017-07-22 Thread Gabriel FERNANDEZ
On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch enables clocks for STM32H743 boards. >> >> Signed-off-by: Gabriel Fernandez >&g

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

2017-07-22 Thread Gabriel FERNANDEZ
On 07/21/2017 10:37 PM, Stephen Boyd wrote: > On 07/20, Vladimir Zapolskiy wrote: >> Hi Gabriel, >> >> On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: >>> Hi Vladimir, >>> >>> >>> On 07/19/2017 11:20 PM, Vladimir Zapolskiy wr

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

2017-07-20 Thread Gabriel FERNANDEZ
Hi Vladimir, On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch enables clocks for STM32H743 boards. >> >> Signed-off-by: Gabriel Fernan

Re: [PATCH v6 3/3] clk: stm32h7: Add stm32h743 clock driver

2017-07-19 Thread Gabriel FERNANDEZ
Hi Vladimi, Many thanks for the code review On 07/18/2017 10:19 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch enables clocks for STM32H743 boards. >> &g

Re: [PATCH v6 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

2017-07-19 Thread Gabriel FERNANDEZ
Hi Vladimir, Many thanks for the code review. On 07/18/2017 09:48 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/18/2017 10:53 AM, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> We need to export clk_gate_is_enabled() from clk framework

Re: [PATCH v5 1/2] clk: gate: expose clk_gate_ops::is_enabled

2017-07-17 Thread Gabriel FERNANDEZ
t; > url: > https://github.com/0day-ci/linux/commits/gabriel-fernandez-st-com/clk-stm32h7-Add-stm32h743-clock-driver/20170714-170518 > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: arm-lpc32xx_defconfig (attached as .config) > compiler: a

Re: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver

2017-07-05 Thread Gabriel FERNANDEZ
On 06/30/2017 08:54 PM, Stephen Boyd wrote: > On 06/30, Gabriel FERNANDEZ wrote: >> >> On 06/30/2017 02:20 AM, Stephen Boyd wrote: >>> On 06/29, Gabriel FERNANDEZ wrote: >>>> On 06/28/2017 05:59 PM, Stephen Boyd wrote: >>>>> On 06/27, Gab

Re: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver

2017-06-30 Thread Gabriel FERNANDEZ
On 06/30/2017 02:20 AM, Stephen Boyd wrote: > On 06/29, Gabriel FERNANDEZ wrote: >> >> On 06/28/2017 05:59 PM, Stephen Boyd wrote: >>> On 06/27, Gabriel FERNANDEZ wrote: >>>> On 06/22/2017 12:07 AM, Stephen Boyd wrote: >>>>> readl_poll_timeou

Re: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver

2017-06-29 Thread Gabriel FERNANDEZ
On 06/28/2017 05:59 PM, Stephen Boyd wrote: > On 06/27, Gabriel FERNANDEZ wrote: >> >> On 06/22/2017 12:07 AM, Stephen Boyd wrote: >>> readl_poll_timeout? >>> >> if i use readl_poll_timeout (wich use 'ktime_get()') it can be >&

Re: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver

2017-06-27 Thread Gabriel FERNANDEZ
On 06/22/2017 12:07 AM, Stephen Boyd wrote: > On 06/07, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch enables clocks for STM32H743 boards. >> >> Signed-off-by: Gabriel Fernandez >> >> for MFD changes: >> Acked-by

Re: [RESEND PATCH v4] clk: stm32h7: Add stm32h743 clock driver

2017-06-22 Thread Gabriel FERNANDEZ
Hi Stephen, Thanks for reviewing. On 06/22/2017 12:07 AM, Stephen Boyd wrote: > On 06/07, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch enables clocks for STM32H743 boards. >> >> Signed-off-by: Gabriel Fernandez >> >

Re: [PATCH] clk: stm32h7: Add stm32h743 clock driver

2017-04-28 Thread Gabriel Fernandez
Hi Stephen Sorry for delay i was on sick live On 04/07/2017 09:51 PM, Stephen Boyd wrote: On 04/06, Gabriel Fernandez wrote: On 04/06/2017 12:32 AM, Stephen Boyd wrote: On 03/15, gabriel.fernan...@st.com wrote: diff --git a/Documentation/devicetree/bindings/clock/st,stm32h7-rcc.txt b

Re: [PATCH] clk: stm32h7: Add stm32h743 clock driver

2017-04-06 Thread Gabriel Fernandez
Hi Stephen, On 04/06/2017 12:32 AM, Stephen Boyd wrote: On 03/15, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch enables clocks for STM32H743 boards. Like what clocks exactly? All of them? Yes all of them, it's new IP diff --git a/Documentation/devicetree/bin

Re: [PATCH v2] clk: stm32h7: Add stm32h743 clock driver

2017-04-03 Thread Gabriel Fernandez
On 04/03/2017 06:04 PM, Rob Herring wrote: On Mon, Apr 3, 2017 at 9:39 AM, Rob Herring wrote: On Wed, Mar 29, 2017 at 11:08:22AM +0200, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch enables clocks for STM32H743 boards. Signed-off-by: Gabriel Fernandez Just for the

Re: [PATCH] clk: stm32h7: Add stm32h743 clock driver

2017-03-27 Thread Gabriel Fernandez
On 03/27/2017 09:04 PM, Rob Herring wrote: On Fri, Mar 24, 2017 at 4:41 AM, Gabriel Fernandez wrote: Hi Rob, Thanks for reviewing On 03/24/2017 03:06 AM, Rob Herring wrote: On Wed, Mar 15, 2017 at 10:23:30AM +0100, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch

Re: [PATCH] clk: stm32h7: Add stm32h743 clock driver

2017-03-24 Thread Gabriel Fernandez
Hi Rob, Thanks for reviewing On 03/24/2017 03:06 AM, Rob Herring wrote: On Wed, Mar 15, 2017 at 10:23:30AM +0100, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch enables clocks for STM32H743 boards. Signed-off-by: Gabriel Fernandez --- .../devicetree/bindings/clock

Re: [PATCH 0/2] STM32F4 clock fixes

2017-03-16 Thread Gabriel Fernandez
Hi Stephen, On 03/15/2017 09:43 PM, Stephen Boyd wrote: On 03/15, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch-set contains 2 fixes. One concerning exclusion of wrong values for PLLQ (0 & 1) And the second is a fix about timeout management of PLL and LSE/LSI cl

Re: [Resend PATCH v2 2/3] dt-bindings: mfd: stm32f4: Add missing binding definition

2017-02-01 Thread Gabriel Fernandez
Hi Lee, On 02/01/2017 02:31 PM, Lee Jones wrote: On Wed, 01 Feb 2017, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch adds missing binding definition (backupram, ethernet, otg, qspi, adc & dsi) What is RCC? Reset & Clock Control Signed-off-by: Gabriel F

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-11 Thread Gabriel Fernandez
ng. Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock") Signed-off-by: Arnd Bergmann --- drivers/clk/clk-stm32f4.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Acked-by: Gabriel Fernandez

Re: [PATCH v2 4/9] clk: stm32f4: Add lcd-tft clock

2016-12-01 Thread Gabriel Fernandez
Hi Rob, Thanks for reviewing On 11/30/2016 09:53 PM, Rob Herring wrote: On Thu, Nov 24, 2016 at 03:45:44PM +0100, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch introduces lcd-tft clock for stm32f4 soc. Signed-off-by: Gabriel Fernandez --- .../devicetree/bindings

Re: [PATCH 1/6] clk: stm32f4: Add PLL_I2S & PLL_SAI for STM32F429/469 boards

2016-11-09 Thread Gabriel Fernandez
On 11/09/2016 09:10 AM, Radosław Pietrzyk wrote: I would expect that VCO clock will force recalculation for all its children if I am not mistaken. Sure BR Gabriel. 2016-11-08 17:19 GMT+01:00 Gabriel Fernandez : On 11/08/2016 09:52 AM, Radosław Pietrzyk wrote: 2016-11-08 9:35 GMT+01:00

Re: [PATCH 4/6] clk: stm32f4: Add I2S clock

2016-11-08 Thread Gabriel Fernandez
On 11/07/2016 03:14 PM, Daniel Thompson wrote: On 07/11/16 13:05, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch introduces I2S clock for stm32f4 soc. The I2S clock could be derived from an external clock or from pll-i2s Signed-off-by: Gabriel Fernandez --- drivers

Re: [PATCH 1/6] clk: stm32f4: Add PLL_I2S & PLL_SAI for STM32F429/469 boards

2016-11-08 Thread Gabriel Fernandez
On 11/08/2016 09:52 AM, Radosław Pietrzyk wrote: 2016-11-08 9:35 GMT+01:00 Gabriel Fernandez : Hi Radosław Many thanks for reviewing. On 11/07/2016 03:57 PM, Radosław Pietrzyk wrote: +static struct clk_hw *clk_register_pll_div(const char *name, + const char *parent_name

Re: [PATCH 1/6] clk: stm32f4: Add PLL_I2S & PLL_SAI for STM32F429/469 boards

2016-11-08 Thread Gabriel Fernandez
Hi Radosław Many thanks for reviewing. On 11/07/2016 03:57 PM, Radosław Pietrzyk wrote: +static struct clk_hw *clk_register_pll_div(const char *name, + const char *parent_name, unsigned long flags, + void __iomem *reg, u8 shift, u8 width, + u8 clk_divid

Re: [PATCH 3/6] clk: stm32f4: Add post divisor for I2S & SAI PLLs and Add lcd-tft clock

2016-11-07 Thread Gabriel Fernandez
Hi Daniel, On 11/07/2016 02:58 PM, Daniel Thompson wrote: On 07/11/16 13:05, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch adds post dividers of I2S & SAI PLLs. These dividers are managed by a dedicated register (RCC_DCKCFGR). The PLL should be off before a set

Re: [PATCH 2/6] clk: stm32f4: SDIO & 48Mhz clock management for STM32F469 board

2016-11-07 Thread Gabriel Fernandez
Hi Daniel, On 11/07/2016 02:55 PM, Daniel Thompson wrote: On 07/11/16 13:05, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez In the stm32f469 soc, the 48Mhz clock could be derived from pll-q or from pll-sai-p. The SDIO clock could be also derived from 48Mhz or from sys clock

Re: [PATCH 1/6] clk: stm32f4: Add PLL_I2S & PLL_SAI for STM32F429/469 boards

2016-11-07 Thread Gabriel Fernandez
Hi Daniel, Thanks for reviewing. On 11/07/2016 02:53 PM, Daniel Thompson wrote: On 07/11/16 13:05, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch introduces PLL_I2S and PLL_SAI. Vco clock of these PLLs can be modify by DT (only n multiplicator, m divider is still fixed

Re: [PATCH 1/2] ARM: dts: stm32f429: add LSI and LSE clocks

2016-11-04 Thread Gabriel Fernandez
Hi Alexandre, On 11/04/2016 11:15 AM, Alexandre Torgue wrote: Gabriel, On 11/04/2016 09:52 AM, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch adds lsi / lse oscillators. These clocks can be use by RTC clocks. The clock drivers needs to disable the power domain write

Re: [PATCH v2 0/6] STM32F4 Add RTC & QSPI clocks

2016-11-03 Thread Gabriel Fernandez
Hi Alexandre, On 11/03/2016 09:52 AM, Alexandre Torgue wrote: Hi Gabriel, On 10/14/2016 11:18 AM, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez v2: - rename compatible property "st,stm32f46xx-rcc" into "st,stm32f469-rcc" - cosmetic: remove bad copy/p

Re: [PATCH v2 1/6] clk: stm32f4: Add LSI & LSE clocks

2016-10-20 Thread Gabriel Fernandez
Hi Stephen, On 10/19/2016 10:24 PM, Stephen Boyd wrote: On 10/14, gabriel.fernan...@st.com wrote: @@ -292,8 +298,110 @@ static int stm32f4_rcc_lookup_clk_idx(u8 primary, u8 secondary) return clks[i]; } +static struct regmap *pdrm; This can't be part of the stm32_rgate structure?

Re: [PATCH v2 5/6] clk: stm32f469: Add QSPI clock

2016-10-20 Thread Gabriel Fernandez
Hi Stephen On 10/19/2016 10:32 PM, Stephen Boyd wrote: On 10/14, gabriel.fernan...@st.com wrote: @@ -532,10 +618,42 @@ static struct clk_hw *stm32_register_cclk(struct device *dev, const char *name, { 0 }, }; +struct stm32f4_clk_data { + const struct stm32f4_gate_data *gat

Re: [PATCH v2 4/6] clk: stm32f4: Add RTC clock

2016-10-20 Thread Gabriel Fernandez
Hi Stephen, On 10/19/2016 10:45 PM, Stephen Boyd wrote: On 10/14, gabriel.fernan...@st.com wrote: @@ -310,6 +310,15 @@ static inline void enable_power_domain_write_protection(void) regmap_update_bits(pdrm, 0x00, (1 << 8), (0 << 8)); } +static inline void sofware_reset_backup_doma

Re: [PATCH v2 0/6] STM32F4 Add RTC & QSPI clocks

2016-10-20 Thread Gabriel Fernandez
Hi Stephen, On 10/19/2016 10:29 PM, Stephen Boyd wrote: On 10/19, Gabriel Fernandez wrote: Hi Stephen, On 10/19/2016 01:51 AM, Stephen Boyd wrote: On 10/14, gabriel.fernan...@st.com wrote: Gabriel Fernandez (6): clk: stm32f4: Add LSI & LSE clocks ARM: dts: stm32f429: add LSI and

Re: [PATCH v2 4/6] clk: stm32f4: Add RTC clock

2016-10-20 Thread Gabriel Fernandez
Hi Stephen, Thanks for reviewing. Ok for all yours remarks On 10/19/2016 10:45 PM, Stephen Boyd wrote: On 10/14, gabriel.fernan...@st.com wrote: @@ -310,6 +310,15 @@ static inline void enable_power_domain_write_protection(void) regmap_update_bits(pdrm, 0x00, (1 << 8), (0 << 8)); }

Re: [PATCH v2 1/6] clk: stm32f4: Add LSI & LSE clocks

2016-10-20 Thread Gabriel Fernandez
Hi Stephen, Many thanks for reviewing. On 10/19/2016 10:24 PM, Stephen Boyd wrote: On 10/14, gabriel.fernan...@st.com wrote: @@ -292,8 +298,110 @@ static int stm32f4_rcc_lookup_clk_idx(u8 primary, u8 secondary) return clks[i]; } +static struct regmap *pdrm; This can't be part of

Re: [PATCH v2 0/6] STM32F4 Add RTC & QSPI clocks

2016-10-19 Thread Gabriel Fernandez
Hi Stephen, On 10/19/2016 01:51 AM, Stephen Boyd wrote: On 10/14, gabriel.fernan...@st.com wrote: Gabriel Fernandez (6): clk: stm32f4: Add LSI & LSE clocks ARM: dts: stm32f429: add LSI and LSE clocks arm: stmf32: Enable SYSCON clk: stm32f4: Add RTC clock clk: stm32f469:

Re: [PATCH 5/6] clk: stm32f469: Add QSPI clock

2016-10-11 Thread Gabriel Fernandez
Hi Rob, Thanks for reviewing On 10/08/2016 10:50 PM, Rob Herring wrote: On Fri, Sep 30, 2016 at 04:25:08PM +0200, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez This patch adds the QSPI clock for stm32f469 discovery board. The gate mapping is a little bit different from stm32f429

Re: [PATCH] Reorganize STM32 clocks in order to prepare them for PLLI2S and PLLSAI

2016-10-10 Thread Gabriel Fernandez
Hi Radosław, Yes i m nearly ready to push a patch-set to manage LCD-TFT clock. In my patch-set i introduced PLLI2S and PLLSAI in generic way, and offer the possibility to change the vco frequency (in order to cover all frequencies for any LCD). And then, the vco is no longer a fixed factor.

Re: [PATCH v3 00/14] Clock improvement for video playback

2016-09-15 Thread Gabriel Fernandez
On 09/14/2016 08:36 PM, Stephen Boyd wrote: On 08/29, gabriel.fernan...@st.com wrote: From: Gabriel Fernandez v3: - Rebase to v4.8-rc1 - Tipo fix in st,clkgen-pll.txt - Add Ack of Peter for the series - Add missed patch: "ARM: DT: STiH4xx: Simplify clock binding of ST

Re: [RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms

2016-08-25 Thread Gabriel Fernandez
On 08/25/2016 02:11 AM, Michael Turquette wrote: Quoting Gabriel Fernandez (2016-08-22 09:06:20) Hi Mike, you forgot me ? Best Regards Gabriel On 07/11/2016 08:58 AM, Gabriel Fernandez wrote: On 07/08/2016 06:08 PM, Michael Turquette wrote: Quoting Gabriel Fernandez (2016-07-08 02:12

Re: [RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms

2016-08-22 Thread Gabriel Fernandez
Hi Mike, you forgot me ? Best Regards Gabriel On 07/11/2016 08:58 AM, Gabriel Fernandez wrote: On 07/08/2016 06:08 PM, Michael Turquette wrote: Quoting Gabriel Fernandez (2016-07-08 02:12:35) Hi Mike, On 07/08/2016 03:43 AM, Michael Turquette wrote: Quoting Rob Herring (2016-06-19 08

Re: [PATCH v2 3/4] drivers: reset: Add STM32 reset driver

2016-07-22 Thread Gabriel Fernandez
: Maxime Coquelin Signed-off-by: Gabriel Fernandez --- drivers/reset/Makefile | 1 + drivers/reset/reset-stm32.c | 113 2 files changed, 114 insertions(+) create mode 100644 drivers/reset/reset-stm32.c diff --git a/drivers/reset/Makefile b

Re: [RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms

2016-07-11 Thread Gabriel Fernandez
On 07/08/2016 06:08 PM, Michael Turquette wrote: Quoting Gabriel Fernandez (2016-07-08 02:12:35) Hi Mike, On 07/08/2016 03:43 AM, Michael Turquette wrote: Quoting Rob Herring (2016-06-19 08:04:58) On Thu, Jun 16, 2016 at 11:20:22AM +0200, Gabriel Fernandez wrote: This patch reworks the

Re: [RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms

2016-07-08 Thread Gabriel Fernandez
Hi Mike, On 07/08/2016 03:43 AM, Michael Turquette wrote: Quoting Rob Herring (2016-06-19 08:04:58) On Thu, Jun 16, 2016 at 11:20:22AM +0200, Gabriel Fernandez wrote: This patch reworks the clock binding to avoid too much detail in DT. Now we have only compatible string per type of clock

Re: [PATCH 3/4] drivers: reset: Add STM32 reset driver

2016-07-06 Thread Gabriel Fernandez
Hi Philipp On 07/05/2016 03:29 PM, Philipp Zabel wrote: Am Dienstag, den 05.07.2016, 09:29 +0200 schrieb Gabriel Fernandez: [...] +static const struct reset_control_ops stm32_reset_ops = { + .assert = stm32_reset_assert, + .deassert = stm32_reset_deassert, Are the

Re: [PATCH 3/4] drivers: reset: Add STM32 reset driver

2016-07-06 Thread Gabriel Fernandez
Hi Philipp, On 07/05/2016 03:28 PM, Philipp Zabel wrote: Am Montag, den 04.07.2016, 15:47 +0200 schrieb gabriel.fernan...@st.com: From: Gabriel Fernandez The STM32 MCUs family IPs can be reset by accessing some registers from the RCC block. The list of available reset lines is documented in

Re: [PATCH 2/4] dt-bindings: Document the STM32 reset bindings

2016-07-06 Thread Gabriel Fernandez
Hi Rob, Thanks for reviewing On 07/05/2016 06:18 PM, Rob Herring wrote: On Mon, Jul 04, 2016 at 03:47:30PM +0200, gabriel.fernan...@st.com wrote: From: Maxime Coquelin This adds documentation of device tree bindings for the STM32 reset controller. Signed-off-by: Maxime Coquelin --- .../d

Re: [PATCH 2/4] dt-bindings: Document the STM32 reset bindings

2016-07-05 Thread Gabriel Fernandez
Hi Philipp, On 07/04/2016 07:36 PM, Philipp Zabel wrote: Am Montag, den 04.07.2016, 15:47 +0200 schrieb gabriel.fernan...@st.com: From: Maxime Coquelin This adds documentation of device tree bindings for the STM32 reset controller. Signed-off-by: Maxime Coquelin The way I understand Docume

Re: [PATCH 3/4] drivers: reset: Add STM32 reset driver

2016-07-05 Thread Gabriel Fernandez
Hi Philipp, Thanks for reviewing. On 07/04/2016 07:36 PM, Philipp Zabel wrote: Hi Gabriel, Am Montag, den 04.07.2016, 15:47 +0200 schrieb gabriel.fernan...@st.com: From: Gabriel Fernandez Isn't Maxime the author of this driver? Yes i upstream with his agreement. I only made

Re: [RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms

2016-06-20 Thread Gabriel Fernandez
Hi Rob, On 19 June 2016 at 17:04, Rob Herring wrote: > On Thu, Jun 16, 2016 at 11:20:22AM +0200, Gabriel Fernandez wrote: >> This patch reworks the clock binding to avoid too much detail in DT. >> Now we have only compatible string per type of clock >> (remark from Rob https

[RESEND PATCH v2 04/13] drivers: clk: st: Add clock propagation for audio clocks

2016-06-16 Thread Gabriel Fernandez
This patch allows fine tuning of the quads FS for audio clocks accuracy. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- .../devicetree/bindings/clock/st/st,flexgen.txt| 2 ++ drivers/clk/st/clk-flexgen.c | 24 ++ 2 files

[RESEND PATCH v2 01/13] drivers: clk: st: Remove stih415-416 clock support

2016-06-16 Thread Gabriel Fernandez
STiH415 and STiH416 platforms are no longer used. these platforms will be deprecated for the next kernel. Signed-off-by: Gabriel Fernandez --- .../bindings/clock/st/st,clkgen-divmux.txt | 49 -- .../devicetree/bindings/clock/st/st,clkgen-mux.txt | 18 +- .../devicetree/bindings/clock

[RESEND PATCH v2 03/13] drivers: clk: st: Add fs660c32 synthesizer algorithm

2016-06-16 Thread Gabriel Fernandez
Use an algorithm instead of a table to compute clocks for fs660c32 synthesizer. During a video playback we need to adjust audio & video frequencies. A table can't cover all HDMI resolutions and audio adjustment. Signed-off-by: Gabriel Fernandez --- drivers/clk/st/clkgen-fsy

[RESEND PATCH v2 07/13] ARM: DT: STiH410: Enable clock propagation for audio clocks

2016-06-16 Thread Gabriel Fernandez
This patch is used in the clock driver to apply a clock propagation flag on the audio clocks of STiH410 Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih410-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[RESEND PATCH v2 06/13] ARM: DT: STiH407: Enable clock propagation for audio clocks

2016-06-16 Thread Gabriel Fernandez
This patch is used in the clock driver to apply a clock propagation flag on the audio clocks of STiH407 Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih407-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[RESEND PATCH v2 11/13] ARM: DT: STiH418: Enable synchronous clock mode for video clocks

2016-06-16 Thread Gabriel Fernandez
This patch enables the synchronous clock mode for video clocks on STiH418 board. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih418-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stih418-clock.dtsi b

[RESEND PATCH v2 08/13] ARM: DT: STiH418: Enable clock propagation for audio clocks

2016-06-16 Thread Gabriel Fernandez
This patch is used in the clock driver to apply a clock propagation flag on the audio clocks of STiH418 Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih418-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[RESEND PATCH v2 12/13] ARM: DT: STi: STiH407: clock configuration to address 720p and 1080p

2016-06-16 Thread Gabriel Fernandez
It is necessary to properly configure these clocks in order to address 720p and 1080p HDMI resolution. Signed-off-by: Vincent Abriou Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih407.dtsi | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch

[RESEND PATCH v2 13/13] ARM: DT: STi: STiH410: clock configuration to address 720p and 1080p

2016-06-16 Thread Gabriel Fernandez
It is necessary to properly configure these clocks in order to address 720p and 1080p HDMI resolution. Signed-off-by: Vincent Abriou Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih410.dtsi | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch

[RESEND PATCH v2 09/13] ARM: DT: STiH407: Enable synchronous clock mode for video clocks

2016-06-16 Thread Gabriel Fernandez
This patch enables the synchronous clock mode for video clocks on STiH407 board. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih407-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b

[RESEND PATCH v2 10/13] ARM: DT: STiH410: Enable synchronous clock mode for video clocks

2016-06-16 Thread Gabriel Fernandez
This patch enables the synchronous clock mode for video clocks on STiH410 board. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih410-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b

[RESEND PATCH v2 00/13] Clock improvement for video playback

2016-06-16 Thread Gabriel Fernandez
video resolutions and make audio adjustment during a video playback. Gabriel Fernandez (13): drivers: clk: st: Remove stih415-416 clock support drivers: clk: st: Simplify clock binding of STiH4xx platforms drivers: clk: st: Add fs660c32 synthesizer algorithm drivers: clk: st: Add clock

[RESEND PATCH v2 05/13] drivers: clk: st: Handle clk synchronous mode for video clocks

2016-06-16 Thread Gabriel Fernandez
This patch configures the semi-synchronous mode of the video clocks of clkgenD2. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- .../devicetree/bindings/clock/st/st,flexgen.txt| 2 ++ drivers/clk/st/clk-flexgen.c | 37 -- 2

[RESEND PATCH v2 02/13] drivers: clk: st: Simplify clock binding of STiH4xx platforms

2016-06-16 Thread Gabriel Fernandez
This patch reworks the clock binding to avoid too much detail in DT. Now we have only compatible string per type of clock (remark from Rob https://lkml.org/lkml/2016/5/25/492) Signed-off-by: Gabriel Fernandez --- .../devicetree/bindings/clock/st/st,clkgen-mux.txt | 2 +- .../devicetree

[PATCH v2 06/13] ARM: DT: STiH407: Enable clock propagation for audio clocks

2016-06-06 Thread Gabriel Fernandez
This patch is used in the clock driver to apply a clock propagation flag on the audio clocks of STiH407 Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih407-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[PATCH v2 03/13] drivers: clk: st: Add fs660c32 synthesizer algorithm

2016-06-06 Thread Gabriel Fernandez
Use an algorithm instead of a table to compute clocks for fs660c32 synthesizer. During a video playback we need to adjust audio & video frequencies. A table can't cover all HDMI resolutions and audio adjustment. Signed-off-by: Gabriel Fernandez --- drivers/clk/st/clkgen-fsy

[PATCH v2 08/13] ARM: DT: STiH418: Enable clock propagation for audio clocks

2016-06-06 Thread Gabriel Fernandez
This patch is used in the clock driver to apply a clock propagation flag on the audio clocks of STiH418 Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih418-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[PATCH v2 04/13] drivers: clk: st: Add clock propagation for audio clocks

2016-06-06 Thread Gabriel Fernandez
This patch allows fine tuning of the quads FS for audio clocks accuracy. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- .../devicetree/bindings/clock/st/st,flexgen.txt| 2 ++ drivers/clk/st/clk-flexgen.c | 24 ++ 2 files

[PATCH v2 12/13] ARM: DT: STi: STiH407: clock configuration to address 720p and 1080p

2016-06-06 Thread Gabriel Fernandez
It is necessary to properly configure these clocks in order to address 720p and 1080p HDMI resolution. Signed-off-by: Vincent Abriou Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih407.dtsi | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch

[PATCH v2 10/13] ARM: DT: STiH410: Enable synchronous clock mode for video clocks

2016-06-06 Thread Gabriel Fernandez
This patch enables the synchronous clock mode for video clocks on STiH410 board. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih410-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stih410-clock.dtsi b

[PATCH v2 07/13] ARM: DT: STiH410: Enable clock propagation for audio clocks

2016-06-06 Thread Gabriel Fernandez
This patch is used in the clock driver to apply a clock propagation flag on the audio clocks of STiH410 Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih410-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts

[PATCH v2 09/13] ARM: DT: STiH407: Enable synchronous clock mode for video clocks

2016-06-06 Thread Gabriel Fernandez
This patch enables the synchronous clock mode for video clocks on STiH407 board. Signed-off-by: Olivier Bideau Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih407-clock.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stih407-clock.dtsi b

[PATCH v2 13/13] ARM: DT: STi: STiH410: clock configuration to address 720p and 1080p

2016-06-06 Thread Gabriel Fernandez
It is necessary to properly configure these clocks in order to address 720p and 1080p HDMI resolution. Signed-off-by: Vincent Abriou Signed-off-by: Gabriel Fernandez --- arch/arm/boot/dts/stih410.dtsi | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/arch

[PATCH v2 01/13] drivers: clk: st: Remove stih415-416 clock support

2016-06-06 Thread Gabriel Fernandez
STiH415 and STiH416 platforms are no longer used. these platforms will be deprecated for the next kernel. Signed-off-by: Gabriel Fernandez --- .../bindings/clock/st/st,clkgen-divmux.txt | 49 -- .../devicetree/bindings/clock/st/st,clkgen-mux.txt | 18 +- .../devicetree/bindings/clock

  1   2   3   4   5   >