Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/16/2018 3:22 PM, Håkon Bugge wrote: > But, do we need an update to IBTA (that the BTH.PKey shall be that of the > VM's Port)? Nothing in spec mentions shared (port) virtualization so that is an exercise completely left to the reader... Annex A19 is silent on this specific point but the

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/16/2018 3:22 PM, Håkon Bugge wrote: > But, do we need an update to IBTA (that the BTH.PKey shall be that of the > VM's Port)? Nothing in spec mentions shared (port) virtualization so that is an exercise completely left to the reader... Annex A19 is silent on this specific point but the

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/16/2018 11:12 AM, Jason Gunthorpe wrote: > On Wed, May 16, 2018 at 08:47:21AM +0200, Håkon Bugge wrote: > >>> This is not a difficult issue. >>> >>> If the GMP is properly tagged with the right PKey then it will never >>> be delivered to the VM if the VM does not have the PKey in the >>>

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/16/2018 11:12 AM, Jason Gunthorpe wrote: > On Wed, May 16, 2018 at 08:47:21AM +0200, Håkon Bugge wrote: > >>> This is not a difficult issue. >>> >>> If the GMP is properly tagged with the right PKey then it will never >>> be delivered to the VM if the VM does not have the PKey in the >>>

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/14/2018 5:02 PM, Jason Gunthorpe wrote: > On Thu, May 10, 2018 at 05:16:28PM +0200, Håkon Bugge wrote: > >> We are talking about two things here. The PKey in the BTH and the >> PKey in the CM REQ payload. They differ. >> >> I am out of office, but if my memory serves me correct, the PKey in

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/14/2018 5:02 PM, Jason Gunthorpe wrote: > On Thu, May 10, 2018 at 05:16:28PM +0200, Håkon Bugge wrote: > >> We are talking about two things here. The PKey in the BTH and the >> PKey in the CM REQ payload. They differ. >> >> I am out of office, but if my memory serves me correct, the PKey in

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/11/2018 6:55 AM, Håkon Bugge wrote: > > >> On 10 May 2018, at 18:54, Hal Rosenstock <h...@dev.mellanox.co.il> wrote: >> >> On 5/10/2018 11:16 AM, Håkon Bugge wrote: >>> >>> >>>> On 10 May 2018, at 16:01, Hal Rosenstock <h...@d

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/11/2018 6:55 AM, Håkon Bugge wrote: > > >> On 10 May 2018, at 18:54, Hal Rosenstock wrote: >> >> On 5/10/2018 11:16 AM, Håkon Bugge wrote: >>> >>> >>>> On 10 May 2018, at 16:01, Hal Rosenstock wrote: >>>> >>>

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/10/2018 11:16 AM, Håkon Bugge wrote: > > >> On 10 May 2018, at 16:01, Hal Rosenstock <h...@dev.mellanox.co.il> wrote: >> >> On 5/10/2018 5:16 AM, Håkon Bugge wrote: >>> >>> >>>> On 9 May 2018, at 13:28, Hal Rosenstock <h...@

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/10/2018 11:16 AM, Håkon Bugge wrote: > > >> On 10 May 2018, at 16:01, Hal Rosenstock wrote: >> >> On 5/10/2018 5:16 AM, Håkon Bugge wrote: >>> >>> >>>> On 9 May 2018, at 13:28, Hal Rosenstock wrote: >>>> >>>> On

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/10/2018 5:16 AM, Håkon Bugge wrote: > > >> On 9 May 2018, at 13:28, Hal Rosenstock <h...@dev.mellanox.co.il> wrote: >> >> On 5/9/2018 5:30 AM, Håkon Bugge wrote: >>> There is no point in using RDMA CM to establish a connection between >&

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/10/2018 5:16 AM, Håkon Bugge wrote: > > >> On 9 May 2018, at 13:28, Hal Rosenstock wrote: >> >> On 5/9/2018 5:30 AM, Håkon Bugge wrote: >>> There is no point in using RDMA CM to establish a connection between >>> two QPs that cannot p

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/9/2018 5:30 AM, Håkon Bugge wrote: > There is no point in using RDMA CM to establish a connection between > two QPs that cannot possible communicate. Particularly, if both the > active and passive side use limited pkeys, they are not able to > communicate. > > In order to detect this

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

On 5/9/2018 5:30 AM, Håkon Bugge wrote: > There is no point in using RDMA CM to establish a connection between > two QPs that cannot possible communicate. Particularly, if both the > active and passive side use limited pkeys, they are not able to > communicate. > > In order to detect this

Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X

; This patch restores the original behavior. > > Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed > in RoCE"). > Signed-off-by: Honggang Li <ho...@redhat.com> Reviewed-by: Hal Rosenstock <h...@mellanox.com> > --- > drivers/infiniband

Re: [PATCH] IB/mlx5: Set the default active rate and width to QDR and 4X

inal behavior. > > Fixes: f1b65df5a232 ("IB/mlx5: Add support for active_width and active_speed > in RoCE"). > Signed-off-by: Honggang Li Reviewed-by: Hal Rosenstock > --- > drivers/infiniband/hw/mlx5/main.c | 3 +++ > 1 file changed, 3 insertions(+) > >

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

On 3/15/2018 8:43 AM, Honggang LI wrote: > On Thu, Mar 15, 2018 at 08:32:02AM -0400, Hal Rosenstock wrote: >> On 3/15/2018 8:01 AM, Hal Rosenstock wrote: >>> On 3/15/2018 5:02 AM, Honggang LI wrote: >>>> From: Honggang Li <ho...@redhat.com> >>>>

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

On 3/15/2018 8:43 AM, Honggang LI wrote: > On Thu, Mar 15, 2018 at 08:32:02AM -0400, Hal Rosenstock wrote: >> On 3/15/2018 8:01 AM, Hal Rosenstock wrote: >>> On 3/15/2018 5:02 AM, Honggang LI wrote: >>>> From: Honggang Li >>>> >>>> commi

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

On 3/15/2018 8:01 AM, Hal Rosenstock wrote: > On 3/15/2018 5:02 AM, Honggang LI wrote: >> From: Honggang Li <ho...@redhat.com> >> >> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and >> active_speed in RoCE"). Before this patch applied, the

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

On 3/15/2018 8:01 AM, Hal Rosenstock wrote: > On 3/15/2018 5:02 AM, Honggang LI wrote: >> From: Honggang Li >> >> commit f1b65df5a232 ("IB/mlx5: Add support for active_width and >> active_speed in RoCE"). Before this patch applied, the mlx5_ib >> drive

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

On 3/15/2018 5:02 AM, Honggang LI wrote: > From: Honggang Li > > commit f1b65df5a232 ("IB/mlx5: Add support for active_width and > active_speed in RoCE"). Before this patch applied, the mlx5_ib > driver set default active_width and active_speed to IB_WIDTH_4X > and

Re: [PATCH 2/2] IB/core: Set width to 1X for invalid active widths when port is down

On 3/15/2018 5:02 AM, Honggang LI wrote: > From: Honggang Li > > commit f1b65df5a232 ("IB/mlx5: Add support for active_width and > active_speed in RoCE"). Before this patch applied, the mlx5_ib > driver set default active_width and active_speed to IB_WIDTH_4X > and IB_SPEED_QDR. > > When the

Re: [PATCH v3] Documentation/ABI: update infiniband sysfs interfaces

the comment '[to be documented]'. > > Signed-off-by: Aishwarya Pant <aishp...@gmail.com> Thanks. Looks good to me (the device neutral parts of this which I reviewed). Nice work! Reviewed-by: Hal Rosenstock <h...@mellanox.com>

Re: [PATCH v3] Documentation/ABI: update infiniband sysfs interfaces

the comment '[to be documented]'. > > Signed-off-by: Aishwarya Pant Thanks. Looks good to me (the device neutral parts of this which I reviewed). Nice work! Reviewed-by: Hal Rosenstock

Re: [PATCH v2] Documentation/ABI: update infiniband sysfs interfaces

On 2/6/2018 2:24 AM, Aishwarya Pant wrote: > Add documentation for core and hardware specific infiniband interfaces. > The descriptions have been collected from git commit logs, reading > through code and data sheets. Some drivers have incomplete doc and are > annotated with the comment '[to be

Re: [PATCH v2] Documentation/ABI: update infiniband sysfs interfaces

On 2/6/2018 2:24 AM, Aishwarya Pant wrote: > Add documentation for core and hardware specific infiniband interfaces. > The descriptions have been collected from git commit logs, reading > through code and data sheets. Some drivers have incomplete doc and are > annotated with the comment '[to be

Re: [PATCH] Documentation/ABI: update infiniband sysfs interfaces

On 2/5/2018 2:19 AM, Aishwarya Pant wrote: >>> + cap_mask: (RO) Port capability mask >> 2 bits here are settable: IsCommunicationManagementSupported and IsSM. > Hi > > Sorry, I don't quite understand this. cap_mask is a read only value which > indicates the supported functions. So

Re: [PATCH] Documentation/ABI: update infiniband sysfs interfaces

On 2/5/2018 2:19 AM, Aishwarya Pant wrote: >>> + cap_mask: (RO) Port capability mask >> 2 bits here are settable: IsCommunicationManagementSupported and IsSM. > Hi > > Sorry, I don't quite understand this. cap_mask is a read only value which > indicates the supported functions. So

Re: [PATCH] Documentation/ABI: update infiniband sysfs interfaces

On 2/1/2018 8:32 AM, Aishwarya Pant wrote: > Add documentation for core and hardware specific infiniband interfaces. > The descriptions have been collected from git commit logs, reading > through code and data sheets. Some drivers have incomplete doc and are > annotated with the comment '[to be

Re: [PATCH] Documentation/ABI: update infiniband sysfs interfaces

On 2/1/2018 8:32 AM, Aishwarya Pant wrote: > Add documentation for core and hardware specific infiniband interfaces. > The descriptions have been collected from git commit logs, reading > through code and data sheets. Some drivers have incomplete doc and are > annotated with the comment '[to be

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/28/2017 6:42 AM, Thomas Bogendoerfer wrote: >> I must be missing something as to what is going on in this scenario. I think I see what's going on now. The -EINVAL in kernel sysfs/rate_show causes error to either open or read of file. I had checked that an empty file is parsed correctly but

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/28/2017 6:42 AM, Thomas Bogendoerfer wrote: >> I must be missing something as to what is going on in this scenario. I think I see what's going on now. The -EINVAL in kernel sysfs/rate_show causes error to either open or read of file. I had checked that an empty file is parsed correctly but

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 7:19 PM, Hal Rosenstock wrote: > On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: >> >> >> On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >>> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>>> When running ibstat (if transceiver is no

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 7:19 PM, Hal Rosenstock wrote: > On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: >> >> >> On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >>> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>>> When running ibstat (if transceiver is no

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: > > > On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>> When running ibstat (if transceiver is not connected in adapter): >>> >>> ibpanic: [785

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 7:04 PM, Ghazale Hosseinabadi wrote: > > > On 10/27/2017 03:52 PM, Hal Rosenstock wrote: >> On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: >>> When running ibstat (if transceiver is not connected in adapter): >>> >>> ibpanic: [785

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: > When running ibstat (if transceiver is not connected in adapter): > > ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid argument Any output before that ? I'm trying to understand how far it gets. It looks to me that empty rate

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 5:54 PM, Ghazale Hosseinabadi wrote: > When running ibstat (if transceiver is not connected in adapter): > > ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid argument Any output before that ? I'm trying to understand how far it gets. It looks to me that empty rate

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 4:33 PM, Parav Pandit wrote: > > >> -Original Message----- >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] >> Sent: Friday, October 27, 2017 3:19 PM >> To: Parav Pandit <pa...@mellanox.com>; Thomas Bogendoerfer >>

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 4:33 PM, Parav Pandit wrote: > > >> -Original Message----- >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] >> Sent: Friday, October 27, 2017 3:19 PM >> To: Parav Pandit ; Thomas Bogendoerfer >> ; Matan Barak ; Leon >&

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 2:32 PM, Parav Pandit wrote: > However I believe that ibstat tool should be enhanced to report unknown port > speed instead of expecting drivers to supply some random number like this. ibstat gets the rate from libibumad via /sys/class/infiniband//ports//rate file which is supposed

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On 10/27/2017 2:32 PM, Parav Pandit wrote: > However I believe that ibstat tool should be enhanced to report unknown port > speed instead of expecting drivers to supply some random number like this. ibstat gets the rate from libibumad via /sys/class/infiniband//ports//rate file which is supposed

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On 9/30/2015 12:32 PM, Weiny, Ira wrote: >> >> On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> This interface has no current users and is obsolete. >> >> There are no in tree users of this but there is Sean's madeye tool (which is >> out >> of tree). This is still a

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: > From: Ira Weiny > > This interface has no current users and is obsolete. There are no in tree users of this but there is Sean's madeye tool (which is out of tree). This is still a useful debug tool for MADs. > Signed-off-by: Ira Weiny > --- >

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On 9/30/2015 12:32 PM, Weiny, Ira wrote: >> >> On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: >>> From: Ira Weiny >>> >>> This interface has no current users and is obsolete. >> >> There are no in tree users of this but there is Sean's madeye tool (which is >> out >> of

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On 9/30/2015 2:01 AM, ira.we...@intel.com wrote: > From: Ira Weiny > > This interface has no current users and is obsolete. There are no in tree users of this but there is Sean's madeye tool (which is out of tree). This is still a useful debug tool for MADs. >

Re: [PATCH v5 04/27] IB/Verbs: Reform IB-core cm

On 4/20/2015 4:33 AM, Michael Wang wrote: > > Use raw management helpers to reform IB-core cm. > > Cc: Hal Rosenstock > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang

Re: [PATCH v5 04/27] IB/Verbs: Reform IB-core cm

On 4/20/2015 4:33 AM, Michael Wang wrote: Use raw management helpers to reform IB-core cm. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

On 4/16/2015 11:58 AM, Jason Gunthorpe wrote: > It also looks like hardwired 1 won't work on switch ports, so it is no-go. AFAIK enhanced switch port 0 is not supported by CM/RDMA CM in the current code. There is no need for CM/RDMA CM on base switch port 0. -- To unsubscribe from this list: send

Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

On 4/16/2015 9:57 AM, Or Gerlitz wrote: > On Mon, Apr 13, 2015 at 3:35 PM, Michael Wang > wrote: >> >> Introduce helper cap_af_ib() to help us check if the port of an >> IB device support Native Infiniband Address. >> >> Cc: Steve Wise >> Cc: Tom Talpey >> Cc: Jason Gunthorpe >> Cc: Doug

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

On 4/16/2015 9:35 AM, Michael Wang wrote: > > > On 04/16/2015 03:19 PM, Hal Rosenstock wrote: > [snip] >>> >>> +static inline int cma_validate_port(struct ib_device *device, u8 port, >>> + union ib_gid *gid, int

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

On 4/16/2015 9:41 AM, Michael Wang wrote: > > > On 04/16/2015 03:36 PM, Hal Rosenstock wrote: > [snip] >>> -EXPORT_SYMBOL(rdma_node_get_transport); >>> - >>> enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 >>> por

Re: [PATCH v4 20/27] IB/Verbs: Use management helper cap_ib_sa()

On 4/16/2015 4:12 AM, Michael Wang wrote: > > Introduce helper cap_ib_sa() to help us check if the port of an > IB device support Infiniband Subnet Administrator. Nit: Administrator -> Administration > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

On 4/16/2015 4:15 AM, Michael Wang wrote: > > We have get rid of all the scene using legacy rdma_node_get_transport(), > now clean it up. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- >

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

On 4/16/2015 4:09 AM, Michael Wang wrote: > > Reform cma_acquire_dev() with management helpers, introduce > cma_validate_port() to make the code more clean. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by:

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

On 4/16/2015 4:08 AM, Michael Wang wrote: > > Use raw management helpers to reform cm related part in IB-core cma/ucm. > > These checks focus on the device cm type rather than the port capability, > directly pass port 1 works currently, but can't support mixing cm type > device in future. This

Re: [PATCH v4 03/27] IB/Verbs: Reform IB-core mad/agent/user_mad

On 4/16/2015 4:05 AM, Michael Wang wrote: > > Use raw management helpers to reform IB-core mad/agent/user_mad. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- >

Re: [PATCH v4 04/27] IB/Verbs: Reform IB-core cm

On 4/16/2015 4:05 AM, Michael Wang wrote: > > Use raw management helpers to reform IB-core cm. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- > drivers/infiniband/core/cm.c | 22

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

On 4/15/2015 4:33 PM, ira.weiny wrote: > On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: >> On 4/13/2015 8:22 AM, Michael Wang wrote: >>> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h >>> index 65994a1..d54f91e 100644 >>> ---

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

On 4/15/2015 4:33 PM, ira.weiny wrote: On Wed, Apr 15, 2015 at 02:36:13PM -0400, Hal Rosenstock wrote: On 4/13/2015 8:22 AM, Michael Wang wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma

Re: [PATCH v4 03/27] IB/Verbs: Reform IB-core mad/agent/user_mad

On 4/16/2015 4:05 AM, Michael Wang wrote: Use raw management helpers to reform IB-core mad/agent/user_mad. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

Re: [PATCH v4 04/27] IB/Verbs: Reform IB-core cm

On 4/16/2015 4:05 AM, Michael Wang wrote: Use raw management helpers to reform IB-core cm. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

On 4/16/2015 9:35 AM, Michael Wang wrote: On 04/16/2015 03:19 PM, Hal Rosenstock wrote: [snip] +static inline int cma_validate_port(struct ib_device *device, u8 port, + union ib_gid *gid, int dev_type) +{ + u8 found_port; + int ret = -ENODEV

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

On 4/16/2015 9:41 AM, Michael Wang wrote: On 04/16/2015 03:36 PM, Hal Rosenstock wrote: [snip] -EXPORT_SYMBOL(rdma_node_get_transport); - enum rdma_link_layer rdma_port_get_link_layer(struct ib_device *device, u8 port_num) { if (device-get_link_layer) diff --git a/include/rdma

Re: [PATCH v4 14/27] IB/Verbs: Reform cma_acquire_dev()

On 4/16/2015 4:09 AM, Michael Wang wrote: Reform cma_acquire_dev() with management helpers, introduce cma_validate_port() to make the code more clean. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

On 4/16/2015 9:57 AM, Or Gerlitz wrote: On Mon, Apr 13, 2015 at 3:35 PM, Michael Wang yun.w...@profitbricks.com wrote: Introduce helper cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

On 4/16/2015 4:08 AM, Michael Wang wrote: Use raw management helpers to reform cm related part in IB-core cma/ucm. These checks focus on the device cm type rather than the port capability, directly pass port 1 works currently, but can't support mixing cm type device in future. This is

Re: [PATCH v4 20/27] IB/Verbs: Use management helper cap_ib_sa()

On 4/16/2015 4:12 AM, Michael Wang wrote: Introduce helper cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administrator. Nit: Administrator - Administration Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v4 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

On 4/16/2015 4:15 AM, Michael Wang wrote: We have get rid of all the scene using legacy rdma_node_get_transport(), now clean it up. Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford

Re: [PATCH v4 10/27] IB/Verbs: Reform cm related part in IB-core cma/ucm

On 4/16/2015 11:58 AM, Jason Gunthorpe wrote: It also looks like hardwired 1 won't work on switch ports, so it is no-go. AFAIK enhanced switch port 0 is not supported by CM/RDMA CM in the current code. There is no need for CM/RDMA CM on base switch port 0. -- To unsubscribe from this list: send

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

On 4/13/2015 8:22 AM, Michael Wang wrote: > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 65994a1..d54f91e 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -75,10 +75,13 @@ enum rdma_node_type { > }; > > enum rdma_transport_type { > + /*

Re: [PATCH v3 10/28] IB/Verbs: Reform cm related part in IB-core cma

On 4/13/2015 3:50 PM, Jason Gunthorpe wrote: > Less clear is how rocee vs ib work within a device... Can you APM > between those two kinds of ports? The specs allow this to work but AFAIK it's not implemented. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH v3 01/28] IB/Verbs: Implement new callback query_transport()

On 4/13/2015 8:22 AM, Michael Wang wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -75,10 +75,13 @@ enum rdma_node_type { }; enum rdma_transport_type { + /* legacy

Re: [PATCH v3 10/28] IB/Verbs: Reform cm related part in IB-core cma

On 4/13/2015 3:50 PM, Jason Gunthorpe wrote: Less clear is how rocee vs ib work within a device... Can you APM between those two kinds of ports? The specs allow this to work but AFAIK it's not implemented. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

RE: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

On Fri, 2008-01-18 at 09:42 -0800, Sean Hefty wrote: > >> Sean Hefty (6): > >> IB/mad: Fix incorrect access to items on local_list > > > >It wasn't clear to me that this issue was ever really nailed. Was the > >loop on this closed ? > > The error that this patches addresses is fairly

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

On Thu, 2008-01-17 at 16:11 -0800, Roland Dreier wrote: > Here all the patches I already have in my for-2.6.25 branch: > Sean Hefty (6): > IB/mad: Fix incorrect access to items on local_list It wasn't clear to me that this issue was ever really nailed. Was the loop on this closed ? -- Hal

RE: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

On Fri, 2008-01-18 at 09:42 -0800, Sean Hefty wrote: Sean Hefty (6): IB/mad: Fix incorrect access to items on local_list It wasn't clear to me that this issue was ever really nailed. Was the loop on this closed ? The error that this patches addresses is fairly obvious if you

Re: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

On Thu, 2008-01-17 at 16:11 -0800, Roland Dreier wrote: Here all the patches I already have in my for-2.6.25 branch: Sean Hefty (6): IB/mad: Fix incorrect access to items on local_list It wasn't clear to me that this issue was ever really nailed. Was the loop on this closed ? -- Hal --

Re: [ofa-general] Further 2.6.23 merge plans...

On Thu, 2007-07-12 at 19:15, Roland Dreier wrote: > As you can see, I just sent my first 2.6.23 pull request for Linus. > There are still a few more things I plan to do in before the merge > window closes (in ~10 days): > > - Write a patch to add P_Key handling to user_mad in the way we >

Re: [ofa-general] Further 2.6.23 merge plans...

On Thu, 2007-07-12 at 19:15, Roland Dreier wrote: As you can see, I just sent my first 2.6.23 pull request for Linus. There are still a few more things I plan to do in before the merge window closes (in ~10 days): - Write a patch to add P_Key handling to user_mad in the way we discussed

Re: [ofa-general] [PATCH] eHCA: Add "Modify Port" verb

Hi Joachim, On Mon, 2007-04-23 at 12:23, Joachim Fenkes wrote: > Add "Modify Port" verb support to eHCA driver. > ib_cm needs this to initialize properly. > > > Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> > --- > > ehca_hca.c | 48 ++-- >

Re: [ofa-general] [PATCH] eHCA: Add Modify Port verb

Hi Joachim, On Mon, 2007-04-23 at 12:23, Joachim Fenkes wrote: Add Modify Port verb support to eHCA driver. ib_cm needs this to initialize properly. Signed-off-by: Joachim Fenkes [EMAIL PROTECTED] --- ehca_hca.c | 48 ++-- hcp_if.c |

Re: [PATCH 0/29v2] InfiniBand core update

On Tue, 2005-07-12 at 18:38, Andrew Morton wrote: > OK, well the timing of a merge is mainly up to you guys, especially as the > subsystem is pretty raw and you're the only people who use it ;) > > Two things from a quick scan: > > a) In many places the patch does > > if (p) >

Re: [PATCH 0/29v2] InfiniBand core update

On Mon, 2005-07-11 at 23:11, Andrew Morton wrote: > Well I was asking. Do you guys think that this material is appropriate to > and safe enough for 2.6.13? I used your versions of the patches (Tom's ucm one is needed and you added that). I also back ported the trailing whitespace elimination

Re: [PATCH 0/29v2] InfiniBand core update

On Mon, 2005-07-11 at 23:11, Andrew Morton wrote: > Well I was asking. Do you guys think that this material is appropriate to > and safe enough for 2.6.13? We think so. > What are "user CM" and "kernel CM"? CM is the InfiniBand Communications Manager. It is (primarily) responsible for setting

Re: [PATCH 0/29v2] InfiniBand core update

On Mon, 2005-07-11 at 23:12, David S. Miller wrote: > Please acknowledge that you understand how inappropriate > and problem causing your huge patch bomb was today to this > mailing list. > > It is nearly 8 hours later, and vger.kernel.org is still > trying mightily to spit out all of your

Re: [PATCH 0/29v2] InfiniBand core update

On Mon, 2005-07-11 at 23:11, Andrew Morton wrote: Well I was asking. Do you guys think that this material is appropriate to and safe enough for 2.6.13? I used your versions of the patches (Tom's ucm one is needed and you added that). I also back ported the trailing whitespace elimination

Re: [PATCH 0/29v2] InfiniBand core update

On Tue, 2005-07-12 at 18:38, Andrew Morton wrote: OK, well the timing of a merge is mainly up to you guys, especially as the subsystem is pretty raw and you're the only people who use it ;) Two things from a quick scan: a) In many places the patch does if (p)

Re: [PATCH 0/29v2] InfiniBand core update

On Mon, 2005-07-11 at 23:12, David S. Miller wrote: Please acknowledge that you understand how inappropriate and problem causing your huge patch bomb was today to this mailing list. It is nearly 8 hours later, and vger.kernel.org is still trying mightily to spit out all of your patches to

Re: [PATCH 0/29v2] InfiniBand core update

On Mon, 2005-07-11 at 23:11, Andrew Morton wrote: Well I was asking. Do you guys think that this material is appropriate to and safe enough for 2.6.13? We think so. What are user CM and kernel CM? CM is the InfiniBand Communications Manager. It is (primarily) responsible for setting up and

Re: [PATCH 0/29v2] InfiniBand core update

On Mon, 2005-07-11 at 20:05, Andrew Morton wrote: > Hal Rosenstock <[EMAIL PROTECTED]> wrote: > > > > This is version 2 of a patch series to get the Infiniband core up to > > date. > > Well that was interesting. > > - All the patches had mangled h

[PATCH 4/27] Combine some MAD routines

Combine response_mad() and solicited_mad() routines into a single function and simplify/encapsulate its usage. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 3/27. -- mad.c | 105 -- 1 f

PATCH [6/27] Change ib_mad_send_wr_private struct

Have ib_mad_send_wr_private reference the private agent structure directly, rather than the exposed agent definition. Remove unneeded parameters to functions and simplify code were possible from this change. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock &

[PATCH 8/27] Minor cleanup during MAD startup and shutdown

Minor cleanup during startup and shutdown Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 7/27. -- mad.c | 44 +-- 1 files changed, 9 insertions(+), 35 deletions(-) diff -uprN linux-2.6.13-rc2-mm1/drivers/infiniband7/core/mad.c linux-2.6.13-r

[PATCH 10/27] Add automatic retries to MAD layer

Add automatic retries to MAD layer. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 9/27. -- core/mad.c | 26 +- core/mad_priv.h|2 ++ core/sa_query.c|

[PATCH 15/27] Fix a couple of MAD code paths

Fixed locking to handle error posting MAD send work requests. Fixed handling canceling a MAD with an active work request. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 14/27. -- mad.c | 28 +++

[PATCH 16/27] Add ib_create_ah_from_wc to IB verbs

Added new call: ib_create_ah_from_wc. Call will allocate an address handle given work completion information, including any received GRH. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 15/27. --

[PATCH 6/29v2] Change ib_mad_send_wr_private struct

Have ib_mad_send_wr_private reference the private agent structure directly, rather than the exposed agent definition. Remove unneeded parameters to functions and simplify code were possible from this change. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock &

[PATCH 11/29v2] Simplify calling of list_del in MAD

Simplify calling of list_del. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 10/29. -- mad.c |3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -uprN linux-2.6.13-rc2-mm1-10/drivers/inf

[PATCH 10/29v2] Add automatic retries to MAD layer

Add automatic retries to MAD layer. Signed-off-by: Sean Hefty <[EMAIL PROTECTED]> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]> This patch depends on patch 9/29. -- core/mad.c | 26 +- core/mad_priv.h|2 ++ core/sa_query.c|

  1   2   3   >