On Wed, 2016-11-23 at 19:32 +0100, Matthias Brugger wrote:
> Hi Hongzhou,
>
> On 12/05/16 04:55, Hongzhou Yang wrote:
> > On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote:
> >> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote:
> >>> Hi,
> >
, 16),
> MTK_FUNCTION(0, "GPIO16"),
> MTK_FUNCTION(1, "IDDIG"),
> MTK_FUNCTION(2, "CMFLASH"),
Acked-by: Hongzhou Yang
Thanks,
Hongzhou
ruct platform_driver mtk_pinctrl_driver = {
> },
> };
>
> -static int __init mtk_pinctrl_init(void)
> -{
> - return platform_driver_register(&mtk_pinctrl_driver);
> -}
> -device_initcall(mtk_pinctrl_init);
> +builtin_platform_driver(mtk_pinctrl_driver);
Acked-by: Hongzhou Yang
Thanks,
Hongzhou
On Wed, 2016-05-11 at 19:09 -0700, Hongzhou Yang wrote:
> On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote:
> > Hi,
> >
> > On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote:
> > > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote:
> > > >
On Thu, 2016-05-12 at 09:41 +0800, chunfeng yun wrote:
> Hi,
>
> On Wed, 2016-05-11 at 11:32 -0700, Hongzhou Yang wrote:
> > On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote:
> > > On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun
> > > wrote:
> > >
On Wed, 2016-05-11 at 13:56 +0200, Linus Walleij wrote:
> On Tue, May 10, 2016 at 10:23 AM, Chunfeng Yun
> wrote:
>
> > the default mode of GPIO16 pin is gpio, when set EINT16 to
> > IRQ_TYPE_LEVEL_HIGH, no interrupt is triggered, it can be
> > fixed when set its default mode as usb iddig.
> >
>
e setting is 500us,
> correct this as well.
>
> While I'm at it, also change the debounce time array name to
> "debounce_time" for readability.
>
> Signed-off-by: Yingjoe Chen
Acked-by: Hongzhou Yang
> ---
> This was based on v4.6-rc1
> Change since v1:
&
mit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Linus Walleij
> Cc: Matthias Brugg
On Wed, 2016-02-24 at 18:45 +0530, Laxman Dewangan wrote:
> Use devm_pinctrl_register() for pin control registration and clean
> the error path.
>
> Signed-off-by: Laxman Dewangan
> Cc: Matthias Brugger
> Cc: Hongzhou Yang
> Cc: Yingjoe Chen
> ---
Acked-by: Hongzhou
On Fri, 2016-02-05 at 14:52 +0100, Linus Walleij wrote:
> On Thu, Feb 4, 2016 at 4:03 AM, Hongzhou Yang
> wrote:
> > On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote:
> >> Since input-enable/disable and input-schmitt-enable/disable are
> >> workable when g
On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote:
> Since input-enable/disable and input-schmitt-enable/disable are
> workable when gpio direction is input, so add direction setting
> when do input-enable/disable and input-schmitt-enable/disable
> properties.
>
> Signed-off-by: Biao Huang
> --
configs will kmemdup to dup_configs in pictrl util function.
So configs need to be freed.
Signed-off-by: Hongzhou Yang
Reviewed-by: Daniel Kurtz
Reviewed-by: Matthias Brugger
---
Fix a memleak issue.
According to Yingjoe's comment, add return checek for
pinconf_generic_parse_dt_c
Since Linux gpio framework return 0 for output, 1 for input.
But HW use 0 stands for input, and 1 stands for output.
So use negative to correct it.
And gpio_chip.get is used to get input value, no need to get
output value, so removing it.
Signed-off-by: Hongzhou Yang
---
Base on v4.4-rc1
configs will kmemdup to dup_configs in pictrl util function.
So configs need to be freed.
Signed-off-by: Hongzhou Yang
---
Fix a memleak issue.
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a
configs will kmemdup to dup_configs in pictrl util function.
So configs need to be freed.
Signed-off-by: Hongzhou Yang
---
Fix a memleak issue.
drivers/pinctrl/mediatek/pinctrl-mtk-common.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek
Since Linux gpio framework return 0 for output, 1 for input.
But HW use 0 stands for input, and 1 stands for output.
So use negative to correct it.
And gpio_chip.get is used to get input value, no need to get
output value, so removing it.
Signed-off-by: Hongzhou Yang
---
Add get direction
; irq_set_chained_handler_and_data(irq, mtk_eint_irq_handler, pctl);
> return 0;
Acked-by: Hongzhou Yang
Thanks
Hongzhou
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
x27;s, all members in pinctrl_desc will set to
the new one's, such as name, pins and pins numbers, etc.
This is a bug.
Move pinctrl_desc into mtk_pinctrl, assign new value for
each pinctrl device to fix it.
Cc: sta...@vger.kernel.org # v4.1+
Signed-off-by: Hongzhou Yang
Reviewed-by: Axel Li
On Tue, 2015-08-25 at 17:16 -0700, Hongzhou Yang wrote:
> Since our common driver need support main chip and PMU
> at the same time, that means it will register two
> pinctrl device, and the pinctrl_desc structure should
> be used two times.
>
> But pinctrl_desc use global stati
x27;s, all members in pinctrl_desc will set to
the new one's, such as name, pins and pins numbers, etc.
This is a bug. Changing to use devm_kzalloc to fix it.
Cc: sta...@vger.kernel.org # v4.1+
Signed-off-by: Hongzhou Yang
Reviewed-by: Axel Lin
---
Adding pinctrl_desc into mtk_pinctrl, assign
x27;s, all members in pinctrl_desc will set to
the new one's, such as name, pins and pins numbers, etc.
This is a bug. Changing to use devm_kzalloc to fix it.
Cc: sta...@vger.kernel.org # v4.1+
Signed-off-by: Hongzhou Yang
---
Use dynamic allocation to fix multiple registration issue.
drive
x27;s, all members in pinctrl_desc will set to
the new one's, such as name, pins and pins numbers, etc.
This is a bug. Changing to use devm_kzalloc to fix it.
Cc: sta...@vger.kernel.org # v4.1+
Signed-off-by: Hongzhou Yang
---
Use dynamic allocation to fix multiple registration issue.
drive
> > >> +}
> > >
> > > Hi Maoguang,
> > >
> > > You changed from set_bit/clear_bit to this, but didn't add any locking.
> > > Since this is basic read/modify/write, is it OK to do it without
> > > locking?
> >
> > I believe
On Tue, 2015-08-11 at 15:45 +0800, Daniel Kurtz wrote:
> On Tue, Aug 11, 2015 at 12:49 PM, Hongzhou Yang
> wrote:
> > Use dynamic allocation to fix multiple registeration issue.
>
> s/registeration/registration - here and in the patch subject.
>
&g
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 27 +++--
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
index ad1ea16..2bba504
re you OK with this patch? Can I have your ACKs?
>
> Yours,
> Linus Walleij
Hi Linus,
Yes, you can. Thank you.
Acked-by: Hongzhou Yang
Hongzhou
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel
n %d on group %d .\n",
> + dev_err(pctl->dev, "invalid function %d on group %d .\n",
> function, group);
> return -EINVAL;
> }
Hi Colin,
Thank you very much.
Acked-by: Hongzhou Yang
Hongzhou
--
To unsubscribe from this
On Wed, 2015-05-27 at 02:43 -0700, Hongzhou Yang wrote:
> Hi Linus,
> After integration test, we found some bugs in the code you just merged.
> The first is that I missed ies/smt configuration for MSDC3.
> The seconed is the if judgement for "interrupt-controller" I added las
On Wed, 2015-05-27 at 11:32 +0100, Lee Jones wrote:
> On Wed, 27 May 2015, Hongzhou Yang wrote:
>
> > Base on Lee Jones' comment, change pinctrl subnode name.
> >
> > ---
> > Register pinctrl subnode into 6397 mfd cell.
>
> Sascha already mentioned
Add ies/smt support for MSDC3.
Also fix ies bug for pin 106 and 107.
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/pinctrl-mt8173.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8173.c
b/drivers/pinctrl/mediatek
n the contrary, this is a bug.
so adding this patch to fix it.
Hongzhou Yang (2):
pinctrl: mediatek: Fix bug of ies/smt setting for mt8173.
pinctrl: mediatek: Fix pinctrl register irq fail bug.
drivers/pinctrl/mediatek/pinctrl-mt8173.c | 10 +-
drivers/pinctrl/mediatek/pinctrl
d_property.
Also fix bug of misuse pointer.
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/pinctrl-mtk-common.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
ind
Base on Lee Jones' comment, change pinctrl subnode name.
---
Register pinctrl subnode into 6397 mfd cell.
Signed-off-by: Hongzhou Yang
Acked-by: Linus Walleij
---
drivers/mfd/mt6397-core.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/m
On Tue, 2015-05-19 at 10:34 +0100, Lee Jones wrote:
> On Mon, 18 May 2015, Hongzhou Yang wrote:
>
> > Register pinctrl subnode into 6397 mfd cell.
> >
> > Signed-off-by: Hongzhou Yang
> > ---
> > drivers/mfd/mt6397-core.c |3 +++
> > 1 file chan
Add pinctrl and GPIO node to mt8173-evb.dts.
Signed-off-by: Hongzhou Yang
---
arch/arm64/boot/dts/mediatek/mt8173-evb.dts |8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
index c9bc71b
Add pinctrl and GPIO node to mt8135-evbp1.dts.
Signed-off-by: Hongzhou Yang
---
arch/arm/boot/dts/mt8135-evbp1.dts |8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/mt8135-evbp1.dts
b/arch/arm/boot/dts/mt8135-evbp1.dts
index 357a91f..332233b 100644
--- a/arch/arm
From: Yingjoe Chen
Add pinctrl,GPIO and EINT node to mt8127.dtsi.
Signed-off-by: Yingjoe Chen
Signed-off-by: Hongzhou Yang
---
arch/arm/boot/dts/mt8127-pinfunc.h | 742
arch/arm/boot/dts/mt8127.dtsi | 22 ++
2 files changed, 764 insertions
Register pinctrl subnode into 6397 mfd cell.
Signed-off-by: Hongzhou Yang
---
drivers/mfd/mt6397-core.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index 09bc780..012c620 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd
From: Yingjoe Chen
MT8127 pinctrl/eint are similar to mt8135 and mt8173, add
support for mt8127 using mediatek common pinctrl driver.
Signed-off-by: Yingjoe Chen
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/Kconfig |6 +
drivers/pinctrl/mediatek/Makefile
.
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/Kconfig |6 +
drivers/pinctrl/mediatek/Makefile |1 +
drivers/pinctrl/mediatek/pinctrl-mt6397.c | 78 +
drivers/pinctrl/mediatek/pinctrl-mt8135.c |2 +-
drivers/pinctrl/mediatek/pinctrl
future soc driver
can use it.
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/pinctrl-mt8173.c | 201 +
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 82 +++---
drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 31 +++-
3 files changed, 198 insertions
-by: Yingjoe Chen
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/pinctrl-mt8173.c | 166 +++--
drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 60 +
drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 31 +
3 files changed, 136 insertions(+), 121
Signed-off-by: Hongzhou Yang
---
drivers/pinctrl/mediatek/pinctrl-mt8135.c | 10 --
drivers/pinctrl/mediatek/pinctrl-mtk-common.h | 10 ++
2 files changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8135.c
b/drivers/pinctrl/mediatek
Add pinfunc header file, mt8135/mt8173 relate dts will include it.
Signed-off-by: Hongzhou Yang
---
include/dt-bindings/pinctrl/mt6397-pinfunc.h | 256 ++
1 file changed, 256 insertions(+)
create mode 100644 include/dt-bindings/pinctrl/mt6397-pinfunc.h
diff --git a
Since 6397 is no need to support interrupt controller,
moving interrupt controller relate property to optional list.
Also adding mt8173 and mt8127 to bindings.
Signed-off-by: Hongzhou Yang
---
.../devicetree/bindings/pinctrl/pinctrl-mt65xx.txt |9 +++--
1 file changed, 7 insertions
Due to these patches haven't sent to ML, just resend them.
Changes in v2:
- Break mfd relate change out into a sparate patch.
- Rearrange order of patches.
Hongzhou Yang (7):
dt-bindings: mediatek: Modify pinctrl bindings for mt6397.
pinctrl: dt bindings: mt6397: Add pinfunc header
On Thu, 2015-03-19 at 19:41 +0100, Fabian Frederick wrote:
>
> > On 19 March 2015 at 02:58 Hongzhou Yang wrote:
> >
> >
> > On Mon, 2015-03-16 at 20:59 +0100, Fabian Frederick wrote:
> > > of_device_id is always used as const.
> > > (See driv
diatek/pinctrl-mt8135.c | 2 +-
> drivers/pinctrl/mediatek/pinctrl-mt8173.c | 2 +-
>
For the pinctrl-mt81xx driver,
Acked-by: Hongzhou Yang
By the way, Axel has sent same patch to linux-gpio.
http://article.gmane.org/gmane.linux.kernel.gpio/6815
Thanks.
Hongzhou
--
To unsubscribe fr
48 matches
Mail list logo