[PATCH v4 1/3] ASoC: pcm179x: Split into core and SPI parts

2016-01-22 Thread Jacob Siverskog
The pcm179x family supports both SPI and I2C for configuration. This patch splits the driver into core and SPI parts, in preparation for I2C support. Reviewed-by: Johan Hovold Signed-off-by: Jacob Siverskog --- sound/soc/codecs/Kconfig | 11 +-- sound/soc/codecs/Makefile | 2

[PATCH v4 2/3] ASoC: pcm179x: Add I2C interface driver

2016-01-22 Thread Jacob Siverskog
The PCM179x family supports both SPI and I2C. This patch adds support for the I2C interface. Reviewed-by: Johan Hovold Signed-off-by: Jacob Siverskog --- .../devicetree/bindings/sound/pcm179x.txt | 11 +++- sound/soc/codecs/Kconfig | 9 +++ sound/soc/codecs

[PATCH v4 3/3] ASoC: pcm179x: Support continuous rates

2016-01-22 Thread Jacob Siverskog
/pcm1795.pdf http://www.ti.com/lit/ds/symlink/pcm1796.pdf Reviewed-by: Johan Hovold Signed-off-by: Jacob Siverskog --- sound/soc/codecs/pcm179x.c | 4 +++- sound/soc/codecs/pcm179x.h | 4 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs

[PATCH v4 0/3] ASoC: pcm179x: Add I2C support, declare support for continuous rates

2016-01-22 Thread Jacob Siverskog
regmap error check to where the regmaps are allocated. Minor cosmetic changes. [V3]: Allocation of private data moved to common code. [V2]: Fix build issues found by kbuild test robot by adding static keyword and proper symbol exports. Jacob Siverskog (3): ASoC: pcm179x: Split into core and SPI

Re: [PATCH v3 1/3] ASoC: pcm179x: Split into core and SPI parts

2016-01-22 Thread Jacob Siverskog
On Thu, Jan 21, 2016 at 6:56 PM, Johan Hovold wrote: > On Thu, Jan 21, 2016 at 05:27:58PM +0100, Michael Trimarchi wrote: >> Hi >> >> On Thu, Jan 21, 2016 at 4:36 PM, Johan Hovold wrote: >> > On Thu, Jan 21, 2016 at 04:26:56PM +0100, Jacob Siverskog wrote: >>

Re: [PATCH v3 1/3] ASoC: pcm179x: Split into core and SPI parts

2016-01-22 Thread Jacob Siverskog
On Thu, Jan 21, 2016 at 6:56 PM, Johan Hovold <jo...@kernel.org> wrote: > On Thu, Jan 21, 2016 at 05:27:58PM +0100, Michael Trimarchi wrote: >> Hi >> >> On Thu, Jan 21, 2016 at 4:36 PM, Johan Hovold <jo...@kernel.org> wrote: >> > On Thu, Jan 21, 2016

[PATCH v4 2/3] ASoC: pcm179x: Add I2C interface driver

2016-01-22 Thread Jacob Siverskog
The PCM179x family supports both SPI and I2C. This patch adds support for the I2C interface. Reviewed-by: Johan Hovold <jo...@kernel.org> Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- .../devicetree/bindings/sound/pcm179x.txt | 11 +++- sound/soc/co

[PATCH v4 1/3] ASoC: pcm179x: Split into core and SPI parts

2016-01-22 Thread Jacob Siverskog
The pcm179x family supports both SPI and I2C for configuration. This patch splits the driver into core and SPI parts, in preparation for I2C support. Reviewed-by: Johan Hovold <jo...@kernel.org> Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- sound/soc/codecs/Kconfi

[PATCH v4 0/3] ASoC: pcm179x: Add I2C support, declare support for continuous rates

2016-01-22 Thread Jacob Siverskog
regmap error check to where the regmaps are allocated. Minor cosmetic changes. [V3]: Allocation of private data moved to common code. [V2]: Fix build issues found by kbuild test robot by adding static keyword and proper symbol exports. Jacob Siverskog (3): ASoC: pcm179x: Split into core and SPI

[PATCH v4 3/3] ASoC: pcm179x: Support continuous rates

2016-01-22 Thread Jacob Siverskog
/pcm1795.pdf http://www.ti.com/lit/ds/symlink/pcm1796.pdf Reviewed-by: Johan Hovold <jo...@kernel.org> Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- sound/soc/codecs/pcm179x.c | 4 +++- sound/soc/codecs/pcm179x.h | 4 2 files changed, 3 insertions(+), 5 deletions(-)

[PATCH v3 3/3] ASoC: pcm179x: Support continuous rates

2016-01-21 Thread Jacob Siverskog
/pcm1795.pdf http://www.ti.com/lit/ds/symlink/pcm1796.pdf Reviewed-by: Johan Hovold Signed-off-by: Jacob Siverskog --- sound/soc/codecs/pcm179x.c | 4 +++- sound/soc/codecs/pcm179x.h | 4 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs

[PATCH v3 2/3] ASoC: pcm179x: Add I2C interface driver

2016-01-21 Thread Jacob Siverskog
The PCM179x family supports both SPI and I2C. This patch adds support for the I2C interface. Reviewed-by: Johan Hovold Signed-off-by: Jacob Siverskog --- .../devicetree/bindings/sound/pcm179x.txt | 11 +++- sound/soc/codecs/Kconfig | 9 +++ sound/soc/codecs

[PATCH v3 1/3] ASoC: pcm179x: Split into core and SPI parts

2016-01-21 Thread Jacob Siverskog
The pcm179x family supports both SPI and I2C for configuration. This patch splits the driver into core and SPI parts, in preparation for I2C support. Reviewed-by: Johan Hovold Signed-off-by: Jacob Siverskog --- sound/soc/codecs/Kconfig | 11 ++-- sound/soc/codecs/Makefile | 2

[PATCH v3 0/3] ASoC: pcm179x: Add I2C support, declare support for continuous rates

2016-01-21 Thread Jacob Siverskog
of private data moved to common code. [V2]: Fix build issues found by kbuild test robot by adding static keyword and proper symbol exports. Jacob Siverskog (3): ASoC: pcm179x: Split into core and SPI parts ASoC: pcm179x: Add I2C interface driver ASoC: pcm179x: Support continuous rates

[PATCH v3 1/3] ASoC: pcm179x: Split into core and SPI parts

2016-01-21 Thread Jacob Siverskog
The pcm179x family supports both SPI and I2C for configuration. This patch splits the driver into core and SPI parts, in preparation for I2C support. Reviewed-by: Johan Hovold <jo...@kernel.org> Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- sound/soc/codecs/Kconfi

[PATCH v3 0/3] ASoC: pcm179x: Add I2C support, declare support for continuous rates

2016-01-21 Thread Jacob Siverskog
of private data moved to common code. [V2]: Fix build issues found by kbuild test robot by adding static keyword and proper symbol exports. Jacob Siverskog (3): ASoC: pcm179x: Split into core and SPI parts ASoC: pcm179x: Add I2C interface driver ASoC: pcm179x: Support continuous rates

[PATCH v3 2/3] ASoC: pcm179x: Add I2C interface driver

2016-01-21 Thread Jacob Siverskog
The PCM179x family supports both SPI and I2C. This patch adds support for the I2C interface. Reviewed-by: Johan Hovold <jo...@kernel.org> Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- .../devicetree/bindings/sound/pcm179x.txt | 11 +++- sound/soc/co

[PATCH v3 3/3] ASoC: pcm179x: Support continuous rates

2016-01-21 Thread Jacob Siverskog
/pcm1795.pdf http://www.ti.com/lit/ds/symlink/pcm1796.pdf Reviewed-by: Johan Hovold <jo...@kernel.org> Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- sound/soc/codecs/pcm179x.c | 4 +++- sound/soc/codecs/pcm179x.h | 4 2 files changed, 3 insertions(+), 5 deletions(-)

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Jacob Siverskog
On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet wrote: > On Wed, 2016-01-20 at 16:06 +0100, Jacob Siverskog wrote: >> On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet wrote: >> > On Tue, 2016-01-05 at 15:34 +0100, Jacob Siverskog wrote: >> >> On Tue, Jan 5, 2016 at 3:14

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Jacob Siverskog
On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 15:34 +0100, Jacob Siverskog wrote: >> On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet wrote: > >> > >> > You might build a kernel with KASAN support to get maybe more chances to >>

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Jacob Siverskog
On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Tue, 2016-01-05 at 15:34 +0100, Jacob Siverskog wrote: >> On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > >> > >> > You might build a kernel wi

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-20 Thread Jacob Siverskog
On Wed, Jan 20, 2016 at 4:48 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Wed, 2016-01-20 at 16:06 +0100, Jacob Siverskog wrote: >> On Tue, Jan 5, 2016 at 3:39 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: >> > On Tue, 2016-01-05 at 15:34 +0100, Jacob Sive

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-05 Thread Jacob Siverskog
On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 12:07 +0100, Jacob Siverskog wrote: >> On Mon, Jan 4, 2016 at 4:25 PM, Eric Dumazet wrote: >> > On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: >> >> On Wed, Dec 30, 2015 at 11:

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-05 Thread Jacob Siverskog
On Mon, Jan 4, 2016 at 4:25 PM, Eric Dumazet wrote: > On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: >> On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang wrote: >> > On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog >> > wrote: >> >> On Wed, Dec 3

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-05 Thread Jacob Siverskog
On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Tue, 2016-01-05 at 12:07 +0100, Jacob Siverskog wrote: >> On Mon, Jan 4, 2016 at 4:25 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: >> > On Mon, 2016-01-04 at 10:10 +0100, Jacob Sive

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-05 Thread Jacob Siverskog
On Mon, Jan 4, 2016 at 4:25 PM, Eric Dumazet <eric.duma...@gmail.com> wrote: > On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: >> On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> > On Wed, Dec 30, 2015 at 6:30 A

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-04 Thread Jacob Siverskog
On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang wrote: > On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog > wrote: >> On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote: >>> How often can you trigger this bug ? >> >> Ok. I don't have a good repro to trigger it

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2016-01-04 Thread Jacob Siverskog
On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > On Wed, Dec 30, 2015 at 6:30 AM, Jacob Siverskog > <jacob@teenage.engineering> wrote: >> On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet <eduma...@google.com> wrote: >>> How often

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-30 Thread Jacob Siverskog
On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet wrote: > On Wed, Dec 30, 2015 at 6:14 AM, Jacob Siverskog > wrote: > >> Ok. Thanks for your feedback. How do you believe the issue could be >> solved? Investigating it gives: >> >> static inline void __skb_u

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-30 Thread Jacob Siverskog
On Tue, Dec 29, 2015 at 9:08 PM, David Miller wrote: > From: Rainer Weikusat > Date: Tue, 29 Dec 2015 19:42:36 + > >> Jacob Siverskog writes: >>> This should fix a NULL pointer dereference I encountered (dump >>> below). Since __skb_unlink is called while

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-30 Thread Jacob Siverskog
On Tue, Dec 29, 2015 at 9:08 PM, David Miller <da...@davemloft.net> wrote: > From: Rainer Weikusat <rweiku...@mobileactivedefense.com> > Date: Tue, 29 Dec 2015 19:42:36 + > >> Jacob Siverskog <jacob@teenage.engineering> writes: >>> This should fix a NU

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-30 Thread Jacob Siverskog
On Wed, Dec 30, 2015 at 2:26 PM, Eric Dumazet <eduma...@google.com> wrote: > On Wed, Dec 30, 2015 at 6:14 AM, Jacob Siverskog > <jacob@teenage.engineering> wrote: > >> Ok. Thanks for your feedback. How do you believe the issue could be >> solved? Investigating i

[PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-29 Thread Jacob Siverskog
rom [] (___sys_recvmsg+0x94/0x170) [] (___sys_recvmsg) from [] (__sys_recvmsg+0x3c/0x6c) [] (__sys_recvmsg) from [] (ret_fast_syscall+0x0/0x3c) Code: e5842074 e8930006 e5835000 e5835004 (e5812004) Signed-off-by: Jacob Siverskog --- net/core/datagram.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

2015-12-29 Thread Jacob Siverskog
rom [] (___sys_recvmsg+0x94/0x170) [] (___sys_recvmsg) from [] (__sys_recvmsg+0x3c/0x6c) [] (__sys_recvmsg) from [] (ret_fast_syscall+0x0/0x3c) Code: e5842074 e8930006 e5835000 e5835004 (e5812004) Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- net/core/datagram.c | 4 ++-- 1 file c

[PATCH v3 1/1] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
Silicon Labs support, performing PLL soft reset will only be noticeable if the PLL parameters have been changed. Signed-off-by: Jacob Siverskog Signed-off-by: Jens Rudberg Acked-by: Sebastian Hesselbarth --- drivers/clk/clk-si5351.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/clk/cl

[PATCH v3 0/1] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
Hi! Changes in v3: - Fix multiline comment style Changes in v2: - Output disabling and power down removed in order to prevent breaking systems requiring always-enabled clocks - Cosmetic changes Jacob Jacob Siverskog (1): clk: si5351: Add PLL soft reset drivers/clk/clk-si5351.c | 7

[PATCH v2] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
Silicon Labs support, performing PLL soft reset will only be noticeable if the PLL parameters have been changed. Signed-off-by: Jacob Siverskog Signed-off-by: Jens Rudberg --- drivers/clk/clk-si5351.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si

[PATCH v2] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
it should not be any issues always performing the PLL reset. Changes in v2: - Output disabling and power down removed in order to prevent breaking systems requiring always-enabled clocks - Cosmetic changes Jacob Jacob Siverskog (1): clk: si5351: Add PLL soft reset drivers/clk/clk-si5351.c | 6

Re: [PATCH] clk: si5351: Add setup steps

2015-11-20 Thread Jacob Siverskog
Hi Sebastian! On Thu, Nov 19, 2015 at 10:00 PM, Sebastian Hesselbarth wrote: > On 19.11.2015 14:40, Jacob Siverskog wrote: >> This is according to figure 12 ("I2C Programming Procedure") in >> "Si5351A/B/C Data Sheet" >> (https://www.silabs.com/Suppo

Re: [PATCH] clk: si5351: Add setup steps

2015-11-20 Thread Jacob Siverskog
Hi Marek! Thanks for your feedback. On Thu, Nov 19, 2015 at 3:18 PM, Belisko Marek wrote: > Hi Jacob, > > On Thu, Nov 19, 2015 at 2:40 PM, Jacob Siverskog > wrote: >> This is according to figure 12 ("I2C Programming Procedure") in >> "Si5351A/B/C Data Sh

[PATCH v2] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
Silicon Labs support, performing PLL soft reset will only be noticeable if the PLL parameters have been changed. Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> Signed-off-by: Jens Rudberg <jens@teenage.engineering> --- drivers/clk/clk-si5351.c | 6 ++ 1 file changed, 6 insertions(

[PATCH v2] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
it should not be any issues always performing the PLL reset. Changes in v2: - Output disabling and power down removed in order to prevent breaking systems requiring always-enabled clocks - Cosmetic changes Jacob Jacob Siverskog (1): clk: si5351: Add PLL soft reset drivers/clk/clk-si5351.c | 6

[PATCH v3 0/1] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
Hi! Changes in v3: - Fix multiline comment style Changes in v2: - Output disabling and power down removed in order to prevent breaking systems requiring always-enabled clocks - Cosmetic changes Jacob Jacob Siverskog (1): clk: si5351: Add PLL soft reset drivers/clk/clk-si5351.c | 7

[PATCH v3 1/1] clk: si5351: Add PLL soft reset

2015-11-20 Thread Jacob Siverskog
Silicon Labs support, performing PLL soft reset will only be noticeable if the PLL parameters have been changed. Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> Signed-off-by: Jens Rudberg <jens@teenage.engineering> Acked-by: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com

Re: [PATCH] clk: si5351: Add setup steps

2015-11-20 Thread Jacob Siverskog
Hi Marek! Thanks for your feedback. On Thu, Nov 19, 2015 at 3:18 PM, Belisko Marek <marek.beli...@gmail.com> wrote: > Hi Jacob, > > On Thu, Nov 19, 2015 at 2:40 PM, Jacob Siverskog > <jacob@teenage.engineering> wrote: >> This is according to figure 12 ("I2C Pro

Re: [PATCH] clk: si5351: Add setup steps

2015-11-20 Thread Jacob Siverskog
Hi Sebastian! On Thu, Nov 19, 2015 at 10:00 PM, Sebastian Hesselbarth <sebastian.hesselba...@gmail.com> wrote: > On 19.11.2015 14:40, Jacob Siverskog wrote: >> This is according to figure 12 ("I2C Programming Procedure") in >> "Si5351A/B/C Data Sheet

[PATCH] clk: si5351: Add setup steps

2015-11-19 Thread Jacob Siverskog
Silicon Labs support, performing PLL soft reset will only be noticable if the PLL parameters have been changed. Signed-off-by: Jacob Siverskog Signed-off-by: Jens Rudberg --- drivers/clk/clk-si5351.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/clk/clk-si5351.c b/drivers/cl

[PATCH] clk: si5351: Add setup steps

2015-11-19 Thread Jacob Siverskog
Silicon Labs support, performing PLL soft reset will only be noticable if the PLL parameters have been changed. Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> Signed-off-by: Jens Rudberg <jens@teenage.engineering> --- drivers/clk/clk-si5351.c | 13 + 1 file changed, 13 ins

[PATCH] ti-st: use worker instead of calling st_int_write in wake up

2015-09-11 Thread Jacob Siverskog
Farooq Signed-off-by: Jacob Siverskog --- drivers/misc/ti-st/st_core.c | 18 -- include/linux/ti_wilink_st.h | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index c8c6a36..6e3af8b 100644 --- a/d

[PATCH] ti-st: use worker instead of calling st_int_write in wake up

2015-09-11 Thread Jacob Siverskog
Signed-off-by: Muhammad Hamza Farooq <mfar...@visteon.com> Signed-off-by: Jacob Siverskog <jacob@teenage.engineering> --- drivers/misc/ti-st/st_core.c | 18 -- include/linux/ti_wilink_st.h | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/misc/t