Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-08-02 Thread James Ettle
Hello, On Tue, 2020-07-28 at 18:06 -0500, Bjorn Helgaas wrote: > > I tried to deduce the problem from the code in aspm.c, but I didn't > see the problem. If you have the ability to build a kernel with a > debug patch, can you boot with the patch below and collect the dmesg > log? I've built suc

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-28 Thread James Ettle
On Mon, 2020-07-27 at 16:47 -0500, Bjorn Helgaas wrote: > > I don't see anything in rtsx that enables L0s. Can you collect the > dmesg log when booting with "pci=earlydump"? That will show whether > the BIOS left it this way. The PCI core isn't supposed to do this, > so > if it did, we need to

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-27 Thread James Ettle
On Mon, 2020-07-27 at 09:14 -0500, Bjorn Helgaas wrote: > I don't know the connection between ASPM and package C-states, so I > need to simplify this even more. All I want to do right now is > verify > that if we don't have any outside influences on the ASPM > configuration > (eg, no manual change

Re: rtsx_pci not restoring ASPM state after suspend/resume

2020-07-25 Thread James Ettle
On Fri, 2020-07-24 at 18:13 -0500, Bjorn Helgaas wrote: > > Maybe we should simplify this a little bit more. James, if you don't > touch ASPM config at all, either manually or via udev, does the ASPM > configuration stay the same across suspend/resume? > Yes, it stays the same. Explicitly: Wi

Re: linux-next: Signed-off-by missing for commit in the nfsd tree

2018-02-23 Thread James Ettle
ds" wrote: >On Thu, Feb 22, 2018 at 06:39:43AM +, James Ettle wrote: >> I only really posted this as a demo of a fix. I was hoping someone >who actually knows what they're doing in the kernel would pick it up >and make it proper. > >Whoops, sorry, I didn't r

Re: [PATCH 0/4] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled

2017-12-21 Thread James Ettle
OK, I built a kernel based on: - git clone of git.infradead.org/users/jjs/linux-tpmdd.git taken last night - applying the patch in https://patchwork.kernel.org/patch/10119417/ - stock config-4.14.6-300.fc27.x86_64 + make oldconfig The tpm modules are loaded and the keyboard is working. Note: I w

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-19 Thread James Ettle
s On 19/12/17 13:00, Jarkko Sakkinen wrote: > On Mon, Dec 18, 2017 at 06:26:35PM +, James Ettle wrote: >> The keyboard and touchpad work OK with the patch quoted below and the >> earlier two applied, i.e. the three patches with signatures: >> &g

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-18 Thread James Ettle
The keyboard and touchpad work OK with the patch quoted below and the earlier two applied, i.e. the three patches with signatures: 667dcc75be864ff4c17cf58891853b7393bba3e2 db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 370d45a34dc8914066a995a3a6d6df1953ea9f60 I applied these to a vanilla kernel.org 4.

Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-12 Thread James Ettle
r anything, but /dev/tpm0 is present and have never initialised it. I don't know if anything in Fedora uses it by default if present.] Regards, James. On 12/12/17 11:38, Javier Martinez Canillas wrote: > Hello James, > > On 12/11/2017 08:37 PM, James Ettle wrote: >> Hello, &g

[BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system

2017-12-11 Thread James Ettle
Hello, [First: Apologies if cross-posting from Kernel.org BZ is bad form; my distro BZ advised I post this to your mailing list as well.] Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU breaks PS/2 keyboard and mouse. They just don't respond until after a suspend/resume cycle,