Re: [PATCH 0/2] AFS metadata xattr fixes

On 3/11/2021 9:10 AM, David Howells (dhowe...@redhat.com) wrote: I wonder if it's better to just hide all the afs.* xattrs from listxattr(). It would probably be even better to not use xattrs for this, but I'm not sure what I would use instead. I believe that all of the "afs.*" xattrs should

Re: file metadata via fs API (was: [GIT PULL] Filesystem Information)

On 8/14/2020 1:05 PM, Linus Torvalds (torva...@linux-foundation.org) wrote: > Honestly, I really think you may want an extended [f]statfs(), not > some mount tracking. > > Linus Linus, Thank you for the reply. Perhaps some of the communication disconnect is due to which thread

Re: file metadata via fs API (was: [GIT PULL] Filesystem Information)

On 8/12/2020 2:18 PM, Linus Torvalds (torva...@linux-foundation.org) wrote: > What's wrong with fstatfs()? All the extra magic metadata seems to not > really be anything people really care about. > > What people are actually asking for seems to be some unique mount ID, > and we have 16 bytes of

Re: [GIT PULL afs: Development for 5.4

On 9/19/2019 9:15 AM, Matthew Wilcox wrote: > Why is it organised this way? I mean, yes, technically, rxrpc is a > generic layer-6 protocol that any blah blah blah, but in practice no > other user has come up in the last 37 years, so why bother pretending > one is going to? Just git mv net/rxrpc

Re: [PATCH net] rxrpc: Fix local refcounting

David, Looks good to me. You can add a Reviewed-by line. Thanks. Jeffrey Altman On 8/9/2019 5:47 PM, David Howells wrote: > Fix rxrpc_unuse_local() to handle a NULL local pointer as it can be called > on an unbound socket on which rx->local is not yet set. > > The following reproduced

Re: [PATCH -next] afs: use correct afs_call_type in yfs_fs_store_opaque_acl2

This change is correct. On 8/9/2019 4:43 AM, YueHaibing wrote: > It seems that 'yfs_RXYFSStoreOpaqueACL2' should be use in > yfs_fs_store_opaque_acl2(). > > Fixes: f5e4546347bc ("afs: Implement YFS ACL setting") > Signed-off-by: YueHaibing > --- > fs/afs/yfsclient.c | 2 +- > 1 file changed, 1

Re: [PATCH -next] afs: remove unused variable 'afs_zero_fid'

Confirmed. On 8/9/2019 4:42 AM, YueHaibing wrote: > fs/afs/fsclient.c:18:29: warning: > afs_zero_fid defined but not used [-Wunused-const-variable=] > > It is never used since commit 025db80c9e42 ("afs: Trace > the initiation and completion of client calls") > > Reported-by: Hulk Robot >

Re: [PATCH -next] afs: remove unused variable 'afs_voltypes'

This is true but I believe afs_voltypes should be used in the afs_put_volume() and afs_deactivate_volume() enter() tracing. If it will not be used for those calls then removal is correct. Jeffrey Altman On 8/9/2019 4:40 AM, YueHaibing wrote: > fs/afs/volume.c:15:26: warning: > afs_voltypes