Re: [PATCH v3 2/2] scsi: pm8001: clean up for open brace

On Thu, Apr 8, 2021 at 2:56 PM Luo Jiaxing wrote: > > There are few error about open brace is reported by checkpatch.pl: > > ERROR: that open brace { should be on the previous line > +static struct error_fw flash_error_table[] = > +{ > > So fix them all. > > Signed-off-by: Jianqin Xie >

Re: [PATCH v3 1/2] scsi: pm8001: clean up for white space

On Thu, Apr 8, 2021 at 2:56 PM Luo Jiaxing wrote: > > Some errors are found like below when run checkpatch.pl > > ERROR: space prohibited before that ',' (ctx:WxW) > +int pm8001_mpi_general_event(struct pm8001_hba_info *pm8001_ha , void > *piomb); > > It all about white space, so fix them. > >

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

On Thu, Apr 8, 2021 at 3:06 PM Gioh Kim wrote: > > As the name shows, it checks if strings are equal in case insensitive > manner. > > For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c uses > strncasecmp to check that the input via sysfs is "mi". But it would > work even-if the input is

Re: [PATCH v3] lib/string: Introduce sysfs_streqcase

On Thu, Apr 8, 2021 at 11:34 AM Gioh Kim wrote: > > As the name shows, it checks if strings are equal in case insensitive > manner. > > For example, drivers/infiniband/ulp/rtrs/rtrs-clt-sysfs.c uses > strncasecmp to check that the input via sysfs is "mi". But it would > work even-if the input is

Re: [PATCH][next] scsi: pm80xx: Fix potential infinite loop

On Wed, Apr 7, 2021 at 7:18 PM Martin K. Petersen wrote: > > > Hi Colin! > > > The for-loop iterates with a u8 loop counter i and compares this with > > the loop upper limit of pm8001_ha->max_q_num which is a u32 type. > > There is a potential infinite loop if pm8001_ha->max_q_num is larger > >

Re: [PATCH] scsi: pm8001: avoid -Wrestrict warning

On Tue, Mar 23, 2021 at 1:55 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > On some configurations, gcc warns about overlapping source and > destination arguments to snprintf: > > drivers/scsi/pm8001/pm8001_init.c: In function 'pm8001_request_msix': >

Re: [PATCH] block/rnbd-clt: fix overlapping snprintf arguments

On Tue, Mar 23, 2021 at 1:55 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The -Wrestrict warning (disabled by default) points out undefined > behavior calling snprintf(): > > drivers/block/rnbd/rnbd-clt-sysfs.c: In function 'rnbd_clt_get_path_name': >

Re: [PATCH 22/30] scsi: pm8001: pm80xx_hwi: Fix a bunch of doc-rotted function headers

On Wed, Mar 3, 2021 at 3:47 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm80xx_hwi.c:1427: warning: expecting prototype for > pm8001_chip_init(). Prototype was for pm80xx_chip_init() instead > drivers/scsi/pm8001/pm80xx_hwi.c:1584: warning:

Re: [PATCH 18/30] scsi: pm8001: pm8001_hwi: Fix some misnamed function descriptions

On Wed, Mar 3, 2021 at 3:47 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_hwi.c:1183: warning: expecting prototype for > pm8001_chip_interrupt_enable(). Prototype was for > pm8001_chip_intx_interrupt_enable() instead >

Re: [PATCH 08/30] scsi: pm8001: pm8001_init: Provide function name and fix a misspelling

On Wed, Mar 3, 2021 at 3:46 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_init.c:192: warning: expecting prototype for > tasklet for 64 msi(). Prototype was for pm8001_tasklet() instead > drivers/scsi/pm8001/pm8001_init.c:872: warning:

Re: [PATCH 13/30] scsi: pm8001: pm8001_ctl: Fix incorrectly named functions in headers

On Wed, Mar 3, 2021 at 3:47 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_ctl.c:313: warning: expecting prototype for > pm8001_ctl_sas_address_show(). Prototype was for > pm8001_ctl_host_sas_address_show() instead >

Re: [PATCH 11/30] scsi: pm8001: pm8001_sas: Provide function name 'pm8001_I_T_nexus_reset()' in header

On Wed, Mar 3, 2021 at 3:47 PM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_sas.c:989: warning: expecting prototype for and > hard reset for(). Prototype was for pm8001_I_T_nexus_reset() instead > > Cc: Jack Wang > Cc: "James E.J.

Re: [PATCH v3 09/19] scsi: pm80xx: Pass gfp_t flags to libsas event notifiers

On Mon, Jan 18, 2021 at 11:10 AM Ahmed S. Darwish wrote: > > Use the new libsas event notifiers API, which requires callers to > explicitly pass the gfp_t memory allocation flags. > > Call chain analysis, pm8001_hwi.c: > > pm8001_interrupt_handler_msix() || pm8001_interrupt_handler_intx() || >

Re: [PATCH v3 02/19] scsi: libsas and users: Remove notifier indirection

On Mon, Jan 18, 2021 at 11:10 AM Ahmed S. Darwish wrote: > > From: John Garry > > LLDDs report events to libsas with .notify_port_event and > .notify_phy_event callbacks. > > These callbacks are fixed and so there is no reason why the functions > cannot be called directly, so do that. > > This

Re: [PATCH v3 15/19] scsi: pm80xx: Switch back to original libsas event notifiers

On Mon, Jan 18, 2021 at 11:11 AM Ahmed S. Darwish wrote: > > libsas event notifiers required an extension where gfp_t flags must be > explicitly passed. For bisectability, a temporary _gfp() variant of such > functions were added. All call sites then got converted use the _gfp() > variants and

Re: [PATCH v3 01/19] Documentation: scsi: libsas: Remove notify_ha_event()

On Mon, Jan 18, 2021 at 11:10 AM Ahmed S. Darwish wrote: > > The ->notify_ha_event() hook has long been removed from the libsas event > interface. > > Remove it from documentation. > > Fixes: 042ebd293b86 ("scsi: libsas: kill useless ha_event and do some > cleanup") > Signed-off-by: Ahmed S.

Re: [PATCH] scsi: pm80xx: switch from 'pci_' to 'dma_' API

On Sun, Jan 17, 2021 at 2:24 PM Christophe JAILLET wrote: > > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When

Re: [PATCH][next] scsi: pm80xx: clean up indentation of a code block

On Fri, Jan 15, 2021 at 10:58 AM Colin King wrote: > > From: Colin Ian King > > A block of code is indented one level too deeply, clean this > up. > > Addresses-Coverity: ("Indentation does not match nesting level") > Signed-off-by: Colin Ian King Acked-by: Jack Wang > --- >

Re: [RFC/RFT PATCH] scsi: pm8001: Expose HW queues for pm80xx hw

Hi John, On Tue, Jan 5, 2021 at 12:21 PM John Garry wrote: > > In commit 05c6c029a44d ("scsi: pm80xx: Increase number of supported > queues"), support for 80xx chip was improved by enabling multiple HW > queues. > > In this, like other SCSI MQ HBA drivers, the HW queues were not exposed > to

Re: [PATCH] block/rnbd-clt: improve find_or_create_sess() return check

On Sun, Jan 10, 2021 at 10:58 PM wrote: > > From: Tom Rix > > clang static analysis reports this problem > > rnbd-clt.c:1212:11: warning: Branch condition evaluates to a > garbage value > else if (!first) > ^~ > > This is triggered in the

Re: drivers/block/rnbd/rnbd-clt.c:387:2: error: implicit declaration of function 'sg_free_table_chained'

On Fri, Jan 8, 2021 at 7:46 AM kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: f5e6c330254ae691f6d7befe61c786eb5056007e > commit: 5a1328d0c3a757cdd8c65f4dfe0a02502a5810bc block/rnbd-clt: Dynamically > allocate sglist for

Re: [PATCH] block/rnbd: Adding name to the Contributors List

Hi, Jens On Fri, Dec 18, 2020 at 3:53 PM Jens Axboe wrote: > > On 12/17/20 11:46 PM, Jinpu Wang wrote: > > Hi Jens, > > > > On Thu, Dec 17, 2020 at 6:44 PM swapnil ingle > > wrote: > >> > >> Adding linux-r...@vger.kernel.org > >> >

Re: [PATCH] block/rnbd: Adding name to the Contributors List

Hi Jens, On Thu, Dec 17, 2020 at 6:44 PM swapnil ingle wrote: > > Adding linux-r...@vger.kernel.org > > On Fri, Nov 27, 2020 at 1:54 PM Danil Kipnis > wrote: >> >> On Fri, Nov 27, 2020 at 1:31 PM Swapnil Ingle wrote: >> > >> > Adding name to the Contributors List >> > >> > Signed-off-by:

Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

On Mon, Dec 7, 2020 at 4:01 PM Jens Axboe wrote: > > On 12/7/20 7:54 AM, Colin King wrote: > > From: Colin Ian King > > > > Currently in the case where dev->blk_symlink_name fails to be allocates > > the error return path attempts to set an end-of-string character to > > the unallocated

Re: [PATCH] block/rnbd: Adding name to the Contributors List

On Fri, Nov 27, 2020 at 1:31 PM Swapnil Ingle wrote: > > Adding name to the Contributors List > > Signed-off-by: Swapnil Ingle Hi, Swapnil, Thanks for your past contributions, sorry for missing your name on the list. Acked-by: Jack Wang > --- > drivers/block/rnbd/README | 1 + > 1 file

Re: [PATCH] block/rnbd: server: Fix error return code in rnbd_srv_create_dev_sysfs()

On Wed, Nov 25, 2020 at 1:47 PM Wang ShaoBo wrote: > > Fix to return -ENOMEM error code from the error handling case where > kobject_create_and_add() failed instead of 0 in rnbd_srv_create_dev_sysfs(), > as done elsewhere in this function. > > Signed-off-by: Wang ShaoBo Thanks Shaobo, we have a

Re: [PATCH][next] scsi: pm8001: remove space in a debug message

On Tue, Nov 24, 2020 at 10:38 AM Colin King wrote: > > From: Colin Ian King > > There are two words that need separating with a space in a > pm8001_dbg message. Fix it. > > Signed-off-by: Colin Ian King Acked-by: Jack Wang Thanks > --- > drivers/scsi/pm8001/pm8001_hwi.c | 2 +- > 1 file

Re: [PATCH 2/2] scsi: pm8001: Fix misindentation

On Tue, Nov 24, 2020 at 5:36 AM Joe Perches wrote: > > kernel robot reported a misindentation of a goto. > > Fix it. > > At the same time, use a temporary for a repeated entry in the same block > to reduce visual noise. > > Reported-by: kernel test robot > Signed-off-by: Joe Perches Acked-by:

Re: [PATCH 1/2] scsi: pm8001: Convert pm8001_printk to pm8001_info

On Tue, Nov 24, 2020 at 5:36 AM Joe Perches wrote: > > Use the more common logging style. > > Signed-off-by: Joe Perches Acked-by: Jack Wang Thanks! > --- > drivers/scsi/pm8001/pm8001_init.c | 12 ++-- > drivers/scsi/pm8001/pm8001_sas.c | 4 ++-- > drivers/scsi/pm8001/pm8001_sas.h |

Re: [PATCH 2/2] scsi: pm8001: Make implicit use of pm8001_ha in pm8001_printk explicit

On Sat, Nov 21, 2020 at 12:16 AM Joe Perches wrote: > > Make the pm8001_printk macro take an explicit HBA instead of > assuming the existence of an unspecified pm8001_ha argument > > Miscellanea: > > o Add pm8001_ha to the few uses of pm8001_printk > o Add HBA to the pm8001_dbg macro call to

Re: [PATCH] scsi: pm8001: remove casting kcalloc

On Fri, Nov 20, 2020 at 9:36 AM Xu Wang wrote: > > Remove casting the values returned by kcalloc. > > Signed-off-by: Xu Wang Acked-by: Jack Wang Thanks Xu! > --- > drivers/scsi/pm8001/pm8001_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 1/1] scsi: pm8001: pm8001_hwi: Remove unused variable 'value'

On Mon, Nov 16, 2020 at 11:41 AM Lee Jones wrote: > > Hasn't been used since 2009. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_hwi.c: In function ‘mpi_set_phys_g3_with_ssc’: > drivers/scsi/pm8001/pm8001_hwi.c:415:6: warning: variable ‘value’ set but >

Re: [PATCH v2 28/39] docs: ABI: fix syntax to be parsed using ReST notation

On Fri, Oct 30, 2020 at 8:41 AM Mauro Carvalho Chehab wrote: > > There are a number of new changes at the ABI files that cause > them to produce warnings when generating ABI output. > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab > --- > .../ABI/stable/sysfs-driver-firmware-zynqmp | 62

Re: [PATCH v3 17/28] scsi: pm_8001: Drop PCI Wakeup calls from .resume

On Thu, Oct 1, 2020 at 2:30 PM Vaibhav Gupta wrote: > > The driver calls pci_enable_wake(, false) in pm8001_pci_resume(), and > there is no corresponding pci_enable_wake(, true) in > pm8001_pci_suspend(). Either it should do enable-wake the device in > .suspend() or should not invoke

Re: [PATCH 2/2] RDMA/rtrs: check before free

On Thu, Oct 1, 2020 at 9:27 AM Gioh Kim wrote: > > From: Gioh Kim > > If rtrs_iu_alloc failed to allocate buffer or map dma, > there are some allocated addresses and some NULL addresses > in the array. rtrs_iu_free should check data before free. > > Signed-off-by: Gioh Kim > --- >

Re: [PATCH 1/2] RDMA/rtrs: remove unnecessary argument dir of rtrs_iu_free

On Thu, Oct 1, 2020 at 9:26 AM Gioh Kim wrote: > > From: Gioh Kim > > The direction of DMA operation is already in the rtrs_iu. > > Signed-off-by: Gioh Kim Looks fine to me! Acked-by: Jack Wang > --- > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 14 ++ >

Re: [PATCH] block/rnbd: send_msg_close if any error occurs after send_msg_open

On Fri, Sep 18, 2020 at 10:18 AM Jinpu Wang wrote: > > On Fri, Sep 18, 2020 at 9:24 AM Gioh Kim wrote: > > > > From: Gioh Kim > > > > After send_msg_open is done, send_msg_close should be done > > if any error occurs and it is necessary to recover > &

Re: [PATCH] RDMA/rtrs: remove unused field of rtrs_iu

On Wed, Sep 30, 2020 at 3:14 PM Gioh Kim wrote: > > From: Gioh Kim > > list field is not used anywhere > > Signed-off-by: Gioh Kim thanks, Gioh! Acked-by: Jack Wang > --- > drivers/infiniband/ulp/rtrs/rtrs-pri.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] block/rnbd: send_msg_close if any error occurs after send_msg_open

On Fri, Sep 18, 2020 at 9:24 AM Gioh Kim wrote: > > From: Gioh Kim > > After send_msg_open is done, send_msg_close should be done > if any error occurs and it is necessary to recover > what has been done. > > Signed-off-by: Gioh Kim Looks good to me! Thanks! Acked-by: Jack Wang > --- >

Re: [RFC] pcie hotplug doesn't work with kernel 4.19

Hi Lukas, see reply below On Wed, Sep 16, 2020 at 7:48 AM Lukas Wunner wrote: > > On Tue, Sep 15, 2020 at 04:15:15PM +0200, Jinpu Wang wrote: > > We are testing PCIe nvme SSD hotplug, it works out of box with kernel > > 5.4.62, > > dmesg during the hotplug: > [...] &

[RFC] pcie hotplug doesn't work with kernel 4.19

C=m CONFIG_HOTPLUG_PCI_SHPC=y CONFIG_HOTPLUG_PCI_PCIE=y Thanks in advance! -- Jinpu Wang Linux Kernel Developer Application Support (IONOS Cloud) 1&1 IONOS SE | Greifswalder Str. 207 | 10405 Berlin | Germany Phone: E-mail: jinpu.w...@cloud.ionos.com | Web: www.ionos.de Hauptsitz Mo

Re: [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort

On Sun, Aug 23, 2020 at 11:15 AM Dinghao Liu wrote: > > When pm8001_tag_alloc() fails, task should be freed just > like what we've done in the subsequent error paths. > > Signed-off-by: Dinghao Liu Thanks! Acked-by: Jack Wang > --- > drivers/scsi/pm8001/pm8001_sas.c | 2 +- > 1 file changed, 1

Re: [PATCH] block/rnbd: Ensure err is always initialized in process_rdma

On Tue, Aug 18, 2020 at 8:50 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/block/rnbd/rnbd-srv.c:150:6: warning: variable 'err' is used > uninitialized whenever 'if' condition is true > [-Wsometimes-uninitialized] > if (IS_ERR(bio)) { > ^~~ >

Re: [PATCH] block: rnbd: rnbd-srv: silence uninitialized variable warning

On Tue, Aug 18, 2020 at 7:30 AM Nathan Chancellor wrote: > > On Tue, Aug 18, 2020 at 12:03:18AM -0400, Brooke Basile wrote: > > Clang warns: > > drivers/block/rnbd/rnbd-srv.c:150:6: warning: variable 'err' is used > > uninitialized whenever 'if' condition is true > >

Re: [PATCH v3] block: check queue's limits.discard_granularity in __blkdev_issue_discard()

Hi Coly, one question below: Coly Li 于2020年8月5日周三 上午8:36写道： > > If create a loop device with a backing NVMe SSD, current loop device > driver doesn't correctly set its queue's limits.discard_granularity and > leaves it as 0. If a discard request at LBA 0 on this loop device, in >

Re: [PATCH v2 10/15] scsi: pm_8001: use generic power management

On Mon, Jul 20, 2020 at 3:38 PM Vaibhav Gupta wrote: > > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do

Re: [PATCH v2 10/24] scsi: pm8001: pm8001_ctl: Provide descriptions for the many undocumented 'attr's

On Mon, Jul 13, 2020 at 10:00 AM Lee Jones wrote: > > ... even if they are completely unused. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_ctl.c:56: warning: Function parameter or member > 'attr' not described in 'pm8001_ctl_mpi_interface_rev_show' >

Re: [PATCH 27/30] scsi: pm8001: pm8001_init: Demote obvious misuse of kerneldoc and update others

On Wed, Jul 8, 2020 at 2:03 PM Lee Jones wrote: > > More bitrot issues with function documentation not keeping up with API > changes. > > Fixes the following W=1 kernel build warning(s): > > drivers/scsi/pm8001/pm8001_init.c:64: warning: cannot understand function > prototype: 'const struct

Re: [PATCH -next] RDMA/rtrs: fix potential resources leaks

Hi, Bo, On Fri, Jun 19, 2020 at 3:10 PM Bo YU wrote: > > Dev is returned from allocation function kzalloc but it does not > free it in out_err path. If allocation failed, kzalloc return NULL, nothing to free. > > Detected by CoverityScan, CID# 1464569: (Resource leak) > > Fixes:

Re: [BUG] divide error select_idle_sibling+0x36b

Hi Peter, On Tue, Jun 16, 2020 at 3:15 PM Peter Zijlstra wrote: > > On Tue, Jun 16, 2020 at 03:07:00PM +0200, Jinpu Wang wrote: > > > [7623813.970839] CPU: 10 PID: 46544 Comm: qemu-2.7 Tainted: G > > O4.14.154-1-pserver #4.14.154-1.1~deb9 > > Please try on a kerne

[BUG] divide error select_idle_sibling+0x36b

[14792.092598] TSC found unstable after boot, most likely due to broken BIOS. Use 'tsc=unstable'. [14791.924432] sched_clock: Marking unstable (14792681905573, -589293039)<-(14792645239415, -552646967) [14792.093494] clocksource: Switched to clocksource hpet Regards! -- Jinpu Wang Linux Ke

Re: KVM guest freeze on Linux > 4.19

Garry Filakhtov 于2020年6月12日周五 上午8:38写道： > > Good time of the day, > > Hope you all are staying safe during these challenging times. > > I have been struggling with KVM guest freezes after the upgrade from > 4.19 LTS to 5.4 LTS. > > Searching through the internet lead me to >

Re: [PATCH] RDMA/rtrs: client: Fix function return on success

On Tue, May 19, 2020 at 6:16 PM Bart Van Assche wrote: > > On 2020-05-19 09:13, Gustavo A. R. Silva wrote: > > The function should return 0 on success, instead of err. > > > > Addresses-Coverity-ID: 1493753 ("Identical code for different branches") > > Fixes: 6a98d71daea1 ("RDMA/rtrs: client:

Re: [PATCH 4.14 00/65] 4.14.150-stable review

Greg Kroah-Hartman 于2019年10月17日周四 下午11:56写道： > > This is the start of the stable review cycle for the 4.14.150 release. > There are 65 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH v3 18/26] scsi: pm80xx: Use PCI_STD_NUM_BARS

On Mon, Sep 16, 2019 at 10:47 PM Denis Efremov wrote: > > Replace the magic constant (6) with define PCI_STD_NUM_BARS representing > the number of PCI BARs. > > Cc: Jack Wang > Cc: "James E.J. Bottomley" > Signed-off-by: Denis Efremov Looks fine, thanks! Acked-by: Jack Wang > --- >

Re: Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

On Wed, Aug 7, 2019 at 2:35 PM Jinpu Wang wrote: > > On Wed, Aug 7, 2019 at 8:36 AM Jinpu Wang wrote: > > > > On Wed, Aug 7, 2019 at 1:40 AM NeilBrown wrote: > > > > > > On Tue, Aug 06 2019, Jinpu Wang wrote: > > > > > > >

Re: [PATCH 4.19 00/91] 4.19.67-stable review

Greg Kroah-Hartman 于2019年8月14日周三 下午7:10写道： > > This is the start of the stable review cycle for the 4.19.67 release. > There are 91 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

On Wed, Aug 7, 2019 at 8:36 AM Jinpu Wang wrote: > > On Wed, Aug 7, 2019 at 1:40 AM NeilBrown wrote: > > > > On Tue, Aug 06 2019, Jinpu Wang wrote: > > > > > On Tue, Aug 6, 2019 at 9:54 AM Jinpu Wang > > > wrote: > > >>

Re: Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

On Wed, Aug 7, 2019 at 1:40 AM NeilBrown wrote: > > On Tue, Aug 06 2019, Jinpu Wang wrote: > > > On Tue, Aug 6, 2019 at 9:54 AM Jinpu Wang > > wrote: > >> > >> On Tue, Aug 6, 2019 at 1:46 AM NeilBrown wrote: > >> > > >> >

Re: Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

On Tue, Aug 6, 2019 at 9:54 AM Jinpu Wang wrote: > > On Tue, Aug 6, 2019 at 1:46 AM NeilBrown wrote: > > > > On Mon, Aug 05 2019, Jinpu Wang wrote: > > > > > Hi Neil, > > > > > > For the md higher write IO latency problem, I bisected it to the

Re: Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

On Tue, Aug 6, 2019 at 1:46 AM NeilBrown wrote: > > On Mon, Aug 05 2019, Jinpu Wang wrote: > > > Hi Neil, > > > > For the md higher write IO latency problem, I bisected it to these commits: > > > > 4ad23a97 MD: use per-cpu counter for writes_pendi

Bisected: Kernel 4.14 + has 3 times higher write IO latency than Kernel 4.4 with raid1

Hi Neil, For the md higher write IO latency problem, I bisected it to these commits: 4ad23a97 MD: use per-cpu counter for writes_pending 210f7cd percpu-refcount: support synchronous switch to atomic mode. Do you maybe have an idea? How can we fix it? Regards, Jack Wang git bisect log: git

Re: Kernel 4.14 + has 100 times higher IO latency than Kernel 4.4 with raid1

On Fri, Aug 2, 2019 at 9:52 PM Paul Menzel wrote: > > Dear Jinpu, > > > On 02.08.19 16:48, Jinpu Wang wrote: > > > We found a problem regarding much higher IO latency when running > > kernel 4.4.131 compare to 4.14.133, tried with latest upstream > > 5.3-

Kernel 4.14 + has 100 times higher IO latency than Kernel 4.4 with raid1

Hi All, We found a problem regarding much higher IO latency when running kernel 4.4.131 compare to 4.14.133, tried with latest upstream 5.3-rc2, same result. Reproducer: 1 create md raid1 with 2 ram disks: sudo mdadm -C /dev/md0 -l1 -n2 -e1.2 --bitmap=internal /dev/ram[0-1] 2 run fio command

Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc

On Thu, Aug 1, 2019 at 12:22 AM Colin King wrote: > > From: Colin Ian King > > There are several occasions where variable rc is being initialized > with a value that is never read and error is being re-assigned a > little later on. Clean up the code by removing rc entirely and > just returning

Re: [PATCH] scsi: libsas, lldds: Use dev_is_expander()

On Thu, Jun 6, 2019 at 3:35 AM Jason Yan wrote: > > > > On 2019/6/6 0:12, John Garry wrote: > > Many times in libsas, and in LLDDs which use libsas, the check for an > > expander device is re-implemented or open coded. > > > > Use dev_is_expander() instead. We rename this from > >

Re: Is 2nd Generation Intel(R) Xeon(R) Processors (Formerly Cascade Lake) affected by MDS

gt;> On Fri, May 24, 2019 at 03:19:34PM +0200, Jinpu Wang wrote: > >> Resend with plain text, and remove confidential unnecessary signature. > >> sorry for spam. > >> > >> Hi Thomas, hi Greg, hi Tony, hi Arjan, hi other expert on the list > >> > >

Is 2nd Generation Intel(R) Xeon(R) Processors (Formerly Cascade Lake) affected by MDS

Resend with plain text, and remove confidential unnecessary signature. sorry for spam. Hi Thomas, hi Greg, hi Tony, hi Arjan, hi other expert on the list I noticed on our Cascade lake with 4.14.120, the kernel is reporting vulnerable: jwang@ps401a-912:~$ head

Is 2nd Generation Intel(R) Xeon(R) Processors (Formerly Cascade Lake) affected by MDS

Resend with plain text, sorry for spam. Hi Thomas, hi Greg, hi Tony, hi Arjan, hi other expert on the list I noticed on our Cascade lake with 4.14.120, the kernel is reporting vulnerable: jwang@ps401a-912:~$ head /sys/devices/system/cpu/vulnerabilities/mds Vulnerable: Clear CPU buffers

Re: [PATCH 4.14 067/115] crypto: testmgr - add AES-CFB tests

snip > > > > Can you drop the patch? > > Yes, now dropped. Sasha, I think I did this same thing in the past :) Thanks, I remember I probably reported same thing in the past too :) Jack

Re: [PATCH 4.14 067/115] crypto: testmgr - add AES-CFB tests

Hi Greg, This patch causes build failure for me: In file included from crypto/testmgr.c:54: crypto/testmgr.h:16081:4: error: 'const struct cipher_testvec' has no member named 'ptext' .ptext = "\x6b\xc1\xbe\xe2\x2e\x40\x9f\x96" ^ crypto/testmgr.h:16089:4: error: 'const struct

Re: [PATCH] scsi: pm8001: clean up structurally dead code when PM8001_USE_MSIX is defined

On Fri, Mar 29, 2019 at 12:43 AM Colin King wrote: > > From: Colin Ian King > > When macro PM8001_USE_MSIX is defined there are redundant dead code > calls to pm8001_chip_intx_interrupt_{enable|disable}. Clean this up > by compiling in the appropriate enable/disable handlers for the > defined

Re: [PATCH 4.14 000/101] 4.14.92-stable review

Greg Kroah-Hartman 于2019年1月8日周二 下午1:28写道： > > On Mon, Jan 07, 2019 at 08:59:12PM -0800, Guenter Roeck wrote: > > Should all now be fixed up. > > I hope, this set of releases has been a pain... > > greg k-h I had build failure below, looks related to 0fe69354b888 ("crypto: testmgr - add AES-CFB

Re: Shaohua Li

Guoqing Jiang 于2019年1月3日周四 上午4:16写道： > > > > On 1/3/19 1:13 AM, Jens Axboe wrote: > > Hi, > > > > I've got some very sad news to share with you - over Christmas, Shaohua > > Li passed away after battling cancer for most of last year. > > It is really a sad news and a big lost for the community

Re: [PATCH 6/8] scsi: pm80xx: reduce indentation

On Sun, Dec 30, 2018 at 5:29 PM Julia Lawall wrote: > > Delete tab aligning a statement with the right hand side of a > preceding assignment rather than the left hand side. > > Found with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, Julia. Acked-by: Jack Wang > > --- >

Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch

+cc Greg, stable Greensky, James J 于2018年12月21日周五 上午11:48写道： > > Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in > pipe mode") broke the LT 4.14 branch when using event groups in pipe-mode. > > # perf record -e '{cycles,instructions,branches}' -- sleep 4 | perf

Re: [PATCH 4.14 00/72] 4.14.90-stable review

> From: Greg Kroah-Hartman > Date: 2018年12月20日周四 上午10:39 > Subject: [PATCH 4.14 00/72] 4.14.90-stable review > To: > Cc: Greg Kroah-Hartman , > , , > , , , > , , > > > > This is the start of the stable review cycle for the 4.14.90 release. > There are 72 patches in this series, all will be

Re: [PATCH] md/bitmap: use mddev_suspend/resume instead of ->quiesce()

On Mon, Oct 8, 2018 at 5:24 PM Jack Wang wrote: > > From: Jack Wang > > After 9e1cc0a54556 ("md: use mddev_suspend/resume instead of ->quiesce()") > We still have similar left in bitmap functions. > > Replace quiesce() with mddev_suspend/resume. > > Also move md_bitmap_create out of

Re: [PATCH] md/bitmap: use mddev_suspend/resume instead of ->quiesce()

On Mon, Oct 8, 2018 at 5:24 PM Jack Wang wrote: > > From: Jack Wang > > After 9e1cc0a54556 ("md: use mddev_suspend/resume instead of ->quiesce()") > We still have similar left in bitmap functions. > > Replace quiesce() with mddev_suspend/resume. > > Also move md_bitmap_create out of

Re: [PATCH] lib: memcmp optimization

On Wed, Oct 10, 2018 at 1:13 AM Andrew Morton wrote: > > On Tue, 9 Oct 2018 16:28:11 +0200 Jack Wang wrote: > > > From: Florian-Ewald Mueller > > > > During testing, I have configured 128 md/raid1's and, while under > > heavy IO, I started a check on each of them > > (echo check >

Re: [PATCH] lib: memcmp optimization

On Wed, Oct 10, 2018 at 1:13 AM Andrew Morton wrote: > > On Tue, 9 Oct 2018 16:28:11 +0200 Jack Wang wrote: > > > From: Florian-Ewald Mueller > > > > During testing, I have configured 128 md/raid1's and, while under > > heavy IO, I started a check on each of them > > (echo check >

Re: [PATCH] md/bitmap: use mddev_suspend/resume instead of ->quiesce()

On Fri, Sep 28, 2018 at 8:30 PM Shaohua Li wrote: > > On Thu, Sep 27, 2018 at 10:07:57AM +0200, Jack Wang wrote: > > From: Jack Wang > > > > After 9e1cc0a54556 ("md: use mddev_suspend/resume instead of ->quiesce()") > > We still have similar left in bitmap functions. > > > > Replace quiesce()

Re: [PATCH] md/bitmap: use mddev_suspend/resume instead of ->quiesce()

On Fri, Sep 28, 2018 at 8:30 PM Shaohua Li wrote: > > On Thu, Sep 27, 2018 at 10:07:57AM +0200, Jack Wang wrote: > > From: Jack Wang > > > > After 9e1cc0a54556 ("md: use mddev_suspend/resume instead of ->quiesce()") > > We still have similar left in bitmap functions. > > > > Replace quiesce()

Re: [PATCH] x86/kvm/vmx: Fix GPF on reading vmentry_l1d_flush

> From: MINOURA Makoto / 箕浦 真 > Date: 2018年8月22日周三 上午9:50 > Subject: [PATCH] x86/kvm/vmx: Fix GPF on reading vmentry_l1d_flush > To: > Cc: > > > > When EPT is not enabled, reading > /sys/module/kvm_intel/parameters/vmentry_l1d_flush causes > general protection fault in vmentry_l1d_flush_get()

Re: [PATCH] x86/kvm/vmx: Fix GPF on reading vmentry_l1d_flush

> From: MINOURA Makoto / 箕浦 真 > Date: 2018年8月22日周三 上午9:50 > Subject: [PATCH] x86/kvm/vmx: Fix GPF on reading vmentry_l1d_flush > To: > Cc: > > > > When EPT is not enabled, reading > /sys/module/kvm_intel/parameters/vmentry_l1d_flush causes > general protection fault in vmentry_l1d_flush_get()

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Mon, Aug 20, 2018 at 4:47 PM Thomas Gleixner wrote: > > On Mon, 20 Aug 2018, Jinpu Wang wrote: > > On Mon, Aug 20, 2018 at 3:02 PM Thomas Gleixner wrote: > > > That works, but we might as well force 'select HOTPLUG_CPU if SMP' so the > > > L1TF mi

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Mon, Aug 20, 2018 at 4:47 PM Thomas Gleixner wrote: > > On Mon, 20 Aug 2018, Jinpu Wang wrote: > > On Mon, Aug 20, 2018 at 3:02 PM Thomas Gleixner wrote: > > > That works, but we might as well force 'select HOTPLUG_CPU if SMP' so the > > > L1TF mi

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Mon, Aug 20, 2018 at 3:02 PM Thomas Gleixner wrote: > > On Mon, 20 Aug 2018, Jinpu Wang wrote: > > > On Sat, Aug 18, 2018 at 2:50 PM Thomas Gleixner wrote: > > > > > > On Fri, 17 Aug 2018, Greg Kroah-Hartman wrote: > > > > On Fri, Aug 1

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Mon, Aug 20, 2018 at 3:02 PM Thomas Gleixner wrote: > > On Mon, 20 Aug 2018, Jinpu Wang wrote: > > > On Sat, Aug 18, 2018 at 2:50 PM Thomas Gleixner wrote: > > > > > > On Fri, 17 Aug 2018, Greg Kroah-Hartman wrote: > > > > On Fri, Aug 1

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Sat, Aug 18, 2018 at 2:50 PM Thomas Gleixner wrote: > > On Fri, 17 Aug 2018, Greg Kroah-Hartman wrote: > > On Fri, Aug 17, 2018 at 02:39:00PM +0200, Jinpu Wang wrote: > > > > > > I found the problem, CONFIG_HOTPLUG_SMT is enable due to CONFIG_SMP, >

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Sat, Aug 18, 2018 at 2:50 PM Thomas Gleixner wrote: > > On Fri, 17 Aug 2018, Greg Kroah-Hartman wrote: > > On Fri, Aug 17, 2018 at 02:39:00PM +0200, Jinpu Wang wrote: > > > > > > I found the problem, CONFIG_HOTPLUG_SMT is enable due to CONFIG_SMP, >

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Thu, Aug 16, 2018 at 6:48 PM Jinpu Wang wrote: > > On Thu, Aug 16, 2018 at 6:39 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Aug 16, 2018 at 06:28:59PM +0200, Jinpu Wang wrote: > > > On Thu, Aug 16, 2018 at 5:51 PM Greg Kroah-Hartman > > > wrote: >

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Thu, Aug 16, 2018 at 6:48 PM Jinpu Wang wrote: > > On Thu, Aug 16, 2018 at 6:39 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Aug 16, 2018 at 06:28:59PM +0200, Jinpu Wang wrote: > > > On Thu, Aug 16, 2018 at 5:51 PM Greg Kroah-Hartman > > > wrote: >

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Thu, Aug 16, 2018 at 6:39 PM Greg Kroah-Hartman wrote: > > On Thu, Aug 16, 2018 at 06:28:59PM +0200, Jinpu Wang wrote: > > On Thu, Aug 16, 2018 at 5:51 PM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Aug 16, 2018 at 05:43:23PM +0200, Jinpu Wa

Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63

On Thu, Aug 16, 2018 at 6:39 PM Greg Kroah-Hartman wrote: > > On Thu, Aug 16, 2018 at 06:28:59PM +0200, Jinpu Wang wrote: > > On Thu, Aug 16, 2018 at 5:51 PM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Aug 16, 2018 at 05:43:23PM +0200, Jinpu Wa

Re: [PATCH 4.14 000/104] 4.14.63-stable review

> From: Greg Kroah-Hartman > Date: 2018年8月15日周三 上午8:15 > Subject: Re: [PATCH 4.14 000/104] 4.14.63-stable review > To: > Cc: , , > , , , > , , > > > > On Tue, Aug 14, 2018 at 07:16:14PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.63 release. >

Re: [PATCH 4.14 000/104] 4.14.63-stable review

> From: Greg Kroah-Hartman > Date: 2018年8月15日周三 上午8:15 > Subject: Re: [PATCH 4.14 000/104] 4.14.63-stable review > To: > Cc: , , > , , , > , , > > > > On Tue, Aug 14, 2018 at 07:16:14PM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.63 release. >

Re: [PATCH] scsi: pm80xx: fix spelling mistake "UNSORPORTED" -> "SUPPORTED"

On Sat, May 26, 2018 at 4:42 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pm8001_printk message text; also > I believe NOT_UNSUPPORTED should probably be NOT_SUPPORTED. Also > fix the indent of the

Re: [PATCH] scsi: pm80xx: fix spelling mistake "UNSORPORTED" -> "SUPPORTED"

On Sat, May 26, 2018 at 4:42 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in pm8001_printk message text; also > I believe NOT_UNSUPPORTED should probably be NOT_SUPPORTED. Also > fix the indent of the pm8001_printk statement. > > Signed-off-by: Colin Ian King

Re: [PATCH] md/raid1: add error handling of read error from FailFast device

On Wed, May 9, 2018 at 10:58 AM, Jack Wang wrote: > -- Forwarded message -- > From: Gioh Kim > Date: 2018-05-02 13:08 GMT+02:00 > Subject: [PATCH] md/raid1: add error handling of read error from FailFast > device > To:

  1   2   >