Signed-off-by: Jongsung Kim
---
Documentation/devicetree/bindings/net/stmmac.txt | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/stmmac.txt
b/Documentation/devicetree/bindings/net/stmmac.txt
index cb694062afff..988e56781fbd
On 05/04/2018 10:11 PM, Guenter Roeck wrote:
> On 05/03/2018 11:05 PM, Jongsung Kim wrote:
>> Add restart handler for SP805 watchdog so that the driver can be
>> used to reboot the system.
>>
>> Signed-off-by: Jongsung Kim <neidhard@lge.com>
>>
On 05/04/2018 10:11 PM, Guenter Roeck wrote:
> On 05/03/2018 11:05 PM, Jongsung Kim wrote:
>> Add restart handler for SP805 watchdog so that the driver can be
>> used to reboot the system.
>>
>> Signed-off-by: Jongsung Kim
>> Cc: Guenter Roec
Add restart handler for SP805 watchdog so that the driver can be
used to reboot the system.
Signed-off-by: Jongsung Kim <neidhard@lge.com>
Cc: Guenter Roeck <li...@roeck-us.net>
---
drivers/watchdog/sp805_wdt.c | 14 ++
1 file changed, 14 insertions(+)
diff --g
Add restart handler for SP805 watchdog so that the driver can be
used to reboot the system.
Signed-off-by: Jongsung Kim
Cc: Guenter Roeck
---
drivers/watchdog/sp805_wdt.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog
Add restart handler for SP805 watchdog so that the driver can be
used to reboot the system.
Signed-off-by: Jongsung Kim <neidhard@lge.com>
Cc: Guenter Roeck <li...@roeck-us.net>
---
drivers/watchdog/sp805_wdt.c | 13 +
1 file changed, 13 insertions(+)
diff --g
Add restart handler for SP805 watchdog so that the driver can be
used to reboot the system.
Signed-off-by: Jongsung Kim
Cc: Guenter Roeck
---
drivers/watchdog/sp805_wdt.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog
On 04/30/2018 08:18 PM, Guenter Roeck wrote:
> On 04/29/2018 11:44 PM, Jongsung Kim wrote:
>> Add restart handler for SP805 watchdog so that the driver can be
>> used to reboot the system.
>>
>> Signed-off-by: Jongsung Kim <neidhard@lge.com>
>> ---
On 04/30/2018 08:18 PM, Guenter Roeck wrote:
> On 04/29/2018 11:44 PM, Jongsung Kim wrote:
>> Add restart handler for SP805 watchdog so that the driver can be
>> used to reboot the system.
>>
>> Signed-off-by: Jongsung Kim
>> ---
>> drivers/watchdog/sp80
Add restart handler for SP805 watchdog so that the driver can be
used to reboot the system.
Signed-off-by: Jongsung Kim <neidhard@lge.com>
---
drivers/watchdog/sp805_wdt.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/wa
Add restart handler for SP805 watchdog so that the driver can be
used to reboot the system.
Signed-off-by: Jongsung Kim
---
drivers/watchdog/sp805_wdt.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
index
Hi Ard,
On 2016년 08월 16일 23:39, Ard Biesheuvel wrote:
> (+ Dave)
>
> Hello Jongsung,
>
> On 16 August 2016 at 14:55, Jongsung Kim <neidhard@lge.com> wrote:
>> Current count_plts() uses O(n^2) algorithm for counting distinct
>> PLTs. It's good and fast enou
Hi Ard,
On 2016년 08월 16일 23:39, Ard Biesheuvel wrote:
> (+ Dave)
>
> Hello Jongsung,
>
> On 16 August 2016 at 14:55, Jongsung Kim wrote:
>> Current count_plts() uses O(n^2) algorithm for counting distinct
>> PLTs. It's good and fast enough when handling relativel
ho.s...@lge.com>
Signed-off-by: Jongsung Kim <neidhard@lge.com>
Reviewed-by: Namhyung Kim <namhyung@lge.com>
---
arch/arm/kernel/module-plts.c | 111 +-
1 file changed, 110 insertions(+), 1 deletion(-)
diff --git a/arch/arm/kernel/module-p
erence
looks very short and negligible.
This patch does not replaces original O(n^2) counting algorithm
with introduced O(n) algorithm, to use it as fall-back algorithm
when required memory allocation fails.
Reported-by: Chanho Min
Suggested-by: Youngho Shin
Signed-off-by: Jongsung Kim
Re
On 2016년 07월 02일 09:20, Stephen Boyd wrote:
> On 06/29, Jongsung Kim wrote:
>> On 2016년 06월 29일 06:18, Michael Turquette wrote:
>>> Quoting Rob Herring (2016-06-28 13:55:18)
>>>> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
>>>>> The
On 2016년 07월 02일 09:20, Stephen Boyd wrote:
> On 06/29, Jongsung Kim wrote:
>> On 2016년 06월 29일 06:18, Michael Turquette wrote:
>>> Quoting Rob Herring (2016-06-28 13:55:18)
>>>> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
>>>>> The
On 2016년 06월 29일 06:18, Michael Turquette wrote:
> Quoting Rob Herring (2016-06-28 13:55:18)
>> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
>>> There is no way to set additional flags for a DT-initialized fixed-
>>> factor-clock, and it can be probl
On 2016년 06월 29일 06:18, Michael Turquette wrote:
> Quoting Rob Herring (2016-06-28 13:55:18)
>> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
>>> There is no way to set additional flags for a DT-initialized fixed-
>>> factor-clock, and it can be probl
On 2016년 06월 29일 05:55, Rob Herring wrote:
> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
>> There is no way to set additional flags for a DT-initialized fixed-
>> factor-clock, and it can be problematic i.e., when the clock rate
>> needs to be changed. [1
On 2016년 06월 29일 05:55, Rob Herring wrote:
> On Fri, Jun 24, 2016 at 01:12:52PM +0900, Jongsung Kim wrote:
>> There is no way to set additional flags for a DT-initialized fixed-
>> factor-clock, and it can be problematic i.e., when the clock rate
>> needs to be changed. [1
[1] http://www.spinics.net/lists/linux-clk/msg09040.html
[2] https://lkml.org/lkml/2016/6/20/1025
Changes since v1:
- fix possible build failure when using gcc-5 or gcc-6
Signed-off-by: Jongsung Kim <neidhard@lge.com>
Cc: Maxime Ripard <maxime.rip...@free-electrons.com>
Cc: M
[1] http://www.spinics.net/lists/linux-clk/msg09040.html
[2] https://lkml.org/lkml/2016/6/20/1025
Changes since v1:
- fix possible build failure when using gcc-5 or gcc-6
Signed-off-by: Jongsung Kim
Cc: Maxime Ripard
Cc: Mike Turquette
Cc: Stephen Boyd
---
.../bindings/clock/fixed-factor
[1] http://www.spinics.net/lists/linux-clk/msg09040.html
[2] https://lkml.org/lkml/2016/6/20/1025
Signed-off-by: Jongsung Kim <neidhard@lge.com>
Cc: Maxime Ripard <maxime.rip...@free-electrons.com>
Cc: Mike Turquette <mturque...@baylibre.com>
Cc: Stephen Boyd <sb...@codeaurora.org
[1] http://www.spinics.net/lists/linux-clk/msg09040.html
[2] https://lkml.org/lkml/2016/6/20/1025
Signed-off-by: Jongsung Kim
Cc: Maxime Ripard
Cc: Mike Turquette
Cc: Stephen Boyd
---
.../bindings/clock/fixed-factor-clock.txt | 4
drivers/clk/clk-fixed-factor.c
clk_factor_round_rate().
Signed-off-by: Jongsung Kim <neidhard@lge.com>
---
drivers/clk/clk-fixed-factor.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 75cd6c7..9568306 100644
--- a/drivers/c
clk_factor_round_rate().
Signed-off-by: Jongsung Kim
---
drivers/clk/clk-fixed-factor.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 75cd6c7..9568306 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b
clk_factor_round_rate().
Signed-off-by: Jongsung Kim <neidhard@lge.com>
---
drivers/clk/clk-fixed-factor.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 75cd6c7..9b5df847f 100644
--- a/drivers/c
clk_factor_round_rate().
Signed-off-by: Jongsung Kim
---
drivers/clk/clk-fixed-factor.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 75cd6c7..9b5df847f 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b
On 10/12/2015 06:27 PM, Arnd Bergmann wrote:
> How about changing the zcomp code to pass the page pointer instead of the
> kernel space pointer? That would avoid having to do the kmap_atomic, which
> can itself be expensive on 32-bit machines and should not be needed here if
> you have a HW DMA
On 10/12/2015 06:27 PM, Arnd Bergmann wrote:
> How about changing the zcomp code to pass the page pointer instead of the
> kernel space pointer? That would avoid having to do the kmap_atomic, which
> can itself be expensive on 32-bit machines and should not be needed here if
> you have a HW DMA
900, Jongsung Kim wrote:
>> Recently, we made a driver utilizing kmap_atomic_to_page. Of course,
>> it's not mainlined. People may be using it outside mainline just like us.
> Since kmap_atomic() mappings are supposed to be short-lived, why do you
> need it in your driver? D
900, Jongsung Kim wrote:
>> Recently, we made a driver utilizing kmap_atomic_to_page. Of course,
>> it's not mainlined. People may be using it outside mainline just like us.
> Since kmap_atomic() mappings are supposed to be short-lived, why do you
> need it in your driver? D
Recently, we made a driver utilizing kmap_atomic_to_page. Of course, it's not
mainlined. People may be using it outside mainline just like us.
vmalloc has vmalloc_to_page, pkmap has kmap_to page, and fixmap has
kmap_atomic_to_page. Then.. how about letting virt_to_page do them all?
On
Recently, we made a driver utilizing kmap_atomic_to_page. Of course, it's not
mainlined. People may be using it outside mainline just like us.
vmalloc has vmalloc_to_page, pkmap has kmap_to page, and fixmap has
kmap_atomic_to_page. Then.. how about letting virt_to_page do them all?
On
On 07/14/2014 07:15 PM, Varka Bhadram wrote:
>
> I think we can do in this way:
>
> if (phydev)
> return phy_ethtool_set_wol(phydev, wol);
> else
> return -ENODEV;
>
>
> we can save err. What do you say ...?
>
Thank you for your comment. I just wanted the function to return
at one
On 07/14/2014 07:49 PM, David Laight wrote:
> From: Varka Bhadram
>> On 07/14/2014 02:32 PM, Jongsung Kim wrote:
>>> This patch enables the ethtool utility to control the WOL function
>>> of the PHY connected to the GEM/MACB. (if supported)
> ...
>>> +st
On 07/14/2014 07:49 PM, David Laight wrote:
From: Varka Bhadram
On 07/14/2014 02:32 PM, Jongsung Kim wrote:
This patch enables the ethtool utility to control the WOL function
of the PHY connected to the GEM/MACB. (if supported)
...
+static int macb_set_wol(struct net_device *netdev, struct
On 07/14/2014 07:15 PM, Varka Bhadram wrote:
I think we can do in this way:
if (phydev)
return phy_ethtool_set_wol(phydev, wol);
else
return -ENODEV;
we can save err. What do you say ...?
Thank you for your comment. I just wanted the function to return
at one position.
This patch enables the ethtool utility to control the WOL function
of the PHY connected to the GEM/MACB. (if supported)
Signed-off-by: Jongsung Kim
---
drivers/net/ethernet/cadence/macb.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/drivers
This patch enables the ethtool utility to control the WOL function
of the PHY connected to the GEM/MACB. (if supported)
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/ethernet/cadence/macb.c | 26 ++
1 files changed, 26 insertions(+), 0 deletions
On 06/17/2014 04:54 PM, Nicolas Ferre wrote:
Hi Nicolas,
> On 17/06/2014 05:39, Jongsung Kim :
>> On 06/17/2014 06:28 AM, Sören Brinkmann wrote:
>>> Shouldn't it be sufficient to replace 'MACB_BIT(RCOMP) with
>>> 'MACB_RX_INT_FLAGS'
>>> to clear al
On 06/17/2014 04:54 PM, Nicolas Ferre wrote:
Hi Nicolas,
On 17/06/2014 05:39, Jongsung Kim :
On 06/17/2014 06:28 AM, Sören Brinkmann wrote:
Shouldn't it be sufficient to replace 'MACB_BIT(RCOMP) with
'MACB_RX_INT_FLAGS'
to clear all the RX IRQ flags.
I'm afraid not.
You know
On 06/17/2014 12:50 PM, Sören Brinkmann wrote:
> On Tue, 2014-06-17 at 11:38AM +0900, Jongsung Kim wrote:
>> On 06/16/2014 11:56 PM, Sören Brinkmann wrote:
>>> On Mon, 2014-06-16 at 02:00PM +0900, Jongsung Kim wrote:
>>>> On 06/13/2014 12:44 AM, Sören Brinkmann wro
On 06/17/2014 06:28 AM, Sören Brinkmann wrote:
> Shouldn't it be sufficient to replace 'MACB_BIT(RCOMP) with
> 'MACB_RX_INT_FLAGS'
> to clear all the RX IRQ flags.
I'm afraid not.
You know, this driver initially targeted only GEMs configured with
"gem_irq_clear_read."
For this implementation
On 06/16/2014 11:56 PM, Sören Brinkmann wrote:
> On Mon, 2014-06-16 at 02:00PM +0900, Jongsung Kim wrote:
>> On 06/13/2014 12:44 AM, Sören Brinkmann wrote:
>>> This is now clearing all IRQ flags which is probably not what we want
>>> here. This is handling RX onl
On 06/16/2014 11:56 PM, Sören Brinkmann wrote:
On Mon, 2014-06-16 at 02:00PM +0900, Jongsung Kim wrote:
On 06/13/2014 12:44 AM, Sören Brinkmann wrote:
This is now clearing all IRQ flags which is probably not what we want
here. This is handling RX only. We still want the non-RX interrupts to go
On 06/17/2014 06:28 AM, Sören Brinkmann wrote:
Shouldn't it be sufficient to replace 'MACB_BIT(RCOMP) with
'MACB_RX_INT_FLAGS'
to clear all the RX IRQ flags.
I'm afraid not.
You know, this driver initially targeted only GEMs configured with
gem_irq_clear_read.
For this implementation of
On 06/17/2014 12:50 PM, Sören Brinkmann wrote:
On Tue, 2014-06-17 at 11:38AM +0900, Jongsung Kim wrote:
On 06/16/2014 11:56 PM, Sören Brinkmann wrote:
On Mon, 2014-06-16 at 02:00PM +0900, Jongsung Kim wrote:
On 06/13/2014 12:44 AM, Sören Brinkmann wrote:
This is now clearing all IRQ flags
On 06/13/2014 12:44 AM, Sören Brinkmann wrote:
> Hi Jongsung,
Hi Sören,
> Does this interrupt need to be enabled? There is nothing checking
> that bit and handling this IRQ in the handler, AFAICT. And you solve
> this by simply clearing the bit. So, I wonder whether not enabling this
> IRQ in
On 06/13/2014 12:44 AM, Sören Brinkmann wrote:
Hi Jongsung,
Hi Sören,
Does this interrupt need to be enabled? There is nothing checking
that bit and handling this IRQ in the handler, AFAICT. And you solve
this by simply clearing the bit. So, I wonder whether not enabling this
IRQ in the
Reported-by: Hayun Hwang
Signed-off-by: Youngkyu Choi
Signed-off-by: Jongsung Kim
Tested-by: Hayun Hwang
---
drivers/net/ethernet/cadence/macb.c | 37 ++
1 files changed, 15 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c
b/d
-by: Hayun Hwang hwang.ha...@lge.com
Signed-off-by: Youngkyu Choi youngkyu7.c...@lge.com
Signed-off-by: Jongsung Kim neidhard@lge.com
Tested-by: Hayun Hwang hwang.ha...@lge.com
---
drivers/net/ethernet/cadence/macb.c | 37 ++
1 files changed, 15 insertions(+), 22
Using phy_drivers_register/_unregister functions is proper way to
handle multiple PHY drivers registration. For Realtek PHY drivers
module, it fixes incomplete current error-handlings up and adds
missed unregistration for the RTL8201CP driver.
Signed-off-by: Jongsung Kim
---
drivers/net/phy
Using phy_drivers_register/_unregister functions is proper way to
handle multiple PHY drivers registration. For Realtek PHY drivers
module, it fixes incomplete current error-handlings up and adds
missed unregistration for the RTL8201CP driver.
Signed-off-by: Jongsung Kim neidhard@lge.com
Signed-off-by: Jongsung Kim
---
drivers/net/ethernet/cadence/macb.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net/ethernet/cadence/macb.c
index c89aa41..b4e0dc8 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/ethernet/cadence/macb.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/cadence/macb.c
b/drivers/net/ethernet/cadence/macb.c
index c89aa41..b4e0dc8 100644
--- a/drivers/net/ethernet
Stephen Warren :
> Looking at the TRM, it seems this is really the only change, according
> to the changelog in the documentation (although it's a little difficult
> to tell since the document seems to have a bunch of changes that
presumably
> don't affect behaviour). So, faking the periphid
Jongsung Kim :
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi
b/arch/arm/boot/dts/bcm2835.dtsi
> index f0052dc..1e12aef 100644
> --- a/arch/arm/boot/dts/bcm2835.dtsi
> +++ b/arch/arm/boot/dts/bcm2835.dtsi
> @@ -44,6 +44,7 @@
> reg =
like PL011-r1p4 or earlier revisions. As a workaround for
this compatibility issue, this patch overrides the HW UART periphid
register values with the actually compatible UART periphid 0x00241011
(r1p3 or r1p4).
Reported-by: Stephen Warren
Signed-off-by: Jongsung Kim
---
arch/arm/boot/dts/bcm2835
like PL011-r1p4 or earlier revisions. As a workaround for
this compatibility issue, this patch overrides the HW UART periphid
register values with the actually compatible UART periphid 0x00241011
(r1p3 or r1p4).
Reported-by: Stephen Warren swar...@wwwdotorg.org
Signed-off-by: Jongsung Kim neidhard
Jongsung Kim neidhard@lge.com :
diff --git a/arch/arm/boot/dts/bcm2835.dtsi
b/arch/arm/boot/dts/bcm2835.dtsi
index f0052dc..1e12aef 100644
--- a/arch/arm/boot/dts/bcm2835.dtsi
+++ b/arch/arm/boot/dts/bcm2835.dtsi
@@ -44,6 +44,7 @@
reg = 0x7e201000 0x1000
Stephen Warren swar...@wwwdotorg.org :
Looking at the TRM, it seems this is really the only change, according
to the changelog in the documentation (although it's a little difficult
to tell since the document seems to have a bunch of changes that
presumably
don't affect behaviour). So, faking
Jongsung Kim :
> Stephen Warren :
>>> All r1p5 have 32-byte FIFO depth and it's not configurable. From the
>>> PL011
>>> TRM:
>>>
>>> r1p4-r1p5 Contains the following differences in functionality:
>>> * The
Jongsung Kim neidhard@lge.com :
Stephen Warren swar...@wwwdotorg.org :
All r1p5 have 32-byte FIFO depth and it's not configurable. From the
PL011
TRM:
r1p4-r1p5 Contains the following differences in functionality:
* The receive and transmit FIFOs are increased to a depth
Stephen Warren :
>> All r1p5 have 32-byte FIFO depth and it's not configurable. From the
PL011
>> TRM:
>>
>> r1p4-r1p5Contains the following differences in functionality:
>> * The receive and transmit FIFOs are increased to a depth of
32.
>> * The Revision field in
Stephen Warren swar...@wwwdotorg.org :
All r1p5 have 32-byte FIFO depth and it's not configurable. From the
PL011
TRM:
r1p4-r1p5Contains the following differences in functionality:
* The receive and transmit FIFOs are increased to a depth of
32.
* The Revision
Stephen Warren :
> Looking at BCM2835-ARM-Peripherals.pdf (i.e. the public documentation for
> the BCM2835 chip), I see:
>
> =
> The UART provides:
> * Separate 16x8 transmit and 16x12 receive FIFO memory.
> ...
> For the in-depth UART overview, please, refer to the ARM PrimeCell UART
>
Stephen Warren :
> For reference, the AMBA periphid of the UART device there is 0x00341011.
> The nibble "3" is the revision being tested in:
The UART device has periphid 0x00341011, and is compatible with the
original PL011 prior to r1p5. Not with r1p5. It could be a possible
way to specify the
Stephen Warren swar...@wwwdotorg.org :
For reference, the AMBA periphid of the UART device there is 0x00341011.
The nibble 3 is the revision being tested in:
The UART device has periphid 0x00341011, and is compatible with the
original PL011 prior to r1p5. Not with r1p5. It could be a possible
Stephen Warren swar...@wwwdotorg.org :
Looking at BCM2835-ARM-Peripherals.pdf (i.e. the public documentation for
the BCM2835 chip), I see:
=
The UART provides:
* Separate 16x8 transmit and 16x12 receive FIFO memory.
...
For the in-depth UART overview, please, refer to the ARM PrimeCell
nges in v2:
* separated patch (pointed by Francois Romieu and Sergei Shtylyov)
* make functions shorter (pointed by Sergei Shtylyov)
Signed-off-by: Jongsung Kim
Cc: Francois Romieu
Cc: Sergei Shtylyov
---
drivers/net/phy/realtek.c | 41 -
1 files cha
register page-selecting function (pointed by Francois Romieu)
Signed-off-by: Jongsung Kim
Cc: Francois Romieu
Cc: Sergei Shtylyov
---
drivers/net/phy/Kconfig |2 +-
drivers/net/phy/realtek.c | 52 +
2 files changed, 53 insertions(+), 1
Add compatible but missing generic PHY suspend/resume handlers for
the RTL8211B driver.
Signed-off-by: Jongsung Kim
---
drivers/net/phy/realtek.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 8e95e38
Use the phy_drivers_register and phy_drivers_unregister to
simplify registration and error handling. The two existing
phy_driver structures are converted to an array of the
structures to do this.
v2: use proper way to register multiple drivers.
Signed-off-by: Jongsung Kim
Cc: Francois Romieu
Use the phy_drivers_register and phy_drivers_unregister to
simplify registration and error handling. The two existing
phy_driver structures are converted to an array of the
structures to do this.
v2: use proper way to register multiple drivers.
Signed-off-by: Jongsung Kim neidhard@lge.com
Cc
register page-selecting function (pointed by Francois Romieu)
Signed-off-by: Jongsung Kim neidhard@lge.com
Cc: Francois Romieu rom...@fr.zoreil.com
Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
drivers/net/phy/Kconfig |2 +-
drivers/net/phy/realtek.c | 52
Add compatible but missing generic PHY suspend/resume handlers for
the RTL8211B driver.
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/phy/realtek.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
in v2:
* separated patch (pointed by Francois Romieu and Sergei Shtylyov)
* make functions shorter (pointed by Sergei Shtylyov)
Signed-off-by: Jongsung Kim neidhard@lge.com
Cc: Francois Romieu rom...@fr.zoreil.com
Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
drivers/net/phy
Sergei Shtylyov :
>> -.suspend= genphy_suspend,
>> -.resume = genphy_resume,
>> +.suspend= _suspend,
>> +.resume = _resume,
>
>Contrariwise, you should have dropped & from the other functions.
>It's completely
Sergei Shtylyov sergei.shtyl...@cogentembedded.com :
-.suspend= genphy_suspend,
-.resume = genphy_resume,
+.suspend= genphy_suspend,
+.resume = genphy_resume,
Contrariwise, you should have dropped from the
This patch replaces the ugly bit-operations with the convenient
amba_rev macro from the get_fifosize_arm function. The type of
get_fifosize member function is also slightly changed to take
a pointer to the amba_device.
Signed-off-by: Jongsung Kim
---
drivers/tty/serial/amba-pl011.c | 11
Use the phy_drivers_register and phy_drivers_unregister to
simplify registration and error handling. The two existing
phy_driver structures are converted to an array of the
structures to do this.
Signed-off-by: Jongsung Kim
---
drivers/net/phy/realtek.c | 65
Add compatible but missing generic PHY suspend/resume handlers for
the RTL8211B driver.
Signed-off-by: Jongsung Kim
---
drivers/net/phy/realtek.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 8e95e38
Add the minimal driver to support the Realtek RTL8201F 10/100Mbps
Ethernet Transceivers.
The help message for the config REALTEK_PHY is also modified to
describe the current status of the module correctly.
Signed-off-by: Jongsung Kim
---
drivers/net/phy/Kconfig |2 +-
drivers/net/phy
This patch cleans up the drivers code by:
- using a consistent way to reference functions
- removing unused macro-definitions
- removing unnecessary new-lines
- making ack_interrupt functions shorter.
Signed-off-by: Jongsung Kim
---
drivers/net/phy/realtek.c | 29
This patch cleans up the drivers code by:
- using a consistent way to reference functions
- removing unused macro-definitions
- removing unnecessary new-lines
- making ack_interrupt functions shorter.
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/phy/realtek.c | 29
Add the minimal driver to support the Realtek RTL8201F 10/100Mbps
Ethernet Transceivers.
The help message for the config REALTEK_PHY is also modified to
describe the current status of the module correctly.
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/phy/Kconfig |2
Add compatible but missing generic PHY suspend/resume handlers for
the RTL8211B driver.
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/phy/realtek.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
Use the phy_drivers_register and phy_drivers_unregister to
simplify registration and error handling. The two existing
phy_driver structures are converted to an array of the
structures to do this.
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/phy/realtek.c | 65
This patch replaces the ugly bit-operations with the convenient
amba_rev macro from the get_fifosize_arm function. The type of
get_fifosize member function is also slightly changed to take
a pointer to the amba_device.
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/tty/serial/amba
Sergei Shtylyov :
>> Agreed. I just thought it's better to make it similar to the
>> rtl821x_ack_interrupt.
>
>Ah, then you may leave this code as is.
>
>> Then, may I make shorter the rtl821x_ack_interrupt as well as
>> rtl8201f_ack_interrupt?
>
>In a separate patch, if you wish.
>
Sergei Shtylyov sergei.shtyl...@cogentembedded.com :
Agreed. I just thought it's better to make it similar to the
rtl821x_ack_interrupt.
Ah, then you may leave this code as is.
Then, may I make shorter the rtl821x_ack_interrupt as well as
rtl8201f_ack_interrupt?
In a separate
Sergei Shtylyov :
> Removal of unused #define's is a matter of a separate cleanup patch...
Sorry. I won't touch them.
>> +static int rtl8201f_ack_interrupt(struct phy_device *phydev) {
>> +int err;
>> +
>> +err = phy_read(phydev, RTL8201F_ISR);
>
>This could be an initializer
Francois Romieu :
> Your patch contains both "remove unused #define" and "support new
hardware"
> parts. I am not sure that the former is adequate for submission until
net-next opens.
I see. Sorry for trying touching them even without comment. I won't touch
them.
> static void
This patch adds the minimal driver to manage the
Realtek RTL8201F 10/100Mbps Transceivers.
Signed-off-by: Jongsung Kim
---
drivers/net/phy/realtek.c | 60 +++-
1 files changed, 53 insertions(+), 7 deletions(-)
diff --git a/drivers/net/phy/realtek.c b
This patch adds the minimal driver to manage the
Realtek RTL8201F 10/100Mbps Transceivers.
Signed-off-by: Jongsung Kim neidhard@lge.com
---
drivers/net/phy/realtek.c | 60 +++-
1 files changed, 53 insertions(+), 7 deletions(-)
diff --git a/drivers
Francois Romieu rom...@fr.zoreil.com :
Your patch contains both remove unused #define and support new
hardware
parts. I am not sure that the former is adequate for submission until
net-next opens.
I see. Sorry for trying touching them even without comment. I won't touch
them.
static void
Sergei Shtylyov sergei.shtyl...@cogentembedded.com :
Removal of unused #define's is a matter of a separate cleanup patch...
Sorry. I won't touch them.
+static int rtl8201f_ack_interrupt(struct phy_device *phydev) {
+int err;
+
+err = phy_read(phydev, RTL8201F_ISR);
This
This patch replaces the ugly bit-operations with the convenient
amba_rev macro from the get_fifosize_arm function. The type of
get_fifosize member function is also slightly changed to take
a pointer to the amba_device.
Signed-off-by: Jongsung Kim
---
drivers/tty/serial/amba-pl011.c | 11
1 - 100 of 107 matches
Mail list logo
