Hi, Corentin
On 11/24/2015 9:12 PM, LABBE Corentin wrote:
On Fri, Nov 20, 2015 at 04:33:14PM +0800, Josh Wu wrote:
Hi, Corentin
Thanks for the patch. It looks fine to me, just one nitpick in below:
On 11/20/2015 3:45 PM, LABBE Corentin wrote:
of_match_device could return NULL, and so cause
if (!host->caps)
+ return 1;
it's better to use -EINVAL here.
Best Regards,
Josh Wu
if (of_property_read_u32(np, "atmel,nand-addr-offset", &val) == 0) {
if (val >= 32) {
--
To unsubscribe from this list: send the line "unsubscr
Hi, Corentin
Thanks for the patch.
On 11/20/2015 3:45 PM, LABBE Corentin wrote:
All atmel_nand_caps are never modified, consitify them.
Signed-off-by: LABBE Corentin
Acked-by: Josh Wu
Best Regards,
Josh Wu
---
drivers/mtd/nand/atmel_nand.c | 6 +++---
1 file changed, 3 insertions
Atmel ISI support a preview path which can output RGB data.
So this patch introduces a bool variable to choose which path is
enabled currently. And also we need setup corresponding path registers.
By default the preview path is disabled. We only use Codec path.
Signed-off-by: Josh Wu
t_rgb() function
which only used once. Also move the code into the for loop.
Josh Wu (5):
media: atmel-isi: correct yuv swap according to different sensor
outputs
media: atmel-isi: prepare for the support of preview path
media: atmel-isi: add code to setup correct resolution for preview
Not like codec path, preview path can do downsampling, so we should setup
a extra preview width, height for it.
This patch add preview resolution setup without down sampling. So currently
preview path will output same size as sensor output size.
Signed-off-by: Josh Wu
---
Changes in v2: None
This patch enable Atmel ISI preview path to convert the YUV to RGB format.
Signed-off-by: Josh Wu
---
Changes in v2:
- According to Guennadi's suggestion, remove the is_output_rgb() function
which only used once. Also move the code into the for loop.
drivers/media/platform/soc_camera/
output a pass-through formats, which means no swap.
Just setup YCC_SWAP as default with no swap.
Signed-off-by: Josh Wu
---
Changes in v2:
- remove the duplicated variable: cfg2_yuv_swap.
drivers/media/platform/soc_camera/atmel-isi.c | 39 ---
1 file changed, 29
The preview path only can convert UYVY format to RGB data.
To make preview path work correctly, we need to set up YCC_SWAP
according to sensor output and convert them to UYVY.
Signed-off-by: Josh Wu
---
Changes in v2:
- remove cfg2_yuv_swap for rgb format
- correct the comment style
drivers
This macro is used to generate a OF string for a v4l2 clock.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 4 ++--
include/media/v4l2-clk.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform
ot;.
This patch will search the clock with OF string name if fail to find the
clock with I2C string name.
Signed-off-by: Josh Wu
---
drivers/media/v4l2-core/v4l2-clk.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-clk.c
b/drivers/media/v4l2-core/
Make all v4l2-clk's clock name use V4L2_CLK_NAME_SIZE definition.
In future, if the string increased we just need to change the
V4L2_CLK_NAME_SIZE once.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 6 +++---
drivers/media/usb/em28xx/em28xx-camera.c
Since v4l2_clk_name_i2c() is defined, so just reuse it.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c
b/drivers/media/platform
This patch set will fix a bug in soc-camera, which will fail to search
the v4l2-clk if the i2c sensor is probed later than soc-camera host.
It also add some clean up for v4l2-clk code and usage.
Josh Wu (4):
soc_camera: get the clock name by using macro: v4l2_clk_name_i2c()
v4l2-clk: add
Hi, Nicolas
On 9/18/2015 10:09 PM, Nicolas Ferre wrote:
Le 18/09/2015 13:28, Josh Wu a écrit :
On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the parallel
connection for ov2640. So we must set the hsync/vsync property (1 means
active high).
Otherwise, the connection would be seen
On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the parallel
connection for ov2640. So we must set the hsync/vsync property (1 means
active high).
Otherwise, the connection would be seen as BT.656 or BT.1120.
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/at91sam9m10g45ek.dts | 2
o into 4.3.
Best Regards,
Josh Wu
Thanks
Guennadi
On Tue, 4 Aug 2015, Josh Wu wrote:
Since in soc_of_bind() it may use the of node's full name as the clk_name,
and this full name may be longer than 32 characters, take at91 i2c sensor
as an example, length is 34 bytes:
/ahb/apb/i2c@
:
‘atmel_isi_runtime_resume’ defined but not used
Protect the unused functions by #ifdef CONFIG_PM to fix this.
Signed-off-by: Geert Uytterhoeven
Acked-by: Josh Wu
Best Regards,
Josh Wu
---
Resend with correct suject
---
drivers/media/platform/soc_camera/atmel-isi.c | 2 ++
1 file changed, 2
Hi, Guennadi
Thanks for the review.
On 8/30/2015 4:48 PM, Guennadi Liakhovetski wrote:
Hi Josh,
On Wed, 17 Jun 2015, Josh Wu wrote:
In the function configure_geometry(), we will setup the ISI CFG2
according to the sensor output format.
It make no sense to just read back the CFG2 register
Hi, Laurent
On 8/22/2015 2:22 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Friday 21 August 2015 16:08:14 Josh Wu wrote:
After adding the format check in try_fmt()/set_fmt(), we don't need any
format check in configure_geometry(). So make configure_geometry() as
void
After adding the format check in try_fmt()/set_fmt(), we don't need any
format check in configure_geometry(). So make configure_geometry() as
void type.
Signed-off-by: Josh Wu
---
Changes in v3:
- check the whether format is supported, if no then return a default
format.
- misc ch
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So move the configure_geometry(), which access the ISI hardware, to
start_streaming() will make code more consistent and simpler.
Signed-off-by: Josh Wu
Review
.
Signed-off-by: Josh Wu
Reviewed-by: Laurent Pinchart
---
Changes in v3: None
Changes in v2:
- add Laurent's reviewed-by tag.
drivers/media/platform/soc_camera/atmel-isi.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/soc_c
Hi, Laurent
Thanks for the review.
On 8/21/2015 2:30 AM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Wednesday 05 August 2015 11:26:29 Josh Wu wrote:
After adding the format check in set_fmt(), we don't need any format check
in configure_geometry(). So
Hi, Laurent
Could you have time to review this patch? so that I can send a pull
request with your reviewed-by tags.
Best Regards,
Josh Wu
On 8/5/2015 11:26 AM, Josh Wu wrote:
After adding the format check in set_fmt(), we don't need any format check
in configure_geometry(). So
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So move the configure_geometry(), which access the ISI hardware, to
start_streaming() will make code more consistent and simpler.
Signed-off-by: Josh Wu
Review
After adding the format check in set_fmt(), we don't need any format check
in configure_geometry(). So make configure_geometry() as void type.
Signed-off-by: Josh Wu
---
Changes in v2:
- new added patch
drivers/media/platform/soc_camera/atmel-isi.c | 39 +--
1
.
Signed-off-by: Josh Wu
Reviewed-by: Laurent Pinchart
---
Changes in v2:
- add Laurent's reviewed-by tag.
drivers/media/platform/soc_camera/atmel-isi.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi
nough so far.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/soc_camera.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/soc_camera/soc_camera.c
b/drivers/media/platform/soc_camera/soc_camera.c
index d708df4..fcf3e97 100644
--- a/drivers/
Hi, Laurent
On 8/3/2015 9:27 PM, Laurent Pinchart wrote:
Hi Josh,
On Monday 03 August 2015 11:56:01 Josh Wu wrote:
On 7/31/2015 10:37 PM, Laurent Pinchart wrote:
On Wednesday 17 June 2015 18:39:39 Josh Wu wrote:
As in set_fmt() function we only need to know which format is been set,
we
(PIN_PB24, 6, 3)
As sama5d2 use ISC, so It's better to run s/ISI_/ISC_/ in this file,
which is consistent with the datasheet.
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
HI, Laurent
On 7/31/2015 10:37 PM, Laurent Pinchart wrote:
Hi Josh,
Thank you for the patch.
On Wednesday 17 June 2015 18:39:39 Josh Wu wrote:
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So mov
Hi, list
Ping..., any feedback for this series?
Best Regards,
Josh Wu
On 6/17/2015 6:39 PM, Josh Wu wrote:
In the function configure_geometry(), we will setup the ISI CFG2
according to the sensor output format.
It make no sense to just read back the CFG2 register and just set part
of it.
So
On 7/28/2015 3:37 PM, Nicolas Ferre wrote:
Le 16/06/2015 12:08, Josh Wu a écrit :
Add Atmel-isi and ov2640 driver in defconfig
Signed-off-by: Josh Wu
---
Changes in v2: None
arch/arm/configs/at91_dt_defconfig | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/configs
They'll use "atmel,sama5d3-rstc" for reset function.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
Changes in v2: None
arch/arm/boot/dts/sama5d3.dtsi | 2 +-
arch/arm/boot/dts/sama5d4.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ar
nal driving the bus, but since sama5d3 and
later chips there is no such a conflict.
So in this patch:
1. the sama5d3 reset function only need to write the rstc register
and return.
2. we can remove the code related with sama5d3 DDR controller as
we don't use it at all.
Signed-off-b
On 7/20/2015 4:44 PM, Josh Wu wrote:
On 7/20/2015 4:35 PM, Josh Wu wrote:
Hi, Maxime
On 7/20/2015 3:52 PM, Maxime Ripard wrote:
Hi Josh,
On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote:
On 7/11/2015 12:12 AM, Nicolas Ferre wrote:
Le 10/07/2015 14:31, Maxime Ripard a écrit :
On Fri
On 7/20/2015 4:35 PM, Josh Wu wrote:
Hi, Maxime
On 7/20/2015 3:52 PM, Maxime Ripard wrote:
Hi Josh,
On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote:
On 7/11/2015 12:12 AM, Nicolas Ferre wrote:
Le 10/07/2015 14:31, Maxime Ripard a écrit :
On Fri, Jul 10, 2015 at 02:09:07PM +0200
Hi, Maxime
On 7/20/2015 3:52 PM, Maxime Ripard wrote:
Hi Josh,
On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote:
On 7/11/2015 12:12 AM, Nicolas Ferre wrote:
Le 10/07/2015 14:31, Maxime Ripard a écrit :
On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote:
Hi,
On 10/07
On 7/11/2015 12:12 AM, Nicolas Ferre wrote:
Le 10/07/2015 14:31, Maxime Ripard a écrit :
On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote:
Hi,
On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote :
I would agree with Maxime. Currently all latest chip reset function is
compatible
On 7/10/2015 2:54 PM, Maxime Ripard wrote:
On Fri, Jul 10, 2015 at 11:06:52AM +0800, Josh Wu wrote:
Hi, Maxime
On 7/9/2015 8:03 PM, Maxime Ripard wrote:
Hi,
On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote:
As since sama5d3, to reset the chip, we don't need to shutdown th
Hi, Alexandre
On 7/10/2015 2:03 PM, Alexandre Belloni wrote:
Hi,
On 09/07/2015 at 18:15:46 +0800, Josh Wu wrote :
As since sama5d3, to reset the chip, we don't need to shutdown the ddr
controller.
So add a new compatible string and new restart function for sama5d3 and
later chips.
Hi, Guenter
On 7/10/2015 11:14 AM, Guenter Roeck wrote:
On Fri, Jul 10, 2015 at 09:59:53AM +0800, Josh Wu wrote:
Hi, Guenter
On 7/10/2015 1:37 AM, Guenter Roeck wrote:
On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote:
As since sama5d3, to reset the chip, we don't need to shutdow
Hi, Maxime
On 7/9/2015 8:03 PM, Maxime Ripard wrote:
Hi,
On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote:
As since sama5d3, to reset the chip, we don't need to shutdown the ddr
controller.
So add a new compatible string and new restart function for sama5d3 and
later chips.
Hi, Guenter
On 7/10/2015 1:37 AM, Guenter Roeck wrote:
On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote:
As since sama5d3, to reset the chip, we don't need to shutdown the ddr
controller.
So add a new compatible string and new restart function for sama5d3 and
later chips. As we
As since sama5d3, to reset the chip, we don't need to shutdown the ddr
controller.
So add a new compatible string and new restart function for sama5d3 and
later chips. As we don't use sama5d3 ddr controller, so remove it as
well.
Signed-off-by: Josh Wu
Acked-by: Nicolas Ferre
---
They'll use "atmel,sama5d3-rstc" for reset function.
Cc: devicet...@vger.kernel.org
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/sama5d3.dtsi | 2 +-
arch/arm/boot/dts/sama5d4.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d3.
As in set_fmt() function we only need to know which format is been set,
we don't need to access the ISI hardware in this moment.
So move the configure_geometry(), which access the ISI hardware, to
start_streaming() will make code more consistent and simpler.
Signed-off-by: Josh Wu
---
dr
.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
b/drivers/media/platform/soc_camera/atmel-isi.c
index 9070172..8bc40ca 100644
--- a
If ISI is working on a 1024x768 or higher resolution, it needs longer
time to disable ISI. So this patch will increase timeout to 500ms.
Signed-off-by: Josh Wu
---
drivers/media/platform/soc_camera/atmel-isi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media
First we group the isi data pins, and for now we only use 0~7 data pins
with HSYNC and VSYNC.
Also add the link for atmel-isi and ov2640 sensor node.
Signed-off-by: Josh Wu
---
Changes in v2:
- group the isi data pin.
- remove the isi_mck pin from pinctrl-isi as it will used by camera
sensor
Add Atmel-isi and ov2640 driver in defconfig
Signed-off-by: Josh Wu
---
Changes in v2: None
arch/arm/configs/at91_dt_defconfig | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/configs/at91_dt_defconfig
b/arch/arm/configs/at91_dt_defconfig
index bcef49a..d089ec9 100644
--- a
Add Atmel-isi and ov2640 driver in defconfig
Signed-off-by: Josh Wu
---
arch/arm/configs/at91_dt_defconfig | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/configs/at91_dt_defconfig
b/arch/arm/configs/at91_dt_defconfig
index bcef49a..d089ec9 100644
--- a/arch/arm/configs
Add the link for atmel-isi and ov2640 sensor node.
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/at91sam9g45.dtsi | 4 +++
arch/arm/boot/dts/at91sam9m10g45ek.dts | 45 ++
2 files changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi
b
On 3/4/2015 7:07 PM, Nicolas Ferre wrote:
Le 04/03/2015 03:51, Josh Wu a écrit :
Add at91 sama5d4 xplained board support.
Signed-off-by: Josh Wu
---
Changes in v4:
- Thanks to Bo Shen to find following leds issues:
1. the leds' label is changed in new xplained board.
2. as
Add at91 sama5d4 xplained board support.
Signed-off-by: Josh Wu
---
Changes in v4:
- Thanks to Bo Shen to find following leds issues:
1. the leds' label is changed in new xplained board.
2. as piod bank is disabled in sama5d4, that will whole led driver
not work. So just disable th
macb0 DT node can have phy child nodes, so add the #{address,
size}_cells for macb0 node.
Signed-off-by: Josh Wu
---
Changes in v4:
- fix typo in commit message: cell -> cells
Changes in v3:
- new added
Changes in v2: None
arch/arm/boot/dts/sama5d4.dtsi | 2 ++
1 file changed, 2 inserti
Hi, Colin
On 3/1/2015 4:27 AM, Colin King wrote:
From: Colin Ian King
Fix typo, "Unkown" -> "Unknown"
Signed-off-by: Colin Ian King
Thanks for the patch.
Acked-by: Josh Wu
---
drivers/mtd/nand/atmel_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
macb0 DT node can have phy child nodes, so add the #{address, size}_cell
for macb0 node.
Signed-off-by: Josh Wu
---
Changes in v3:
- new added
Changes in v2: None
arch/arm/boot/dts/sama5d4.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm
Add at91 sama5d4 xplained board support.
Signed-off-by: Josh Wu
---
Changes in v3:
- add phy0 child node under macb0
- rebase on top of linux next, re-formated the arch/arm/boot/dts/Makefile
Changes in v2:
- to be sorted by memory address, put the adc dt node after usart4.
arch/arm/boot/dts
Hi, Alexandre
On 2/10/2015 2:10 AM, Alexandre Belloni wrote:
Hi Josh,
On 09/02/2015 at 17:17:03 +0800, Josh Wu wrote :
Add at91 sama5d4 xplained board support.
Signed-off-by: Josh Wu
---
Changes in v2:
- to be sorted by memory address, put the adc dt node after usart4.
arch/arm/boot/dts
Hi, Boris
On 2/9/2015 5:24 PM, Boris Brezillon wrote:
Hi Josh,
On Mon, 9 Feb 2015 17:17:03 +0800
Josh Wu wrote:
Add at91 sama5d4 xplained board support.
Signed-off-by: Josh Wu
---
Changes in v2:
- to be sorted by memory address, put the adc dt node after usart4.
arch/arm/boot/dts
Add the leds DT node in the dts file.
In the leds, d10 is set as heartbeat led.
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/at91-sama5d4ek.dts | 22 ++
1 file changed, 22 insertions(+)
diff --git a/arch/arm/boot/dts/at91-sama5d4ek.dts
b/arch/arm/boot/dts/at91
Add at91 sama5d4 xplained board support.
Signed-off-by: Josh Wu
---
Changes in v2:
- to be sorted by memory address, put the adc dt node after usart4.
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-sama5d4_xplained.dts | 232
2 files
add at91 sama5d4 xplained board support.
Signed-off-by: Josh Wu
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-sama5d4_xplained.dts | 234
2 files changed, 235 insertions(+)
create mode 100644 arch/arm/boot/dts/at91
Hi, Boris
Thanks a lot for your explanation, check my reply for more description
for my suggestion.
On 2/3/2015 5:37 PM, Boris Brezillon wrote:
On Tue, 3 Feb 2015 16:46:15 +0800
Josh Wu wrote:
Hi, Boris, Brian
On 2/2/2015 5:42 PM, Boris Brezillon wrote:
Hi Brian,
On Sun, 1 Feb 2015 23
NFC properties --> we can make the NFC not a node, just many NFC
properties.
&nand chip0
&nand chip1
}
This is still looks nice to me.
Josh, Brian, any idea to solve this EBI/nand-chip/nand-controller
dependency problem is welcome.
Best Regards,
Boris
Best Regards,
Josh Wu
-
Hi, Guennadi
On 11/28/2014 4:13 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Thu, 27 Nov 2014, Josh Wu wrote:
Hi, Guennadi
On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 25 Nov 2014, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The
rror
Location regs */
- >;
- interrupts = <22 IRQ_TYPE_LEVEL_HIGH 6>;
- atmel,nand-addr-offset = <21>;
- atmel,nand-cmd-offset = <22>;
- atmel,nand-has-dma;
- p
Hi, Boris
Thanks for the patch.
You need to rebase on the top of current mtd-l2 git tree. As I had some
change on the binding document.
Best Regards,
Josh Wu
On 12/5/2014 6:30 AM, Boris Brezillon wrote:
The NAND and NFC (NAND Flash Controller) were linked together with a
parent <->
atch.
Acked-by: Josh Wu
Best Regards,
Josh Wu
---
drivers/mtd/nand/atmel_nand.c | 76 ++-
1 file changed, 61 insertions(+), 15 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 19d1e9d..0239fe6 100644
--- a/
Hi, Guennadi
On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote:
Hi Josh,
On Tue, 25 Nov 2014, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu
Thanks for your patches. I'm ok with thes
Hi, Alexandre
On 11/26/2014 12:40 AM, Alexandre Belloni wrote:
The sama4d4 has Special Function Registers that allow to manage DDR, OHCI, EBI
and AIC interrupt redirection.
Just a nitpick, It should be sama5d4, not sama4d4.
Best Regards,
Josh Wu
Signed-off-by: Alexandre Belloni
Acked-by
Hi, Sylwester and Mauro
On 11/25/2014 6:34 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 25/11/14 09:54, Josh Wu wrote:
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu
---
include/media/v4l2-image-sizes.h | 9
Reuse the v4l2 size definitions from v4l2-image-sizes.h.
So we can remove the rudundent definitions from ov2640.c.
Signed-off-by: Josh Wu
---
drivers/media/i2c/soc_camera/ov2640.c | 82 +--
1 file changed, 30 insertions(+), 52 deletions(-)
diff --git a/drivers
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h.
The definitions are sorted by alphabet order.
Signed-off-by: Josh Wu
---
include/media/v4l2-image-sizes.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image
prepare a new patch which do above replace.
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi, Vinod
On 10/21/2014 12:06 AM, Vinod Koul wrote:
The driver was also using own method to do 32bit copy, turns out
we have a kernel API so use that instead
Signed-off-by: Vinod Koul
Thanks for the patch.
Acked-by: Josh Wu
BTW, is there any similar kernel API that is for the read from io
This patch adds an entry in MAINTAINERS file for ATMEL nand driver.
Signed-off-by: Josh Wu
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3705430..1bdf3bf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1698,6 +1698,12 @@ M
Hi, Alexandre
On 9/12/2014 5:40 PM, Alexandre Belloni wrote:
From: Boris BREZILLON
Signed-off-by: Boris BREZILLON
Signed-off-by: Alexandre Belloni
---
Thanks for the patch.
Acked-by: Josh Wu
Best Regards,
Josh Wu
Changes in v4:
- fix typo in the documentation
.../devicetree
clocks = <&hsmc_clk>
Best Regards,
Josh Wu
reg = <
0x7000 0x1000 /* NFC Command Registers */
0xc000 0x0070 /* NFC HSMC regs */
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atme
Hi, Nicolas
On 9/12/2014 3:52 PM, Nicolas Ferre wrote:
On 11/09/2014 19:52, Alexandre Belloni :
From: Boris BREZILLON
Signed-off-by: Boris BREZILLON
Signed-off-by: Alexandre Belloni
You may need to add Josh Wu to the list because he is the "de-facto"
Maintainer of this driver
enabled, so I think
nfc->is_initialized should set to false.
Otherwise, the nand driver will try to use the NFC without enabled the
clock.
Is it better to move the code block
nfc->is_initialized = true;
dev_info(&pdev->dev, "NFC is probed.\n"
The handle_adc_eoc_trigger() in only used in at91_adc.c. So make it
static.
Signed-off-by: Josh Wu
---
drivers/iio/adc/at91_adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
index 772e869..7807e0e 100644
--- a
ays ago which does almost the same thing to
support 4k-page nand flash.
personally I am fine with your patch.
Brain, you only need to take care this patch. And drop my patch [1].
[1] http://patchwork.ozlabs.org/patch/372406/
Thanks.
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the
0 as a reference so far. When the devices
file is finally removed. We will add the ISI resouces to DT file.
So I am ok with this.
Hi, J.C.
What do you think of this patch?
Best Regards,
Josh Wu
Josh verified that this definition of at91_add_device_isi() never will
be call
ll be called.
Right. There is no implement to support for at91sam9263 ISI. So in
at91sam9263ek it will not call at91_add_device_isi().
Current ISI driver only support at91sam9g45 and later chips.
Acked-by: Josh Wu
Best Regards,
Josh Wu
arch/arm/mach-at91/at91sam9263_devices.c
Hi, all
since v4l2_clk_get() WON'T return EPROBE_DEFER. So this version of patch
is invalid.
Please drop this version of the patch.
Sorry for the noise.
Best Regards,
Josh Wu
On 3/20/2014 5:01 PM, Josh Wu wrote:
Since the the v4l2_clk_get() may return a EPROBE_DEFER during async
probin
Hi, Sylwester
On 3/20/2014 10:44 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 19/03/14 10:17, Josh Wu wrote:
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(&client->dev, "mclk");
+if (IS_ERR(clk))
+ret
Since the the v4l2_clk_get() may return a EPROBE_DEFER during async
probing. So move the v4l2_clk_get() to the beginning of the
probe(). Only when we get mclk successfully we continue the probe.
Signed-off-by: Josh Wu
---
v1 -> v2:
just return PTR_ERR(clk) as it can be -EPROBE_DEFER.
refi
Hi, Sylwester
Thanks for your review.
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
Hi Josh,
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(&client->dev, "mclk");
+if (IS_ERR(clk))
+return -EPROBE_DEFER;
You should instead make it:
r
Move the clock detection code to the beginning of the probe().
If we meet any error in the clock detecting, then defer the probe.
Signed-off-by: Josh Wu
---
drivers/media/i2c/soc_camera/ov2640.c | 43 +
1 file changed, 28 insertions(+), 15 deletions(-)
diff
+), 6 deletions(-)
Thank you for the fixes.
I tested the patch series in at91sam9m10g45ek and works fine.
so here is my:
Tested-by: Josh Wu
Acked-by: Josh Wu
Best Regards,
Josh Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
value of 2/ADCCLK or 1/ADCCLK depending on the version.
Signed-off-by: Alexandre Belloni
Thanks for the fix and
Acked-by: Josh Wu
Best Regards,
Josh Wu
---
drivers/iio/adc/at91_adc.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/at91_adc.c b
_available_child_of_node() and
of_get_available_child_count() to enumerate all child nodes. So the
disabled node will be inavailable.
Signed-off-by: Josh Wu
---
resend this patch based on the patch:
- http://www.spinics.net/lists/devicetree/msg05903.html
drivers/leds/leds-gpio.c |6 +++---
1 fi
ild_of_node() to
enumerate all child nodes. So the disabled node will be inavilable.
Signed-off-by: Josh Wu
---
drivers/leds/leds-gpio.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index e8b01e5..9bb4e04
On 5/31/2013 10:34 PM, Richard Genoud wrote:
We don't have to issue a warning when a stronger error correting
capability is chosen.
Signed-off-by: Richard Genoud
Acked-by: Josh Wu
Best Regards,
Josh Wu
---
drivers/mtd/nand/atmel_nand.c |2 +-
1 file changed, 1 insertion(
Hi, Andrew
Could you merge it for avr32? Thanks in advance.
Best Regards,
Josh Wu
On 4/1/2013 2:26 PM, Josh Wu wrote:
fixed the following compile error when use avr32 atstk1006_defconfig:
drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_location':
drivers/mtd/nand/atmel_
introduced by commit:
1c7b874d33b463f7150b1ab4617f000af9b327fd
mtd: at91: atmel_nand: add Programmable Multibit ECC controller support
The PMECC for nand flash code uses writel_relaxed(). But in avr32, there is no
macro "writel_relaxed" defined.
This patch add writex_relaxed macro definitions.
Signed-off-by: Josh W
Sorry, please drop this email. I will send out another one to include
a...@linux-foundation.org
Best Regards,
Josh Wu
On 4/1/2013 1:58 PM, Josh Wu wrote:
fixed the following compile error when use avr32 atstk1006_defconfig:
drivers/mtd/nand/atmel_nand.c: In function 'pmecc_err_loc
1 - 100 of 104 matches
Mail list logo
