Re: [linux-sunxi] [PATCH 10/15] drm/sun4i: Add support for R40 TV TCONs

2018-05-19 Thread Julian Calaby
Hi Jernej, On Sun, May 20, 2018 at 11:57 AM, Julian Calaby <julian.cal...@gmail.com> wrote: > Hi Jernej, > > On Sun, May 20, 2018 at 4:31 AM, Jernej Skrabec <jernej.skra...@siol.net> > wrote: >> R40 display pipeline has a lot of possible configurations. HDMI can

Re: [linux-sunxi] [PATCH 10/15] drm/sun4i: Add support for R40 TV TCONs

2018-05-19 Thread Julian Calaby
} > + > +static int sun8i_r40_tcon_tv_set_mux_1(struct sun4i_tcon *tcon, > + const struct drm_encoder *encoder) > +{ > + return sun8i_r40_tcon_tv_set_mux(tcon, encoder, 1); > +} Are TCON-TOPs going to be a common thing in new SoCs from Allwi

Re: [linux-sunxi] [PATCH 07/15] dt-bindings: display: sun4i-drm: Add R40 HDMI pipeline

2018-05-19 Thread Julian Calaby
+H3 and A64 HDMI PHY requires additional clocks: >- pll-0: parent of phy clock > + - pll-1: second possible phy clock parent (A64 only) Maybe split this into two: H3 HDMI PHY ... - pll-0: ... A64 HDMI PHY ... - pll-0: ... - pll-1: ... At the moment a quick reading implies th

Re: [linux-sunxi] [PATCH v2 1/6] ASoC: sun4i-i2s: Add slot width override

2018-03-13 Thread Julian Calaby
operty is present then the dai is > + configured to extend the slot width to the > + value specified. Min 8, Max 32. > + This sounds like something that would be useful for other I2S controllers. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 14/15] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

2018-02-27 Thread Julian Calaby
Hi Maxime, On Tue, Feb 27, 2018 at 6:07 PM, Maxime Ripard <maxime.rip...@bootlin.com> wrote: > On Tue, Feb 27, 2018 at 01:29:27PM +1100, Julian Calaby wrote: >> Hi Jernej, >> >> On Tue, Feb 27, 2018 at 3:27 AM, Jernej Škrabec <jernej.skra...@siol.net> >> w

Re: [linux-sunxi] [PATCH 14/15] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

2018-02-26 Thread Julian Calaby
.net> 写到: >> >Hi Julian, >> > >> >Dne nedelja, 25. februar 2018 ob 09:11:34 CET je Julian Calaby >> > >> >napisal(a): >> >> Hi Jernej, >> >> >> >> On Sun, Feb 25, 2018 at 8:45 AM, Jernej Skrabec >> > >> &

Re: [linux-sunxi] [PATCH 14/15] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

2018-02-25 Thread Julian Calaby
Hi Icenowy, On Sun, Feb 25, 2018 at 7:43 PM, Icenowy Zheng <icen...@aosc.io> wrote: > > > 于 2018年2月25日 GMT+08:00 下午4:11:34, Julian Calaby <julian.cal...@gmail.com> 写到: >>Hi Jernej, >> >>On Sun, Feb 25, 2018 at 8:45 AM, Jernej Skrabec >><jernej

Re: [linux-sunxi] [PATCH 14/15] ARM: dts: sun8i: h3: Enable HDMI output on H3 boards

2018-02-25 Thread Julian Calaby
lease add the necessary bits and pieces to the h2-plus DTSs too? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH v3] rtc: ac100: Fix ac100 determine rate bug

2018-02-15 Thread Julian Calaby
om the codec side of the chip, which we > +* properly declare and reference in the devicetree and is > +* not implemented in any driver right now. > +* If the clock core looks for the parent of that second > +* m

Re: [linux-sunxi] [PATCH 1/3] net: stmmac: dwmac-sun8i: drop V3s compatible and add V3 one

2018-02-02 Thread Julian Calaby
s variant around for compatibility with existing device trees? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [RFC PATCH 2/9] ARM: sunxi: add Allwinner ARMv5 SoCs

2018-01-19 Thread Julian Calaby
Hi Icenowy, On Sat, Jan 20, 2018 at 2:10 PM, Icenowy Zheng <icen...@aosc.io> wrote: > > > 于 2018年1月20日 GMT+08:00 上午11:06:40, Julian Calaby <julian.cal...@gmail.com> 写到: >>Hi Icenowy, >> >>On Sat, Jan 20, 2018 at 10:17 AM, Icenowy Zheng <icen...@aosc.io>

Re: [linux-sunxi] [RFC PATCH 2/9] ARM: sunxi: add Allwinner ARMv5 SoCs

2018-01-19 Thread Julian Calaby
gt; +menuconfig ARCH_SUNXI_V5 > + bool "Allwinner SoCs" That name seems a little too generic. Maybe "Allwinner ARMv5 SoCs"? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [RFC PATCH 1/9] ARM: add CONFIG_ARCH_SUNXI_V7 for differentiate ARMv5/v7 Allwinner SoCs

2018-01-19 Thread Julian Calaby
ONTROLLER > select CLKSRC_MMIO > select GENERIC_IRQ_CHIP Shouldn't you remove all the common ARCH_SUNXI selects from ARCH_SUNXI_v7? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH v2 13/16] power: supply: axp20x_battery: add support for AXP813

2018-01-09 Thread Julian Calaby
#define AXP22X_CHRG_CTRL1_TGT_4_24V(3 << 5) Should these be "alphabetical", i.e. AXP20X, AXP22X, AXP813? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 16/67] powerpc: rename dma_direct_ to dma_nommu_

2018-01-03 Thread Julian Calaby
>> The address on the device side is sometimes (often?) offset from the CPU >> address. So eg. the device can DMA to RAM address 0x0 using address >> 0x800. >> >> Identity would imply 0 == 0 etc. >> >> I think "bijective" is the co

Re: [PATCH 17/67] microblaze: rename dma_direct to dma_microblaze

2017-12-29 Thread Julian Calaby
Hi Christoph, On Fri, Dec 29, 2017 at 7:18 PM, Christoph Hellwig <h...@lst.de> wrote: > This frees the dma_direct_* namespace for a generic implementation. Don't you mean "dma_nommu" not "dma_microblaze" in the subject line? Thanks, -- Julian Calaby Email: ju

Re: [linux-sunxi] [PATCH 11/17] drm/sun4i: Wire in DE2 scaler support

2017-11-29 Thread Julian Calaby
ELPER_NO_SCALING; if (layer->mixer->cfg->scaler_mask & BIT(layer->id)) { min_scale = 1; max_scale = (1UL << 20) - 1; } However the compiler will probably sort it all out anyway, so it probably doesn't matter that much, except for style. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 5/5] wlcore: Use common error handling code in wl1271_op_suspend()

2017-10-30 Thread Julian Calaby
utex_unlock(>mutex); > > - if (ret < 0) { > - wl1271_warning("couldn't prepare device to suspend"); "couldn't enable power saving"? > - return ret; > - } > + if (ret < 0) > + goto report_prepa

Re: [PATCH 4/5] wlcore: Use common error handling code in wlcore_set_beacon_template()

2017-10-30 Thread Julian Calaby
tter > reused at the end of this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> However, > --- > drivers/net/wireless/ti/w

Re: [PATCH 3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_template()

2017-10-30 Thread Julian Calaby
iled at the beginning. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

2017-10-30 Thread Julian Calaby
_off(wl); > + goto out_free_nvs; Why not put this in front of the out_free_nvs label? It looks weird here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/5] wlcore: Delete an unnecessary check statement in wlcore_set_beacon_template()

2017-10-30 Thread Julian Calaby
y without the specification of useful actions between. > Thus remove such unnecessary source code at the end of this function. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Looks good to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> -- Julia

Re: [linux-sunxi] [PATCH v4 02/11] drm/sun4i: tcon: Add support for demuxing TCON output on A31

2017-10-11 Thread Julian Calaby
..@csie.org> Thanks! FWIW this is: Reviewed-by: Julian Calaby <julian.cal...@gmail.com> -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] Re: [PATCH v3 04/14] drm/sun4i: tcon: Add support for demuxing TCON output on A31

2017-09-30 Thread Julian Calaby
Hi Chen-Yu, On Sat, Sep 30, 2017 at 3:58 PM, Chen-Yu Tsai <w...@csie.org> wrote: > On Sat, Sep 30, 2017 at 1:35 PM, Julian Calaby <julian.cal...@gmail.com> > wrote: >> Hi Chen-Yu, >> >> On Fri, Sep 29, 2017 at 8:22 PM, Chen-Yu Tsai <w...@csie.org>

Re: [linux-sunxi] Re: [PATCH v3 04/14] drm/sun4i: tcon: Add support for demuxing TCON output on A31

2017-09-29 Thread Julian Calaby
rs, > which > are only available in TCON0. Other than that, there's nothing else > shared between > the two TCONs. So there's no particular reason to look for TCON1 explicitly. In that case: in the bizarre case where we're trying to use this mux type and there is no TCON0, shouldn't we fail? (Also, the code doesn't make sense if we have some TCON1 and TCON2 in that order as it'll return TCON2) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 3/4] arm64: allwinner: h5: add compatible string for DE2 CCU

2017-09-16 Thread Julian Calaby
compatible = "allwinner,sun50i-h5-de2-clk"; > +}; > + This is what I get for reviewing before reading the full patch set. Shouldn't this be rolled into the previous patch? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 2/4] ARM: sun8i: h3/h5: add DE2 CCU device node for H3

2017-09-16 Thread Julian Calaby
e-cells = <1>; > ranges; > > + display_clocks: clock@100 { > + /* compatible is in per SoC .dtsi file */ I don't know device tree very well, but shouldn't this node be disabled so that it doesn't do anything weird on H5? Or are n

Re: [v6] wlcore: add missing nvs file name info for wilink8

2017-08-10 Thread Julian Calaby
>> Well clearly at least this one does not have any valid hardware >> mac address, the hardware mac address is broken with all zeroes. >> > > Looks like it is not really all zeros but rather 00:00:00:00:00:01. > I wonder if it is just a one board issue or not... It's 0

Re: [v4] wlcore: add missing nvs file name info for wilink8

2017-08-04 Thread Julian Calaby
"be removed as a default mac address is " > + "stored internally.\n"); > + > + /* Use TI oui and a random nic */ > + oui = 0x080028; Is there (or should there be) a constant for this? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Julian Calaby
Hi Nitin, On Fri, Jun 23, 2017 at 12:37 AM, Nitin Gupta <nitin.m.gu...@oracle.com> wrote: > Hi Julian, > > > On 6/22/17 3:53 AM, Julian Calaby wrote: >> >> On Thu, Jun 22, 2017 at 7:50 AM, Nitin Gupta <nitin.m.gu...@oracle.com> >> wrote: >>> &g

Re: [PATCH] sparc64: Fix gup_huge_pmd

2017-06-22 Thread Julian Calaby
gt; + if (PageTail(head)) > + head = compound_head(head); Stupid question: shouldn't this go before the page calculation? > do { > VM_BUG_ON(compound_head(page) != head); > pages[*nr] = page; Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 28/44] sparc: remove arch specific dma_supported implementations

2017-06-08 Thread Julian Calaby
nc_sg_for_cpu= sbus_sync_sg_for_cpu, > .sync_sg_for_device = sbus_sync_sg_for_device, > + .dma_supported = sbus_dma_supported, > }; > > static int __init sparc_register_ioport(void) Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 5/15] clk: sunxi-ng: sun5i: Export video PLLs

2017-03-07 Thread Julian Calaby
; -#define CLK_PLL_VIDEO1_2X 16 > > +/* The PLL_VIDEO0_2X is exported for HDMI */ PLL_VIDEO*1*_2X, right? > /* The CPU clock is exported */ > > #define CLK_AXI18 Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 3/3] Staging:wilc1000:host_interface: Integrated two 'if' statements to a single 'if' statement

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 2:38 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Removed unnecessary 'if' statement and integrated the condition to the > previous 'if' statement. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: J

Re: [PATCH 2/3] Staging:wilc1000:host_interface: Fixed alignment to match open parenthesis

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 2:37 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Fixed alignment to match open parenthesis. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > -

Re: [PATCH 1/3] Staging:wilc1000:host_interface: Removed unnecessary blank line

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 2:35 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Removed unnecessary blank line. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > drivers/stag

Re: [PATCH] Staging:wilc1000:wilc_sdio: Modified comment style to preferred kernel comment style

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 3:41 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Modified comment style to preferred kernel comment style. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > -

Re: [PATCH] Staging:wilc1000:linux_wlan: Modified the 'if-else' statement

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 3:14 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Modified the 'if-else' statement to make it more readable. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Again, I'm dubious if this is needed or helpful, but Revie

Re: [PATCH 4/4] Staging:wilc1000:wilc_spi: Added blank line after function and modified comment style

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 4:07 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Added blank line after function and modified comment style. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Re: [PATCH 3/4] Staging:wilc1000:wilc_spi: Fixed spelling error

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 4:06 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Fixed spelling error. 'unkmown' to 'unknown'. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > dr

Re: [PATCH 2/4] Staging:wilc1000:wilc_spi: Fixed alignment to match parenthesis

2017-03-04 Thread Julian Calaby
Hi All, On Fri, Mar 3, 2017 at 4:05 AM, Georgios Emmanouil <geo.em...@gmail.com> wrote: > Fixed alignment to match parenthesis. > > Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > driver

Re: [PATCH 1/4] Staging:wilc1000:wilc_spi: Fixed comment style to the preferred kernel comment style

2017-03-04 Thread Julian Calaby
; Signed-off-by: Georgios Emmanouil <geo.em...@gmail.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > drivers/staging/wilc1000/wilc_spi.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) -- Julian Calaby Email: julian.cal...@gmail.com Profil

Re: [linux-sunxi] Re: [PATCH 1/2] nvmem: sunxi-sid: add support for H3 and A64's SID controller

2017-01-27 Thread Julian Calaby
return PTR_ERR(nvmem); >> >> - randomness = kzalloc(sizeof(u8) * (size), GFP_KERNEL); >> + randomness_size = max(size, SUNXI_SID_MAX_RANDOMNESS_SIZE); >> + randomness = kzalloc(sizeof(u8) * (randomness_size), GFP_KERNEL); > > Why is that change needed? According to the definition of SUNXI_SID_MAX_RANDOMNESS_SIZE, only the first 16 bytes of the SID data region are sufficiently non-zero to be used for randomness. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] ssb: main.c: This patch removes unnecessary return statement using spatch tool

2017-01-06 Thread Julian Calaby
} > - size = (1 << (size + 1)); > - > - return size; > + return (1 << (size + 1)); Is the size variable used elsewhere? If not, it's declaration should probably be removed. Also, there should be a blank line before the return statement. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h

2016-12-16 Thread Julian Calaby
184 > +#define D7S_MINOR 193 I was going to say "why not change the name to something more descriptive" however they're all very abbreviated, so maybe consider a second patch series to describe what each of these is for? > #define VFIO_MINOR 196

Re: [PATCH] mwifiex: fix null pointer deference when adapter is null

2016-09-15 Thread Julian Calaby
nter dereference. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [Patch] Wireless Driver rsi changes: Firmware loading and device initialization changed for RSI-91x devices

2016-09-06 Thread Julian Calaby
not attached 3. Improve the subject as described in the linked document Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
.) Moving four assignments because you think they might improve stuff is just annoying people. >> He's not another Nick Krause. > > Are you going to remember me under an other nickname anyhow? Nick Krause submitted patches that make yours look good. At least yours compile. Thanks

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
tle more than moving stuff around pointlessly. I really wish he'd concentrate on the former rather than the latter. He's not another Nick Krause. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
software module. What benefits? You have not proved that this change produces any useful benefits. >> and wasting everyone's time in the process. > > I assume that a few contributors can take the presented ideas for further > considerations. > Will their value evolve a bit more

Re: [PATCH 2/4] sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
;> at the top of the file then ok, > > I see another software design option where the transformation result might be > looking > more pleasing for you again. > > >> but why all the way down here? > > * How do you think about the reason I gave in the short commit me

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
things, there is absolutely no reason to take them as-is - you are making the code longer and more difficult to read for no benefit and wasting everyone's time in the process. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/2] mwifiex: simplify length computation for some memset

2016-09-03 Thread Julian Calaby
T <christophe.jail...@wanadoo.fr> Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 2/4] sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-03 Thread Julian Calaby
) { > u8 seen_or_pass0 = (pass == 0) ? (SEEN_XREG | SEEN_DATAREF | > SEEN_MEM) : seen; This is utterly pointless, why? If you were moving the assignments on declaration onto separate lines at the top of the file then ok, but why all the way down here? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

2016-09-03 Thread Julian Calaby
hes <j...@perches.com> This all looks correct to me. I wish you'd put the code changes in a separate patch, however it's all noted in the commit log, so... Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] staging: wilc1000: fix spelling mistake: "retyring" -> "retrying"

2016-09-03 Thread Julian Calaby
Hi All, On Sun, Aug 28, 2016 at 9:28 PM, Colin King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > trivial fix to spelling mistake in dev_err message > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Revie

Re: [PATCH] rtl8xxxu: fix spelling mistake "firmare" -> "firmware"

2016-09-03 Thread Julian Calaby
Hi All, On Sun, Sep 4, 2016 at 2:43 AM, Colin King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistakes in dev_dbg message. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Revie

Re: [PATCH] ath10k: fix spelling mistake "montior" -> "monitor"

2016-08-27 Thread Julian Calaby
Hi All, On Sat, Aug 27, 2016 at 4:08 AM, Colin King <colin.k...@canonical.com> wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in ath10k_warn message. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Revie

Re: [PATCH] zd1211rw: fix spelling mistake "firmeware" -> "firmware"

2016-08-24 Thread Julian Calaby
right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 2/9] mfd: axp20x: Add support for AXP806 PMIC

2016-08-20 Thread Julian Calaby
Hi Chen-Yu, On Sun, Aug 21, 2016 at 12:11 PM, Chen-Yu Tsai <w...@csie.org> wrote: > The X-Powers AXP809 is a new PMIC that is paired with Allwinner's A80 > SoC, along with a master AXP809 PMIC. The first "AXP809" should be "AXP806". Thanks, -- Julian Calaby

Re: [PATCH 2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

2016-08-20 Thread Julian Calaby
goto out; > - } else if (ap_ioctl) > + else if (ap_ioctl) > ret = 0; > } > > - out: Does this change make any difference to the compiled code? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 2/2] ASoC: sunxi: compatibility for sun6i to SPDIF

2016-07-30 Thread Julian Calaby
TES; > > platform_set_drvdata(pdev, host); > > + if (of_device_is_compatible(pdev->dev.of_node, > + "allwinner,sun6i-a31-spdif")) { Given how much Allwinner likes to shuffle stuff around with each SoC generation, would it make sense to add a f

Re: [PATCH 2/3] staging: wilc1000: One function call less in mac_ioctl() after error detection

2016-07-28 Thread Julian Calaby
micro-optimisation: kfree(NULL) is perfectly valid and buff is either malloc'd memory or NULL when it's called. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH] regulator: axp20x: support AXP813 variant

2016-07-28 Thread Julian Calaby
mp;& i == AXP809_DCDC1)) > + (regulators == axp809_regulators && i == AXP809_DCDC1) || > + (regulators == axp813_regulators && i == AXP813_DCDC1)) Ditto. > of_property_read_string(rdev->dev.of_node, >

Re: [PATCH] mwifiex: fix unconditional error return in .add_virtual_intf callback

2016-07-03 Thread Julian Calaby
> interface") > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Looks correct to me as Dan Carpenter submitted the same fix. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 0/4] Mesh mpm fixes and enhancements

2016-06-28 Thread Julian Calaby
sely Patches that you send must be signed off by you, not ack'd by you. I.e. From: Random Developer <random.develo...@company.com> . Signed-off-by: Random Developer <random.develo...@company.com> Signed-off-by: Patch Sender <patch.sen...@company.com> Thanks, --

Re: [PATCH] [linux-next] rtlwifi: Fix typo in printk

2016-06-28 Thread Julian Calaby
Hi All, On Wed, Jun 29, 2016 at 1:37 PM, Masanari Iida <standby2...@gmail.com> wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida <standby2...@gmail.com> Looks right to me. Reviewed-by: Julian Calaby <julian.c

Re: [PATCH] sparc64: sparc64_defconfig: convert to use libata PATA drivers

2016-06-27 Thread Julian Calaby
t driver. I believe the Ultra 10 uses the same motherboard so it's likely also affected. I believe these were in the first generation of "PC" like SPARC workstations. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One

2016-06-23 Thread Julian Calaby
t;130>; > + regulator-boot-on; > + regulator-type = "voltage"; > + > + gpios = <_pio 0 6 GPIO_ACTIVE_HIGH>; > + states = <110 0x0 > + 130 0x1>; > + > + startu

Re: [linux-sunxi] [PATCH 11/14] ARM: sun8i: clk: Add clk-factor rate application method

2016-06-23 Thread Julian Calaby
-- > 4 files changed, 98 insertions(+), 22 deletions(-) Shouldn't the .dtsi changes be in a separate patch? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One

2016-06-23 Thread Julian Calaby
t;130>; > + regulator-boot-on; > + regulator-type = "voltage"; > + > + gpios = <_pio 0 6 GPIO_ACTIVE_HIGH>; > + states = <110 0x0 > + 1300000 0x1>; > + > + start

Re: [PATCH] staging: wilc1000: fix spelling mistake: "interupts" -> "interrupts"

2016-06-23 Thread Julian Calaby
right to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] staging: wilc1000: arrays can't be NULL

2016-06-23 Thread Julian Calaby
Hi Luis, On Fri, Jun 24, 2016 at 9:50 AM, Luis de Bethencourt <lui...@osg.samsung.com> wrote: > On 24/06/16 00:15, Julian Calaby wrote: >> Hi Joe, >> >> On Fri, Jun 24, 2016 at 5:24 AM, Joe Perches <j...@perches.com> wrote: >>> On Thu, 2016-06-23

Re: [PATCH] staging: wilc1000: arrays can't be NULL

2016-06-23 Thread Julian Calaby
Maybe I should send a hit to the >> kernelnewbies mailing list :) > > Or not. > > really_long_identifiers™ makes using 80 columns silly. > > The hungarian could probably be converted though. The main developers of this driver are slowly working through the driver's style issu

Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

2016-06-23 Thread Julian Calaby
Hi Luis, On Thu, Jun 23, 2016 at 9:25 PM, Luis de Bethencourt <lui...@osg.samsung.com> wrote: > On 23/06/16 02:29, Julian Calaby wrote: >> Hi All, >> >> On Wed, Jun 22, 2016 at 10:39 PM, Luis de Bethencourt >> <lui...@osg.samsung.com> wrote: >>> T

Re: [PATCH] staging: wilc1000: fix error handling in wilc_debugfs_init()

2016-06-22 Thread Julian Calaby
returning -EINVAL instead of -1 is more > appropriate. These two changes could be argued to be separate changes deserving of their own patches. > Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> However if everyone else is ok with that, this is: Reviewed-by: Julian Calaby <

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
Hi Joe, On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <j...@perches.com> wrote: > On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote: >> Hi Joe, > > rehi Julian. (I always put a salutation on my emails and always finish them with "Thanks," =) ) >>

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
Hi Joe, On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <j...@perches.com> wrote: > On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote: >> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c > > just fyi: the script name is not plural Thanks, must have typo

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
si/vmw_pvscsi.c or ./scripts/get_maintainers.pl patchfile.patch Thanks, Julian Calaby > > Thanks! > Arvind > ________ > From: Julian Calaby <julian.cal...@gmail.com> > Sent: Thursday, June 16, 2016 6:48 PM > To: Jim Gill > Cc: j...@linu

Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

2016-06-16 Thread Julian Calaby
1301 > USA. > * > - * Maintained by: Arvind Kumar <arvindku...@vmware.com> > + * Maintained by: Jim Gill <jg...@vmware.com> Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant? Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] sparc64: Swap registers for fault code and address in mna trap

2016-06-16 Thread Julian Calaby
put the kernel version this applies to below the "---". > Signed-off-by: Hisashi Kanda <hika...@zlab.co.jp> > > --- i.e. here. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver

2016-06-14 Thread Julian Calaby
Hi Michal, On Tue, Jun 14, 2016 at 4:35 PM, Michal Suchanek <hramr...@gmail.com> wrote: > Hello, > > On 14 June 2016 at 07:45, Julian Calaby <julian.cal...@gmail.com> wrote: >> Hi Michal, >> >> On Tue, Jun 14, 2016 at 3:28 PM, Michal Suchanek <hramr...@g

Re: [linux-sunxi] [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver

2016-06-13 Thread Julian Calaby
Hi Michal, On Tue, Jun 14, 2016 at 3:28 PM, Michal Suchanek <hramr...@gmail.com> wrote: > On 14 June 2016 at 06:47, Julian Calaby <julian.cal...@gmail.com> wrote: >> Hi Michal, >> >> On Tue, Jun 14, 2016 at 2:34 PM, Michal Suchanek <hramr...@gmail.com> wr

Re: [linux-sunxi] [PATCH v3 11/13] dt: spi: sun4i: merge sun4i and sun6i binding doc

2016-06-13 Thread Julian Calaby
Hi Michal, On Tue, Jun 14, 2016 at 2:40 PM, Michal Suchanek <hramr...@gmail.com> wrote: > On 14 June 2016 at 01:45, Julian Calaby <julian.cal...@gmail.com> wrote: >> Hi Michal, >> >> On Tue, Jun 14, 2016 at 3:46 AM, Michal Suchanek <hramr...@gmail.com> wr

Re: [linux-sunxi] [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver

2016-06-13 Thread Julian Calaby
Hi Michal, On Tue, Jun 14, 2016 at 2:34 PM, Michal Suchanek <hramr...@gmail.com> wrote: > Hello, > > On 14 June 2016 at 01:43, Julian Calaby <julian.cal...@gmail.com> wrote: >> Hi Michal, >> >> On Tue, Jun 14, 2016 at 3:46 AM, Michal Suchanek <hramr...@

Re: [linux-sunxi] [PATCH v3 11/13] dt: spi: sun4i: merge sun4i and sun6i binding doc

2016-06-13 Thread Julian Calaby
nterrupts = <11>; > - clocks = <_gates 21>, <_clk>; > +spi1: spi@01c69000 { > + compatible = "allwinner,sun6i-a31-spi"; > + reg = <0x01c69000 0x1000>; > + interrupts = <0 66 4>; > + clocks = <_gates 21&

Re: [linux-sunxi] [PATCH v3 10/13] spi: sunxi: merge sun4i and sun6i SPI driver

2016-06-13 Thread Julian Calaby
, > + )) { > + pr_err(", %s", str); > + i++; > + } > + } > + ret = -EINVAL; > + goto err_free_master; > + } > + > master->max_speed_hz = 100 * 1000 * 1000; > master->min_speed_hz = 3 * 1000; > master->set_cs = sunxi_spi_set_cs; Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH v3 07/13] spi: sunxi: rename constants to match between sun4i and sun6i

2016-06-13 Thread Julian Calaby
0x1c > #define SUNXI_FIFO_STA_RF_CNT_MASK 0x7f My gut feeling on this is that we have a lot of cases of a definition of a register offset, then definitions of the bits in that register with that register encoded into the constant's name. You appear to be throwing a lot of that information away which makes me worry. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] scsi:stex.c Support Pegasus 3 product

2016-06-13 Thread Julian Calaby
Hi Charles, On Mon, Jun 13, 2016 at 9:40 PM, Charles Chiou <ch1102ch...@gmail.com> wrote: > Hi Julian, > > > On 06/10/2016 08:10 AM, Julian Calaby wrote: >> >> Hi Charles, >> >> On Mon, Jun 6, 2016 at 5:53 PM, Charles Chiou <ch1102ch...@gmail.com

Re: [PATCH] scsi:stex.c Support Pegasus 3 product

2016-06-09 Thread Julian Calaby
e unrelated whitespace changes. > before = jiffies; > while (hba->ccb[tag].req_type & PASSTHRU_REQ_TYPE) { > if (time_after(jiffies, before + ST_INTERNAL_TIMEOUT * HZ)) { > @@ -1821,24 +1954,29 @@ static void stex_remove(struct pci_dev *pdev) > scsi_host_put(hba->host); > > pci_disable_device(pdev); > + > + unregister_reboot_notifier(_notifier); Again, not P3 specific. > } > > static void stex_shutdown(struct pci_dev *pdev) > { > struct st_hba *hba = pci_get_drvdata(pdev); > - > - if (hba->supports_pm == 0) > + if (hba->supports_pm == 0) { > stex_hba_stop(hba, ST_IGNORED); > - else > + } else if (hba->supports_pm == 1 && S6flag) { > + unregister_reboot_notifier(_notifier); > + stex_hba_stop(hba, ST_S6); > + } else Also not P3 specific. > stex_hba_stop(hba, ST_S5); > } > > -static int stex_choice_sleep_mic(pm_message_t state) > +static int stex_choice_sleep_mic(struct st_hba *hba, pm_message_t state) > { > switch (state.event) { > case PM_EVENT_SUSPEND: > return ST_S3; > case PM_EVENT_HIBERNATE: > + hba->msi_lock = 0; > return ST_S4; > default: > return ST_NOTHANDLED; > @@ -1864,6 +2003,13 @@ static int stex_resume(struct pci_dev *pdev) > stex_handshake(hba); > return 0; > } > + > +static int stex_halt(struct notifier_block *nb, unsigned long event, void > *buf) > +{ > + S6flag = 1; > + return NOTIFY_OK; > +} > + And again. Why is this needed? > MODULE_DEVICE_TABLE(pci, stex_pci_tbl); > > static struct pci_driver stex_pci_driver = { > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

2016-06-08 Thread Julian Calaby
xists, has that number, takes arguments in that format and works? Thanks, Julian Calaby > On Wed, Jun 8, 2016 at 8:16 PM, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Prasun Maiti <prasunmait...@gmail.com> writes: >> >>> No. I did not any test for that cas

Re: [PATCH] Drivers: ssb: Fix bare unsigned and changed to trailing comments

2016-06-04 Thread Julian Calaby
Hugh Sipiere <hgsipi...@gmail.com> You should separate the changes into two patches, one to change "unsigned" to "unsigned int" and one to fix the comments. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

2016-06-01 Thread Julian Calaby
enable-sdio-wakeup; > + > + brcmf: bcrmf@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + interrupt-parent = <>; > + interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; > + interrupt-names = "host-wake"; > + }; > + Extra line. > +}; > + > +_pins_a { > +/* AP6210 requires pull-up */ Should this be indented the same as the following line? > + allwinner,pull = ; > +}; > + Extra line. Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

2016-06-01 Thread Julian Calaby
Hi Javier, On Wed, Jun 1, 2016 at 11:51 PM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > Hello Julian, > > Thanks a lot for your feedback and reviews. > > On 06/01/2016 12:20 AM, Julian Calaby wrote: >> Hi All, >> >> On Sat, May 28, 2016 at 12:

Re: [PATCH 8/8] mwifiex: use better message and error code when OF node doesn't match

2016-05-31 Thread Julian Calaby
ppropriate one. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++-- > 1 file changed, 2 insertions(+)

Re: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

2016-05-31 Thread Julian Calaby
the property being missed shouldn't be treated as an error. Have you checked whether it is truly optional? I.e. nothing else breaks if this property isn't set? > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Other than that, this looks sensible to me. Reviewed-by: Juli

Re: [PATCH 6/8] mwifiex: check if mwifiex_sdio_probe_of() fails and return error

2016-05-31 Thread Julian Calaby
av...@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks, -- Julian Calaby Email: julian.cal...@gmail.c

Re: [PATCH 4/8] mwifiex: consolidate mwifiex_sdio_probe() error paths

2016-05-31 Thread Julian Calaby
t; > This also has the nice side effect that the cleanup operations are made > in the inverse order of their counterparts, which was not the case for > the mwifiex_add_card() error path. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sens

Re: [PATCH 3/8] mwifiex: propagate mwifiex_add_card() errno code in mwifiex_sdio_probe()

2016-05-31 Thread Julian Calaby
the first function that failed. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks sensible to me. Reviewed-by: Julian Calaby <julian.cal...@gmail.com> > --- > > drivers/net/wireless/marvell/mwifiex/sdio.c | 8 > 1 file changed,

Re: [PATCH 5/8] mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe()

2016-05-31 Thread Julian Calaby
Hi All, On Sat, May 28, 2016 at 12:18 AM, Javier Martinez Canillas <jav...@osg.samsung.com> wrote: > It's better to have the device name prefixed in the error message. > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> This looks right to me. Revie

  1   2   3   >