[PATCH] block: Add nr_bios to block_rq_remap tracepoint

2013-09-17 Thread Jun'ichi Nomura
/2013-August/msg00084.html http://www.redhat.com/archives/dm-devel/2013-September/msg00024.html Signed-off-by: Jun'ichi Nomura Acked-by: Mike Snitzer Cc: Jens Axboe diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 2fdb4a4..0e6f765 100644 --- a/include/linux/blkdev.h +++ b

[PATCH] block: Add nr_bios to block_rq_remap tracepoint

2013-09-17 Thread Jun'ichi Nomura
/2013-August/msg00084.html http://www.redhat.com/archives/dm-devel/2013-September/msg00024.html Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com Acked-by: Mike Snitzer snit...@redhat.com Cc: Jens Axboe ax...@kernel.dk diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 2fdb4a4

Re: [dm-devel] [PATCH] dm: allow error target to replace either bio-based and request-based targets

2013-08-22 Thread Jun'ichi Nomura
stent. I.e. for the above case, the error message should be "Request-based dm doesn't support multiple targets yet", not "Inconsistent table: different target types can't be mixed up". --- Jun'ichi Nomura, NEC Corporation diff --git a/drivers/md/dm-table.c b/drivers/md/dm-tabl

Re: [dm-devel] [PATCH] dm: allow error target to replace either bio-based and request-based targets

2013-08-22 Thread Jun'ichi Nomura
multiple targets yet, not Inconsistent table: different target types can't be mixed up. --- Jun'ichi Nomura, NEC Corporation diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index f221812..6e683c8 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -860,14 +860,16

[PATCH repost] blkcg: fix "scheduling while atomic" in blk_queue_bypass_start

2013-02-25 Thread Jun'ichi Nomura
ctl+0x13/0x17 [dm_mod] [] do_vfs_ioctl+0x3fb/0x441 [] ? file_has_perm+0x8a/0x99 [] sys_ioctl+0x5e/0x82 [] ? trace_hardirqs_on_thunk+0x3a/0x3f [] system_call_fastpath+0x16/0x1b Signed-off-by: Jun'ichi Nomura Acked-by: Vivek Goyal Acked-by: Tejun Heo Cc: Jens Axboe Cc: Alasdair G Kergo

[PATCH repost] blkcg: fix scheduling while atomic in blk_queue_bypass_start

2013-02-25 Thread Jun'ichi Nomura
[812010be] ? trace_hardirqs_on_thunk+0x3a/0x3f [814310d9] system_call_fastpath+0x16/0x1b Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com Acked-by: Vivek Goyal vgo...@redhat.com Acked-by: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk Cc: Alasdair G Kergon

[PATCH repost] blkcg: fix "scheduling while atomic" in blk_queue_bypass_start

2013-01-07 Thread Jun'ichi Nomura
? table_clear+0xaa/0xaa [dm_mod] [] dm_ctl_ioctl+0x13/0x17 [dm_mod] [] do_vfs_ioctl+0x3fb/0x441 [] ? file_has_perm+0x8a/0x99 [] sys_ioctl+0x5e/0x82 [] ? trace_hardirqs_on_thunk+0x3a/0x3f [] system_call_fastpath+0x16/0x1b Signed-off-by: Jun'ichi Nomura Acked-by: Vivek Goyal Cc:

[PATCH repost] blkcg: fix scheduling while atomic in blk_queue_bypass_start

2013-01-07 Thread Jun'ichi Nomura
[81147aa0] sys_ioctl+0x5e/0x82 [812010be] ? trace_hardirqs_on_thunk+0x3a/0x3f [814310d9] system_call_fastpath+0x16/0x1b Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com Acked-by: Vivek Goyal vgo...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: Jens Axboe ax

[PATCH] blkcg: fix "scheduling while atomic" in blk_queue_bypass_start

2012-10-29 Thread Jun'ichi Nomura
0x1d6/0x236 [dm_mod] [] ? table_clear+0xaa/0xaa [dm_mod] [] dm_ctl_ioctl+0x13/0x17 [dm_mod] [] do_vfs_ioctl+0x3fb/0x441 [] ? file_has_perm+0x8a/0x99 [] sys_ioctl+0x5e/0x82 [] ? trace_hardirqs_on_thunk+0x3a/0x3f [] system_call_fastpath+0x16/0x1b Signed-off-by: Jun'ichi Nomura Cc: Vi

Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page

2012-10-29 Thread Jun'ichi Nomura
For IO errors come from disk failure, next read will likely fail again so we don't have to remember it somewhere. >> Also, if you're going to keep this state in memory, what happens if >> the inode gets pushed out of memory? > > You lose the error, just like you do today wi

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-29 Thread Jun'ichi Nomura
On 10/27/12 05:21, Vivek Goyal wrote: > On Thu, Oct 25, 2012 at 06:41:11PM +0900, Jun'ichi Nomura wrote: >> [PATCH] dm: stay in blk_queue_bypass until queue becomes initialized >> >> With 749fefe677 ("block: lift the initial queue bypass mode on >&

Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page

2012-10-29 Thread Jun'ichi Nomura
read will likely succeed reading old data from disk in case of the memory error. I'm afraid the read-after-write inconsistency could cause silent data corruption. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page

2012-10-29 Thread Jun'ichi Nomura
read will likely fail again so we don't have to remember it somewhere. Also, if you're going to keep this state in memory, what happens if the inode gets pushed out of memory? You lose the error, just like you do today with any other IO error. -- Jun'ichi Nomura, NEC Corporation

[PATCH] blkcg: fix scheduling while atomic in blk_queue_bypass_start

2012-10-29 Thread Jun'ichi Nomura
] ? trace_hardirqs_on_thunk+0x3a/0x3f [814310d9] system_call_fastpath+0x16/0x1b Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com Cc: Vivek Goyal vgo...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk Cc: Alasdair G Kergon a...@redhat.com --- block/blk-cgroup.c |4

Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page

2012-10-29 Thread Jun'ichi Nomura
-overs in storage stack and not visible to applications which don't care.) So it's consistent in some sense. OTOH, the next read will likely succeed reading old data from disk in case of the memory error. I'm afraid the read-after-write inconsistency could cause silent data corruption. -- Jun'ichi

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-29 Thread Jun'ichi Nomura
On 10/27/12 05:21, Vivek Goyal wrote: On Thu, Oct 25, 2012 at 06:41:11PM +0900, Jun'ichi Nomura wrote: [PATCH] dm: stay in blk_queue_bypass until queue becomes initialized With 749fefe677 (block: lift the initial queue bypass mode on blk_register_queue() instead of blk_init_allocated_queue

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-25 Thread Jun'ichi Nomura
On 10/25/12 18:41, Jun'ichi Nomura wrote: > With 749fefe677 ("block: lift the initial queue bypass mode on > blk_register_queue() instead of blk_init_allocated_queue()"), > add_disk() eventually calls blk_queue_bypass_end(). > This change invokes the following warning

[PATCH 1/2] block: move blk_queue_bypass_{start,end} to include/linux/blkdev.h

2012-10-25 Thread Jun'ichi Nomura
[PATCH] block: move blk_queue_bypass_{start,end} to include/linux/blkdev.h dm wants to use those functions to control the bypass status of half-initialized device. This patch is a preparation for: [PATCH] dm: stay in blk_queue_bypass until queue becomes initialized Signed-off-by: Jun'ichi

[PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-25 Thread Jun'ichi Nomura
0m0.442s sys 0m6.861s If this additional cost is not negligible, we need a variant of add_disk() that does not end bypassing. Signed-off-by: Jun'ichi Nomura Cc: Vivek Goyal Cc: Tejun Heo Cc: Jens Axboe Cc: Alasdair G Kergon --- drivers/md/dm.c|4 1 file changed, 4 insertion

[PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-25 Thread Jun'ichi Nomura
of add_disk() that does not end bypassing. Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com Cc: Vivek Goyal vgo...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk Cc: Alasdair G Kergon a...@redhat.com --- drivers/md/dm.c|4 1 file changed, 4 insertions

[PATCH 1/2] block: move blk_queue_bypass_{start,end} to include/linux/blkdev.h

2012-10-25 Thread Jun'ichi Nomura
[PATCH] block: move blk_queue_bypass_{start,end} to include/linux/blkdev.h dm wants to use those functions to control the bypass status of half-initialized device. This patch is a preparation for: [PATCH] dm: stay in blk_queue_bypass until queue becomes initialized Signed-off-by: Jun'ichi

Re: [PATCH 2/2] dm: stay in blk_queue_bypass until queue becomes initialized

2012-10-25 Thread Jun'ichi Nomura
On 10/25/12 18:41, Jun'ichi Nomura wrote: With 749fefe677 (block: lift the initial queue bypass mode on blk_register_queue() instead of blk_init_allocated_queue()), add_disk() eventually calls blk_queue_bypass_end(). This change invokes the following warning when multipath is used

[PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-21 Thread Jun'ichi Nomura
-off-by: Jun'ichi Nomura Cc: Vivek Goyal Cc: Tejun Heo Cc: Jens Axboe --- block/blk-cgroup.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 54f35d1..a31e678 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -333,6

Re: [PATCH] Fix use-after-free of q->root_blkg and q->root_rl.blkg

2012-10-21 Thread Jun'ichi Nomura
t;> check and original patch which I had acked. >> >> Can you please send another patch to change that? It really isn't a >> related change and I don't wanna mix the two. > > Sure. Jun'ichi, would you like to send that cleanup line in a separate patch? OK

Re: [PATCH] Fix use-after-free of q-root_blkg and q-root_rl.blkg

2012-10-21 Thread Jun'ichi Nomura
. Can you please send another patch to change that? It really isn't a related change and I don't wanna mix the two. Sure. Jun'ichi, would you like to send that cleanup line in a separate patch? OK. I will send that patch. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list

[PATCH] blkcg: stop iteration early if root_rl is the only request list

2012-10-21 Thread Jun'ichi Nomura
-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com Cc: Vivek Goyal vgo...@redhat.com Cc: Tejun Heo t...@kernel.org Cc: Jens Axboe ax...@kernel.dk --- block/blk-cgroup.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 54f35d1

Re: [PATCH] Fix use-after-free of q->root_blkg and q->root_rl.blkg

2012-10-17 Thread Jun'ichi Nomura
On 10/17/12 22:47, Vivek Goyal wrote: > On Wed, Oct 17, 2012 at 09:02:22AM +0900, Jun'ichi Nomura wrote: >> On 10/17/12 08:20, Tejun Heo wrote: >>>>>> -if (ent == >root_blkg->q_node) >>>>>> +if (q->root_blkg && ent == &g

[PATCH] blkcg: Fix use-after-free of q->root_blkg and q->root_rl.blkg

2012-10-17 Thread Jun'ichi Nomura
x1f7 > [] x86_64_start_reservations+0xb8/0xbd > [] x86_64_start_kernel+0x101/0x110 This patch clears q->root_blkg and q->root_rl.blkg when root blkg is destroyed. Signed-off-by: Jun'ichi Nomura Acked-by: Vivek Goyal Cc: Tejun Heo Cc: Jens Axboe --- v3: Removed a hunk for NULL-c

[PATCH] blkcg: Fix use-after-free of q-root_blkg and q-root_rl.blkg

2012-10-17 Thread Jun'ichi Nomura
[81cdb2dd] x86_64_start_reservations+0xb8/0xbd [81cdb3e3] x86_64_start_kernel+0x101/0x110 This patch clears q-root_blkg and q-root_rl.blkg when root blkg is destroyed. Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com Acked-by: Vivek Goyal vgo...@redhat.com Cc: Tejun Heo t

Re: [PATCH] Fix use-after-free of q-root_blkg and q-root_rl.blkg

2012-10-17 Thread Jun'ichi Nomura
On 10/17/12 22:47, Vivek Goyal wrote: On Wed, Oct 17, 2012 at 09:02:22AM +0900, Jun'ichi Nomura wrote: On 10/17/12 08:20, Tejun Heo wrote: -if (ent == q-root_blkg-q_node) +if (q-root_blkg ent == q-root_blkg-q_node) Can we fix it little differently. Little earlier in the code

Re: [PATCH] Fix use-after-free of q->root_blkg and q->root_rl.blkg

2012-10-16 Thread Jun'ichi Nomura
blkg_list again. > if (ent == >root_blkg->q_node) So ent is not >root_blkg->q_node. > ent = ent->next; > if (ent == >blkg_list) > return NULL; And we return NULL here. Ah, yes. You are correct. We can do without the abo

Re: [PATCH] Fix use-after-free of q-root_blkg and q-root_rl.blkg

2012-10-16 Thread Jun'ichi Nomura
is q-blkg_list again. if (ent == q-root_blkg-q_node) So ent is not q-root_blkg-q_node. ent = ent-next; if (ent == q-blkg_list) return NULL; And we return NULL here. Ah, yes. You are correct. We can do without the above hunk. -- Jun'ichi Nomura

Re: [PATCH] Fix use-after-free of q->root_blkg and q->root_rl.blkg

2012-10-10 Thread Jun'ichi Nomura
t list point of view > root blkg is gone and you can't get to it. (It might still be around for > some more time due to pending IOs though). > > Some minor comments below. > >> >> Signed-off-by: Jun'ichi Nomura >> >> diff --git a/block/blk-cgroup.c b/block/b

Re: [PATCH] Fix use-after-free of q-root_blkg and q-root_rl.blkg

2012-10-10 Thread Jun'ichi Nomura
due to pending IOs though). Some minor comments below. Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index f3b44a6..5015764 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -285,6 +285,9 @@ static void

[PATCH] Fix use-after-free of q->root_blkg and q->root_rl.blkg

2012-10-09 Thread Jun'ichi Nomura
110 blk_put_rl() does this: if (rl->blkg && rl->blkg->blkcg != _root) blkg_put(rl->blkg); but if rl is q->root_rl, rl->blkg might be a bogus pointer because blkcg_deactivate_policy() does not clear q->root_rl.blkg after blkg_destroy_all(). A

[PATCH] Fix use-after-free of q-root_blkg and q-root_rl.blkg

2012-10-09 Thread Jun'ichi Nomura
(). Attached patch works for me. Signed-off-by: Jun'ichi Nomura j-nom...@ce.jp.nec.com diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index f3b44a6..5015764 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -285,6 +285,9 @@ static void blkg_destroy_all(struct request_queue *q

Re: [dm-devel] [PATCH v8 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-09-05 Thread Jun'ichi Nomura
function do something like: pools->bs = (type == DM_TYPE_BIO_BASED) ? bioset_create(pool_size, 0) : bioset_create(pool_size, offsetof(struct dm_rq_clone_bio_info, clone)); -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this

Re: [dm-devel] [PATCH v8 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-09-05 Thread Jun'ichi Nomura
== DM_TYPE_BIO_BASED) ? bioset_create(pool_size, 0) : bioset_create(pool_size, offsetof(struct dm_rq_clone_bio_info, clone)); -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: [PATCH 3/3] HWPOISON: prevent inode cache removal to keep AS_HWPOISON sticky

2012-08-29 Thread Jun'ichi Nomura
aoya's patch will keep the failure information and allows the reader to get I/O error when it reads from broken pagecache. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/3] HWPOISON: prevent inode cache removal to keep AS_HWPOISON sticky

2012-08-29 Thread Jun'ichi Nomura
. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-13 Thread Jun'ichi Nomura
s = bioset_create(pool_size, > + offsetof(struct dm_rq_clone_bio_info, orig)); > if (!pools->bs) > goto free_tio_pool_and_out; Shouldn't this be offsetof(struct dm_rq_clone_bio_info, clone)? -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list:

Re: [PATCH 2/3] HWPOISON: undo memory error handling for dirty pagecache

2012-08-13 Thread Jun'ichi Nomura
ain instead of bad data. Also, ext3/ext4 has an option to panic when an error is detected, for people who want to avoid corruption on intermittent errors. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH 2/3] HWPOISON: undo memory error handling for dirty pagecache

2012-08-13 Thread Jun'ichi Nomura
when an error is detected, for people who want to avoid corruption on intermittent errors. -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v5 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info

2012-08-13 Thread Jun'ichi Nomura
, + offsetof(struct dm_rq_clone_bio_info, orig)); if (!pools-bs) goto free_tio_pool_and_out; Shouldn't this be offsetof(struct dm_rq_clone_bio_info, clone)? -- Jun'ichi Nomura, NEC Corporation -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] PCI: Remove default PCI expansion ROM memory allocation

2007-12-13 Thread Jun'ichi Nomura
Gary Hade wrote: > Remove default PCI expansion ROM memory allocation Thank you Gary for the new patch. By not allocating resources for expansion ROM, this patch will eliminate the problem that my patch masked, too: http://lkml.org/lkml/2007/12/4/284 Regards, -- Jun'ichi Nomura,

Re: [PATCH] PCI: Remove default PCI expansion ROM memory allocation

2007-12-13 Thread Jun'ichi Nomura
Gary Hade wrote: Remove default PCI expansion ROM memory allocation Thank you Gary for the new patch. By not allocating resources for expansion ROM, this patch will eliminate the problem that my patch masked, too: http://lkml.org/lkml/2007/12/4/284 Regards, -- Jun'ichi Nomura, NEC Corporation

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-05 Thread Jun'ichi Nomura
Gary Hade wrote: > On Tue, Dec 04, 2007 at 06:23:32PM -0500, Jun'ichi Nomura wrote: >> Kernel always tries to. But it's best effort basis, IMO. >> (Maybe your patch is going to fix that?) > > If you are seeing the allocation failures both with and > without m

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-05 Thread Jun'ichi Nomura
Gary Hade wrote: On Tue, Dec 04, 2007 at 06:23:32PM -0500, Jun'ichi Nomura wrote: Kernel always tries to. But it's best effort basis, IMO. (Maybe your patch is going to fix that?) If you are seeing the allocation failures both with and without my original patch I doubt that an improved

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Jun'ichi Nomura
Hi Gary, Gary Hade wrote: > On Tue, Dec 04, 2007 at 02:35:48PM -0500, Jun'ichi Nomura wrote: >> On a system with PCI-to-PCI bridges, following errors are observed: >> >> PCI: Failed to allocate mem resource #8:[EMAIL PROTECTED] for :02:00.0 >> PCI: Failed to allo

[PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Jun'ichi Nomura
confusing. This patch omits the error message if the resource is an expansion ROM or a bridge. Thanks, -- Jun'ichi Nomura, NEC Corporation of America Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- linux-2.6.24-rc3/drivers/pci/setup-res.c.orig 2007-12-04 00:24:11.0

[PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Jun'ichi Nomura
confusing. This patch omits the error message if the resource is an expansion ROM or a bridge. Thanks, -- Jun'ichi Nomura, NEC Corporation of America Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- linux-2.6.24-rc3/drivers/pci/setup-res.c.orig 2007-12-04 00:24:11.0 -0500

Re: [PATCH] pci: Omit error message for benign allocation failure

2007-12-04 Thread Jun'ichi Nomura
Hi Gary, Gary Hade wrote: On Tue, Dec 04, 2007 at 02:35:48PM -0500, Jun'ichi Nomura wrote: On a system with PCI-to-PCI bridges, following errors are observed: PCI: Failed to allocate mem resource #8:[EMAIL PROTECTED] for :02:00.0 PCI: Failed to allocate mem resource #6:[EMAIL PROTECTED

[PATCH] dm: Fix panic on shrinking device size

2007-10-30 Thread Jun'ichi Nomura
count=1 & echo "Wait til dd push some I/O" sleep 5 dmsetup resume ${MAP} ------ Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- dm-ioctl.c | 10 +++--- dm-table.c |3 +++ dm.c | 24 +

[PATCH] dm: Fix panic on shrinking device size

2007-10-30 Thread Jun'ichi Nomura
push some I/O sleep 5 dmsetup resume ${MAP} -- Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- dm-ioctl.c | 10 +++--- dm-table.c |3 +++ dm.c | 24 ++-- 3 files changed, 24

Re: [dm-devel] [PATCH] dm: noflush resizing (0/3)

2007-10-25 Thread Jun'ichi Nomura
Alasdair, Jun'ichi Nomura wrote: > So as far as I understand, the point is: > 1. it's preferable to resize inode after the resume, if possible Attached is a modified version of the (2/3) patch. - The logic is basically the same as before. - Moved the set-size function outside of the

Re: [dm-devel] [PATCH] dm: noflush resizing (0/3)

2007-10-25 Thread Jun'ichi Nomura
Kergon wrote: > On Thu, Oct 25, 2007 at 10:18:02AM -0400, Jun'ichi Nomura wrote: >> There is no guarantee that the I/O flowing through the device again. >> The table might need be replaced again, but to do that, the resume >> should have been completed to l

Re: [dm-devel] [PATCH] dm: noflush resizing (0/3)

2007-10-25 Thread Jun'ichi Nomura
new bdev inode if there isn't. But dm wants to access bdev inode only when it exists in memory. So something like bdlookup() will fit for the purpose, IMO. Thanks, -- Jun'ichi Nomura, NEC Corporation of America - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [dm-devel] [PATCH] dm: noflush resizing (0/3)

2007-10-25 Thread Jun'ichi Nomura
bdlookup() will fit for the purpose, IMO. Thanks, -- Jun'ichi Nomura, NEC Corporation of America - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [dm-devel] [PATCH] dm: noflush resizing (0/3)

2007-10-25 Thread Jun'ichi Nomura
Kergon wrote: On Thu, Oct 25, 2007 at 10:18:02AM -0400, Jun'ichi Nomura wrote: There is no guarantee that the I/O flowing through the device again. The table might need be replaced again, but to do that, the resume should have been completed to let the userspace know it. Then the first

Re: [dm-devel] [PATCH] dm: noflush resizing (0/3)

2007-10-25 Thread Jun'ichi Nomura
Alasdair, Jun'ichi Nomura wrote: So as far as I understand, the point is: 1. it's preferable to resize inode after the resume, if possible Attached is a modified version of the (2/3) patch. - The logic is basically the same as before. - Moved the set-size function outside of the table

[PATCH] dm: noflush resizing (3/3) Allow table swapping with different size

2007-10-24 Thread Jun'ichi Nomura
This patch removes the check for whether the loaded table is going to change the device size and allows resizing of the dm device suspended with 'noflush'. Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- dm.c |5 - 1 file changed, 5 deletions(-) Index: linux-2.6.23.work/d

[PATCH] dm: noflush resizing (1/3) Add bdlookup()

2007-10-24 Thread Jun'ichi Nomura
or forever. Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- fs/block_dev.c| 27 +++ include/linux/fs.h|4 +++- include/linux/genhd.h |6 ++ 3 files changed, 36 insertions(+), 1 deletion(-) Index: linux-2.6.23.work/fs/block

[PATCH] dm: noflush resizing (2/3) Use bdlookup() on noflush suspend

2007-10-24 Thread Jun'ichi Nomura
s set via bd_set_size() and bd_set_size() is protected by bd_mutex. So I think bd_mutex is the lock we should use. Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- dm.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) Index: linux-2.6.23.work/

[PATCH] dm: noflush resizing (0/3)

2007-10-24 Thread Jun'ichi Nomura
, -- Jun'ichi Nomura, NEC Corporation of America - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] dm: noflush resizing (0/3)

2007-10-24 Thread Jun'ichi Nomura
, -- Jun'ichi Nomura, NEC Corporation of America - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] dm: noflush resizing (1/3) Add bdlookup()

2007-10-24 Thread Jun'ichi Nomura
or forever. Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- fs/block_dev.c| 27 +++ include/linux/fs.h|4 +++- include/linux/genhd.h |6 ++ 3 files changed, 36 insertions(+), 1 deletion(-) Index: linux-2.6.23.work/fs/block_dev.c

[PATCH] dm: noflush resizing (2/3) Use bdlookup() on noflush suspend

2007-10-24 Thread Jun'ichi Nomura
() and bd_set_size() is protected by bd_mutex. So I think bd_mutex is the lock we should use. Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- dm.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) Index: linux-2.6.23.work/drivers/md/dm.c

[PATCH] dm: noflush resizing (3/3) Allow table swapping with different size

2007-10-24 Thread Jun'ichi Nomura
This patch removes the check for whether the loaded table is going to change the device size and allows resizing of the dm device suspended with 'noflush'. Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- dm.c |5 - 1 file changed, 5 deletions(-) Index: linux-2.6.23.work/drivers

[PATCH] device-mapper: fix bd_mount_sem corruption

2007-10-08 Thread Jun'ichi Nomura
d (%p)\n", atomic_read(>bdev.bd_mount_sem.count), >bdev); Without the patch, I saw something like: Incorrect semaphore count = 17 (f2ab91c0) With the patch, the message didn't appear. Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>

[PATCH] device-mapper: fix bd_mount_sem corruption

2007-10-08 Thread Jun'ichi Nomura
, atomic_read(ei-bdev.bd_mount_sem.count), ei-bdev); Without the patch, I saw something like: Incorrect semaphore count = 17 (f2ab91c0) With the patch, the message didn't appear. Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] diff --git a/drivers

Re: [2.6.23 PATCH 07/18] dm io: fix panic on large request

2007-07-17 Thread Jun'ichi Nomura
Patrick McHardy wrote: > Jun'ichi Nomura wrote: >> Are you using other dm modules such as dm-multipath, dm-mirror >> or dm-snapshot? >> If so, can you take the output of 'dmsetup table' and 'dmsetup ls'? > > No other modules. > >> Do you have a reliable way t

Re: [2.6.23 PATCH 07/18] dm io: fix panic on large request

2007-07-17 Thread Jun'ichi Nomura
Hi, Patrick McHardy wrote: > Alasdair G Kergon wrote: >> From: "Jun'ichi Nomura" <[EMAIL PROTECTED]> >> >> bio_alloc_bioset() will return NULL if 'num_vecs' is too large. >> Use bio_get_nr_vecs() to get estimation of maximum number. >> >

Re: [2.6.23 PATCH 07/18] dm io: fix panic on large request

2007-07-17 Thread Jun'ichi Nomura
Hi, Patrick McHardy wrote: Alasdair G Kergon wrote: From: Jun'ichi Nomura [EMAIL PROTECTED] bio_alloc_bioset() will return NULL if 'num_vecs' is too large. Use bio_get_nr_vecs() to get estimation of maximum number. Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] Signed-off-by: Alasdair G

Re: [2.6.23 PATCH 07/18] dm io: fix panic on large request

2007-07-17 Thread Jun'ichi Nomura
Patrick McHardy wrote: Jun'ichi Nomura wrote: Are you using other dm modules such as dm-multipath, dm-mirror or dm-snapshot? If so, can you take the output of 'dmsetup table' and 'dmsetup ls'? No other modules. Do you have a reliable way to reproduce the oops which I can try? /etc

[PATCH 2.6.20-rc5] dm-multipath: fix stall on noflush suspend/resume

2007-01-19 Thread Jun'ichi Nomura
to do __set_size() and waits forever. Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- 'noflush suspend' is a new device-mapper feature introduced in early 2.6.20. So I hope the fix being included before 2.6.20 is released. Example of reproducer: 1. Create a multipath device by dmsetup

[PATCH 2.6.20-rc5] dm-multipath: fix stall on noflush suspend/resume

2007-01-19 Thread Jun'ichi Nomura
__set_size() and waits forever. Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- 'noflush suspend' is a new device-mapper feature introduced in early 2.6.20. So I hope the fix being included before 2.6.20 is released. Example of reproducer: 1. Create a multipath device by dmsetup 2. Fail all paths