Re: [PATCH 4.9 00/83] 4.9.191-stable review

2019-09-05 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 07:52:52PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.191 release. > There are 83 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/57] 4.14.142-stable review

2019-09-05 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 07:53:28PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.142 release. > There are 57 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 00/93] 4.19.70-stable review

2019-09-05 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 07:53:02PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.70 release. > There are 93 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.2 000/143] 5.2.12-stable review

2019-09-05 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 07:52:23PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.2.12 release. > There are 143 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 00/77] 4.4.191-stable review

2019-09-05 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 07:52:47PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.191 release. > There are 77 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [Linux-kernel-mentees] [PATCH] PCI/IOV: Make SR-IOV attributes with mode 0664 use 0644

2019-09-05 Thread Kelsey Skunberg
On Thu, Sep 05, 2019 at 01:29:38PM -0500, Bjorn Helgaas wrote: > [+cc Bodong, Eli: just FYI since this affects sriov_drivers_autoprobe, > which you added with 0e7df22401a3] > > On Thu, Sep 05, 2019 at 12:32:26AM -0600, Kelsey Skunberg wrote: > > sriov_numvfs and sriov_driv

Re: [PATCH] PCI/IOV: Make SR-IOV attributes with mode 0664 use 0644

2019-09-05 Thread Kelsey Skunberg
On Thu, Sep 05, 2019 at 12:24:19PM -0400, Don Dutile wrote: > On 09/05/2019 02:32 AM, Kelsey Skunberg wrote: > > sriov_numvfs and sriov_drivers_autoprobe have "unusual" permissions (0664) > > with no reported or found reason for allowing group write permissions. >

Re: [PATCH] PCI/IOV: Make SR-IOV attributes with mode 0664 use 0644

2019-09-05 Thread Kelsey Skunberg
On Thu, Sep 05, 2019 at 09:34:16AM +0200, Greg KH wrote: > On Thu, Sep 05, 2019 at 12:32:26AM -0600, Kelsey Skunberg wrote: > > sriov_numvfs and sriov_drivers_autoprobe have "unusual" permissions (0664) > > with no reported or found reason for allowing group write perm

Re: [PATCH 2/2] PCI: Unify pci_dev_is_disconnected() and pci_dev_is_inaccessible()

2019-09-05 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 07:35:23AM +0200, Lukas Wunner wrote: > On Tue, Sep 03, 2019 at 10:36:35PM -0600, Kelsey Skunberg wrote: > > Change pci_dev_is_disconnected() call inside pci_dev_is_inaccessible() to: > > > > pdev->error_state == pci_channel_io_perm_failure &

[PATCH] PCI/IOV: Make SR-IOV attributes with mode 0664 use 0644

2019-09-05 Thread Kelsey Skunberg
sriov_numvfs and sriov_drivers_autoprobe from "0664" permissions to "0644" permissions. Exchange DEVICE_ATTR() with DEVICE_ATTR_RW() which sets the mode to "0644". DEVICE_ATTR() should only be used for "unusual" permissions. Signed-off-by: Kelsey Skunberg

Re: [PATCH 1/3] ACPI: Remove acpi_has_method() call from acpi_adxl.c

2019-09-04 Thread Kelsey Skunberg
:31:11AM +0200, Rafael J. Wysocki wrote: > > > On Mon, Jul 22, 2019 at 4:36 AM Kelsey Skunberg > > > wrote: > > > > > > > > acpi_check_dsm() will already return an error if the DSM method does not > > > > exist. Checking if the DSM method exists

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-09-04 Thread Kelsey Skunberg
On Wed, Sep 04, 2019 at 02:33:44PM -0400, Don Dutile wrote: > On 09/04/2019 02:22 AM, Kelsey Skunberg wrote: > > On Thu, Aug 15, 2019 at 10:37:13AM -0400, Don Dutile wrote: > > > On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: > > > > [+cc Bodong, Don

Re: [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-09-04 Thread Kelsey Skunberg
On Thu, Aug 15, 2019 at 10:37:13AM -0400, Don Dutile wrote: > On 08/14/2019 01:38 AM, Bjorn Helgaas wrote: > > [+cc Bodong, Don, Greg for permission question] > > > > On Tue, Aug 13, 2019 at 02:45:12PM -0600, Kelsey Skunberg wrote: > > > Symbolic permissio

[PATCH 2/2] PCI: Unify pci_dev_is_disconnected() and pci_dev_is_inaccessible()

2019-09-03 Thread Kelsey Skunberg
u32 v; if (pdev->error_state == pci_channel_io_perm_failure) return true; return !pci_bus_read_dev_vendor_id(pdev->bus, pdev->devfn, , 0); } Signed-off-by: Kelsey Skunberg --- drivers/pci/access.c| 12 ++

[PATCH 1/2] PCI: Change pci_device_is_present() to pci_dev_is_inaccessible()

2019-09-03 Thread Kelsey Skunberg
t;pdev)) return -ENODEV; Signed-off-by: Kelsey Skunberg --- drivers/net/ethernet/broadcom/tg3.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- drivers/nvme/host/pci.c | 2 +- drivers/pci/hotplug/acpiphp_glue.c| 2 +- drivers/pci

[PATCH 0/2] PCI: Change to using pci_dev_is_inaccessible()

2019-09-03 Thread Kelsey Skunberg
pci_dev_is_disconnected() with pci_dev_is_inaccessible() so there is only one function needed to learn if a device is inaccessible due to surprise removal or an error condition. Kelsey Skunberg (2): PCI: Change pci_device_is_present() to pci_dev_is_inaccessible() PCI: Unify

Re: [PATCH 5.2 000/144] 5.2.9-stable review

2019-08-16 Thread Kelsey Skunberg
On Wed, Aug 14, 2019 at 06:59:16PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.2.9 release. > There are 144 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 00/91] 4.19.67-stable review

2019-08-16 Thread Kelsey Skunberg
On Wed, Aug 14, 2019 at 07:00:23PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.67 release. > There are 91 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/69] 4.14.139-stable review

2019-08-16 Thread Kelsey Skunberg
On Wed, Aug 14, 2019 at 07:00:58PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.139 release. > There are 69 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [Linux-kernel-mentees] [PATCH v2 1/3] PCI: sysfs: Define device attributes with DEVICE_ATTR*()

2019-08-15 Thread Kelsey Skunberg
On Wed, Aug 14, 2019 at 09:52:20AM +0200, Greg KH wrote: > On Tue, Aug 13, 2019 at 02:45:11PM -0600, Kelsey Skunberg wrote: > > Defining device attributes should be done through the helper > > DEVICE_ATTR*(_name, _mode, _show, _store). Change all instances using > >

[PATCH v3 4/4] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-15 Thread Kelsey Skunberg
The sysfs SR-IOV functions are for an optional feature and will be better organized to keep with the feature's code. Move the sysfs SR-IOV functions to /pci/iov.c. Signed-off-by: Kelsey Skunberg --- drivers/pci/iov.c | 168 ++ drivers/pci/pci-sysfs.c

[PATCH v3 1/4] PCI: sysfs: Define device attributes with DEVICE_ATTR*

2019-08-15 Thread Kelsey Skunberg
DEVICE_ATTR_RO(_name); Signed-off-by: Kelsey Skunberg --- drivers/pci/pci-sysfs.c | 59 +++-- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 965c72104150..8af7944fdccb 100644 --- a/drivers/pci

[PATCH v3 2/4] PCI: sysfs: Change permissions from symbolic to octal

2019-08-15 Thread Kelsey Skunberg
Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not preferred and octal permissions should be used instead. Change all symbolic permissions to octal permissions. Example of old: "(S_IWUSR | S_IWGRP)" Example of new: "0220" Signed-off-by: Kelsey Skunberg

[PATCH v3 3/4] PCI: sysfs: Change DEVICE_ATTR() to DEVICE_ATTR_WO()

2019-08-15 Thread Kelsey Skunberg
the _name passed by DEVICE_ATTR_WO() and the related _name##_store() name match with each other. Example: DEVICE_ATTR_WO(bus_rescan) must be able to call bus_rescan_store() Signed-off-by: Kelsey Skunberg --- drivers/pci/pci-sysfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[PATCH v3 0/4] PCI: Clean up pci-sysfs.c

2019-08-15 Thread Kelsey Skunberg
permissions to DEVICE_ATTR_WO(). Updated series log to reflect new patch and unusual permissions information. Kelsey Skunberg (4): PCI: sysfs: Define device attributes with DEVICE_ATTR* PCI: sysfs: Change permissions from symbolic to octal PCI: sysfs

Re: [Linux-kernel-mentees] [PATCH v2 1/3] PCI: sysfs: Define device attributes with DEVICE_ATTR*()

2019-08-14 Thread Kelsey Skunberg
On Wed, Aug 14, 2019 at 09:52:20AM +0200, Greg KH wrote: > On Tue, Aug 13, 2019 at 02:45:11PM -0600, Kelsey Skunberg wrote: > > Defining device attributes should be done through the helper > > DEVICE_ATTR*(_name, _mode, _show, _store). Change all instances using > >

[PATCH v2 3/3] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-13 Thread Kelsey Skunberg
The sysfs SR-IOV functions are for an optional feature and will be better organized to keep with the feature's code. Move the sysfs SR-IOV functions to /pci/iov.c. Signed-off-by: Kelsey Skunberg --- drivers/pci/iov.c | 168 ++ drivers/pci/pci-sysfs.c

[PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal

2019-08-13 Thread Kelsey Skunberg
Symbolic permissions such as "(S_IWUSR | S_IWGRP)" are not preferred and octal permissions should be used instead. Change all symbolic permissions to octal permissions. Example of old: "(S_IWUSR | S_IWGRP)" Example of new: "0220" Signed-off-by: Kelsey Skunberg

[PATCH v2 1/3] PCI: sysfs: Define device attributes with DEVICE_ATTR*()

2019-08-13 Thread Kelsey Skunberg
, _store) Example of new: static DEVICE_ATTR(foo, S_IWUSR | S_IRUGO, show_foo, store_foo) Signed-off-by: Kelsey Skunberg --- drivers/pci/pci-sysfs.c | 59 +++-- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/drivers/pci/pci-sysfs.c b

[PATCH v2 0/3] PCI: pci-sysfs.c cleanup

2019-08-13 Thread Kelsey Skunberg
moves sysfs SR-IOV functions to iov.c will then apply cleaner. Kelsey Skunberg (3): PCI: sysfs: Define device attributes with DEVICE_ATTR*() PCI: sysfs: Change permissions from symbolic to octal PCI/IOV: Move sysfs SR-IOV functions to iov.c drivers/pci/iov.c | 168

Re: [Linux-kernel-mentees] [PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-10 Thread Kelsey Skunberg
On Sat, Aug 10, 2019 at 07:24:09PM +0200, Greg KH wrote: > On Sat, Aug 10, 2019 at 12:15:25PM -0500, Bjorn Helgaas wrote: > > On Sat, Aug 10, 2019 at 09:17:19AM +0200, Greg KH wrote: > > > On Fri, Aug 09, 2019 at 01:57:21PM -0600, Kelsey Skunberg wrote: > > > > +

[PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c

2019-08-09 Thread Kelsey Skunberg
The sysfs SR-IOV functions are for an optional feature and will be better organized to keep with the feature's code. Move the sysfs SR-IOV functions to /pci/iov.c. Signed-off-by: Kelsey Skunberg --- drivers/pci/iov.c | 173 +++ drivers/pci/pci-sysfs.c

Re: [PATCH 4.14 000/293] 4.14.135-stable review

2019-07-30 Thread Kelsey Skunberg
On Mon, Jul 29, 2019 at 09:18:11PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.135 release. > There are 293 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 000/113] 4.19.63-stable review

2019-07-30 Thread Kelsey Skunberg
On Mon, Jul 29, 2019 at 09:21:27PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.63 release. > There are 113 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.2 000/215] 5.2.5-stable review

2019-07-30 Thread Kelsey Skunberg
On Mon, Jul 29, 2019 at 09:19:56PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.2.5 release. > There are 215 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 000/271] 4.19.61-stable review

2019-07-26 Thread Kelsey Skunberg
On Wed, Jul 24, 2019 at 09:17:49PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.61 release. > There are 271 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.1 000/371] 5.1.20-stable review

2019-07-26 Thread Kelsey Skunberg
On Wed, Jul 24, 2019 at 09:15:52PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.1.20 release. > There are 371 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.2 000/413] 5.2.3-stable review

2019-07-26 Thread Kelsey Skunberg
On Wed, Jul 24, 2019 at 09:14:51PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.2.3 release. > There are 413 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

[PATCH v2 07/11] PCI: Move pcie_update_link_speed() to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pcie_update_line_speed() is only called within drivers/pci/. Since declaration does not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 1 + include/linux/pci.h | 1 - 2 files changed, 1 insertion(+), 1 deletion

[PATCH v2 09/11] PCI: Move ECRC declarations to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pcie_set_ecrc_checking() and pcie_ecrc_get_policy() are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 8 include/linux/pci.h | 8 2

[PATCH v2 03/11] PCI: Move *_host_bridge_device() declarations to drivers/pci.pci.h

2019-07-24 Thread Kelsey Skunberg
pci_get_host_bridge_device() and pci_put_host_bridge_device() are only called within drivers/pci/pci.h. Since declarations do not need to be visible to the rest of the kernel, move to drives/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 3 +++ include/linux/pci.h | 3

[PATCH v2 01/11] PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
The #define PCI_PM_* lines are only used within drivers/pci/ and they do not need to be seen by the rest of the kernel. Move #define PCI_* to drivers/pci/pci.h Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 5 + include/linux/pci.h | 5 - 2 files changed, 5 insertions(+), 5

[PATCH v2 00/11] Hide PCI symbols that don't need to be global

2019-07-24 Thread Kelsey Skunberg
- Changed line lengths on commit logs to stay below 80 characters - Changed cover-letter log to better explain patch series Kelsey Skunberg (11): PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h PCI: Move PME declarations to drivers/pci/pci.h PCI: Move

[PATCH v2 06/11] PCI: Move pci_bus_* declarations to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pci_bus_* declarations are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 2 ++ include/linux/pci.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions

[PATCH v2 10/11] PCI: Move PTM declaration to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pci_enable_ptm() is only called within drivers/pci/. Since declaration does not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 3 +++ include/linux/pci.h | 7 --- 2 files changed, 3 insertions(+), 7 deletions

[PATCH v2 08/11] PCI: Move pci_ats_init() to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pci_ats_init() is only called with drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 7 --- include/linux/pci.h | 2 -- 2 files changed, 4 insertions(+), 5 deletions

[PATCH v2 05/11] PCI: Move pci_hotplug_*_size declarations to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pci_hotplug_*_size declarations are only called within drivers/pci/pci/. Since declarations do not need to be seen by the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 3 +++ include/linux/pci.h | 4 2 files changed, 3 insertions

[PATCH v2 02/11] PCI: Move PME declarations to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pci_check_pme_status() and pci_pme_wakeup_bus() are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 2 ++ include/linux/pci.h | 2 -- 2 files changed, 2

[PATCH v2 04/11] PCI: Move PCI Virtual Channel declarations to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
PCI Virtual Channel declarations are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 5 + include/linux/pci.h | 5 - 2 files changed, 5 insertions

[PATCH v2 11/11] PCI: Move pci_*_node() declarations to drivers/pci/pci.h

2019-07-24 Thread Kelsey Skunberg
pci_*_node() is only called from drivers/pci/. Since these declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 9 + include/linux/pci.h | 8 2 files changed, 9 insertions(+), 8

[PATCH v3] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-24 Thread Kelsey Skunberg
acpi_evaluate_object will already return an error if the needed method does not exist. Remove unnecessary acpi_has_method() calls and check the returned acpi_status for failure instead. Signed-off-by: Kelsey Skunberg --- Changes in v2: - Fixed white space warnings and errors Changes

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Kelsey Skunberg
On Tue, Jul 23, 2019 at 02:07:39PM -0700, David Miller wrote: > From: David Miller > Date: Tue, 23 Jul 2019 14:06:46 -0700 (PDT) > > > From: Kelsey Skunberg > > Date: Tue, 23 Jul 2019 12:58:11 -0600 > > > >> acpi_evaluate_object will already return an

Re: [PATCH 00/11] PCI: Move symbols to drivers/pci/pci.h

2019-07-23 Thread Kelsey Skunberg
On Tue, Jul 23, 2019 at 06:07:01PM -0500, Bjorn Helgaas wrote: > On Thu, Jul 11, 2019 at 04:23:30PM -0600, Kelsey Skunberg wrote: > > Move symbols defined in include/linux/pci.h that are only used in > > drivers/pci/ to drivers/pci/pci.h. > > > > Symbols only used

Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Kelsey Skunberg
On Tue, Jul 23, 2019 at 05:56:04PM -0500, Bjorn Helgaas wrote: > On Tue, Jul 23, 2019 at 1:59 PM Kelsey Skunberg > wrote: > > > > acpi_evaluate_object will already return an error if the needed method > > does not exist. Remove unnecessary acpi_has_method() calls an

[PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-23 Thread Kelsey Skunberg
acpi_evaluate_object will already return an error if the needed method does not exist. Remove unnecessary acpi_has_method() calls and check the returned acpi_status for failure instead. Signed-off-by: Kelsey Skunberg --- Changes in v2: - Fixed white space warnings and errors drivers

[PATCH] platform: x86: Remove acpi_has_method() call in wmi.c

2019-07-21 Thread Kelsey Skunberg
__query_block(). Signed-off-by: Kelsey Skunberg --- drivers/platform/x86/wmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 784cea8572c2..59e9aa0f9643 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers

[PATCH] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-21 Thread Kelsey Skunberg
acpi_evaluate_object will already return an error if the needed method does not exist. Remove unnecessary acpi_has_method() calls and check the returned acpi_status for failure instead. Signed-off-by: Kelsey Skunberg --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 7 +++ drivers

[PATCH 1/3] ACPI: Remove acpi_has_method() call from acpi_adxl.c

2019-07-21 Thread Kelsey Skunberg
acpi_check_dsm() will already return an error if the DSM method does not exist. Checking if the DSM method exists before the acpi_check_dsm() call is not needed. Remove acpi_has_method() call to avoid additional work. Signed-off-by: Kelsey Skunberg --- drivers/acpi/acpi_adxl.c | 5 - 1 file

[PATCH 0/3] ACPI: Remove unnecessary acpi_has_method() calls

2019-07-21 Thread Kelsey Skunberg
Remove acpi_has_method() calls which return an error a following call will provide anyways. Removing the unnecessary acpi_has_method() calls help to clean up code and remove extra work. Kelsey Skunberg (3): ACPI: Remove acpi_has_method() call from acpi_adxl.c ACPI: Remove acpi_has_method

[PATCH 2/3] ACPI: Remove acpi_has_method() call from scan.c

2019-07-21 Thread Kelsey Skunberg
acpi_evaluate_reference() will return an error if the DEP method does not exist. Checking if the DEP method exists before the acpi_evaluate_reference() call is not needed. Remove acpi_has_method() call to avoid additional work. Signed-off-by: Kelsey Skunberg --- drivers/acpi/scan.c | 3 --- 1

[PATCH 3/3] ACPI: Remove acpi_has_method() calls from thermal.c

2019-07-21 Thread Kelsey Skunberg
The following acpi_has_method() calls are unnecessary since acpi_execute_simple_method() and acpi_evaluate_reference() will return an error if the given method does not exist. Remove acpi_has_method() calls to avoid additional work. Signed-off-by: Kelsey Skunberg --- drivers/acpi/thermal.c | 11

Re: [PATCH 5.2 00/21] 5.2.2-stable review

2019-07-18 Thread Kelsey Skunberg
On Thu, Jul 18, 2019 at 12:01:18PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.2.2 release. > There are 21 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

Re: [PATCH 5.1 00/54] 5.1.19-stable review

2019-07-18 Thread Kelsey Skunberg
On Thu, Jul 18, 2019 at 12:00:55PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.1.19 release. > There are 54 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 00/47] 4.19.60-stable review

2019-07-18 Thread Kelsey Skunberg
On Thu, Jul 18, 2019 at 12:01:14PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.60 release. > There are 47 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.9 00/54] 4.9.186-stable review

2019-07-18 Thread Kelsey Skunberg
On Thu, Jul 18, 2019 at 12:01:30PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.186 release. > There are 54 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.4 00/40] 4.4.186-stable review

2019-07-18 Thread Kelsey Skunberg
On Thu, Jul 18, 2019 at 12:01:56PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.186 release. > There are 40 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/80] 4.14.134-stable review

2019-07-18 Thread Kelsey Skunberg
On Thu, Jul 18, 2019 at 12:00:51PM +0900, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.134 release. > There are 80 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

[PATCH] PCI: Stop exporting pci_bus_sem

2019-07-17 Thread Kelsey Skunberg
pci_bus_sem is not used by a loadable kernel module and does not need to be exported. Remove line exporting pci_bus_sem. Signed-off-by: Kelsey Skunberg --- drivers/pci/search.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/search.c b/drivers/pci/search.c index 7f4e65872b8d

[PATCH] thermal: intel: int340x_thermal: Remove unnecessary acpi_has_method() uses

2019-07-17 Thread Kelsey Skunberg
acpi_evaluate_object() will already return in error if the method does not exist. Checking if the method is absent before the acpi_evaluate_object() call is not needed. Remove acpi_has_method() calls to avoid additional work. Signed-off-by: Kelsey Skunberg --- drivers/thermal/intel

[PATCH] PCI: Remove unused EXPORT_SYMBOL()s from drivers/pci/bus.c

2019-07-17 Thread Kelsey Skunberg
. No found history of functions being used by a loadable kernel module. Signed-off-by: Kelsey Skunberg --- drivers/pci/bus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c index 495059d923f7..8e40b3e6da77 100644 --- a/drivers/pci/bus.c +++ b/drivers/pci/bus.c

Re: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h

2019-07-15 Thread Kelsey Skunberg
On Mon, Jul 15, 2019 at 06:37:17PM -0500, Bjorn Helgaas wrote: > On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote: > > On Mon, 15 Jul 2019, Kelsey Skunberg wrote: > > > > > Remove the following uncalled functions from include/linux/pci.h: > > > &

[PATCH v3] PCI: Remove functions not called in include/linux/pci.h

2019-07-15 Thread Kelsey Skunberg
were added. Code continues to be unused and should be removed. Signed-off-by: Kelsey Skunberg --- Changes since v1: - Fixed Signed-off-by line to show full name Changes since v2: - Change commit message to reference prior commit properly with the following format: commit <12-

Re: [Linux-kernel-mentees] [PATCH v2] PCI: Remove functions not called in include/linux/pci.h

2019-07-15 Thread Kelsey Skunberg
On Mon, Jul 15, 2019 at 09:42:47PM +0200, Lukas Bulwahn wrote: > > > On Mon, 15 Jul 2019, Kelsey Skunberg wrote: > > > Remove the following uncalled functions from include/linux/pci.h: > > > > pci_block_cfg_access() > >

[PATCH v2] PCI: Remove functions not called in include/linux/pci.h

2019-07-15 Thread Kelsey Skunberg
dded. Code continues to be unused and should be removed. Signed-off-by: Kelsey Skunberg --- Changes since v1: - Fixed Signed-off-by line to show full name include/linux/pci.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index cf380544c700..3c

Re: [PATCH 5.1 000/138] 5.1.18-stable review

2019-07-13 Thread Kelsey Skunberg
On Fri, Jul 12, 2019 at 02:17:44PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.1.18 release. > There are 138 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.2 00/61] 5.2.1-stable review

2019-07-13 Thread Kelsey Skunberg
On Fri, Jul 12, 2019 at 02:19:13PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.2.1 release. > There are 61 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

Re: [PATCH 4.19 00/91] 4.19.59-stable review

2019-07-13 Thread Kelsey Skunberg
On Fri, Jul 12, 2019 at 02:18:03PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.59 release. > There are 91 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

[PATCH 11/11] PCI: Move pci_*_node() declarations to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pci_*_node() is only called from drivers/pci/. Since these declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 8 include/linux/pci.h | 8 2 files changed, 8 insertions(+), 8

[PATCH 09/11] PCI: Move ECRC declarations to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pcie_set_ecrc_checking() and pcie_ecrc_get_policy() are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 8 include/linux/pci.h | 8 2

[PATCH 10/11] PCI: Move PTM declaration to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pci_enable_ptm() is only called within drivers/pci/. Since declaration does not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 3 +++ include/linux/pci.h | 7 --- 2 files changed, 3 insertions(+), 7 deletions

[PATCH 06/11] PCI: Move pci_bus_* declarations to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pci_bus_* declarations are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 3 +++ include/linux/pci.h | 2 -- 2 files changed, 3 insertions(+), 2

[PATCH 08/11] PCI: Move pci_ats_init() to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pci_ats_init() is only called with drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 7 --- include/linux/pci.h | 2 -- 2 files changed, 4 insertions(+), 5 deletions

[PATCH 02/11] PCI: Move PME declarations to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pci_check_pme_status() and pci_pme_wakeup_bus() are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 2 ++ include/linux/pci.h | 2 -- 2 files changed, 2

[PATCH 00/11] PCI: Move symbols to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
Move symbols defined in include/linux/pci.h that are only used in drivers/pci/ to drivers/pci/pci.h. Symbols only used in drivers/pci/ do not need to be visible to the rest of the kernel. Kelsey Skunberg (11): PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h PCI: Move PME declarations

[PATCH 07/11] PCI: Move pcie_update_link_speed() to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pcie_update_line_speed() is only called within drivers/pci/. Since declaration does not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 1 + include/linux/pci.h | 1 - 2 files changed, 1 insertion(+), 1 deletion

[PATCH 05/11] PCI: Move pci_hotplug_*_size declarations to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
pci_hotplug_*_size declarations are only called within drivers/pci/pci/. Since declarations do not need to be seen by the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 3 +++ include/linux/pci.h | 4 2 files changed, 3 insertions

[PATCH 04/11] PCI: Move PCI Virtual Channel declarations to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
PCI Virtual Channel declarations are only called within drivers/pci/. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 5 + include/linux/pci.h | 5 - 2 files changed, 5 insertions

[PATCH 03/11] PCI: Move *_host_bridge_device() declarations to drivers/pci.pci.h

2019-07-11 Thread Kelsey Skunberg
pci_get_host_bridge_device() and pci_put_host_bridge_device() are only called within drivers/pci/pci.h. Since declarations do not need to be visible to the rest of the kernel, move to drivers/pci/pci.h. Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 3 +++ include/linux/pci.h | 3

[PATCH 01/11] PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h

2019-07-11 Thread Kelsey Skunberg
The #define PCI_PM_* lines are only used within drivers/pci/ and they do not need to be seen by the rest of the kernel. Move #define PCI_* to drivers/pci/pci.h Signed-off-by: Kelsey Skunberg --- drivers/pci/pci.h | 5 + include/linux/pci.h | 5 - 2 files changed, 5 insertions(+), 5

Re: [PATCH 5.1 00/55] 5.1.16-stable review

2019-07-02 Thread Kelsey Skunberg
On Tue, Jul 02, 2019 at 10:01:08AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.1.16 release. > There are 55 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.14 00/43] 4.14.132-stable review

2019-07-02 Thread Kelsey Skunberg
On Tue, Jul 02, 2019 at 10:01:40AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.132 release. > There are 43 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 4.19 00/72] 4.19.57-stable review

2019-07-02 Thread Kelsey Skunberg
On Tue, Jul 02, 2019 at 10:01:01AM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.19.57 release. > There are 72 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.1 00/46] 5.1.3-stable review

2019-05-17 Thread Kelsey Skunberg
On Wed, May 15, 2019 at 12:56:24PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.1.3 release. > There are 46 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know.

Re: [PATCH 4.9 00/51] 4.9.177-stable review

2019-05-17 Thread Kelsey Skunberg
On Wed, May 15, 2019 at 12:55:35PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.177 release. > There are 51 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH 5.0 000/137] 5.0.17-stable review

2019-05-17 Thread Kelsey Skunberg
On Wed, May 15, 2019 at 12:54:41PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.0.17 release. > There are 137 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

Re: [PATCH] selftests: pidfd: Create .gitignore to include pidfd_test

2019-05-16 Thread Kelsey Skunberg
On Tue, May 14, 2019 at 05:26:25PM -0600, Shuah Khan wrote: > Hi Kelsey, > > On 5/11/19 10:57 PM, Kelsey Skunberg wrote: > > Create /selftests/pidfd/.gitignore which holds the following file name > > created after compiling: > > This patch generates the following check

[PATCH] tools: gpio: Add include/linux/gpio.h to .gitignore

2019-05-11 Thread Kelsey Skunberg
File include/linux/gpio.h is generated after building tools/testing/selftests Add gpio.h to .gitignore to help clean up working tree status. Signed-off-by: Kelsey Skunberg --- tools/gpio/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/gpio/.gitignore b

[PATCH] selftests: drivers: Create .gitignore to include /dma-buf/udmabuf

2019-05-11 Thread Kelsey Skunberg
Create /selftests/drivers/.gitignore which holds the following file name created after compiling: - /dma-buf/udmabuf Signed-off-by: Kelsey Skunberg --- tools/testing/selftests/drivers/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/drivers

[PATCH] selftests: pidfd: Create .gitignore to include pidfd_test

2019-05-11 Thread Kelsey Skunberg
Create /selftests/pidfd/.gitignore which holds the following file name created after compiling: - pidfd_test Signed-off-by: Kelsey Skunberg --- tools/testing/selftests/pidfd/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 tools/testing/selftests/pidfd/.gitignore

[PATCH v2] selftests: kvm: Add files generated when compiled to .gitignore

2019-05-11 Thread Kelsey Skunberg
The following files are generated in /selftests/kvm/ after compiling and should be added to /selftests/kvm/.gitignore: - /x86_64/hyperv_cpuid - /x86_64/smm_test - /clear_dirty_log_test Signed-off-by: Kelsey Skunberg --- Changes since v1: - Included

  1   2   >