RE: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

Hi Zhang, > On 六, 2016-09-03 at 05:25 +0000, Khiem Nguyen wrote: > > Signed-off-by: Hien Dang <hien.dang...@renesas.com> > > Signed-off-by: Thao Nguyen <thao.nguyen...@rvc.renesas.com> > > Signed-off-by: Khiem Nguyen <khiem.nguyen...@renesas.com> &

RE: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

Hi Zhang, > On 六, 2016-09-03 at 05:25 +0000, Khiem Nguyen wrote: > > Signed-off-by: Hien Dang > > Signed-off-by: Thao Nguyen > > Signed-off-by: Khiem Nguyen > > Well, I can only see patch 4/5, 5/5 in patchwork but I can not see this > one Thanks for your

RE: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

OK. I prefer updating DT binding to describe alias. There is requirement about coefficient to calculate temperature, and the coefficient value (fixed value) is different among thermal sensors. Thanks. Best regards, KHIEM Nguyen

RE: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

OK. I prefer updating DT binding to describe alias. There is requirement about coefficient to calculate temperature, and the coefficient value (fixed value) is different among thermal sensors. Thanks. Best regards, KHIEM Nguyen

RE: [PATCH 3/5 v2] arm64: dts: r8a7795: Add R-Car Gen3 thermal support

3 more registers beyond this range. OK. Will update in v3. Thanks. Best regards, KHIEM Nguyen

RE: [PATCH 3/5 v2] arm64: dts: r8a7795: Add R-Car Gen3 thermal support

3 more registers beyond this range. OK. Will update in v3. Thanks. Best regards, KHIEM Nguyen

RE: [PATCH 0/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal support

Hi Geert, Thanks for your comment. > > This patchset adds new thermal sensor driver to support 3 sensors found in > > R-Car > Gen3 series. [snip] > You forgot to CC Simon Horman and the linux-renesas-soc mailing list. OK. Will do in v3.

RE: [PATCH 0/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal support

Hi Geert, Thanks for your comment. > > This patchset adds new thermal sensor driver to support 3 sensors found in > > R-Car > Gen3 series. [snip] > You forgot to CC Simon Horman and the linux-renesas-soc mailing list. OK. Will do in v3.

RE: [PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

Examples with soctypes are: > > + - "renesas,r8a7795-thermal" (R-Car H3) > > + - "renesas,r8a7796-thermal" (R-Car M3) > > M3-W OK. I will follow upstream style. Will update in v3. Best regards, KHIEM Nguyen

RE: [PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

Examples with soctypes are: > > + - "renesas,r8a7795-thermal" (R-Car H3) > > + - "renesas,r8a7796-thermal" (R-Car M3) > > M3-W OK. I will follow upstream style. Will update in v3. Best regards, KHIEM Nguyen

[PATCH 5/5 v2] arm64: defconfig: Enable R-Car Gen3 thermal support

Signed-off-by: Khiem Nguyen <khiem.nguyen...@renesas.com> --- v2: * No change arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 07cd615..cdb7b40 100644 --- a/arch/arm64/configs/defconfig

[PATCH 5/5 v2] arm64: defconfig: Enable R-Car Gen3 thermal support

Signed-off-by: Khiem Nguyen --- v2: * No change arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 07cd615..cdb7b40 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig

[PATCH 4/5 v2] arm64: dts: r8a7796: Add R-Car Gen3 thermal support

Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- v2: * Add newly. arch/arm64/boot/dts/renesas/r8a7796.dtsi | 83 1 file changed, 83 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r

[PATCH 4/5 v2] arm64: dts: r8a7796: Add R-Car Gen3 thermal support

Signed-off-by: Khiem Nguyen --- v2: * Add newly. arch/arm64/boot/dts/renesas/r8a7796.dtsi | 83 1 file changed, 83 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 3aae29f..c7491b0 100644

[PATCH 3/5 v2] arm64: dts: r8a7795: Add R-Car Gen3 thermal support

Signed-off-by: Hien Dang <hien.dang...@renesas.com> Signed-off-by: Thao Nguyen <thao.nguyen...@rvc.renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@renesas.com> --- v2: * Update the compatible string following new format. arch/arm64/boot/dts/renesas

[PATCH 3/5 v2] arm64: dts: r8a7795: Add R-Car Gen3 thermal support

Signed-off-by: Hien Dang Signed-off-by: Thao Nguyen Signed-off-by: Khiem Nguyen --- v2: * Update the compatible string following new format. arch/arm64/boot/dts/renesas/r8a7795.dtsi | 83 1 file changed, 83 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

Signed-off-by: Hien Dang <hien.dang...@renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@renesas.com> --- v2: * Update the format of compatible string. * Add explanation for keyword tsc. .../bindings/thermal/rcar-gen3-thermal.txt | 79 ++ 1

[PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

Signed-off-by: Hien Dang <hien.dang...@renesas.com> Signed-off-by: Thao Nguyen <thao.nguyen...@rvc.renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@renesas.com> --- v2: * Set static function for _linear_temp_converter(). * Update the compatible string following

[PATCH 1/5 v2] thermal: rcar_gen3_thermal: Document the R-Car Gen3

Signed-off-by: Hien Dang Signed-off-by: Khiem Nguyen --- v2: * Update the format of compatible string. * Add explanation for keyword tsc. .../bindings/thermal/rcar-gen3-thermal.txt | 79 ++ 1 file changed, 79 insertions(+) create mode 100644 Documentation

[PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

Signed-off-by: Hien Dang Signed-off-by: Thao Nguyen Signed-off-by: Khiem Nguyen --- v2: * Set static function for _linear_temp_converter(). * Update the compatible string following new format. * Add newline to improve readability. * Change thermal_init callbacks to void functions

[PATCH 0/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal support

features. The new driver can support both polling mode and interrupt mode. It has been tested with R-Car H3. I expect same result on R-Car M3. This driver is developed based on early work of Hien Dang and Thao Nguyen. All comments are welcome. Khiem Nguyen (5): thermal: rcar_gen3_thermal

[PATCH 0/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal support

features. The new driver can support both polling mode and interrupt mode. It has been tested with R-Car H3. I expect same result on R-Car M3. This driver is developed based on early work of Hien Dang and Thao Nguyen. All comments are welcome. Khiem Nguyen (5): thermal: rcar_gen3_thermal

RE: [PATCH 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver support

change the code flow for both drivers, as your idea. > zone = devm_thermal_zone_of_sensor_register(); > if (IS_ERR(zone)) { > ... > ret = PTR_ERR(zone); > goto error_unregister; > } > priv->zone = zone; > > > + priv->data->thermal_init(priv); > > thermal_init() has return value; OK. Will fix in v2. > > > + ret = _read_fuse_factor(priv); > > + if (ret) > > + goto error_unregister; > > + _linear_coefficient_calculation(priv); > > + ret = rcar_gen3_thermal_update_temp(priv); > > + > > + if (ret < 0) > > + goto error_unregister; > > This is very picky comment about empty line, but this is readable for me > > ret = _read_fuse_factor(priv); > if (ret) > goto error_unregister; > > _linear_coefficient_calculation(priv); > > ret = rcar_gen3_thermal_update_temp(priv); > if (ret < 0) > goto error_unregister; OK. Newline does not harm anything. Will add in v2. Thanks. Best regards, KHIEM Nguyen

RE: [PATCH 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver support

change the code flow for both drivers, as your idea. > zone = devm_thermal_zone_of_sensor_register(); > if (IS_ERR(zone)) { > ... > ret = PTR_ERR(zone); > goto error_unregister; > } > priv->zone = zone; > > > + priv->data->thermal_init(priv); > > thermal_init() has return value; OK. Will fix in v2. > > > + ret = _read_fuse_factor(priv); > > + if (ret) > > + goto error_unregister; > > + _linear_coefficient_calculation(priv); > > + ret = rcar_gen3_thermal_update_temp(priv); > > + > > + if (ret < 0) > > + goto error_unregister; > > This is very picky comment about empty line, but this is readable for me > > ret = _read_fuse_factor(priv); > if (ret) > goto error_unregister; > > _linear_coefficient_calculation(priv); > > ret = rcar_gen3_thermal_update_temp(priv); > if (ret < 0) > goto error_unregister; OK. Newline does not harm anything. Will add in v2. Thanks. Best regards, KHIEM Nguyen

[PATCH/RFC 3/3] arm64: dts: r8a7795: Support shared irq for thermal sensors

This patch adds the shared interrupts for thermal sensors TSC1/TSC2/TSC3. Signed-off-by: Gaku Inami <gaku.inami...@bp.renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 9 ++--- 1 file changed, 6 inse

[PATCH/RFC 3/3] arm64: dts: r8a7795: Support shared irq for thermal sensors

This patch adds the shared interrupts for thermal sensors TSC1/TSC2/TSC3. Signed-off-by: Gaku Inami Signed-off-by: Khiem Nguyen --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b

[PATCH/RFC 2/3] thermal: rcar_gen3_thermal: Modify the way to detect the interrupts

of thermal sensor is changed as below. - Change the shared interrupt in each thermal sensors. - Detect the interrupt when the temperature is changed one degree up and down. Signed-off-by: Gaku Inami <gaku.inami...@bp.renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.re

[PATCH/RFC 2/3] thermal: rcar_gen3_thermal: Modify the way to detect the interrupts

of thermal sensor is changed as below. - Change the shared interrupt in each thermal sensors. - Detect the interrupt when the temperature is changed one degree up and down. Signed-off-by: Gaku Inami Signed-off-by: Khiem Nguyen --- drivers/thermal/rcar_gen3_thermal.c | 69

[PATCH/RFC 1/3] thermal: rcar_gen3_thermal: Modify the shared irq with initialization

Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- drivers/thermal/rcar_gen3_thermal.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index a9a372b..e6

[PATCH/RFC 1/3] thermal: rcar_gen3_thermal: Modify the shared irq with initialization

In R-CAR Gen3 series, it has some thermal sensors. The interrupt I/F that can be used in thermal sensors is three. So it should be used the interrupt I/F as shared. This patch changes the shared settings for the thermal interrupts. Signed-off-by: Gaku Inami Signed-off-by: Khiem Nguyen

[PATCH/RFC 0/3] thermal: rcar_gen3_thermal: Apply shared interrupts for thermal sensors

This patchset intents to improve thermal driver operation in interrupt mode, which has been introduced in [1]. The original idea is using 1 interrupt for each thermal sensor, to detect both up and down temperature. It caused issue when the temperature is changing rapidly. The new idea is about

[PATCH/RFC 0/3] thermal: rcar_gen3_thermal: Apply shared interrupts for thermal sensors

This patchset intents to improve thermal driver operation in interrupt mode, which has been introduced in [1]. The original idea is using 1 interrupt for each thermal sensor, to detect both up and down temperature. It caused issue when the temperature is changing rapidly. The new idea is about

[PATCH 4/4] arm64: defconfig: Enable R-Car Gen3 thermal support

Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 4f3e1f6..b5551d9 100644 --- a/arch/arm64/configs/defconfig +++ b/arch

[PATCH 4/4] arm64: defconfig: Enable R-Car Gen3 thermal support

Signed-off-by: Khiem Nguyen --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 4f3e1f6..b5551d9 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -200,8 +200,10

[PATCH 3/4] arm64: dts: r8a7795: Add R-Car Gen3 thermal support

Signed-off-by: Hien Dang <hien.dang...@rvc.renesas.com> Signed-off-by: Thao Nguyen <thao.nguyen...@rvc.renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 86 1 file chan

[PATCH 3/4] arm64: dts: r8a7795: Add R-Car Gen3 thermal support

Signed-off-by: Hien Dang Signed-off-by: Thao Nguyen Signed-off-by: Khiem Nguyen --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 86 1 file changed, 86 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795

[PATCH 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver support

Signed-off-by: Hien Dang <hien.dang...@rvc.renesas.com> Signed-off-by: Thao Nguyen <thao.nguyen...@rvc.renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- drivers/thermal/Kconfig | 9 + drivers/thermal/Makefile| 1

[PATCH 2/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver support

Signed-off-by: Hien Dang Signed-off-by: Thao Nguyen Signed-off-by: Khiem Nguyen --- drivers/thermal/Kconfig | 9 + drivers/thermal/Makefile| 1 + drivers/thermal/rcar_gen3_thermal.c | 524 3 files changed, 534 insertions

[PATCH 1/4] thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings

Signed-off-by: Hien Dang <hien.dang...@rvc.renesas.com> Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- .../bindings/thermal/rcar-gen3-thermal.txt | 79 ++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicet

[PATCH 1/4] thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings

Signed-off-by: Hien Dang Signed-off-by: Khiem Nguyen --- .../bindings/thermal/rcar-gen3-thermal.txt | 79 ++ 1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.txt diff --git a/Documentation/devicetree

[PATCH 0/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal support

features. The new driver can support both polling mode and interrupt mode. It has been tested with R-Car H3. This driver is developed based on early work of Hien Dang and Thao Nguyen. All comments are welcome. Khiem Nguyen (4): thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings

[PATCH 0/4] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal support

features. The new driver can support both polling mode and interrupt mode. It has been tested with R-Car H3. This driver is developed based on early work of Hien Dang and Thao Nguyen. All comments are welcome. Khiem Nguyen (4): thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings

[PATCH 2/2] cpufreq: rcar: Add support for R8A7796 SoC

Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- drivers/cpufreq/cpufreq-dt-platdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index 32f6dda..7d038fd 100644 --- a/drivers/cpufreq/cpuf

[PATCH 2/2] cpufreq: rcar: Add support for R8A7796 SoC

Signed-off-by: Khiem Nguyen --- drivers/cpufreq/cpufreq-dt-platdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index 32f6dda..7d038fd 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq

[PATCH 1/2] cpufreq: rcar: Add support for R8A7795 SoC

After the commit "a399dc9fc50 cpufreq: shmobile: Use generic platdev driver", will use cpufreq-dt-platdev driver to enable cpufreq-dt support. Hence, follow the implementation to support new R8A7795 SoC. Signed-off-by: Khiem Nguyen <khiem.nguyen...@rvc.renesas.com> --- drivers

[PATCH 1/2] cpufreq: rcar: Add support for R8A7795 SoC

After the commit "a399dc9fc50 cpufreq: shmobile: Use generic platdev driver", will use cpufreq-dt-platdev driver to enable cpufreq-dt support. Hence, follow the implementation to support new R8A7795 SoC. Signed-off-by: Khiem Nguyen --- drivers/cpufreq/cpufreq-dt-platdev.c | 1 + 1 fi

[PATCH 0/2] cpufreq: rcar: Enable CPUFreq support

This series enables CPUFreq support in available R-Car Gen3 SoC. It depends on 2 series below: [PATCH 0/4] clk: renesas: cpg-mssr: Add support for R-Car M3-W [RFC 0/4] Add Z clock support All comments are appreciated. Khiem Nguyen (2): cpufreq: rcar: Add support for R8A7795 SoC

[PATCH 0/2] cpufreq: rcar: Enable CPUFreq support

This series enables CPUFreq support in available R-Car Gen3 SoC. It depends on 2 series below: [PATCH 0/4] clk: renesas: cpg-mssr: Add support for R-Car M3-W [RFC 0/4] Add Z clock support All comments are appreciated. Khiem Nguyen (2): cpufreq: rcar: Add support for R8A7795 SoC

Re: [PATCH 5/8 v4] thermal: rcar: enable to use thermal-zone on DT

Hi Morimoto-san, Sorry for late information in v3. There's a small mistake in example in DT binding documentation. Anyway, let's wait for more comments from other developers before fixing it. On 12/8/2015 12:28 PM, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch enables to use

Re: [PATCH 7/8 v3] ARM: shmobile: r8a7791: enable to use thermal-zone

Hi Morimoto-san, Thanks for your patch. I have same comments as patch 0006. On 12/7/2015 2:44 PM, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch enables to use thermal-zone on r8a7791. This thermal sensor can measure temperature from -4 to 125000, but over 117000 can be

Re: [PATCH 6/8 v3] ARM: shmobile: r8a7790: enable to use thermal-zone

Hi Morimoto-san, Thanks for your patch. On 12/7/2015 2:44 PM, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch enables to use thermal-zone on r8a7790. This thermal sensor can measure temperature from -4 to 125000, but over 117000 can be critical on this chip. Thus, default

Re: [PATCH 5/8 v4] thermal: rcar: enable to use thermal-zone on DT

Hi Morimoto-san, Sorry for late information in v3. There's a small mistake in example in DT binding documentation. Anyway, let's wait for more comments from other developers before fixing it. On 12/8/2015 12:28 PM, Kuninori Morimoto wrote: From: Kuninori Morimoto

Re: [PATCH 6/8 v3] ARM: shmobile: r8a7790: enable to use thermal-zone

Hi Morimoto-san, Thanks for your patch. On 12/7/2015 2:44 PM, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch enables to use thermal-zone on r8a7790. This thermal sensor can measure temperature from -4 to 125000, but over 117000 can be

Re: [PATCH 7/8 v3] ARM: shmobile: r8a7791: enable to use thermal-zone

Hi Morimoto-san, Thanks for your patch. I have same comments as patch 0006. On 12/7/2015 2:44 PM, Kuninori Morimoto wrote: From: Kuninori Morimoto This patch enables to use thermal-zone on r8a7791. This thermal sensor can measure temperature from -4 to

Re: [PATCH v4 2/3] phy: rcar-gen3-usb2: change the mode to OTG on the combined channel

Hi Kishon, On 10/17/2015 8:48 AM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote: To use the channel 0 of R-Car gen3 as periperal mode, This patch changes the mode to OTG instead of HOST. Then, this driver needs to set some registers to enable

Re: [PATCH v4 2/3] phy: rcar-gen3-usb2: change the mode to OTG on the combined channel

Hi Kishon, On 10/17/2015 8:48 AM, Kishon Vijay Abraham I wrote: Hi, On Tuesday 13 October 2015 03:52 PM, Yoshihiro Shimoda wrote: To use the channel 0 of R-Car gen3 as periperal mode, This patch changes the mode to OTG instead of HOST. Then, this driver needs to set some registers to enable

Re: [PATCH/RFC 2/5] PM / Domains: Add DT bindings for the R-Mobile System Controller

er-domain-cells = <0>; > + power-on-latency = <25>; > + power-off-latency = <25>; > + }; > + }; > + }; > + }; > + > + &g

Re: [PATCH/RFC 2/5] PM / Domains: Add DT bindings for the R-Mobile System Controller

; + power-domains = pd_a3sp; + #pwm-cells = 3; + }; -- Best regards, KHIEM Nguyen -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo