Re: [PATCH v5 00/10] Function Granular KASLR

2020-09-28 Thread Kristen Carlson Accardi
Hi, On Fri, 2020-09-25 at 15:06 +0200, Miroslav Benes wrote: > Hi Kristen, > > On Wed, 23 Sep 2020, Kristen Carlson Accardi wrote: > > > Function Granular Kernel Address Space Layout Randomiz

[PATCH v5 10/10] livepatch: only match unique symbols when using fgkaslr

2020-09-23 Thread Kristen Carlson Accardi
or modules, forcing the algorithm to require that only unique symbols are allowed to be patched. Signed-off-by: Kristen Carlson Accardi --- kernel/livepatch/core.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index f76fdb925532

[PATCH v5 03/10] x86: Makefile: Add build and config option for CONFIG_FG_KASLR

2020-09-23 Thread Kristen Carlson Accardi
together for the future by ensuring that if CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected when used with CONFIG_FG_KASLR the function sections will not be consolidated back into .text. Thanks to Kees Cook for the dead code elimination changes. Signed-off-by: Kristen Carlson Accardi Reviewed

[PATCH v5 06/10] x86/boot/compressed: Avoid duplicate malloc() implementations

2020-09-23 Thread Kristen Carlson Accardi
bss dec hex filename 8842314 468 178320 9021102 89a6ae vmlinux.before 8842240 468 178320 9021028 89a664 vmlinux.after Signed-off-by: Kees Cook Signed-off-by: Kristen Carlson Accardi --- arch/x86/boot/compressed/kaslr.c | 4 arch/x86/boot/compressed/misc.c | 3 +++ a

[PATCH v5 04/10] x86: Make sure _etext includes function sections

2020-09-23 Thread Kristen Carlson Accardi
f the text section and the orphaned sections, _etext must be moved so that it is after both .text and .text.* The text size must also be calculated to include .text AND .text.* Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck Reviewed-by: Kees Cook --- arch/

[PATCH v5 02/10] x86/boot: Allow a "silent" kaslr random byte fetch

2020-09-23 Thread Kristen Carlson Accardi
Kees Cook Signed-off-by: Kristen Carlson Accardi --- arch/x86/lib/kaslr.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c index a53665116458..2b3eb8c948a3 100644 --- a/arch/x86/lib/kaslr.c +++ b/arch/x86/lib/kaslr.c

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-21 Thread Kristen Carlson Accardi
On Wed, 2020-07-22 at 16:33 -0500, Josh Poimboeuf wrote: > On Wed, Jul 22, 2020 at 12:56:10PM -0700, Kristen Carlson Accardi > wrote: > > On Wed, 2020-07-22 at 12:42 -0700, Kees Cook wrote: > > > On Wed, Jul 22, 2020 at 11:07:30AM -0500, Josh Poimboeuf wrote: > > > &

[PATCH] objtool: support symtab_shndx during dump

2020-08-12 Thread Kristen Carlson Accardi
When getting the symbol index number, make sure to use the extended symbol table information in order to support symbol index's greater than 64K. Signed-off-by: Kristen Carlson Accardi --- tools/objtool/orc_dump.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-12 Thread Kristen Carlson Accardi
On Tue, 2020-08-04 at 14:23 -0400, Joe Lawrence wrote: > On Fri, Jul 17, 2020 at 09:59:57AM -0700, Kristen Carlson Accardi > wrote: > > Function Granular Kernel Address Space Layout Randomization

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-10 Thread Kristen Carlson Accardi
On Fri, 2020-08-07 at 10:20 -0700, Kees Cook wrote: > On Fri, Aug 07, 2020 at 09:38:11AM -0700, Kristen Carlson Accardi > wrote: > > Thanks for testing. Yes, Josh and I have been discussing the > > orc_unwind > > issues. I've root caused one issue already

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-07 Thread Kristen Carlson Accardi
On Tue, 2020-08-04 at 14:23 -0400, Joe Lawrence wrote: > On Fri, Jul 17, 2020 at 09:59:57AM -0700, Kristen Carlson Accardi > wrote: > > Function Granular Kernel Address Space Layout Randomization

Re: [PATCH v4 00/10] Function Granular KASLR

2020-08-06 Thread Kristen Carlson Accardi
Hi Mingo, thanks for taking a look, I am glad you like the idea. Some replies below: On Thu, 2020-08-06 at 17:32 +0200, Ingo Molnar wrote: > * Kristen Carlson Accardi wrote: > > > Function Granular Kernel Address Space Layout Randomization

Re: [PATCH v4 00/10] Function Granular KASLR

2020-07-22 Thread Kristen Carlson Accardi
On Wed, 2020-07-22 at 12:42 -0700, Kees Cook wrote: > On Wed, Jul 22, 2020 at 11:07:30AM -0500, Josh Poimboeuf wrote: > > On Wed, Jul 22, 2020 at 07:39:55AM -0700, Kees Cook wrote: > > > On Wed, Jul 22, 2020 at 11:27:30AM +0200, Miroslav Benes wrote: > > > > Let me CC live-patching ML, because

Re: [PATCH v4 00/10] Function Granular KASLR

2020-07-22 Thread Kristen Carlson Accardi
On Wed, 2020-07-22 at 10:56 -0400, Joe Lawrence wrote: > On 7/22/20 10:51 AM, Joe Lawrence wrote: > > On 7/22/20 10:39 AM, Kees Cook wrote: > > > On Wed, Jul 22, 2020 at 11:27:30AM +0200, Miroslav Benes wrote: > > > > Let me CC live-patching ML, because from a quick glance this is > > > >

Re: [PATCH v4 09/10] kallsyms: Hide layout

2020-07-20 Thread Kristen Carlson Accardi
On Sun, 2020-07-19 at 18:25 -0700, Kees Cook wrote: > On Fri, Jul 17, 2020 at 10:00:06AM -0700, Kristen Carlson Accardi > wrote: > > This patch makes /proc/kallsyms display in a random order, rather > > than sorted by address in order to hide the newly randomized > > add

[PATCH v4 05/10] x86: Make sure _etext includes function sections

2020-07-17 Thread Kristen Carlson Accardi
f the text section and the orphaned sections, _etext must be moved so that it is after both .text and .text.* The text size must also be calculated to include .text AND .text.* Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck Reviewed-by: Kees Cook --- arch/

[PATCH v4 04/10] x86: Makefile: Add build and config option for CONFIG_FG_KASLR

2020-07-17 Thread Kristen Carlson Accardi
together for the future by ensuring that if CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected when used with CONFIG_FG_KASLR the function sections will not be consolidated back into .text. Thanks to Kees Cook for the dead code elimination changes. Signed-off-by: Kristen Carlson Accardi Reviewed

[PATCH v4 07/10] x86/boot/compressed: Avoid duplicate malloc() implementations

2020-07-17 Thread Kristen Carlson Accardi
bss dec hex filename 8842314 468 178320 9021102 89a6ae vmlinux.before 8842240 468 178320 9021028 89a664 vmlinux.after Signed-off-by: Kees Cook Signed-off-by: Kristen Carlson Accardi --- arch/x86/boot/compressed/kaslr.c | 4 arch/x86/boot/compressed/misc.c | 3 +++ a

[PATCH v4 03/10] x86/boot: Allow a "silent" kaslr random byte fetch

2020-07-17 Thread Kristen Carlson Accardi
Kees Cook Signed-off-by: Kristen Carlson Accardi --- arch/x86/lib/kaslr.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c index a53665116458..2b3eb8c948a3 100644 --- a/arch/x86/lib/kaslr.c +++ b/arch/x86/lib/kaslr.c

[PATCH v4 06/10] x86/tools: Add relative relocs for randomized functions

2020-07-17 Thread Kristen Carlson Accardi
Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck Reviewed-by: Kees Cook --- arch/x86/boot/compressed/Makefile | 7 +- arch/x86/tools/relocs.c | 41 --- arch/x86/tools/relocs.h | 4 +-- arch/x86/tools/relocs_common.c| 15

[PATCH v4 08/10] x86: Add support for function granular KASLR

2020-07-17 Thread Kristen Carlson Accardi
but since it is expected to be sorted by address, it will need to be resorted. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck Reviewed-by: Kees Cook --- .../admin-guide/kernel-parameters.txt | 7 + Documentation/security/fgkaslr.rst| 172 Doc

[PATCH v4 02/10] x86: tools/relocs: Support >64K section headers

2020-07-17 Thread Kristen Carlson Accardi
elf file to read the extended symbol table info, and then replace all direct references to st_shndx with calls to sym_index(), which will determine whether the value can be read directly or whether the value should be pulled out of the extended table. Signed-off-by: Kristen Carlson Accardi Revie

[PATCH v4 10/10] module: Reorder functions

2020-07-17 Thread Kristen Carlson Accardi
if CONFIG_FG_KASLR is selected. If a module has functions split out into separate text sections (i.e. compiled with the -ffunction-sections flag), reorder the functions to provide some code diversification to modules. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Kees Cook Acked-by: Ard Biesheuvel

[PATCH v4 09/10] kallsyms: Hide layout

2020-07-17 Thread Kristen Carlson Accardi
This patch makes /proc/kallsyms display in a random order, rather than sorted by address in order to hide the newly randomized address layout. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- kernel/kallsyms.c | 163

[PATCH v4 01/10] objtool: Do not assume order of parent/child functions

2020-07-17 Thread Kristen Carlson Accardi
If a .cold function is examined prior to it's parent, the link to the parent/child function can be overwritten when the parent is examined. Only update pfunc and cfunc if they were previously nil to prevent this from happening. Signed-off-by: Kristen Carlson Accardi Acked-by: Josh Poimboeuf

[PATCH v4 00/10] Function Granular KASLR

2020-07-17 Thread Kristen Carlson Accardi
e information on how function layout impacts performance, see: Optimizing Function Placement for Large-Scale Data-Center Applications, G. Ottoni, B. Maher Kees Cook (2): x86/boot: Allow a "silent" kaslr random byte fetch x86/boot/compressed: Avoid duplicate malloc() implementatio

Re: [PATCH v3 09/10] kallsyms: Hide layout

2020-07-08 Thread Kristen Carlson Accardi
On Tue, 2020-07-07 at 23:16 +, Luck, Tony wrote: > > Signed-off-by: Kristen Carlson Accardi > > Reviewed-by: Tony Luck > > Tested-by: Tony Luck > > I'll happily review and test again ... but since you've made > substantive > changes, you should drop these tags

Re: [PATCH v3 09/10] kallsyms: Hide layout

2020-07-07 Thread Kristen Carlson Accardi
On Wed, 2020-06-24 at 08:18 -0700, Kees Cook wrote: > On Wed, Jun 24, 2020 at 12:21:16PM +0200, Jann Horn wrote: > > On Tue, Jun 23, 2020 at 7:26 PM Kristen Carlson Accardi > > wrote: > > > This patch makes /proc/kallsyms display alphabetically by symbol > > > n

Re: [PATCH v3 09/10] kallsyms: Hide layout

2020-06-25 Thread Kristen Carlson Accardi
On Wed, 2020-06-24 at 08:18 -0700, Kees Cook wrote: > On Wed, Jun 24, 2020 at 12:21:16PM +0200, Jann Horn wrote: > > On Tue, Jun 23, 2020 at 7:26 PM Kristen Carlson Accardi > > wrote: > > > This patch makes /proc/kallsyms display alphabetically by symbol > > > n

[PATCH v3 00/10] Function Granular KASLR

2020-06-23 Thread Kristen Carlson Accardi
tion on how function layout impacts performance, see: Optimizing Function Placement for Large-Scale Data-Center Applications, G. Ottoni, B. Maher Kees Cook (1): x86/boot: Allow a "silent" kaslr random byte fetch Kristen Carlson Accardi (9): objtool: Do not assume order of parent/child

[PATCH v3 08/10] x86: Add support for function granular KASLR

2020-06-23 Thread Kristen Carlson Accardi
but since it is expected to be sorted by address, it will need to be resorted. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- Documentation/security/fgkaslr.rst | 173 + Documentation/security/index.rst | 1 + arch/x86/boot/compressed/Makefile

[PATCH v3 10/10] module: Reorder functions

2020-06-23 Thread Kristen Carlson Accardi
if CONFIG_FG_KASLR is selected. If a module has functions split out into separate text sections (i.e. compiled with the -ffunction-sections flag), reorder the functions to provide some code diversification to modules. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Kees Cook Acked-by: Ard Biesheuvel

[PATCH v3 02/10] x86: tools/relocs: Support >64K section headers

2020-06-23 Thread Kristen Carlson Accardi
elf file to read the extended symbol table info, and then replace all direct references to st_shndx with calls to sym_index(), which will determine whether the value can be read directly or whether the value should be pulled out of the extended table. Signed-off-by: Kristen Carlson Accardi Revie

[PATCH v3 03/10] x86/boot: Allow a "silent" kaslr random byte fetch

2020-06-23 Thread Kristen Carlson Accardi
Kees Cook Signed-off-by: Kristen Carlson Accardi --- arch/x86/lib/kaslr.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c index a53665116458..2b3eb8c948a3 100644 --- a/arch/x86/lib/kaslr.c +++ b/arch/x86/lib/kaslr.c

[PATCH v3 07/10] x86/boot/compressed: change definition of STATIC

2020-06-23 Thread Kristen Carlson Accardi
In preparation for changes to the upcoming fgkaslr commit, change misc.c to not define STATIC as static, but instead set STATIC to "". This allows memptr to become accessible to multiple files. Signed-off-by: Kristen Carlson Accardi --- arch/x86/boot/compressed/kaslr.c | 4 arc

[PATCH v3 06/10] x86/tools: Add relative relocs for randomized functions

2020-06-23 Thread Kristen Carlson Accardi
Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck Reviewed-by: Kees Cook --- arch/x86/boot/compressed/Makefile | 7 +- arch/x86/tools/relocs.c | 41 --- arch/x86/tools/relocs.h | 4 +-- arch/x86/tools/relocs_common.c| 15

[PATCH v3 05/10] x86: Make sure _etext includes function sections

2020-06-23 Thread Kristen Carlson Accardi
f the text section and the orphaned sections, _etext must be moved so that it is after both .text and .text.* The text size must also be calculated to include .text AND .text.* Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- arch/x86/kernel/vmlinux.lds.

[PATCH v3 04/10] x86: Makefile: Add build and config option for CONFIG_FG_KASLR

2020-06-23 Thread Kristen Carlson Accardi
together for the future by ensuring that if CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected when used with CONFIG_FG_KASLR the function sections will not be consolidated back into .text. Thanks to Kees Cook for the dead code elimination changes. Signed-off-by: Kristen Carlson Accardi Reviewed

[PATCH v3 09/10] kallsyms: Hide layout

2020-06-23 Thread Kristen Carlson Accardi
This patch makes /proc/kallsyms display alphabetically by symbol name rather than sorted by address in order to hide the newly randomized address layout. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- kernel/kallsyms.c | 128

[PATCH v3 01/10] objtool: Do not assume order of parent/child functions

2020-06-23 Thread Kristen Carlson Accardi
If a .cold function is examined prior to it's parent, the link to the parent/child function can be overwritten when the parent is examined. Only update pfunc and cfunc if they were previously nil to prevent this from happening. Signed-off-by: Kristen Carlson Accardi Acked-by: Josh Poimboeuf

[tip: objtool/core] objtool: Do not assume order of parent/child functions

2020-06-17 Thread tip-bot2 for Kristen Carlson Accardi
The following commit has been merged into the objtool/core branch of tip: Commit-ID: e000acc145928693833f09152244242a678d3cd5 Gitweb: https://git.kernel.org/tip/e000acc145928693833f09152244242a678d3cd5 Author:Kristen Carlson Accardi AuthorDate:Wed, 15 Apr 2020 14:04:43

Re: [PATCH v2 9/9] module: Reorder functions

2020-06-09 Thread Kristen Carlson Accardi
On Tue, 2020-06-09 at 13:42 -0700, Kees Cook wrote: > On Tue, Jun 09, 2020 at 01:14:04PM -0700, Kristen Carlson Accardi > wrote: > > On Thu, 2020-05-21 at 14:33 -0700, Kees Cook wrote: > > > Oh! And I am reminded suddenly about CONFIG_FG_KASLR needing to > >

Re: [PATCH v2 9/9] module: Reorder functions

2020-06-09 Thread Kristen Carlson Accardi
On Thu, 2020-05-21 at 14:33 -0700, Kees Cook wrote: > Oh! And I am reminded suddenly about CONFIG_FG_KASLR needing to > interact > correctly with CONFIG_LD_DEAD_CODE_DATA_ELIMINATION in that we do NOT > want the sections to be collapsed at link time: sorry - I'm a little confused and was

Re: [PATCH v2 7/9] x86: Add support for function granular KASLR

2020-06-04 Thread Kristen Carlson Accardi
On Thu, 2020-05-21 at 14:08 -0700, Kees Cook wrote: > On Thu, May 21, 2020 at 09:56:38AM -0700, Kristen Carlson Accardi > wrote: > > At boot time, find all the function sections that have separate > > .text > > sections, shuffle them, and then copy them to new locations. Ad

Re: [PATCH v2 0/9] Function Granular KASLR

2020-05-21 Thread Kristen Carlson Accardi
On Thu, 2020-05-21 at 16:30 -0700, Kees Cook wrote: > On Fri, May 22, 2020 at 12:26:30AM +0200, Thomas Gleixner wrote: > > I understand how this is supposed to work, but I fail to find an > > explanation how all of this is preserving the text subsections we > > have, > > i.e. .kprobes.text,

Re: [PATCH v2 7/9] x86: Add support for function granular KASLR

2020-05-21 Thread Kristen Carlson Accardi
Hi Kees, Thanks for your review - I will incorporate what I can into v3, or explain why not once I give it a try :). On Thu, 2020-05-21 at 14:08 -0700, Kees Cook wrote: > > > On Thu, May 21, 2020 at 09:56:38AM -0700, Kristen Carlson Accardi > wrote: > > + /* >

[PATCH v2 7/9] x86: Add support for function granular KASLR

2020-05-21 Thread Kristen Carlson Accardi
At boot time, find all the function sections that have separate .text sections, shuffle them, and then copy them to new locations. Adjust any relocations accordingly. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- Documentation/security/fgkaslr.rst

[PATCH v2 6/9] x86/tools: Add relative relocs for randomized functions

2020-05-21 Thread Kristen Carlson Accardi
Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- arch/x86/boot/compressed/Makefile | 7 +++- arch/x86/tools/relocs.c | 55 --- arch/x86/tools/relocs.h | 4 +-- arch/x86/tools/relocs_common.c| 15 ++--- 4 files changed, 62

[PATCH v2 4/9] x86: Makefile: Add build and config option for CONFIG_FG_KASLR

2020-05-21 Thread Kristen Carlson Accardi
Allow user to select CONFIG_FG_KASLR if dependencies are met. Change the make file to build with -ffunction-sections if CONFIG_FG_KASLR Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- Makefile | 4 arch/x86/Kconfig | 13 + 2

[PATCH v2 5/9] x86: Make sure _etext includes function sections

2020-05-21 Thread Kristen Carlson Accardi
f the text section and the orphaned sections, _etext must be moved so that it is after both .text and .text.* The text size must also be calculated to include .text AND .text.* Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- arch/x86/kernel/vmlinux.lds.

[PATCH v2 9/9] module: Reorder functions

2020-05-21 Thread Kristen Carlson Accardi
if CONFIG_FG_KASLR is selected. If a module has functions split out into separate text sections (i.e. compiled with the -ffunction-sections flag), reorder the functions to provide some code diversification to modules. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Kees Cook Acked-by: Ard Biesheuvel

[PATCH v2 8/9] kallsyms: Hide layout

2020-05-21 Thread Kristen Carlson Accardi
This patch makes /proc/kallsyms display alphabetically by symbol name rather than sorted by address in order to hide the newly randomized address layout. Signed-off-by: Kristen Carlson Accardi Reviewed-by: Tony Luck Tested-by: Tony Luck --- kernel/kallsyms.c | 138

[PATCH v2 0/9] Function Granular KASLR

2020-05-21 Thread Kristen Carlson Accardi
For more information on how function layout impacts performance, see: Optimizing Function Placement for Large-Scale Data-Center Applications, G. Ottoni, B. Maher Kees Cook (1): x86/boot: Allow a "silent" kaslr random byte fetch Kristen Carlson Accardi (8): objtool: Do not assume o

[PATCH v2 1/9] objtool: Do not assume order of parent/child functions

2020-05-21 Thread Kristen Carlson Accardi
If a .cold function is examined prior to it's parent, the link to the parent/child function can be overwritten when the parent is examined. Only update pfunc and cfunc if they were previously nil to prevent this from happening. Signed-off-by: Kristen Carlson Accardi Acked-by: Josh Poimboeuf

[PATCH v2 3/9] x86/boot: Allow a "silent" kaslr random byte fetch

2020-05-21 Thread Kristen Carlson Accardi
Kees Cook Signed-off-by: Kristen Carlson Accardi --- arch/x86/lib/kaslr.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c index a53665116458..2b3eb8c948a3 100644 --- a/arch/x86/lib/kaslr.c +++ b/arch/x86/lib/kaslr.c

[PATCH v2 2/9] x86: tools/relocs: Support >64K section headers

2020-05-21 Thread Kristen Carlson Accardi
elf file to read the extended symbol table info, and then replace all direct references to st_shndx with calls to sym_index(), which will determine whether the value can be read directly or whether the value should be pulled out of the extended table. Signed-off-by: Kristen Carlson Accardi Revie

[PATCH] x86: entry: flush the cache if syscall error

2018-10-11 Thread Kristen Carlson Accardi
no significant performance impact. Suggested-by: Alan Cox Signed-off-by: Kristen Carlson Accardi --- arch/x86/Kconfig| 9 + arch/x86/entry/common.c | 18 ++ 2 files changed, 27 insertions(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 1a0be022f91d..bde978eb3b4e

[PATCH] x86: entry: flush the cache if syscall error

2018-10-11 Thread Kristen Carlson Accardi
no significant performance impact. Suggested-by: Alan Cox Signed-off-by: Kristen Carlson Accardi --- arch/x86/Kconfig| 9 + arch/x86/entry/common.c | 18 ++ 2 files changed, 27 insertions(+) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 1a0be022f91d..bde978eb3b4e

Re: [PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Kristen Carlson Accardi
https://bugzilla.redhat.com/show_bug.cgi?id=1271225 > against Fedora to remove the 94cpufreq file that causes the problem. It > should be noted that pm-utils is obsoleted with newer versions of systemd. > > Cc: Kristen Carlson Accardi > Cc: "Rafael J. Wysocki" > Cc: Viresh

Re: [PATCH] cpufreq, intel_pstate, Fix intel_pstate powersave min_perf_pct value

2015-10-14 Thread Kristen Carlson Accardi
> I have submitted https://bugzilla.redhat.com/show_bug.cgi?id=1271225 > against Fedora to remove the 94cpufreq file that causes the problem. It > should be noted that pm-utils is obsoleted with newer versions of systemd. > > Cc: Kristen Carlson Accardi <kris...@linux.intel.com>

[tip:x86/urgent] x86/cpufeatures: Correct spelling of the HWP_NOTIFY flag

2015-09-23 Thread tip-bot for Kristen Carlson Accardi
Commit-ID: a7adb91b13c104e5ad950fbe1795aa2722f2ea0a Gitweb: http://git.kernel.org/tip/a7adb91b13c104e5ad950fbe1795aa2722f2ea0a Author: Kristen Carlson Accardi AuthorDate: Tue, 22 Sep 2015 10:51:36 -0700 Committer: Ingo Molnar CommitDate: Wed, 23 Sep 2015 09:57:24 +0200 x86/cpufeatures

[tip:x86/urgent] x86/cpufeatures: Correct spelling of the HWP_NOTIFY flag

2015-09-23 Thread tip-bot for Kristen Carlson Accardi
Commit-ID: a7adb91b13c104e5ad950fbe1795aa2722f2ea0a Gitweb: http://git.kernel.org/tip/a7adb91b13c104e5ad950fbe1795aa2722f2ea0a Author: Kristen Carlson Accardi <kris...@linux.intel.com> AuthorDate: Tue, 22 Sep 2015 10:51:36 -0700 Committer: Ingo Molnar <mi...@kernel.org> Com

Re: [PATCH] [v2] intel_pstate: Fix user input of min/max to legal policy region

2015-09-09 Thread Kristen Carlson Accardi
0 > > Fix this problem by 2 steps: > 1.Normalize the user input to [min_policy, max_policy]. > 2.Make sure max_perf_pct>=min_perf_pct, suggested by Seiichi Ikarashi. > > Signed-off-by: Chen Yu Acked-by: Kristen Carlson Accardi > --- > v2: > - Add logic to ensur

Re: [PATCH] [v2] intel_pstate: Fix user input of min/max to legal policy region

2015-09-09 Thread Kristen Carlson Accardi
em/cpu/intel_pstate/min_perf_pct:100 > > Fix this problem by 2 steps: > 1.Normalize the user input to [min_policy, max_policy]. > 2.Make sure max_perf_pct>=min_perf_pct, suggested by Seiichi Ikarashi. > > Signed-off-by: Chen Yu <yu.c.c...@intel.com> Acked-by: Kristen Carlso

Re: [PATCH] intel_pstate: append more Oracle OEM table id to vendor bypass list

2015-08-05 Thread Kristen Carlson Accardi
"ORACLE", "X4275 M3", PPC}, > + {1, "ORACLE", "X6-2", PPC}, > + {1, "ORACLE", "Sudbury ", PPC}, > {0, "", ""}, > }; > Acked-by: Kristen Carlson Accardi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] intel_pstate: append more Oracle OEM table id to vendor bypass list

2015-08-05 Thread Kristen Carlson Accardi
[] = { {1, ORACLE, X4270M3 , PPC}, {1, ORACLE, X4270M2 , PPC}, {1, ORACLE, X4170M2 , PPC}, + {1, ORACLE, X4170 M3, PPC}, + {1, ORACLE, X4275 M3, PPC}, + {1, ORACLE, X6-2, PPC}, + {1, ORACLE, Sudbury , PPC}, {0, , }, }; Acked-by: Kristen Carlson

Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing

2015-07-21 Thread Kristen Carlson Accardi
pstate, > .get_turbo = knl_get_turbo_pstate, > + .get_scaling = core_get_scaling, > .set = core_set_pstate, > }, > }; Acked-by: Kristen Carlson Accardi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: [PATCH] intel_pstate: Add get_scaling cpu_defaults param to Knights Landing

2015-07-21 Thread Kristen Carlson Accardi
= core_get_min_pstate, .get_turbo = knl_get_turbo_pstate, + .get_scaling = core_get_scaling, .set = core_set_pstate, }, }; Acked-by: Kristen Carlson Accardi kris...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay [v2]

2015-06-15 Thread Kristen Carlson Accardi
iver should not panic in this situation. This > patch changes the div_fp() function to use div64_s64() to allow for "long" > division. This will avoid the overflow condition on long delays. > > [v2]: use div64_s64() in div_fp() Were you able to resolve your original concerns

Re: [PATCH] cpufreq, Fix overflow in busy_scaled due to long delay [v2]

2015-06-15 Thread Kristen Carlson Accardi
? Thanks, Kristen Cc: Kristen Carlson Accardi kris...@linux.intel.com Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Doug Smythies dsmyth...@telus.net Cc: linux...@vger.kernel.org Signed-off-by: Prarit Bhargava pra...@redhat.com --- drivers/cpufreq

Re: [PATCH] intel_pstate: set BYT MSR with wrmsrl_on_cpu()

2015-05-11 Thread Kristen Carlson Accardi
I believe my first inline comment spoke to this. > > So here's the changelog I'd use with this patch: > > "Commit 007bea098b86 (intel_pstate: Add setting voltage value for baytrail > P states.) introduced byt_set_pstate() with the assumption that it would > always be run by the CPU whose MSR is to be written by it. It turns out, > however, that is not always the case in practice, so modify byt_set_pstate() > to enforce the MSR write done by it to always happen on the right CPU." > > I don't think you need to say anything more in it. Mentioning governors in > particular is unnecessary and confusing. > > Kristen, what do you think? > > Looks good to me with the modified changelog. Acked-by: Kristen Carlson Accardi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] intel_pstate: set BYT MSR with wrmsrl_on_cpu()

2015-05-11 Thread Kristen Carlson Accardi
is unnecessary and confusing. Kristen, what do you think? Looks good to me with the modified changelog. Acked-by: Kristen Carlson Accardi kris...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] cpufreq/intel_pstate: Fix an annoying !CONFIG_SMP warning

2015-04-13 Thread Kristen Carlson Accardi
gt; > struct cpuinfo_x86 *c = _cpu_data; > > > > Rename the local variable and use static_cpu_has_safe() which alleviates > > the need for defining a local cpuinfo_x86 pointer. > > Kristen, any comments here? Seems fine to me. Acked-by: Kristen Carlson Ac

Re: [PATCH] cpufreq/intel_pstate: Fix an annoying !CONFIG_SMP warning

2015-04-13 Thread Kristen Carlson Accardi
a local cpuinfo_x86 pointer. Kristen, any comments here? Seems fine to me. Acked-by: Kristen Carlson Accardi kris...@linux.intel.com Signed-off-by: Borislav Petkov b...@suse.de Cc: Kristen Carlson Accardi kris...@linux.intel.com Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Viresh Kumar

Re: [PATCH 2/2 V9] intel_pstate: add kernel parameter to force loading.

2014-12-10 Thread Kristen Carlson Accardi
et better performance with this driver. > > Signed-off-by: Ethan Zhao > Tested-by: Alexey Kodanev > Reviewed-by: Linda Knippers Acked-by: Kristen Carlson Accardi > --- > v2: change to hardware vendor specific naming parameter. > v4: refine code and doc. > v5: fix a typo in doc.

Re: [PATCH 2/2 V9] intel_pstate: add kernel parameter to force loading.

2014-12-10 Thread Kristen Carlson Accardi
with this driver. Signed-off-by: Ethan Zhao ethan.z...@oracle.com Tested-by: Alexey Kodanev alexey.koda...@oracle.com Reviewed-by: Linda Knippers linda.knipp...@hp.com Acked-by: Kristen Carlson Accardi kris...@linux.intel.com --- v2: change to hardware vendor specific naming parameter

Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-04 Thread Kristen Carlson Accardi
On Thu, 04 Dec 2014 23:10:58 +0100 "Rafael J. Wysocki" wrote: > On Thursday, December 04, 2014 11:07:31 AM Ethan Zhao wrote: > > To force loading on Oracle Sun X86 servers, provide one kernel command line > > parameter > > > > intel_pstate = ora_force > > I would suggest to change the name

Re: [PATCH 2/2 V7] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-04 Thread Kristen Carlson Accardi
On Thu, 04 Dec 2014 23:10:58 +0100 Rafael J. Wysocki r...@rjwysocki.net wrote: On Thursday, December 04, 2014 11:07:31 AM Ethan Zhao wrote: To force loading on Oracle Sun X86 servers, provide one kernel command line parameter intel_pstate = ora_force I would suggest to change the

Re: [PATCH 2/2 V6] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-02 Thread Kristen Carlson Accardi
On Fri, 28 Nov 2014 12:36:17 +0900 Ethan Zhao wrote: > To force loading on Oracle Sun X86 servers, provide one kernel command line > parameter > > intel_pstate = ora_force > > For those who be aware of the risk of no power capping capabily working and > try to get better performance with

Re: [PATCH 1/2 V6] intel_pstate: skip this driver if Sun server has _PPC method

2014-12-02 Thread Kristen Carlson Accardi
randewie > Tested-by: Linda Knippers Acked-by: Kristen Carlson Accardi > --- > v2: fix break HP Proliant issue. > v3: expand the hardware vendor list. > v4: refine code. > v5v6: change enum PCC to PPC. > > drivers/cpufreq/intel_pstate.c | 45 > +++

Re: [PATCH 1/2 V6] intel_pstate: skip this driver if Sun server has _PPC method

2014-12-02 Thread Kristen Carlson Accardi
Signed-off-by: Dirk Brandewie dirk.brande...@gmail.com Tested-by: Linda Knippers linda.knipp...@hp.com Acked-by: Kristen Carlson Accardi kris...@linux.intel.com --- v2: fix break HP Proliant issue. v3: expand the hardware vendor list. v4: refine code. v5v6: change enum PCC to PPC

Re: [PATCH 2/2 V6] intel_pstate: add kernel parameter to force loading on Sun X86 servers.

2014-12-02 Thread Kristen Carlson Accardi
On Fri, 28 Nov 2014 12:36:17 +0900 Ethan Zhao ethan.z...@oracle.com wrote: To force loading on Oracle Sun X86 servers, provide one kernel command line parameter intel_pstate = ora_force For those who be aware of the risk of no power capping capabily working and try to get better

Re: [PATCH 3/3] intel_pstate: add module and kernel command line parameter to ignore ACPI _PPC

2014-11-20 Thread Kristen Carlson Accardi
On Thu, 20 Nov 2014 08:57:34 +0800 ethan wrote: > > > > 在 2014年11月20日,03:05,Kristen Carlson Accardi 写道: > > > > On Tue, 18 Nov 2014 17:37:06 +0900 > > Ethan Zhao wrote: > > > >> Add kernel command line parameter > >> in

Re: [PATCH 3/3] intel_pstate: add module and kernel command line parameter to ignore ACPI _PPC

2014-11-20 Thread Kristen Carlson Accardi
On Thu, 20 Nov 2014 08:57:34 +0800 ethan ethan.ker...@gmail.com wrote: 在 2014年11月20日,03:05,Kristen Carlson Accardi kris...@linux.intel.com 写道: On Tue, 18 Nov 2014 17:37:06 +0900 Ethan Zhao ethan.z...@oracle.com wrote: Add kernel command line parameter intel_pstate

Re: [PATCH 3/3] intel_pstate: add module and kernel command line parameter to ignore ACPI _PPC

2014-11-19 Thread Kristen Carlson Accardi
On Tue, 18 Nov 2014 17:37:06 +0900 Ethan Zhao wrote: > Add kernel command line parameter > intel_pstate = ignore_acpi_ppc > and module parameter > ignore_acpi_ppc = 1 > to allow driver to ignore the ACPI _PPC existence even for Sun x86 servers. > These parameter could be used for

Re: [PATCH 2/3] intel_pstate: allow driver to be built as a module

2014-11-19 Thread Kristen Carlson Accardi
On Tue, 18 Nov 2014 17:37:05 +0900 Ethan Zhao wrote: > From: Brian Maly > > To provide the flexibility of module, allow this driver to > be configured and built as a module. > > Signed-off-by: Brian Maly > Signed-off-by: Ethan Zhao I believe the entire concept of being able to use

Re: [PATCH 2/3] intel_pstate: allow driver to be built as a module

2014-11-19 Thread Kristen Carlson Accardi
On Tue, 18 Nov 2014 17:37:05 +0900 Ethan Zhao ethan.z...@oracle.com wrote: From: Brian Maly brian.m...@oracle.com To provide the flexibility of module, allow this driver to be configured and built as a module. Signed-off-by: Brian Maly brian.m...@oracle.com Signed-off-by: Ethan Zhao

Re: [PATCH 3/3] intel_pstate: add module and kernel command line parameter to ignore ACPI _PPC

2014-11-19 Thread Kristen Carlson Accardi
On Tue, 18 Nov 2014 17:37:06 +0900 Ethan Zhao ethan.z...@oracle.com wrote: Add kernel command line parameter intel_pstate = ignore_acpi_ppc and module parameter ignore_acpi_ppc = 1 to allow driver to ignore the ACPI _PPC existence even for Sun x86 servers. These parameter could be used

Re: 2.6.25-rc2 Thinkpad T30 docking fails with oops.

2008-02-22 Thread Kristen Carlson Accardi
On Fri, 22 Feb 2008 00:34:17 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 19 Feb 2008 20:47:08 + Paul Martin <[EMAIL PROTECTED]> wrote: > > > Now, this was working in 2.6.23, but is not in any later kernel. > > Previously reported, but I guess that the previous report was > >

Re: 2.6.25-rc2 Thinkpad T30 docking fails with oops.

2008-02-22 Thread Kristen Carlson Accardi
On Fri, 22 Feb 2008 00:34:17 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Tue, 19 Feb 2008 20:47:08 + Paul Martin <[EMAIL PROTECTED]> wrote: > > > Now, this was working in 2.6.23, but is not in any later kernel. > > Previously reported, but I guess that the previous report was > >

Re: 2.6.25-rc2 Thinkpad T30 docking fails with oops.

2008-02-22 Thread Kristen Carlson Accardi
On Fri, 22 Feb 2008 00:34:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 19 Feb 2008 20:47:08 + Paul Martin [EMAIL PROTECTED] wrote: Now, this was working in 2.6.23, but is not in any later kernel. Previously reported, but I guess that the previous report was ignored due to

Re: 2.6.25-rc2 Thinkpad T30 docking fails with oops.

2008-02-22 Thread Kristen Carlson Accardi
On Fri, 22 Feb 2008 00:34:17 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 19 Feb 2008 20:47:08 + Paul Martin [EMAIL PROTECTED] wrote: Now, this was working in 2.6.23, but is not in any later kernel. Previously reported, but I guess that the previous report was ignored due to

Re: [PATCH] enclosure: add support for enclosure services

2008-02-13 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 13:28:15 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: > > I understand what you are trying to do - I guess I just doubt the > > value you've added by doing this. I think that there

Re: [PATCH] enclosure: add support for enclosure services

2008-02-13 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 13:28:15 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: I understand what you are trying to do - I guess I just doubt the value you've added by doing this. I think that there's going to be so much

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 12:45:35 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote: > > I apologize for taking so long to review this patch. I obviously > > agree wholeheartedly with Luben. The problem I ran

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Mon, 4 Feb 2008 18:01:36 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> wrote: > --- On Mon, 2/4/08, James Bottomley > <[EMAIL PROTECTED]> wrote: > > > > The enclosure misc device is really just a > > library providing > > > > sysfs > > > > support for physical enclosure devices and their > > >

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 12:45:35 -0600 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote: I apologize for taking so long to review this patch. I obviously agree wholeheartedly with Luben. The problem I ran into while trying to design

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Mon, 4 Feb 2008 18:01:36 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Mon, 2/4/08, James Bottomley [EMAIL PROTECTED] wrote: The enclosure misc device is really just a library providing sysfs support for physical enclosure devices and their components. Who

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-03 Thread Kristen Carlson Accardi
On Sat, 01 Dec 2007 18:28:54 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kristen Carlson Accardi wrote: > > Enclosure Management via LED > > > > This patch implements Enclosure Management via the LED protocol as > > specified in AHCI specification. > &

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-03 Thread Kristen Carlson Accardi
On Sat, 01 Dec 2007 18:28:54 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi [EMAIL

  1   2   3   4   5   >