Re: [PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue

On Fri, Apr 09, 2021 at 07:40:57AM -0700, Joe Perches wrote: > On Fri, 2021-04-09 at 00:09 -0300, Luiz Sampaio wrote: > > Since there is only one statement inside the if clause, no brackets are > > required. > [] > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/drive

[PATCH v7 6/6] w1: ds2438: support for writing to offset register

to the offset register if the two's complement of the current register while passing zero current to the load will calibrate the measurements. This change was tested on real hardware and it was able to calibrate the chip correctly. Signed-off-by: Luiz Sampaio --- .../ABI/stable/sysfs-driver-w1_ds2438

[PATCH v7 5/6] w1: ds2438: adding support for reading page1

Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio

[PATCH v7 4/6] w1: ds2438: fixing bug that would always get page0

The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio

[PATCH v7 3/6] w1: ds2438: changed sysfs macro for rw file

The iad sysfs file has permissions for read and write. Changed to the recommended macro BIN_ATTR_RW. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c

[PATCH v7 2/6] w1: ds2438: fixed if brackets coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c

[PATCH v7 1/6] w1: ds2438: fixed a coding style issue

There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1

[PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements

not compile. I'm sorry. Fixed it. Changes in v2: - Using git send-email to send the patches - Adding documentation as requested - Separating the coding style changes in different patches as requested Luiz Sampaio (6): w1: ds2438: fixed a coding style issue w1: ds2438: fixed if brackets coding

[PATCH v6 6/6] w1: ds2438: support for writing to offset register

to the offset register if the two's complement of the current register while passing zero current to the load will calibrate the measurements. This change was tested on real hardware and it was able to calibrate the chip correctly. Signed-off-by: Luiz Sampaio --- .../ABI/stable/sysfs-driver-w1_ds2438

[PATCH v6 5/6] w1: ds2438: adding support for reading page1

Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio

[PATCH v6 2/6] w1: ds2438: fixed if brackets coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c

[PATCH v6 4/6] w1: ds2438: fixing bug that would always get page0

The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio

[PATCH v6 3/6] w1: ds2438: fixed a coding style issue

Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers

[PATCH v6 1/6] w1: ds2438: fixed a coding style issue

There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1

[PATCH v6 0/9] w1: ds2438: adding support for calibration of current measurements

it. Changes in v2: - Using git send-email to send the patches - Adding documentation as requested - Separating the coding style changes in different patches as requested Luiz Sampaio (9): w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style

[PATCH v5 6/6] w1: ds2438: support for writing to offset register

to the offset register if the two's complement of the current register while passing zero current to the load will calibrate the measurements. This change was tested on real hardware and it was able to calibrate the chip correctly. Signed-off-by: Luiz Sampaio --- .../ABI/stable/sysfs-driver-w1_ds2438

[PATCH v5 5/6] w1: ds2438: adding support for reading page1

Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio

[PATCH v5 1/6] w1: ds2438: fixed a coding style issue

There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1

[PATCH v5 4/6] w1: ds2438: fixing bug that would always get page0

The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio

[PATCH v5 3/6] w1: ds2438: fixed a coding style issue

Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers

[PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c

[PATCH v5 0/9] w1: ds2438: adding support for calibration of current measurements

documentation as requested - Separating the coding style changes in different patches as requested Luiz Sampaio (9): w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed

Re: [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style

On Mon, Apr 05, 2021 at 12:53:22PM +0200, Greg KH wrote: > On Mon, Apr 05, 2021 at 07:50:06AM -0300, Luiz Sampaio wrote: > > Changed the permissions to preferred octal style. > > > > Signed-off-by: Luiz Sampaio > > --- > > drivers/w1/slaves/w1_ds2438.c | 2 +-

Re: [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements

On Mon, Apr 05, 2021 at 12:53:38PM +0200, Greg KH wrote: > On Mon, Apr 05, 2021 at 07:50:00AM -0300, Luiz Sampaio wrote: > > The following patches aim to make a user able to calibrate the current > > measurement of the DS2438. This chip uses a offset register in page1, whic

Re: [PATCH v4 9/9] w1: ds2438: support for writing to offset register

On Mon, Apr 05, 2021 at 01:04:59PM +0200, Greg KH wrote: > On Mon, Apr 05, 2021 at 07:50:09AM -0300, Luiz Sampaio wrote: > > Added a sysfs entry to support writing to the offset register on page1. > > This register is used to calibrate the chip canceling offset errors in the

[PATCH v4 7/9] w1: ds2438: fixing bug that would always get page0

The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio

[PATCH v4 9/9] w1: ds2438: support for writing to offset register

to the offset register if the two's complement of the current register while passing zero current to the load will calibrate the measurements. This change was tested on real hardware and it was able to calibrate the chip correctly. Signed-off-by: Luiz Sampaio --- Documentation/w1/slaves/w1_ds2438.rst

[PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style

Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers

[PATCH v4 8/9] w1: ds2438: adding support for reading page1

Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio

[PATCH v4 5/9] w1: ds2438: fixed a coding style issue in vdd_read

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v4 3/9] w1: ds2438: fixed a coding style issue in temperature_read

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v4 2/9] w1: ds2438: fixed a coding style issue in iad_read

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v4 4/9] w1: ds2438: fixed a coding style issue in vad_read

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements

added a wrong line that would not compile. I'm sorry. Fixed it. Changes in v2: - Using git send-email to send the patches - Adding documentation as requested - Separating the coding style changes in different patches as requested Luiz Sampaio (9): w1: ds2438: fixed a coding style issue w1

[PATCH v4 1/9] w1: ds2438: fixed a coding style issue after return

There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1

[PATCH v3 9/9] w1: ds2438: support for writing to offset register

to the offset register if the two's complement of the current register while passing zero current to the load will calibrate the measurements. This change was tested on real hardware and it was able to calibrate the chip correctly. Signed-off-by: Luiz Sampaio --- Documentation/w1/slaves/w1_ds2438.rst

[PATCH v3 8/9] w1: ds2438: adding support for reading page1

Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio

[PATCH v3 7/9] w1: ds2438: fixing bug that would always get page0

The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio

[PATCH v3 6/9] w1: ds2438: fixed a coding style issue

Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers

[PATCH v3 5/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v3 4/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v3 3/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v3 1/9] w1: ds2438: fixed a coding style issue

There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1

[PATCH v3 2/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v3 0/9] w1: ds2438: adding support for calibration of current measurements

git send-email to send the patches - Adding documentation as requested - Separating the coding style changes in different patches as requested Luiz Sampaio (9): w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438

[PATCH v2 9/9] w1: ds2438: support for writing to offset register

to the offset register if the two's complement of the current register while passing zero current to the load will calibrate the measurements. This change was tested on real hardware and it was able to calibrate the chip correctly. Signed-off-by: Luiz Sampaio --- Documentation/w1/slaves/w1_ds2438.rst

[PATCH v2 8/9] w1: ds2438: adding support for reading page1

Added a sysfs entry to support reading the page1 registers. This registers contain Elapsed Time Meter (ETM) data, which shows for how long the chip is on, as well as an Offset Register data, which can be used to calibrate the current measurement of the chip. Signed-off-by: Luiz Sampaio

[PATCH v2 7/9] w1: ds2438: fixing bug that would always get page0

The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page. Signed-off-by: Luiz Sampaio

[PATCH v2 6/9] w1: ds2438: fixed a coding style issue

Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers

[PATCH v2 2/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v2 5/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v2 4/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v2 3/9] w1: ds2438: fixed a coding style issue

Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v2 1/9] w1: ds2438: fixed a coding style issue

There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1

[PATCH v2 0/9] w1: ds2438: adding support for calibration of current measurements

style changes in different patches as requested Luiz Sampaio (9): w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding

[PATCH 3/3] w1: ds2438: adding support for accessing page1 registers

the calibration steps explained in the datasheet can use this driver to fully calibrate de current measurements. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 94 ++- 1 file changed, 92 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves

[PATCH 2/3] w1: ds2438: fixed bug in get_page function

The get_page function always returned register values from page 0. Fixes by writing the actual page number to the bus. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1

[PATCH 1/3] w1: ds2438: fixed a coding style issues

Fixed coding style issues. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 5cfb0ae23e91..a9884fc8c726 100644

[PATCH 0/3] w1: ds2438: adding support for calibration of current measurements

to the offset register. This patch was tested on real hardware using a power supply and an electronic load. Please help to review this series of patches. Best regards! Sampaio Luiz Sampaio (3): w1: ds2438: fixed a coding style issues w1: ds2438: fixed bug in get_page function w1: ds2438: adding

[PATCH] w1: ds2438: fixing bug in get_page function

In the w1_ds2438_get_page function, there is an argument to change the page number you want to read from the chip. But this was always getting the page 0, not the pageno page. Fixed it. Also fixed coding style issue. Signed-off-by: Luiz Sampaio ---  drivers/w1/slaves/w1_ds2438.c | 31