Re: [PATCH 0/5] Bring the BusLogic host bus adapter driver up to Y2021

2021-04-20 Thread Maciej W. Rozycki
On Mon, 19 Apr 2021, Khalid Aziz wrote: > > Khalid: I have skimmed over these documents and I infer 24-bit addressing > > can be verified with any MultiMaster adapter, including ones that do have > > 32-bit addressing implemented, by using the legacy Initialize Mailbox HBA > > command. That c

[PATCH v2 5/5] scsi: Set allocation length to 255 for ATA Information VPD page

2021-04-20 Thread Maciej W. Rozycki
ogy - Small Computer System Interface - 2", WORKING DRAFT, X3T9.2, Project 375D, Revision 10L, 7-SEP-93, Section 8.2.5 "INQUIRY command", pp.104-108 Signed-off-by: Maciej W. Rozycki Fixes: af73623f5f10 ("[SCSI] sd: Reduce buffer size for vpd request") --- No changes fr

[PATCH v2 3/5] scsi: Provide for avoiding trailing allocation length with VPD inquiries

2021-04-20 Thread Maciej W. Rozycki
d 0:0:1:0: scsi_vpd_inquiry(0): buf[512] => -5 (here with the buffer size set back to 512, the `BusLogic=TraceErrors' parameter and trailing sense data zeros trimmed for brevity). Note the sense key of 0x5 returned denoting an illegal request even for page 0. Signed-off-by: Ma

[PATCH v2 4/5] scsi: Avoid using reserved length byte with VPD inquiries

2021-04-20 Thread Maciej W. Rozycki
first and only then issuing the intended request for full data. References: [1] "Information technology - Small Computer System Interface - 2", WORKING DRAFT, X3T9.2, Project 375D, Revision 10L, 7-SEP-93, Section 8.2.5 "INQUIRY command", pp.104-108 [2] same, Sect

[PATCH v2 1/5] scsi: BusLogic: Fix missing `pr_cont' use

2021-04-20 Thread Maciej W. Rozycki
39 35 38 20 20 00 C4 00 04 01 07 2F 07 04 35 FF FF FF FF FF FF FF FF FF FF 01 00 FE FF 08 FF FF 00 00 00 00 00 00 00 01 00 01 00 00 FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 FC scsi0: Configuring BusLogic Model BT-958 PCI Wide Ultra SCSI Host Adapter etc. Signed-off-by: Maciej W. Rozycki Fix

[PATCH v2 2/5] scsi: BusLogic: Avoid unbounded `vsprintf' use

2021-04-20 Thread Maciej W. Rozycki
r by using `vscnprintf' rather than `vsprintf'. Signed-off-by: Maciej W. Rozycki --- Changes from v1: - use `vscnprintf' instead of `vsnprintf' for the correct character count. --- drivers/scsi/BusLogic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) linux-buslogic-vscn

[PATCH v2 0/5] Bring the BusLogic host bus adapter driver up to Y2021

2021-04-20 Thread Maciej W. Rozycki
Hi, This is v2 of the series with 2/5 updated to use `vscnprintf' rather than `vsnprintf'. No other changes. So we are here owing to Christoph's recent ISA bounce buffering sweep:

[PATCH 3/4] MIPS: Reinstate platform `__div64_32' handler

2021-04-19 Thread Maciej W. Rozycki
div64 and reduced the module's average execution time down to 1.0668s and 0.2629s from 2.1529s and 0.5647s respectively for an R3400 CPU @40MHz and a 5Kc CPU @160MHz. For a reference 64-bit `do_div' code where we have the DDIVU instruction available to do the whole calculation right

[PATCH 1/4] lib/math: Add a `do_div' test module

2021-04-19 Thread Maciej W. Rozycki
stant and as a variable each, so as to verify the implementation for both cases should they be handled by different code execution paths. Reference results were produced with GNU bc. At the conclusion output the total execution time elapsed. Signed-off-by: Maciej W. Rozycki --- NB ther

[PATCH 2/4] div64: Correct inline documentation for `do_div'

2021-04-19 Thread Maciej W. Rozycki
if the C++ semantics is not readily understood. While at it observe that "semantics" is an uncountable noun, so refer to it with a singular rather than plural verb. Signed-off-by: Maciej W. Rozycki --- NB there's a `checkpatch.pl' warning for tabs preceded by spaces, but that

[PATCH 4/4] MIPS: Avoid DIVU in `__div64_32' is result would be zero

2021-04-19 Thread Maciej W. Rozycki
R3400 CPU @40MHz and a 5Kc CPU @160MHz. Signed-off-by: Maciej W. Rozycki --- I have made an experimental change on top of this to put `__div64_32' out of line, and that increases the averages respectively up to 1.0785s and 0.2705s. Not a terrible loss, especially compared to generic ti

[PATCH 0/4] Reinstate and improve MIPS `do_div' implementation

2021-04-19 Thread Maciej W. Rozycki
Hi, As Huacai has recently discovered the MIPS backend for `do_div' has been broken and inadvertently disabled with commit c21004cd5b4c ("MIPS: Rewrite to work with gcc 4.4.0."). As it is code I have originally written myself and Huacai had issues bringing it back to life leading to a reque

Re: [PATCH 0/5] Bring the BusLogic host bus adapter driver up to Y2021

2021-04-19 Thread Maciej W. Rozycki
On Mon, 19 Apr 2021, Khalid Aziz wrote: > On 4/18/21 2:21 PM, Ondrej Zary wrote: > > > > Found the 3000763 document here: > > https://doc.lagout.org/science/0_Computer Science/0_Computer > > History/old-hardware/buslogic/3000763_PCI_EISA_Wide_SCSI_Tech_Ref_Dec94.pdf > > > > There's also 3002593

[tip: x86/build] x86/build: Disable HIGHMEM64G selection for M486SX

2021-04-19 Thread tip-bot2 for Maciej W. Rozycki
The following commit has been merged into the x86/build branch of tip: Commit-ID: 0ef3439cd80ba7770723edb0470d15815914bb62 Gitweb: https://git.kernel.org/tip/0ef3439cd80ba7770723edb0470d15815914bb62 Author:Maciej W. Rozycki AuthorDate:Wed, 14 Apr 2021 12:38:28 +02:00

RE: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use

2021-04-17 Thread Maciej W. Rozycki
On Sat, 17 Apr 2021, David Laight wrote: > > > In patch 2, vscnprintf should probably be used to make sure it's > > > 0 terminated. > > > > Why? C99 has this[1]: > > > > "The vsnprintf function is equivalent to snprintf, with the variable > > argument list replaced by arg, which shall have bee

Re: [PATCH 0/5] Bring the BusLogic host bus adapter driver up to Y2021

2021-04-16 Thread Maciej W. Rozycki
On Fri, 16 Apr 2021, Khalid Aziz wrote: > > Sadly I didn't get to these resources while they were still there, and > > neither did archive.org, and now they not appear available from anywhere > > online. I'm sure Leonard had this all, but, alas, he is long gone too. > > These documents were a

Re: [PATCH 5/5] scsi: Set allocation length to 255 for ATA Information VPD page

2021-04-16 Thread Maciej W. Rozycki
On Thu, 15 Apr 2021, Nix wrote: > > Set the allocation length to 255 for the ATA Information VPD page > > requested in the WRITE SAME handler, so as not to limit information > > examined by `scsi_get_vpd_page' in the supported vital product data > > pages unnecessarily. > > > > Originally it wa

Re: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use

2021-04-16 Thread Maciej W. Rozycki
On Fri, 16 Apr 2021, Joe Perches wrote: > > I'm not sure if that complex message > > routing via `blogic_msg' is worth having even, rather than calling > > `printk' or suitable variants directly. > > It's to allow the message content to be added to the internal > &adapter->msgbuf[adapter-

Re: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use

2021-04-16 Thread Maciej W. Rozycki
On Thu, 15 Apr 2021, Joe Perches wrote: > In patch 2, vscnprintf should probably be used to make sure it's > 0 terminated. Why? C99 has this[1]: "The vsnprintf function is equivalent to snprintf, with the variable argument list replaced by arg, which shall have been initialized by the va_sta

[PATCH 5/5] scsi: Set allocation length to 255 for ATA Information VPD page

2021-04-14 Thread Maciej W. Rozycki
ogy - Small Computer System Interface - 2", WORKING DRAFT, X3T9.2, Project 375D, Revision 10L, 7-SEP-93, Section 8.2.5 "INQUIRY command", pp.104-108 Signed-off-by: Maciej W. Rozycki Fixes: af73623f5f10 ("[SCSI] sd: Reduce buffer size for vpd request") --- Nix, I can

[PATCH 4/5] scsi: Avoid using reserved length byte with VPD inquiries

2021-04-14 Thread Maciej W. Rozycki
first and only then issuing the intended request for full data. References: [1] "Information technology - Small Computer System Interface - 2", WORKING DRAFT, X3T9.2, Project 375D, Revision 10L, 7-SEP-93, Section 8.2.5 "INQUIRY command", pp.104-108 [2] same, Sect

[PATCH 3/5] scsi: Provide for avoiding trailing allocation length with VPD inquiries

2021-04-14 Thread Maciej W. Rozycki
d 0:0:1:0: scsi_vpd_inquiry(0): buf[512] => -5 (here with the buffer size set back to 512, the `BusLogic=TraceErrors' parameter and trailing sense data zeros trimmed for brevity). Note the sense key of 0x5 returned denoting an illegal request even for page 0. Signed-off-by: Ma

[PATCH 2/5] scsi: BusLogic: Avoid unbounded `vsprintf' use

2021-04-14 Thread Maciej W. Rozycki
r by using `vsnprintf' rather than `vsprintf'. Signed-off-by: Maciej W. Rozycki --- drivers/scsi/BusLogic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) linux-buslogic-vsnprintf.diff Index: linux-macro-ide/dri

[PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use

2021-04-14 Thread Maciej W. Rozycki
39 35 38 20 20 00 C4 00 04 01 07 2F 07 04 35 FF FF FF FF FF FF FF FF FF FF 01 00 FE FF 08 FF FF 00 00 00 00 00 00 00 01 00 01 00 00 FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 FC scsi0: Configuring BusLogic Model BT-958 PCI Wide Ultra SCSI Host Adapter etc. Signed-off-by: Maciej W. Rozycki Fix

[PATCH 0/5] Bring the BusLogic host bus adapter driver up to Y2021

2021-04-14 Thread Maciej W. Rozycki
Hi, First of all, does anyone have a copy of: "MultiMaster UltraSCSI Host Adapters for PCI Systems: Technical Reference Manual" (pub. 3002493-E)? It used to live in the "Mylex Manuals and Documentation Archives" section of the Mylex web site , spec

[PATCH] x86: Disable HIGHMEM64G selection for M486SX

2021-04-14 Thread Maciej W. Rozycki
-PAE-enabled processors: High Memory Support > 1. off (NOHIGHMEM) 2. 4GB (HIGHMEM4G) 3. 64GB (HIGHMEM64G) choice[1-3?]: With the fix in place the setting is now correctly removed: High Memory Support > 1. off (NOHIGHMEM) 2. 4GB (HIGHMEM4G) choice[1-2?]: Signed-off-by: Maciej W. R

Re: [PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2021-04-12 Thread Maciej W. Rozycki
On Mon, 12 Apr 2021, Daniel Vetter wrote: > > Note that it's entirely possible that things continue to work well > > despite this warning. It's unclear to me from your email if you > > actually see any difference (and apparently you're not able to see it > > right now due to not being close to the

Re: [PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2021-04-11 Thread Maciej W. Rozycki
On Tue, 29 Sep 2020, Greg KH wrote: > > > > >> VT_RESIZEX was introduced in Linux 1.3.3, but it is unclear that what > > > > >> comes to the "+ more" part, and I couldn't find a user of VT_RESIZEX. > > > > >> > > > > > > > > > > It seems this is/was used by "svgatextmode" which seems to be at > >

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-08 Thread Maciej W. Rozycki
On Fri, 9 Apr 2021, Masami Hiramatsu wrote: > > > Is this approach guaranteed to keep interrupt handling latency low enough > > > for the system not to be negatively affected, e.g. for the purpose of NTP > > > timekeeping? > > > > IMHO, interrupt latency can't be ensured if kprobes is triggered.

Re: [PATCH v2] MIPS: add support for buggy MT7621S core detection

2021-04-07 Thread Maciej W. Rozycki
On Mon, 5 Apr 2021, Ilya Lipnitskiy wrote: > diff --git a/arch/mips/include/asm/mips-cps.h > b/arch/mips/include/asm/mips-cps.h > index fd43d876892e..9f495ffef2b7 100644 > --- a/arch/mips/include/asm/mips-cps.h > +++ b/arch/mips/include/asm/mips-cps.h > @@ -165,11 +167,29 @@ static inline uint64_

Re: [PATCH] MIPS: add support for buggy MT7621S core detection

2021-04-07 Thread Maciej W. Rozycki
On Mon, 5 Apr 2021, Ilya Lipnitskiy wrote: > Thanks for the comments. Including asm/bugs.h in asm/mips-cps.h led to > some circular dependencies when I tried it, but I will try again based > on your feedback - indeed it would be much cleaner to have this logic > in mips_cps_numcores. The only wrin

Re: [PATCH] MIPS: add support for buggy MT7621S core detection

2021-04-05 Thread Maciej W. Rozycki
On Fri, 2 Apr 2021, Ilya Lipnitskiy wrote: > diff --git a/arch/mips/include/asm/bugs.h b/arch/mips/include/asm/bugs.h > index d72dc6e1cf3c..d32f0c4e61f7 100644 > --- a/arch/mips/include/asm/bugs.h > +++ b/arch/mips/include/asm/bugs.h > @@ -50,4 +51,21 @@ static inline int r4k_daddiu_bug(void) >

Re: [PATCH] riscv: keep interrupts disabled for BREAKPOINT exception

2021-04-03 Thread Maciej W. Rozycki
On Thu, 1 Apr 2021, Masami Hiramatsu wrote: > > > > Current riscv's kprobe handlers are run with both preemption and > > > > interrupt enabled, this violates kprobe requirements. Fix this issue > > > > by keeping interrupts disabled for BREAKPOINT exception. > > > > > > Not only while the break

Re: [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024

2021-04-02 Thread Maciej W. Rozycki
On Fri, 2 Apr 2021, David Abdurachmanov wrote: > > > > This macro is exported as a part of the user API so it must not depend > > > > on > > > > Kconfig. Also changing it (rather than say adding COMMAND_LINE_SIZE_V2 > > > > or > > > > switching to an entirely new data object that has its dimen

Re: [PATCH] riscv: Bump COMMAND_LINE_SIZE value to 1024

2021-03-30 Thread Maciej W. Rozycki
On Mon, 29 Mar 2021, Palmer Dabbelt wrote: > > --- /dev/null > > +++ b/arch/riscv/include/uapi/asm/setup.h > > @@ -0,0 +1,8 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ > > + > > +#ifndef _UAPI_ASM_RISCV_SETUP_H > > +#define _UAPI_ASM_RISCV_SETUP_H > > + > > +#define

Re: How long should be PCIe card in Warm Reset state?

2021-03-30 Thread Maciej W. Rozycki
On Tue, 30 Mar 2021, Pali Rohár wrote: > > The spec does not give any exceptions AFAICT as to the timeouts required > > between the three kinds of a Conventional Reset (Hot, Warm, or Cold) and > > refers to them collectively as a Conventional Reset across the relevant > > parts of the document

Re: How long should be PCIe card in Warm Reset state?

2021-03-30 Thread Maciej W. Rozycki
On Tue, 30 Mar 2021, Pali Rohár wrote: > > If I were to implement this stuff, for good measure I'd give it a safety > > margin beyond what the spec requires and use a timeout of say 2-4s while > > actively querying the status of the device. The values given in the spec > > are only the minimu

RE: How long should be PCIe card in Warm Reset state?

2021-03-30 Thread Maciej W. Rozycki
On Thu, 25 Mar 2021, David Laight wrote: > I can't see the value in the (nice bound) copy of the PCI 2.0 spec I have. > But IIRC it is 100ms (it might just me 500ms). > While this might seem like ages it can be problematic if targets have > to load large FPGA images from serial EEPROMs. AFAICT i

Re: [PATCH v2] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again

2021-03-28 Thread Maciej W. Rozycki
On Thu, 25 Mar 2021, Tiezhu Yang wrote: > > > I wonder whether MIPS EVA will generate overlapping address ranges? > > they can overlap in EVA mode. > > > > > If yes, it is better to make ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE depend > > > on !EVA on MIPS. > > Could please add the change ? > > OK

Re: [PATCH v2] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again

2021-03-22 Thread Maciej W. Rozycki
On Mon, 22 Mar 2021, Tiezhu Yang wrote: > > > --- a/arch/mips/Kconfig > > > +++ b/arch/mips/Kconfig > > > @@ -6,6 +6,7 @@ config MIPS > > > select ARCH_BINFMT_ELF_STATE if MIPS_FP_SUPPORT > > > select ARCH_HAS_FORTIFY_SOURCE > > > select ARCH_HAS_KCOV > > > + select A

Re: [PATCH v2] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again

2021-03-21 Thread Maciej W. Rozycki
On Thu, 18 Mar 2021, Tiezhu Yang wrote: > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index 160b3a8..4b94ec7 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -6,6 +6,7 @@ config MIPS > select ARCH_BINFMT_ELF_STATE if MIPS_FP_SUPPORT > select ARCH_HAS_FORTIFY_SOU

[PATCH 2/2] MIPS: SiByte: Enable pata_platform with SWARM defconfig

2021-03-21 Thread Maciej W. Rozycki
Enable support for the onboard PATA PIO mode3 interface, which is one of the boot devices supported by the CFE firmware with the Broadcom SWARM board. Include disk, CD-ROM and generic storage drivers. Signed-off-by: Maciej W. Rozycki --- arch/mips/configs/sb1250_swarm_defconfig |8

[PATCH 1/2] MIPS: SiByte: Regenerate stale SWARM defconfig

2021-03-21 Thread Maciej W. Rozycki
Options have been removed and reordered since the last update, so regenerate the template so as not to interfere with actual changes. Signed-off-by: Maciej W. Rozycki --- arch/mips/configs/sb1250_swarm_defconfig |9 + 1 file changed, 1 insertion(+), 8 deletions(-) linux-swarm

[PATCH 0/2] MIPS: SiByte: Update SWARM defconfig for PATA support

2021-03-21 Thread Maciej W. Rozycki
Hi, In the course of looking into Christoph's recent proposal to drop legacy IDE drivers I have noticed that SiByte SWARM's defconfig does not enable the pata_platform driver for the onboard PATA interface. I think default configuration ought to enable all the supported onboard devices unless

[PATCH 3/3] pata_legacy: Add `probe_mask' parameter like with ide-generic

2021-03-21 Thread Maciej W. Rozycki
da2 sda3 sd 0:0:0:0: [sda] Attached SCSI disk scsi host1: pata_legacy ata2: PATA max PIO4 cmd 0x1e8 ctl 0x3ee irq 11 scsi host1: pata_legacy ata3: PATA max PIO4 cmd 0x1e0 ctl 0x3e6 irq 8 Signed-off-by: Maciej W. Rozycki --- Documentation/admin-guide/kernel-parameters.txt | 11 +++

[PATCH 2/3] pata_platform: Document `pio_mask' module parameter

2021-03-21 Thread Maciej W. Rozycki
Add MODULE_PARM_DESC documentation and a kernel-parameters.txt entry. Signed-off-by: Maciej W. Rozycki --- Documentation/admin-guide/kernel-parameters.txt |7 +++ drivers/ata/pata_platform.c |4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) linux-pata

[PATCH 1/3] pata_legacy: Properly document module parameters

2021-03-21 Thread Maciej W. Rozycki
: - `all' affects primary and secondary port ranges only rather than all, - `probe_all' affects tertiary and further port ranges rather than all, - `ht6560b' is for HT 6560B rather than HT 6560A. Signed-off-by: Maciej W. Rozycki --- Documentation/admin-guide/kernel-parame

[PATCH 0/3] ata: Module parameter clean-ups for pata_legacy and pata_platform

2021-03-21 Thread Maciej W. Rozycki
Hi, In the course of looking into Christoph's recent proposal to drop legacy IDE drivers I have come across a number of issues with module parameters of the pata_legacy and pata_platform drivers: errors in documentation present in the comment form, missing user-visible documentation, and unco

Re: [PATCH 10/10] ide: remove the legacy ide driver

2021-03-19 Thread Maciej W. Rozycki
On Sat, 20 Mar 2021, Maciej W. Rozycki wrote: > > been scheduled for removal for a while. Finally kill it off so that we > > can start cleaning up various bits of cruft it forced on the block layer. > > You need to adjust Documentation/admin-guide/kernel-parameters.txt too,

Re: [PATCH 10/10] ide: remove the legacy ide driver

2021-03-19 Thread Maciej W. Rozycki
On Thu, 18 Mar 2021, Christoph Hellwig wrote: > The legay ide driver has been replace with libata startin in 2003 and has s/legay/legacy/;s/replace/replaced/;s/startin/startin/ (though I'd say "back in" instead in the latter case). > been scheduled for removal for a while. Finally kill it off

Re: remove the legacy ide driver

2021-03-19 Thread Maciej W. Rozycki
On Thu, 18 Mar 2021, Christoph Hellwig wrote: > we've been trying to get rid of the legacy ide driver for a while now, > and finally scheduled a removal for 2021, which is three month old now. Hmm, there's still a regression in that pata_legacy unconditionally pokes at random I/O port locations

Re: [PATCH 04/10] MIPS: disable CONFIG_IDE in sb1250_swarm_defconfig

2021-03-18 Thread Maciej W. Rozycki
name of the driver could be improved I suppose though: scsi host0: pata_platform ata1: PATA max PIO0 mmio cmd 0x100b3e00 ctl 0x100b7ec0 irq 36 (PIO3 is actually hardwired; it's an odd interface and people reported issues with it, but I have never had any myself be it with IDE or libata).

RE: [PATCH v2] MIPS: Check __clang__ to avoid performance influence with GCC in csum_tcpudp_nofold()

2021-03-17 Thread Maciej W. Rozycki
On Wed, 17 Mar 2021, David Laight wrote: > > > > Not that I grok the mips opcodes. > > > > But that code has horridness on its side. > > > > It's a 32-bit one's-complement addition. The use of 64-bit operations > > reduces the number of calculations as any 32-bit carries accumulate in the > > h

Re: [PATCH v2] MIPS: Check __clang__ to avoid performance influence with GCC in csum_tcpudp_nofold()

2021-03-17 Thread Maciej W. Rozycki
On Wed, 17 Mar 2021, Tiezhu Yang wrote: > > > The code produced by GCC remains the same between (1), (3) and (4), > > > the last changes looks like better (with less changes based on commit > > > 198688edbf77), so I will send v3 later. > > Aren't those all the same - apart from register selection.

Re: The killing of ideal_nops[]

2021-03-14 Thread Maciej W. Rozycki
On Wed, 10 Mar 2021, Peter Zijlstra wrote: > Below is the latest version which I just pushed out to my git tree so > that the robots can have a go at it. Do you want me to quickly check it with a real i486, or is it already covered by said robots (NB I wouldn't trust QEMU with such stuff)? M

Re: [PATCH v2] MIPS: Check __clang__ to avoid performance influence with GCC in csum_tcpudp_nofold()

2021-03-14 Thread Maciej W. Rozycki
On Tue, 9 Mar 2021, Tiezhu Yang wrote: > diff --git a/arch/mips/include/asm/checksum.h > b/arch/mips/include/asm/checksum.h > index 1e6c135..80eddd4 100644 > --- a/arch/mips/include/asm/checksum.h > +++ b/arch/mips/include/asm/checksum.h > @@ -128,9 +128,13 @@ static inline __sum16 ip_fast_csum(c

[PATCH net-next 4/4] FDDI: defxx: Use driver's name with resource requests

2021-03-10 Thread Maciej W. Rozycki
A (TURBOchannel) adapters. Signed-off-by: Maciej W. Rozycki --- drivers/net/fddi/defxx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) Index: linux-defxx/drivers/net/fddi/defxx.c === --- linux-defxx.orig/d

[PATCH net-next 3/4] FDDI: defxx: Implement dynamic CSR I/O address space selection

2021-03-10 Thread Maciej W. Rozycki
aciej W. Rozycki --- drivers/net/fddi/Kconfig | 19 -- drivers/net/fddi/defxx.c | 60 +-- drivers/net/fddi/defxx.h |3 ++ 3 files changed, 25 insertions(+), 57 deletions(-) Index: linux-defxx/drivers/net/fddi/Kc

[PATCH net/net-next 2/4] FDDI: defxx: Make MMIO the configuration default except for EISA

2021-03-10 Thread Maciej W. Rozycki
the potentially ambiguous PIO acronym with IOP for "port I/O" vs "I/O ports" according to our nomenclature used elsewhere. Signed-off-by: Maciej W. Rozycki Fixes: e89a2cfb7d7b ("[TC] defxx: TURBOchannel support") Cc: sta...@vger.kernel.org # v2.6.21+ --- d

[PATCH net-next 1/3] FDDI: if_fddi.h: Update my e-mail address

2021-03-10 Thread Maciej W. Rozycki
Following the recent update to MAINTAINERS update my e-mail address. Signed-off-by: Maciej W. Rozycki --- include/uapi/linux/if_fddi.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-defxx/include/uapi/linux/if_fddi.h

[PATCH net-next 3/3] FDDI: defza: Update my e-mail address

2021-03-10 Thread Maciej W. Rozycki
Following the recent update to MAINTAINERS update my e-mail address. Signed-off-by: Maciej W. Rozycki --- Documentation/networking/device_drivers/fddi/defza.rst |2 +- drivers/net/fddi/defza.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index

[PATCH net/net-next 1/4] FDDI: defxx: Bail out gracefully with unassigned PCI resource for CSR

2021-03-10 Thread Maciej W. Rozycki
he port I/O space anyway. While at it factor out the error message calls into helpers and fix an argument order bug with the `pr_err' call now in `dfx_register_res_err'. Signed-off-by: Maciej W. Rozycki Fixes: 4d0438e56a8f ("defxx: Clean up DEFEA resource management") Cc: sta

[PATCH 0/4] FDDI: defxx: CSR access fixes and improvements

2021-03-10 Thread Maciej W. Rozycki
Hi, As a lab upgrade I have recently replaced a dated 32-bit x86 server with a new POWER9 system. One of the purposes of the system has been providing network based resources to clients over my FDDI network. As such the new server has also received a new DEFPA FDDI network adapter. As it t

[PATCH net-next 2/3] FDDI: defxx: Update my e-mail address

2021-03-10 Thread Maciej W. Rozycki
Following the recent update to MAINTAINERS update my e-mail address. Signed-off-by: Maciej W. Rozycki --- drivers/net/fddi/defxx.c |2 +- drivers/net/fddi/defxx.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: linux-defxx/drivers/net/fddi/defxx.c

[PATCH net-next 0/3] FDDI: Update my e-mail address througout

2021-03-10 Thread Maciej W. Rozycki
Hi, Following the recent update to MAINTAINERS update my e-mail addresses embedded througout the FDDI networking pieces. Change split into parts according to individual components. LMO (linux-mips.org) has not been recovered at this point, but in the interim I now have forwarding set up fro

Re: [PATCH v2] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-07 Thread Maciej W. Rozycki
On Mon, 8 Mar 2021, Serge Semin wrote: > > some of them are not R2 (SB1), others are. So best bet would be to > > simply reserve the first 0x1000 bytes for every CPU and special handling > > for the BMIPS case. Does this cover all cases ? > > I can't say for sure whether it will cover all the cas

Re: [PATCH v2] MIPS: kernel: Reserve exception base early to prevent corruption

2021-03-07 Thread Maciej W. Rozycki
On Sun, 7 Mar 2021, Thomas Bogendoerfer wrote: > > Are you sure all of them have "cpu_has_mips_r2_r6" macro returning > > true (false) in order to safely use the lowest region in accordance > > with the conditional statement you've added? > > some of them are not R2 (SB1), others are. For the

Re: [PATCH] MIPS: Add comment about CONFIG_MIPS32_O32 in loongson3_defconfig when build with Clang

2021-03-04 Thread Maciej W. Rozycki
On Fri, 5 Mar 2021, Jiaxun Yang wrote: > > Huh? Is that a joke? From the o32 psABI's point of view a MIPS64 CPU is > > exactly the same as a MIPS32 one (for whatever ISA revision), so there's > > nothing to support there really other than the CPU/ISA name. > > Clang treat MIPS32 as a differen

Re: [PATCH] MIPS: Add comment about CONFIG_MIPS32_O32 in loongson3_defconfig when build with Clang

2021-03-04 Thread Maciej W. Rozycki
On Thu, 4 Mar 2021, Tiezhu Yang wrote: > This is a known bug [2] with Clang, as Simon Atanasyan said, > "There is no plan on support O32 for MIPS64 due to lack of > resources". Huh? Is that a joke? From the o32 psABI's point of view a MIPS64 CPU is exactly the same as a MIPS32 one (for whatev

Re: [PATCH] MIPS: boot/compressed: Copy DTB to aligned address

2021-03-04 Thread Maciej W. Rozycki
On Wed, 3 Mar 2021, Rob Herring wrote: > > Since 5.12-rc1, the Device Tree blob must now be properly aligned. > > I had checked the other built-in cases as microblaze broke too, but > missed some of the many ways MIPS can have a dtb. Appended and > built-in DTBs were supposed to be temporary. :(

Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption

2021-03-03 Thread Maciej W. Rozycki
On Wed, 3 Mar 2021, Thomas Bogendoerfer wrote: > > What's up with the R3k (the usual trigger for me) here? > > I've moved r3k cpu_probe() to it's own file and when moving ebase > reservation to cpu_probe(), I need to add it there as well. So just > a mechanic step, I've missed. Ah, right, I di

Re: [PATCH] MIPS: BMIPS: Reserve exception base to prevent corruption

2021-03-03 Thread Maciej W. Rozycki
On Wed, 3 Mar 2021, Thomas Bogendoerfer wrote: > perfect, I only forgot about R3k... I'll submit a formal patch submission > later today. What's up with the R3k (the usual trigger for me) here? Maciej

[PATCH] crypto: mips/poly1305 - enable for all MIPS processors

2021-03-03 Thread Maciej W. Rozycki
MIPS processors. Signed-off-by: Maciej W. Rozycki Fixes: a11d055e7a64 ("crypto: mips/poly1305 - incorporate OpenSSL/CRYPTOGAMS optimized implementation") Cc: sta...@vger.kernel.org # v5.5+ --- On Wed, 3 Mar 2021, Jason A. Donenfeld wrote: > >> Would you mind sending this for 5.

Re: [PATCH] arch: mips: sibyte: Return -EFAULT if copy_to_user() fails

2021-03-01 Thread Maciej W. Rozycki
On Mon, 1 Mar 2021, Sergei Shtylyov wrote: > > The copy_to_user() function returns the number of bytes remaining to be > > copied, but we want to return -EFAULT if the copy doesn't complete. > >Then 'err' is hardly a good name for that variable. :-) Something like `left' might be better, es

Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code

2021-02-27 Thread Maciej W. Rozycki
On Mon, 22 Feb 2021, Maciej W. Rozycki wrote: > > > I haven't booted Linux on my Malta for a while now, but it turns out to > > > work just fine, and your patch set does not regress it booting multi-user > > > NFS-rooted over FDDI. > > > > > &g

Re: [PATCH] MIPS: select CPU_MIPS64 for remaining MIPS64 CPUs

2021-02-27 Thread Maciej W. Rozycki
On Sat, 27 Feb 2021, Jason A. Donenfeld wrote: > The CPU_MIPS64 and CPU_MIPS32 variables are supposed to be able to > distinguish broadly between 64-bit and 32-bit MIPS CPUs. However, they That is not true. The purpose of these options is to identify MIPS64 and MIPS32 ISA processors respective

Re: [PATCH 5/5] MIPS: SGI-IP27: fix spelling in Copyright

2021-02-23 Thread Maciej W. Rozycki
On Mon, 22 Feb 2021, Lukas Bulwahn wrote: > This is a Copyright line, and just a typo slipped through. > > Signed-off-by: Lukas Bulwahn > --- Reviewed-by: Maciej W. Rozycki Maciej

Re: [PATCH 3/5] arch: mips: update references to current linux-mips list

2021-02-23 Thread Maciej W. Rozycki
On Tue, 23 Feb 2021, Thomas Bogendoerfer wrote: > For the other patches I'll wait for how the resolution for linux-mips.org > looks like. FWIW I think the typo fix in 5/5 is obviously correct and can go in right away. We can deal with the LMO reference later on should it be needed. Maciej

Re: [PATCH 5/5] MIPS: SGI-IP27: fix spelling in Copyright

2021-02-23 Thread Maciej W. Rozycki
On Tue, 23 Feb 2021, Philippe Mathieu-Daudé wrote: > > diff --git a/arch/mips/sgi-ip27/ip27-timer.c > > b/arch/mips/sgi-ip27/ip27-timer.c > > index 79c434fece52..444b5e0e935f 100644 > > --- a/arch/mips/sgi-ip27/ip27-timer.c > > +++ b/arch/mips/sgi-ip27/ip27-timer.c > > @@ -1,7 +1,7 @@ > > // SPD

Re: [PATCH 4/5] arch: mips: remove dead references

2021-02-23 Thread Maciej W. Rozycki
On Tue, 23 Feb 2021, Philippe Mathieu-Daudé wrote: > On Mon, Feb 22, 2021 at 5:22 PM Lukas Bulwahn wrote: > > > > The domain lookup for linux-mips.org fails for quite some time now. > > Further, the two links: > > > > http://decstation.unix-ag.org/ > > https://web.archive.org/web/2007060918580

Re: [PATCH 0/5] Remove dead linux-mips.org references

2021-02-22 Thread Maciej W. Rozycki
On Mon, 22 Feb 2021, Lukas Bulwahn wrote: > The domain lookup for linux-mips.org fails for quite some time now. > Hence, webpages, the patchwork instance and Ralf Baechle's email there is > not reachable anymore. I have been contacted by Ralf a couple of weeks ago and he told me there had been

Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code

2021-02-22 Thread Maciej W. Rozycki
On Mon, 22 Feb 2021, Christoph Hellwig wrote: > > I haven't booted Linux on my Malta for a while now, but it turns out to > > work just fine, and your patch set does not regress it booting multi-user > > NFS-rooted over FDDI. > > > > I note however that the system does not reboot properly: > >

Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code

2021-02-20 Thread Maciej W. Rozycki
On Mon, 15 Feb 2021, Maciej W. Rozycki wrote: > I hope to have the adapter properly fixed soon and I'll look at the Malta > side now, possibly using the old server whose DEFPA has worked flawlessly > for some 20 years now. I have planned to use the interface to supply NFS &

Re: [PATCH 1/6] MIPS/malta: simplify plat_setup_iocoherency

2021-02-20 Thread Maciej W. Rozycki
ns and merge plat_enable_iocoherency into plat_setup_iocoherency > to simplify the code a bit. Tested-by: Maciej W. Rozycki FWIW, Maciej

Re: [PATCH v2] MIPS: Make check condition for SDBBP consistent with EJTAG spec

2021-02-16 Thread Maciej W. Rozycki
On Tue, 9 Feb 2021, Thomas Bogendoerfer wrote: > > > > diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S > > > > index bcce32a..743d759 100644 > > > > --- a/arch/mips/kernel/genex.S > > > > +++ b/arch/mips/kernel/genex.S > > > > @@ -349,8 +349,8 @@ NESTED(ejtag_debug_handler, PT_SIZ

Re: [PATCH v2] MIPS: Add basic support for ptrace single step

2021-02-16 Thread Maciej W. Rozycki
On Fri, 12 Feb 2021, Thomas Bogendoerfer wrote: > > IMHO ptrace single step is for CPUs supporting single stepping and not > > for emulating it in the kernel. > > I've checked other arch how they implement single step, and looks like > I'm wrong. So I'm ok with applying your patch. Can you resend

Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code

2021-02-15 Thread Maciej W. Rozycki
On Tue, 9 Feb 2021, Maciej W. Rozycki wrote: > > > Do you need to have this verified anyhow? I only have a non-coherent > > > 5Kc > > > Malta though. > > > > If you get a chance to test this logic, that would be great. > > I'll try to give

Re: [PATCH] arch: mips: kernel: Made couple of spelling fixes and a sentence construction in smp.c

2021-02-13 Thread Maciej W. Rozycki
On Tue, 2 Feb 2021, Bhaskar Chowdhury wrote: > On 17:51 Mon 01 Feb 2021, Bert Vermeulen wrote: > > On 2/1/21 12:17 PM, Bhaskar Chowdhury wrote: > > > s/debugees/debuge's/ > > > > Definitely not. > > > > > h Obviously "debuggees", e.g.: . Maciej

Re: [PATCH 1/3] MIPS: ftrace: Fix N32 save registers

2021-02-13 Thread Maciej W. Rozycki
On Mon, 1 Feb 2021, Jiaxun Yang wrote: > > Thank you for your reply, and now I know. Before that, I saw the macro > > from arch/mips/include/asm/regdef.h and thought it needed to be modified > > here. But that seems have no sence. > > Please ignore this patch. > > I guess that's for uapi consider

Re: [PATCH] MIPS: Fix inline asm input/output type mismatch in checksum.h used with Clang

2021-02-12 Thread Maciej W. Rozycki
On Wed, 27 Jan 2021, Thomas Bogendoerfer wrote: > > Fix the following build error when make M=samples/bpf used with Clang: > > > > CLANG-bpf samples/bpf/sockex2_kern.o > > In file included from samples/bpf/sockex2_kern.c:7: > > In file included from ./include/uapi/linux/if_tunnel.h:7: > > In f

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-11 Thread Maciej W. Rozycki
On Mon, 1 Feb 2021, Thomas Gleixner wrote: > >> While it cures the problem on the reporters machine it breaks machines > >> with Intel chipsets which use bit 0-5 of the D register. So check only > >> for bit 6 being 0 which is the case on these Intel machines as well. > > > > This looks fine, but

Re: [PATCH 2/2] MIPS: make kgdb depend on FPU support

2021-02-10 Thread Maciej W. Rozycki
On Wed, 10 Feb 2021, Daniel Thompson wrote: > > NB if GDB sees a register padded out (FAOD it means all-x's rather than a > > hex string placed throughout the respective slot) in a `g' packet, then it > > will mark the register internally as "unavailable" and present it to the > > receiver of

Re: [PATCH 2/2] MIPS: make kgdb depend on FPU support

2021-02-10 Thread Maciej W. Rozycki
On Wed, 10 Feb 2021, Daniel Thompson wrote: > > Wrapping the relevant parts of this file into #ifdef MIPS_FP_SUPPORT > > would be as easy though and would qualify as a proper fix given that we > > have no XML description support for the MIPS target (so we need to supply > > the inexistent regi

Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code

2021-02-09 Thread Maciej W. Rozycki
On Mon, 8 Feb 2021, Christoph Hellwig wrote: > > Do you need to have this verified anyhow? I only have a non-coherent 5Kc > > Malta though. > > If you get a chance to test this logic, that would be great. I'll try to give it a hit in the next few days then. Installed in my Malta I have a D

Re: [PATCH] MIPS: vpe: Remove vpe_getcwd

2021-02-08 Thread Maciej W. Rozycki
On Fri, 22 Jan 2021, Thomas Bogendoerfer wrote: > I couldn't find any user of the dubious vpe_getcwd so far. So remove it and > get rid of another set_fs(KERNEL_DS). IIRC it served as the path for the SP-side program to load in the AP/SP model. Or something like that. There may have been an a

Re: [PATCH 2/2] MIPS: make kgdb depend on FPU support

2021-02-08 Thread Maciej W. Rozycki
On Fri, 22 Jan 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > kgdb fails to build when the FPU support is disabled: > > arch/mips/kernel/kgdb.c: In function 'dbg_set_reg': > arch/mips/kernel/kgdb.c:147:35: error: 'struct thread_struct' has no member > named 'fpu' > 147 |memcpy((voi

Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code

2021-02-08 Thread Maciej W. Rozycki
On Mon, 8 Feb 2021, Christoph Hellwig wrote: > diff --git a/arch/mips/mti-malta/malta-setup.c > b/arch/mips/mti-malta/malta-setup.c > index e98cc977a735b2..f8c9663e7faa10 100644 > --- a/arch/mips/mti-malta/malta-setup.c > +++ b/arch/mips/mti-malta/malta-setup.c > @@ -143,7 +143,7 @@ static void _

Re: [PATCH v2 2/4] MIPS: microMIPS: Fix the judgment of mm_jr16_op and mm_jalr_op

2021-02-07 Thread Maciej W. Rozycki
On Thu, 21 Jan 2021, Jinyang He wrote: > mm16_r5_format.rt is 5 bits, so directly judge the value if equal or not. > mm_jalr_op requires 7th to 16th bits. These 10 which bits generated by The minor opcode extension field is comprised of bits 15:6, not 16:7 as your description suggests. Please

[PATCH] MAINTAINERS: Update my e-mail address throughout

2021-01-21 Thread Maciej W. Rozycki
I find linux-mips.org too unreliable to rely on, so move to a place I have proper control over. Signed-off-by: Maciej W. Rozycki --- -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, My address is now . Please apply. Maciej -BEGIN PGP SIGNATURE

Re: [PATCH] MIPS: Support binutils configured with --enable-mips-fix-loongson3-llsc=yes

2021-01-09 Thread Maciej W. Rozycki
On Sat, 9 Jan 2021, Aurelien Jarno wrote: > diff --git a/arch/mips/Makefile b/arch/mips/Makefile > index cd4343edeb11..5ffdd67093bc 100644 > --- a/arch/mips/Makefile > +++ b/arch/mips/Makefile > @@ -136,6 +136,25 @@ cflags-$(CONFIG_SB1XXX_CORELIS) += $(call > cc-option,-mno-sched-prolog) \ > #

  1   2   3   4   5   6   7   8   9   >