Hi,
On Thu, Feb 25, 2021 at 09:09:30AM +0200, Kalle Valo wrote:
> writes:
>
> > On 24/02/21 10:13 pm, Kalle Valo wrote:
> >> EXTERNAL EMAIL: Do not click links or open attachments unless you
> >> know the content is safe
> >>
> >> Marcus Folkes
Write the value instead of reading it twice.
Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function in
wilc_sdio.c file")
Signed-off-by: Marcus Folkesson
---
drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
to the device.
>
> Fixes: 976932e40036 ("watchdog: sama5d4: make use of timeout-secs provided in
> devicetree")
> Signed-off-by: Romain Izard
Reviewed-by: Marcus Folkesson
The `vref` regulator is declared as optional in the device-tree binding,
but the driver does require it.
Go for the device-tree binding and make the `vref` regulator optional.
Signed-off-by: Marcus Folkesson
---
drivers/iio/dac/ti-dac5571.c | 30 ++
1 file changed
Use the created list of of_device_id's as a match table.
Signed-off-by: Marcus Folkesson
---
drivers/iio/dac/ti-dac5571.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/dac/ti-dac5571.c b/drivers/iio/dac/ti-dac5571.c
index e39d1e901353..f6dcd8bce2b0 100644
--- a/drivers/ii
Do not try to write negative values and make sure that the write goes well.
Signed-off-by: Marcus Folkesson
---
drivers/iio/dac/mcp4922.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/dac/mcp4922.c b/drivers/iio/dac/mcp4922.c
index bf9aa3fc0534
On Tue, Aug 21, 2018 at 09:31:25PM +0200, Marcus Folkesson wrote:
> LTC1665/LTC1660 is a 8/10-bit Digital-to-Analog Converter (DAC)
> with eight individual channels.
>
> Signed-off-by: Marcus Folkesson
Rob, sorry I missed your tag.
Reviewed-by: Rob Herring
> ---
>
Add entry for ltc1660 DAC driver and add myself as
maintainer of this driver.
Signed-off-by: Marcus Folkesson
---
Notes:
v2:
- rename enumerated files, ltc166x* -> ltc1660*
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
in
LTC1665/LTC1660 is a 8/10-bit Digital-to-Analog Converter (DAC)
with eight individual channels.
Signed-off-by: Marcus Folkesson
---
Notes:
v2:
- rename file, ltc166x -> ltc1660
.../devicetree/bindings/iio/dac/ltc1660.txt | 21 +
1 file changed,
LTC1665/LTC1660 is a 8/10-bit Digital-to-Analog Converter
(DAC) with eight individual channels.
Signed-off-by: Marcus Folkesson
---
Notes:
v2:
- rename all instances of ltc166x to ltc1660
- read regulator value "in-place" instead of cache voltage
- fix erro
lient *client)
> +{
> + struct iio_dev *indio_dev = i2c_get_clientdata(client);
> +
> + iio_device_unregister(indio_dev);
> +
> + pm_runtime_dont_use_autosuspend(&client->dev);
> + pm_runtime_disable(&client->dev);
> + pm_runtime_set_suspended(&client->dev);
> + pm_runtime_put_noidle(&client->dev);
> +
> + return vcnl4035_set_als_power_state(iio_priv(indio_dev),
> + VCNL4035_MODE_ALS_DISABLE);
> +}
> +
> +#ifdef CONFIG_PM
> +static int __maybe_unused vcnl4035_runtime_suspend(struct device *dev)
> +{
> + struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
> + struct vcnl4035_data *data = iio_priv(indio_dev);
> + int ret;
> +
> + ret = vcnl4035_set_als_power_state(data, VCNL4035_MODE_ALS_DISABLE);
> + regcache_mark_dirty(data->regmap);
> +
> + return ret;
> +}
> +
> +static int __maybe_unused vcnl4035_runtime_resume(struct device *dev)
> +{
> + struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
> + struct vcnl4035_data *data = iio_priv(indio_dev);
> + int ret;
> +
> + regcache_sync(data->regmap);
> + ret = vcnl4035_set_als_power_state(data, VCNL4035_MODE_ALS_ENABLE);
> + if (ret < 0)
> + return ret;
> +
> + /* wait for 1 ALS integration cycle */
> + msleep(data->als_it_val * 100);
> +
> + return 0;
> +}
> +#endif
> +
> +static const struct dev_pm_ops vcnl4035_pm_ops = {
> + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> + pm_runtime_force_resume)
> + SET_RUNTIME_PM_OPS(vcnl4035_runtime_suspend,
> +vcnl4035_runtime_resume, NULL)
> +};
> +
> +static const struct of_device_id vcnl4035_of_match[] = {
> + { .compatible = "vishay,vcnl4035", },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, vcnl4035_of_match);
> +
> +static struct i2c_driver vcnl4035_driver = {
> + .driver = {
> + .name = VCNL4035_DRV_NAME,
> + .pm = &vcnl4035_pm_ops,
> + .of_match_table = of_match_ptr(vcnl4035_of_match),
Please correct me if I'm wrong here.
Use of_match_ptr() and not provide an ACPI match table will not make
this driver work on ACPI systems.
The reason is that the ACPI match function will fall back on
of_match_table if no acpi_match_table is provided, and the
of_match_ptr() macro will simple evaluate to NULL if not CONFIG_OF
is set.
In other words, I think we should change this to just
.of_match_table = &vcnl4035_of_match,
> + },
> + .probe = vcnl4035_probe,
> + .remove = vcnl4035_remove,
> +};
> +
> +module_i2c_driver(vcnl4035_driver);
> +
> +MODULE_AUTHOR("Parthiban Nallathambi ");
> +MODULE_DESCRIPTION("VCNL4035 Ambient Light Sensor driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.14.4
>
Best regards
Marcus Folkesson
signature.asc
Description: PGP signature
On Sun, Aug 19, 2018 at 08:29:43PM +0100, Jonathan Cameron wrote:
> On Sun, 19 Aug 2018 21:17:51 +0200
> Marcus Folkesson wrote:
>
> > On Sun, Aug 19, 2018 at 08:02:57PM +0100, Jonathan Cameron wrote:
> > > On Wed, 8 Aug 2018 10:09:15 +0200
>
On Sun, Aug 19, 2018 at 08:02:57PM +0100, Jonathan Cameron wrote:
> On Wed, 8 Aug 2018 10:09:15 +0200
> Marcus Folkesson wrote:
>
> > MCP3911 is a dual channel Analog Front End (AFE) containing two
> > synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
>
Hi Jonathan,
Thanks for your comments!
On Sun, Aug 19, 2018 at 05:38:50PM +0100, Jonathan Cameron wrote:
> On Sat, 11 Aug 2018 22:02:24 +0200
> Marcus Folkesson wrote:
>
> > LTC1665/LTC1660 is a 8/10-bit Digital-to-Analog Converter
> > (DAC) with eight individual channels
Hi Gutavo,
Sorry for the delay.
On Wed, Aug 15, 2018 at 12:50:10PM -0500, Gustavo A. R. Silva wrote:
> Hi Marcus,
>
> On 8/15/18 12:27 PM, Marcus Folkesson wrote:
> > Hi,
> >
> > On Wed, Aug 15, 2018 at 11:38:52AM -0500, Gustavo A. R. Silva wrote:
> >> I
n_index = Z;
for (i = X ; i < MAX_AXIS; i++) {
if (state->sensor_num == MOTIONSENSE_LOC_LID && i != Y)
state->sign[i] = -1;
else
state->sign[i] = 1;
}
Best regards,
Marcus Folkesson
> --
> 2.7.4
>
signature.asc
Description: PGP signature
LTC1665/LTC1660 is a 8/10-bit Digital-to-Analog Converter
(DAC) with eight individual channels.
Signed-off-by: Marcus Folkesson
---
drivers/iio/dac/Kconfig | 10 ++
drivers/iio/dac/Makefile | 1 +
drivers/iio/dac/ltc166x.c | 244 ++
3 files
LTC1665/LTC1660 is a 8/10-bit Digital-to-Analog Converter (DAC)
with eight individual channels.
Signed-off-by: Marcus Folkesson
---
.../devicetree/bindings/iio/dac/ltc166x.txt | 21 +
1 file changed, 21 insertions(+)
create mode 100644 Documentation/devicetree
Add entry for ltc166x DAC driver and add myself as
maintainer of this driver.
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9276da915d9d..2dc4c773fb2e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
This is already handled by SIMPLE_DEV_PM_OPS().
Signed-off-by: Marcus Folkesson
---
Somehow git-send-email messed up (?!) the format for (at least) gmail, so
resend it.
Mutt still read the mail correct though.
drivers/iio/dac/max517.c | 11 +++
1 file changed, 3 insertions(+), 8
This is already handled by SIMPLE_DEV_PM_OPS().
Signed-off-by: Marcus Folkesson
---
Somehow git-send-email messed up (?!) the format for (at least) gmail, so
resend it.
Mutt still read the mail correct though.
drivers/iio/dac/mcp4725.c | 12 +++-
1 file changed, 3 insertions(+), 9
This is already handled by SIMPLE_DEV_PM_OPS().
Signed-off-by: Marcus Folkesson
---
Somehow git-send-email messed up (?!) the format for (at least) gmail, so
resend it.
Mutt still read the mail correct though.
drivers/iio/dac/max5821.c | 11 +++
1 file changed, 3 insertions(+), 8
amp;iio_const_attr_sampling_frequency_available.dev_attr.attr,
> + NULL,
> +};
> +
> +static const struct attribute_group adxl372_attrs_group = {
> + .attrs = adxl372_attributes,
> +};
> +
> static const struct iio_info adxl372_info = {
> + .attrs = &adxl372_attrs_group,
> .read_raw = adxl372_read_raw,
> + .write_raw = adxl372_write_raw,
> .debugfs_reg_access = &adxl372_reg_access,
> .hwfifo_set_watermark = adxl372_set_watermark,
> };
> --
> 2.7.4
Best regards,
Marcus Folkesson
>
signature.asc
Description: PGP signature
> index 000..db9ecd2
> --- /dev/null
> +++ b/drivers/iio/accel/adxl372.c
> @@ -0,0 +1,525 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * ADXL372 3-Axis Digital Accelerometer SPI driver
> + *
> + * Copyright 2018 Analog Devices Inc.
> + */
Please make the SPDX-identifier and MODULE_LICENCE match here as well.
Either
SPDX-License-Identifier: GPL-2.0+
MODULE_LICENSE("GPL")
or
SPDX-License-Identifier: GPL-2.0
MODULE_LICENSE("GPL v2")
Thanks!
Marcus Folkesson
signature.asc
Description: PGP signature
SIMPLE_DEV_PM_OPS() is already doing this.
Signed-off-by: Marcus Folkesson
---
drivers/iio/dac/max517.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
index 1d853247a205..451d10e323cf 100644
--- a/drivers/iio
SIMPLE_DEV_PM_OPS() is already doing this.
Signed-off-by: Marcus Folkesson
---
drivers/iio/dac/mcp4725.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c
index 8b5aad4c32d9..6d71fd905e29 100644
--- a/drivers
SIMPLE_DEV_PM_OPS() is already doing this.
Signed-off-by: Marcus Folkesson
---
drivers/iio/dac/max5821.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/dac/max5821.c b/drivers/iio/dac/max5821.c
index d0ecc1fdd8fc..f0cf6903dcd2 100644
--- a/drivers
ex 000..db9ecd2
> --- /dev/null
> +++ b/drivers/iio/accel/adxl372.c
> @@ -0,0 +1,525 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
The SPDX identifier "GPL-2.0+" is "GPL v2 or later", and the MODULE_LICENSE
"GPL v2" is "GPL v2 only"
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Co-Developed-by: Kent Gustavsson
Signed-off-by: Kent Gustavsson
Signed-off-by: Marcus Folkesson
---
Notes:
v4:
- remove defined(CONFIG_OF) and
Add an entry for mcp3911 ADC driver and add myself and
Kent Gustavsson as maintainers of this driver.
Co-Developed-by: Kent Gustavsson
Signed-off-by: Kent Gustavsson
Signed-off-by: Marcus Folkesson
---
Notes:
v4:
- add Kent as co-developer
v3:
- no changes
v2
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Co-Developed-by: Kent Gustavsson
Signed-off-by: Kent Gustavsson
Signed-off-by: Marcus Folkesson
Reviewed-by: Rob Herring
---
Notes:
v4:
- remove
Hi Andy and Jonathan,
On Fri, Aug 03, 2018 at 11:09:22PM +0100, Jonathan Cameron wrote:
> On Thu, 2 Aug 2018 22:52:00 +0300
> Andy Shevchenko wrote:
>
> > On Thu, Aug 2, 2018 at 10:15 PM, Marcus Folkesson
> > wrote:
> > > MCP3911 is a dual channel Analog
Add an entry for mcp3911 ADC driver and add myself and
Kent Gustavsson as maintainers of this driver.
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
Notes:
v3:
- no changes
v2:
- no changes
MAINTAINERS | 8
1 file changed, 8 insertions
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
Notes:
v3:
- add bindings for interrupt
- prefix device-addr with
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
Notes:
v3:
- rename adc_clk to clki
- add error handling/cleanup for clock
Hi Jonathan,
Sorry for the delay, I've been away from keyboard for a few days.
On Sun, Jul 29, 2018 at 12:44:22PM +0100, Jonathan Cameron wrote:
> On Tue, 24 Jul 2018 20:30:02 +0200
> Marcus Folkesson wrote:
>
> > MCP3911 is a dual channel Analog Front End (AFE) containing
Hello Rob,
Thank you for the review.
On Wed, Jul 25, 2018 at 11:51:17AM -0600, Rob Herring wrote:
> On Tue, Jul 24, 2018 at 08:30:03PM +0200, Marcus Folkesson wrote:
> > MCP3911 is a dual channel Analog Front End (AFE) containing two
> > synchronous sampling delta-sigma An
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
Notes:
v2:
- cleanups and bugfixes (thanks Peter Meerwald-Stadler)
- drop
Add an entry for mcp3911 ADC driver and add myself and
Kent Gustavsson as maintainers of this driver.
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
Notes:
v2:
- no changes
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
Notes:
v2:
- drop channel width
- drop `external_vref`
- replace
Hello Dmitry,
On Tue, Jul 24, 2018 at 02:38:04AM +, Dmitry Torokhov wrote:
> Hi Marcus,
>
> On Mon, Jul 16, 2018 at 04:40:14PM +0200, Marcus Folkesson wrote:
> > The USB device is only needed during setup, so put it back after
> > initialization and do not store it
Hi Jonathan,
On Sun, Jul 22, 2018 at 09:11:11AM +0100, Jonathan Cameron wrote:
> On Sat, 21 Jul 2018 21:59:22 +0200
> Marcus Folkesson wrote:
>
[snip]
> > +Optional properties:
> > + - device-addr: Device address when multiple MCP3911 chips are present on
> > the
irely sure that the SPI framework can handle multiple
clients on the same CS.
The reason why we created device-addr is that the chip supports that and
may have hardcoded chip address from factory.
The chip address is also part of the protocol so we have to specify it.
> >
> some comments below...
>
> > Signed-off-by: Marcus Folkesson
> > Signed-off-by: Kent Gustavsson
> > ---
> > drivers/iio/adc/Kconfig | 10 ++
> > drivers/iio/adc/Makefile | 1 +
> > drivers/iio/adc/mcp3911.c | 444
> > +
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
.../devicetree/bindings/iio/adc/mcp3911.txt| 33 ++
1 file changed
Add an entry for mcp3911 ADC driver and add myself and
Kent Gustavsson as maintainers of this driver.
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 79bb02ff812f
MCP3911 is a dual channel Analog Front End (AFE) containing two
synchronous sampling delta-sigma Analog-to-Digital Converters (ADC).
Signed-off-by: Marcus Folkesson
Signed-off-by: Kent Gustavsson
---
drivers/iio/adc/Kconfig | 10 ++
drivers/iio/adc/Makefile | 1 +
drivers/iio/adc/mcp3911
refcount on the device is safe.
Reported-by: Alexey Khoroshilov
Signed-off-by: Marcus Folkesson
---
drivers/input/joystick/pxrc.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/input/joystick/pxrc.c b/drivers/input/joystick/pxrc.c
index
On Sat, Jul 14, 2018 at 08:51:09AM +, Dmitry Torokhov wrote:
> On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote:
> > Hi Alexey,
> >
> > Good catch!
> >
> > On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote:
> > > pxrc
river Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov
Reviewed-by: Marcus Folkesson
> ---
> drivers/input/joystick/pxrc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/joystick/pxrc.c b/drivers/input/joystick/px
Add documentation to give a brief description on how to use the
CCID Gadget Device.
This includes a description for all attributes followed by an example on
how to setup the device with ConfigFS.
Reviewed-by: Randy Dunlap
Signed-off-by: Marcus Folkesson
---
Notes:
v4:
- clarify how
Add MAINTAINERS entry for USB CCID Gadget Device
Signed-off-by: Marcus Folkesson
---
Notes:
v4:
- No changes
v3:
- No changes
v2:
- No changes
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Add MAINTAINERS entry for PhoenixRC Flight Controller Adapter
Signed-off-by: Marcus Folkesson
---
Notes:
v2:
Add proper mailing list
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9ce5062dc028..d8b5d9f810e4 100644
--- a
Hi Andrzej,
Thank you for reviewing.
On Mon, May 28, 2018 at 11:12:27AM +0200, Andrzej Pietrasiewicz wrote:
> W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze:
> > Hi Andrzej,
> >
> > On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej Pietrasiewicz wrote:
> >&g
Hi Andrzej,
On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej Pietrasiewicz wrote:
> Mi Marcus,
>
> W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze:
> > Chip Card Interface Device (CCID) protocol is a USB protocol that
> > allows a smartcard device to be connected to
Hi Randy,
On Sun, May 27, 2018 at 04:36:24PM -0700, Randy Dunlap wrote:
> Hi,
>
> I have a few documentation comments below...
>
> On 05/26/2018 02:19 PM, Marcus Folkesson wrote:
> > Add documentation to give a brief description on how to use the
> > CCID Gadget
On Sat, May 26, 2018 at 10:56:52PM +0200, Greg Kroah-Hartman wrote:
> On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote:
> > Signed-off-by: Marcus Folkesson
>
> I can't take patches without any changelog text. And why would you
> submit a patch over 1000
show up as a CCID device to the host and let a
userspace daemon act as the smartcard.
This is useful when the Linux gadget itself should act as a cryptographic
device or forward APDUs to an embedded smartcard device.
Signed-off-by: Marcus Folkesson
---
drivers/usb/gadget/Kconfig | 17
Add documentation to give a brief description on how to use the
CCID Gadget Device.
This includes a description for all attributes followed by an example on
how to setup the device with ConfigFS.
Signed-off-by: Marcus Folkesson
---
Documentation/usb/gadget_ccid.rst | 267
Add MAINTAINERS entry for USB CCID Gadget Device
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 078fd80f664f..e77c3d2bec89 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14541,6 +14541,14 @@ L
Signed-off-by: Marcus Folkesson
---
Documentation/usb/gadget_ccid.rst | 267 ++
1 file changed, 267 insertions(+)
create mode 100644 Documentation/usb/gadget_ccid.rst
diff --git a/Documentation/usb/gadget_ccid.rst
b/Documentation/usb/gadget_ccid.rst
new
Add MAINTAINERS entry for USB CCID Gadget Device
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 078fd80f664f..e77c3d2bec89 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14541,6 +14541,14 @@ L
Signed-off-by: Marcus Folkesson
---
drivers/usb/gadget/Kconfig | 17 +
drivers/usb/gadget/function/Makefile | 1 +
drivers/usb/gadget/function/f_ccid.c | 988 +++
drivers/usb/gadget/function/f_ccid.h | 91
include/uapi/linux/usb/ccid.h
Add MAINTAINERS entry for PhoenixRC Flight Controller Adapter
Signed-off-by: Marcus Folkesson
---
Notes:
v2:
Add proper mailing list
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9ce5062dc028..d8b5d9f810e4 100644
--- a
Add MAINTAINERS entry for PhoenixRC Flight Controller Adapter
Signed-off-by: Marcus Folkesson
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9051a9ca24a2..feb02e9568e6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7,6 +7,12
return ret;
> + }
> +
> + ret = sc27xx_vibra_hw_init(info);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to initialize the vibrator.\n");
> + input_ff_destroy(info->input_dev);
> + input_unregister_device(info->input_dev);
No need to unregister managed input devices.
> + return ret;
> + }
Cheers,
Marcus Folkesson
input_set_capability() and input_set_abs_param() will do it for you.
Signed-off-by: Marcus Folkesson
---
drivers/input/joystick/gamecon.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick
input_set_capability() and input_set_abs_param() will do it for you.
Signed-off-by: Marcus Folkesson
---
drivers/input/joystick/as5011.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/joystick/as5011.c b/drivers/input/joystick/as5011.c
index 005d852a06e9
input_set_capability() and input_set_abs_param() will do it for you.
Signed-off-by: Marcus Folkesson
---
drivers/input/joystick/xpad.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index
On Fri, Mar 16, 2018 at 06:56:27PM -0700, Guenter Roeck wrote:
> On 03/16/2018 06:37 AM, Marcus Folkesson wrote:
> > Hi,
> >
> > Am I supposed to do something more to make this patchset picked up?
> >
>
> Did you check linux-next ?
:-)
Thank you
/Marcus
- Add SPDX identifier
- Remove boiler plate license text
- If MODULE_LICENSE and boiler plate does not match, go for boiler plate
license
Signed-off-by: Marcus Folkesson
Acked-by: Adam Thomson
Acked-by: Baruch Siach
Acked-by: Charles Keepax
Acked-by: Keiji Hayashibara
Acked-by: Johannes
Ping.
Would someone please have a look?
Thanks,
Marcus Folkesson
On Wed, Feb 28, 2018 at 02:37:57PM +0100, Marcus Folkesson wrote:
> Hello,
>
> I have not recieved any feedback on these so I resend them.
>
> I got this deadlock on my own driver (pxrc) when using the same
ping.
I do not want to nag, but would someone please have a look at this?
Thanks,
Marcus Folkesson
On Sun, Feb 18, 2018 at 05:17:46PM +0100, Marcus Folkesson wrote:
> This driver let you plug in your RC controller to the adapter and
> use it as input device in various RC simulators.
>
Hi,
Am I supposed to do something more to make this patchset picked up?
Thanks,
Marcus Folkesson
On Sun, Feb 11, 2018 at 09:08:41PM +0100, Marcus Folkesson wrote:
> watchdog_init_timeout() will allways pick timeout_param since it
> defaults to a valid timeout.
>
> Following b
7xx
> +timer (usually 2500).
Optional properties:
- timeout-sec : Contains the watchdog timeout in seconds
watchdog_init_timeout() will fix this for you.
> +
> +Example:
> +
> +timer@f00080c1 {
> +compatible = "nuvoton,npcm750-wdt";
> +
(ret)
> + return ret;
> +
> + ret = devm_watchdog_register_device(dev, &wdt->wdd);
> + if (ret) {
> + dev_err(dev, "failed to register watchdog\n");
> + return ret;
> + }
> +
> + platform_set_drvdata(pdev, wdt);
Do we need to set drvdata? I don't see that we are using it?
> + dev_info(dev, "NPCM watchdog driver enabled\n");
> +
> + return 0;
> +}
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id npcm_wdt_match[] = {
> + {.compatible = "nuvoton,npcm750-wdt"},
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, npcm_wdt_match);
> +#endif
> +
> +static struct platform_driver npcm_wdt_driver = {
> + .probe = npcm_wdt_probe,
> + .driver = {
> + .name = "npcm-wdt",
> + .of_match_table = of_match_ptr(npcm_wdt_match),
> + },
> +};
> +module_platform_driver(npcm_wdt_driver);
> +
> +MODULE_AUTHOR("Joel Stanley");
> +MODULE_DESCRIPTION("Watchdog driver for NPCM");
> +MODULE_LICENSE("GPL");
^^
Either "GPL v2" here or change SPDX identifier.
> --
> 2.15.1
Overall I think it looks good.
Thanks,
Marcus Folkesson
signature.asc
Description: PGP signature
- Add SPDX identifier
- Remove boiler plate license text
- If MODULE_LICENSE and boiler plate does not match, go for boiler plate
license
Cc: Philippe Ombredanne
Signed-off-by: Marcus Folkesson
Acked-by: Adam Thomson
Acked-by: Baruch Siach
Acked-by: Charles Keepax
Acked-by: Florian
GPL v2 is the original license according to the old license text.
See f64cdd0e94f1faf3b7f2b03af71f70dc6d8da0c2.
Signed-off-by: Marcus Folkesson
---
drivers/usb/usb-skeleton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb
t;
> >
> > > +// SPDX-License-Identifier: GPL-2.0
> >
> > > +MODULE_LICENSE("GPL");
> >
> > Not the same.
>
> Hmmm... I copied from usb-skeleton.c, IIRC...
> I'll change to GPL-2.0+, that would be correct, I think.
Yep, the usb-skeleton.c is wrong.
I have prepared a patch, just not submitted it yet..
GPL-2.0+ is "GPLv2 or later" if that is what you want.
Best regards
Marcus Folkesson
;users || (synusb->flags & SYNUSB_IO_ALWAYS)) &&
usb_submit_urb(synusb->urb, GFP_NOIO) < 0) {
retval = -EIO;
}
The same URB will then be fail when resubmitted in synusb_open().
Introduce synusb->is_open to keep track of the state instead.
S
in open()).
I will create a separate "pm_mutex" to use instead of input_dev->mutex
to get rid of the lockups in those drivers
---8<--
[1] https://lkml.org/lkml/2018/1/20/191
Thanks,
Best regards
Marcus Folkesson
>users && usb_submit_urb(pegasus->irq, GFP_NOIO) < 0)
retval = -EIO;
The same URB will then be fail when resubmitted in pegasus_open().
Introduce pegasus->is_open to keep track of the state instead.
Signed-off-by: Marcus Folkesson
---
drivers/input/tabl
usb_autopm_get_interface() that is called in pegasus_open() does an
autoresume if the device is suspended.
input_dev->mutex used in pegasus_resume() is in this case already
taken by the input subsystem and will cause a deadlock.
Signed-off-by: Marcus Folkesson
---
drivers/input/tab
usb_autopm_get_interface() that is called in usbtouch_open() does an
autoresume if the device is suspended.
input_dev->mutex used in usbtouch_resume() is in this case already
taken by the input subsystem and will cause a deadlock.
Signed-off-by: Marcus Folkesson
---
drivers/input/touchscr
;users || usbtouch->type->irq_always)
result = usb_submit_urb(usbtouch->irq, GFP_NOIO);
The same URB will then be fail when resubmitted in usbtouch_open().
Introduce usbtouch->is_open to keep track of the state instead.
Signed-off-by: Marcus Folkesson
---
drivers
usb_autopm_get_interface() that is called in synusb_open() does an
autoresume if the device is suspended.
input_dev->mutex used in synusb_resume() is in this case already
taken by the input subsystem and will cause a deadlock.
Signed-off-by: Marcus Folkesson
---
drivers/input/mo
This driver let you plug in your RC controller to the adapter and
use it as input device in various RC simulators.
Signed-off-by: Marcus Folkesson
---
v5:
- Drop autosuspend support
- Use pm_mutex instead of input_dev->mutex
- Use pxrc->is_open instead of inp
in vim let you jump between matching ifdef/endif as well.
>
> There is a similar sequence for emacs.
>
> >
> > Deferring to Wim.
> >
> > Guenter
> >
>
> --
>
> -
> Jerry Hoemann Software Engineer Hewlett Packard Enterprise
> -
Thanks,
Marcus Folkesson
signature.asc
Description: PGP signature
ev = {
> .min_timeout= 1,
> .max_timeout= HPWDT_MAX_TIMER,
> .timeout= DEFAULT_MARGIN,
> +#ifdef CONFIG_HPWDT_NMI_DECODING /* { */
> + .pretimeout = PRETIMEOUT_SEC,
> +#endif /* } */
WDT_VERSION, hpwdt_dev.timeout, nowayout);
> +
> return 0;
>
> -error_misc_register:
> +error_wd_register:
> hpwdt_exit_nmi_decoding();
> error_init_nmi_decoding:
> pci_iounmap(dev, pci_mem_addr);
> @@ -417,9 +273,9 @@ static int hpwdt_probe(struct pci_dev *dev, const struct
> pci_device_id *ent)
> static void hpwdt_exit(struct pci_dev *dev)
> {
> if (!nowayout)
> - hpwdt_stop();
> + hpwdt_stop(&hpwdt_dev);
>
> - misc_deregister(&hpwdt_miscdev);
> + watchdog_unregister_device(&hpwdt_dev);
> hpwdt_exit_nmi_decoding();
> pci_iounmap(dev, pci_mem_addr);
> pci_disable_device(dev);
> @@ -432,6 +288,25 @@ static struct pci_driver hpwdt_driver = {
> .remove = hpwdt_exit,
> };
>
> +
> +static const struct watchdog_ops hpwdt_ops = {
> + .owner = THIS_MODULE,
> + .start = hpwdt_start,
> + .stop = hpwdt_stop,
> + .ping = hpwdt_ping,
> + .set_timeout= hpwdt_settimeout,
> + .get_timeleft = hpwdt_gettimeleft,
> +};
> +
> +static struct watchdog_device hpwdt_dev = {
> + .info = &hpwdt_info,
> + .ops= &hpwdt_ops,
> + .min_timeout= 1,
> + .max_timeout= HPWDT_MAX_TIMER,
> + .timeout= DEFAULT_MARGIN,
> +};
> +
> +
> MODULE_AUTHOR("Jerry Hoemann");
> MODULE_DESCRIPTION("hpe watchdog driver");
> MODULE_LICENSE("GPL");
> --
> 2.13.6
>
Best regards
Marcus Folkesson
signature.asc
Description: PGP signature
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
By following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt, it also
let us to set timout-sec property in devicetree.
Signed-off-by: Marcus Folkesson
Reviewed-by: Guenter
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
By following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt, it also
let us to set timout-sec property in devicetree.
Signed-off-by: Marcus Folkesson
Reviewed-by: Guenter
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
By following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt, it also
let us to set timout-sec property in devicetree.
Signed-off-by: Marcus Folkesson
Reviewed-by: Guenter
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
By following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt, it also
let us to set timout-sec property in devicetree.
Signed-off-by: Marcus Folkesson
Reviewed-by: Guenter
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.
Signed-off-by: Marcus Folkesson
---
Notes:
v3:
- Use wdd->time
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.
Signed-off-by: Marcus Folkesson
---
Notes:
v3:
- Reformat and use
watchdog_init_timeout() will allways pick timeout_param since it
defaults to a valid timeout.
Following best practice described in
Documentation/watchdog/watchdog-kernel-api.txt to make use of
the parameter logic.
Signed-off-by: Marcus Folkesson
Reviewed-by: Guenter Roeck
---
drivers/watchdog
watchdog_init_timeout() will preserve wdd->timeout value if no parameter
nor timeout-secs dt property is set.
Signed-off-by: Marcus Folkesson
---
drivers/watchdog/uniphier_wdt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/uniphier_wdt.c b/driv
Signed-off-by: Marcus Folkesson
---
drivers/watchdog/lpc18xx_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/lpc18xx_wdt.c b/drivers/watchdog/lpc18xx_wdt.c
index b4221f43cd94..331cadb459ac 100644
--- a/drivers/watchdog/lpc18xx_wdt.c
+++ b/drivers
watchdog_init_timeout() will preserve wdd->timeout value if
no parameter nor timeout-secs dt property is set.
Signed-off-by: Marcus Folkesson
---
drivers/watchdog/gpio_wdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watch
1 - 100 of 183 matches
Mail list logo
