.
>
> Note: using SK_RST_REASON_NOT_SPECIFIED is the same as
> SK_RST_REASON_MPTCP_RST_EUNSPEC. They are both unknown. So we can convert
> it directly.
It looks good to me, thanks:
Reviewed-by: Matthieu Baerts (NGI0)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
is also added in the next commit, and probably
already included via include/net/request_sock.h. So I guess that's fine.)
Other than that, it looks good to me:
Reviewed-by: Matthieu Baerts (NGI0)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
t/mptcp/subflow.c | 5 +++--
For the modifications in MPTCP:
Acked-by: Matthieu Baerts (NGI0)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
Hi Jason,
On 23/04/2024 09:21, Jason Xing wrote:
> From: Jason Xing
>
> Adjust the parameter and support passing reason of reset which
> is for now NOT_SPECIFIED. No functional changes.
(...)
> net/mptcp/subflow.c| 8 +---
For the modifications in MPTCP:
Ack
od to me regarding the modifications
linked to MPTCP.
Acked-by: Matthieu Baerts (NGI0)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
On 22/04/2024 11:17, Jason Xing wrote:> On Mon, Apr 22, 2024 at 4:47 PM
Matthieu Baerts wrote:
>> On 22/04/2024 05:01, Jason Xing wrote:
>>> From: Jason Xing
(...)
>>> diff --git a/include/net/rstreason.h b/include/net/rstreason.h
>>> new file mode 100644
Hi Jason,
On 22/04/2024 05:01, Jason Xing wrote:
> From: Jason Xing
>
> Add a new standalone file for the easy future extension to support
> both active reset and passive reset in the TCP/DCCP/MPTCP protocols.
Thank you for looking at that!
(...)
> diff --git a/include/net/rstreason.h
Hi David, Nico,
On 17/04/2021 06:24, David Gow wrote:
Hi Matt,
Like patch 1/6, I can apply it in MPTCP tree and send it later to
net-next with other patches.
Except if you guys prefer to apply it in KUnit tree and send it to
linux-next?
Given 1/6 is going to net-next, it makes sense to send
Hi David,
Thank you for your very clear reply!
On 15/04/2021 08:01, David Gow wrote:
On Wed, Apr 14, 2021 at 5:25 PM Matthieu Baerts
wrote:
Up to the KUnit maintainers to decide ;-)
To summarise my view: personally, I'd prefer things the way this patch
works: have everything end
Hi Nico,
On 14/04/2021 10:58, Nico Pache wrote:
Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the
KUNIT *_KUNIT_TEST config name format.
For MPTCP, we have multiple KUnit tests: crypto and token. That's why we
wrote TESTS with a S.
I'm fine without S if we need to
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 7d95f22798ecea513f37b792b39fec4bcf20fec3
Gitweb:
https://git.kernel.org/tip/7d95f22798ecea513f37b792b39fec4bcf20fec3
Author:Matthieu Baerts
AuthorDate:Fri, 26 Mar 2021 11:50:23 +01:00
() patching
condition")
Signed-off-by: Matthieu Baerts
---
Notes:
Feel free to modify this patch directly if you prefer. I can of course
send a new version if needed.
kernel/static_call.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/static
Hi Chuck,
(+ cc: MPTCP list)
On 01/03/2021 15:52, Chuck Lever wrote:
On Mar 1, 2021, at 8:49 AM, syzbot
wrote:
(...)
syzbot found the following issue on:
(...)
Hi, thanks for the report.
Initial analysis:
c8e88e3aa738 ("NFSD: Replace READ* macros in nfsd4_decode_layoutget()"
Hi Naresh,
On 19/11/2020 08:04, Naresh Kamboju wrote:
While running kselftest net/mptcp: mptcp_join.sh on x86_64 device running
linux next 20201118 tag the following warning was noticed.
Thank you for testing MPTCP and having reported this bug!
It looks like it is similar to what syzbot
Hi Randy,
On 16/11/2020 04:17, Randy Dunlap wrote:
The previous Kconfig patch led to some other build errors as
reported by the 0day bot and my own overnight build testing.
These are all in when KCOV is enabled but
SKB_EXTENSIONS is not enabled, so fix those by combining those conditions
in
Hi Randy,
On 14/11/2020 02:11, Randy Dunlap wrote:
The previous Kconfig patch led to some other build errors as
reported by the 0day bot and my own overnight build testing.
Thank you for looking at that!
I had the same issue and I was going to propose a similar fix with one
small
Hi Jakub,
09 Nov 2020 21:57:05 Jakub Kicinski :
> On Mon, 9 Nov 2020 17:28:54 +0100 Matthieu Baerts wrote:
>> A small detail (I think): the Signed-off-by of the sender (Geliang)
>> should be the last one in the list if I am not mistaken.
>> But I guess this is not blo
Hi Geliang,
On 09/11/2020 14:59, Geliang Tang wrote:
This patch added NULL pointer check for mptcp_pm_alloc_anno_list, and
avoided similar static checker warnings in mptcp_pm_add_timer.
Signed-off-by: Geliang Tang
Reviewed-by: Dan Carpenter
I think Dan reviewed the v1 of your patch --
detail (I think): the Signed-off-by of the sender (Geliang)
should be the last one in the list if I am not mistaken.
But I guess this is not blocking.
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Philip,
On 28/10/2020 00:00, Philip Li wrote:
On Tue, Oct 27, 2020 at 04:07:28PM +0100, Matthieu Baerts wrote:
FYI, this was already reported earlier:
https://github.com/multipath-tcp/mptcp_net-next/issues/102
Thanks for the info, we didn't notice this. We will take a look
of reported
Hi all,
On 27/10/2020 14:16, kernel test robot wrote:
Greeting,
FYI, we noticed the following commit (built with gcc-9):
commit: f2ff7f11f9a74842245db52d685bf9bc7ac2c4b1 ("selftests: mptcp: add ADD_ADDR
IPv6 test cases")
https://github.com/multipath-tcp/mptcp_net-next.git export
Thanks for
Hi Greg,
On 27/10/2020 14:53, Greg Kroah-Hartman wrote:
From: Matthieu Baerts
[ Upstream commit 287d35405989cfe0090e3059f7788dc531879a8d ]
Recently, CONFIG_MPTCP_IPV6 no longer selects CONFIG_IPV6. As a
consequence, if CONFIG_MPTCP_IPV6=y is added to the kconfig, it will no
longer ensure
it")
Signed-off-by: Matthieu Baerts
---
tools/testing/selftests/net/mptcp/config | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/mptcp/config
b/tools/testing/selftests/net/mptcp/config
index 8df5cb8f71ff..741a1c4f4ae8 100644
--- a/tools/testing/selftests/ne
Hi Geert,
On 21/10/2020 11:52, Geert Uytterhoeven wrote:
Hi Matthieu,
On Wed, Oct 21, 2020 at 11:47 AM Matthieu Baerts
wrote:
On 21/10/2020 11:43, Geert Uytterhoeven wrote:
On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote:
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote
But selecting IPV6 like we did
before was forcing it to be built-in while it was maybe not what the
user wants.
Reported-by: Geert Uytterhoeven
Fixes: 010b430d5df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of
selecting it")
Signed-off-by: Matthieu Baerts
---
Notes:
For more det
Hi Geert,
On 21/10/2020 11:43, Geert Uytterhoeven wrote:
Hi Jakub,
On Wed, Oct 21, 2020 at 5:56 AM Jakub Kicinski wrote:
On Tue, 20 Oct 2020 11:26:34 +0200 Matthieu Baerts wrote:
On 20/10/2020 09:38, Geert Uytterhoeven wrote:
MPTCP_IPV6 selects IPV6, thus enabling an optional feature
Hi Jakub,
On 19/10/2020 22:40, Jakub Kicinski wrote:
On Mon, 19 Oct 2020 18:27:55 +0200 Matthieu Baerts wrote:
Hi Geliang,
On 19/10/2020 12:23, Geliang Tang wrote:
This patchset deals with initializations of mptcp_options_received's two
fields, ahmac and port.
Geliang Tang (2):
mptcp
Hi Geert,
On 20/10/2020 09:40, Geert Uytterhoeven wrote:
On Mon, Oct 19, 2020 at 10:38 PM Geert Uytterhoeven
wrote:
On Mon, Oct 19, 2020 at 5:47 PM Matthieu Baerts
wrote:
On 19/10/2020 13:32, Geert Uytterhoeven wrote:
MPTCP_KUNIT_TESTS selects MPTCP, thus enabling an optional feature
-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
is my:
Reviewed-by: Matthieu Baerts
Also, if you don't mind and while I am here, I never know: is it OK for
you the maintainers to send one Acked/Reviewed-by for a whole series --
but then this is not reflected on patchwork -- or should we send one tag
for each patch?
Cheers,
Matt
to have an easy way to
enable all KUnit tests. We imitated what was and is still done in
fs/ext4/Kconfig.
But it probably makes sense to depend on MPTCP instead of selecting it.
So that's fine for me. But then please also send a patch to ext4
maintainer to do the same there.
Reviewed-by: Matthieu
Hi Rafael,
On 16/10/2020 19:15, Rafael J. Wysocki wrote:
On Friday, October 16, 2020 4:30:55 PM CEST Matthieu Baerts wrote:
By chance, do you already have a fix for that?
Can you please try the appended patch?
Thank you for the patch, this fixes the compilation warning I got.
Reported
Hi Rafael,
On 04/09/2020 19:24, Rafael J. Wysocki wrote:
From: "Rafael J. Wysocki"
The logical address of every GPE block in system memory must be
known before passing it to acpi_ev_initialize_gpe_block(), because
memory cannot be mapped on the fly from an interrupt handler.
Accordingly, the
netns".
The commit 8b974778f998 ("selftests: mptcp: interpret \n as a new line")
is very similar to this one. But the modification in simult_flows.sh was
missed because this commit above was done in parallel to one here below.
Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests&
(and read): the remaining bytes contained garbage.
Fixes: 6a6c05a8b016 ("mptcp: send out ADD_ADDR with echo flag")
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/95
Reported-and-tested-by: Davide Caratti
Acked-by: Geliang Tang
Signed-off-by: Matthieu Baerts
---
Hi David, Jakub,
On 21/09/2020 16:57, Matthieu Baerts wrote:
From: Mat Martineau
When receiving a DATA_FIN MPTCP option on a TCP FIN packet, the DATA_FIN
information would be stored but the MPTCP worker did not get
scheduled. In turn, the MPTCP socket state would remain in
TCP_ESTABLISHED
://github.com/multipath-tcp/mptcp_net-next/issues/84
Fixes: 43b54c6ee382 ("mptcp: Use full MPTCP-level disconnect state machine")
Acked-by: Paolo Abeni
Signed-off-by: Mat Martineau
Signed-off-by: Matthieu Baerts
---
Notes:
This is a resend of v1 and v2 with the same code modification. The
8fbf241064 ("selftests: add test-cases for MPTCP MP_JOIN")
Fixes: 048d19d444be ("mptcp: add basic kselftest for mptcp")
Signed-off-by: Matthieu Baerts
---
Notes:
This commit improves the output in selftests in case of errors, mostly
seen when modifying MPTCP
Hi Colin,
On 15/09/2020 10:44, Colin King wrote:
From: Colin Ian King
There is a spelling mistake a pr_debug message. Fix it.
Thank you for the patch!
Reviewed-by: Matthieu Baerts
Now I don't know if it can be accepted if it was not sent to netdev ML.
You might have to re-submit
tlink-based PM")
Fixes: ec3edaa7ca6ce ("mptcp: Add handling of outgoing MP_JOIN requests")
Fixes: f296234c98a8f ("mptcp: Add handling of incoming MP_JOIN requests")
Signed-off-by: Geliang Tang
Thank you for the v2!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tess
this
address.
Fixes: 01cacb00b35cb ("mptcp: add netlink-based PM")
Signed-off-by: Geliang Tang
Thank you for the v2!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Geliang,
On 07/09/2020 12:29, Geliang Tang wrote:
This patch set the init remote_id to zero, otherwise it will be a random
number.
Then it added the missing subflow's remote_id setting code both in
__mptcp_subflow_connect and in subflow_ulp_clone.
Thank you for this other patch!
Here as
Hi Geliang,
On 07/09/2020 12:29, Geliang Tang wrote:
In mptcp_pm_nl_get_local_id, skc_local is the same as msk_local, so it
always return 0. Thus every subflow's local_id is 0. It's incorrect.
This patch fixed this issue.
Also, we need to ignore the zero address here, like 0.0.0.0 in IPv4.
Hi Tim,
Thank you for having sent the patch!
On 06/08/2020 08:41, Tim Froidcoeur wrote:
Refactor the fastreuse update code in inet_csk_get_port into a small
helper function that can be called from other places.
(...)
diff --git a/net/ipv4/inet_connection_sock.c
other host didn't announce another one. This also
fixes inet_diag showing blank info about MPTCP sockets from unblocking
sockets doing a connect().
Fixes: 41be81a8d3d0 ("mptcp: fix unblocking connect()")
Signed-off-by: Matthieu Baerts
---
net/mptcp/protocol.c | 2 +-
1 file changed, 1 inse
-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Schmidt [ieee802154]
---
net/mptcp/protocol.c | 12 +++
Thank you for the v2!
For MPTCP-related code:
Acked-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Christoph,
On 20/07/2020 14:47, Christoph Hellwig wrote:
Rework the remaining setsockopt code to pass a sockptr_t instead of a
plain user pointer. This removes the last remaining set_fs(KERNEL_DS)
outside of architecture specific code.
Signed-off-by: Christoph Hellwig
---
...
diff
wig
---
include/linux/net.h | 6 --
include/net/sock.h | 4
net/core/sock.c | 30 ++
net/mptcp/protocol.c | 6 --
Thank you for looking at that!
For MPTCP-related code:
Acked-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belg
-X4O6gS-ns3-ns4-MPTCP-MPTCP-10.0.3.1-10030-listener.pcap
It was a connection from ns3 to ns4, better to start with ns3 then. The
port is also added, easier to find the trace we want.
Co-developed-by: Christoph Paasch
Signed-off-by: Christoph Paasch
Signed-off-by: Matthieu Baerts
---
tools
to v1
spec")
Signed-off-by: Geliang Tang
Thank you for this v2. It looks good to me!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Geliang,
On 18/06/2020 08:27, Geliang Tang wrote:
On Tue, Jun 16, 2020 at 05:18:56PM +0200, Matthieu Baerts wrote:
On 16/06/2020 08:47, Geliang Tang wrote:
>>
I would suggest you to discuss about that on MPTCP mailing list. We also
have meetings every Thursday. New devs are always w
Hi Geliang
On 16/06/2020 08:47, Geliang Tang wrote:
Add handling for sending and receiving the MP_PRIO, MP_FAIL, and
MP_FASTCLOSE suboptions.
Thank you for the patches!
Unfortunately, I don't think it would be wise to accept them now: for
the moment, these suboptions are ignored at the
ot;mptcp: unify MPTCP_PM_MAX_ADDR and MPTCP_PM_ADDR_MAX"
Thank you for this v2, it looks good to me!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
Hi Geliang,
On 12/06/2020 07:27, Geliang Tang wrote:
Unify these two duplicate macros into 8.
Thank you for this new patch!
(...)
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index 809687d3f410..86d265500cf6 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -135,7
eliang Tang
---
Changes in v2:
- Add "-net" subject and "Fixes" tag as Matt suggested.
Thanks for this v2! LGTM!
Reviewed-by: Matthieu Baerts
Cheers,
Matt
--
Matthieu Baerts | R Engineer
matthieu.bae...@tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
incremented.
Because this is a bug-fix for net, may you clearly indicate that in the
subject to help -net maintainers please? [PATCH net v2]
Also, may you add a "Fixes" tag as well as it is for -net ? I guess it
should be:
Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling")
is to remove #ifdef CONFIG_NETDEVICES from net/core/filter.c
and rely on sock_bindtoindex() returning ENOPROTOOPT in the extreme
case of oddly configured kernels.
Fixes: 70c58997c1e8 ("bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt")
Suggested-by: Alexei Starovoitov
Signed-off-by: Matth
Hi Alexei,
On 03/06/2020 20:14, Alexei Starovoitov wrote:
On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote:
Hi Ferenc,
On 03/06/2020 10:56, Ferenc Fejes wrote:
Matthieu Baerts ezt írta (időpont:
2020. jún. 3., Sze, 10:11):
A recent commit added new variables only used
Hi Ferenc,
On 03/06/2020 10:56, Ferenc Fejes wrote:
Matthieu Baerts ezt írta (időpont:
2020. jún. 3., Sze, 10:11):
A recent commit added new variables only used if CONFIG_NETDEVICES is
set.
Thank you for noticing and fixed this!
A simple fix is to only declare these variables if the same
these variables in the related "case" section.
Fixes: 70c58997c1e8 ("bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt")
Signed-off-by: Matthieu Baerts
---
Notes:
This fix currently applies on net-next and bpf-next only. Except that
net-next is now closed and -net w
"$err" is a variable pointing to a temp file. "$out" is not: only used
as a local variable in "check()" and representing the output of a
command line.
Fixes: eedbc685321b (selftests: add PM netlink functional tests)
Signed-off-by: Matthieu Baerts
---
too
ood to me, thank you for this!
Reviewed-by: Matthieu Baerts
--
Matthieu Baerts | R Engineer
matthieu.bae...@tessares.net
Tessares SA | Hybrid Access Solutions
www.tessares.net
1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
case a
subsubdir has the same name as another one in another subdirectory.
Fixes: 852c8cbf34d3 (selftests/kselftest/runner.sh: Add 45 second timeout per
test)
Signed-off-by: Matthieu Baerts
---
tools/testing/selftests/kselftest/runner.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
1406),
just before the BUG_ON() somehow suggests to add a check before using
it, what Tim did.
In master, this code path causing the issue will not be taken because
the implementation of tcp_rtx_queue_tail() is different:
tcp_fragment() → tcp_rtx_queue_tail() → tcp_write_queue_prev() →
skb_queue_pre
ot;)
> Signed-off-by: Eric Dumazet
> Reported-by: Andrew Prout
> Tested-by: Andrew Prout
> Tested-by: Jonathan Lemon
> Tested-by: Michal Kubecek
> Acked-by: Neal Cardwell
> Acked-by: Yuchung Cheng
> Acked-by: Christoph Paasch
> Cc: Jonathan Looney
> S
66 matches
Mail list logo
