is going on somewhere
or if the bug has fallen in a black hole.
(In the original mail, I've proposed a patch as a quick fix, but I don't know if
it can be considered as a definitive correction or not)
Thanks,
P.
Andrew Morton wrote:
> On Mon, 4 Feb 2008 16:29:21 +0100
> Pierre Peiffer &
is going on somewhere
or if the bug has fallen in a black hole.
(In the original mail, I've proposed a patch as a quick fix, but I don't know if
it can be considered as a definitive correction or not)
Thanks,
P.
Andrew Morton wrote:
On Mon, 4 Feb 2008 16:29:21 +0100
Pierre Peiffer [EMAIL PROTECTED
Andi Kleen wrote:
> [EMAIL PROTECTED] writes:
>
>> This is a resend of the first part of the patchset sent 2 weeks
>> ago. This is the part about the IPC which (again) proposes to consolidate
>> some part of the existing code.
>>
>> It does not change the behavior of the existing
Andi Kleen wrote:
[EMAIL PROTECTED] writes:
This is a resend of the first part of the patchset sent 2 weeks
ago. This is the part about the IPC which (again) proposes to consolidate
some part of the existing code.
It does not change the behavior of the existing code, but
On Feb 13, 2008 9:07 PM, Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> On Tue, Feb 12, 2008 at 05:13:41PM +0100, [EMAIL PROTECTED] wrote:
> > Trivial patch which adds some small locking functions and makes use of them
> > to factorize some part of the code and to make it cleaner.
>
> What's wrong
these same pieces of code
into one common function called ipcctl_pre_down().
It simplifies a little these xxxctl_down() functions and increases a little
the maintainability.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
Acked-by: Serge Hallyn <[EMAIL PROTECTED]>
---
ipc/m
From: Pierre Peiffer <[EMAIL PROTECTED]>
The IPC_SET command performs the same permission setting for all IPCs.
This patch introduces a common ipc_update_perm() function to update these
permissions and makes use of it for all IPCs.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTE
From: Pierre Peiffer <[EMAIL PROTECTED]>
All IPCs make use of an intermetiate *_setbuf structure to handle the
IPC_SET command. This is not really needed and, moreover, it complicates
a little bit the code.
This patch get rid of the use of it and uses directly the semid64_ds/
msgi
From: Pierre Peiffer <[EMAIL PROTECTED]>
semctl_down() takes one unused parameter: semnum.
This patch proposes to get rid of it.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
Acked-by: Serge Hallyn <[EMAIL PROTECTED]>
---
ipc/sem.c |6 +++---
1 file changed, 3 insertio
From: Pierre Peiffer <[EMAIL PROTECTED]>
Currently, sys_msgctl is not easy to read.
This patch tries to improve that by introducing the msgctl_down function
to handle all commands requiring the rwmutex to be taken in write mode
(ie IPC_SET and IPC_RMID for now). It is the equivalent fu
From: Pierre Peiffer <[EMAIL PROTECTED]>
semctl_down is called with the rwmutex (the one which protects the
list of ipcs) taken in write mode.
This patch moves this rwmutex taken in write-mode inside semctl_down.
This has the advantages of reducing a little bit the window during
From: Pierre Peiffer <[EMAIL PROTECTED]>
Currently, the way the different commands are handled in sys_shmctl
introduces some duplicated code.
This patch introduces the shmctl_down function to handle all the commands
requiring the rwmutex to be taken in write mode (ie IPC_SET and IPC_RMID
f
From: Pierre Peiffer <[EMAIL PROTECTED]>
Trivial patch which adds some small locking functions and makes use of them
to factorize some part of the code and to make it cleaner.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
Acked-by: Serge Hallyn <[EMAIL PROTECTED]>
---
ux
textdata bss dec hex filename
1902917 175820 122880 2201617 219811 obj/vmlinux
--
Pierre Peiffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
these same pieces of code
into one common function called ipcctl_pre_down().
It simplifies a little these xxxctl_down() functions and increases a little
the maintainability.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge Hallyn [EMAIL PROTECTED]
---
ipc/msg.c | 48
From: Pierre Peiffer [EMAIL PROTECTED]
All IPCs make use of an intermetiate *_setbuf structure to handle the
IPC_SET command. This is not really needed and, moreover, it complicates
a little bit the code.
This patch get rid of the use of it and uses directly the semid64_ds/
msgid64_ds/shmid64_ds
From: Pierre Peiffer [EMAIL PROTECTED]
Currently, sys_msgctl is not easy to read.
This patch tries to improve that by introducing the msgctl_down function
to handle all commands requiring the rwmutex to be taken in write mode
(ie IPC_SET and IPC_RMID for now). It is the equivalent function
From: Pierre Peiffer [EMAIL PROTECTED]
Currently, the way the different commands are handled in sys_shmctl
introduces some duplicated code.
This patch introduces the shmctl_down function to handle all the commands
requiring the rwmutex to be taken in write mode (ie IPC_SET and IPC_RMID
for now
From: Pierre Peiffer [EMAIL PROTECTED]
The IPC_SET command performs the same permission setting for all IPCs.
This patch introduces a common ipc_update_perm() function to update these
permissions and makes use of it for all IPCs.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge
From: Pierre Peiffer [EMAIL PROTECTED]
semctl_down() takes one unused parameter: semnum.
This patch proposes to get rid of it.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge Hallyn [EMAIL PROTECTED]
---
ipc/sem.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions
bss dec hex filename
1902917 175820 122880 2201617 219811 obj/vmlinux
--
Pierre Peiffer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
From: Pierre Peiffer [EMAIL PROTECTED]
semctl_down is called with the rwmutex (the one which protects the
list of ipcs) taken in write mode.
This patch moves this rwmutex taken in write-mode inside semctl_down.
This has the advantages of reducing a little bit the window during
which this rwmutex
Hi,
By continuing to consolidate a little the IPC code, each id can be built
directly in ipc_addid() instead of having it built from each callers of
ipc_addid()
And I also remove shm_addid() in order to have, as much as possible, the
same code for shm/sem/msg.
Signed-off-by: Pierre Peiffer
>
>> think of clone() nightmare to add a new argument);
>
> Yes, and then there will need to be the clone_with_pid() extension on
> top of that.
>
>> second, the change
>> is incremental: first code the mechanism to set the field, then add
>> support in the IPC su
to be the clone_with_pid() extension on
top of that.
second, the change
is incremental: first code the mechanism to set the field, then add
support in the IPC subsystem, later in the DEVPTS, then in clone and
so forth.
Oren.
Pierre Peiffer wrote:
Kirill Korotaev wrote:
Why user space can need this API
patch.
As NS8390p_init() does the same thing than NS8390_init(), I suppose that this
is the right fix ?
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
---
drivers/net/ne.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: b/drivers/ne
Pavel Machek wrote:
> Hi!
>
>> * Patches 9 to 15 propose to add some functionalities, and thus are
>> submitted here for RFC, about both the interest and their implementation.
>> These functionalities are:
>> - Two new control-commands:
>> . IPC_SETID: to change an IPC's id.
>> .
Pavel Machek wrote:
Hi!
* Patches 9 to 15 propose to add some functionalities, and thus are
submitted here for RFC, about both the interest and their implementation.
These functionalities are:
- Two new control-commands:
. IPC_SETID: to change an IPC's id.
. IPC_SETALL:
patch.
As NS8390p_init() does the same thing than NS8390_init(), I suppose that this
is the right fix ?
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
---
drivers/net/ne.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: b/drivers/net/ne.c
Serge E. Hallyn wrote:
> Quoting Pierre Peiffer ([EMAIL PROTECTED]):
>>
>> Serge E. Hallyn wrote:
>>> Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
>>>> From: Pierre Peiffer <[EMAIL PROTECTED]>
>>>>
>>>> In order
Serge E. Hallyn wrote:
Quoting Pierre Peiffer ([EMAIL PROTECTED]):
Serge E. Hallyn wrote:
Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
From: Pierre Peiffer [EMAIL PROTECTED]
In order to modify the semundo-list of a task from procfs, we must be able
to
work on any target task
, I don't think this really a concern at all. I mean: I've never seen
"this allows non-GPL binary and thus, this is bad" as an argument to reject a
functionality, but I may be wrong, and thus, it can be discussed as well.
I think the points (1) and (2) as stated above are
Nadia Derbey wrote:
> [EMAIL PROTECTED] wrote:
>> From: Pierre Peiffer <[EMAIL PROTECTED]>
>>
>> semctl_down() takes one unused parameter: semnum.
>> This patch proposes to get rid of it.
>>
>> Signed-off-by: Pierre Peiffer <[EMAIL PROTECT
Serge E. Hallyn wrote:
> Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
>> From: Pierre Peiffer <[EMAIL PROTECTED]>
>>
>> Today, the sem_undo_list is freed when the last task using it exits.
>> There is no mechanism in place, that allows a safe concurre
Serge E. Hallyn wrote:
> Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
>> From: Pierre Peiffer <[EMAIL PROTECTED]>
>>
>> In order to modify the semundo-list of a task from procfs, we must be able to
>> work on any target task.
>> But all the exis
Hi again,
Thinking more about this, I think I must clarify why I choose this way.
In fact, the idea of these patches is to provide the missing user APIs (or
extend the existing ones) that allow to set or update _all_ properties of all
IPCs, as needed in the case of the checkpoint/restart
Hi again,
Thinking more about this, I think I must clarify why I choose this way.
In fact, the idea of these patches is to provide the missing user APIs (or
extend the existing ones) that allow to set or update _all_ properties of all
IPCs, as needed in the case of the checkpoint/restart
Serge E. Hallyn wrote:
Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
From: Pierre Peiffer [EMAIL PROTECTED]
In order to modify the semundo-list of a task from procfs, we must be able to
work on any target task.
But all the existing code playing with the semundo-list, currently works
only
Serge E. Hallyn wrote:
Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
From: Pierre Peiffer [EMAIL PROTECTED]
Today, the sem_undo_list is freed when the last task using it exits.
There is no mechanism in place, that allows a safe concurrent access to
the sem_undo_list of a target task
Nadia Derbey wrote:
[EMAIL PROTECTED] wrote:
From: Pierre Peiffer [EMAIL PROTECTED]
semctl_down() takes one unused parameter: semnum.
This patch proposes to get rid of it.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge Hallyn [EMAIL PROTECTED]
---
ipc/sem.c |6
this allows non-GPL binary and thus, this is bad as an argument to reject a
functionality, but I may be wrong, and thus, it can be discussed as well.
I think the points (1) and (2) as stated above are the key ones.
Pierre
Kirill
Pierre Peiffer wrote:
Hi again,
Thinking more about this, I think
problem, as we
will probably restart an application in an empty "container"/"namespace"; Thus
we can create all needed IPCs in an empty IPC namespace like this:
1. create first IPC
2. change its ID
3. create the second IPC
4. change its ID
5. etc..
But yes, I agree
. etc..
But yes, I agree that if we can directly create an IPC with the right ID, it
would be better; may be with an IPC_CREATE command or something like that if the
direction is to do that from userspace.
--
Pierre Peiffer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
From: Pierre Peiffer <[EMAIL PROTECTED]>
This patch adds the write operation to the semundo file.
This write operation allows root to add or update the semundo list and
their values for a given process.
The user must provide some lines, each containing the semaphores ID
fo
From: Pierre Peiffer <[EMAIL PROTECTED]>
In order to modify the semundo-list of a task from procfs, we must be able to
work on any target task.
But all the existing code playing with the semundo-list, currently works
only on the 'current' task, and does not allow to specify any targe
From: Pierre Peiffer <[EMAIL PROTECTED]>
This patch adds a new procfs interface to display the per-process semundo
data.
A new per-PID file is added, named "semundo".
It contains one line per semaphore IPC where there is something to undo for
this process.
Then, each line co
From: Pierre Peiffer <[EMAIL PROTECTED]>
Today, the sem_undo_list is freed when the last task using it exits.
There is no mechanism in place, that allows a safe concurrent access to
the sem_undo_list of a target task and protects efficiently against a
task-exit.
That is okay for now as we
From: Pierre Peiffer <[EMAIL PROTECTED]>
This patch adds a new IPC_SETALL command to the System V IPCs set of commands,
which allows to change all the settings of an IPC
It works exactly the same way as the IPC_SET command, except that it
additionally changes all the times and the pids
From: Pierre Peiffer <[EMAIL PROTECTED]>
This patch adds a new IPC_SETID command to the System V IPCs set of commands,
which allows to change the ID of an existing IPC.
This command can be used through the semctl/shmctl/msgctl API, with the new
ID passed as the third argument for
From: Pierre Peiffer <[EMAIL PROTECTED]>
This patch provides three new API to change the ID of an existing
System V IPCs.
These APIs are:
long msg_chid(struct ipc_namespace *ns, int id, int newid);
long sem_chid(struct ipc_namespace *ns, int id, int newid);
long sh
these same pieces of code
into one common function called ipcctl_pre_down().
It simplifies a little these xxxctl_down() functions and increases a little
the maintainability.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
Acked-by: Serge Hallyn <[EMAIL PROTECTED]>
---
ipc/m
From: Pierre Peiffer <[EMAIL PROTECTED]>
The IPC_SET command performs the same permission setting for all IPCs.
This patch introduces a common ipc_update_perm() function to update these
permissions and makes use of it for all IPCs.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTE
From: Pierre Peiffer <[EMAIL PROTECTED]>
All IPCs make use of an intermetiate *_setbuf structure to handle the
IPC_SET command. This is not really needed and, moreover, it complicate
a little bit the code.
This patch get rid of the use of it and uses directly the semid64_ds/
msgi
From: Pierre Peiffer <[EMAIL PROTECTED]>
semctl_down is called with the rwmutex (the one which protects the
list of ipcs) taken in write mode.
This patch moves this rwmutex taken in write-mode inside semctl_down.
This has the advantages of reducing a little bit the window during
From: Pierre Peiffer <[EMAIL PROTECTED]>
semctl_down() takes one unused parameter: semnum.
This patch proposes to get rid of it.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
Acked-by: Serge Hallyn <[EMAIL PROTECTED]>
---
ipc/sem.c |6 +++---
1 file changed, 3 insertio
From: Pierre Peiffer <[EMAIL PROTECTED]>
Currently, sys_msgctl is not easy to read.
This patch tries to improve that by introducing the msgctl_down function
to handle all commands requiring the rwmutex to be taken in write mode
(ie IPC_SET and IPC_RMID for now). It is the equivalent fu
From: Pierre Peiffer <[EMAIL PROTECTED]>
Currently, the way the different commands are handled in sys_shmctl
introduces some duplicated code.
This patch introduces the shmctl_down function to handle all the commands
requiring the rwmutex to be taken in write mode (ie IPC_SET and IPC_RMID
f
From: Pierre Peiffer <[EMAIL PROTECTED]>
Trivial patch which adds some small locking functions and makes use of them
to factorize some part of code and makes it cleaner.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
Acked-by: Serge Hallyn <[EMAIL PROTECTED]>
---
Hi,
Here is a patchset about the IPC, which proposes to consolidate some
part of the existing code and to add some functionalities.
* Patches 1 to 8 don't change the existing behavior, but propose to rewrite
some parts of the existing code. In fact, the three kinds of IPC (semaphores,
Hi,
Here is a patchset about the IPC, which proposes to consolidate some
part of the existing code and to add some functionalities.
* Patches 1 to 8 don't change the existing behavior, but propose to rewrite
some parts of the existing code. In fact, the three kinds of IPC (semaphores,
From: Pierre Peiffer [EMAIL PROTECTED]
Currently, sys_msgctl is not easy to read.
This patch tries to improve that by introducing the msgctl_down function
to handle all commands requiring the rwmutex to be taken in write mode
(ie IPC_SET and IPC_RMID for now). It is the equivalent function
From: Pierre Peiffer [EMAIL PROTECTED]
semctl_down is called with the rwmutex (the one which protects the
list of ipcs) taken in write mode.
This patch moves this rwmutex taken in write-mode inside semctl_down.
This has the advantages of reducing a little bit the window during
which this rwmutex
From: Pierre Peiffer [EMAIL PROTECTED]
semctl_down() takes one unused parameter: semnum.
This patch proposes to get rid of it.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge Hallyn [EMAIL PROTECTED]
---
ipc/sem.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions
From: Pierre Peiffer [EMAIL PROTECTED]
The IPC_SET command performs the same permission setting for all IPCs.
This patch introduces a common ipc_update_perm() function to update these
permissions and makes use of it for all IPCs.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge
From: Pierre Peiffer [EMAIL PROTECTED]
This patch provides three new API to change the ID of an existing
System V IPCs.
These APIs are:
long msg_chid(struct ipc_namespace *ns, int id, int newid);
long sem_chid(struct ipc_namespace *ns, int id, int newid);
long shm_chid
From: Pierre Peiffer [EMAIL PROTECTED]
In order to modify the semundo-list of a task from procfs, we must be able to
work on any target task.
But all the existing code playing with the semundo-list, currently works
only on the 'current' task, and does not allow to specify any target task
From: Pierre Peiffer [EMAIL PROTECTED]
Today, the sem_undo_list is freed when the last task using it exits.
There is no mechanism in place, that allows a safe concurrent access to
the sem_undo_list of a target task and protects efficiently against a
task-exit.
That is okay for now as we don't
From: Pierre Peiffer [EMAIL PROTECTED]
This patch adds a new procfs interface to display the per-process semundo
data.
A new per-PID file is added, named semundo.
It contains one line per semaphore IPC where there is something to undo for
this process.
Then, each line contains the semid followed
From: Pierre Peiffer [EMAIL PROTECTED]
This patch adds the write operation to the semundo file.
This write operation allows root to add or update the semundo list and
their values for a given process.
The user must provide some lines, each containing the semaphores ID
followed by the semaphores
From: Pierre Peiffer [EMAIL PROTECTED]
This patch adds a new IPC_SETID command to the System V IPCs set of commands,
which allows to change the ID of an existing IPC.
This command can be used through the semctl/shmctl/msgctl API, with the new
ID passed as the third argument for msgctl and shmctl
From: Pierre Peiffer [EMAIL PROTECTED]
This patch adds a new IPC_SETALL command to the System V IPCs set of commands,
which allows to change all the settings of an IPC
It works exactly the same way as the IPC_SET command, except that it
additionally changes all the times and the pids values
these same pieces of code
into one common function called ipcctl_pre_down().
It simplifies a little these xxxctl_down() functions and increases a little
the maintainability.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge Hallyn [EMAIL PROTECTED]
---
ipc/msg.c | 48
From: Pierre Peiffer [EMAIL PROTECTED]
All IPCs make use of an intermetiate *_setbuf structure to handle the
IPC_SET command. This is not really needed and, moreover, it complicate
a little bit the code.
This patch get rid of the use of it and uses directly the semid64_ds/
msgid64_ds/shmid64_ds
From: Pierre Peiffer [EMAIL PROTECTED]
Currently, the way the different commands are handled in sys_shmctl
introduces some duplicated code.
This patch introduces the shmctl_down function to handle all the commands
requiring the rwmutex to be taken in write mode (ie IPC_SET and IPC_RMID
for now
From: Pierre Peiffer [EMAIL PROTECTED]
Trivial patch which adds some small locking functions and makes use of them
to factorize some part of code and makes it cleaner.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
Acked-by: Serge Hallyn [EMAIL PROTECTED]
---
ipc/sem.c | 61
Andrew Morton wrote:
> Doing this in a piecemeal through-a-pinhole fashion won't work very well
> and is a bit risky.
Yes, agree, that's also my feeling.
--
Pierre Peiffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Andrew Morton wrote:
Doing this in a piecemeal through-a-pinhole fashion won't work very well
and is a bit risky.
Yes, agree, that's also my feeling.
--
Pierre Peiffer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
message follows immediately */
};
is acceptable ?
Otherwise, either a cast can be added or this patch can be dropped...
Thanks,
--
Pierre Peiffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo inf
message follows immediately */
};
is acceptable ?
Otherwise, either a cast can be added or this patch can be dropped...
Thanks,
--
Pierre Peiffer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
le.patch
> +ext-use-ext_get_group_desc.patch
> +ext-remove-unused-argument-for-ext_find_goal.patch
> +ext-cleanup-ext_bg_num_gdb.patch
>
> ext2/3/4 cleanups
>
> +per-zone-and-reclaim-enhancements-for-memory-controller-take-3-modifies-vmscanc-for-isolate-globa-cgroup-lru-
at http://www.tux.org/lkml/
--
Pierre Peiffer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
The file exit.c contains one useless extern declaration of sem_exit().
Moreover, it refers to nothing.
This trivial patch removes it.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
---
kernel/exit.c |2 --
1 file changed, 2 deletions(-)
Index: b/kernel/
The file exit.c contains one useless extern declaration of sem_exit().
Moreover, it refers to nothing.
This trivial patch removes it.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
---
kernel/exit.c |2 --
1 file changed, 2 deletions(-)
Index: b/kernel/exit.c
From: Pierre Peiffer <[EMAIL PROTECTED]>
These both commands (SEM_STAT and IPC_STAT) are rather doing the same things
(only the meaning of the id given as input and the return value differ).
However, for the semaphores, they are handled in two different places
(two different fun
this by introducing a common function,
free_ipcs(),
that do the job. The specific routine to call on each individual ipcs is passed
as
parameter. For this, these ipc-specific 'free' routines are reworked to take a
generic 'struct ipc_perm' as parameter.
Signed-off-by: Pierre Peiffer <[EMAIL PROTEC
Andrew,
Following this discussion http://lkml.org/lkml/2007/11/27/54, I
resend the three patches that I've sent last friday to let you have all of
them in the right order.
Thanks,
--
Pierre Peiffer
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
From: Pierre Peiffer <[EMAIL PROTECTED]>
Each ipc_namespace contains a table of 3 pointers to struct ipc_ids (3 for
msg, sem and shm, structure used to store each ipcs)
These pointers are dynamically allocated for each icp_namespace as the
ipc_namespace itself (for the init nam
Andrew Morton wrote:
> On Mon, 26 Nov 2007 22:44:38 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote:
>
>> On Fri, 23 Nov 2007 17:52:50 +0100 Pierre Peiffer <[EMAIL PROTECTED]> wrote:
>>
>>> sem_exit_ns(), msg_exit_ns() and shm_exit_ns() are all called whe
Andrew Morton wrote:
On Mon, 26 Nov 2007 22:44:38 -0800 Andrew Morton [EMAIL PROTECTED] wrote:
On Fri, 23 Nov 2007 17:52:50 +0100 Pierre Peiffer [EMAIL PROTECTED] wrote:
sem_exit_ns(), msg_exit_ns() and shm_exit_ns() are all called when an
ipc_namespace is
released to free all ipcs
Andrew,
Following this discussion http://lkml.org/lkml/2007/11/27/54, I
resend the three patches that I've sent last friday to let you have all of
them in the right order.
Thanks,
--
Pierre Peiffer
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
From: Pierre Peiffer [EMAIL PROTECTED]
Each ipc_namespace contains a table of 3 pointers to struct ipc_ids (3 for
msg, sem and shm, structure used to store each ipcs)
These pointers are dynamically allocated for each icp_namespace as the
ipc_namespace itself (for the init namespace
From: Pierre Peiffer [EMAIL PROTECTED]
These both commands (SEM_STAT and IPC_STAT) are rather doing the same things
(only the meaning of the id given as input and the return value differ).
However, for the semaphores, they are handled in two different places
(two different functions).
This patch
this by introducing a common function,
free_ipcs(),
that do the job. The specific routine to call on each individual ipcs is passed
as
parameter. For this, these ipc-specific 'free' routines are reworked to take a
generic 'struct ipc_perm' as parameter.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED
this by introducing a common function,
free_ipcs(),
that do the job. The specific routine to call on each individual ipcs is passed
as
parameter. For this, these ipc-specific 'free' routines are reworked to take a
generic 'struct ipc_perm' as parameter.
Signed-off-by: Pierre Peiffer <[EMAIL PROTEC
by handling these both
commands in the same place in semctl_nolock(). It also removes one
unused parameter for this function.
Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]>
---
ipc/sem.c | 38 --
1 file changed, 16 insertions(+), 22 deletions(-)
In
Pavel Emelyanov wrote:
> Well I think you're right. The structure gains 50% in size... Really too
> much to fight for performance in IPC :)
>
> Thanks for checking this thing.
>
> You may put my Acked-by in the original patch.
>
Cool. Thanks !
P.
> Thanks,
> P
:
> Pierre Peiffer wrote:
>> Hi,
>>
>> Thanks for reviewing this !
>>
>> Pavel Emelyanov wrote:
>>> Pavel Emelyanov wrote:
>>>> Cedric Le Goater wrote:
>>>>> Pierre Peiffer wrote:
>>> [snip]
>>>
>>>
Hi,
Thanks for reviewing this !
Pavel Emelyanov wrote:
> Pavel Emelyanov wrote:
>> Cedric Le Goater wrote:
>>> Pierre Peiffer wrote:
>
> [snip]
>
>>> Pavel, what do you think of it ?
>> Looks sane, good catch, Pierre.
>>
>> But
Hi,
Thanks for reviewing this !
Pavel Emelyanov wrote:
Pavel Emelyanov wrote:
Cedric Le Goater wrote:
Pierre Peiffer wrote:
[snip]
Pavel, what do you think of it ?
Looks sane, good catch, Pierre.
But I'd find out whether these three ipc_ids intersect any
cache-line
by handling these both
commands in the same place in semctl_nolock(). It also removes one
unused parameter for this function.
Signed-off-by: Pierre Peiffer [EMAIL PROTECTED]
---
ipc/sem.c | 38 --
1 file changed, 16 insertions(+), 22 deletions(-)
Index: b/ipc
1 - 100 of 227 matches
Mail list logo
