Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes

2020-12-10 Thread Simon Budig
Also mark "report rate" register as non-existent for generic > firmwares as > having it set to 0 does not make sense. Looks good. Reviewed-by: Simon Budig Thanks, Simon --      kernel concepts GmbH Simon Budig  Hauptstraße 16

Re: edt-ft5x06 question

2017-11-15 Thread Simon Budig
r I am interested in feedback. Bye, Simon -- kernel concepts GmbH Simon Budig Sieghuetter Hauptweg 48 simon.bu...@kernelconcepts.de D-57072 Siegen +49-271-771091-17 http://www.kernelconcepts.de/ HR Siegen, HR B 9613; Geschäf

Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs

2017-01-04 Thread Simon Budig
> Explained originally here why to not use msleep for 1-20ms: > http://lkml.org/lkml/2007/8/3/250 Acked-by: Simon Budig Bye, Simon -- kernel concepts GmbH Simon Budig Sieghuetter Hauptweg 48 simon.bu...@kernelconcepts.de D-57072 Siegen

Re: [PATCH] Input: touchscreen: edt_ft5x06 - change msleep to usleep_range for small msecs

2016-12-03 Thread Simon Budig
t see a lot that speaks in favor of it. *shrug* Bye, Simon -- kernel concepts GmbH Simon Budig Sieghuetter Hauptweg 48 simon.bu...@kernelconcepts.de D-57072 Siegen +49-271-771091-17 http://www.kernelconcepts.de/ HR S

Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support

2014-03-20 Thread Simon Budig
ommunication protocol). They got tricked into thinking that this driver would be suitable... If I were to chose the name again I'd probably pick "edt-polytouch" or something like this. But I doubt that it is useful to change the name now. Bye, Simon -- Simon Budig

Re: [PATCHv4 2/5] Input: edt-ft5x06: Add DT support

2014-03-20 Thread Simon Budig
col (see Patch 5/5). I don't know anything about the naming scheme used in the device tree, but I am not sure if the chip-ID is actually useful here. Bye, Simon -- Simon Budigkernel concepts GmbH simon.bu...@kernelconcepts.de Sieghue

Re: [PATCH 2/2] Input: edt-ft5x06: Add DT support

2014-01-16 Thread Simon Budig
em from being passed via platform_data. I have no > idea what they actually control and what units they use. I could not > even find a manual where they are documented. > Maybe Simon Budig can help out here as the original driver author. The units are not specified in the datasheets available t

Re: [PATCHv2 3/3] Input: edt-ft5x06: Add DT support

2014-01-16 Thread Simon Budig
ide different defaults depending on the way a specific device is built. So these properties can be viewed in the same way you specify display resolution or display type in the device tree. Bye, Simon -- Simon Budigkernel concepts GmbH simon.bu...@kern

Re: [PATCH] Input: Let the FT5x06 driver build without debugfs

2012-08-17 Thread Simon Budig
patch for this issue which I slightly prefer. You can find it in the mail from Guenther Roeck: http://www.mail-archive.com/linux-input@vger.kernel.org/msg00646.html Thanks, Simon - -- Simon Budigkernel concepts GmbH simon.bu...@kernelco

Re: linux-next: Tree for Aug 14 (drivers/input/touchscreen/edt-ft5x06.c)

2012-08-14 Thread Simon Budig
tion required on my part? Thanks, Simon - -- Simon Budigkernel concepts GmbH simon.bu...@kernelconcepts.de Sieghuetter Hauptweg 48 +49-271-771091-17 D-57072 Siegen -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
Jiri Kosina ([EMAIL PROTECTED]) wrote: > On Mon, 15 Jan 2007, Simon Budig wrote: > > Is it possible that there is a regression in the hid-debug stuff? The > > mapping does not seem to appear in the dmesg-output. I unfortunately > > don't have an earlier kernel availabl

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
Jiri Kosina ([EMAIL PROTECTED]) wrote: > On Mon, 15 Jan 2007, Simon Budig wrote: > > Yeah, it was easy to port over. Did the hid-debug stuff disappear > > completely? What would I use instead? > > No, it didn't disappear, it was just moved to include/linux/hid-debug.

Re: [PATCH 2.6.20-rc5] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
From: Simon Budig <[EMAIL PROTECTED]> This trivial change adds some missing enum values to the hid-debug output. Signed-off-by: Simon Budig <[EMAIL PROTECTED]> --- linux/include/linux/hid-debug.h.orig2007-01-15 18:19:52.0 +0100 +++ linux/include/linux/hid-debug.h

[PATCH 2.6.20-rc5] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
From: Simon Budig <[EMAIL PROTECTED]> This change introduces a mapping for LED indicators between the USB HID specification and the Linux input subsystem. The previous code properly mapped the LEDs relevant for Keyboards, but garbeled the remaining ones. With this change all LED enums fr

Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-15 Thread Simon Budig
Jiri Kosina ([EMAIL PROTECTED]) wrote: > thanks for the patch. It seems that it is based on pre-2.6.20-rc1 kernel > (this is where the USBHID split happened and generic HID layer was > introduced). Could you please rebase it against newer version of kernel > and resend it? I've updated the patc

[PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)

2007-01-14 Thread Simon Budig
From: Simon Budig <[EMAIL PROTECTED]> This change introduces a mapping for LED indicators between the USB HID specification and the Linux input subsystem. The previous code properly mapped the LEDs relevant for Keyboards, but garbeled the remaining ones. With this change all LED enums fr