Re: [RFC PATCH V2] scsi: ufs: Add specific callback for setting DMA mask

On 2018-05-15 21:31, Alim Akhtar wrote: Ping !!! On Thu, Mar 8, 2018 at 4:33 PM, Alim Akhtar wrote: Currently DMA mask for UFS HCI is set by reading CAP register's [64AS] bit. Some HCI controller like Exynos support 36-bit bus address. This works perfectly fine

Re: [RFC PATCH V2] scsi: ufs: Add specific callback for setting DMA mask

On 2018-05-15 21:31, Alim Akhtar wrote: Ping !!! On Thu, Mar 8, 2018 at 4:33 PM, Alim Akhtar wrote: Currently DMA mask for UFS HCI is set by reading CAP register's [64AS] bit. Some HCI controller like Exynos support 36-bit bus address. This works perfectly fine with DMA mask set as 64 in

Re: [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func

u32 attr_sel, u32 *mib_val, u8 peer); +extern int ufshcd_config_pwr_mode(struct ufs_hba *hba, + struct ufs_pa_layer_attr *desired_pwr_mode); /* UIC command interfaces for DME primitives */ #define DME_LOCAL 0 Looks good to me. Reviewed-by: Subhash Jad

Re: [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func

); +extern int ufshcd_config_pwr_mode(struct ufs_hba *hba, + struct ufs_pa_layer_attr *desired_pwr_mode); /* UIC command interfaces for DME primitives */ #define DME_LOCAL 0 Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc

Re: [PATCH 3/4] scsi: ufs: add quirk to enable host controller without hce

0 unsigned int quirks;/* Deviations from standard UFSHCI spec. */ /* Device deviations from standard UFS device spec. */ Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 3/4] scsi: ufs: add quirk to enable host controller without hce

ndard UFSHCI spec. */ /* Device deviations from standard UFS device spec. */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 2/4] scsi: ufs: add quirk not to allow reset of interrupt aggregation

nd counter are reset by s/w. +*/ + #define UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR 0x200 + unsigned int quirks;/* Deviations from standard UFSHCI spec. */ /* Device deviations from standard UFS device spec. */ Looks good to me. Reviewed-by: Subhash Jadavani <subha...@co

Re: [PATCH 2/4] scsi: ufs: add quirk not to allow reset of interrupt aggregation

RESET_INTR_AGGR 0x200 + unsigned int quirks;/* Deviations from standard UFSHCI spec. */ /* Device deviations from standard UFS device spec. */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora

Re: [PATCH 1/4] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr

+* Cleaer handling for transfer/task request list is just opposite. +*/ + #define UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR0x100 + unsigned int quirks;/* Deviations from standard UFSHCI spec. */ /* Device deviations from standard UFS device spec. */ Looks good to me

Re: [PATCH 1/4] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr

. +*/ + #define UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR0x100 + unsigned int quirks;/* Deviations from standard UFSHCI spec. */ /* Device deviations from standard UFS device spec. */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Inn

Re: [PATCH v2 2/2] scsi: ufs: Use freq table with devfreq

; + ufshcd_devfreq_remove(hba); } ufshcd_setup_clocks(hba, false); ufshcd_setup_hba_vreg(hba, false); Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 2/2] scsi: ufs: Use freq table with devfreq

evfreq_remove(hba); } ufshcd_setup_clocks(hba, false); ufshcd_setup_hba_vreg(hba, false); Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 10/10] scsi: ufs: Add clock ungating to a separate workqueue

100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -361,6 +361,7 @@ struct ufs_clk_gating { struct device_attribute enable_attr; bool is_enabled; int active_reqs; + struct workqueue_struct *clk_gating_workq; }; struct ufs_saved_pwr_info { Looks good to m

Re: [PATCH v2 10/10] scsi: ufs: Add clock ungating to a separate workqueue

struct device_attribute enable_attr; bool is_enabled; int active_reqs; + struct workqueue_struct *clk_gating_workq; }; struct ufs_saved_pwr_info { Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 07/10] scsi: ufs-qcom: remove broken hci version quirk

On 2018-05-03 04:07, Asutosh Das wrote: From: Subhash Jadavani <subha...@codeaurora.org> UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for version

Re: [PATCH v2 08/10] scsi: ufs: make sure all interrupts are processed

, enabled_intr_status); - retval = IRQ_HANDLED; - } spin_unlock(hba->host->host_lock); return retval; } Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 07/10] scsi: ufs-qcom: remove broken hci version quirk

On 2018-05-03 04:07, Asutosh Das wrote: From: Subhash Jadavani UFSHCD_QUIRK_BROKEN_UFS_HCI_VERSION is only applicable for QCOM UFS host controller version 2.x.y and this has been fixed from version 3.x.y onwards, hence this change removes this quirk for version 3.x.y onwards. Signed-off

Re: [PATCH v2 08/10] scsi: ufs: make sure all interrupts are processed

_unlock(hba->host->host_lock); return retval; } Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 06/10] scsi: ufs: add reference counting for scsi block requests

On 2018-05-03 04:07, Asutosh Das wrote: From: Subhash Jadavani <subha...@codeaurora.org> Currently we call the scsi_block_requests()/scsi_unblock_requests() whenever we want to block/unblock scsi requests but as there is no reference counting, nesting of these calls could leave us in und

Re: [PATCH v2 06/10] scsi: ufs: add reference counting for scsi block requests

On 2018-05-03 04:07, Asutosh Das wrote: From: Subhash Jadavani Currently we call the scsi_block_requests()/scsi_unblock_requests() whenever we want to block/unblock scsi requests but as there is no reference counting, nesting of these calls could leave us in undesired state sometime. Consider

Re: [PATCH v2 05/10] scsi: ufshcd: fix possible unclocked register access

On 2018-05-03 04:07, Asutosh Das wrote: From: Subhash Jadavani <subha...@codeaurora.org> vendor specific setup_clocks ops may depend on clocks managed by ufshcd driver so if the vendor specific setup_clocks callback is called when the required clocks are turned off, it results into unc

Re: [PATCH v2 05/10] scsi: ufshcd: fix possible unclocked register access

On 2018-05-03 04:07, Asutosh Das wrote: From: Subhash Jadavani vendor specific setup_clocks ops may depend on clocks managed by ufshcd driver so if the vendor specific setup_clocks callback is called when the required clocks are turned off, it results into unclocked register access

Re: [PATCH v2 04/10] scsi: ufs: fix exception event handling

eption events and allow retransmissions of the query requests, in case of timeout. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Maya Erez <me...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora

Re: [PATCH v2 04/10] scsi: ufs: fix exception event handling

retransmissions of the query requests, in case of timeout. Signed-off-by: Subhash Jadavani Signed-off-by: Maya Erez Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs

Re: [PATCH v2 03/10] scsi: ufs: Add LCC quirk for host and device

we don't want to disable the LCC on both host & device; hence this change splits the quirk in 2 parts one for host and one for device. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Can Guo <

Re: [PATCH v2 03/10] scsi: ufs: Add LCC quirk for host and device

we don't want to disable the LCC on both host & device; hence this change splits the quirk in 2 parts one for host and one for device. Signed-off-by: Subhash Jadavani Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.c

Re: [PATCH v2 02/10] scsi: ufs-qcom: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk

On 2018-05-03 04:07, Asutosh Das wrote: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk to avoid failures in seen on some UFS devices. Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 02/10] scsi: ufs-qcom: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk

On 2018-05-03 04:07, Asutosh Das wrote: Enable UFSHCD_QUIRK_BROKEN_PWR_MODE_CHANGE quirk to avoid failures in seen on some UFS devices. Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufs-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c

Re: [PATCH v2 01/10] scsi: ufs: Allowing power mode change

i <yga...@codeaurora.org> Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 8 +++- drivers/scsi/ufs/ufshcd.h | 7 +++ 2 file

Re: [PATCH v2 01/10] scsi: ufs: Allowing power mode change

On 2018-05-03 04:07, Asutosh Das wrote: From: Yaniv Gardi Due to M-PHY issues, moving from HS to any other mode or gear or even Hibern8 may cause some un-predicted behavior of the device. This patch adds provides a quirk to address that. Signed-off-by: Yaniv Gardi Signed-off-by: Subhash

Re: [PATCH] scsi: ufs: ufshcd: Remove VLA usage

el[MAX_MODEL_LEN] = '\0'; out: + kfree(desc_buf); return err; } -- 2.17.0 Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: ufshcd: Remove VLA usage

out: + kfree(desc_buf); return err; } -- 2.17.0 Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 3/3] scsi: ufs: Use freq table with devfreq

gt;min_freq; + profile->freq_table[1] = clki->max_freq; + devfreq = devm_devfreq_add_device(hba->dev, - _devfreq_profile, + profile, "simple_ondemand", NULL); if (I

Re: [PATCH 3/3] scsi: ufs: Use freq table with devfreq

; + profile->freq_table[1] = clki->max_freq; + devfreq = devm_devfreq_add_device(hba->dev, - _devfreq_profile, + profile, "simple_ondemand", NULL); if (IS_ERR(devfreq)) { Looks goo

Re: [PATCH 2/3] scsi: ufs: Extract devfreq registration

); + if (ret) goto out; - } } hba->clk_scaling.is_allowed = true; } Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 2/3] scsi: ufs: Extract devfreq registration

} } hba->clk_scaling.is_allowed = true; } Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 1/1] scsi: ufs: fix exception event handling

eption events and allow retransmissions of the query requests, in case of timeout. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> Signed-off-by: Maya Erez <me...@codeaurora.org> Signed-off-by: Can Guo <c...@codeaurora.org> Signed-off-by: Asutosh Das <asuto...@codeaurora

Re: [PATCH 1/1] scsi: ufs: fix exception event handling

retransmissions of the query requests, in case of timeout. Signed-off-by: Subhash Jadavani Signed-off-by: Maya Erez Signed-off-by: Can Guo Signed-off-by: Asutosh Das --- drivers/scsi/ufs/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs

Re: [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE

sh Storage (UFS) QCOM PHY"); +MODULE_LICENSE("GPL v2"); Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE

(UFS) QCOM PHY"); +MODULE_LICENSE("GPL v2"); Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg

gt;min_uV : 0; ret = regulator_set_voltage(reg, min_uV, vreg->max_uV); Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg

et_voltage(reg, min_uV, vreg->max_uV); Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 5/5] ufs/phy: qcom: Refactor to use phy_init call

truct phy *phy); int ufs_qcom_phy_set_tx_lane_enable(struct phy *phy, u32 tx_lanes); -int ufs_qcom_phy_calibrate_phy(struct phy *phy, bool is_rate_B); -int ufs_qcom_phy_is_pcs_ready(struct phy *phy); void ufs_qcom_phy_save_controller_version(struct phy *phy, u8 m

Re: [PATCH v2 5/5] ufs/phy: qcom: Refactor to use phy_init call

); int ufs_qcom_phy_set_tx_lane_enable(struct phy *phy, u32 tx_lanes); -int ufs_qcom_phy_calibrate_phy(struct phy *phy, bool is_rate_B); -int ufs_qcom_phy_is_pcs_ready(struct phy *phy); void ufs_qcom_phy_save_controller_version(struct phy *phy, u8 major, u16 minor, u16 step); Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 5/5] ufs/phy: qcom: Refactor to use phy_init call

Hi Vivek, Please find one comment inline below, rest look good. Regards, Subhash On 2017-08-03 23:48, Vivek Gautam wrote: Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek

Re: [PATCH 5/5] ufs/phy: qcom: Refactor to use phy_init call

Hi Vivek, Please find one comment inline below, rest look good. Regards, Subhash On 2017-08-03 23:48, Vivek Gautam wrote: Refactor ufs_qcom_power_up_sequence() to get rid of ugly exported phy APIs and use the phy_init() and phy_power_on() to do the phy initialization. Signed-off-by: Vivek

Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

values */ ufs_qcom_assert_reset(hba); /* provide 1ms delay to let the reset pulse propagate */ Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 4/5] scsi/ufs: qcom: Set phy mode based on the controllers HS MODE

); /* provide 1ms delay to let the reset pulse propagate */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: fix wrong command type of UTRD for UFSHCI v2.1

c_hdr(lrbp, _flags, Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: fix wrong command type of UTRD for UFSHCI v2.1

+ (hba->ufs_version == UFSHCI_VERSION_11)) lrbp->command_type = UTP_CMD_TYPE_SCSI; + else + lrbp->command_type = UTP_CMD_TYPE_UFS_STORAGE; if (likely(lrbp->cmd)) { ufshcd_prepare_req_desc_hdr(lrbp, _flags, Looks

Re: [PATCH] scsi: ufs: continue to boot even with Boot LUN is disabled

+ scsi_device_put(sdev_boot); goto out; -remove_sdev_boot: - scsi_remove_device(sdev_boot); remove_sdev_ufs_device: scsi_remove_device(hba->sdev_ufs_device); out: Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qual

Re: [PATCH] scsi: ufs: continue to boot even with Boot LUN is disabled

(sdev_boot); goto out; -remove_sdev_boot: - scsi_remove_device(sdev_boot); remove_sdev_ufs_device: scsi_remove_device(hba->sdev_ufs_device); out: Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Auro

Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs

On 2017-06-22 04:51, Arnd Bergmann wrote: On Thu, Jun 22, 2017 at 1:44 PM, Bu Tao wrote: 在 2017/6/17 5:51, Arnd Bergmann 写道: On Fri, Jun 16, 2017 at 8:51 AM, Bu Tao wrote: +Optional properties for board device: +- ufs-hi3660-use-rate-B:

Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs

On 2017-06-22 04:51, Arnd Bergmann wrote: On Thu, Jun 22, 2017 at 1:44 PM, Bu Tao wrote: 在 2017/6/17 5:51, Arnd Bergmann 写道: On Fri, Jun 16, 2017 at 8:51 AM, Bu Tao wrote: +Optional properties for board device: +- ufs-hi3660-use-rate-B: specifies UFS rate-B +-

Re: [PATCH 1/3] scsi:ufs:add AHIT for hi3660 ufs

On 2017-06-09 18:20, butao wrote: add Auto-Hibernate Idle Timer value for hi3660 ufs Signed-off-by: Bu Tao Signed-off-by: Geng Jianfeng Signed-off-by: Zang Leigang Signed-off-by: Yu Jianfeng

Re: [PATCH 1/3] scsi:ufs:add AHIT for hi3660 ufs

On 2017-06-09 18:20, butao wrote: add Auto-Hibernate Idle Timer value for hi3660 ufs Signed-off-by: Bu Tao Signed-off-by: Geng Jianfeng Signed-off-by: Zang Leigang Signed-off-by: Yu Jianfeng --- drivers/scsi/ufs/ufshci.h | 3 +++ 1 file changed, 3 insertions(+) mode change 100644 =>

Re: [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers

On 2017-06-05 01:36, Adrian Hunter wrote: From: Szymon Mielczarek This patch adds a glue pci driver for Intel UFS Host controllers. Signed-off-by: Szymon Mielczarek Signed-off-by: Adrian Hunter ---

Re: [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers

On 2017-06-05 01:36, Adrian Hunter wrote: From: Szymon Mielczarek This patch adds a glue pci driver for Intel UFS Host controllers. Signed-off-by: Szymon Mielczarek Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/Kconfig| 11 +++ drivers/scsi/ufs/Makefile | 1 +

Re: [PATCH 1/2] scsi: ufs: Tidy clocks list head usage

goto out; list_for_each_entry(clki, head, list) { @@ -7811,6 +7811,8 @@ int ufshcd_alloc_host(struct device *dev, struct ufs_hba **hba_handle) hba->dev = dev; *hba_handle = hba; + INIT_LIST_HEAD(>clk_list_head); + out_error: re

Re: [PATCH 1/2] scsi: ufs: Tidy clocks list head usage

shcd_alloc_host(struct device *dev, struct ufs_hba **hba_handle) hba->dev = dev; *hba_handle = hba; + INIT_LIST_HEAD(>clk_list_head); + out_error: return err; } Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()

ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4966,7 +4966,6 @@ static void ufshcd_exception_event_handler(struct work_struct *work) out: pm_runtime_put_sync(hba->dev); - return; } /* Complete requests that have door-bell cleared */ Looks good to me. Reviewed-by

Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()

tatic void ufshcd_exception_event_handler(struct work_struct *work) out: pm_runtime_put_sync(hba->dev); - return; } /* Complete requests that have door-bell cleared */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora F

Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

{ - dev_err(hba->dev, "LRB Memory allocation failed\n"); + if (!hba->lrb) goto out; - } + return 0; out: return -ENOMEM; Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> PS: ufshcd_me

Re: [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc()

n"); + if (!hba->lrb) goto out; - } + return 0; out: return -ENOMEM; Looks good to me. Reviewed-by: Subhash Jadavani PS: ufshcd_memory_alloc() also does some DMA coherent memory allocation (via dmam_alloc_coherent() APIs) and tries to print o

Re: [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()

>dev, hba->nutrs, sizeof(*hba->lrb), GFP_KERNEL); if (!hba->lrb) { dev_err(hba->dev, "LRB Memory allocation failed\n"); Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc()

lrb) { dev_err(hba->dev, "LRB Memory allocation failed\n"); Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

s */ Looks good to me. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

viewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [scsi] scsi: ufshcd-platform: remove the useless cast in ERR_PTR/IS_ERR

goto out; } LGTM. Reviewed-by: Subhash Jadavani <subha...@codeaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [scsi] scsi: ufshcd-platform: remove the useless cast in ERR_PTR/IS_ERR

. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

On 2017-03-15 10:26, James Bottomley wrote: On Mon, 2017-03-13 at 17:19 -0700, Subhash Jadavani wrote: On 2017-03-12 03:22, Tomas Winkler wrote: > Fix compilation warning > > drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned > expression < 0 is always false

Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

On 2017-03-15 10:26, James Bottomley wrote: On Mon, 2017-03-13 at 17:19 -0700, Subhash Jadavani wrote: On 2017-03-12 03:22, Tomas Winkler wrote: > Fix compilation warning > > drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned > expression < 0 is always false

Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

->host->host_lock, flags); LGTM. Reviewed-by: Subhash Jadavani <subha...@codaurora.org> -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [scsi] scsi: ufs: don't check unsigned type for a negative value

re(struct device *dev, if (kstrtoul(buf, 0, )) return -EINVAL; - if ((value < UFS_PM_LVL_0) || (value >= UFS_PM_LVL_MAX)) + if (value >= UFS_PM_LVL_MAX) return -EINVAL; spin_lock_irqsave(hba->host->host_lock, flags); LG

Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

On 2017-02-27 19:24, Martin K. Petersen wrote: "Michal" == Potomski, MichalX writes: Michal> Since in UFS 2.1 specification some of the descriptor lengths Michal> differs from 2.0 specification and some devices, which are Michal> reporting spec version 2.0 have

Re: [PATCH v2] scsi: ufs: Factor out ufshcd_read_desc_param

On 2017-02-27 19:24, Martin K. Petersen wrote: "Michal" == Potomski, MichalX writes: Michal> Since in UFS 2.1 specification some of the descriptor lengths Michal> differs from 2.0 specification and some devices, which are Michal> reporting spec version 2.0 have different descriptor lengths we

Re: [PATCH v1 1/1] scsi: ufs-qcom: remove redundant condition check

On 2017-02-20 19:06, Martin K. Petersen wrote: "Subhash" == Subhash Jadavani <subha...@codeaurora.org> writes: Subhash, Subhash> Dan Carpenter <dan.carpen...@oracle.com> reported this: --- The Subhash> patch 9c46b8676271: "scsi: ufs-qcom: dump additional tes

Re: [PATCH v1 1/1] scsi: ufs-qcom: remove redundant condition check

On 2017-02-20 19:06, Martin K. Petersen wrote: "Subhash" == Subhash Jadavani writes: Subhash, Subhash> Dan Carpenter reported this: --- The Subhash> patch 9c46b8676271: "scsi: ufs-qcom: dump additional testbus Subhash> registers" from Feb 3, 2017, leads to

Re: [PATCH] scsi: ufs: Factor out ufshcd_read_desc_param

truct ufs_hba *hba, enum query_opcode opcode, enum flag_idn idn, bool *flag_res); int ufshcd_hold(struct ufs_hba *hba, bool async); void ufshcd_release(struct ufs_hba *hba); + +int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn desc_id, + int *desc_length);

Re: [PATCH] scsi: ufs: Factor out ufshcd_read_desc_param

hba, enum query_opcode opcode, enum flag_idn idn, bool *flag_res); int ufshcd_hold(struct ufs_hba *hba, bool async); void ufshcd_release(struct ufs_hba *hba); + +int ufshcd_map_desc_id_to_length(struct ufs_hba *hba, enum desc_idn desc_id, + int *desc_length); + u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba); /* Wrapper functions for safely calling variant operations */ Looks good to me. Reviewed-by: Subhash Jadavani -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[PATCH v1 1/1] scsi: ufs-qcom: remove redundant condition check

1534__func__, host->testbus.select_minor); 1535 return false; 1536 } 1537 1538 return true; 1539 } --- As data type of "select_minor" is u8, above check is redundant. This change removes it. Reported-by: Dan Carpenter <dan.c

[PATCH v1 1/1] scsi: ufs-qcom: remove redundant condition check

->testbus.select_minor); 1535 return false; 1536 } 1537 1538 return true; 1539 } --- As data type of "select_minor" is u8, above check is redundant. This change removes it. Reported-by: Dan Carpenter Signed-off-by: Subhash Jadavani --- dr

[PATCH v1 8/8] scsi: ufs: dump hw regs on link failures

From: Venkat Gopalakrishnan <venk...@codeaurora.org> Dump host state, power info and host/vendor specific registers on link failures. This provides useful info to debug the failures. Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Subhash Jad

[PATCH v1 8/8] scsi: ufs: dump hw regs on link failures

From: Venkat Gopalakrishnan Dump host state, power info and host/vendor specific registers on link failures. This provides useful info to debug the failures. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 12 +++- 1 file changed

[PATCH v1 7/8] scsi: ufs-qcom: dump additional testbus registers

<venk...@codeaurora.org> Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/scsi/ufs/ufs-qcom.c | 48 +++-- drivers/scsi/ufs/ufs-qcom.h | 1 + 2 files changed, 43 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/ufs/ufs-qcom.c b/dr

[PATCH v1 6/8] scsi: ufs: kick start clock scaling only after device detection

UFS clock scaling might start kicking in even before the device is running at the fastest interface speed which is undesirable. This change moves the clock scaling kick start only after the device is detected and running at the fastest interface speed. Signed-off-by: Subhash Jadavani <su

[PATCH v1 7/8] scsi: ufs-qcom: dump additional testbus registers

From: Venkat Gopalakrishnan Change testbus default config, dump additional testbus registers along with other debug vendor specific registers. These additional info are useful in debugging link related failures. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani --- drivers

[PATCH v1 6/8] scsi: ufs: kick start clock scaling only after device detection

UFS clock scaling might start kicking in even before the device is running at the fastest interface speed which is undesirable. This change moves the clock scaling kick start only after the device is detected and running at the fastest interface speed. Signed-off-by: Subhash Jadavani

[PATCH v1 5/8] scsi: ufs: don't suspend clock scaling during clock gating

-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 185 -- drivers/scsi/ufs/ufshcd.h | 31 +++- 2 files changed, 171 insertions(+), 45 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c

[PATCH v1 5/8] scsi: ufs: don't suspend clock scaling during clock gating

-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 185 -- drivers/scsi/ufs/ufshcd.h | 31 +++- 2 files changed, 171 insertions(+), 45 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 056e912..4f6ba24 100644

[PATCH v1 4/8] scsi: ufs: add host state prints in failure cases

driver will contribute to analysis efforts. Added prints of various fields in the hba struct which may be of interest. Signed-off-by: Gilad Broner <gbro...@codeaurora.org> Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 25 +++

[PATCH v1 4/8] scsi: ufs: add host state prints in failure cases

efforts. Added prints of various fields in the hba struct which may be of interest. Signed-off-by: Gilad Broner Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi

[PATCH v1 3/8] scsi: ufs: add load based scaling of UFS gear

to scale gear between HS-G3 and HS-G1 based on same existing load based clock scaling logic. Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 594 -- drivers/scsi/ufs/ufshcd.h | 9 + 2 files changed, 428 inse

[PATCH v1 3/8] scsi: ufs: add load based scaling of UFS gear

to scale gear between HS-G3 and HS-G1 based on same existing load based clock scaling logic. Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 594 -- drivers/scsi/ufs/ufshcd.h | 9 + 2 files changed, 428 insertions(+), 175 deletions(-) diff

[PATCH v1 2/8] scsi: ufs: reduce printout for aborted requests

inimal details for other subsequent requests. Signed-off-by: Gilad Broner <gbro...@codeaurora.org> Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 46 -- drivers/scsi/ufs/ufshcd.h | 3 +++ 2 files chan

[PATCH v1 2/8] scsi: ufs: reduce printout for aborted requests

subsequent requests. Signed-off-by: Gilad Broner Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 46 -- drivers/scsi/ufs/ufshcd.h | 3 +++ 2 files changed, 35 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi

[PATCH v1 1/8] scsi: ufs: skip request abort task when previous aborts failed

Signed-off-by: Gilad Broner <gbro...@codeaurora.org> Signed-off-by: Subhash Jadavani <subha...@codeaurora.org> --- drivers/scsi/ufs/ufshcd.c | 20 drivers/scsi/ufs/ufshcd.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers

[PATCH v1 1/8] scsi: ufs: skip request abort task when previous aborts failed

Signed-off-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 20 drivers/scsi/ufs/ufshcd.h | 3 +++ 2 files changed, 23 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index a70bf06..61fea17 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b

Re: [PATCH 4/4] phy: qcom-ufs: Suppress extraneous logging

when this occur. Cc: Subhash Jadavani <subha...@codeaurora.org> Cc: Vivek Gautam <vivek.gau...@codeaurora.org> Signed-off-by: Bjorn Andersson <bjorn.anders...@linaro.org> --- drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++ drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++-

Re: [PATCH 4/4] phy: qcom-ufs: Suppress extraneous logging

when this occur. Cc: Subhash Jadavani Cc: Vivek Gautam Signed-off-by: Bjorn Andersson --- drivers/phy/phy-qcom-ufs-qmp-14nm.c | 15 +++ drivers/phy/phy-qcom-ufs-qmp-20nm.c | 12 ++-- 2 files changed, 5 insertions(+), 22 deletions(-) diff --git a/drivers/phy/phy-qcom-ufs-qmp

  1   2   3   4   >