Hi Mike,
Do you have any comments about this patch?
The patch is needed to provide a clean fix for recently
broken support for HDMI on Exynos4210 SoC in mainline.
Regards,
Tomasz Stanislawski
On 05/01/2014 12:19 AM, Tomasz Figa wrote:
> Mike,
>
> On 08.04.2014 17:45, Tomasz Figa wro
er, there was a very strong opposition from DT maintainers
to adding any bit related configuration to DT.
The current solution was designed to be a trade-off between
being generic and being accepted :).
Regards,
Tomasz Stanislawski
>> Cheers
>> Kishon
>
--
To unsubscribe fr
On 05/04/2014 01:17 AM, Greg KH wrote:
> On Fri, Apr 11, 2014 at 01:48:28PM +0200, Tomasz Stanislawski wrote:
>> Hi everyone,
>> This patchset adds support for sii9234 HD Mobile Link Bridge. The chip is
>> used
>> to convert HDMI signal into MHL. The driver enabl
Hi Rahul,
I will prepare we v3 version.
Do you want me to add your patches for exynos5?50 to the patchset?
Regards,
Tomasz Stanislawski
On 04/30/2014 08:37 AM, Rahul Sharma wrote:
> Hi Tomasz,
>
> I have tested your patches for exynos5250 and 5420. Works fine. Are
> you planning to
This patch adds missing pinctrls for I2C controllers 2-7.
Signed-off-by: Tomasz Stanislawski
---
arch/arm/boot/dts/exynos4.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 0401f4d..288aa81 100644
--- a
The i2c_ak8975 controler uses label i2c8.
This alias is already used for I2C controller 8 defined
in file arch/arm/boot/dts/exynos4.dtsi.
This patch renames a label for i2c_ak8975 to i2c9.
Signed-off-by: Tomasz Stanislawski
---
arch/arm/boot/dts/exynos4412-trats2.dts |2 +-
1 file changed
re welcome.
Regards,
Tomasz Stanislawski
References:
[1]
https://github.com/junpei0824/SC02C-linux/tree/master-jelly-cm-aokp/drivers/media/video/mhl
Tomasz Stanislawski (2):
misc: add sii9234 driver
arm: dts: trats2: add SiI9234 node
Documentation/devicetree/bindings/sii9234.txt | 22 +
Add driver for HDMI bridge using MHL connection.
Contains refactored code for MHL driver developed by:
Adam Hampson
Erik Gilling
Shankar Bandal
Dharam Kumar
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Kyungmin Park
---
Documentation/devicetree/bindings/sii9234.txt | 22 +
drivers
This patch adds configuration of SiI9234 bridge to Trats2 board.
Signed-off-by: Tomasz Stanislawski
---
arch/arm/boot/dts/exynos4412-trats2.dts | 43 +++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts
b/arch/arm/boot/dts
Hi Rahul,
On 04/09/2014 11:12 AM, Rahul Sharma wrote:
> Hi Tomasz,
>
> On 9 April 2014 14:07, Andrzej Hajda wrote:
>> Hi Tomasz,
>>
>> On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote:
>>> Add exynos-simple-phy driver to support a single register
>&
used as far as I know.
Regards,
Tomasz Stanislawski
On 04/09/2014 12:30 PM, Andrzej Hajda wrote:
> Hi Tomasz,
>
> On 04/08/2014 04:37 PM, Tomasz Stanislawski wrote:
>> The HDMIPHY (physical interface) is controlled by a single
>> bit in a power controller's regiter. It w
The HDMIPHY (physical interface) is controlled by a single
bit in a power controller's regiter. It was implemented
as clock. It was a simple but effective hack.
This patch makes S5P-HDMI driver to control HDMIPHY via PHY interface.
Signed-off-by: Tomasz Stanislawski
---
drivers/media/pla
el.samsung-soc/28617/focus=28648
* create a dedicated power domain for hdmiphy
Regards,
Tomasz Stanislawski
Changelog:
v2:
* rename to exynos-simple-phy
* fix usage of devm_ioremap()
* add documentation for DT bindings
* add patches to client drivers
v1: ini
Add exynos-simple-phy driver to support a single register
PHY interfaces present on Exynos4 SoC.
Signed-off-by: Tomasz Stanislawski
---
.../devicetree/bindings/phy/samsung-phy.txt| 24 +++
drivers/phy/Kconfig|5 +
drivers/phy/Makefile
The HDMIPHY (physical interface) is controlled by a single
bit in a power controller's regiter. It was implemented
as clock. It was a simple but effective hack.
This patch makes HDMI driver to control HDMIPHY via PHY interface.
Signed-off-by: Tomasz Stanislawski
---
drivers/gpu/drm/e
lly, this patch adds CLK_SET_PARENT_PARENT (sorry for naming) flag to
inform clk-core that clk_set_parent() should be propagated.
Signed-off-by: Tomasz Stanislawski
---
drivers/clk/clk.c|6 ++
include/linux/clk-provider.h |1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/clk
This reverts commit 59956d35a8618235ea715280b49447bb36f2c975.
Signed-off-by: Tomasz Stanislawski
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos
Export sclk_hdmiphy clock to be usable from DT.
Signed-off-by: Tomasz Stanislawski
---
drivers/clk/samsung/clk-exynos4.c |2 +-
include/dt-bindings/clock/exynos4.h |1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/samsung/clk-exynos4.c
b/drivers/clk
This patch enables clk_set_parent() propagation for clocks used
by s5p-tv and exynos-drm drivers.
Signed-off-by: Tomasz Stanislawski
---
drivers/clk/samsung/clk-exynos4.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos4.c
b/drivers
s clock
directly and clk_set_parent() is propagated to mout_hdmi.
This new behaviour does not break DT bindings because mout_hdmi would be simply
ignored.
After this change the 'add mout_hdmi clock' is no longer needed.
Regards,
Tomasz Stanislawski
Tomasz Stanislawski (4):
clk: propagate pa
Add exynos-phy driver to support a single register
PHY interfaces present on Exynos4 SoC.
Signed-off-by: Tomasz Stanislawski
Signed-off-by: Kyungmin Park
---
drivers/phy/Kconfig |5 ++
drivers/phy/Makefile |1 +
drivers/phy/exynos-phy.c | 152
d driver that export clocks/phys/etc that are controlled by PMU
unit.
Regards,
Tomasz Stanislawski
Tomasz Stanislawski (1):
phy: Add exynos-phy driver
drivers/phy/Kconfig |5 ++
drivers/phy/Makefile |1 +
drivers/phy/exynos-phy.c | 152 +++
lly, this patch adds CLK_SET_PARENT_PARENT (sorry for naming) flag to
inform clk-core that clk_set_parent() should be propagated.
Signed-off-by: Tomasz Stanislawski
---
drivers/clk/clk.c|6 ++
include/linux/clk-provider.h |1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/clk
Hi,
Please refer to the comments below.
On 10/24/2013 05:52 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 21 October 2013 07:48 PM, Tomasz Stanislawski wrote:
>> Add simple-phy driver to support a single register
>> PHY interfaces present on Exynos4 SoC.
>
> H
Use default handler of_phy_simple_xlate() when NULL is passed as argument to
of_phy_provider_register().
Signed-off-by: Tomasz Stanislawski
---
drivers/phy/phy-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index
This patch enables clk_set_parent() propagation for clocks used
by s5p-tv and exynos-drm drivers.
Signed-off-by: Tomasz Stanislawski
---
drivers/clk/samsung/clk-exynos4.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/samsung/clk-exynos4.c
b/drivers
This patch eliminates redundant checks while retrieving HPD gpio from DT during
HDMI's probe().
Signed-off-by: Tomasz Stanislawski
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi
The HDMIPHY (physical interface) is controlled by a single
bit in a power controller's regiter. It was implemented
as clock. It was a simple but effective hack.
This patch makes HDMI driver to control HDMIPHY via PHY interface.
Signed-off-by: Tomasz Stanislawski
---
drivers/gpu/drm/e
This reverts commit 59956d35a8618235ea715280b49447bb36f2c975.
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index a0e10ae..fcfa23a 100644
--
This patch adds DT nodes for HDMI related devices on SoCs from Exynos4 family.
Signed-off-by: Tomasz Stanislawski
---
arch/arm/boot/dts/exynos4.dtsi| 27 +++
arch/arm/boot/dts/exynos4210.dtsi |4
2 files changed, 31 insertions(+)
diff --git a/arch/arm
This patch add proper compatibles for Mixer and HDMI chip
available on exynos4210 SoCs.
Signed-off-by: Tomasz Stanislawski
---
drivers/gpu/drm/exynos/exynos_hdmi.c |3 +++
drivers/gpu/drm/exynos/exynos_mixer.c |3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/gpu/drm
This patch adds configuration of HDMI devices on Universal C210 board.
Signed-off-by: Tomasz Stanislawski
---
arch/arm/boot/dts/exynos4210-universal_c210.dts | 53 +++
1 file changed, 53 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts
b/arch
This patch adds DT nodes for I2C controller dedicated for HDMIPHY.
Signed-off-by: Tomasz Stanislawski
---
arch/arm/boot/dts/exynos4.dtsi | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index caadc02..a5f6b8b
Add simple-phy driver to support a single register
PHY interfaces present on Exynos4 SoC.
Signed-off-by: Tomasz Stanislawski
---
drivers/phy/Kconfig |5 ++
drivers/phy/Makefile |1 +
drivers/phy/phy-simple.c | 128 ++
3 files changed
lly, this patch adds CLK_SET_PARENT_PARENT (sorry for naming) flag to
inform clk-core that clk_set_parent() should be propagated.
Signed-off-by: Tomasz Stanislawski
---
drivers/clk/clk.c|6 ++
include/linux/clk-provider.h |1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/clk
Export sclk_hdmiphy clock to be usable from DT.
Signed-off-by: Tomasz Stanislawski
---
.../devicetree/bindings/clock/exynos4-clock.txt|1 +
drivers/clk/samsung/clk-exynos4.c |4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation
latform register.
This situation is very common in Exynos SoCs. The current version supports
only one phy per node. The code might be modified to support multiple phys
from single simple-phy provider to avoid creation of multiple nodes in DT.
All comments are welcome.
Regards,
Tomasz Stanislawsk
>From c8e5d14b1e7a010695d87b60759aeeacdf9e599a Mon Sep 17 00:00:00 2001
From: Tomasz Stanislawski
Date: Tue, 1 Oct 2013 10:34:35 +0200
Subject: [PATCH] klist: fix a typo in klist_iter_init()
Fix a typo in comments for klist_iter_init().
Signed-off-by: Tomasz Stanislawski
---
lib/klis
On 09/25/2013 11:57 PM, Seth Jennings wrote:
> On Wed, Sep 25, 2013 at 07:09:50PM +0200, Tomasz Stanislawski wrote:
>>> I just had an idea this afternoon to potentially kill both these birds with
>>> one
>>> stone: Replace the rbtree in zswap with an address_space
are two swap offset pointing to
the same page. There might be more if zsmalloc is used.
What is worse it is possible that one swap entry could
point to data that cross a page boundary.
Of course, one could try to modify MM to support
multiple mapping of a page in the radix tree.
But I think that MM
> didn`t support it.
> Without it Common Clock Framework prints a warning.
>
> Signed-off-by: Mateusz Krawczuk
> Signed-off-by: Kyungmin Park
Acked-by: Tomasz Stanislawski
> ---
> drivers/media/platform/s5p-tv/mixer_drv.c | 34
> +--
>
Rename to 'media: s5p-tv: sdo: integrate with CCF'
On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote:
> Replace clk_enable by clock_enable_prepare and clk_disable with
> clk_disable_unprepare.
> Clock prepare is required by Clock Common Framework, and old clock driver
> didn`t support it.
> Without
Hi,
As you can see sdo, hdmi and mixer are saparate drivers that are
parts of s5p-tv drivers set. Could you rename commit name to
'media: s5p-tv: sdo: Restore vpll clock rate after streamoff'
On 09/21/2013 05:00 PM, Mateusz Krawczuk wrote:
> Restore vpll clock rate if start stream fail or stream
On 09/23/2013 07:44 PM, Joe Perches wrote:
> On Mon, 2013-09-23 at 17:48 +0200, Bartlomiej Zolnierkiewicz wrote:
>> On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote:
>>> May I ask what is the rationale for this patch?
>>> To reduce a few lines of code?
Hi,
On 09/23/2013 05:48 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Tomasz,
>
> On Monday, September 23, 2013 04:50:01 PM Tomasz Stanislawski wrote:
>> Hello,
>> May I ask what is the rationale for this patch?
>> To reduce a few lines of code?
>
> This patch
Hello,
May I ask what is the rationale for this patch?
To reduce a few lines of code?
Or to give up possibility of changing message format in just one place?
I could see migrating from mxr_* to pr_* could seen as the fix, but not this.
Waiting for reply,
Tomasz Stanislawski
On 09/21/2013 05:00
On 08/02/2013 01:58 AM, Casey Schaufler wrote:
> On 6/27/2013 2:11 PM, Casey Schaufler wrote:
>> On 6/11/2013 5:55 AM, Tomasz Stanislawski wrote:
>>> This patch adds a hash table to quicken searching of a smack label by its
>>> name.
>>>
>>> Basic
ind this patchset useful.
All comments are welcome.
Regards,
Tomasz Stanislawski.
Changelog:
v1:
- post 'fix memleak in smk_write_rules_list() as a separate patch'
- prepare performance measurements
- remove stack allocations for a rule string, use kmalloc()
[1] http://en.it-usenet.or
and it is
very likely to fail.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smackfs.c |5 +
1 file changed, 5 insertions(+)
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 08aebc2..5dcd520 100644
--- a/security/smack/smackfs.c
+++ b/security/smack
-byte-long chunks according to ksize(). This reduces
amount of used memory by 25%.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smack.h |3 +++
security/smack/smack_lsm.c | 11 ++-
security/smack/smackfs.c |2 +-
3 files changed, 14 insertions(+), 2 deletions
smk_parse_substrings() function that parses a string into
substring separated by whitespaces. The buffer for substring is preallocated.
It must store substring the worst case scenario which is SMK_LOAD2LEN in case
of long rule parsing.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smackfs.c
smack_master_list using 16-byte-long chunks according to ksize(). This
reduces amount of used memory by 50%.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smack.h |7 +++
security/smack/smack_lsm.c |8
security/smack/smackfs.c |8 ++--
3 files changed, 17
>From 8497987bedf8821db3dce47a6205dfce2b0895c5 Mon Sep 17 00:00:00 2001
From: Tomasz Stanislawski
Date: Thu, 6 Jun 2013 09:30:50 +0200
Subject: [PATCH] security: smack: fix memleak in smk_write_rules_list()
The smack_parsed_rule structure is allocated. If a rule is successfully
installed t
Hi Casey,
Thank you for the review.
Please refer to the comments below.
On 06/15/2013 09:32 PM, Casey Schaufler wrote:
> On 6/13/2013 8:29 AM, Tomasz Stanislawski wrote:
>> The maximal length for a rule line for long format is introduced as
>> SMK_LOAD2LEN. This allows a buffer fo
ch for label hashing [1] is applied.
I hope you find this patchset useful.
Regards,
Tomasz Stanislawski
References:
[1] http://thread.gmane.org/gmane.linux.kernel.lsm/19609
Tomasz Stanislawski (5):
security: smack: avoid kmalloc allocations while loading a rule
string
security: smack
().
Signed-off-by: Tomasz Stanislawski
---
security/smack/smackfs.c | 67 +++---
1 file changed, 33 insertions(+), 34 deletions(-)
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 9a3cd0d..46f111e 100644
--- a/security/smack
user calls write() for a very long chunk.
Such an allocation often causes a lot swapper/writeback havoc and it is very
likely to fails.
Moreover, stack allocation is slightly faster than from kmalloc.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smackfs.c | 15 ++-
1 file
smack_master_list using 16-byte-long chunks according to ksize(). This
reduces amount of used memory by 50%.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smack.h |7 +++
security/smack/smack_lsm.c |8
security/smack/smackfs.c |8 ++--
3 files changed, 17
: Tomasz Stanislawski
---
security/smack/smackfs.c | 30 ++
1 file changed, 10 insertions(+), 20 deletions(-)
diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 46f111e..e8c57f3 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
-byte-long chunks according to ksize(). This reduces
amount of used memory by 25%.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smack.h |3 +++
security/smack/smack_lsm.c | 11 ++-
security/smack/smackfs.c |2 +-
3 files changed, 14 insertions(+), 2 deletions
Hi Casey,
Thank you for your review.
Please refer to comments below.
On 06/12/2013 07:11 AM, Casey Schaufler wrote:
> On 6/11/2013 5:55 AM, Tomasz Stanislawski wrote:
>> This patch adds a hash table to quicken searching of a smack label by its
>> name.
>>
>> Ba
- drop Dan Bernstein hash function in favor of more standard full_name_hash
- adjust the number of hash slots basing on measurements
Regards,
Tomasz Stanislawski
Tomasz Stanislawski (1):
security: smack: add a hash table to quicken smk_find_entry()
security/smack/smack.h|5 +
secu
.693 | 0.666 | 0.653 | 0.641 | 0.633 |
0.630 | 0.627
Surprisingly, a single hlist is slightly faster than a double-linked list.
The speed-up saturates near 64 slots. Therefore I chose value 128 to provide
some margin if more labels were used.
It looks that IO becomes a new bottleneck.
Signed-off-by:
additional 4kiB
memory for the hash table.
Signed-off-by: Tomasz Stanislawski
---
security/smack/smack.h|5 +
security/smack/smack_access.c | 33 +++--
security/smack/smack_lsm.c| 21 +++--
3 files changed, 51 insertions(+), 8
_entry overhead was
reduced to mere 0.05% of CPU cycles.
I hope you find the measurement and the patch useful.
All comments are welcome.
Regards,
Tomasz Stanislawski
Tomasz Stanislawski (1):
security: smack: add hash table for smack for quick label searching
security/smack/smack.
s
> follows: (http://coccinelle.lip6.fr/)
>
> //
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
Hi Greg,
On 08/09/2012 04:23 PM, Greg KH wrote:
> On Thu, Aug 09, 2012 at 11:36:21AM +0200, Tomasz Stanislawski wrote:
>> This patch adds reference counting on a module that exported dma-buf and
>> implements its operations. This prevents the module from being unloaded while
>&
This patch sets owner field in DMABUF operations for all DMABUF exporters in
DRM subsystem. This prevents an exporting module from being unloaded while
exported DMABUF descriptor is in use.
Signed-off-by: Tomasz Stanislawski
Acked-by: Sumit Semwal
Acked-by: Daniel Vetter
---
drivers/gpu/drm
This patch adds reference counting on a module that exported dma-buf and
implements its operations. This prevents the module from being unloaded while
DMABUF file is in use.
Signed-off-by: Tomasz Stanislawski
Acked-by: Sumit Semwal
Acked-by: Daniel Vetter
CC: linux-...@vger.kernel.org
Hello,
This patchset adds reference counting for an exporter module to DMABUF
framework. Moreover, it adds setup of an owner field for exporters in DRM
subsystem.
v1: Original
v2:
- split patch into DMABUF and DRM part
- allow owner to be NULL
Regards,
Tomasz Stanislawski
Tomasz
Hi Laurent,
On 08/08/2012 03:35 PM, Laurent Pinchart wrote:
> Hi Tomasz,
>
> Thanks for the patch.
>
> On Wednesday 08 August 2012 12:17:41 Tomasz Stanislawski wrote:
>> This patch adds reference counting on a module that exports dma-buf and
>> implements its op
This patch adds reference counting on a module that exports dma-buf and
implements its operations. This prevents the module from being unloaded while
DMABUF file is in use.
Signed-off-by: Tomasz Stanislawski
---
Documentation/dma-buf-sharing.txt |3 ++-
drivers/base/dma-buf.c
On 08/06/2012 01:58 PM, Michal Nazarewicz wrote:
>
> Tomasz Stanislawski writes:
>> I recommend to change the semantics for unlimited number of segments
>> from 'value 0' to:
>>
>> #define DMA_SEGMENTS_COUNT_UNLIMITED ((unsigned lon
r:
int dma_buf_get_parameters(struct dma_buf *dmabuf,
struct device_dma_parameters *params);
This function will fill *params with lowest common DMA requirements for
all devices on attachment list. Return value can be used to diagnose
errors like incorrectly initialized dma_buf pointer
(like
74 matches
Mail list logo
