Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Vaibhav Hiremath
On Monday 19 September 2016 01:16 PM, Peter Chen wrote: On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote: On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote: [...] We had an agreement that keep mmc's pwrseq framework unchanging. Unless Ulf and rob both agree to c

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-19 Thread Vaibhav Hiremath
On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote: [...] We had an agreement that keep mmc's pwrseq framework unchanging. Unless Ulf and rob both agree to change. Why 2 separate approach for same problem ? And I see this as possible duplication of code/functionality :) How the new ker

Re: [PATCH v6 0/8] power: add power sequence library

2016-09-06 Thread Vaibhav Hiremath
a On Friday 02 September 2016 06:40 AM, Peter Chen wrote: On Wed, Aug 31, 2016 at 10:28:20PM +0530, Vaibhav Hiremath wrote: On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote: On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote: On Monday 29 August 2016 04:40 PM, Peter Chen

Re: [PATCH v6 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-05 Thread Vaibhav Hiremath
On Friday 02 September 2016 06:30 AM, Peter Chen wrote: On Thu, Sep 01, 2016 at 01:33:22PM +0530, Vaibhav Hiremath wrote: On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by

Re: [PATCH v6 2/8] power: add power sequence library

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: We have an well-known problem that the device needs to do some power sequence before it can be recognized by related host, the typical example like hard-wired mmc devices and usb devices. This power sequence is hard to be described at device

Re: [PATCH v6 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Add binding doc for generic power sequence library. Signed-off-by: Peter Chen Acked-by: Philipp Zabel Acked-by: Rob Herring --- .../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++ 1 file changed, 48 insertio

Re: [PATCH v6 4/8] usb: core: add power sequence handling for USB devices

2016-09-01 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Some hard-wired USB devices need to do power sequence to let the device work normally, the typical power sequence like: enable USB PHY clock, toggle reset pin, etc. But current Linux USB driver lacks of such code to do it, it may cause some h

Re: [PATCH v6 0/8] power: add power sequence library

2016-08-31 Thread Vaibhav Hiremath
On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote: On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote: On Monday 29 August 2016 04:40 PM, Peter Chen wrote: On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote: On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav

Re: [PATCH v6 0/8] power: add power sequence library

2016-08-31 Thread Vaibhav Hiremath
On Monday 29 August 2016 04:40 PM, Peter Chen wrote: On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote: On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav Hiremath wrote: On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence

Re: [PATCH v6 0/8] power: add power sequence library

2016-08-23 Thread Vaibhav Hiremath
On Monday 15 August 2016 02:43 PM, Peter Chen wrote: Hi all, This is a follow-up for my last power sequence framework patch set [1]. According to Rob Herring and Ulf Hansson's comments[2], I use a generic power sequence library for parsing the power sequence elements on DT, and implement gener

Re: [PATCH] USB: core: of: Check device_node before parsing in usb_of_get_child_node()

2016-08-16 Thread Vaibhav Hiremath
On Monday 15 August 2016 06:33 PM, Peter Chen wrote: On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote: In case of HUB devices connected to USB ports, we may not have DT node representing it inside USB, and when devices connected to hub gets enumerated, call to

Re: [PATCH] USB: core: of: Check device_node before parsing in usb_of_get_child_node()

2016-08-15 Thread Vaibhav Hiremath
On Monday 15 August 2016 11:41 AM, Greg KH wrote: On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote: In case of HUB devices connected to USB ports, we may not have DT node representing it inside USB, and when devices connected to hub gets enumerated, call to

[PATCH] USB: core: of: Check device_node before parsing in usb_of_get_child_node()

2016-08-15 Thread Vaibhav Hiremath
> Call to usb_of_get_child_node() leads to NULL pointer dereference as parent->dev.of_node = NULL, as USB HUB DTS node may be empty. Fix this NULL pointer dereference by adding check for pointer device_node inside usb_of_get_child_node() fn. Signed-off-by: Vaibhav Hiremath ---

Re: [RFD] Sharing GPIOs for input (buttons) and output (LEDs)

2016-03-22 Thread Vaibhav Hiremath
On Thursday 17 March 2016 03:48 PM, Linus Walleij wrote: On Mon, Feb 22, 2016 at 1:14 PM, Geert Uytterhoeven wrote: On the Renesas Salvator-X development board, 3 GPIO pins are connected to both push buttons and LEDs. Not exactly related to buttons and leds, but recently I came across anot

Re: [PATCH-v2 0/3] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-15 Thread Vaibhav Hiremath
On Tuesday 15 September 2015 05:58 PM, Ulf Hansson wrote: On 7 September 2015 at 13:31, Vaibhav Hiremath wrote: Trivial patch-series, which fixes the tabbing issue in the driver, uses the BIT macro for bit fields and prints notice on -EPROBE_DEFER in sdhci_add_host() function on regulator

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 06:11 PM, Vaibhav Hiremath wrote: On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote: On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote: On 14 September 2015 at 11:42, Vaibhav Hiremath wrote: On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-14 Thread Vaibhav Hiremath
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote: [...] Could this be implemented by regulator API? From patch set 3/3, the pxa1928 voltage_switch hook is to operate the IO pad registers, this seems not belong to the SDHC IP core. Not quite sure whether regulator would be right fit

Re: [PATCH-v5 RESEND 3/5] i2c: pxa: Add support for pxa910/988 & new configuration features

2015-09-13 Thread Vaibhav Hiremath
On Saturday 12 September 2015 12:36 AM, Wolfram Sang wrote: On Mon, Aug 24, 2015 at 11:29:36AM +0530, Vaibhav Hiremath wrote: TWSI_ILCR & TWSI_IWCR registers are used to adjust clock rate of standard & fast mode in pxa910/988; so this patch adds these two new entries to "struct p

Re: [PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-09-13 Thread Vaibhav Hiremath
On Saturday 12 September 2015 12:23 AM, Wolfram Sang wrote: On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote: From: Yi Zhang Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the slave d

Re: [PATCH-v2 2/7] mmc: sdhci-pxav3: binding: Add pxa1928 compatible support

2015-09-09 Thread Vaibhav Hiremath
On Wednesday 09 September 2015 05:19 AM, Rob Herring wrote: On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote: With support for pxa1928 family of devices , this patch updates the binding document with compatible property of "marvell,pxav3-1928-sdhci". Signed-off-by: Vaibha

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-08 Thread Vaibhav Hiremath
On Tuesday 08 September 2015 08:12 PM, Linus Walleij wrote: On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee signal

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-08 Thread Vaibhav Hiremath
On Tuesday 08 September 2015 03:34 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:32:34 +0530 Vaibhav Hiremath wrote: On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath wrote: static const struct sdhci_ops

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-08 Thread Vaibhav Hiremath
On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote: On Tue, 8 Sep 2015 15:04:41 +0530 Vaibhav Hiremath wrote: On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-08 Thread Vaibhav Hiremath
On Tuesday 08 September 2015 12:24 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee

Re: [PATCH-v2 5/7] mmc: sdhci-pxav3: Fix HS200 mode support

2015-09-08 Thread Vaibhav Hiremath
On Tuesday 08 September 2015 12:23 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:39 +0530 Vaibhav Hiremath wrote: From: Kevin Liu IN case of MMC HS200 mode, current code does not enable SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations. So this patch updates the a

Re: [PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-08 Thread Vaibhav Hiremath
On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 16:48:38 +0530 Vaibhav Hiremath wrote: Different bus clock may need different pin setting. For example, fast bus clock like 208Mhz need pin drive fast while slow bus clock prefer pin drive slow to guarantee

Re: [PATCH-v2 1/3] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-07 Thread Vaibhav Hiremath
On Monday 07 September 2015 05:26 PM, Jisheng Zhang wrote: On Mon, 7 Sep 2015 17:01:09 +0530 Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

[PATCH-v2 3/3] mmc: sdhci: print notice on -EPROBE_DEFER in sdhci_add_host() fn

2015-09-07 Thread Vaibhav Hiremath
This patch adds kernel notice/message to sdhci_host_add() fn on -EPROBE_DEFER. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1dbe932..37a5cd5 100644

[PATCH-v2 1/3] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-07 Thread Vaibhav Hiremath
There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc... This patch fixes all such occurrences in the code. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 46

[PATCH-v2 0/3] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-07 Thread Vaibhav Hiremath
age patch into new one. - changed error to kernel notice for EPROBE_DEFER in sdhci_add_host() Note: This patch-series should get merged before another series - [PATCH-v2 0/7] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller Vaibhav Hiremath (3): mmc: sdhci-pxav3: Fix tabbing is

[PATCH-v2 2/3] mmc: sdhci-pxav3: Use BIT macro for bit field definitions

2015-09-07 Thread Vaibhav Hiremath
Instead of using shift operation use BIT macro for bit field definitions. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index 7a07177

[PATCH-v2 1/7] mmc: sdhci-pxav3: Enable pxa1928 device support

2015-09-07 Thread Vaibhav Hiremath
more differences, which would be added as and when respective feature gets added to the driver. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 62 ++ 1 file changed, 51 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sdhci

[PATCH-v2 4/7] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-07 Thread Vaibhav Hiremath
speed. And selection of pin state is done based on timing mode. Signed-off-by: Vaibhav Hiremath Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci-pxav3.c | 45 +- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3

[PATCH-v2 2/7] mmc: sdhci-pxav3: binding: Add pxa1928 compatible support

2015-09-07 Thread Vaibhav Hiremath
With support for pxa1928 family of devices , this patch updates the binding document with compatible property of "marvell,pxav3-1928-sdhci". Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH-v2 6/7] mmc: sdhci: add new quirk for setting BUS_POWER & BUS_VLT fields

2015-09-07 Thread Vaibhav Hiremath
quirk (SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER), which make sure that ->set_power() sets these fields. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pltfm.c | 3 +++ drivers/mmc/host/sdhci.c | 3 ++- drivers/mmc/host/sdhci.h | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(

[PATCH-v2 5/7] mmc: sdhci-pxav3: Fix HS200 mode support

2015-09-07 Thread Vaibhav Hiremath
From: Kevin Liu IN case of MMC HS200 mode, current code does not enable SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations. So this patch updates the above bit fields correctly. Signed-off-by: Tim Wang Signed-off-by: Kevin Liu Signed-off-by: Vaibhav Hiremath ---

[PATCH-v2 7/7] mmc: sdhci: enable SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON for pxa1928

2015-09-07 Thread Vaibhav Hiremath
Card power is dependent on bus power, without that card wouldn't respond (No CARD_INT). So this patch enables the quirk SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pltfm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

[PATCH-v2 3/7] mmc: sdhci-pxav3: Add platform specific set_clock ops

2015-09-07 Thread Vaibhav Hiremath
controller/platform specific clock configuration needs to be executed. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdh

[PATCH-v2 0/7] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller

2015-09-07 Thread Vaibhav Hiremath
ix HS200 mode support Vaibhav Hiremath (6): mmc: sdhci-pxav3: Enable pxa1928 device support mmc: sdhci-pxav3: binding: Add pxa1928 compatible support mmc: sdhci-pxav3: Add platform specific set_clock ops mmc: sdhci-pxav3: Add pinctl setting according to bus clock mmc: sdhci: add new quir

Re: [PATCH 0/5] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller

2015-09-07 Thread Vaibhav Hiremath
On Friday 04 September 2015 09:02 PM, Vaibhav Hiremath wrote: PXA1928 SDHCI controller has few differences, for example, PXAxxxPXA1928 ===== SDCLK_DELAY field 0x10A

[PATCH 5/5] mmc: sdhci: add new quirk for setting BUS_POWER & BUS_VLT fields

2015-09-04 Thread Vaibhav Hiremath
quirk (SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER), which make sure that ->set_power() sets these fields. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pltfm.c | 3 +++ drivers/mmc/host/sdhci.c | 3 ++- drivers/mmc/host/sdhci.h | 2 ++ 3 files changed, 7 insertions(+), 1 deletion(

[PATCH 3/5] mmc: sdhci-pxav3: Add pinctl setting according to bus clock

2015-09-04 Thread Vaibhav Hiremath
speed. And selection of pin state is done based on timing mode. Signed-off-by: Vaibhav Hiremath Signed-off-by: Kevin Liu --- drivers/mmc/host/sdhci-pxav3.c | 45 +- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3

[PATCH 4/5] mmc: sdhci-pxav3: Fix HS200 mode support

2015-09-04 Thread Vaibhav Hiremath
From: Kevin Liu IN case of MMC HS200 mode, current code does not enable SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations. So this patch updates the above bit fields correctly. Signed-off-by: Tim Wang Signed-off-by: Kevin Liu Signed-off-by: Vaibhav Hiremath ---

[PATCH 1/5] mmc: sdhci-pxav3: Enable pxa1928 device support

2015-09-04 Thread Vaibhav Hiremath
more differences, which would be added as and when respective feature gets added to the driver. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 62 ++ 1 file changed, 51 insertions(+), 11 deletions(-) diff --git a/drivers/mmc/host/sdhci

[PATCH 2/5] mmc: sdhci-pxav3: Add platform specific set_clock ops

2015-09-04 Thread Vaibhav Hiremath
controller/platform specific clock configuration needs to be executed. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 46 +- 1 file changed, 45 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdh

[PATCH 0/5] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller

2015-09-04 Thread Vaibhav Hiremath
(1): mmc: sdhci-pxav3: Fix HS200 mode support Vaibhav Hiremath (4): mmc: sdhci-pxav3: Enable pxa1928 device support mmc: sdhci-pxav3: Add platform specific set_clock ops mmc: sdhci-pxav3: Add pinctl setting according to bus clock mmc: sdhci: add new quirk for setting BUS_POWER &

Re: [RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-03 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote: On 2015/9/2 3:32, Vaibhav Hiremath wrote: In case PXA1928 family of devices, there is device/controller specific configuration to control voltage/power on the IO pins. This patch implements and enables the sdhci_ops->voltage_swi

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote: On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote: On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the

Re: [RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote: On 2015/9/2 3:32, Vaibhav Hiremath wrote: In case PXA1928 family of devices, there is device/controller specific configuration to control voltage/power on the IO pins. This patch implements and enables the sdhci_ops->voltage_swi

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c @@ -455,7

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 01:56 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 13:49:53 +0530 Vaibhav Hiremath wrote: On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the

Re: [RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:34 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 01:02:17 +0530 Vaibhav Hiremath wrote: Currently, the sdhci_do_start_signal_voltage_switch() function invokes controller specific voltage switch configuration only for 1.8v usecase; but it is required for

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-02 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 12:24 PM, Jisheng Zhang wrote: On Wed, 2 Sep 2015 00:54:13 +0530 Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

Re: [PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device

2015-09-01 Thread Vaibhav Hiremath
On Monday 24 August 2015 11:29 AM, Vaibhav Hiremath wrote: Sorry for not following up on this aggressively, was quit busy with some other stuff. Resending this patch with Robert's Tested-By. This patch-series is subset of the original patch-series, submitted on 14 Jul 2015. Link to Ori

Re: [PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: Return value would give clear information about the actual root-cause of the failure. I'm not sure why that is as nearly every error path in sdhci_add_host emits a me

Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-01 Thread Vaibhav Hiremath
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote: On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc

[RFC 2/3] mmc: sdhci: add host_ops->voltage_switch callback for all other voltages

2015-09-01 Thread Vaibhav Hiremath
support (I/O domain power control register). Signed-off-by: Vaibhav Hiremath --- Note: Currently ->voltage_switch() callback is only supported in f_sdh30 driver. And I am not sure on the dependency of execution sequence for that device. I could have moved ->voltage_switch() call at one common

[RFC 1/3] mmc: sdhci: pass signal_voltage as an argument to voltage_switch callback

2015-09-01 Thread Vaibhav Hiremath
In order to do particular voltage specific configuration in sdhci_ops->voltage_switch() callback function, we need to pass respective voltage value as well. So this patch adds an extra argument for signal voltage to the callback function. Signed-off-by: Vaibhav Hiremath Signed-off-by: Kevin

[RFC 3/3] mmc: sdhci-pxav3: Add ->voltage_switch callback support

2015-09-01 Thread Vaibhav Hiremath
<0xd401e81c 4>, <0xd4015068 8>; ... }; Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 59 ++ 1 file changed, 59 insertions(+) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci

[RFC 0/3] mmc: sdhci: pass signal voltage as an argument to ->voltage_switch()

2015-09-01 Thread Vaibhav Hiremath
l at one common place (above/below), but was not quite sure about it. So, replicated/duplicated the call for other voltages. Vaibhav Hiremath (3): mmc: sdhci: pass signal_voltage as an argument to voltage_switch callback mmc: sdhci: add host_ops->voltage_switch callback for all other

[PATCH 0/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-01 Thread Vaibhav Hiremath
Trivial patch-series, which fixes the tabbing issue in the driver and second patch prints the return value from sdhci_add_host() function Vaibhav Hiremath (2): mmc: sdhci-pxav3: Fix tabbing issue mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn drivers/mmc/host/sdhci

[PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue

2015-09-01 Thread Vaibhav Hiremath
There were some coding style issues where spaces have been used instead of tabs, for example, in macro definitions, alignment of function declarations/definitions, etc... This patch fixes all such occurrences in the code. And also use BIT for bit definitions. Signed-off-by: Vaibhav Hiremath

[PATCH 2/2] mmc: sdhci-pxav3: Print ret value on error from sdhci_add_host() fn

2015-09-01 Thread Vaibhav Hiremath
Return value would give clear information about the actual root-cause of the failure. Signed-off-by: Vaibhav Hiremath --- drivers/mmc/host/sdhci-pxav3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 04:05 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them

[PATCH-v3 RESEND] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-25 Thread Vaibhav Hiremath
Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked-by: Lee Jones --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2 files changed, 3 insertions(+) diff --git a

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 02:00 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 09:21 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath

Re: [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:28 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: This patch updates the binding documentation for optional clocks node and related information for buffered 32KHz clock. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:22 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 125

Re: [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:25 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Update header file with required macros for 32KHz buffered clock output of 88PM800 family of device. These macros will be used in clk provider driver. Signed-off-by: Vaibhav Hiremath

Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Vaibhav Hiremath wrote: Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. That's not all it's doing though is it? Yes, its just tabbing related fixes.

Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 01:19 PM, Lee Jones wrote: On Tue, 25 Aug 2015, Krzysztof Kozlowski wrote: On 25.08.2015 03:56, Vaibhav Hiremath wrote: This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c

Re: [PATCH-v3] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 12:08 PM, Mark Brown wrote: On Mon, Aug 24, 2015 at 12:32:17PM +0530, Vaibhav Hiremath wrote: On Monday 20 July 2015 05:22 PM, Vaibhav Hiremath wrote: Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Last update/understanding

Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-25 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 10:55 AM, Krzysztof Kozlowski wrote: On 25.08.2015 03:56, Vaibhav Hiremath wrote: This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 25 + 1 file

Re: [PATCH-v3 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-24 Thread Vaibhav Hiremath
On Tuesday 25 August 2015 10:18 AM, Krzysztof Kozlowski wrote: On 24.08.2015 21:40, Vaibhav Hiremath wrote: 88PM860 device supports dual phase mode on BUCK1 output. In normal usecase, BUCK1A and BUCK1B operates independently with 3A capacity. And they both can work as a dual phase providing

[PATCH-v2 4/5] clk: 88pm800: Add clk provider driver for 88pm800 family of devices

2015-08-24 Thread Vaibhav Hiremath
}, + .probe = pm800_clk_probe, + .remove = pm800_clk_remove, + .id_table = pm800_clk_id, +}; + +static int __init pm800_clk_init(void) +{ + return platform_driver_register(&pm800_clk_driver); +} +subsys_initcall(pm800_clk_init); + +static void __exit pm800_clk_cleanu

[PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice

2015-08-24 Thread Vaibhav Hiremath
This patch adds mfd_cell/clk-subdevice for 88PM800 MFD (and family of devices). Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index c4e097d..a928eed 100644

[PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros

2015-08-24 Thread Vaibhav Hiremath
Update header file with required macros for 32KHz buffered clock output of 88PM800 family of device. These macros will be used in clk provider driver. Signed-off-by: Vaibhav Hiremath --- include/linux/mfd/88pm80x.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux

[PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information

2015-08-24 Thread Vaibhav Hiremath
This patch updates the binding documentation for optional clocks node and related information for buffered 32KHz clock. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Documentation/devicetree/bindings/mfd/88pm800.txt | 27 +++ 1

[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-24 Thread Vaibhav Hiremath
Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 125 -- 1 file changed, 61 insertions(+), 64 deletions(-) diff --git a/drivers/mfd

[PATCH-v2 0/5] clk: 88pm800: Add new clk provider driver for 88PM800 MFD

2015-08-24 Thread Vaibhav Hiremath
- Used devm_kcalloc variants for array allocation instead of kzalloc. - Fixed all other trivial issues. Vaibhav Hiremath (5): mfd: 88pm800: Fix tabbing issue mfd: 88pm800: Update the header file with 32K clk related macros mfd: devicetree: bindings: Add clock subdevice node informati

[PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue

2015-08-24 Thread Vaibhav Hiremath
Driver had coding style issues where spaces were used instead of tabs. This patch fixes them all. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 125 -- 1 file changed, 61 insertions(+), 64 deletions(-) diff --git a/drivers/mfd

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 09:21 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath wrote: As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method of

Re: [PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 07:24 PM, Lee Jones wrote: On Wed, 08 Jul 2015, Vaibhav Hiremath wrote: As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe (page 0) controls the method of clearing interrupt status of 88pm800 family of devices; 0: clear on read 1: clear on write If pdata

Re: [PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-08-24 Thread Vaibhav Hiremath
On Monday 24 August 2015 06:32 PM, Lee Jones wrote: On Mon, 24 Aug 2015, Vaibhav Hiremath wrote: 88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch updates the devicetree

[PATCH-v3 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-24 Thread Vaibhav Hiremath
mode on BUCK1. Note that if dual phase mode is enabled, then BUCK1B will not be registered to the regulator framework and the current capacity of BUCK1(A) would be set to 6A [3A of BUCK1A + 3A of BUCK1B]. Signed-off-by: Vaibhav Hiremath --- drivers/regulator/88pm800.c | 40

[PATCH-v3 1/2] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-08-24 Thread Vaibhav Hiremath
88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch updates the devicetree binding with DT property to enable dual-phase mode on BUCK1. Signed-off-by: Vaibhav Hiremath

[PATCH-v3 0/2] regulator: 88pm800: Add dual phase mode support on BUCK1

2015-08-24 Thread Vaibhav Hiremath
. - Based on Mark Brown's comment, we should use DT property of its own. using set_current_limit() is not right way here. So, created DT property for Dual phase mode enable. - Updated binding for new DT property Vaibhav Hiremath (2): mfd: devicetree: bindings: 88pm800: Add DT property

Re: [PATCH-v3] mfd: 88pm80x: Add 88pm860 chip type support

2015-08-24 Thread Vaibhav Hiremath
On Monday 20 July 2015 05:22 PM, Vaibhav Hiremath wrote: Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2

Re: [PATCH-v6 0/6] mfd: 88pm800: Add Device tree support

2015-08-23 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 12:27 AM, Vaibhav Hiremath wrote: On Wednesday 08 July 2015 05:56 PM, Vaibhav Hiremath wrote: This patch-series adds support for Device tree to 88PM800 mfd driver. It also sets default configuration of irq clear method if board file doesn't exist. Testing:: -

[PATCH-v5 RESEND 3/5] i2c: pxa: Add support for pxa910/988 & new configuration features

2015-08-23 Thread Vaibhav Hiremath
d DT properties for ilcr and iwcr configuration fields. In case of Master ilcr is used for low/high time and in case of slave mode of operation iwcr is used for setup/hold time. Signed-off-by: Jett.Zhou Signed-off-by: Yi Zhang Signed-off-by: Vaibhav Hiremath Tested-by: Robert Jarzmik --- drive

[PATCH-v5 RESEND 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-23 Thread Vaibhav Hiremath
f the I2C module after xfer in master mode of operation. i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer Signed-off-by: Yi Zhang Signed-off-by: Vaibhav Hiremath --- drivers/i2c/busses/i2c-pxa.c | 43 +-- 1 file change

[PATCH-v5 RESEND 4/5] Documentation: binding: add sclk adjustment properties to i2c-pxa

2015-08-23 Thread Vaibhav Hiremath
hold/setup wait counter for standard and fast mode. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b/Documentation/devicetree/bindings

[PATCH-v5 RESEND 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-23 Thread Vaibhav Hiremath
: Vaibhav Hiremath Signed-off-by: Jett.Zhou Signed-off-by: Yi Zhang Tested-by: Robert Jarzmik --- drivers/i2c/busses/i2c-pxa.c | 69 1 file changed, 63 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c

[PATCH-v5 RESEND 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-23 Thread Vaibhav Hiremath
Driver will now supports enable/disable across msg xfer, which user can control it by new DT property - i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer and enable it back before xfer. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/i2c/i2c

[PATCH-v5 RESEND 0/5] i2c: pxa: Add support for PXA910 family of device

2015-08-23 Thread Vaibhav Hiremath
fram Sang" - Dropped Patch 05/12: using core bus reset implementation - under work. 08/12: NAKed and dropped - Separated DT binding patch from driver changes, for easy merge Vaibhav Hiremath (4): Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-09 Thread Vaibhav Hiremath
On Sunday 09 August 2015 05:48 PM, Robert Jarzmik wrote: Vaibhav Hiremath writes: Robert, It would be helpful if you can test this patch-series and confirm that it now fixes the NULL pointer deference issue. Tested, it works on pxa27x in master mode, in non-DT mode. For all non-DT

Re: [PATCH-v2 2/2] regulator: 88pm800: Add support for configuration of dual phase on BUCK1

2015-08-05 Thread Vaibhav Hiremath
On Thursday 06 August 2015 05:28 AM, Krzysztof Kozlowski wrote: On 05.08.2015 17:45, Vaibhav Hiremath wrote: On Thursday 23 July 2015 10:21 AM, Krzysztof Kozlowski wrote: 2015-07-22 1:23 GMT+09:00 Vaibhav Hiremath : 88PM860 device supports dual phase mode on BUCK1 output. In normal

  1   2   3   4   >