Re: [PATCH] crypto: hisilicon/hpre - fix unmapping invalid dma address

2021-04-19 Thread Hui Tang
On 2021/4/16 19:26, Herbert Xu wrote: On Sat, Apr 10, 2021 at 05:49:17PM +0800, Hui Tang wrote: Currently, an invalid dma address may be unmapped when calling 'xx_data_clr_all' in error path, so check dma address of sqe in/out whether it has been mapped before calling 'dma_free_coherent

[PATCH for vm-scalability] usemem: Output a message after punch holes done

2021-04-13 Thread Hui Zhu
From: Hui Zhu When I use punch holes to setup a test page fragmentation environment, I didn't know when the punch holes done. I can only get this information through top or something else. This commit add code to output a message after punch holes done to handle this issue. Signed-off-by: Hui

[PATCH] sched: remove the redundant comments

2021-04-12 Thread Hui Su
Since the commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]"), we don't need this any more. Signed-off-by: Hui Su --- kernel/sched/sched.h | 5 - 1 file changed, 5 deletions(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 10a1522b1e30..223202

[PATCH v3] crypto: hisilicon/hpre - delete redundant log and return in advance

2021-04-10 Thread Hui Tang
'hpre_cfg_by_dsm' has checked and printed error path internally. It is not necessary to do it here, so remove it. It should return error immediately when return value of 'hpre_cfg_by_dsm' is non-zero, and no need to execute the remaining sentences. Signed-off-by: Hui Tang --- v1 ->

[PATCH] crypto: hisilicon/hpre - fix unmapping invalid dma address

2021-04-10 Thread Hui Tang
-> hpre_curve25519_src_init -> hpre_curve25519_hw_data_clr_all Fixes: a9214b0b6ed2(crypto: hisilicon - fix the check on dma address) Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/

[PATCH 3/3] crypto: hisilicon/hpre - add debug log

2021-04-10 Thread Hui Tang
When the received sqe is abnormal, the error message in the sqe written back by the hardware is printed to help to analyze the abnormal causes. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[PATCH 2/3] crypto: hisilicon/hpre - use the correct variable type

2021-04-10 Thread Hui Tang
The return value of 'le32_to_cpu' is unsigned, so change the variable type from 'int' to 'unsigned int'. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b

[PATCH 0/3] crypto: hisilicon/hpre - add debug log

2021-04-10 Thread Hui Tang
This patchset adds the debug log and cleanup code style. Hui Tang (3): crypto: hisilicon/hpre - delete the rudundant space after return crypto: hisilicon/hpre - use the correct variable type crypto: hisilicon/hpre - add debug log drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11

[PATCH 1/3] crypto: hisilicon/hpre - delete the rudundant space after return

2021-04-10 Thread Hui Tang
There are two spaces after return, just keep one. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +- drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b

Re: [PATCH v2] crypto: hisilicon/hpre - delete redundant log

2021-04-09 Thread Hui Tang
On 2021/4/9 15:33, Herbert Xu wrote: On Fri, Apr 02, 2021 at 07:24:29PM +0800, Hui Tang wrote: 'hpre_cfg_by_dsm' has checked and printed error path internally. It is not necessary to do it here, so remove it. Signed-off-by: Hui Tang v1 -> v2: - Return immediately when return va

[PATCH v2 -next 3/3] clk: qcom: apss-ipq-pll: Add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Chen Hui
: Add ipq apss pll driver") Signed-off-by: Chen Hui Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/apss-ipq-pll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c index 30be87fb222a..bef7899ad0d6 100644 --- a/driver

[PATCH v2 -next 1/3] clk: qcom: a7-pll: Add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Chen Hui
dd A7 PLL support") Signed-off-by: Chen Hui Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/a7-pll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/qcom/a7-pll.c b/drivers/clk/qcom/a7-pll.c index e171d3caf2cf..c4a53e5db229 100644 --- a/drivers/clk/qcom/a7-pll.c +++

[PATCH v2 -next 2/3] clk: qcom: a53-pll: Add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Chen Hui
: Add A53 PLL support") Signed-off-by: Chen Hui Reviewed-by: Manivannan Sadhasivam --- drivers/clk/qcom/a53-pll.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c index 45cfc57bff92..af6ac17c7dae 100644 --- a/drivers/clk/qcom/a53-p

[PATCH v2 -next 0/3] Add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Chen Hui
v2: - separate from one patch into three patches - add fixes tags Chen Hui (3): clk: qcom: a7-pll: Add missing MODULE_DEVICE_TABLE clk: qcom: a53-pll: Add missing MODULE_DEVICE_TABLE clk: qcom: apss-ipq-pll: Add missing MODULE_DEVICE_TABLE drivers/clk/qcom/a53-pll.c | 1 + drivers

[PATCH -next] PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe()

2021-04-09 Thread Chen Hui
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Chen Hui --- drivers/pci/controller/pcie-altera-msi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/controller/pcie

[PATCH -next] drm/hisilicon/kirin: Remove redundant DRM_ERROR call in dsi_parse_dt()

2021-04-09 Thread Chen Hui
There is a error message within devm_ioremap_resource already, so remove the DRM_ERROR call to avoid redundant error message. Signed-off-by: Chen Hui --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/hisilicon

[PATCH -next] clk: qcom: Add missing MODULE_DEVICE_TABLE

2021-04-08 Thread Chen Hui
Add missing MODULE_DEVICE_TABLE entries to support module autoloading, as these drivers can be compiled as external modules. Signed-off-by: Chen Hui --- drivers/clk/qcom/a53-pll.c | 1 + drivers/clk/qcom/a7-pll.c | 1 + drivers/clk/qcom/apss-ipq-pll.c | 1 + 3 files changed, 3

[PATCH -next] clk: samsung: Remove redundant dev_err calls

2021-04-08 Thread Chen Hui
There is error message within devm_ioremap_resource already, so remove the dev_err calls to avoid redundant error messages. Signed-off-by: Chen Hui --- drivers/clk/samsung/clk-exynos4412-isp.c | 4 +--- drivers/clk/samsung/clk-s5pv210-audss.c | 4 +--- 2 files changed, 2 insertions(+), 6

[PATCH for vm-scalability] usemem: Add code for touch-alloc

2021-04-08 Thread Hui Zhu
Add code for touch-alloc. And Change read memory to write memory to avoid use the zero-page for reads in do_anonymous_page. Signed-off-by: Hui Zhu --- usemem.c | 34 ++ 1 file changed, 22 insertions(+), 12 deletions(-) diff --git a/usemem.c b/usemem.c index

[PATCH -next] drm/mediatek: Remove redundant dev_err calls

2021-04-08 Thread Chen Hui
There is a error message within devm_ioremap_resource already, so remove the dev_err calls to avoid redundant error messages. Signed-off-by: Chen Hui --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 4 +--- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +--- 2 files changed, 2 insertions(+), 6

[PATCH v2] crypto: hisilicon/hpre - delete redundant log

2021-04-02 Thread Hui Tang
'hpre_cfg_by_dsm' has checked and printed error path internally. It is not necessary to do it here, so remove it. Signed-off-by: Hui Tang v1 -> v2: - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero. --- drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- 1 file changed

[PATCH] crypto: hisilicon - check if debugfs opened

2021-03-27 Thread Hui Tang
'xx_debugfs_init' check if debugfs opened. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 5 - drivers/crypto/hisilicon/qm.c | 3 +++ drivers/crypto/hisilicon/sec2/sec_main.c | 5 - drivers/crypto/hisilicon/zip/zip_main.c | 3 +++ 4 files changed

[PATCH] crypto: hisilicon/hpre - delete redundant log

2021-03-27 Thread Hui Tang
'hpre_cfg_by_dsm' has checked and printed error path, so it is not necessary at all. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto

[PATCH] crypto: hisilicon - delete redundant '\n'

2021-03-27 Thread Hui Tang
It has newline already by sysfs, so delete redundant '\n' Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++-- drivers/crypto/hisilicon/sec2/sec_main.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b

[PATCH] crypto: hisilicon/hpre - fix a typo and delete redundant blank line

2021-03-27 Thread Hui Tang
s/shoul/should/ Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c index f2605c4..8aae921 100644 --- a/drivers/crypto

[PATCH] crypto: hisilicon/hpre - fix PASID setting on kunpeng 920

2021-03-27 Thread Hui Tang
We must confirm the PASID is disabled before using no-sva mode. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 43 +-- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto

[PATCH] crypto: hisilicon/hpre - fix Kconfig

2021-03-19 Thread Hui Tang
hpre select 'CRYPTO_ECDH' and 'CRYPTO_CURVE25519'. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig index c45adb1..e572f99 100644 --- a/drivers

[PATCH] crypto: hisilicon/hpre - fix "hpre_ctx_init" resource leak

2021-03-19 Thread Hui Tang
When calling "hpre_ctx_set" fails, stop and put qp, otherwise will leak qp resource. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c

[PATCH] crypto: hisilicon - fix the check on dma address

2021-03-19 Thread Hui Tang
System may be able to get physical address of zero if not reserved by firmware. The dma address obtained by 'dma_alloc_coherent' is valid, since already checking cpu va before, so do not check again. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 12

[PATCH 0/2] crypto: hisilicon/hpre - remove 'CONFIG_CRYPTO_DH'

2021-03-19 Thread Hui Tang
Remove 'CONFIG_CRYPTO_DH' and optimise 'hpre_algs_register' error path. Hui Tang (2): crypto: hisilicon/hpre - delete wrap of 'CONFIG_CRYPTO_DH' crypto: hisilicon/hpre - optimise 'hpre_algs_register' error path drivers/crypto/hisilicon/hpre/hpre_crypto.c | 30

[PATCH 2/2] crypto: hisilicon/hpre - optimise 'hpre_algs_register' error path

2021-03-19 Thread Hui Tang
There is redundant code especially when registing new algorithms in the future. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers

[PATCH 1/2] crypto: hisilicon/hpre - delete wrap of 'CONFIG_CRYPTO_DH'

2021-03-19 Thread Hui Tang
'CRYPTO_DH' has selected in 'Kconfig', so delete 'CONFIG_CRYPTO_DH'. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon

Re: [PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2021-03-18 Thread Ding Hui
manage), so report the problem and don't attach. Not attaching also fixes an oops which could occur if the driver tries to manage a zero component enclosure. Reported-by: Ding Hui Cc: sta...@vger.kernel.org Signed-off-by: James Bottomley --- drivers/scsi/ses.c | 5 + 1 file changed, 5 inserti

[PATCH v2 0/2] crypto: qat - fixes related to 'dma_map_single'

2021-03-04 Thread Hui Tang
This patchset fix bugs related to 'dma_map_single' use: Hui Tang (2): crypto: qat - fix 'dma_unmap_single' invalid address crypto: qat - fix use of 'dma_map_single' v1 -> v2: 1.fix build warning reported by kernel test rebot 2.add patch #1 drivers/crypto/qat/qat_com

[PATCH v2 2/2] crypto: qat - fix use of 'dma_map_single'

2021-03-04 Thread Hui Tang
DMA_TO_DEVICE synchronisation must be done after the last modification of the memory region by the software and before it is handed off to the device. Signed-off-by: Hui Tang Reported-by: kernel test robot Reported-by: Dan Carpenter --- drivers/crypto/qat/qat_common/qat_algs.c | 27

[PATCH v2 1/2] crypto: qat - fix unmap invalid dma address

2021-03-04 Thread Hui Tang
'dma_mapping_error' return a negative value if 'dma_addr' is equal to 'DMA_MAPPING_ERROR' not zero, so fix initialization of 'dma_addr'. Signed-off-by: Hui Tang --- drivers/crypto/qat/qat_common/qat_algs.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] video: fbdev: fix use of 'dma_map_single'

2021-02-28 Thread Hui Tang
DMA_TO_DEVICE synchronisation must be done after the last modification of the memory region by the software and before it is handed off to the device. Signed-off-by: Hui Tang --- drivers/video/fbdev/grvga.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/video

[PATCH] crypto: qat - fix use of 'dma_map_single'

2021-02-28 Thread Hui Tang
DMA_TO_DEVICE synchronisation must be done after the last modification of the memory region by the software and before it is handed off to the device. Signed-off-by: Hui Tang --- drivers/crypto/qat/qat_common/qat_algs.c | 23 --- 1 file changed, 12 insertions(+), 11

[PATCH] crypto: hisilicon/hpre - enable Elliptic curve cryptography

2021-02-04 Thread Hui Tang
Enable x25519/x448/ecdh/ecdsa/sm2 algorithm on Kunpeng 930. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c

[PATCH 0/4] crypto: hisilicon - some updates to adapt Kunpeng930

2021-02-04 Thread Hui Tang
1.Update clusters number for both Kunpeng920 and Kunpeng930. 2.Some bugfixs only on Kunpeng920, so added hardware version wrap. 3.Fix use of 'dma_map_single'. 4.Fix PASID on Kunpeng930. Hui Tang (2): crypto: hisilicon/hpre - adapt the number of clusters crypto: hisilicon/hpre - tiny fix

[PATCH 3/4] crypto: hisilicon/qm - fix use of 'dma_map_single'

2021-02-04 Thread Hui Tang
From: Weili Qian Calling 'dma_map_single' after the data is written to ensure that the cpu cache and dma cache are consistent. Signed-off-by: Weili Qian Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/qm.c | 50 +++ 1 file changed, 27 insertions

[PATCH 2/4] crypto: hisilicon/hpre - tiny fix

2021-02-04 Thread Hui Tang
Update since some special settings only for Kunpeng920. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b/drivers/crypto/hisilicon/hpre/hpre_main.c

[PATCH 1/4] crypto: hisilicon/hpre - adapt the number of clusters

2021-02-04 Thread Hui Tang
HPRE of Kunpeng 930 is updated on cluster numbers, so we try to update this driver to make it running okay on Kunpeng920/Kunpeng930 chips. Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre.h | 8 ++-- drivers/crypto/hisilicon/hpre/hpre_main.c | 71

[PATCH 4/4] crypto: hisilicon - PASID fixed on Kunpeng 930

2021-02-04 Thread Hui Tang
From: Weili Qian Enable PASID by setting 'sqc' and 'cqc' pasid bits per queue in Kunpeng 930. For Kunpeng 920, PASID is effective for all queues once set in SVA scenarios. Signed-off-by: Weili Qian Signed-off-by: Hui Tang --- drivers/crypto/hisilicon/hpre/hpre_main.c | 18

[PATCH] lib/stackdepot.c: fix the compile warning

2021-02-02 Thread Hui Su
sed_result [-Wunused-result] 154 | kstrtobool(str, _depot_disable); | ^ Signed-off-by: Hui Su --- lib/stackdepot.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index cc21116512a7..acd13f574

[PATCH] usemem: Remove the duplicate do_access

2021-01-18 Thread Hui Zhu
From: Hui Zhu Got following error when build usemem: gcc -O -c -Wall -g usemem.c -o usemem.o usemem.c:451:15: error: redefinition of ‘do_access’ unsigned long do_access(unsigned long *p, unsigned long idx, int read) ^ usemem.c:332:15: note: previous definition

[PATCH] crypto: hisilicon/hpre - add ecc algorithm inqury for uacce device

2021-01-18 Thread Hui Tang
Uacce SysFS support more algorithms inqury such as 'ecdh/ecdsa/sm2/x25519/x448' Signed-off-by: Hui Tang Reviewed-by: Zaibo Xu --- drivers/crypto/hisilicon/hpre/hpre_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_main.c b

[PATCH] crypto: hisilicon/hpre - add two RAS correctable errors processing

2021-01-18 Thread Hui Tang
1.One CE error is detecting timeout of generating a random number. 2.Another is detecting timeout of SVA prefetching address. Signed-off-by: Hui Tang Reviewed-by: Zaibo Xu --- drivers/crypto/hisilicon/hpre/hpre_main.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH] crypto: hisilicon/hpre - delete ECC 1bit error reported threshold

2021-01-18 Thread Hui Tang
Delete 'HPRE_RAS_ECC1BIT_TH' register setting of hpre, since register 'QM_RAS_CE_THRESHOLD' of qm has done this work. Signed-off-by: Hui Tang Reviewed-by: Zaibo Xu --- drivers/crypto/hisilicon/hpre/hpre_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre

[tip: sched/core] sched: Use task_current() instead of 'rq->curr == p'

2021-01-14 Thread tip-bot2 for Hui Su
The following commit has been merged into the sched/core branch of tip: Commit-ID: 65bcf072e20ed7597caa902f170f293662b0af3c Gitweb: https://git.kernel.org/tip/65bcf072e20ed7597caa902f170f293662b0af3c Author:Hui Su AuthorDate:Sat, 31 Oct 2020 01:32:23 +08:00 Committer

Re: [PATCH] mm/page_alloc: remove the static for local variable node_order

2020-12-30 Thread Hui Su
Hi, Matthew: On Wed, Dec 30, 2020 at 12:42:33PM +, Matthew Wilcox wrote: > On Wed, Dec 30, 2020 at 07:40:14PM +0800, Hui Su wrote: > > local variable node_order do not need the static here. > > It bloody well does. It can be up to 2^10 entries on x86 (and larger > on

[PATCH] mm/page_alloc: remove the static for local variable node_order

2020-12-30 Thread Hui Su
local variable node_order do not need the static here. Signed-off-by: Hui Su --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bdbec4c98173..45e049ccf117 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5864,7

Re: [blokc/blk] d828aefa7a: xfstests.xfs.372.fail

2020-12-28 Thread Hui Su
map_sg()") > url: > https://github.com/0day-ci/linux/commits/Hui-Su/blokc-blk-merge-remove-the-next_bvec-label-in-__blk_bios_map_sg/20201223-202618 > base: https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git > for-next > > in testcase: xfstests > version:

[PATCH v2] blokc/blk-merge: remove the next_bvec label in __blk_bios_map_sg()

2020-12-23 Thread Hui Su
remove the next_bvec label in __blk_bios_map_sg(), simplify the logic of traversal bvec. Signed-off-by: Hui Su --- block/blk-merge.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 808768f6b174..aa113cbc0f35 100644

Re: [PATCH] blokc/blk-merge: remove the next_bvec label in __blk_bios_map_sg()linux-bl...@vger.kernel.org (open list:BLOCK LAYER)

2020-12-23 Thread Hui Su
On Wed, Dec 23, 2020 at 08:33:07AM +, Christoph Hellwig wrote: > On Wed, Dec 23, 2020 at 12:31:58PM +0800, sh wrote: > > remove the next_bvec label in __blk_bios_map_sg(), simplify the logic > > of traversal bvec. > > What makes you believe that this simplifies anything? 1. this change

Re: [PATCH] blokc/blk-merge: remove the next_bvec label in __blk_bios_map_sg()linux-bl...@vger.kernel.org (open list:BLOCK LAYER)

2020-12-23 Thread Hui Su
Hi, all: Please ignore this change, i will resend a patch V2 later.

[PATCH] mm/buffer.c: remove the macro check in check_irqs_on()

2020-12-22 Thread Hui Su
The macro irqs_disabled is always defined in include/linux/irqflags.h, so we don't need the macro check. Signed-off-by: Hui Su --- fs/buffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 32647d2011df..34b505542d96 100644 --- a/fs/buffer.c +++ b/fs

[PATCH] usemem: Add option touch-alloc

2020-12-16 Thread Hui Zhu
Some environment will not fault in memory even if MAP_POPULATE is set. This commit add option touch-alloc to read memory after allocate it to make sure the pages is fault in. Signed-off-by: Hui Zhu --- usemem.c | 37 + 1 file changed, 25 insertions(+), 12

[PATCH] usemem: Add option init-time

2020-12-16 Thread Hui Zhu
From: Hui Zhu This commit add a new option init-time to remove the initialization time from the run time and show the initialization time. Signed-off-by: Hui Zhu --- usemem.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/usemem.c b/usemem.c

[PATCH] mm/memcontrol: remove the unnecessary rcu_read_[un]lock

2020-12-16 Thread Hui Su
the rcu_read_lock and rcu_read_unlock is unnecessary in: lock_page_lruvec() lock_page_lruvec_irq() lock_page_lruvec_irqsave() Signed-off-by: Hui Su --- mm/memcontrol.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index

Re: [PATCH v41 00/24] Intel SGX foundations

2020-12-14 Thread Hui, Chunyang
s, we have commented out his > tag lines in the commit messages. > > Originally the code was based on early prototyping work of Suresh S. > > This patch set has been rebased on top of tip tree commit > c3c30db1b191bb1640a08bbcc593c212affcab75. Tested-by: Chunyang Hui The Occlum

Re: [PATCH v41 00/24] Intel SGX foundations

2020-12-14 Thread Hui, Chunyang
s, we have commented out his > tag lines in the commit messages. > > Originally the code was based on early prototyping work of Suresh S. > > This patch set has been rebased on top of tip tree commit > c3c30db1b191bb1640a08bbcc593c212affcab75. Tested-by: Chunyang Hui Occlum

[PATCH] samples/bpf/Makefile: Create tools/testing/selftests/bpf dir

2020-12-14 Thread Hui Zhu
From: Hui Zhu Got an error when I built samples/bpf in a separate directory: make O=../bk/ defconfig make -j64 bzImage make headers_install make V=1 M=samples/bpf ... ... make -C /home/teawater/kernel/linux/samples/bpf/../..//tools/build CFLAGS= LDFLAGS= fixdep make -f /home/teawater/kernel

[tip: core/rcu] docs/rcu: Update the call_rcu() API

2020-12-13 Thread tip-bot2 for Hui Su
The following commit has been merged into the core/rcu branch of tip: Commit-ID: c386e29d43728778ddd642fa73cc582bee684171 Gitweb: https://git.kernel.org/tip/c386e29d43728778ddd642fa73cc582bee684171 Author:Hui Su AuthorDate:Thu, 15 Oct 2020 22:13:34 +08:00 Committer

[linux-next] kernel panic when poweroff (Tree for Dec 11)

2020-12-11 Thread Hui Su
cing: Attempted to kill init! exitcode=0x0009 ]--- qemu-system-x86_64: terminating on signal 15 from pid 2836242 (pkill) The next tree for Dec 10 does not contain this problem, and the tree for Dec 11 can reproduce this problem stably(always panic when poweroff). Reported-by: Hui Su

[PATCH] fs/proc: make pde_get() return nothing

2020-12-10 Thread Hui Su
we don't need pde_get()'s return value, so make pde_get() return nothing Signed-off-by: Hui Su --- fs/proc/internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/proc/internal.h b/fs/proc/internal.h index 917cc85e3466..0abbd93a4a08 100644 --- a/fs/proc/internal.h

Re: [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-08 Thread Hui Su
On Mon, Dec 07, 2020 at 09:28:46AM -0800, Shakeel Butt wrote: > On Mon, Dec 7, 2020 at 6:22 AM Hui Su wrote: > > The reason to keep __memcg_kmem_[un]charge_page functions is that they > were called in the very hot path. Can you please check the performance > impact

[PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

2020-12-07 Thread Hui Su
Since the commit 60cd4bcd6238 ("memcg: localize memcg_kmem_enabled() check"), we have supplied the api which users don't have to explicitly check memcg_kmem_enabled(). Signed-off-by: Hui Su --- mm/page_alloc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH][next] arm64: fix the mm build error in mm/kfence/core.c

2020-12-05 Thread Hui Su
of function ‘set_memory_valid’ [-Werror=implicit-function-declaration] 12 | set_memory_valid(addr, 1, !protect); | ^~~~ cc1: some warnings being treated as errors which introduced by commit d54febeba2ff ("kfence: use pt_regs to generate stack trace on faults"). Signed-off-

Re: [PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2020-11-29 Thread Ding Hui
On 2020/11/29 13:12, Douglas Gilbert wrote: On 2020-11-28 6:27 p.m., James Bottomley wrote: On Sat, 2020-11-28 at 20:23 +0800, Ding Hui wrote: We can get a crash when disconnecting the iSCSI session, the call trace like this:    [2a00fb70] kfree at 0830e224

[PATCH] scsi: ses: Fix crash caused by kfree an invalid pointer

2020-11-28 Thread Ding Hui
ount is 0 We also need check index when use edev->component[] array in ses_enclosure_data_process Tested-by: Zeng Zhicong Cc: stable # 2.6.25+ Signed-off-by: Ding Hui --- drivers/scsi/ses.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/

[PATCH] mm/compaction: make defer_compaction and compaction_deferred static

2020-11-23 Thread Hui Su
defer_compaction() and compaction_deferred() and compaction_restarting() in mm/compaction.c won't be used in other files, so make them static, and remove the declaration in the header file. Take the chance to fix a typo. Signed-off-by: Hui Su --- include/linux/compaction.h | 12

[PATCH] hwtracing: stm: fix return value of error branch in stm_heartbeat_init

2020-11-23 Thread Wang Hui
ret would be reset by stm_source_register_device after first loop, so we should reassign ret while allocation failed for stm_heartbeat[i].data.name Reported-by: Hulk Robot Fixes: 119291853038 ("stm class: Add heartbeat stm source device") Signed-off-by: Wang Hui --- drivers/hwt

Re: + mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch added to -mm tree

2020-11-20 Thread Hui Su
c) Ideally: find the original patch on the mailing list and do a > > reply-to-all to that, adding suitable additional cc's > > > > *** Remember to use Documentation/process/submit-checklist.rst when testing > > your code *** > > > > The -mm tree is in

Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

2020-11-20 Thread Hui Su
On Tue, Nov 17, 2020 at 05:59:00PM +, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 01:56:58AM +0800, Hui Su wrote: > > On Tue, Nov 17, 2020 at 05:47:27PM +, Matthew Wilcox wrote: > > > On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote: > > > > On T

[tip: x86/cleanups] x86/dumpstack: Make show_trace_log_lvl() static

2020-11-17 Thread tip-bot2 for Hui Su
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: 09a217c10504bcaef911cf2af74e424338efe629 Gitweb: https://git.kernel.org/tip/09a217c10504bcaef911cf2af74e424338efe629 Author:Hui Su AuthorDate:Fri, 13 Nov 2020 21:39:43 +08:00 Committer

Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

2020-11-17 Thread Hui Su
On Tue, Nov 17, 2020 at 05:59:00PM +, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 01:56:58AM +0800, Hui Su wrote: > > On Tue, Nov 17, 2020 at 05:47:27PM +, Matthew Wilcox wrote: > > > On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote: > > > > On T

Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

2020-11-17 Thread Hui Su
On Tue, Nov 17, 2020 at 05:41:17PM +, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote: > > lru_list lru bit 0 can tell whether the list is > > avtive lru-list or not. > > lru_list lru bit 1 can tell whether the list is > > file lru-li

Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

2020-11-17 Thread Hui Su
On Tue, Nov 17, 2020 at 05:47:27PM +, Matthew Wilcox wrote: > On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote: > > On Tue, Nov 17, 2020 at 05:41:17PM +, Matthew Wilcox wrote: > > > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote: > > > > lru_l

[PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

2020-11-17 Thread Hui Su
lru_list lru bit 0 can tell whether the list is avtive lru-list or not. lru_list lru bit 1 can tell whether the list is file lru-list or not. And fix some define type in shrink_active_list() and get_scan_count(). v1->v2: correct the commit message, and fix the define type. Signed-off-by: Hui

Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

2020-11-17 Thread Hui Su
On Wed, Nov 18, 2020 at 12:49:19AM +0800, Hui Su wrote: > page->lru bit 0 can tell whether the page is > avtive page or not. > page->lru bit 1 can tell whether the page is > file page or not. > > Signed-off-by: Hui Su > --- > include/linux/mmzone.h | 4 ++-- > 1

[PATCH] mm/lru: simplify is_file_lru() and is_active_lru()

2020-11-17 Thread Hui Su
page->lru bit 0 can tell whether the page is avtive page or not. page->lru bit 1 can tell whether the page is file page or not. Signed-off-by: Hui Su --- include/linux/mmzone.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/mmzone.h b/include

[PATCH] namespace: make timens_on_fork() return nothing

2020-11-17 Thread Hui Su
timens_on_fork() always return 0, and maybe not need to judge the return value in copy_namespaces(). So make timens_on_fork() return nothing and do not judge its return val in copy_namespaces(). Signed-off-by: Hui Su --- include/linux/time_namespace.h | 6 +++--- kernel/nsproxy.c

Re: [PATCH] namespace: make timens_on_fork() return nothing

2020-11-17 Thread Hui Su
Please ignore this change.

[PATCH v2] namespace: make timens_on_fork() return nothing

2020-11-17 Thread Hui Su
timens_on_fork() always return 0, and maybe not need to judge the return value in copy_namespaces(). So make timens_on_fork() return nothing and do not judge its return val in copy_namespaces(). Signed-off-by: Hui Su --- include/linux/time_namespace.h | 6 +++--- kernel/nsproxy.c

Re: [PATCH] nsproxy: remove judge of timens_on_fork()'s return val

2020-11-17 Thread Hui Su
On Tue, Nov 17, 2020 at 12:30:26AM -0800, Andrey Vagin wrote: > On Sun, Nov 15, 2020 at 10:36 AM Hui Su wrote: > > > > timens_on_fork() always return 0, and maybe not > > need to judge the return value in copy_namespaces(). > > Thank you for cleaning this up. I t

Re: + mm-shmem-use-kmem_cache_zalloc-in-shmem_alloc_inode.patch added to -mm tree

2020-11-17 Thread Hui Su
that, adding suitable additional cc's > > > > > > *** Remember to use Documentation/process/submit-checklist.rst when > > > testing your code *** > > > > > > The -mm tree is included into linux-next and is updated > > > there every 3-4 workin

[PATCH] mm/compaction: move compaction_suitable's comment to right place

2020-11-16 Thread Hui Su
Since commit 837d026d560c ("mm/compaction: more trace to understand when/why compaction start/finish"), the comment place is not suitable. So move compaction_suitable's comment to right place. Signed-off-by: Hui Su --- mm/compaction.c | 14 +++--- 1 file changed, 7 insert

[PATCH] nsproxy: remove judge of timens_on_fork()'s return val

2020-11-15 Thread Hui Su
timens_on_fork() always return 0, and maybe not need to judge the return value in copy_namespaces(). Signed-off-by: Hui Su --- kernel/nsproxy.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c index 12dd41b39a7f..e2e6c5dc433f 100644

[PATCH] nsproxy: use put_nsproxy() in switch_task_namespaces()

2020-11-15 Thread Hui Su
Use put_nsproxy() instead of ' if (atomic_dec_and_test(>count)) { free_nsproxy(ns); }' in switch_task_namespaces(). and remove the whitespace by the way. Signed-off-by: Hui Su --- kernel/nsproxy.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ker

[PATCH] mm/shmem: use kmem_cache_zalloc in shmem_alloc_inode()

2020-11-15 Thread Hui Su
_inode(). Signed-off-by: Hui Su --- mm/shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 537c137698f8..b84adda45461 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2308,7 +2308,6 @@ static struct inode *shmem_get_inode(struct super_block *sb,

[PATCH v3] mm/shmem.c: make shmem_mapping() inline

2020-11-15 Thread Hui Su
ion in shmem_fs.h v2->v3: make shmem_aops global, and export it to modules. Signed-off-by: Hui Su --- include/linux/shmem_fs.h | 6 +- mm/shmem.c | 16 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h

Re: [PATCH v2] mm/shmem.c: make shmem_mapping() inline

2020-11-15 Thread Hui Su
On Sat, Nov 14, 2020 at 10:50:39AM -0800, Andrew Morton wrote: > On Sat, 14 Nov 2020 13:51:34 +0800 Hui Su wrote: > > > inline the shmem_mapping(), and use shmem_mapping() > > instead of 'inode->i_mapping->a_ops == _aops' > > in shmem_evict_inode(). > &g

[PATCH v2] mm/shmem.c: make shmem_mapping() inline

2020-11-13 Thread Hui Su
inline the shmem_mapping(), and use shmem_mapping() instead of 'inode->i_mapping->a_ops == _aops' in shmem_evict_inode(). v1->v2: remove the inline for func declaration in shmem_fs.h Reviewed-by: Pankaj Gupta Reported-by: kernel test robot Signed-off-by: Hui Su --- mm/shmem.c |

Re: [PATCH] mm/shmem.c: make shmem_mapping() inline

2020-11-13 Thread Hui Su
On Sat, Nov 14, 2020 at 12:54:47AM +0800, kernel test robot wrote: > Hi Hui, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on mmotm/master] > > url: > https://github.com/0day-ci/linux/commits/Hui-Su/mm-shmem-c-make-shmem

[PATCH] mm/shmem.c: make shmem_mapping() inline

2020-11-13 Thread Hui Su
inline the shmem_mapping(), and use shmem_mapping() instead of 'inode->i_mapping->a_ops == _aops' in shmem_evict_inode(). Signed-off-by: Hui Su --- include/linux/shmem_fs.h | 2 +- mm/shmem.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include

[PATCH] mm/page_counter: use page_counter_read in page_counter_set_max

2020-11-13 Thread Hui Su
use page_counter_read() in page_counter_set_max(). Signed-off-by: Hui Su --- mm/page_counter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/page_counter.c b/mm/page_counter.c index b24a60b28bb0..c6860f51b6c6 100644 --- a/mm/page_counter.c +++ b/mm/page_counter.c

[PATCH] x86/dumpstack: make show_trace_log_lvl() static

2020-11-13 Thread Hui Su
show_trace_log_lvl() won't be used by other files, so make it static and remove the declaration from the header file. Signed-off-by: Hui Su --- arch/x86/include/asm/stacktrace.h | 3 --- arch/x86/kernel/dumpstack.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/arch

[PATCH] fs/kernfs: remove the double check of dentry->inode

2020-11-13 Thread Hui Su
In both kernfs_node_from_dentry() and in kernfs_dentry_node(), we will check the dentry->inode is NULL or not, which is superfluous. So remove the check in kernfs_node_from_dentry(). Signed-off-by: Hui Su --- fs/kernfs/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --

[tip: sched/core] sched/fair: Remove superfluous lock section in do_sched_cfs_slack_timer()

2020-11-11 Thread tip-bot2 for Hui Su
The following commit has been merged into the sched/core branch of tip: Commit-ID: cdb310474dece99985e4cdd2b96b1324e39c1c9d Gitweb: https://git.kernel.org/tip/cdb310474dece99985e4cdd2b96b1324e39c1c9d Author:Hui Su AuthorDate:Fri, 30 Oct 2020 22:46:21 +08:00 Committer

  1   2   3   4   5   6   7   8   9   10   >