, all,
Strictly this is doing two things. But I agree that the "ok" variable in
virtnet_get_hw_stats() was very confusing, and I'm not sure how long it
would have taken me to grasp the fix without that change being here too.
Reviewed-by: Simon Horman
On Tue, Apr 23, 2024 at 10:17:31AM +0800, Jason Xing wrote:
> On Tue, Apr 23, 2024 at 10:14 AM Jason Xing wrote:
> >
> > Hi Simon,
> >
> > On Tue, Apr 23, 2024 at 2:28 AM Simon Horman wrote:
> > >
> > > On Mon, Apr 2
On Mon, Apr 22, 2024 at 11:01:03AM +0800, Jason Xing wrote:
...
> diff --git a/include/net/rstreason.h b/include/net/rstreason.h
...
> +/**
> + * There are three parts in order:
> + * 1) reset reason in MPTCP: only for MPTCP use
> + * 2) skb drop reason: relying on drop reasons for such as
On Thu, Apr 11, 2024 at 06:01:54PM +0800, xu.xi...@zte.com.cn wrote:
> From: hepeilin
nit: it's nicer if this From line matches one of the Signed-off-by lines
From: Peilin He
> Introduce a tracepoint for icmp_send, which can help users to get more
> detail information conveniently when
On Tue, Mar 26, 2024 at 08:15:56PM +0100, Johannes Berg wrote:
> From: Johannes Berg
>
> The way __print_symbolic() works is limited and inefficient
> in multiple ways:
> - you can only use it with a static list of symbols, but
>e.g. the SKB dropreasons are now a dynamic list
>
> - it
On Thu, Mar 14, 2024 at 12:00:27PM -0400, Steven Rostedt wrote:
> On Thu, 14 Mar 2024 15:39:28 +0100
> Paolo Abeni wrote:
>
> > On Wed, 2024-03-13 at 09:34 -0400, Steven Rostedt wrote:
...
> > > Fixes: d8355240cf8fb ("net: hns3: add trace event support for PF/VF
> > > mailbox")
> >
> >
On Thu, Jan 18, 2024 at 10:22:05AM +0800, Kunwu Chan wrote:
> Hi Simon,
>
> Thanks for your reply.
>
> On 2024/1/17 17:29, Simon Horman wrote:
> > On Wed, Jan 17, 2024 at 03:20:45PM +0800, Kunwu Chan wrote:
> > > Use the new KMEM_CACHE() macro inste
uld probably be targeted at 'nf-next' rather than 'net'.
If it is a fix, then I would suggest targeting it at 'nf'
and providing a Fixes tag.
The above notwithstanding, this looks good to me.
Acked-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 4 +---
> 1 file changed, 1 inse
enter (linuxtesting.org).
>
> Fixes: 8d8e20e2d7bb ("ipvs: Decrement ttl")
> Signed-off-by: Fedor Pchelkin
Acked-by: Simon Horman
max() is inclusive. So a -1 has been added when needed.
>
> Signed-off-by: Christophe JAILLET
Reviewed-by: Simon Horman
On Tue, Dec 26, 2023 at 04:20:03PM -0800, Chris Lew wrote:
>
>
> On 12/23/2023 5:56 AM, Simon Horman wrote:
> > [Dropped bjorn.anders...@kernel.org, as the correct address seems
> > to be anders...@kernel.org, which is already in the CC list.
> > kernel.org
ny other error return value.
>
> Signed-off-by: Sarannya Sasikumar
Thanks,
I have a suggestion below. But that notwithstanding this change
looks good to me.
Reviewed-by: Simon Horman
> ---
> net/qrtr/ns.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> di
e things clearer to the reader (me?)
if the return type of service_announce_del was updated void. Because
as things stand -ENODEV may be returned, which implies something might
handle that, even though it doe not.
The above notwithstanding, this change looks good to me.
Reviewed-by: Simon Horman
...
On Wed, Dec 20, 2023 at 01:45:02PM -0800, Mina Almasry wrote:
> Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref
> is always a struct page underneath, but the abstraction allows efforts
> to add support for skb frags not backed by pages.
>
> There is unfortunately 1 instance
ing section protected by a check
> for CONFIG_IPV6.
>
> Fixes: fc651001d2c5ca4f ("neighbor: Add tracepoint to __neigh_create")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Simon Horman
Tested-by: Simon Horman # build-tested
etree/bindings/reserved-memory/framebuffer.yaml
> delete mode 100644
> Documentation/devicetree/bindings/reserved-memory/memory-region.yaml
> delete mode 100644
> Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml
> delete mode 100644
> Documentation/devicetree/bindings/reserved-memory/shared-dma-pool.yaml
>
Reviewed-by: Simon Glass
On Thu, Sep 07, 2023 at 12:56:47PM -0700, Sonia Sharma wrote:
> From: Sonia Sharma
>
> The switch statement in netvsc_send_completion() is incorrectly validating
> the length of incoming network packets by falling through to the next case.
> Avoid the fallthrough. Instead break after a case
On Tue, Apr 06, 2021 at 03:20:39PM +0800, Jiapeng Chong wrote:
> Fix the following clang warning:
>
> drivers/gpio/gpio-it87.c:128:20: warning: unused function 'superio_outw'
> [-Wunused-function].
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
A
it would only match the f1
> plane.
Oh okay, I thought f0 was one of the primary planes, but it's not.
Thanks for the explanation.
For the user-space visible change:
Acked-by: Simon Ser
> It should have been an OVERLAY from the beginning. The documentation
> stipulates that there should be an unique PRIMARY plane per CRTC.
Thanks for the quick patch! One comment below…
> Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU")
> Cc: # 5.8+
> Signed-off-by: Paul Cercueil
>
On Monday, March 29th, 2021 at 5:39 PM, Paul Cercueil
wrote:
> Ok, I read that as "all drivers should provide AT LEAST one primary
> plane per CRTC", and not as "all drivers should provide ONE AND ONLY
> ONE primary plane per CRTC". My bad.
Yeah, it's a little complicated to document, because
On Monday, March 29th, 2021 at 5:32 PM, Paul Cercueil
wrote:
> Making the second plane an overlay would break the ABI, which is never
> something I'm happy to do; but I'd prefer to do it now than later.
Yeah, I wonder if some user-space depends on this behavior somehow?
> I still have
On Monday, March 29th, 2021 at 4:07 PM, Maxime Ripard wrote:
> Since it looks like you have two mutually exclusive planes, just expose
> one and be done with it?
You can expose the other as an overlay. Clever user-space will be able
to figure out that the more advanced plane can be used if the
On Saturday, March 27th, 2021 at 12:22 PM, Paul Cercueil
wrote:
> The ingenic-drm driver has two mutually exclusive primary planes
> already; so the fact that a CRTC must have one and only one primary
> plane is an invalid assumption.
Why does this driver expose two primary planes, if it only
+ netfilter-de...@vger.kernel.org
On Sat, Mar 27, 2021 at 04:43:01AM +0530, Bhaskar Chowdhury wrote:
> s/registerd/registered/
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> 1 file changed, 1 insert
+ netfilter-de...@vger.kernel.org
On Sat, Mar 27, 2021 at 04:42:48AM +0530, Bhaskar Chowdhury wrote:
> s/registerd/registered/
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Simon Horman
> ---
> net/netfilter/ipvs/ip_vs_core.c | 2 +-
> 1 file changed, 1 insert
On Thu, Mar 25, 2021 at 02:35:55PM +0800, Wan Jiabing wrote:
> struct sk_buff has been declared. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
Thanks, nice catch.
Reviewed-by: Simon Horman
R-b me. Pushed, thanks!
inux/issues/115
> Signed-off-by: Gustavo A. R. Silva
Thanks Gustavo,
this looks good to me.
Acked-by: Simon Horman
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net
On Tuesday, February 23rd, 2021 at 6:42 PM, Alex Deucher
wrote:
> yeah, fdo ran out of disk space so I moved to gitlab:
>
> https://gitlab.freedesktop.org/agd5f/linux/-/commits/drm-next
Ah, thanks for the info, my bad!
On Tuesday, February 23rd, 2021 at 12:44 AM, Nathan Chancellor
wrote:
> On Mon, Feb 22, 2021 at 11:05:17PM +0000, Simon Ser wrote:
> > On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder
> > wrote:
> >
> > > >> drivers/gpu/drm/amd/amdgpu/../d
On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder
wrote:
> >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38:
> >> warning: variable 'i' is uninitialized when used here
> >> [-Wuninitialized]
>timing = >detailed_timings[i];
>
If this is about communicating buffer constraints between different components
of the stack, there were a few proposals about it. The most recent one is [1].
Simon
[1]: https://xdc2020.x.org/event/9/contributions/615/
On Friday, February 12th, 2021 at 1:57 PM, Emil Velikov
wrote:
> On Fri, 5 Feb 2021 at 22:01, Chris Wilson wrote:
> >
> > Userspace has discovered the functionality offered by SYS_kcmp and has
> > started to depend upon it. In particular, Mesa uses SYS_kcmp for
> > os_same_file_description()
Please keep the commit message short. You probbly want to send this patch
to amd-...@lists.freedesktop.org instead of dri-devel.
On Thursday, January 28th, 2021 at 1:03 PM, Sumit Semwal
wrote:
> Since he didn't comment over Hridya's last clarification about the
> tracepoints to track total GPU memory allocations being orthogonal to
> this series, I assumed he agreed with it.
IIRC he's away this week. (I don't remember
> Cc: Martin Peres
> Cc: Jeremy Cline
> Cc: Simon Ser
> Signed-off-by: Lyude Paul
Code LGTM:
Reviewed-by: Simon Ser
On Tuesday, January 19th, 2021 at 2:54 AM, Lyude Paul wrote:
> Cc: Martin Peres
> Cc: Jeremy Cline
> Cc: Simon Ser
> Signed-off-by: Lyude Paul
> ---
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/drive
Add format mod prop to
> base/ovly/nvdisp")
> Cc: James Jones
> Cc: Martin Peres
> Cc: Jeremy Cline
> Cc: Simon Ser
> Cc: # v5.8+
> Signed-off-by: Lyude Paul
Together with [1], this patch allows me to run unpatched modifier-aware
user-space successfully, without a cu
On Thursday, January 14th, 2021 at 9:06 AM, Simon Ser
wrote:
> On Thursday, January 14th, 2021 at 9:04 AM, Mauro Carvalho Chehab
> wrote:
>
> > A function has a different name between their prototype
> > and its kernel-doc markup:
> >
> > ../include/drm/dr
es(). Prototype was for drmm_crtc_alloc_with_planes()
> instead
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Simon Ser
if its intentionally that
the following was left alone in
ethernet/netronome/nfp/nfp_net_ethtool.c:nfp_net_get_nspinfo()
snprintf(version, ETHTOOL_FWVERS_LEN, "%hu.%hu"
If the above was not intentional then perhaps you could respin with that
updated and resubmit when net-next re-opens. Feel free to add:
Reviewed-by: Simon Horman
nouveau already has something for colorkey:
https://drmdb.emersion.fr/properties/4008636142/colorkey
I know this is marked "not for merge", but it would be nice to discuss
with them and come up with a standardized property.
On 2020-12-19 2:33 p.m., Oleg Nesterov wrote:
> OOPS! Sorry Simon, yes I forgot to add reported-by. Andrew, or Eric, if
> you take this patch, could you also add
>
> Reported-by: Simon Marchi
I tried the original reproducer on a patched kernel, and it looks good.
GDB's behav
enough and we could use 32-bit and
have an hour before wrapping.
Thinking about U-Boot TPL, where every byte counts, we would likely
store it in a different format and expand it later, but it would be
better if the format were efficient enough that it did not matter. A
flag byte indicating what fields are pr
mark "report rate" register as non-existent for generic
> firmwares as
> having it set to 0 does not make sense.
Looks good.
Reviewed-by: Simon Budig
Thanks,
Simon
--
kernel concepts GmbH Simon Budig
Hauptstraße 16 si
take care of it.
>
> Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver")
> Cc: Simon Glass
> Cc: Gwendal Grignou
> Reviewed-by: Douglas Anderson
> Tested-by: Douglas Anderson
> Acked-by: Enric Balletbo i Serra
> Cc: Alexandru M Stan
> Signed-off-by: Stephen
On Fri, 4 Dec 2020 at 12:35, Stephen Boyd wrote:
>
> This is already handed by default in spi_setup() if the bits_per_word is
> 0, so just drop it to shave off a line.
>
> Cc: Simon Glass
> Cc: Gwendal Grignou
> Reviewed-by: Douglas Anderson
> Tested-by: Douglas And
+
> drivers/net/ethernet/rocker/Kconfig | 1 +
> 10 files changed, 10 insertions(+)
Hi Arnd,
I'm slightly curious to know how you configured the kernel to build
the Netronome NFP driver but not CRC32 but nonetheless I have no
objection to this change.
For the Netronome portion:
Acked-by: Simon Horman
of macro 'fallthrough'
> 299 | fallthrough;
> | ^~~
>
> Reported-by: kernel test robot
> Signed-off-by: Gustavo A. R. Silva
Reviewed-by: Simon Horman
On Monday, November 16, 2020 12:03 PM, Colin King
wrote:
> From: Colin Ian King colin.k...@canonical.com
>
> Since moving to the new debug helper functions we now have a debug message
> that dereferences crtc to print a kernel debug message when crtc is null
> and so this debug message will now
Thanks, this does indeed seem to be the case.
Reviewed-by: Simon Horman
On Friday, October 23, 2020 5:27 PM, Ville Syrjälä
wrote:
> These are two extreme cases:
Thanks!
> > I'm trying to get
> > a fix for my user-space 1, and I'm wondering if int32_t is enough
> > after dividing by mode->htotal.
> > CC Pekka, just FYI (I think Weston has similar code).
>
> What's
On Thursday, October 22, 2020 12:14 PM, Ville Syrjälä
wrote:
> On Wed, Oct 21, 2020 at 08:13:43PM -0700, Randy Dunlap wrote:
>
> > Hi,
> > With linux-next 20201021, when booting up, I am seeing this:
> > [ 0.560896] UBSAN: signed-integer-overflow in
> > ../drivers/gpu/drm/drm_modes.c:765:20
>
quot;arm64: dts: rockchip: Add initial support for Pinebook
Pro")
Signed-off-by: Simon South
---
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
b/arch/arm64/boot/dts/rockchip/rk3
leds: ns2: reorder headers alphabetically
> leds: ns2: use struct led_init_data when registering
> leds: parse linux,default-trigger DT property in LED core
Hi Marek,
For all the patches applying to the leds-ns2 driver:
Reviewed-by: Simon Guinot
Tested-by: Simon Guinot
Thanks for it. The driver is looking way better.
Simon
signature.asc
Description: PGP signature
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote:
> From: ylg
>
> adjust the debug order of src and dst when tcp state changes
>
> Signed-off-by: ylg
Hi,
This sounds reasonable to me but please provide your real name
in the Signed-off-by name, which should be consistent with the
leds: ns2: reorder headers alphabetically
> leds: ns2: use struct led_init_data when registering
Hi Marek,
If you agree, I'll wait the fwnode support before reviewing and testing
this patches.
Simon
signature.asc
Description: PGP signature
On Mon, Sep 21, 2020 at 03:02:08PM +0200, Marek Behun wrote:
> On Mon, 21 Sep 2020 14:53:43 +0200
> Simon Guinot wrote:
>
> > On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote:
> > > On Fri, 18 Sep 2020 15:02:06 +0200
> > > Simon Guinot wrote:
>
On Fri, Sep 18, 2020 at 07:14:05PM +0200, Marek Behun wrote:
> On Fri, 18 Sep 2020 15:02:06 +0200
> Simon Guinot wrote:
>
> > On Thu, Sep 17, 2020 at 01:16:50AM +0200, Marek Behún wrote:
> >
> > Hi Marek,
> >
> > > By using struct led_init_dat
On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> They are not used since commit e4ff67513096 ("ipvs: add
> sync_maxlen parameter for the sync daemon")
>
> Signed-off-by: YueHaibing
Thanks, this look good to me.
Acked-by: Simon Horman
Pablo, please con
So that's why I am complaining right now :) If it is
not too much trouble I'd like to keep platform data support in this
driver.
Thanks in advance.
Simon
> of this driver is via device tree, refactor the code to work with
> device tree only. As Linus Walleij wrote, the device tree should b
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote:
> fallthrough to a separate case/default label break; isn't very readable.
>
> Convert pseudo-keyword fallthrough; statements to a simple break; when
> the next label is case or default and the only statement in the next
> label block
Hi Wang,
On Wed, Sep 09, 2020 at 08:19:21PM +0800, Wang Qing wrote:
> Change the comment typo: "direcly" -> "directly".
>
> Signed-off-by: Wang Qing
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
git log tells me that the
Hi Wang,
On Wed, Sep 09, 2020 at 08:12:44PM +0800, Wang Qing wrote:
> Change the comment typo: "direcly" -> "directly".
>
> Signed-off-by: Wang Qing
git log tells me that the correct prefix for this patch
is "netfilter: conntrack:" rather than "net/netfilter:"
Probably this patch is
On Tue, Sep 08, 2020 at 10:04:08AM +1200, Paul Davey wrote:
> Insert the full 16 bit VIF ID into ipmr Netlink cache reports.
>
> The VIF_ID attribute has 32 bits of space so can store the full VIF ID
> extracted from the high and low byte fields in the igmpmsg.
>
> Signed-off-by: Paul Davey
>
/message/37078754/
Cheers,
Simon.
PS. Have a Mojo SDI inbound, will confirm when it arrives.
On Tuesday, September 1, 2020 3:26 PM, Daniel Vetter wrote:
> On Tue, Sep 01, 2020 at 08:57:37AM +0000, Simon Ser wrote:
>
> > On Monday, August 31, 2020 3:48 PM, Ville Syrjälä
> > ville.syrj...@linux.intel.com wrote:
> >
> > > > > It doesn't seem l
On Monday, August 31, 2020 3:48 PM, Ville Syrjälä
wrote:
> > > It doesn't seem like this IGT test's goal is to exercise support for
> > > gamma LUTs. Does the test just tries to reset the gamma LUT to linear?
> > > If so, I think the IGT test should be fixed to ignore "I don't support
> > >
On Saturday, August 29, 2020 4:06 PM, Sidong Yang wrote:
> Currently vkms module doesn't support gamma function for userspace. so igt
> subtests in kms_plane(pixel-format-pipe-A-plan) failed for calling
> drmModeCrtcSetGamma().
It doesn't seem like this IGT test's goal is to exercise support
ned-off-by: Romain Perier
> Signed-off-by: Allen Pais
Reviewed-by: Simon Horman
But:
This series should be targeted at net-next, and thus have net-next in its
subject
[PATCH net-next x/y] ...
And it should be posted when net-next is open: it is currently closed.
http://v
Anastasov
Pablo, could you consider this for nf-next or should we repost when
net-next re-opens?
Reviewed-by: Simon Horman
On 2020-07-17 10:47, Álvaro Fernández Rojas wrote:
Add BCM63xx USBH PHY driver for BMIPS.
v7: remove Simon from authors and introduce changes suggested by Rob:
I asked you to remove my email address from the source code. All you've
done is update it. I don't want spam. I know the address
g that their
Linux support is better, especially if specific chipsets are known to
have issues...
--
Simon Arlott
On 2020-07-15 14:39, Álvaro Fernández Rojas wrote:
Hello Simon,
This is based on your work:
https://github.com/nomis/linux/commit/c4c55b603a78e2732044a833e248c1a1087e7053
https://github.com/nomis/linux/commit/f153a58b9e6f88e72c3ef34dc076118f8b3ade5b
Ok, it has been a long time and I couldn't
On 2020-07-15 14:18, Álvaro Fernández Rojas wrote:
Add BCM63xx USBH PHY driver for BMIPS.
Signed-off-by: Álvaro Fernández Rojas
---
...
+MODULE_DESCRIPTION("BCM63xx USBH PHY driver");
+MODULE_AUTHOR("Álvaro Fernández Rojas ");
+MODULE_AUTHOR("Simon Arlott ");
e.
Signed-off-by: Simon Arlott
Cc: Park Ju Hyung
Cc: sta...@vger.kernel.org
Fixes: ca6bfcb2f6d9 ("libata: Enable queued TRIM for Samsung SSD 860")
---
drivers/ata/libata-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.
-3eefc8c17801@0882a8b5-c6c3-11e9-b005-00805fc181fe/
--
Simon Arlott
Thanks for the update!
The driver should also disallow importing a AMLOGIC_FBC_LAYOUT_SCATTER
DMA-BUF from another device, but I guess this is clear enough ("not
transferrable between Amlogic SoCs").
>From a user-space PoV:
Acked-by: Simon Ser
Fixed 5 WARNINGs of Block comments use * on subsequent lines.
Signed-off-by: Simon Fong
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 62 +++
1 file changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
b/drivers/staging
Fixed a CHECK of Lines should not end with a '('.
Signed-off-by: Simon Fong
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index
This patchset fixed CHECK and WARNINGs of coding style.
Simon Fong (2):
staging: rtl8188eu: Fix CHECK of coding style
staging: rtl8188eu: Fix WARNINGs of Block comments
drivers/staging/rtl8188eu/core/rtw_recv.c | 7 ++-
drivers/staging/rtl8188eu/core/rtw_xmit.c | 62
On Thursday, July 2, 2020 9:47 AM, Neil Armstrong
wrote:
> Finally is also adds the Scatter Memory layout, meaning the header contains
> IOMMU
> references to the compressed frames content to optimize memory access
> and layout.
>
> In this mode, only the header memory address is needed, thus
:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Reviewed-by: Simon Horman
Fixed a WARNING of Block comments use * on subsequent lines.
Signed-off-by: Simon Fong
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging/rtl8188eu/core
for power off if the other reboot methods
fail.
It is necessary to re-order the processing of DMI checks because this quirk
must apply even if a reboot= command line parameter is used as that's the
only way to specify a PCI mode reboot.
Signed-off-by: Simon Arlott
---
Previous patches to make scsi/sd
s behaviour if "c" was used.
Signed-off-by: Simon Arlott
---
Previous patches to make scsi/sd stop before a reboot:
https://lore.kernel.org/lkml/499138c8-b6d5-ef4a-2780-4f750ed337d3@0882a8b5-c6c3-11e9-b005-00805fc181fe/
https://lore.kernel.org/lkml/e726ffd8-8897-4a79-c3d6
ter that can be used to control
the shutdown behaviour of disks before a reboot. The default will be
the existing behaviour (disks are not stopped).
sd_mod.stop_before_reboot=
0 = disabled (default)
1 = enabled
The behaviour on shutdown is unchanged: all disks are unconditionally
stopped.
my case none of the SSDs are recording unexpected power loss if they
are stopped before the reboot, but the reboot won't necessarily be
instantaneous after the last stop command returns.
--
Simon Arlott
On 19/06/2020 00:31, Damien Le Moal wrote:
> On 2020/06/18 21:26, Simon Arlott wrote:
>> I haven't verified it, but the BIOS leaves the power off for several
>> seconds which should be long enough for the HDDs to spin down.
>>
>> I'm less concerned about those suddenl
hange the patch so that it doesn't distinguish between types of
disks.
The default will have to be the existing behaviour (don't stop disks)
because most reboots shouldn't result in a loss of power.
--
Simon Arlott
Hi Nicolas,
On Wed, 17 Jun 2020 at 13:15, Nicolas Saenz Julienne
wrote:
>
> On Tue, 2020-06-16 at 17:31 -0600, Simon Glass wrote:
> > Hi Nicolas,
> >
> > On Tue, 16 Jun 2020 at 08:09, Nicolas Saenz Julienne
> > wrote:
> > > On Tue, 2020-06-16 at 07:
| 3 ++-
> 25 files changed, 60 insertions(+), 50 deletions(-)
Netronome portion:
Reviewed-by: Simon Horman
On 18/06/2020 08:21, Christoph Hellwig wrote:
> On Wed, Jun 17, 2020 at 07:49:57PM +0100, Simon Arlott wrote:
>> Avoiding a stop of the disk on a reboot is appropriate for HDDs because
>> they're likely to continue to be powered (and should not be told to spin
>> down
On 18/06/2020 09:36, Damien Le Moal wrote:
> On 2020/06/18 3:50, Simon Arlott wrote:
>> I need to use "reboot=p" on my desktop because one of the PCIe devices
>> does not appear after a warm boot. This results in a very cold boot
>> because the BIOS turns the PSU
On 17/06/2020 20:19, Bart Van Assche wrote:
> On 2020-06-17 11:49, Simon Arlott wrote:
>> @@ -3576,9 +3582,19 @@ static void sd_shutdown(struct device *dev)
>> sd_sync_cache(sdkp, NULL);
>> }
>>
>> -if (system_state != SYSTEM_RESTART &
loss to corrupt data depending
on the SSD model/firmware.
Cc: sta...@vger.kernel.org
Signed-off-by: Simon Arlott
---
Documentation/scsi/scsi-parameters.rst | 7 +++
drivers/scsi/sd.c | 22 +++---
2 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/Doc
Hi Nicolas,
On Tue, 16 Jun 2020 at 08:09, Nicolas Saenz Julienne
wrote:
>
> On Tue, 2020-06-16 at 07:43 -0600, Simon Glass wrote:
> > Hi Nicolas,
> >
> > On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne
> > wrote:
> > > There is no distinction
gt; 1 file changed, 14 insertions(+), 1 deletion(-)
Can you update the tests to handle this case please?
Regards,
Simon
On Mon, Jun 15, 2020 at 07:13:01PM -0700, Xidong Wang wrote:
> From: xidongwang
>
> The stack object “zone_limit” has 3 members. In function
> ovs_ct_limit_get_default_limit(), the member "count" is
> not initialized and sent out via “nla_put_nohdr”.
Hi Xidong,
thanks for your patch.
It
1 - 100 of 5119 matches
Mail list logo
