Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[David Miller]

From: Henrik Austad 
Date: Tue, 17 Oct 2017 12:10:10 +0200

> In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
> to find the correct tc instead of dev->tc_to_txq[]
> 
> However, when mqprio is compiled as a module, it cannot resolve the
> symbol, leading to this error:
> 
>  ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
> 
> This adds an EXPORT_SYMBOL() since the other user in the kernel
> (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> sysfs-callback.
> 
> Cc: Alexander Duyck 
> Cc: Jesus Sanchez-Palencia 
> Cc: David S. Miller 
> Signed-off-by: Henrik Austad 

Applied, thanks.

Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[David Miller]

From: Henrik Austad 
Date: Tue, 17 Oct 2017 12:10:10 +0200

> In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
> to find the correct tc instead of dev->tc_to_txq[]
> 
> However, when mqprio is compiled as a module, it cannot resolve the
> symbol, leading to this error:
> 
>  ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
> 
> This adds an EXPORT_SYMBOL() since the other user in the kernel
> (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> sysfs-callback.
> 
> Cc: Alexander Duyck 
> Cc: Jesus Sanchez-Palencia 
> Cc: David S. Miller 
> Signed-off-by: Henrik Austad 

Applied, thanks.

RE: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[Duyck, Alexander H]

> -Original Message-
> From: Eric Dumazet [mailto:eduma...@google.com]
> Sent: Tuesday, October 17, 2017 4:21 AM
> To: Henrik Austad 
> Cc: netdev ; David S . Miller
> ; Daniel Borkmann ; David
> Ahern ; Duyck, Alexander H
> ; Willem de Bruijn ;
> John Fastabend ; tcharding ; LKML
> ; Henrik Austad ; Sanchez-
> Palencia, Jesus 
> Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to
> compile as module
> 
> On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad  wrote:
> > In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> > traffic classes and misc IDs") sch_mqprio started using
> > netdev_txq_to_tc to find the correct tc instead of dev->tc_to_txq[]
> >
> > However, when mqprio is compiled as a module, it cannot resolve the
> > symbol, leading to this error:
> >
> >  ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
> >
> > This adds an EXPORT_SYMBOL() since the other user in the kernel
> > (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> > sysfs-callback.
> >
> > Cc: Alexander Duyck 
> > Cc: Jesus Sanchez-Palencia 
> > Cc: David S. Miller 
> > Signed-off-by: Henrik Austad 
> 
> 
> Reviewed-by: Eric Dumazet 

This is identical to a patch I submitted yesterday when I got the report from 
the kbuild robot. I would say your description looks much better than mine 
though so I would be good with dropping my patch in favor of this one.

Acked-by: Alexander Duyck 

RE: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[Duyck, Alexander H]

> -Original Message-
> From: Eric Dumazet [mailto:eduma...@google.com]
> Sent: Tuesday, October 17, 2017 4:21 AM
> To: Henrik Austad 
> Cc: netdev ; David S . Miller
> ; Daniel Borkmann ; David
> Ahern ; Duyck, Alexander H
> ; Willem de Bruijn ;
> John Fastabend ; tcharding ; LKML
> ; Henrik Austad ; Sanchez-
> Palencia, Jesus 
> Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to
> compile as module
> 
> On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad  wrote:
> > In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> > traffic classes and misc IDs") sch_mqprio started using
> > netdev_txq_to_tc to find the correct tc instead of dev->tc_to_txq[]
> >
> > However, when mqprio is compiled as a module, it cannot resolve the
> > symbol, leading to this error:
> >
> >  ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
> >
> > This adds an EXPORT_SYMBOL() since the other user in the kernel
> > (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> > sysfs-callback.
> >
> > Cc: Alexander Duyck 
> > Cc: Jesus Sanchez-Palencia 
> > Cc: David S. Miller 
> > Signed-off-by: Henrik Austad 
> 
> 
> Reviewed-by: Eric Dumazet 

This is identical to a patch I submitted yesterday when I got the report from 
the kbuild robot. I would say your description looks much better than mine 
though so I would be good with dropping my patch in favor of this one.

Acked-by: Alexander Duyck 

Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[Eric Dumazet]

On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad  wrote:
> In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
> to find the correct tc instead of dev->tc_to_txq[]
>
> However, when mqprio is compiled as a module, it cannot resolve the
> symbol, leading to this error:
>
>  ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
>
> This adds an EXPORT_SYMBOL() since the other user in the kernel
> (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> sysfs-callback.
>
> Cc: Alexander Duyck 
> Cc: Jesus Sanchez-Palencia 
> Cc: David S. Miller 
> Signed-off-by: Henrik Austad 


Reviewed-by: Eric Dumazet 

Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[Eric Dumazet]

On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad  wrote:
> In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
> to find the correct tc instead of dev->tc_to_txq[]
>
> However, when mqprio is compiled as a module, it cannot resolve the
> symbol, leading to this error:
>
>  ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
>
> This adds an EXPORT_SYMBOL() since the other user in the kernel
> (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> sysfs-callback.
>
> Cc: Alexander Duyck 
> Cc: Jesus Sanchez-Palencia 
> Cc: David S. Miller 
> Signed-off-by: Henrik Austad 


Reviewed-by: Eric Dumazet 

[PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[Henrik Austad]

In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
to find the correct tc instead of dev->tc_to_txq[]

However, when mqprio is compiled as a module, it cannot resolve the
symbol, leading to this error:

 ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!

This adds an EXPORT_SYMBOL() since the other user in the kernel
(netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
sysfs-callback.

Cc: Alexander Duyck 
Cc: Jesus Sanchez-Palencia 
Cc: David S. Miller 
Signed-off-by: Henrik Austad 
---
 net/core/dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/dev.c b/net/core/dev.c
index fcddccb..d2b20e7 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2040,6 +2040,7 @@ int netdev_txq_to_tc(struct net_device *dev, unsigned int 
txq)
 
return 0;
 }
+EXPORT_SYMBOL(netdev_txq_to_tc);
 
 #ifdef CONFIG_XPS
 static DEFINE_MUTEX(xps_map_mutex);
-- 
2.7.4

[PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[Henrik Austad]

In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
traffic classes and misc IDs") sch_mqprio started using netdev_txq_to_tc
to find the correct tc instead of dev->tc_to_txq[]

However, when mqprio is compiled as a module, it cannot resolve the
symbol, leading to this error:

 ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!

This adds an EXPORT_SYMBOL() since the other user in the kernel
(netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
sysfs-callback.

Cc: Alexander Duyck 
Cc: Jesus Sanchez-Palencia 
Cc: David S. Miller 
Signed-off-by: Henrik Austad 
---
 net/core/dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/dev.c b/net/core/dev.c
index fcddccb..d2b20e7 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2040,6 +2040,7 @@ int netdev_txq_to_tc(struct net_device *dev, unsigned int 
txq)
 
return 0;
 }
+EXPORT_SYMBOL(netdev_txq_to_tc);
 
 #ifdef CONFIG_XPS
 static DEFINE_MUTEX(xps_map_mutex);
-- 
2.7.4