Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Katsuhiro Suzuki]

Hi Philipp,

On 2017年08月10日 19:37, Philipp Zabel wrote:

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

Add a reset line for analog signal amplifier core (ADAMV) on
UniPhier LD11/LD20 SoCs.


Signed-off-by: Katsuhiro Suzuki 

---
  drivers/reset/reset-uniphier.c | 15 +++
  1 file changed, 15 insertions(+)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index f60c137c17cb..cda4a78a58e2 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
uniphier_pro4_peri_reset_data[] = {

UNIPHIER_RESET_END,

  };
  
+/* Analog signal amplifiers reset data */

+static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

+   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
+   UNIPHIER_RESET_END,

+};
+
  /* core implementaton */
  struct uniphier_reset_priv {

struct reset_controller_dev rcdev;

@@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {

.compatible = "socionext,uniphier-ld20-peri-reset",
.data = uniphier_pro4_peri_reset_data,
},
+   /* Analog signal amplifiers reset */
+   {
+   .compatible = "socionext,uniphier-ld11-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
+   {
+   .compatible = "socionext,uniphier-ld20-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
{ /* sentinel */ }

  };
  MODULE_DEVICE_TABLE(of, uniphier_reset_match);


Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.



Thank you, I will add it and send V2 series.


Regards,
--
Katsuhiro Suzuki

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Katsuhiro Suzuki]

Hi Philipp,

On 2017年08月10日 19:37, Philipp Zabel wrote:

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

Add a reset line for analog signal amplifier core (ADAMV) on
UniPhier LD11/LD20 SoCs.


Signed-off-by: Katsuhiro Suzuki 

---
  drivers/reset/reset-uniphier.c | 15 +++
  1 file changed, 15 insertions(+)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index f60c137c17cb..cda4a78a58e2 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
uniphier_pro4_peri_reset_data[] = {

UNIPHIER_RESET_END,

  };
  
+/* Analog signal amplifiers reset data */

+static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

+   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
+   UNIPHIER_RESET_END,

+};
+
  /* core implementaton */
  struct uniphier_reset_priv {

struct reset_controller_dev rcdev;

@@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {

.compatible = "socionext,uniphier-ld20-peri-reset",
.data = uniphier_pro4_peri_reset_data,
},
+   /* Analog signal amplifiers reset */
+   {
+   .compatible = "socionext,uniphier-ld11-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
+   {
+   .compatible = "socionext,uniphier-ld20-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
{ /* sentinel */ }

  };
  MODULE_DEVICE_TABLE(of, uniphier_reset_match);


Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.



Thank you, I will add it and send V2 series.


Regards,
--
Katsuhiro Suzuki

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Katsuhiro Suzuki]

Hi Yamada-san,

On 2017年08月10日 20:23, Masahiro Yamada wrote:

Hi.


2017-08-10 20:11 GMT+09:00 Masahiro Yamada :

2017-08-10 19:37 GMT+09:00 Philipp Zabel :

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

Add a reset line for analog signal amplifier core (ADAMV) on
UniPhier LD11/LD20 SoCs.


Signed-off-by: Katsuhiro Suzuki 

---
  drivers/reset/reset-uniphier.c | 15 +++
  1 file changed, 15 insertions(+)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index f60c137c17cb..cda4a78a58e2 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
uniphier_pro4_peri_reset_data[] = {

 UNIPHIER_RESET_END,

  };

+/* Analog signal amplifiers reset data */
+static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

+   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
+   UNIPHIER_RESET_END,

+};



I take back my Acked-by.


The reset line index is independent from others
because this block is a separate instance.

Are you OK with starting from the reset ID 100?


It's my mistake. This ID can start with 0.
I will fix in next V2 series, thank you.

Regards,
--
Katsuhiro Suzuki

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Katsuhiro Suzuki]

Hi Yamada-san,

On 2017年08月10日 20:23, Masahiro Yamada wrote:

Hi.


2017-08-10 20:11 GMT+09:00 Masahiro Yamada :

2017-08-10 19:37 GMT+09:00 Philipp Zabel :

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:

Add a reset line for analog signal amplifier core (ADAMV) on
UniPhier LD11/LD20 SoCs.


Signed-off-by: Katsuhiro Suzuki 

---
  drivers/reset/reset-uniphier.c | 15 +++
  1 file changed, 15 insertions(+)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index f60c137c17cb..cda4a78a58e2 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
uniphier_pro4_peri_reset_data[] = {

 UNIPHIER_RESET_END,

  };

+/* Analog signal amplifiers reset data */
+static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {

+   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
+   UNIPHIER_RESET_END,

+};



I take back my Acked-by.


The reset line index is independent from others
because this block is a separate instance.

Are you OK with starting from the reset ID 100?


It's my mistake. This ID can start with 0.
I will fix in next V2 series, thank you.

Regards,
--
Katsuhiro Suzuki

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Masahiro Yamada]

Hi.


2017-08-10 20:11 GMT+09:00 Masahiro Yamada :
> 2017-08-10 19:37 GMT+09:00 Philipp Zabel :
>> Hi Katsuhiro,
>>
>> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
>>> Add a reset line for analog signal amplifier core (ADAMV) on
>>> UniPhier LD11/LD20 SoCs.
>>>
>>> > Signed-off-by: Katsuhiro Suzuki 
>>> ---
>>>  drivers/reset/reset-uniphier.c | 15 +++
>>>  1 file changed, 15 insertions(+)
>>>
>>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
>>> index f60c137c17cb..cda4a78a58e2 100644
>>> --- a/drivers/reset/reset-uniphier.c
>>> +++ b/drivers/reset/reset-uniphier.c
>>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
>>> uniphier_pro4_peri_reset_data[] = {
>>> > UNIPHIER_RESET_END,
>>>  };
>>>
>>> +/* Analog signal amplifiers reset data */
>>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = 
>>> {
>>> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
>>> > +   UNIPHIER_RESET_END,
>>> +};


I take back my Acked-by.


The reset line index is independent from others
because this block is a separate instance.

Are you OK with starting from the reset ID 100?





-- 
Best Regards
Masahiro Yamada

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Masahiro Yamada]

Hi.


2017-08-10 20:11 GMT+09:00 Masahiro Yamada :
> 2017-08-10 19:37 GMT+09:00 Philipp Zabel :
>> Hi Katsuhiro,
>>
>> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
>>> Add a reset line for analog signal amplifier core (ADAMV) on
>>> UniPhier LD11/LD20 SoCs.
>>>
>>> > Signed-off-by: Katsuhiro Suzuki 
>>> ---
>>>  drivers/reset/reset-uniphier.c | 15 +++
>>>  1 file changed, 15 insertions(+)
>>>
>>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
>>> index f60c137c17cb..cda4a78a58e2 100644
>>> --- a/drivers/reset/reset-uniphier.c
>>> +++ b/drivers/reset/reset-uniphier.c
>>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
>>> uniphier_pro4_peri_reset_data[] = {
>>> > UNIPHIER_RESET_END,
>>>  };
>>>
>>> +/* Analog signal amplifiers reset data */
>>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = 
>>> {
>>> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
>>> > +   UNIPHIER_RESET_END,
>>> +};


I take back my Acked-by.


The reset line index is independent from others
because this block is a separate instance.

Are you OK with starting from the reset ID 100?





-- 
Best Regards
Masahiro Yamada

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Masahiro Yamada]

2017-08-10 19:37 GMT+09:00 Philipp Zabel :
> Hi Katsuhiro,
>
> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
>> Add a reset line for analog signal amplifier core (ADAMV) on
>> UniPhier LD11/LD20 SoCs.
>>
>> > Signed-off-by: Katsuhiro Suzuki 
>> ---
>>  drivers/reset/reset-uniphier.c | 15 +++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
>> index f60c137c17cb..cda4a78a58e2 100644
>> --- a/drivers/reset/reset-uniphier.c
>> +++ b/drivers/reset/reset-uniphier.c
>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
>> uniphier_pro4_peri_reset_data[] = {
>> > UNIPHIER_RESET_END,
>>  };
>>
>> +/* Analog signal amplifiers reset data */
>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
>> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
>> > +   UNIPHIER_RESET_END,
>> +};
>> +
>>  /* core implementaton */
>>  struct uniphier_reset_priv {
>> > struct reset_controller_dev rcdev;
>> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] 
>> = {
>> > .compatible = "socionext,uniphier-ld20-peri-reset",
>> > .data = uniphier_pro4_peri_reset_data,
>> > },
>> > +   /* Analog signal amplifiers reset */
>> > +   {
>> > +   .compatible = "socionext,uniphier-ld11-adamv-reset",
>> > +   .data = uniphier_ld11_adamv_reset_data,
>> > +   },
>> > +   {
>> > +   .compatible = "socionext,uniphier-ld20-adamv-reset",
>> > +   .data = uniphier_ld11_adamv_reset_data,
>> > +   },
>> > { /* sentinel */ }
>>  };
>>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);
>
> Please add a patch to describe the new compatible values in
> Documentation/devicetree/bindings/reset/uniphier-reset.txt.
>

The code change is OK with me.

Assuming you will update the binding,

Acked-by: Masahiro Yamada 





-- 
Best Regards
Masahiro Yamada

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Masahiro Yamada]

2017-08-10 19:37 GMT+09:00 Philipp Zabel :
> Hi Katsuhiro,
>
> On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
>> Add a reset line for analog signal amplifier core (ADAMV) on
>> UniPhier LD11/LD20 SoCs.
>>
>> > Signed-off-by: Katsuhiro Suzuki 
>> ---
>>  drivers/reset/reset-uniphier.c | 15 +++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
>> index f60c137c17cb..cda4a78a58e2 100644
>> --- a/drivers/reset/reset-uniphier.c
>> +++ b/drivers/reset/reset-uniphier.c
>> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
>> uniphier_pro4_peri_reset_data[] = {
>> > UNIPHIER_RESET_END,
>>  };
>>
>> +/* Analog signal amplifiers reset data */
>> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
>> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
>> > +   UNIPHIER_RESET_END,
>> +};
>> +
>>  /* core implementaton */
>>  struct uniphier_reset_priv {
>> > struct reset_controller_dev rcdev;
>> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] 
>> = {
>> > .compatible = "socionext,uniphier-ld20-peri-reset",
>> > .data = uniphier_pro4_peri_reset_data,
>> > },
>> > +   /* Analog signal amplifiers reset */
>> > +   {
>> > +   .compatible = "socionext,uniphier-ld11-adamv-reset",
>> > +   .data = uniphier_ld11_adamv_reset_data,
>> > +   },
>> > +   {
>> > +   .compatible = "socionext,uniphier-ld20-adamv-reset",
>> > +   .data = uniphier_ld11_adamv_reset_data,
>> > +   },
>> > { /* sentinel */ }
>>  };
>>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);
>
> Please add a patch to describe the new compatible values in
> Documentation/devicetree/bindings/reset/uniphier-reset.txt.
>

The code change is OK with me.

Assuming you will update the binding,

Acked-by: Masahiro Yamada 





-- 
Best Regards
Masahiro Yamada

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Philipp Zabel]

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
> Add a reset line for analog signal amplifier core (ADAMV) on
> UniPhier LD11/LD20 SoCs.
> 
> > Signed-off-by: Katsuhiro Suzuki 
> ---
>  drivers/reset/reset-uniphier.c | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index f60c137c17cb..cda4a78a58e2 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
> uniphier_pro4_peri_reset_data[] = {
> >     UNIPHIER_RESET_END,
>  };
>  
> +/* Analog signal amplifiers reset data */
> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
> > +   UNIPHIER_RESET_END,
> +};
> +
>  /* core implementaton */
>  struct uniphier_reset_priv {
> >     struct reset_controller_dev rcdev;
> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] 
> = {
> >     .compatible = "socionext,uniphier-ld20-peri-reset",
> >     .data = uniphier_pro4_peri_reset_data,
> >     },
> > +   /* Analog signal amplifiers reset */
> > +   {
> > +   .compatible = "socionext,uniphier-ld11-adamv-reset",
> > +   .data = uniphier_ld11_adamv_reset_data,
> > +   },
> > +   {
> > +   .compatible = "socionext,uniphier-ld20-adamv-reset",
> > +   .data = uniphier_ld11_adamv_reset_data,
> > +   },
> >     { /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);

Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.

regards
Philipp

Re: [PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Philipp Zabel]

Hi Katsuhiro,

On Thu, 2017-08-10 at 16:27 +0900, Katsuhiro Suzuki wrote:
> Add a reset line for analog signal amplifier core (ADAMV) on
> UniPhier LD11/LD20 SoCs.
> 
> > Signed-off-by: Katsuhiro Suzuki 
> ---
>  drivers/reset/reset-uniphier.c | 15 +++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index f60c137c17cb..cda4a78a58e2 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
> uniphier_pro4_peri_reset_data[] = {
> >     UNIPHIER_RESET_END,
>  };
>  
> +/* Analog signal amplifiers reset data */
> +static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
> > +   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
> > +   UNIPHIER_RESET_END,
> +};
> +
>  /* core implementaton */
>  struct uniphier_reset_priv {
> >     struct reset_controller_dev rcdev;
> @@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] 
> = {
> >     .compatible = "socionext,uniphier-ld20-peri-reset",
> >     .data = uniphier_pro4_peri_reset_data,
> >     },
> > +   /* Analog signal amplifiers reset */
> > +   {
> > +   .compatible = "socionext,uniphier-ld11-adamv-reset",
> > +   .data = uniphier_ld11_adamv_reset_data,
> > +   },
> > +   {
> > +   .compatible = "socionext,uniphier-ld20-adamv-reset",
> > +   .data = uniphier_ld11_adamv_reset_data,
> > +   },
> >     { /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, uniphier_reset_match);

Please add a patch to describe the new compatible values in
Documentation/devicetree/bindings/reset/uniphier-reset.txt.

regards
Philipp

[PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Katsuhiro Suzuki]

Add a reset line for analog signal amplifier core (ADAMV) on
UniPhier LD11/LD20 SoCs.

Signed-off-by: Katsuhiro Suzuki 
---
 drivers/reset/reset-uniphier.c | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index f60c137c17cb..cda4a78a58e2 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
uniphier_pro4_peri_reset_data[] = {
UNIPHIER_RESET_END,
 };
 
+/* Analog signal amplifiers reset data */
+static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
+   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
+   UNIPHIER_RESET_END,
+};
+
 /* core implementaton */
 struct uniphier_reset_priv {
struct reset_controller_dev rcdev;
@@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {
.compatible = "socionext,uniphier-ld20-peri-reset",
.data = uniphier_pro4_peri_reset_data,
},
+   /* Analog signal amplifiers reset */
+   {
+   .compatible = "socionext,uniphier-ld11-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
+   {
+   .compatible = "socionext,uniphier-ld20-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, uniphier_reset_match);
-- 
2.13.2

[PATCH 3/3] reset: uniphier: add analog amplifiers reset control

[Katsuhiro Suzuki]

Add a reset line for analog signal amplifier core (ADAMV) on
UniPhier LD11/LD20 SoCs.

Signed-off-by: Katsuhiro Suzuki 
---
 drivers/reset/reset-uniphier.c | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
index f60c137c17cb..cda4a78a58e2 100644
--- a/drivers/reset/reset-uniphier.c
+++ b/drivers/reset/reset-uniphier.c
@@ -196,6 +196,12 @@ static const struct uniphier_reset_data 
uniphier_pro4_peri_reset_data[] = {
UNIPHIER_RESET_END,
 };
 
+/* Analog signal amplifiers reset data */
+static const struct uniphier_reset_data uniphier_ld11_adamv_reset_data[] = {
+   UNIPHIER_RESETX(100, 0x10, 6), /* EVEA */
+   UNIPHIER_RESET_END,
+};
+
 /* core implementaton */
 struct uniphier_reset_priv {
struct reset_controller_dev rcdev;
@@ -415,6 +421,15 @@ static const struct of_device_id uniphier_reset_match[] = {
.compatible = "socionext,uniphier-ld20-peri-reset",
.data = uniphier_pro4_peri_reset_data,
},
+   /* Analog signal amplifiers reset */
+   {
+   .compatible = "socionext,uniphier-ld11-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
+   {
+   .compatible = "socionext,uniphier-ld20-adamv-reset",
+   .data = uniphier_ld11_adamv_reset_data,
+   },
{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, uniphier_reset_match);
-- 
2.13.2