Re: [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements
On Mon, Apr 05, 2021 at 12:53:38PM +0200, Greg KH wrote: > On Mon, Apr 05, 2021 at 07:50:00AM -0300, Luiz Sampaio wrote: > > The following patches aim to make a user able to calibrate the current > > measurement of the DS2438. This chip uses a offset register in page1, which > > is added to the current register to give the user the current measurement. > > If this value is wrong, the user will get an offset current value, even if > > the current is zero, for instance. This patch gives support for reading the > > page1 registers (including the offset register) and for writing to the > > offset register. The DS2438 datasheet shows a calibration routine, and with > > this patch, the user can do this quickly by writing the correct value to > > the offset register. This patch was tested on real hardware using a power > > supply and an electronic load. > > Please help to review this series of patches. > > Please linewrap your text here :( > Hello! Thanks for the review! I'm sorry about this again, I did it for my patches but forgot the cover letter. Won't repeat!
Re: [PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements
On Mon, Apr 05, 2021 at 07:50:00AM -0300, Luiz Sampaio wrote: > The following patches aim to make a user able to calibrate the current > measurement of the DS2438. This chip uses a offset register in page1, which > is added to the current register to give the user the current measurement. If > this value is wrong, the user will get an offset current value, even if the > current is zero, for instance. This patch gives support for reading the page1 > registers (including the offset register) and for writing to the offset > register. The DS2438 datasheet shows a calibration routine, and with this > patch, the user can do this quickly by writing the correct value to the > offset register. This patch was tested on real hardware using a power supply > and an electronic load. > Please help to review this series of patches. Please linewrap your text here :(
[PATCH v4 0/9] w1: ds2438: adding support for calibration of current measurements
The following patches aim to make a user able to calibrate the current measurement of the DS2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if the current is zero, for instance. This patch gives support for reading the page1 registers (including the offset register) and for writing to the offset register. The DS2438 datasheet shows a calibration routine, and with this patch, the user can do this quickly by writing the correct value to the offset register. This patch was tested on real hardware using a power supply and an electronic load. Please help to review this series of patches. Best regards! Sampaio --- Changes in v4: - Fixing different patches with identical subject lines as requested Changes in v3: - I accidentally added a wrong line that would not compile. I'm sorry. Fixed it. Changes in v2: - Using git send-email to send the patches - Adding documentation as requested - Separating the coding style changes in different patches as requested Luiz Sampaio (9): w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixed a coding style issue w1: ds2438: fixing bug that would always get page0 w1: ds2438: adding support for reading page1 w1: ds2438: support for writing to offset register Documentation/w1/slaves/w1_ds2438.rst | 19 +++- drivers/w1/slaves/w1_ds2438.c | 122 ++ 2 files changed, 124 insertions(+), 17 deletions(-) -- 2.30.1
